subject:"RKWard is in kdereview"

Re: RKWard is in kdereview - again

2023-07-04 Thread Jonathan Riddell

I've created an issue for the kdereview process

https://invent.kde.org/education/rkward/-/issues/23

Jonathan


On Sat, 26 Mar 2022 at 20:34, Thomas Friedrichsmeier <
thomas.friedrichsme...@kdemail.net> wrote:

> Hi!
>
> KDE.org has been our home for a 7.5(!) years, now (after over a
> decade on sourceforge), but we still haven't left playground... After a
> lot of procrastination on that matter, a previous review failed due to
> lack of time on my part. Sorry! Now, finally, I'd like to ask you to
> start reviewing RKWard for inclusion into exragear / education, once
> more.
>
> RKWard is an easy to use and easily extensible IDE/GUI for R (a
> powerful language and environment for statistical computing, if you
> did not know it, yet). It aims to combine the power of the
> R-language with the ease of use of commercial statistics tools.
>
> RKWard is used productively on Linux/BSD, Mac, and Windows.
>
>
>
> Here's a summary of the critical comments we got in the previous round
> of review (https://marc.info/?l=kde-core-devel&m=153883367600690&w=2):
>
> Albert Astals Cid remarked
> (https://marc.info/?l=kde-core-devel&m=153912336114603&w=2):
>
> > the i18n folder seems like from the past and something you should not
> > need if in kde infrastructure. Could you delete it?
>
> We cannot easily get rid of this, entirely, as we are shipping
> (non-compiled) plugins that keep their message catalogs in relative
> paths, and thus we have to install .mo files to custom locations. Pino
> Toscano has helped to bring this more in line with standard KDE.org
> processes (https://invent.kde.org/education/rkward/-/merge_requests/2).
>
> > Also I'd suggest you compile enabling
> > -DECM_ENABLE_SANITIZERS="address;undefined"
>
> Thanks for the hint, did not know that switch. One effect of this is a
> lot of false positive "runtime errors", when casting a half-destroyed
> QObject* to its original (derived) type, in order to remove it from
> containers (e.g. a QHash of KActionCollection()s). Is there an elegant
> way around this?
>
> > There's a few memory leaks (reported at exit) that you may want to
> > have a look.
>
> I fixed a lot of that, but didn't work out all of them.
>
> > And there's also a few undefined behaviour warnings on exit, you've
> > them marked as "known" things but it'd be good if you could find a way
> > to fix them.
>
> Not quite sure what you were referring to, esp. what I may have marked
> as known behavior. I did fix several quirks at exit since this comment
> (and I keep introducing new ones, all the time).
>
> > Your help menu is for some reason missing the Change Language option,
> > i tried to do it a quick fix but could not, i would appreciate if you
> > could find a way to only define the extra actions and not all of them
> > (like we do for example in okular).
>
> I've added the switch application language option (in Settings rather
> than Help). Our help menu is perhaps more customized than meets the eye
> on first glance. For instance, we have an app-integrated help system
> instead of external handbook (at least as the primary documentation),
> and our bug report dialog is beefed up to include a lot of extra
> information by default (mostly importantly: version of R). I guess it
> would be possible to hack KHelpMenu this way, but at least at some
> point in the past it seemed cleaner to implement "from scratch" (but
> using the default actions, where applicable).
>
>
>
> Comments by Jonathan Riddel
> (https://marc.info/?l=kde-core-devel&m=153916691226377&w=2):
>
> > It installs two desktop files which creates duplicate menu entries
> > /usr/share/applications/org.kde.rkward-open.desktop
> > /usr/share/applications/org.kde.rkward.desktop
>
> Completed following suggestions by Thomas Baumgart and Meik Michalke:
> https://marc.info/?l=kde-core-devel&m=153942961310071&w=2
>
> > The .desktop files call it a "GUI for R" which is not a great
> > description, everything in the menu is a GUI.  I recommend "R
> > Statistical Programming" or "IDE for R" maybe.
>
> Renamed to Statistics with R, following Meik's suggestion
> (https://marc.info/?l=kde-core-devel&m=153942595709279&w=2).
>
> > I tidied up the files with the icon licence as they could easily be
> > lost.
>
> Done by Jonathan.
>
> > It depends on WebKit which is not supported, could this be ported to
> > WebEngine?
>
> Meanwhile, RKWard can be compiled to use QtWebEngine (and this is the
> default), but support for webkit has not been dropped, because MinGW is
> an important platform for us.
>
> > It's uncommon having debian/ packaging directly in the source and
> > there's also debian-official/ which could get confusing and
> > out-of-sync and messy.  I recommend moving them to another archive.
> > Storing the packaging in KDE neon Git would be cool as we already
> > have packaging for all the rest of KDE software.
>
> Meanwhile packaging has been taken over by the debian-qt-kde team
> (thank you so much!). Jonathan himself added RKWard to

Re: RKWard is in kdereview - again

2022-04-27 Thread Thomas Friedrichsmeier

Hi,

On Wed, 27 Apr 2022 16:09:51 +0200
Thierry Thomas  wrote:
> I just upgraded RKWard to 0.7.3 (just locally, not yet in the ports
> tree), and the patch of FindR.cmake is no more necessary.
> 
> It builds and installs clearly, but I noticed 2 problems:
> 
> 1- the tests do not run:
> 
> > source("all_tests.R")  
> Error in source("all_tests.R") : 
>   all_tests.R:6:9: unexpected string constant
> 5: "rkward_application_tests.R"
> 6: "import_export_plugins.R"

yes, sorry. Add a comma behind these two lines (fixed in master,
meanwhile, but did not touch the release for that).

> 2- when executing some analysis, no output can be displayed but the
> following message:
> 
> The url you are trying to open ('data:text/html;charset=UTF-8…) is
> not a local file or the filetype is not supported by RKWard. Do you
> want to open the url in the default application? Could not find any
> application or handler for data:text/html;charset=UTF-8…

Could you detail the steps to reproduce this? Looks like somehow the
mimetype ended up as the url, but I have never seen this, before.

Regards
Thomas


pgp0MkwEknMzR.pgp
Description: OpenPGP digital signature

Re: RKWard is in kdereview - again

2022-04-27 Thread Thierry Thomas

Hello,

Le lun. 28 mars 22 à 16:53:28 +0200, Adriaan de Groot 
 écrivait :

> > RKWard is used productively on Linux/BSD, Mac, and Windows.
> 
> Congratulations! RKWard has been packaged on FreeBSD for a long time already 
> (although it's only at version 0.7.1, not the latest release -- cc'ing the 
> FreeBSD maintainer there).
> 
> On the FreeBSD side there's only two patches in packaging; one missing 
> include 
> (not needed with current git) and a CMake thingy that I don't quite 
> understand 
> (about gfortran). I do notice that there's a FindR.cmake in Cantor, and one 
> in 
> RKWard, and they are somewhat different: perhaps some coordination to make 
> them both do the same (and the right) things?
> 
> [ade]

I just upgraded RKWard to 0.7.3 (just locally, not yet in the ports
tree), and the patch of FindR.cmake is no more necessary.

It builds and installs clearly, but I noticed 2 problems:

1- the tests do not run:

> source("all_tests.R")
Error in source("all_tests.R") : 
  all_tests.R:6:9: unexpected string constant
5: "rkward_application_tests.R"
6: "import_export_plugins.R"

2- when executing some analysis, no output can be displayed but the
following message:

The url you are trying to open ('data:text/html;charset=UTF-8…) is not a local 
file or the filetype is not supported by RKWard. Do you want to open the url in 
the default application?
Could not find any application or handler for data:text/html;charset=UTF-8…

I do not know if this second error is specific for RKWard, or maybe
related to the installation of KDE on my workststion? I tried to play
with the Output Window options, but without success.

Best regards.
-- 
Th. Thomas.


signature.asc
Description: PGP signature

Re: RKWard is in kdereview - again

2022-03-30 Thread Nicolas Fella

On 3/30/22 17:55, Thomas Friedrichsmeier wrote:

An update and some questions:

Am Mon, 28 Mar 2022 15:39:55 +0200
schrieb Nicolas Fella :
[...]

- Consider adding a color scheme selector (KColorSchemeManager) to the
menu. On Windows that gives you dark mode support for free (this only
really works nicely when using Breeze QStyle). See
https://invent.kde.org/utilities/kate/-/blob/master/kate/katemainwindow.cpp#L235

Done that. On my Windows 8.1 VM, I notice some strange behavior:
- By default, Breeze dark is loaded, even though I have not customized
my color settings at all in this VM.

I think I know what's happening there. In
https://invent.kde.org/frameworks/kconfigwidgets/-/blob/master/src/windowsmessagesnotifier.cpp#L30
we query the registry for AppsUseLightTheme, but IIRC that only exists
with Windows 10. With Windows 8 we then get false, causing Breeze Dark
to get used. Should be trivial to fix by passing a different default to
QSettings.

- Using the "Default" color scheme option switches to Breeze classic.
However, this setting is not permanent in that Breeze dark is again
active in the next session.

That would be https://bugs.kde.org/show_bug.cgi?id=452091

- Setting one of the themes explicitly, seems to be saved / loaded,
correctly, though.

Well, that's Windows 8.1, not much worth worrying about, I guess.

What's troubling me more is that QWebEngineView (used, among other
things, for Help->Help on RKWard) does not adapt to the color theme at
all. I tried adding CSS rules (@media (prefers-color-scheme: dark)
{...}), but QWebEngine simply seems to be unaware of the color scheme
in use. Any ideas, what I may be missing?

(Interestingly, KF5WebKit, still in use on MinGW does adjust itself to
the theme.)

No idea about that.

- On Windows the title bar shows a generic icon instead of the RKWard
icon

Fixed.

- Consider publishing RKWard on the Microsoft Store

- Consider publshing RKWard on Flathub

First step:
https://invent.kde.org/packaging/flatpak-kde-applications/-/merge_requests/81

Regards
Thomas

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier

Am Wed, 30 Mar 2022 17:55:12 +0200
schrieb Thomas Friedrichsmeier :
[...]
> What's troubling me more is that QWebEngineView (used, among other
> things, for Help->Help on RKWard) does not adapt to the color theme at
> all. I tried adding CSS rules (@media (prefers-color-scheme: dark)
> {...}), but QWebEngine simply seems to be unaware of the color scheme
> in use. Any ideas, what I may be missing?

For the record, I suppose it's QTBUG-89753 but can be worked around
using some javascript.

Regards
Thomas


pgpvn2gYPz33o.pgp
Description: Digitale Signatur von OpenPGP

Re: RKWard is in kdereview - again

2022-03-30 Thread Thomas Friedrichsmeier

An update and some questions:

Am Mon, 28 Mar 2022 15:39:55 +0200
schrieb Nicolas Fella :
[...]
> - Consider adding a color scheme selector (KColorSchemeManager) to the
> menu. On Windows that gives you dark mode support for free (this only
> really works nicely when using Breeze QStyle). See
> https://invent.kde.org/utilities/kate/-/blob/master/kate/katemainwindow.cpp#L235

Done that. On my Windows 8.1 VM, I notice some strange behavior:
 - By default, Breeze dark is loaded, even though I have not customized
   my color settings at all in this VM.
 - Using the "Default" color scheme option switches to Breeze classic.
   However, this setting is not permanent in that Breeze dark is again
   active in the next session.
 - Setting one of the themes explicitly, seems to be saved / loaded,
   correctly, though.

Well, that's Windows 8.1, not much worth worrying about, I guess.

What's troubling me more is that QWebEngineView (used, among other
things, for Help->Help on RKWard) does not adapt to the color theme at
all. I tried adding CSS rules (@media (prefers-color-scheme: dark)
{...}), but QWebEngine simply seems to be unaware of the color scheme
in use. Any ideas, what I may be missing?

(Interestingly, KF5WebKit, still in use on MinGW does adjust itself to
the theme.)

> - On Windows the title bar shows a generic icon instead of the RKWard
> icon

Fixed.

> - Consider publishing RKWard on the Microsoft Store
> 
> - Consider publshing RKWard on Flathub

First step:
https://invent.kde.org/packaging/flatpak-kde-applications/-/merge_requests/81

Regards
Thomas


pgpxhaPMxwyK1.pgp
Description: Digitale Signatur von OpenPGP

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot

On Monday, 28 March 2022 17:39:17 CEST Thomas Friedrichsmeier wrote:
> On Mon, 28 Mar 2022 17:09:44 +0200
> Nicolas Fella  wrote:
> [...]
> 
> > Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD
> > build fails: https://invent.kde.org/education/rkward/-/jobs/274861,
> > presumably due to having a different tar implementation than Linux.
> 
> Sweet!
> 
> > I'd appreciate if someone could comment/look into that
> 
> Ouch, that issue, again. The option can safely be stripped, but was
> added to make builds reproducible (
> https://invent.kde.org/education/rkward/-/merge_requests/6). I've
> limited that to "Linux" systems, now.

Relevant bits are a bug report asking for the same in ECM:

https://bugs.kde.org/show_bug.cgi?id=443532

The corresponding MR:

https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/238

and associated commentary. Stealing from ECM is encouraged :) 

[ade]

signature.asc
Description: This is a digitally signed message part.

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier

On Mon, 28 Mar 2022 17:09:44 +0200
Nicolas Fella  wrote:
[...]
> Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD
> build fails: https://invent.kde.org/education/rkward/-/jobs/274861,
> presumably due to having a different tar implementation than Linux.

Sweet!

> I'd appreciate if someone could comment/look into that

Ouch, that issue, again. The option can safely be stripped, but was
added to make builds reproducible (
https://invent.kde.org/education/rkward/-/merge_requests/6). I've
limited that to "Linux" systems, now.

Regards
Thomas

pgpEPK2w38lyW.pgp
Description: OpenPGP digital signature

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier

On Mon, 28 Mar 2022 00:09:38 +0200
Albert Astals Cid  wrote:
[...] 
> Results of running clang-tidy with some of my favorite options
> attached.

Thanks!
 
> The first group [bugprone-integer-division] seems an actual bug since 
>double RKGraphicsDeviceFrontendTransmitter::lwdscale = 72/96;
> means lwdscale value is 0

Fixed.

> The second group [bugprone-parent-virtual-call] is worth looking at,
> may be what you want or may not.

None of these caused real misbehavior, but in none of the cases there
was a terribly good reason for writing them, this way, either. Changed.
 
> The third group [modernize-use-bool-literals] is totally just for our
> monkey brains, the compiler doesn't care, so if you don't care either
> it's fine to not change it

Fixed. One was actually a (minor / optimization) bug, where the bool
was meant to be an int.

> The fourth group [performance-unnecessary-value-param] is just about
> adding a few const & to copy less things, mostly it's Qt things that
> are cheap to copy, so you're not going to get much performance, but
> the const & is faster anyway, so why not do it?.

Will do, but deferred for a quiet hour:
https://invent.kde.org/education/rkward/-/issues/9

Regards
Thomas


pgp9ORnxDk8LR.pgp
Description: OpenPGP digital signature

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella


On 3/28/22 16:53, Adriaan de Groot wrote:

On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote:

KDE.org has been our home for a 7.5(!) years, now (after over a
decade on sourceforge), but we still haven't left playground... After a
lot of procrastination on that matter, a previous review failed due to
lack of time on my part. Sorry! Now, finally, I'd like to ask you to
start reviewing RKWard for inclusion into exragear / education, once
more.


...

RKWard is used productively on Linux/BSD, Mac, and Windows.

Congratulations! RKWard has been packaged on FreeBSD for a long time already
(although it's only at version 0.7.1, not the latest release -- cc'ing the
FreeBSD maintainer there).

On the FreeBSD side there's only two patches in packaging; one missing include
(not needed with current git) and a CMake thingy that I don't quite understand
(about gfortran). I do notice that there's a FindR.cmake in Cantor, and one in
RKWard, and they are somewhat different: perhaps some coordination to make
them both do the same (and the right) things?

[ade]


Talking about FreeBSD: I started adding Gitlab CI and the FreeBSD build
fails: https://invent.kde.org/education/rkward/-/jobs/274861, presumably
due to having a different tar implementation than Linux.

I'd appreciate if someone could comment/look into that

Cheers

Nico

Re: RKWard is in kdereview - again

2022-03-28 Thread Thomas Friedrichsmeier

Hi,

On Mon, 28 Mar 2022 15:39:55 +0200
Nicolas Fella  wrote:
> I recently used RKWard for my Master Thesis, cool project!

thanks!

> A couple of observations:
> 
> - CommitPolicy.txt still mentions Phabricator, that should point to
> Gitlab instead

Done.

> - CommitPolicy.txt mentions Ubuntu Trusty as base for requirements,
> that is *ancient* by now, maybe 20.04 would be a more reasonable base?

Done.

> - The repo doesn't have Gitlab CI, that should be added

Yes. Help (or some pointers) on that would be appreciated, though.

> - Optional/nice-to-have: We tend to use SPDX indentifiers for license
> headers these days, maybe think about converting the existing headers

Deferred to the issue list, for now:
https://invent.kde.org/education/rkward/-/issues/8

> - You are using QtScript, which is deprecated. What's your plan for
> that?

I'm aware we'll have to to port to QJSEngine for KF6. I hope to start
looking into that, soon.

https://invent.kde.org/education/rkward/-/issues/6

> - I see you are distributing stable Windows releases, but there are no
> stable build jobs for that on binary-factory.kde.org

Yes, that's rather hackish. Last I asked, I was told to get out of
playground, before we could have separate stable builds (or was that
stable translations, one of these two, anyway). So kdereview is actually
part of the plan to get there.

> - Consider adding links to the Windows releases to the appstream
> metadata. That way they show up on apps.kde.org/rkward. See
> https://invent.kde.org/utilities/kate/-/merge_requests/667 for an
> example.

Thanks for the pointer. Done.

> - On Windows we tend to use the Breeze QStyle since that looks and
> works quite a bit better than the "native" style. See
> https://invent.kde.org/utilities/kate/-/blob/master/kate/main.cpp#L110
> 
> - Consider adding a color scheme selector (KColorSchemeManager) to the
> menu. On Windows that gives you dark mode support for free (this only
> really works nicely when using Breeze QStyle). See
> https://invent.kde.org/utilities/kate/-/blob/master/kate/katemainwindow.cpp#L235
> 
> - On Windows the title bar shows a generic icon instead of the RKWard
> icon

Will look into these, soon.

> - Consider publishing RKWard on the Microsoft Store
> 
> - Consider publshing RKWard on Flathub

Make sense. First step (for the latter) will be to create a flatpak, of
course.

> Feel free to reach out for questions/help with any of this.

Creating a flatpak is one of the things I shied away from looking into
too closely, so far. It does not look to complicated from a first
glance (yet I suppose we will have to include R, too), but I sure
wouldn't mind a volunteer stepping up...

Thanks for all the pointers!

Thomas


pgpsQJJOkYbgE.pgp
Description: OpenPGP digital signature

Re: RKWard is in kdereview - again

2022-03-28 Thread Adriaan de Groot

On Saturday, 26 March 2022 21:34:06 CEST Thomas Friedrichsmeier wrote:
> KDE.org has been our home for a 7.5(!) years, now (after over a
> decade on sourceforge), but we still haven't left playground... After a
> lot of procrastination on that matter, a previous review failed due to
> lack of time on my part. Sorry! Now, finally, I'd like to ask you to
> start reviewing RKWard for inclusion into exragear / education, once
> more.
> 
...
> 
> RKWard is used productively on Linux/BSD, Mac, and Windows.

Congratulations! RKWard has been packaged on FreeBSD for a long time already 
(although it's only at version 0.7.1, not the latest release -- cc'ing the 
FreeBSD maintainer there).

On the FreeBSD side there's only two patches in packaging; one missing include 
(not needed with current git) and a CMake thingy that I don't quite understand 
(about gfortran). I do notice that there's a FindR.cmake in Cantor, and one in 
RKWard, and they are somewhat different: perhaps some coordination to make 
them both do the same (and the right) things?

[ade]

signature.asc
Description: This is a digitally signed message part.

Re: RKWard is in kdereview - again

2022-03-28 Thread Nicolas Fella


Hi,

I recently used RKWard for my Master Thesis, cool project!

A couple of observations:

- CommitPolicy.txt still mentions Phabricator, that should point to
Gitlab instead

- CommitPolicy.txt mentions Ubuntu Trusty as base for requirements, that
is *ancient* by now, maybe 20.04 would be a more reasonable base?

- The repo doesn't have Gitlab CI, that should be added

- Optional/nice-to-have: We tend to use SPDX indentifiers for license
headers these days, maybe think about converting the existing headers

- You are using QtScript, which is deprecated. What's your plan for that?

- I see you are distributing stable Windows releases, but there are no
stable build jobs for that on binary-factory.kde.org

- Consider adding links to the Windows releases to the appstream
metadata. That way they show up on apps.kde.org/rkward. See
https://invent.kde.org/utilities/kate/-/merge_requests/667 for an example.

- On Windows we tend to use the Breeze QStyle since that looks and works
quite a bit better than the "native" style. See
https://invent.kde.org/utilities/kate/-/blob/master/kate/main.cpp#L110

- Consider adding a color scheme selector (KColorSchemeManager) to the
menu. On Windows that gives you dark mode support for free (this only
really works nicely when using Breeze QStyle). See
https://invent.kde.org/utilities/kate/-/blob/master/kate/katemainwindow.cpp#L235

- On Windows the title bar shows a generic icon instead of the RKWard icon

- Consider publishing RKWard on the Microsoft Store

- Consider publshing RKWard on Flathub


Feel free to reach out for questions/help with any of this.

Cheers

Nico

Re: RKWard is in kdereview - again

2022-03-27 Thread Albert Astals Cid

El dilluns, 28 de març de 2022, a les 0:09:38 (CEST), Albert Astals Cid va 
escriure:
> El dissabte, 26 de març de 2022, a les 21:34:06 (CEST), Thomas 
> Friedrichsmeier va escriure:
> > Hi!
> > 
> > KDE.org has been our home for a 7.5(!) years, now (after over a
> > decade on sourceforge), but we still haven't left playground... After a
> > lot of procrastination on that matter, a previous review failed due to
> > lack of time on my part. Sorry! Now, finally, I'd like to ask you to
> > start reviewing RKWard for inclusion into exragear / education, once
> > more.
> > 
> > RKWard is an easy to use and easily extensible IDE/GUI for R (a
> > powerful language and environment for statistical computing, if you
> > did not know it, yet). It aims to combine the power of the
> > R-language with the ease of use of commercial statistics tools.
> > 
> > RKWard is used productively on Linux/BSD, Mac, and Windows.
> > 
> > 
> > 
> > Here's a summary of the critical comments we got in the previous round
> > of review (https://marc.info/?l=kde-core-devel&m=153883367600690&w=2):
> > 
> > Albert Astals Cid remarked
> > (https://marc.info/?l=kde-core-devel&m=153912336114603&w=2):
> > 
> > > the i18n folder seems like from the past and something you should not
> > > need if in kde infrastructure. Could you delete it?
> > 
> > We cannot easily get rid of this, entirely, as we are shipping
> > (non-compiled) plugins that keep their message catalogs in relative
> > paths, and thus we have to install .mo files to custom locations. Pino
> > Toscano has helped to bring this more in line with standard KDE.org
> > processes (https://invent.kde.org/education/rkward/-/merge_requests/2).
> > 
> > > Also I'd suggest you compile enabling
> > > -DECM_ENABLE_SANITIZERS="address;undefined"
> > 
> > Thanks for the hint, did not know that switch. One effect of this is a
> > lot of false positive "runtime errors", when casting a half-destroyed
> > QObject* to its original (derived) type, in order to remove it from
> > containers (e.g. a QHash of KActionCollection()s). Is there an elegant
> > way around this?
> > 
> > > There's a few memory leaks (reported at exit) that you may want to
> > > have a look.
> > 
> > I fixed a lot of that, but didn't work out all of them.
> > 
> > > And there's also a few undefined behaviour warnings on exit, you've
> > > them marked as "known" things but it'd be good if you could find a way
> > > to fix them.
> > 
> > Not quite sure what you were referring to, esp. what I may have marked
> > as known behavior. I did fix several quirks at exit since this comment
> > (and I keep introducing new ones, all the time).
> > 
> > > Your help menu is for some reason missing the Change Language option,
> > > i tried to do it a quick fix but could not, i would appreciate if you
> > > could find a way to only define the extra actions and not all of them
> > > (like we do for example in okular).
> > 
> > I've added the switch application language option (in Settings rather
> > than Help). Our help menu is perhaps more customized than meets the eye
> > on first glance. For instance, we have an app-integrated help system
> > instead of external handbook (at least as the primary documentation),
> > and our bug report dialog is beefed up to include a lot of extra
> > information by default (mostly importantly: version of R). I guess it
> > would be possible to hack KHelpMenu this way, but at least at some
> > point in the past it seemed cleaner to implement "from scratch" (but
> > using the default actions, where applicable).
> > 
> > 
> > 
> > Comments by Jonathan Riddel
> > (https://marc.info/?l=kde-core-devel&m=153916691226377&w=2):
> > 
> > > It installs two desktop files which creates duplicate menu entries
> > > /usr/share/applications/org.kde.rkward-open.desktop
> > > /usr/share/applications/org.kde.rkward.desktop
> > 
> > Completed following suggestions by Thomas Baumgart and Meik Michalke:
> > https://marc.info/?l=kde-core-devel&m=153942961310071&w=2
> > 
> > > The .desktop files call it a "GUI for R" which is not a great
> > > description, everything in the menu is a GUI.  I recommend "R
> > > Statistical Programming" or "IDE for R" maybe.
> > 
> > Renamed to Statistics with R, following Meik's suggestion
> > (https://marc.info/?l=kde-core-devel&m=153942595709279&w=2).
> > 
> > > I tidied up the files with the icon licence as they could easily be
> > > lost.
> > 
> > Done by Jonathan.
> > 
> > > It depends on WebKit which is not supported, could this be ported to
> > > WebEngine?
> > 
> > Meanwhile, RKWard can be compiled to use QtWebEngine (and this is the
> > default), but support for webkit has not been dropped, because MinGW is
> > an important platform for us.
> > 
> > > It's uncommon having debian/ packaging directly in the source and
> > > there's also debian-official/ which could get confusing and
> > > out-of-sync and messy.  I recommend moving them to another archive.
> > > Storing the packaging in KDE neon Gi

Re: RKWard is in kdereview - again

2022-03-27 Thread Albert Astals Cid

El dissabte, 26 de març de 2022, a les 21:34:06 (CEST), Thomas Friedrichsmeier 
va escriure:
> Hi!
> 
> KDE.org has been our home for a 7.5(!) years, now (after over a
> decade on sourceforge), but we still haven't left playground... After a
> lot of procrastination on that matter, a previous review failed due to
> lack of time on my part. Sorry! Now, finally, I'd like to ask you to
> start reviewing RKWard for inclusion into exragear / education, once
> more.
> 
> RKWard is an easy to use and easily extensible IDE/GUI for R (a
> powerful language and environment for statistical computing, if you
> did not know it, yet). It aims to combine the power of the
> R-language with the ease of use of commercial statistics tools.
> 
> RKWard is used productively on Linux/BSD, Mac, and Windows.
> 
> 
> 
> Here's a summary of the critical comments we got in the previous round
> of review (https://marc.info/?l=kde-core-devel&m=153883367600690&w=2):
> 
> Albert Astals Cid remarked
> (https://marc.info/?l=kde-core-devel&m=153912336114603&w=2):
> 
> > the i18n folder seems like from the past and something you should not
> > need if in kde infrastructure. Could you delete it?
> 
> We cannot easily get rid of this, entirely, as we are shipping
> (non-compiled) plugins that keep their message catalogs in relative
> paths, and thus we have to install .mo files to custom locations. Pino
> Toscano has helped to bring this more in line with standard KDE.org
> processes (https://invent.kde.org/education/rkward/-/merge_requests/2).
> 
> > Also I'd suggest you compile enabling
> > -DECM_ENABLE_SANITIZERS="address;undefined"
> 
> Thanks for the hint, did not know that switch. One effect of this is a
> lot of false positive "runtime errors", when casting a half-destroyed
> QObject* to its original (derived) type, in order to remove it from
> containers (e.g. a QHash of KActionCollection()s). Is there an elegant
> way around this?
> 
> > There's a few memory leaks (reported at exit) that you may want to
> > have a look.
> 
> I fixed a lot of that, but didn't work out all of them.
> 
> > And there's also a few undefined behaviour warnings on exit, you've
> > them marked as "known" things but it'd be good if you could find a way
> > to fix them.
> 
> Not quite sure what you were referring to, esp. what I may have marked
> as known behavior. I did fix several quirks at exit since this comment
> (and I keep introducing new ones, all the time).
> 
> > Your help menu is for some reason missing the Change Language option,
> > i tried to do it a quick fix but could not, i would appreciate if you
> > could find a way to only define the extra actions and not all of them
> > (like we do for example in okular).
> 
> I've added the switch application language option (in Settings rather
> than Help). Our help menu is perhaps more customized than meets the eye
> on first glance. For instance, we have an app-integrated help system
> instead of external handbook (at least as the primary documentation),
> and our bug report dialog is beefed up to include a lot of extra
> information by default (mostly importantly: version of R). I guess it
> would be possible to hack KHelpMenu this way, but at least at some
> point in the past it seemed cleaner to implement "from scratch" (but
> using the default actions, where applicable).
> 
> 
> 
> Comments by Jonathan Riddel
> (https://marc.info/?l=kde-core-devel&m=153916691226377&w=2):
> 
> > It installs two desktop files which creates duplicate menu entries
> > /usr/share/applications/org.kde.rkward-open.desktop
> > /usr/share/applications/org.kde.rkward.desktop
> 
> Completed following suggestions by Thomas Baumgart and Meik Michalke:
> https://marc.info/?l=kde-core-devel&m=153942961310071&w=2
> 
> > The .desktop files call it a "GUI for R" which is not a great
> > description, everything in the menu is a GUI.  I recommend "R
> > Statistical Programming" or "IDE for R" maybe.
> 
> Renamed to Statistics with R, following Meik's suggestion
> (https://marc.info/?l=kde-core-devel&m=153942595709279&w=2).
> 
> > I tidied up the files with the icon licence as they could easily be
> > lost.
> 
> Done by Jonathan.
> 
> > It depends on WebKit which is not supported, could this be ported to
> > WebEngine?
> 
> Meanwhile, RKWard can be compiled to use QtWebEngine (and this is the
> default), but support for webkit has not been dropped, because MinGW is
> an important platform for us.
> 
> > It's uncommon having debian/ packaging directly in the source and
> > there's also debian-official/ which could get confusing and
> > out-of-sync and messy.  I recommend moving them to another archive.
> > Storing the packaging in KDE neon Git would be cool as we already
> > have packaging for all the rest of KDE software.
> 
> Meanwhile packaging has been taken over by the debian-qt-kde team
> (thank you so much!). Jonathan himself added RKWard to neon. We still
> have a (basic) debian packaging to support nightly builds in our Ubuntu

RKWard is in kdereview - again

2022-03-26 Thread Thomas Friedrichsmeier

Hi!

KDE.org has been our home for a 7.5(!) years, now (after over a
decade on sourceforge), but we still haven't left playground... After a
lot of procrastination on that matter, a previous review failed due to
lack of time on my part. Sorry! Now, finally, I'd like to ask you to
start reviewing RKWard for inclusion into exragear / education, once
more.

RKWard is an easy to use and easily extensible IDE/GUI for R (a
powerful language and environment for statistical computing, if you
did not know it, yet). It aims to combine the power of the
R-language with the ease of use of commercial statistics tools.

RKWard is used productively on Linux/BSD, Mac, and Windows.



Here's a summary of the critical comments we got in the previous round
of review (https://marc.info/?l=kde-core-devel&m=153883367600690&w=2):

Albert Astals Cid remarked
(https://marc.info/?l=kde-core-devel&m=153912336114603&w=2):

> the i18n folder seems like from the past and something you should not
> need if in kde infrastructure. Could you delete it?

We cannot easily get rid of this, entirely, as we are shipping
(non-compiled) plugins that keep their message catalogs in relative
paths, and thus we have to install .mo files to custom locations. Pino
Toscano has helped to bring this more in line with standard KDE.org
processes (https://invent.kde.org/education/rkward/-/merge_requests/2).

> Also I'd suggest you compile enabling
> -DECM_ENABLE_SANITIZERS="address;undefined"

Thanks for the hint, did not know that switch. One effect of this is a
lot of false positive "runtime errors", when casting a half-destroyed
QObject* to its original (derived) type, in order to remove it from
containers (e.g. a QHash of KActionCollection()s). Is there an elegant
way around this?

> There's a few memory leaks (reported at exit) that you may want to
> have a look.

I fixed a lot of that, but didn't work out all of them.

> And there's also a few undefined behaviour warnings on exit, you've
> them marked as "known" things but it'd be good if you could find a way
> to fix them.

Not quite sure what you were referring to, esp. what I may have marked
as known behavior. I did fix several quirks at exit since this comment
(and I keep introducing new ones, all the time).

> Your help menu is for some reason missing the Change Language option,
> i tried to do it a quick fix but could not, i would appreciate if you
> could find a way to only define the extra actions and not all of them
> (like we do for example in okular).

I've added the switch application language option (in Settings rather
than Help). Our help menu is perhaps more customized than meets the eye
on first glance. For instance, we have an app-integrated help system
instead of external handbook (at least as the primary documentation),
and our bug report dialog is beefed up to include a lot of extra
information by default (mostly importantly: version of R). I guess it
would be possible to hack KHelpMenu this way, but at least at some
point in the past it seemed cleaner to implement "from scratch" (but
using the default actions, where applicable).



Comments by Jonathan Riddel
(https://marc.info/?l=kde-core-devel&m=153916691226377&w=2):

> It installs two desktop files which creates duplicate menu entries
> /usr/share/applications/org.kde.rkward-open.desktop
> /usr/share/applications/org.kde.rkward.desktop

Completed following suggestions by Thomas Baumgart and Meik Michalke:
https://marc.info/?l=kde-core-devel&m=153942961310071&w=2

> The .desktop files call it a "GUI for R" which is not a great
> description, everything in the menu is a GUI.  I recommend "R
> Statistical Programming" or "IDE for R" maybe.

Renamed to Statistics with R, following Meik's suggestion
(https://marc.info/?l=kde-core-devel&m=153942595709279&w=2).

> I tidied up the files with the icon licence as they could easily be
> lost.

Done by Jonathan.

> It depends on WebKit which is not supported, could this be ported to
> WebEngine?

Meanwhile, RKWard can be compiled to use QtWebEngine (and this is the
default), but support for webkit has not been dropped, because MinGW is
an important platform for us.

> It's uncommon having debian/ packaging directly in the source and
> there's also debian-official/ which could get confusing and
> out-of-sync and messy.  I recommend moving them to another archive.
> Storing the packaging in KDE neon Git would be cool as we already
> have packaging for all the rest of KDE software.

Meanwhile packaging has been taken over by the debian-qt-kde team
(thank you so much!). Jonathan himself added RKWard to neon. We still
have a (basic) debian packaging to support nightly builds in our Ubuntu
PPAs (which fill a somewhat different gap than Neon), but this is now
kept in a separate repository.



Jonathan commented in a separate mail
(https://marc.info/?l=kde-core-devel&m=154118912915065&w=2)

> There's no appstream metainfo file nor product-screenshot
> https://community.kde.org/Guidelines_and_HOWTOs/

33 matches

Mail list logo