Re: KDE Itinerary in kdereview

2019-12-29 Thread Volker Krause
Thanks for the feedback so far!

This has now exceeded the 2 weeks period, the only unaddressed feedback 
(unless I missed something else) is the one from Sandro about having a release 
before being able to pass kdereview. Ben's input on this however seems to 
confirm my understanding that this is rather the other way around, and 
therefore not blocking passing review.

Unless there's any objection I'd therefore move this to extragear/pim within 
the next days, and then look into getting everything needed for this under the 
release service umbrella.

Thanks,
Volker

On Sunday, 8 December 2019 13:14:43 CET Volker Krause wrote:
> Hi,
> 
> KDE Itinerary has been moved to kdereview:
> 
> Code: https://invent.kde.org/kde/itinerary
> Workboard: https://phabricator.kde.org/project/board/280/query/all/
> 
> KDE Itinerary is a Kirigami-based mobile application for managing your
> itinerary as a timeline, including access to your travel documents, tickets
> and boarding passes, real-time updates for train connections, weather
> forecast along your trip, etc.
> 
> Its destination for now is probably extragear/pim, but becoming part of the
> release service eventually would be desirable.
> 
> There are binary factory nightly builds for Android and Flatpak for easy
> testing. It can import travel documents directly, but for the optimal
> experience this is best used together with the KMail Itinerary plug-in and a
> Nextcloud/DavDroid calendar or KDE Connect.
> 
> Thanks,
> Volker



signature.asc
Description: This is a digitally signed message part.


Re: KDE Itinerary in kdereview

2019-12-21 Thread Sandro Knauß
Hi,

> KDE Itinerary has been moved to kdereview:
> 
> Code: https://invent.kde.org/kde/itinerary
> Workboard: https://phabricator.kde.org/project/board/280/query/all/
> 
> KDE Itinerary is a Kirigami-based mobile application for managing your
> itinerary as a timeline, including access to your travel documents, tickets
> and boarding passes, real-time updates for train connections, weather
> forecast along your trip, etc.
> 
> Its destination for now is probably extragear/pim, but becoming part of the
> release service eventually would be desirable.

I thought, that a release entering kdereview needs at least one release, but I 
haven't found any release tarballs nor tags. This is at least blocks us from 
getting it into Debian.

Regards,

hefee





Re: KDE Itinerary in kdereview

2019-12-21 Thread Ben Cooksley
On Sat, Dec 21, 2019 at 7:59 PM Volker Krause  wrote:
>
> On Friday, 20 December 2019 22:50:54 CET Sandro Knauß wrote:
> > Hi,
> >
> > > KDE Itinerary has been moved to kdereview:
> > >
> > > Code: https://invent.kde.org/kde/itinerary
> > > Workboard: https://phabricator.kde.org/project/board/280/query/all/
> > >
> > > KDE Itinerary is a Kirigami-based mobile application for managing your
> > > itinerary as a timeline, including access to your travel documents,
> > > tickets
> > > and boarding passes, real-time updates for train connections, weather
> > > forecast along your trip, etc.
> > >
> > > Its destination for now is probably extragear/pim, but becoming part of
> > > the
> > > release service eventually would be desirable.
> >
> > I thought, that a release entering kdereview needs at least one release, but
> > I haven't found any release tarballs nor tags. This is at least blocks us
> > from getting it into Debian.
>
> My understanding so far was that we are not supposed to do releases from
> playground? That impression is supported by playground projects usually not
> having CI coverage. So one of the main motivations for moving through
> kdereview now is to actually become able to do releases.

There is quite a bit of confusion around what playground projects are
able to do vs. what reviewed projects are able to do unfortunately.

>From my understanding of things, playground projects are only allowed
to make alpha/beta releases, and cannot have any stable releases.
For this reason, they also don't have stable translations.

This does mean however that the difference between playground and
reviewed software is very small and in practice playground projects
have essentially been acting as fully fledged projects (making
releases that distributions are packaging and delivering in their main
repositories, etc)

Since we've moved to Git the story of playground has always been a bit
confusing to be honest, as we now have personal repositories as a
first step, then playground, then review and finally self-released /
release-service / plasma / frameworks.

With the upcoming move to Gitlab and with personal repositories now
having greater prominence this is a topic i'd definitely like to
revisit (but that is a whole different topic/discussion, and should be
in it's own email thread)

>
> Regards,
> Volker

Cheers,
Ben


Re: KDE Itinerary in kdereview

2019-12-20 Thread Volker Krause
On Friday, 20 December 2019 22:50:54 CET Sandro Knauß wrote:
> Hi,
> 
> > KDE Itinerary has been moved to kdereview:
> > 
> > Code: https://invent.kde.org/kde/itinerary
> > Workboard: https://phabricator.kde.org/project/board/280/query/all/
> > 
> > KDE Itinerary is a Kirigami-based mobile application for managing your
> > itinerary as a timeline, including access to your travel documents,
> > tickets
> > and boarding passes, real-time updates for train connections, weather
> > forecast along your trip, etc.
> > 
> > Its destination for now is probably extragear/pim, but becoming part of
> > the
> > release service eventually would be desirable.
> 
> I thought, that a release entering kdereview needs at least one release, but
> I haven't found any release tarballs nor tags. This is at least blocks us
> from getting it into Debian.

My understanding so far was that we are not supposed to do releases from 
playground? That impression is supported by playground projects usually not 
having CI coverage. So one of the main motivations for moving through 
kdereview now is to actually become able to do releases.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.


Re: KDE Itinerary in kdereview

2019-12-17 Thread Christophe Giboudeaux
Hey,

On dimanche 8 décembre 2019 13:14:43 CET Volker Krause wrote:
> Hi,
> 
> KDE Itinerary has been moved to kdereview:
> 
> Code: https://invent.kde.org/kde/itinerary
> Workboard: https://phabricator.kde.org/project/board/280/query/all/
> 
COPYING.LIB contains the LGPL 2.1 license. The files in the repo are LGPL-2.0-
or-later

src/extractors/irctc.js doesn't have a license header (compared to the other 
js files in this folder)





Re: KDE Itinerary in kdereview

2019-12-10 Thread Volker Krause
On Monday, 9 December 2019 11:33:43 CET Jonathan Riddell wrote:
> Looking good
> 
> It's more common to name COPYING as COPYING.LIB when it is the LGPL
> 
> In the appdata file org.kde.itinerary.desktop  it's better to use
> an id without the .desktop on the end since that's unnecessary
> 
> And it's missing the launchpable tag
> 
> org.kde.$NAME.desktop recommended, see
> https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-l
> aunchable 
> 
> The wiki page should maybe be named after the app not the library
> https://community.kde.org/KDE_PIM/KItinerary

Thanks, all of the above should be fixed now.

Regards,
Volker

> On Sun, 8 Dec 2019 at 12:16, Volker Krause  wrote:
> > Hi,
> > 
> > KDE Itinerary has been moved to kdereview:
> > 
> > Code: https://invent.kde.org/kde/itinerary
> > Workboard: https://phabricator.kde.org/project/board/280/query/all/
> > 
> > KDE Itinerary is a Kirigami-based mobile application for managing your
> > itinerary as a timeline, including access to your travel documents,
> > tickets
> > and boarding passes, real-time updates for train connections, weather
> > forecast
> > along your trip, etc.
> > 
> > Its destination for now is probably extragear/pim, but becoming part of
> > the
> > release service eventually would be desirable.
> > 
> > There are binary factory nightly builds for Android and Flatpak for easy
> > testing. It can import travel documents directly, but for the optimal
> > experience this is best used together with the KMail Itinerary plug-in and
> > a
> > Nextcloud/DavDroid calendar or KDE Connect.
> > 
> > Thanks,
> > Volker



signature.asc
Description: This is a digitally signed message part.


Re: KDE Itinerary in kdereview

2019-12-09 Thread Volker Krause
On Sunday, 8 December 2019 14:07:57 CET Christophe Giboudeaux wrote:
> Hey,
> 
> On dimanche 8 décembre 2019 13:14:43 CET Volker Krause wrote:
> > Hi,
> > 
> > KDE Itinerary has been moved to kdereview:
> > 
> > Code: https://invent.kde.org/kde/itinerary
> > Workboard: https://phabricator.kde.org/project/board/280/query/all/
> 
> COPYING.LIB contains the LGPL 2.1 license. The files in the repo are
> LGPL-2.0- or-later
> 
> src/extractors/irctc.js doesn't have a license header (compared to the other
> js files in this folder)

Both valid issues (and fixed), but in a different repo :)

The COPYING issue also existed in the itinerary repo, fixed there as well.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.


Re: KDE Itinerary in kdereview

2019-12-09 Thread Jonathan Riddell
Looking good

It's more common to name COPYING as COPYING.LIB when it is the LGPL

In the appdata file org.kde.itinerary.desktop  it's better to use
an id without the .desktop on the end since that's unnecessary

And it's missing the launchpable tag

org.kde.$NAME.desktop recommended, see
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable


The wiki page should maybe be named after the app not the library
https://community.kde.org/KDE_PIM/KItinerary

Jonathan



On Sun, 8 Dec 2019 at 12:16, Volker Krause  wrote:

> Hi,
>
> KDE Itinerary has been moved to kdereview:
>
> Code: https://invent.kde.org/kde/itinerary
> Workboard: https://phabricator.kde.org/project/board/280/query/all/
>
> KDE Itinerary is a Kirigami-based mobile application for managing your
> itinerary as a timeline, including access to your travel documents,
> tickets
> and boarding passes, real-time updates for train connections, weather
> forecast
> along your trip, etc.
>
> Its destination for now is probably extragear/pim, but becoming part of
> the
> release service eventually would be desirable.
>
> There are binary factory nightly builds for Android and Flatpak for easy
> testing. It can import travel documents directly, but for the optimal
> experience this is best used together with the KMail Itinerary plug-in and
> a
> Nextcloud/DavDroid calendar or KDE Connect.
>
> Thanks,
> Volker