Re: Review Request: KMessageWidget: Adapt height to text changes

[Aurélien Gâteau]

> On May 2, 2011, 5:49 p.m., Aurélien Gâteau wrote:
> > Thanks for the patch Mattias! This is indeed an annoying bug but your fix 
> > does not work when the widget is resized. heightForWidth() needs to be 
> > implemented I think.
> 
> Matthias Fuchs wrote:
> The problem is that resizing takes no effect yet either. Here without the 
> patch enabling word wrap instantly increases the height, even if there is 
> enough horizontal space. So the fix would not make matters worse.
> 
> I am not sure how to fix the height problem in general though. To me it 
> appears that QLabel is lacking here.
>

(Answering almost one year later, new record :/)

I worked a bit on KMessageWidget two weeks ago, the current version in KDE/4.8 
should correctly adjusts its height when wrapping and react to resizing. Can 
you test it?


- Aurélien


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101272/#review3071
---


On May 2, 2011, 12:35 p.m., Matthias Fuchs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101272/
> ---
> 
> (Updated May 2, 2011, 12:35 p.m.)
> 
> 
> Review request for kdelibs and Aurélien Gâteau.
> 
> 
> Description
> ---
> 
> When there is a long or wrapping text, the text is cut off. This patch fixes 
> that.
> 
> 
> Diffs
> -
> 
>   kdeui/widgets/kmessagewidget.cpp 212ea0d 
> 
> Diff: http://git.reviewboard.kde.org/r/101272/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/101272/s/154/
> 
>   http://git.reviewboard.kde.org/r/101272/s/155/
> 
> 
> Thanks,
> 
> Matthias Fuchs
> 
>

Re: Review Request: KMessageWidget: Adapt height to text changes

[Matthias Fuchs]

> On May 2, 2011, 5:49 p.m., Aurélien Gâteau wrote:
> > Thanks for the patch Mattias! This is indeed an annoying bug but your fix 
> > does not work when the widget is resized. heightForWidth() needs to be 
> > implemented I think.

The problem is that resizing takes no effect yet either. Here without the patch 
enabling word wrap instantly increases the height, even if there is enough 
horizontal space. So the fix would not make matters worse.

I am not sure how to fix the height problem in general though. To me it appears 
that QLabel is lacking here.


- Matthias


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101272/#review3071
---


On May 2, 2011, 12:35 p.m., Matthias Fuchs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101272/
> ---
> 
> (Updated May 2, 2011, 12:35 p.m.)
> 
> 
> Review request for kdelibs and Aurélien Gâteau.
> 
> 
> Summary
> ---
> 
> When there is a long or wrapping text, the text is cut off. This patch fixes 
> that.
> 
> 
> Diffs
> -
> 
>   kdeui/widgets/kmessagewidget.cpp 212ea0d 
> 
> Diff: http://git.reviewboard.kde.org/r/101272/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/101272/s/154/
> 
>   http://git.reviewboard.kde.org/r/101272/s/155/
> 
> 
> Thanks,
> 
> Matthias
> 
>

Re: Review Request: KMessageWidget: Adapt height to text changes

[Jarosław Staniek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101272/#review3074
---



kdeui/widgets/kmessagewidget.cpp


Some extra checks needed here.
Sometimes I am getting this warning:

QWidget::setMinimumSize: Negative sizes (0,-1) are not possible
QWidget::setMaximumSize: Negative sizes (16777215,-1) are not possible



- Jarosław


On May 2, 2011, 12:35 p.m., Matthias Fuchs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101272/
> ---
> 
> (Updated May 2, 2011, 12:35 p.m.)
> 
> 
> Review request for kdelibs and Aurélien Gâteau.
> 
> 
> Summary
> ---
> 
> When there is a long or wrapping text, the text is cut off. This patch fixes 
> that.
> 
> 
> Diffs
> -
> 
>   kdeui/widgets/kmessagewidget.cpp 212ea0d 
> 
> Diff: http://git.reviewboard.kde.org/r/101272/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/101272/s/154/
> 
>   http://git.reviewboard.kde.org/r/101272/s/155/
> 
> 
> Thanks,
> 
> Matthias
> 
>

Re: Review Request: KMessageWidget: Adapt height to text changes

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101272/#review3071
---


Thanks for the patch Mattias! This is indeed an annoying bug but your fix does 
not work when the widget is resized. heightForWidth() needs to be implemented I 
think.

- Aurélien


On May 2, 2011, 12:35 p.m., Matthias Fuchs wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101272/
> ---
> 
> (Updated May 2, 2011, 12:35 p.m.)
> 
> 
> Review request for kdelibs and Aurélien Gâteau.
> 
> 
> Summary
> ---
> 
> When there is a long or wrapping text, the text is cut off. This patch fixes 
> that.
> 
> 
> Diffs
> -
> 
>   kdeui/widgets/kmessagewidget.cpp 212ea0d 
> 
> Diff: http://git.reviewboard.kde.org/r/101272/diff
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> 
>   http://git.reviewboard.kde.org/r/101272/s/154/
> 
>   http://git.reviewboard.kde.org/r/101272/s/155/
> 
> 
> Thanks,
> 
> Matthias
> 
>