Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review13040
---
This review has been submitted with commit
3c1c788cc52e166278af2ed878e8a2f65874b1ac by Matěj Laitl to branch KDE/4.8.
- Commit Hook
On Dec. 3, 2011, 11:59 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Dec. 3, 2011, 11:59 p.m.)
Review request for kdelibs.
Description
---
udev PortableMediaPlayer: read protocols from media-player-info
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
PACKAGERS, solid udev backend now has following optional runtime-only
dependency that provides udev rules and other info for identification
of the portable media players:
* media-player-info: for identifying USB storage devices and iPods
Following packages also provide relevant udev rules, but we suggest not
depending on them as they should by pulled by packages that actually
use them (such as Amarok, transitively):
* usbmuxd: for identifying iOS-based iPods
* libmtp = 1.0.4: for identifying MTP players
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
CCMAIL: kde-packa...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfad3b0aef700176e236f7587d3f26c76362
solid/solid/backends/udev/udevdevice.cpp
d6c7fb43427e7db4cb7cfa7d67a02c5368a7811e
solid/solid/backends/udev/udevmanager.cpp
55e655b9f49875923d82b7f2bf10b0e23c3bdfe1
solid/solid/backends/udev/udevportablemediaplayer.h
e0348aafea7ec41e0df578dc661fbbb521531adf
solid/solid/backends/udev/udevportablemediaplayer.cpp
32a189315bbc3bd323ef39f9e2743cbfe1063e68
solid/solid/ifaces/portablemediaplayer.h
b03a995223f03fa15c724427f05afdff6c3e7379
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review12814
---
Bump. Should I port this to to-be kdelibs 4.9, or is it too late?
- Matěj Laitl
On Dec. 3, 2011, 11:59 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Dec. 3, 2011, 11:59 p.m.)
Review request for kdelibs.
Description
---
udev PortableMediaPlayer: read protocols from media-player-info
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
PACKAGERS, solid udev backend now has following optional runtime-only
dependency that provides udev rules and other info for identification
of the portable media players:
* media-player-info: for identifying USB storage devices and iPods
Following packages also provide relevant udev rules, but we suggest not
depending on them as they should by pulled by packages that actually
use them (such as Amarok, transitively):
* usbmuxd: for identifying iOS-based iPods
* libmtp = 1.0.4: for identifying MTP players
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
CCMAIL: kde-packa...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfad3b0aef700176e236f7587d3f26c76362
solid/solid/backends/udev/udevdevice.cpp
d6c7fb43427e7db4cb7cfa7d67a02c5368a7811e
solid/solid/backends/udev/udevmanager.cpp
55e655b9f49875923d82b7f2bf10b0e23c3bdfe1
solid/solid/backends/udev/udevportablemediaplayer.h
e0348aafea7ec41e0df578dc661fbbb521531adf
solid/solid/backends/udev/udevportablemediaplayer.cpp
32a189315bbc3bd323ef39f9e2743cbfe1063e68
solid/solid/ifaces/portablemediaplayer.h
b03a995223f03fa15c724427f05afdff6c3e7379
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info
On April 22, 2012, 9:36 p.m., Matěj Laitl wrote:
Bump. Should I port this to to-be kdelibs 4.9, or is it too late?
Is the patch any different? it should be just the same. In that case please,
apply this patch to 4.8, 4.9 and Frameworks.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review12814
---
On Dec. 3, 2011, 11:59 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Dec. 3, 2011, 11:59 p.m.)
Review request for kdelibs.
Description
---
udev PortableMediaPlayer: read protocols from media-player-info
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
PACKAGERS, solid udev backend now has following optional runtime-only
dependency that provides udev rules and other info for identification
of the portable media players:
* media-player-info: for identifying USB storage devices and iPods
Following packages also provide relevant udev rules, but we suggest not
depending on them as they should by pulled by packages that actually
use them (such as Amarok, transitively):
* usbmuxd: for identifying iOS-based iPods
* libmtp = 1.0.4: for identifying MTP players
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
CCMAIL: kde-packa...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfad3b0aef700176e236f7587d3f26c76362
solid/solid/backends/udev/udevdevice.cpp
d6c7fb43427e7db4cb7cfa7d67a02c5368a7811e
solid/solid/backends/udev/udevmanager.cpp
55e655b9f49875923d82b7f2bf10b0e23c3bdfe1
solid/solid/backends/udev/udevportablemediaplayer.h
e0348aafea7ec41e0df578dc661fbbb521531adf
solid/solid/backends/udev/udevportablemediaplayer.cpp
32a189315bbc3bd323ef39f9e2743cbfe1063e68
solid/solid/ifaces/portablemediaplayer.h
b03a995223f03fa15c724427f05afdff6c3e7379
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Dec. 3, 2011, 11:59 p.m.)
Review request for kdelibs.
Changes
---
Added media-player-info check to CMakeLists; cleaned up xgdbasers; packager
info in commit msg and CCMAIL to kde-packa...@kde.org (hope it can be sent
there from commit hook)
This patch is still based on KDE/4.7 branch (I test it in KDE 4.7), should I
port it to frameworks branch? (solid seems moved around in this branch).
Summary (updated)
-
udev PortableMediaPlayer: read protocols from media-player-info
Description (updated)
---
udev PortableMediaPlayer: read protocols from media-player-info
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
PACKAGERS, solid udev backend now has following optional runtime-only
dependency that provides udev rules and other info for identification
of the portable media players:
* media-player-info: for identifying USB storage devices and iPods
Following packages also provide relevant udev rules, but we suggest not
depending on them as they should by pulled by packages that actually
use them (such as Amarok, transitively):
* usbmuxd: for identifying iOS-based iPods
* libmtp = 1.0.4: for identifying MTP players
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
CCMAIL: kde-packa...@kde.org
Diffs (updated)
-
solid/solid/CMakeLists.txt 1a4adfad3b0aef700176e236f7587d3f26c76362
solid/solid/backends/udev/udevdevice.cpp
d6c7fb43427e7db4cb7cfa7d67a02c5368a7811e
solid/solid/backends/udev/udevmanager.cpp
55e655b9f49875923d82b7f2bf10b0e23c3bdfe1
solid/solid/backends/udev/udevportablemediaplayer.h
e0348aafea7ec41e0df578dc661fbbb521531adf
solid/solid/backends/udev/udevportablemediaplayer.cpp
32a189315bbc3bd323ef39f9e2743cbfe1063e68
solid/solid/ifaces/portablemediaplayer.h
b03a995223f03fa15c724427f05afdff6c3e7379
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8653
---
Ship it!
I have asked in kde-core-devel if adding media player info as dependency is ok
(kdelibs 4.X is freezed forever), and everybody said yes.
So for me, ship it once you've added the CMake warnings and remember to email
the kde-packagers mailist.
Thanks and great work !
- Alex Fiestas
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote:
solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109
http://git.reviewboard.kde.org/r/103028/diff/1/?file=40295#file40295line109
We have been returning mtp as the protocol that identify mtp
devices, the value of the mpi files is storage while it should be mtp.
MTP devices should have ID_MEDIA_PLAYER == 1 si this is catched on line 93. If
there is a MTP device that has ID_MEDIA_PLAYER == string ans string.mpi
says AccessProtocol=storage, it is a bug in media-player-info. (it says that
storage is for USB Mass Storage devices)
On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote:
solid/solid/CMakeLists.txt, line 82
http://git.reviewboard.kde.org/r/103028/diff/1/?file=40291#file40291line82
I can understand the copy/paste of this file, but do we need all of it?
I'd rather keep only what we need and document that we copy/pasted it from
kdelibs etc
Alex Merry wrote:
It's actually already trimmed down (I think to the minimum needed).
There should probably be a comment saying where it was from, though (akonadi;
the libs directory).
Okay, I'll review it, clean if possible and add comment about copying.
- Matěj
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8329
---
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
On Nov. 20, 2011, 3:38 a.m., Alex Fiestas wrote:
Oh another thing, the CMakeList should check for media-player-info as an
optional dependency
OK, I'll add that. The problem is that media-player-info is runtime-only
depencency - even if not present during build, it will work if installed
runtime. (and vice-versa) But an informative check doesn't hurt, so I'll add
that.
Another problem is that media-player-info installs only udev rule and .mpi
files, so I'll probably only check $XDG_DATA_DIRS/media-player-info folder
presence.
- Matěj
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8330
---
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
On Nov. 20, 2011, 3:38 a.m., Alex Fiestas wrote:
Oh another thing, the CMakeList should check for media-player-info as an
optional dependency
Matěj Laitl wrote:
OK, I'll add that. The problem is that media-player-info is runtime-only
depencency - even if not present during build, it will work if installed
runtime. (and vice-versa) But an informative check doesn't hurt, so I'll add
that.
Another problem is that media-player-info installs only udev rule and
.mpi files, so I'll probably only check $XDG_DATA_DIRS/media-player-info
folder presence.
That would be awesome !
- Alex
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8330
---
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote:
solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109
http://git.reviewboard.kde.org/r/103028/diff/1/?file=40295#file40295line109
We have been returning mtp as the protocol that identify mtp
devices, the value of the mpi files is storage while it should be mtp.
Matěj Laitl wrote:
MTP devices should have ID_MEDIA_PLAYER == 1 si this is catched on line
93. If there is a MTP device that has ID_MEDIA_PLAYER == string ans
string.mpi says AccessProtocol=storage, it is a bug in media-player-info.
(it says that storage is for USB Mass Storage devices)
Oh now I got it! so:
If MTP, libmtp set it to 1 and then you should use libmtp to get more info
If NOT mtp, m-p-i will set it to the file you should parse in order to get
information.
Is that correct ?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8329
---
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote:
solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109
http://git.reviewboard.kde.org/r/103028/diff/1/?file=40295#file40295line109
We have been returning mtp as the protocol that identify mtp
devices, the value of the mpi files is storage while it should be mtp.
Matěj Laitl wrote:
MTP devices should have ID_MEDIA_PLAYER == 1 si this is catched on line
93. If there is a MTP device that has ID_MEDIA_PLAYER == string ans
string.mpi says AccessProtocol=storage, it is a bug in media-player-info.
(it says that storage is for USB Mass Storage devices)
Alex Fiestas wrote:
Oh now I got it! so:
If MTP, libmtp set it to 1 and then you should use libmtp to get more info
If NOT mtp, m-p-i will set it to the file you should parse in order to
get information.
Is that correct ?
Absolutely.
- Matěj
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8329
---
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote:
solid/solid/CMakeLists.txt, line 82
http://git.reviewboard.kde.org/r/103028/diff/1/?file=40291#file40291line82
I can understand the copy/paste of this file, but do we need all of it?
I'd rather keep only what we need and document that we copy/pasted it from
kdelibs etc
It's actually already trimmed down (I think to the minimum needed). There
should probably be a comment saying where it was from, though (akonadi; the
libs directory).
- Alex
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8329
---
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8329
---
This patch looks nice, a few things/questions though:
solid/solid/CMakeLists.txt
http://git.reviewboard.kde.org/r/103028/#comment7117
I can understand the copy/paste of this file, but do we need all of it? I'd
rather keep only what we need and document that we copy/pasted it from kdelibs
etc
solid/solid/backends/udev/udevportablemediaplayer.cpp
http://git.reviewboard.kde.org/r/103028/#comment7118
We have been returning mtp as the protocol that identify mtp devices,
the value of the mpi files is storage while it should be mtp.
- Alex Fiestas
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/#review8330
---
Oh another thing, the CMakeList should check for media-player-info as an
optional dependency
- Alex Fiestas
On Nov. 5, 2011, 4:47 p.m., Matěj Laitl wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
---
(Updated Nov. 5, 2011, 4:47 p.m.)
Review request for kdelibs.
Description
---
This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)
[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info
Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.
TODO: announce runtime-only media-player-info dependency for solid and
add it to build instructions. libmtp = 1.0.4 is also needed at
runtime for detection of MTP devices to work. usbmuxd (dependency
of libimobiledevice) is needed at runtime for detection of Apple
iOS devices.
TODO: what about windows support?
The patch is against kdelibs KDE/4.7 branch, please forward-port.
CCBUG: 253671 # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-de...@kde.org
Diffs
-
solid/solid/CMakeLists.txt 1a4adfa
solid/solid/backends/udev/udevdevice.cpp d6c7fb4
solid/solid/backends/udev/udevmanager.cpp 55e655b
solid/solid/backends/udev/udevportablemediaplayer.h e0348aa
solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893
solid/solid/ifaces/portablemediaplayer.h a73120a
solid/solid/xdgbasedirs.cpp PRE-CREATION
solid/solid/xdgbasedirs_p.h PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103028/diff/diff
Testing
---
1. connect iPod
2. works:
$ solid-hardware details
/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi =
'/org/kde/solid/udev/sys/devices/pci:00/:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
parent = '/org/kde/solid/udev' (string)
vendor = 'Apple' (string)
product = 'iPod' (string)
description = 'Portable Media Player' (string)
Block.major = 8 (0x8) (int)
Block.minor = 32 (0x20) (int)
Block.device = '/dev/sdc' (string)
PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'} (string list)
PortableMediaPlayer.supportedDrivers = {'usb'} (string list)
3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
parent = '/org/freedesktop/UDisks/devices/sdc' (string)
vendor = 'Apple' (string)
product = 'MATOUSUV IP' (string)
description = 'MATOUSUV IP' (string)
Block.major = 8 (0x8) (int)
Block.minor = 33 (0x21) (int)
Block.device = '/dev/sdc1' (string)
StorageAccess.accessible = true (bool)
StorageAccess.filePath = '/media/MATOUSUV IP' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'FileSystem' (0x2) (enum)
StorageVolume.fsType = 'vfat' (string)
StorageVolume.label = 'MATOUSUV IP' (string)
StorageVolume.uuid = '3141-5926' (string)
StorageVolume.size = 7888957440 (0x1d637f000) (qulonglong)
Thanks,
Matěj Laitl
