Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
On March 22, 2013, 5:38 p.m., Laurent Montel wrote: For me seems good. Regards Sven Brauch wrote: Sorry to annoy you again ;) just to make sure, I'd push this to kdelibs master now, ok? I hope nobody will mind the increase in the required attica version... yes in master. Regards - Laurent --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29732 --- On March 22, 2013, 11:31 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 22, 2013, 11:31 a.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - CMakeLists.txt b116f50 knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29797 --- This review has been submitted with commit 086d4c2ed65d4767ec8f298e3f4accf387b5d3b6 by Sven Brauch to branch master. - Commit Hook On March 22, 2013, 11:31 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 22, 2013, 11:31 a.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - CMakeLists.txt b116f50 knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 24, 2013, 12:55 p.m.) Status -- This change has been marked as submitted. Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - CMakeLists.txt b116f50 knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
On March 22, 2013, 5:38 p.m., Laurent Montel wrote: For me seems good. Regards Sorry to annoy you again ;) just to make sure, I'd push this to kdelibs master now, ok? I hope nobody will mind the increase in the required attica version... - Sven --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29732 --- On March 22, 2013, 11:31 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 22, 2013, 11:31 a.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - CMakeLists.txt b116f50 knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 22, 2013, 11:31 a.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Changes --- Increase required attica version to 0.4.2 see commit 7f43cb97 in attica. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs (updated) - CMakeLists.txt b116f50 knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29670 --- You need to increase attic - Laurent Montel On March 18, 2013, 5:41 p.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 18, 2013, 5:41 p.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29671 --- You need to increase attica version and make kdelibs depends against it. Otherwise it will not compile. We can't depends against git master version, we must have a official release regards. - Laurent Montel On March 18, 2013, 5:41 p.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 18, 2013, 5:41 p.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
On March 22, 2013, 6:20 a.m., Laurent Montel wrote: You need to increase attica version and make kdelibs depends against it. Otherwise it will not compile. We can't depends against git master version, we must have a official release regards. Ah, yes. So, I would increase attica's version from 0.4.1 to 0.4.2 and make kdelibs master depend on that? - Sven --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29671 --- On March 18, 2013, 5:41 p.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 18, 2013, 5:41 p.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
On March 22, 2013, 6:20 a.m., Laurent Montel wrote: You need to increase attica version and make kdelibs depends against it. Otherwise it will not compile. We can't depends against git master version, we must have a official release regards. Sven Brauch wrote: Ah, yes. So, I would increase attica's version from 0.4.1 to 0.4.2 and make kdelibs master depend on that? Yes - Laurent --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29671 --- On March 18, 2013, 5:41 p.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 18, 2013, 5:41 p.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29732 --- For me seems good. Regards - Laurent Montel On March 22, 2013, 11:31 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 22, 2013, 11:31 a.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - CMakeLists.txt b116f50 knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
Re: Review Request 109568: GHNS3: If the provider file lists a register account URL, provide a link to that in the upload dialog
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/#review29639 --- The patch to attica, which is needed by this, has been submitted now. - Sven Brauch On March 18, 2013, 5:41 p.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109568/ --- (Updated March 18, 2013, 5:41 p.m.) Review request for Attica, kdelibs and Jeremy Paul Whiting. Description --- When the provider file lists an URL to register a new account, this patch adds a link to the login screen of the upload dialog which enables a user to register a new account. This patch depends on https://git.reviewboard.kde.org/r/109567/. Diffs - knewstuff/knewstuff3/uploaddialog.h 3f58f7d knewstuff/knewstuff3/uploaddialog.cpp 922469e knewstuff/knewstuff3/uploaddialog.ui aa54d2b knewstuff/knewstuff3/uploaddialog_p.h 1bb0af4 Diff: http://git.reviewboard.kde.org/r/109568/diff/ Testing --- Thanks, Sven Brauch
