Re: Review Request: [KIO] AccessManager: the missing piece to go with 1bf9737.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101859/#review4507 --- This review has been submitted with commit eed6cc4bf2773cadabdab2a4d860a093b8546a5b by Pierre Rossi to branch KDE/4.7. - Commit On July 5, 2011, 8:32 p.m., Pierre Rossi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101859/ > --- > > (Updated July 5, 2011, 8:32 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > --- > > Bonus question: should this go in 4.7 or master ? > > > Diffs > - > > kio/kio/accessmanager.cpp ef9b8ef > > Diff: http://git.reviewboard.kde.org/r/101859/diff > > > Testing > --- > > > Thanks, > > Pierre > >
Re: Review Request: [KIO] AccessManager: the missing piece to go with 1bf9737.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101859/#review4506 --- This review has been submitted with commit 998af6833721467e292893912764b9078a555ecb by Pierre Rossi to branch master. - Commit On July 5, 2011, 8:32 p.m., Pierre Rossi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101859/ > --- > > (Updated July 5, 2011, 8:32 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > --- > > Bonus question: should this go in 4.7 or master ? > > > Diffs > - > > kio/kio/accessmanager.cpp ef9b8ef > > Diff: http://git.reviewboard.kde.org/r/101859/diff > > > Testing > --- > > > Thanks, > > Pierre > >
Re: Review Request: [KIO] AccessManager: the missing piece to go with 1bf9737.
> On July 5, 2011, 9:47 p.m., Dawit Alemayehu wrote: > > Unnecessary because a job is NOT created in either of those case and as > > such the state of that flag is of no consequence. ok, then if the parent is not necessary either, we should probably drop it too. I just didn't like the fact that a pointer was given for a bool. - Pierre --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101859/#review4415 --- On July 5, 2011, 8:32 p.m., Pierre Rossi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101859/ > --- > > (Updated July 5, 2011, 8:32 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > --- > > Bonus question: should this go in 4.7 or master ? > > > Diffs > - > > kio/kio/accessmanager.cpp ef9b8ef > > Diff: http://git.reviewboard.kde.org/r/101859/diff > > > Testing > --- > > > Thanks, > > Pierre > >
Review Request: [KIO] AccessManager: the missing piece to go with 1bf9737.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101859/ --- Review request for kdelibs and Dawit Alemayehu. Summary --- Bonus question: should this go in 4.7 or master ? Diffs - kio/kio/accessmanager.cpp ef9b8ef Diff: http://git.reviewboard.kde.org/r/101859/diff Testing --- Thanks, Pierre
Re: Review Request: [KIO] AccessManager: the missing piece to go with 1bf9737.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101859/#review4424 --- Ship it! - Dawit On July 5, 2011, 8:32 p.m., Pierre Rossi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101859/ > --- > > (Updated July 5, 2011, 8:32 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > --- > > Bonus question: should this go in 4.7 or master ? > > > Diffs > - > > kio/kio/accessmanager.cpp ef9b8ef > > Diff: http://git.reviewboard.kde.org/r/101859/diff > > > Testing > --- > > > Thanks, > > Pierre > >
Re: Review Request: [KIO] AccessManager: the missing piece to go with 1bf9737.
> On July 5, 2011, 9:47 p.m., Dawit Alemayehu wrote: > > Unnecessary because a job is NOT created in either of those case and as > > such the state of that flag is of no consequence. > > Pierre Rossi wrote: > ok, then if the parent is not necessary either, we should probably drop > it too. I just didn't like the fact that a pointer was given for a bool. Oops. You are correct. I missed that. So please go ahead and commit and yes it needs to go into 4.7 and cherry picked into master. Thanks. - Dawit --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101859/#review4415 --- On July 5, 2011, 8:32 p.m., Pierre Rossi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101859/ > --- > > (Updated July 5, 2011, 8:32 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > --- > > Bonus question: should this go in 4.7 or master ? > > > Diffs > - > > kio/kio/accessmanager.cpp ef9b8ef > > Diff: http://git.reviewboard.kde.org/r/101859/diff > > > Testing > --- > > > Thanks, > > Pierre > >
Re: Review Request: [KIO] AccessManager: the missing piece to go with 1bf9737.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101859/#review4415 --- Unnecessary because a job is NOT created in either of those case and as such the state of that flag is of no consequence. - Dawit On July 5, 2011, 8:32 p.m., Pierre Rossi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101859/ > --- > > (Updated July 5, 2011, 8:32 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Summary > --- > > Bonus question: should this go in 4.7 or master ? > > > Diffs > - > > kio/kio/accessmanager.cpp ef9b8ef > > Diff: http://git.reviewboard.kde.org/r/101859/diff > > > Testing > --- > > > Thanks, > > Pierre > >
