Re: Review Request: Fix KPasswdServer usage of KWallet
On Sept. 29, 2011, 8:14 p.m., Dawit Alemayehu wrote: Sorry, but this is simply wrong. There is a specific reason why passwords are not blindly saved into the wallet before they are validated. The idea of prompting the user for password and actually storing that password need to be two separate actions. So the question is from which application or ioslave are you having this problem ? Fixed correctly. See https://projects.kde.org/projects/kde/kdelibs/repository/revisions/c0cb2f6f489fabb0776319cfc4d2f772c28f61da - Dawit --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102729/#review6926 --- On Sept. 29, 2011, 5:37 a.m., Ben Cooksley wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102729/ --- (Updated Sept. 29, 2011, 5:37 a.m.) Review request for KDE Runtime, Dawit Alemayehu and David Faure. Description --- As of commit 2317acb1da0eefef322d9bac046187fc067cc27b (by adawit) KWallet is never used for password storage by KPasswdServer. It still reads, but never writes. This patch very roughly fixes it to get password saving in KWallet functional again. There is probably a much nicer way to fix it, but I just wanted it to work again. Diffs - kpasswdserver/kpasswdserver.cpp cc8ded2 Diff: http://git.reviewboard.kde.org/r/102729/diff/diff Testing --- Checking the Save Password box when KWallet is enabled leads to the password being saved. Thanks, Ben Cooksley
Re: Review Request: Fix KPasswdServer usage of KWallet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102729/#review6926 --- Sorry, but this is simply wrong. There is a specific reason why passwords are not blindly saved into the wallet before they are validated. The idea of prompting the user for password and actually storing that password need to be two separate actions. So the question is from which application or ioslave are you having this problem ? - Dawit Alemayehu On Sept. 29, 2011, 5:37 a.m., Ben Cooksley wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102729/ --- (Updated Sept. 29, 2011, 5:37 a.m.) Review request for KDE Runtime, Dawit Alemayehu and David Faure. Description --- As of commit 2317acb1da0eefef322d9bac046187fc067cc27b (by adawit) KWallet is never used for password storage by KPasswdServer. It still reads, but never writes. This patch very roughly fixes it to get password saving in KWallet functional again. There is probably a much nicer way to fix it, but I just wanted it to work again. Diffs - kpasswdserver/kpasswdserver.cpp cc8ded2 Diff: http://git.reviewboard.kde.org/r/102729/diff/diff Testing --- Checking the Save Password box when KWallet is enabled leads to the password being saved. Thanks, Ben Cooksley
Review Request: Fix KPasswdServer usage of KWallet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102729/ --- Review request for KDE Runtime, Dawit Alemayehu and David Faure. Description --- As of commit 2317acb1da0eefef322d9bac046187fc067cc27b (by adawit) KWallet is never used for password storage by KPasswdServer. It still reads, but never writes. This patch very roughly fixes it to get password saving in KWallet functional again. There is probably a much nicer way to fix it, but I just wanted it to work again. Diffs - kpasswdserver/kpasswdserver.cpp cc8ded2 Diff: http://git.reviewboard.kde.org/r/102729/diff/diff Testing --- Checking the Save Password box when KWallet is enabled leads to the password being saved. Thanks, Ben Cooksley
