Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/ --- (Updated Oct. 7, 2012, 10:17 p.m.) Review request for kdelibs. Changes --- - regenerated with bison 2.6.2 - updated broken ch07 tests (no new fails, just fixes, reorder caused some noise) Description --- KJS/Grammar: Introduce new non-terminal IdentifierName, which allows keywords to be used as PropertyName, in Memberexps and CallExpr. (but not yet enum,export,extends, super, because they have the same value RESERVED) Diffs (updated) - kjs/grammar.h 5422fc7 kjs/grammar.cpp 71245a4 kjs/grammar.y d5e835f kjs/tests/ecmatest_broken_ch07 bcc238d Diff: http://git.reviewboard.kde.org/r/104243/diff/ Testing --- Tested with ecmascript262, all keyword cases pass now, except the reserved ones Thanks, Bernd Buschinski
Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr
On April 21, 2012, 3:47 p.m., Maks Orlovich wrote: Hmm, you may have missed my reply on IRC, making this languish in the ether: I meant number of shift/reduce conflicts in the parser, as reported by bison. I am ashamed to admit that I am not able to detect LALR parsing ambiguities by inspection.. ok, as I finally got what this is about: This patch does not change the number of conflicts shift/reduce, with and without this patch it says conflicts: 1 shift/reduce Will post another patch soon which fixes this shift/reduce conflict + other minor warnings - Bernd --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/#review12765 --- On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/ --- (Updated March 12, 2012, 9:03 p.m.) Review request for kdelibs. Description --- KJS/Grammar: Introduce new non-terminal IdentifierName, which allows keywords to be used as PropertyName, in Memberexps and CallExpr. (but not yet enum,export,extends, super, because they have the same value RESERVED) Diffs - kjs/grammar.h 2a006df kjs/grammar.cpp 32dbeae kjs/grammar.y d5e835f Diff: http://git.reviewboard.kde.org/r/104243/diff/ Testing --- Tested with ecmascript262, all keyword cases pass now, except the reserved ones Thanks, Bernd Buschinski
Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/#review12765 --- Hmm, you may have missed my reply on IRC, making this languish in the ether: I meant number of shift/reduce conflicts in the parser, as reported by bison. I am ashamed to admit that I am not able to detect LALR parsing ambiguities by inspection.. - Maks Orlovich On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/ --- (Updated March 12, 2012, 9:03 p.m.) Review request for kdelibs. Description --- KJS/Grammar: Introduce new non-terminal IdentifierName, which allows keywords to be used as PropertyName, in Memberexps and CallExpr. (but not yet enum,export,extends, super, because they have the same value RESERVED) Diffs - kjs/grammar.h 2a006df kjs/grammar.cpp 32dbeae kjs/grammar.y d5e835f Diff: http://git.reviewboard.kde.org/r/104243/diff/ Testing --- Tested with ecmascript262, all keyword cases pass now, except the reserved ones Thanks, Bernd Buschinski
Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr
On March 20, 2012, 9:30 p.m., Maks Orlovich wrote: Can I presume this change doesn't changer # of conflicts? I don't understand what conflicts you mean. If you mean failing tests in ecmascript262, it does change the number, it recudes the fails by ~50 - Bernd --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/#review11664 --- On March 12, 2012, 9:03 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/ --- (Updated March 12, 2012, 9:03 p.m.) Review request for kdelibs. Description --- KJS/Grammar: Introduce new non-terminal IdentifierName, which allows keywords to be used as PropertyName, in Memberexps and CallExpr. (but not yet enum,export,extends, super, because they have the same value RESERVED) Diffs - kjs/grammar.h 2a006df kjs/grammar.cpp 32dbeae kjs/grammar.y d5e835f Diff: http://git.reviewboard.kde.org/r/104243/diff/ Testing --- Tested with ecmascript262, all keyword cases pass now, except the reserved ones Thanks, Bernd Buschinski
Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/ --- Review request for kdelibs. Description --- KJS/Grammar: Introduce new non-terminal IdentifierName, which allows keywords to be used as PropertyName, in Memberexps and CallExpr. (but not yet enum,export,extends, super, because they have the same value RESERVED) Diffs - kjs/grammar.h 2a006df kjs/grammar.cpp 32dbeae kjs/grammar.y d5e835f Diff: http://git.reviewboard.kde.org/r/104243/diff/ Testing --- Tested with ecmascript262, all keyword cases pass now, except the reserved ones Thanks, Bernd Buschinski
