Re: Review Request: KJS: No longer treat invalid hex as string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/#review12541 --- This review has been submitted with commit d4d5843d14deed8c8bd8c719adce16620777aa43 by Bernd Buschinski to branch KDE/4.8. - Commit Hook On March 21, 2012, 11:52 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/ --- (Updated March 21, 2012, 11:52 p.m.) Review request for kdelibs. Description --- KJS: No longer treat invalid hex as string Fixes ecmascript - S7.8.4_A6.1_T4 (invalid hex \x0G) - S7.8.4_A6.2_T1 S7.8.4_A6.2_T2 (too short hex \xA) Diffs - kjs/lexer.cpp e89de5f Diff: http://git.reviewboard.kde.org/r/104076/diff/ Testing --- tested with ecmascript, no new regressions Thanks, Bernd Buschinski
Re: Review Request: KJS: No longer treat invalid hex as string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/#review12473 --- Ship it! Ship It! - Maks Orlovich On March 21, 2012, 11:52 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/ --- (Updated March 21, 2012, 11:52 p.m.) Review request for kdelibs. Description --- KJS: No longer treat invalid hex as string Fixes ecmascript - S7.8.4_A6.1_T4 (invalid hex \x0G) - S7.8.4_A6.2_T1 S7.8.4_A6.2_T2 (too short hex \xA) Diffs - kjs/lexer.cpp e89de5f Diff: http://git.reviewboard.kde.org/r/104076/diff/ Testing --- tested with ecmascript, no new regressions Thanks, Bernd Buschinski
Re: Review Request: KJS: No longer treat invalid hex as string
On March 20, 2012, 9:18 p.m., Maks Orlovich wrote: kjs/lexer.cpp, line 320 http://git.reviewboard.kde.org/r/104076/diff/1/?file=51115#file51115line320 Any reason you're still permitting this recovery (testcase: \x)? Because I feared it would break even more, or rather there was some string appending magic that would make it valid. In but there should be no way, \x must be followed by 2 valid hex values. I will update the patch - Bernd --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/#review11663 --- On Feb. 25, 2012, 4:31 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/ --- (Updated Feb. 25, 2012, 4:31 p.m.) Review request for kdelibs. Description --- KJS: No longer treat invalid hex as string Fixes ecmascript - S7.8.4_A6.1_T4 (invalid hex \x0G) - S7.8.4_A6.2_T1 S7.8.4_A6.2_T2 (too short hex \xA) Diffs - kjs/lexer.cpp e89de5f Diff: http://git.reviewboard.kde.org/r/104076/diff/ Testing --- tested with ecmascript, no new regressions Thanks, Bernd Buschinski
Re: Review Request: KJS: No longer treat invalid hex as string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/ --- (Updated March 21, 2012, 11:52 p.m.) Review request for kdelibs. Changes --- also forbit \x Description --- KJS: No longer treat invalid hex as string Fixes ecmascript - S7.8.4_A6.1_T4 (invalid hex \x0G) - S7.8.4_A6.2_T1 S7.8.4_A6.2_T2 (too short hex \xA) Diffs (updated) - kjs/lexer.cpp e89de5f Diff: http://git.reviewboard.kde.org/r/104076/diff/ Testing --- tested with ecmascript, no new regressions Thanks, Bernd Buschinski
Re: Review Request: KJS: No longer treat invalid hex as string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/#review11663 --- This is consistent with the spec; but I am worried that in the wild behavior may not match the spec yet (at least it doesn't for Chrome 18; it may be safe since FF seems to follow this, but I don't have a good version at spec now) kjs/lexer.cpp http://git.reviewboard.kde.org/r/104076/#comment9261 Any reason you're still permitting this recovery (testcase: \x)? - Maks Orlovich On Feb. 25, 2012, 4:31 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/ --- (Updated Feb. 25, 2012, 4:31 p.m.) Review request for kdelibs. Description --- KJS: No longer treat invalid hex as string Fixes ecmascript - S7.8.4_A6.1_T4 (invalid hex \x0G) - S7.8.4_A6.2_T1 S7.8.4_A6.2_T2 (too short hex \xA) Diffs - kjs/lexer.cpp e89de5f Diff: http://git.reviewboard.kde.org/r/104076/diff/ Testing --- tested with ecmascript, no new regressions Thanks, Bernd Buschinski
Review Request: KJS: No longer treat invalid hex as string
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/ --- Review request for kdelibs. Description --- KJS: No longer treat invalid hex as string Fixes ecmascript - S7.8.4_A6.1_T4 (invalid hex \x0G) - S7.8.4_A6.2_T1 S7.8.4_A6.2_T2 (too short hex \xA) Diffs - kjs/lexer.cpp e89de5f Diff: http://git.reviewboard.kde.org/r/104076/diff/ Testing --- tested with ecmascript, no new regressions Thanks, Bernd Buschinski
