Re: Review Request: kjs: Mark Date Infinity as invalid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/#review18558 --- This review has been submitted with commit 48dd1fc50277b861b49613c5f46b6f8b10cc932d by Bernd Buschinski to branch KDE/4.9. - Commit Hook On July 6, 2012, 6:30 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/ --- (Updated July 6, 2012, 6:30 p.m.) Review request for kdelibs. Description --- kjs: Mark Date Infinity as invalid we currently accept Infinity as a valid date, but its not, we even calc with it, which may or may not lead to a result, but always to the wrong result. The correct way it to just report it as invalid, as we do by remembering it as NaN. Diffs - kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105387/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Mark Date Infinity as invalid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/#review15458 --- kjs/date_object.cpp http://git.reviewboard.kde.org/r/105387/#comment12087 Same fix here? (And perhaps in other spots?) Really, this probably needs some cleanup to not dupe this chunk of code; the spec defines one in terms of the other, after all. - Maks Orlovich On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/ --- (Updated June 29, 2012, 6:06 p.m.) Review request for kdelibs. Description --- kjs: Mark Date Infinity as invalid we currently accept Infinity as a valid date, but its not, we even calc with it, which may or may not lead to a result, but always to the wrong result. The correct way it to just report it as invalid, as we do by remembering it as NaN. Diffs - kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105387/diff/ Testing --- Thanks, Bernd Buschinski
Re: Review Request: kjs: Mark Date Infinity as invalid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/ --- (Updated July 6, 2012, 6:30 p.m.) Review request for kdelibs. Changes --- kjs: Mark Date Infinity as invalid cleanup Description --- kjs: Mark Date Infinity as invalid we currently accept Infinity as a valid date, but its not, we even calc with it, which may or may not lead to a result, but always to the wrong result. The correct way it to just report it as invalid, as we do by remembering it as NaN. Diffs (updated) - kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105387/diff/ Testing --- Thanks, Bernd Buschinski
Review Request: kjs: Mark Date Infinity as invalid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/ --- Review request for kdelibs. Description --- kjs: Mark Date Infinity as invalid we currently accept Infinity as a valid date, but its not, we even calc with it, which may or may not lead to a result, but always to the wrong result. The correct way it to just report it as invalid, as we do by remembering it as NaN. Diffs - kjs/date_object.cpp 8a1fc2c Diff: http://git.reviewboard.kde.org/r/105387/diff/ Testing --- Thanks, Bernd Buschinski
