Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/ --- (Updated Oct. 14, 2013, 4:16 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs and David Faure. Bugs: 324879 http://bugs.kde.org/show_bug.cgi?id=324879 Repository: kdelibs Description --- KPropertiesDialog: Do not show the KFileMetaDataWidget The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy. It would be better for people to use the Nepomuk2::FileMetaDataWidget. This mostly only affect Dolphin where users can tag files via the Information Panel and via File->Properties. This removes the widget in the File->Properties BUG: 324879 Diffs - kio/kfile/kpropertiesdialog.cpp b4cd8ee Diff: http://git.reviewboard.kde.org/r/113190/diff/ Testing --- The "Information" tag is no longer shown in the FileProperties dialog Thanks, Vishesh Handa
Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/#review41742 --- This review has been submitted with commit fa58b5a00540b4697bc11cacf66fedb1ba6d22ce by Vishesh Handa to branch master. - Commit Hook On Oct. 14, 2013, 10:25 a.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113190/ > --- > > (Updated Oct. 14, 2013, 10:25 a.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 324879 > http://bugs.kde.org/show_bug.cgi?id=324879 > > > Repository: kdelibs > > > Description > --- > > KPropertiesDialog: Do not show the KFileMetaDataWidget > > The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy. > It would be better for people to use the Nepomuk2::FileMetaDataWidget. > > This mostly only affect Dolphin where users can tag files via the > Information Panel and via File->Properties. This removes the widget in > the File->Properties > > BUG: 324879 > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp b4cd8ee > > Diff: http://git.reviewboard.kde.org/r/113190/diff/ > > > Testing > --- > > The "Information" tag is no longer shown in the FileProperties dialog > > > Thanks, > > Vishesh Handa > >
Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/ --- (Updated Oct. 14, 2013, 10:25 a.m.) Review request for kdelibs and David Faure. Changes --- Added 'master' branch in the review branch field. Bugs: 324879 http://bugs.kde.org/show_bug.cgi?id=324879 Repository: kdelibs Description --- KPropertiesDialog: Do not show the KFileMetaDataWidget The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy. It would be better for people to use the Nepomuk2::FileMetaDataWidget. This mostly only affect Dolphin where users can tag files via the Information Panel and via File->Properties. This removes the widget in the File->Properties BUG: 324879 Diffs - kio/kfile/kpropertiesdialog.cpp b4cd8ee Diff: http://git.reviewboard.kde.org/r/113190/diff/ Testing --- The "Information" tag is no longer shown in the FileProperties dialog Thanks, Vishesh Handa
Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget
> On Oct. 11, 2013, 6:14 a.m., David Faure wrote: > > Which branch is this for? Master? Yes this is for master. We'll still be having a 4.12 release of kdelibs, right? - Vishesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/#review41541 --- On Oct. 10, 2013, 10:45 a.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113190/ > --- > > (Updated Oct. 10, 2013, 10:45 a.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 324879 > http://bugs.kde.org/show_bug.cgi?id=324879 > > > Repository: kdelibs > > > Description > --- > > KPropertiesDialog: Do not show the KFileMetaDataWidget > > The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy. > It would be better for people to use the Nepomuk2::FileMetaDataWidget. > > This mostly only affect Dolphin where users can tag files via the > Information Panel and via File->Properties. This removes the widget in > the File->Properties > > BUG: 324879 > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp b4cd8ee > > Diff: http://git.reviewboard.kde.org/r/113190/diff/ > > > Testing > --- > > The "Information" tag is no longer shown in the FileProperties dialog > > > Thanks, > > Vishesh Handa > >
Re: Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/#review41541 --- Ship it! Which branch is this for? Master? - David Faure On Oct. 10, 2013, 10:45 a.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113190/ > --- > > (Updated Oct. 10, 2013, 10:45 a.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 324879 > http://bugs.kde.org/show_bug.cgi?id=324879 > > > Repository: kdelibs > > > Description > --- > > KPropertiesDialog: Do not show the KFileMetaDataWidget > > The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy. > It would be better for people to use the Nepomuk2::FileMetaDataWidget. > > This mostly only affect Dolphin where users can tag files via the > Information Panel and via File->Properties. This removes the widget in > the File->Properties > > BUG: 324879 > > > Diffs > - > > kio/kfile/kpropertiesdialog.cpp b4cd8ee > > Diff: http://git.reviewboard.kde.org/r/113190/diff/ > > > Testing > --- > > The "Information" tag is no longer shown in the FileProperties dialog > > > Thanks, > > Vishesh Handa > >
Review Request 113190: KPropertiesDialog: Do not show the KFileMetaDataWidget
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113190/ --- Review request for kdelibs and David Faure. Bugs: 324879 http://bugs.kde.org/show_bug.cgi?id=324879 Repository: kdelibs Description --- KPropertiesDialog: Do not show the KFileMetaDataWidget The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy. It would be better for people to use the Nepomuk2::FileMetaDataWidget. This mostly only affect Dolphin where users can tag files via the Information Panel and via File->Properties. This removes the widget in the File->Properties BUG: 324879 Diffs - kio/kfile/kpropertiesdialog.cpp b4cd8ee Diff: http://git.reviewboard.kde.org/r/113190/diff/ Testing --- The "Information" tag is no longer shown in the FileProperties dialog Thanks, Vishesh Handa
