Re: Review Request 113857: Get rid off ifdefs for windows driver kit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113857/ --- (Updated Nov. 19, 2013, 6:18 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs, Patrick Spendrin and Patrick von Reth. Repository: kdelibs Description --- Get rid off ifdefs for windows driver kit Headers are now part of kdewin As discussed with Patrick von Reth on IRC. Diffs - solid/solid/backends/win/winblock.cpp 1f4d378a9614775b4f8abe186d147189a550858c solid/solid/backends/win/windevicemanager.h b2d3c40779a60f24be498ba6e435a0c9cba1f2f8 solid/solid/backends/win/winopticaldisc.cpp c20ee43e33e20f795e814f13d7507756df394c1e solid/solid/backends/win/winopticaldrive.h ce6c2c45338edbe470ba8f040dd3a3e829073d9c solid/solid/backends/win/winopticaldrive.cpp fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e Diff: http://git.reviewboard.kde.org/r/113857/diff/ Testing --- Thanks, Kevin Funk
Re: Review Request 113857: Get rid off ifdefs for windows driver kit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113857/#review43980 --- This review has been submitted with commit 9f538a25935461e7f773c350991fab343b165d60 by Kevin Funk to branch master. - Commit Hook On Nov. 14, 2013, 1:08 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113857/ > --- > > (Updated Nov. 14, 2013, 1:08 p.m.) > > > Review request for kdelibs, Patrick Spendrin and Patrick von Reth. > > > Repository: kdelibs > > > Description > --- > > Get rid off ifdefs for windows driver kit > > Headers are now part of kdewin > > As discussed with Patrick von Reth on IRC. > > > Diffs > - > > solid/solid/backends/win/winblock.cpp > 1f4d378a9614775b4f8abe186d147189a550858c > solid/solid/backends/win/windevicemanager.h > b2d3c40779a60f24be498ba6e435a0c9cba1f2f8 > solid/solid/backends/win/winopticaldisc.cpp > c20ee43e33e20f795e814f13d7507756df394c1e > solid/solid/backends/win/winopticaldrive.h > ce6c2c45338edbe470ba8f040dd3a3e829073d9c > solid/solid/backends/win/winopticaldrive.cpp > fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e > > Diff: http://git.reviewboard.kde.org/r/113857/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > >
Re: Review Request 113857: Get rid off ifdefs for windows driver kit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113857/#review43950 --- Ship it! Ship It! - Patrick von Reth On Nov. 14, 2013, 1:08 p.m., Kevin Funk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113857/ > --- > > (Updated Nov. 14, 2013, 1:08 p.m.) > > > Review request for kdelibs, Patrick Spendrin and Patrick von Reth. > > > Repository: kdelibs > > > Description > --- > > Get rid off ifdefs for windows driver kit > > Headers are now part of kdewin > > As discussed with Patrick von Reth on IRC. > > > Diffs > - > > solid/solid/backends/win/winblock.cpp > 1f4d378a9614775b4f8abe186d147189a550858c > solid/solid/backends/win/windevicemanager.h > b2d3c40779a60f24be498ba6e435a0c9cba1f2f8 > solid/solid/backends/win/winopticaldisc.cpp > c20ee43e33e20f795e814f13d7507756df394c1e > solid/solid/backends/win/winopticaldrive.h > ce6c2c45338edbe470ba8f040dd3a3e829073d9c > solid/solid/backends/win/winopticaldrive.cpp > fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e > > Diff: http://git.reviewboard.kde.org/r/113857/diff/ > > > Testing > --- > > > Thanks, > > Kevin Funk > >
Review Request 113857: Get rid off ifdefs for windows driver kit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113857/ --- Review request for kdelibs, Patrick Spendrin and Patrick von Reth. Repository: kdelibs Description --- Get rid off ifdefs for windows driver kit Headers are now part of kdewin As discussed with Patrick von Reth on IRC. Diffs - solid/solid/backends/win/winblock.cpp 1f4d378a9614775b4f8abe186d147189a550858c solid/solid/backends/win/windevicemanager.h b2d3c40779a60f24be498ba6e435a0c9cba1f2f8 solid/solid/backends/win/winopticaldisc.cpp c20ee43e33e20f795e814f13d7507756df394c1e solid/solid/backends/win/winopticaldrive.h ce6c2c45338edbe470ba8f040dd3a3e829073d9c solid/solid/backends/win/winopticaldrive.cpp fd87eb982a75ff2cff48f9f5ab5e13ac400d9a5e Diff: http://git.reviewboard.kde.org/r/113857/diff/ Testing --- Thanks, Kevin Funk
