Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict
On Jan. 28, 2014, 5:49 p.m., Aleix Pol Gonzalez wrote: Should we even comment/remove them? Doesn't seem like anybody's going to read this output ever... Ping, can someone tell me what to do with this? Can I either push this change or remove the output altogether? - Milian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/#review48493 --- On Jan. 28, 2014, 1 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/ --- (Updated Jan. 28, 2014, 1 p.m.) Review request for kdelibs. Repository: kdelibs Description --- Enabling automatic spell checking in Kate, I see a lot of debug output in the form of: Enchant dict for en_US 0x43a1480 This patch should fix this and only output the lines when debug output is enabled via kdebugdialog. Diffs - sonnet/plugins/enchant/enchantdict.cpp c289d26 Diff: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff
Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/#review52053 --- Heh, the Git history looks very sad in this part of kdelibs. Noone worked on this for years now. Personally I'd just get rid off the debug output, seems like noone cares anyway. (I'm also annoyed by the useless output) - Kevin Funk On Jan. 28, 2014, 1 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/ --- (Updated Jan. 28, 2014, 1 p.m.) Review request for kdelibs. Repository: kdelibs Description --- Enabling automatic spell checking in Kate, I see a lot of debug output in the form of: Enchant dict for en_US 0x43a1480 This patch should fix this and only output the lines when debug output is enabled via kdebugdialog. Diffs - sonnet/plugins/enchant/enchantdict.cpp c289d26 Diff: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff
Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/#review52204 --- This review has been submitted with commit 42b779e3efca6cddf316b6df85a36363288a9db4 by Milian Wolff to branch KDE/4.13. - Commit Hook On Jan. 28, 2014, 1 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/ --- (Updated Jan. 28, 2014, 1 p.m.) Review request for kdelibs. Repository: kdelibs Description --- Enabling automatic spell checking in Kate, I see a lot of debug output in the form of: Enchant dict for en_US 0x43a1480 This patch should fix this and only output the lines when debug output is enabled via kdebugdialog. Diffs - sonnet/plugins/enchant/enchantdict.cpp c289d26 Diff: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff
Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/ --- (Updated March 5, 2014, 7:11 p.m.) Status -- This change has been marked as submitted. Review request for kdelibs. Repository: kdelibs Description --- Enabling automatic spell checking in Kate, I see a lot of debug output in the form of: Enchant dict for en_US 0x43a1480 This patch should fix this and only output the lines when debug output is enabled via kdebugdialog. Diffs - sonnet/plugins/enchant/enchantdict.cpp c289d26 Diff: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff
Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/ --- Review request for kdelibs. Repository: kdelibs Description --- Enabling automatic spell checking in Kate, I see a lot of debug output in the form of: Enchant dict for en_US 0x43a1480 This patch should fix this and only output the lines when debug output is enabled via kdebugdialog. Diffs - sonnet/plugins/enchant/enchantdict.cpp c289d26 Diff: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff
Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/#review48493 --- Should we even comment/remove them? Doesn't seem like anybody's going to read this output ever... - Aleix Pol Gonzalez On Jan. 28, 2014, 1 p.m., Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/ --- (Updated Jan. 28, 2014, 1 p.m.) Review request for kdelibs. Repository: kdelibs Description --- Enabling automatic spell checking in Kate, I see a lot of debug output in the form of: Enchant dict for en_US 0x43a1480 This patch should fix this and only output the lines when debug output is enabled via kdebugdialog. Diffs - sonnet/plugins/enchant/enchantdict.cpp c289d26 Diff: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff
