Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Luigi Toscano 


> On Dic. 30, 2015, 3:48 p.m., Luigi Toscano wrote:
> > For the record: this was submitted to the knotifications frameworks, not to 
> > kdelibs.
> 
> Martin Klapetek wrote:
> Yes, sorry, I wrote it as a message here but now I see that it didn't get 
> through; I still have "Publish" here :S
> 
> There are no more kdelibs releases planned and the same bug happens in 
> frameworks, so I pushed it to frameworks.

Afaik we are still publishing patch releases of kdelibs 4.14 branch, so I would 
add the fix there too.


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90339
---


On Dic. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dic. 29, 2015, 9:54 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Luigi Toscano 


> On Dic. 30, 2015, 3:48 p.m., Luigi Toscano wrote:
> > For the record: this was submitted to the knotifications frameworks, not to 
> > kdelibs.
> 
> Martin Klapetek wrote:
> Yes, sorry, I wrote it as a message here but now I see that it didn't get 
> through; I still have "Publish" here :S
> 
> There are no more kdelibs releases planned and the same bug happens in 
> frameworks, so I pushed it to frameworks.
> 
> Luigi Toscano wrote:
> Afaik we are still publishing patch releases of kdelibs 4.14 branch, so I 
> would add the fix there too.
> 
> Martin Klapetek wrote:
> Ah, do we have any records for that? Also when would the next release be?

With every stable release of KDE Applications (x.y, x.y.z, x.y.z+1, etc, so 
non-beta).

You can check the release tools, kdelibs is listed:
https://quickgit.kde.org/?p=sysadmin%2Frelease-tools.git=blob=ca78d7665498409a5d8b892b255cb6783cea078b=dd91ca9e998550e10f17c850544753ac065ea9e9=modules.git


- Luigi


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90339
---


On Dic. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dic. 29, 2015, 9:54 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek 


> On Dec. 30, 2015, 3:48 p.m., Luigi Toscano wrote:
> > For the record: this was submitted to the knotifications frameworks, not to 
> > kdelibs.

Yes, sorry, I wrote it as a message here but now I see that it didn't get 
through; I still have "Publish" here :S

There are no more kdelibs releases planned and the same bug happens in 
frameworks, so I pushed it to frameworks.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90339
---


On Dec. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dec. 29, 2015, 9:54 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek 


> On Dec. 30, 2015, 3:52 p.m., Kai Uwe Broulik wrote:
> > kdeui/notifications/knotificationrestrictions.cpp, line 50
> > 
> >
> > Note that this string can be shown to the user (we do this in Battery 
> > Monitor), so it should be a translatable proper string.

Is there a value for "no reason" that will not print any reason?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90341
---


On Dec. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dec. 29, 2015, 9:54 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek 


> On Nov. 20, 2015, 8:51 p.m., Johannes Stefan wrote:
> > Ping

There are no more kdelibs releases planned, but I'll push this to frameworks 
for you.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review88660
---


On Dec. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dec. 29, 2015, 9:54 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Martin Klapetek 


> On Dec. 30, 2015, 3:48 p.m., Luigi Toscano wrote:
> > For the record: this was submitted to the knotifications frameworks, not to 
> > kdelibs.
> 
> Martin Klapetek wrote:
> Yes, sorry, I wrote it as a message here but now I see that it didn't get 
> through; I still have "Publish" here :S
> 
> There are no more kdelibs releases planned and the same bug happens in 
> frameworks, so I pushed it to frameworks.
> 
> Luigi Toscano wrote:
> Afaik we are still publishing patch releases of kdelibs 4.14 branch, so I 
> would add the fix there too.

Ah, do we have any records for that? Also when would the next release be?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90339
---


On Dec. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dec. 29, 2015, 9:54 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Kai Uwe Broulik 


> On Dez. 30, 2015, 2:52 nachm., Kai Uwe Broulik wrote:
> > kdeui/notifications/knotificationrestrictions.cpp, line 50
> > 
> >
> > Note that this string can be shown to the user (we do this in Battery 
> > Monitor), so it should be a translatable proper string.
> 
> Martin Klapetek wrote:
> Is there a value for "no reason" that will not print any reason?

No. This would defy the whole point of having to specify a reason. :)

"A human-readable and possibly translated string explaining the reason why 
idleness is inhibited (such as 'Playing a movie')." Unfortunately the spec does 
not say whether/that this field is optional. 

PowerDevil doesn't care about the reason, Battery Monitor won't show a reason 
(just generic "$app currently blocks PM") if none is given, I don't know why 
the fuck Gnome blocks the application if no reason is given.

-1 for specifying a default. I'd rather have Gwenview (which from what I can 
tell is the only app that doesn't set a reason) set one (and the Gnome thing 
fixed...)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90341
---


On Dez. 29, 2015, 8:54 nachm., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dez. 29, 2015, 8:54 nachm.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Luigi Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90339
---


For the record: this was submitted to the knotifications frameworks, not to 
kdelibs.

- Luigi Toscano


On Dic. 29, 2015, 9:54 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dic. 29, 2015, 9:54 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-30 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review90341
---



kdeui/notifications/knotificationrestrictions.cpp (line 50)


Note that this string can be shown to the user (we do this in Battery 
Monitor), so it should be a translatable proper string.


- Kai Uwe Broulik


On Dez. 29, 2015, 8:54 nachm., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Dez. 29, 2015, 8:54 nachm.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-12-29 Thread Johannes Stefan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/
---

(Updated Dec. 29, 2015, 8:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for kdelibs and Martin Klapetek.


Changes
---

Submitted with commit 3f080d44af41d0158d7b5c51269449e78d5b128f by Martin 
Klapetek on behalf of Johannes Stefan to branch master.


Bugs: 334525
http://bugs.kde.org/show_bug.cgi?id=334525


Repository: kdelibs


Description
---

Setting default reason for going into fullscreen mode


Diffs
-

  kdeui/notifications/knotificationrestrictions.cpp 818edea 

Diff: https://git.reviewboard.kde.org/r/125910/diff/


Testing
---

Compiled an tested - DBus Log as expected:

# begin DBUS-log #
method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
   string "Gwenview"
   string "no_reason_specified"
method call sender=:1.6 -> dest=:1.3 serial=588 path=/org/gnome/SessionManager; 
interface=org.gnome.SessionManager; member=Inhibit
   string "Gwenview"
   uint32 0
   string "no_reason_specified"
   uint32 8
signal sender=:1.3 -> dest=(null destination) serial=351 
path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
member=PropertiesChanged
   string "org.gnome.SessionManager"
   array [
  dict entry(
 string "InhibitedActions"
 variant uint32 8
  )
   ]
   array [
   ]
signal sender=:1.3 -> dest=(null destination) serial=352 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=InhibitorAdded
   object path "/org/gnome/SessionManager/Inhibitor29"
method return sender=:1.3 -> dest=:1.6 reply_serial=588
   uint32 1169992534
method call sender=:1.4 -> dest=:1.21 serial=56 
path=/org/gnome/Mutter/IdleMonitor/Core; 
interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
   uint32 35
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner
   string ":1.223"
method return sender=:1.6 -> dest=:1.223 reply_serial=56
   uint32 1169992534
method call sender=:1.6 -> dest=:1.21 serial=592 
path=/org/gnome/Mutter/DisplayConfig; 
interface=org.freedesktop.DBus.Properties; member=Set
   string "org.gnome.Mutter.DisplayConfig"
   string "PowerSaveMode"
   variant   int32 0
method call sender=:1.21 -> dest=:1.3 serial=1073 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=IsInhibited
   uint32 16
method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
method return sender=:1.21 -> dest=:1.4 reply_serial=56
method return sender=:1.3 -> dest=:1.21 reply_serial=1073
   boolean false
# end of DBUS-log #


Thanks,

Johannes Stefan

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-20 Thread Johannes Stefan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review88660
---


Ping

- Johannes Stefan


On Nov. 1, 2015, 9:50 nachm., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Nov. 1, 2015, 9:50 nachm.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-03 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review87941
---


Looks good to me


kdeui/notifications/knotificationrestrictions.cpp (lines 48 - 50)


Btw. the commas are put in the beginning of the lines to have an easy way 
to comment that particular line; you can just comment the whole line and don't 
have to worry about the comma at the end of the previous line.

This is not an issue, I'm just explaining why it was at the beginning of 
the line (or why I think it was) :)


- Martin Klapetek


On Nov. 1, 2015, 10:50 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Nov. 1, 2015, 10:50 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Johannes Stefan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/
---

Review request for kdelibs.


Bugs: 334525
http://bugs.kde.org/show_bug.cgi?id=334525


Repository: kdelibs


Description
---

Setting default reason for going into fullscreen mode


Diffs
-

  kdeui/notifications/knotificationrestrictions.cpp 818edea 

Diff: https://git.reviewboard.kde.org/r/125910/diff/


Testing
---

Compiled an tested - DBus Log as expected:

# begin DBUS-log #
method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
   string "Gwenview"
   string "no_reason_specified"
method call sender=:1.6 -> dest=:1.3 serial=588 path=/org/gnome/SessionManager; 
interface=org.gnome.SessionManager; member=Inhibit
   string "Gwenview"
   uint32 0
   string "no_reason_specified"
   uint32 8
signal sender=:1.3 -> dest=(null destination) serial=351 
path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
member=PropertiesChanged
   string "org.gnome.SessionManager"
   array [
  dict entry(
 string "InhibitedActions"
 variant uint32 8
  )
   ]
   array [
   ]
signal sender=:1.3 -> dest=(null destination) serial=352 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=InhibitorAdded
   object path "/org/gnome/SessionManager/Inhibitor29"
method return sender=:1.3 -> dest=:1.6 reply_serial=588
   uint32 1169992534
method call sender=:1.4 -> dest=:1.21 serial=56 
path=/org/gnome/Mutter/IdleMonitor/Core; 
interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
   uint32 35
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner
   string ":1.223"
method return sender=:1.6 -> dest=:1.223 reply_serial=56
   uint32 1169992534
method call sender=:1.6 -> dest=:1.21 serial=592 
path=/org/gnome/Mutter/DisplayConfig; 
interface=org.freedesktop.DBus.Properties; member=Set
   string "org.gnome.Mutter.DisplayConfig"
   string "PowerSaveMode"
   variant   int32 0
method call sender=:1.21 -> dest=:1.3 serial=1073 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=IsInhibited
   uint32 16
method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
method return sender=:1.21 -> dest=:1.4 reply_serial=56
method return sender=:1.3 -> dest=:1.21 reply_serial=1073
   boolean false
# end of DBUS-log #


Thanks,

Johannes Stefan

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Johannes Stefan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/
---

(Updated Nov. 1, 2015, 10:24 vorm.)


Status
--

This change has been marked as submitted.


Review request for kdelibs.


Bugs: 334525
http://bugs.kde.org/show_bug.cgi?id=334525


Repository: kdelibs


Description
---

Setting default reason for going into fullscreen mode


Diffs
-

  kdeui/notifications/knotificationrestrictions.cpp 818edea 

Diff: https://git.reviewboard.kde.org/r/125910/diff/


Testing
---

Compiled an tested - DBus Log as expected:

# begin DBUS-log #
method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
   string "Gwenview"
   string "no_reason_specified"
method call sender=:1.6 -> dest=:1.3 serial=588 path=/org/gnome/SessionManager; 
interface=org.gnome.SessionManager; member=Inhibit
   string "Gwenview"
   uint32 0
   string "no_reason_specified"
   uint32 8
signal sender=:1.3 -> dest=(null destination) serial=351 
path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
member=PropertiesChanged
   string "org.gnome.SessionManager"
   array [
  dict entry(
 string "InhibitedActions"
 variant uint32 8
  )
   ]
   array [
   ]
signal sender=:1.3 -> dest=(null destination) serial=352 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=InhibitorAdded
   object path "/org/gnome/SessionManager/Inhibitor29"
method return sender=:1.3 -> dest=:1.6 reply_serial=588
   uint32 1169992534
method call sender=:1.4 -> dest=:1.21 serial=56 
path=/org/gnome/Mutter/IdleMonitor/Core; 
interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
   uint32 35
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner
   string ":1.223"
method return sender=:1.6 -> dest=:1.223 reply_serial=56
   uint32 1169992534
method call sender=:1.6 -> dest=:1.21 serial=592 
path=/org/gnome/Mutter/DisplayConfig; 
interface=org.freedesktop.DBus.Properties; member=Set
   string "org.gnome.Mutter.DisplayConfig"
   string "PowerSaveMode"
   variant   int32 0
method call sender=:1.21 -> dest=:1.3 serial=1073 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=IsInhibited
   uint32 16
method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
method return sender=:1.21 -> dest=:1.4 reply_serial=56
method return sender=:1.3 -> dest=:1.21 reply_serial=1073
   boolean false
# end of DBUS-log #


Thanks,

Johannes Stefan

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Thomas Lübking 


> On Nov. 1, 2015, 2:18 nachm., Christoph Feck wrote:
> > kdeui/notifications/knotificationrestrictions.cpp, line 67
> > 
> >
> > I am not sure all compilers support initialization of (non-static) 
> > members inside the class declaration. I suggest to move it to the 
> > constructor.

c++03 - bad
c++11 - good

unless c++11 is required for the component (i don't really know about current 
kdelibs situation, but don't think so?), initializing a non-static member is 
invalid c++

=> You *have* to move it into the constructor

Also see http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2628.html

For anything that requires full (or this feature) c++11 support, the statement 
is fine.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review87800
---


On Nov. 1, 2015, 2:15 nachm., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Nov. 1, 2015, 2:15 nachm.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Christoph Feck 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/#review87800
---



kdeui/notifications/knotificationrestrictions.cpp (line 67)


I am not sure all compilers support initialization of (non-static) members 
inside the class declaration. I suggest to move it to the constructor.


The same code is also present in knotification-framework.

- Christoph Feck


On Nov. 1, 2015, 2:15 p.m., Johannes Stefan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125910/
> ---
> 
> (Updated Nov. 1, 2015, 2:15 p.m.)
> 
> 
> Review request for kdelibs and Martin Klapetek.
> 
> 
> Bugs: 334525
> http://bugs.kde.org/show_bug.cgi?id=334525
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Setting default reason for going into fullscreen mode
> 
> 
> Diffs
> -
> 
>   kdeui/notifications/knotificationrestrictions.cpp 818edea 
> 
> Diff: https://git.reviewboard.kde.org/r/125910/diff/
> 
> 
> Testing
> ---
> 
> Compiled an tested - DBus Log as expected:
> 
> # begin DBUS-log #
> method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
> path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
>string "Gwenview"
>string "no_reason_specified"
> method call sender=:1.6 -> dest=:1.3 serial=588 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=Inhibit
>string "Gwenview"
>uint32 0
>string "no_reason_specified"
>uint32 8
> signal sender=:1.3 -> dest=(null destination) serial=351 
> path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
> member=PropertiesChanged
>string "org.gnome.SessionManager"
>array [
>   dict entry(
>  string "InhibitedActions"
>  variant uint32 8
>   )
>]
>array [
>]
> signal sender=:1.3 -> dest=(null destination) serial=352 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=InhibitorAdded
>object path "/org/gnome/SessionManager/Inhibitor29"
> method return sender=:1.3 -> dest=:1.6 reply_serial=588
>uint32 1169992534
> method call sender=:1.4 -> dest=:1.21 serial=56 
> path=/org/gnome/Mutter/IdleMonitor/Core; 
> interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
>uint32 35
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
> method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; 
> member=GetNameOwner
>string ":1.223"
> method return sender=:1.6 -> dest=:1.223 reply_serial=56
>uint32 1169992534
> method call sender=:1.6 -> dest=:1.21 serial=592 
> path=/org/gnome/Mutter/DisplayConfig; 
> interface=org.freedesktop.DBus.Properties; member=Set
>string "org.gnome.Mutter.DisplayConfig"
>string "PowerSaveMode"
>variant   int32 0
> method call sender=:1.21 -> dest=:1.3 serial=1073 
> path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
> member=IsInhibited
>uint32 16
> method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
> path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
>string 
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
> method return sender=:1.21 -> dest=:1.4 reply_serial=56
> method return sender=:1.3 -> dest=:1.21 reply_serial=1073
>boolean false
> # end of DBUS-log #
> 
> 
> Thanks,
> 
> Johannes Stefan
> 
>

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Johannes Stefan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125910/
---

(Updated Nov. 1, 2015, 9:50 nachm.)


Review request for kdelibs and Martin Klapetek.


Changes
---

Now used the c++03 compliant way of initalizing non-static member variables. 
Thanks a lot for the hints.


Bugs: 334525
http://bugs.kde.org/show_bug.cgi?id=334525


Repository: kdelibs


Description
---

Setting default reason for going into fullscreen mode


Diffs (updated)
-

  kdeui/notifications/knotificationrestrictions.cpp 818edea 

Diff: https://git.reviewboard.kde.org/r/125910/diff/


Testing
---

Compiled an tested - DBus Log as expected:

# begin DBUS-log #
method call sender=:1.223 -> dest=org.freedesktop.ScreenSaver serial=56 
path=/ScreenSaver; interface=org.freedesktop.ScreenSaver; member=Inhibit
   string "Gwenview"
   string "no_reason_specified"
method call sender=:1.6 -> dest=:1.3 serial=588 path=/org/gnome/SessionManager; 
interface=org.gnome.SessionManager; member=Inhibit
   string "Gwenview"
   uint32 0
   string "no_reason_specified"
   uint32 8
signal sender=:1.3 -> dest=(null destination) serial=351 
path=/org/gnome/SessionManager; interface=org.freedesktop.DBus.Properties; 
member=PropertiesChanged
   string "org.gnome.SessionManager"
   array [
  dict entry(
 string "InhibitedActions"
 variant uint32 8
  )
   ]
   array [
   ]
signal sender=:1.3 -> dest=(null destination) serial=352 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=InhibitorAdded
   object path "/org/gnome/SessionManager/Inhibitor29"
method return sender=:1.3 -> dest=:1.6 reply_serial=588
   uint32 1169992534
method call sender=:1.4 -> dest=:1.21 serial=56 
path=/org/gnome/Mutter/IdleMonitor/Core; 
interface=org.gnome.Mutter.IdleMonitor; member=RemoveWatch
   uint32 35
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=589 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.223'"
method call sender=:1.6 -> dest=org.freedesktop.DBus serial=590 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=GetNameOwner
   string ":1.223"
method return sender=:1.6 -> dest=:1.223 reply_serial=56
   uint32 1169992534
method call sender=:1.6 -> dest=:1.21 serial=592 
path=/org/gnome/Mutter/DisplayConfig; 
interface=org.freedesktop.DBus.Properties; member=Set
   string "org.gnome.Mutter.DisplayConfig"
   string "PowerSaveMode"
   variant   int32 0
method call sender=:1.21 -> dest=:1.3 serial=1073 
path=/org/gnome/SessionManager; interface=org.gnome.SessionManager; 
member=IsInhibited
   uint32 16
method call sender=:1.21 -> dest=org.freedesktop.DBus serial=1074 
path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=RemoveMatch
   string 
"type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',path='/org/freedesktop/DBus',arg0=':1.4'"
method return sender=:1.21 -> dest=:1.4 reply_serial=56
method return sender=:1.3 -> dest=:1.21 reply_serial=1073
   boolean false
# end of DBUS-log #


Thanks,

Johannes Stefan