Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-23 Thread Pascal VITOUX 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/
---

(Updated Feb. 23, 2017, 1:12 p.m.)


Status
--

This change has been marked as submitted.


Review request for kde-workspace and Plasma.


Changes
---

Submitted with commit 9b2d766b2bb41a6725b585eaa8ca11fc9cf36b36 by David 
Edmundson on behalf of Pascal VITOUX to branch master.


Repository: kdeplasma-addons


Description
---

Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
'cache/writeback' infos from ksysguard 5.9.0

The monitor displays the dirty + writeback amount proportionaly scaled with the 
maximal amount reached, until the remaining dirty amount goes below a minimal 
threshold of 10MB.

An interesting usecase is to show the real progress of a datas transfer to a 
slow storage device like a USB drive.


Diffs
-

  applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 

Diff: https://git.reviewboard.kde.org/r/129917/diff/


Testing
---

I use it since several months without issue.


File Attachments


panel applets : circular, bar and compact bar monitors
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
desktop applet, with tooltip
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
desktop applet, circular monitors
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png


Thanks,

Pascal VITOUX

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-22 Thread Pascal VITOUX 


> On fév. 22, 2017, 12:31 matin, David Edmundson wrote:
> > Ship It!

I cannot commit myself (no account), so if everyone is ok, can someone do it 
for me ? I would be grateful


- Pascal


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102571
---


On fév. 7, 2017, 10:20 matin, Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated fév. 7, 2017, 10:20 matin)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> File Attachments
> 
> 
> panel applets : circular, bar and compact bar monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
> desktop applet, with tooltip
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
> desktop applet, circular monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102571
---


Ship it!




Ship It!

- David Edmundson


On Feb. 7, 2017, 9:20 a.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated Feb. 7, 2017, 9:20 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> File Attachments
> 
> 
> panel applets : circular, bar and compact bar monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
> desktop applet, with tooltip
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
> desktop applet, circular monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-21 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102567
---



Sebas can this be commited now or you have more concerns?

- Albert Astals Cid


On Feb. 7, 2017, 9:20 a.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated Feb. 7, 2017, 9:20 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> File Attachments
> 
> 
> panel applets : circular, bar and compact bar monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
> desktop applet, with tooltip
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
> desktop applet, circular monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-07 Thread Pascal VITOUX 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/
---

(Updated fév. 7, 2017, 10:20 matin)


Review request for kde-workspace and Plasma.


Changes
---

disabling the cache monitor by default


Repository: kdeplasma-addons


Description
---

Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
'cache/writeback' infos from ksysguard 5.9.0

The monitor displays the dirty + writeback amount proportionaly scaled with the 
maximal amount reached, until the remaining dirty amount goes below a minimal 
threshold of 10MB.

An interesting usecase is to show the real progress of a datas transfer to a 
slow storage device like a USB drive.


Diffs (updated)
-

  applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 

Diff: https://git.reviewboard.kde.org/r/129917/diff/


Testing
---

I use it since several months without issue.


File Attachments


panel applets : circular, bar and compact bar monitors
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
desktop applet, with tooltip
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
desktop applet, circular monitors
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png


Thanks,

Pascal VITOUX

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-07 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102439
---




applets/systemloadviewer/package/contents/config/main.xml (line 52)


I think it's overkill to enable this by default, given it's only 
interesting to a limited group of users, and others probably won't understand 
it, or its utility.


- Sebastian Kügler


On Feb. 6, 2017, 8:05 p.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated Feb. 6, 2017, 8:05 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> File Attachments
> 
> 
> panel applets : circular, bar and compact bar monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
> desktop applet, with tooltip
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
> desktop applet, circular monitors
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-06 Thread Pascal VITOUX 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/
---

(Updated fév. 6, 2017, 9:05 après-midi)


Review request for kde-workspace and Plasma.


Repository: kdeplasma-addons


Description
---

Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
'cache/writeback' infos from ksysguard 5.9.0

The monitor displays the dirty + writeback amount proportionaly scaled with the 
maximal amount reached, until the remaining dirty amount goes below a minimal 
threshold of 10MB.

An interesting usecase is to show the real progress of a datas transfer to a 
slow storage device like a USB drive.


Diffs
-

  applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 

Diff: https://git.reviewboard.kde.org/r/129917/diff/


Testing
---

I use it since several months without issue.


File Attachments (updated)


panel applets : circular, bar and compact bar monitors
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/9067d5be-c1b4-4168-be20-76965b4a40ac__panel.png
desktop applet, with tooltip
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/4eb7a092-7368-448f-8385-7c18ab298389__desktop-tooltip.png
desktop applet, circular monitors
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/02/06/26f769fb-85e9-45f7-90e6-55035770be6e__desktop-circular.png


Thanks,

Pascal VITOUX

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-06 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102428
---



Could you please add screenshots of the new feature? This is important for us 
to review the visual impact your patch has. Thanks already for your work on 
this! I think it's a useful addition.

- Sebastian Kügler


On Feb. 5, 2017, 6:11 p.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated Feb. 5, 2017, 6:11 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX 


> On fév. 5, 2017, 10:07 après-midi, Dominik Haumann wrote:
> > Looks good to me, would be nice to have another review by plasma 
> > developers. Can you commit yourself?
> > 
> > Btw, this is unrelated, but maybe you are motivated to look into the bug 
> > list of the System Load Viewer applet:
> > https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=systemloadviewer_id=1420501=kdeplasma-addons

Thank you, 
No, I can't commit.

I will get a look at that list, when I get some time.


- Pascal


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102422
---


On fév. 5, 2017, 7:11 après-midi, Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated fév. 5, 2017, 7:11 après-midi)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Dominik Haumann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102422
---


Ship it!




Looks good to me, would be nice to have another review by plasma developers. 
Can you commit yourself?

Btw, this is unrelated, but maybe you are motivated to look into the bug list 
of the System Load Viewer applet:
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=systemloadviewer_id=1420501=kdeplasma-addons

- Dominik Haumann


On Feb. 5, 2017, 6:11 p.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated Feb. 5, 2017, 6:11 p.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX 


> On fév. 5, 2017, 2:52 après-midi, Dominik Haumann wrote:
> > Essentially, the idea is good I think. Just tested this patch, and what I 
> > get looks like this: https://ibin.co/3BLqYW18K8p4.png
> > In the "Compact Bar" mode, there are two bars for the cache monitors, and 
> > the right one paints over the clock.
> > 
> > Is it maybe that you wanted hals the width in compact bar mode? This 
> > certainly needs to be fixed in any case.

The two values (dirty and writeback) are supposed to be stacked in the same 
bar. In your capture the first empty bar should be for the swap monitor.

However, there was indeed an issue with the applet width but only when using 
the 'CPUs separately' option.


- Pascal


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102413
---


On fév. 5, 2017, 7:11 après-midi, Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated fév. 5, 2017, 7:11 après-midi)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Pascal VITOUX 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/
---

(Updated fév. 5, 2017, 7:11 après-midi)


Review request for kde-workspace and Plasma.


Changes
---

fix applet width when using the 'CPUs separately' option


Repository: kdeplasma-addons


Description
---

Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
'cache/writeback' infos from ksysguard 5.9.0

The monitor displays the dirty + writeback amount proportionaly scaled with the 
maximal amount reached, until the remaining dirty amount goes below a minimal 
threshold of 10MB.

An interesting usecase is to show the real progress of a datas transfer to a 
slow storage device like a USB drive.


Diffs (updated)
-

  applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 

Diff: https://git.reviewboard.kde.org/r/129917/diff/


Testing
---

I use it since several months without issue.


Thanks,

Pascal VITOUX

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-05 Thread Dominik Haumann 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/#review102413
---



Essentially, the idea is good I think. Just tested this patch, and what I get 
looks like this: https://ibin.co/3BLqYW18K8p4.png
In the "Compact Bar" mode, there are two bars for the cache monitors, and the 
right one paints over the clock.

Is it maybe that you wanted hals the width in compact bar mode? This certainly 
needs to be fixed in any case.

- Dominik Haumann


On Feb. 4, 2017, 12:03 a.m., Pascal VITOUX wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129917/
> ---
> 
> (Updated Feb. 4, 2017, 12:03 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
> 'cache/writeback' infos from ksysguard 5.9.0
> 
> The monitor displays the dirty + writeback amount proportionaly scaled with 
> the maximal amount reached, until the remaining dirty amount goes below a 
> minimal threshold of 10MB.
> 
> An interesting usecase is to show the real progress of a datas transfer to a 
> slow storage device like a USB drive.
> 
> 
> Diffs
> -
> 
>   applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
>   applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
>   applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 
> 
> Diff: https://git.reviewboard.kde.org/r/129917/diff/
> 
> 
> Testing
> ---
> 
> I use it since several months without issue.
> 
> 
> Thanks,
> 
> Pascal VITOUX
> 
>

Review Request 129917: Add a cache monitor to the System Load Viewer applet

2017-02-03 Thread Pascal VITOUX 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129917/
---

Review request for kde-workspace and Plasma.


Repository: kdeplasma-addons


Description
---

Add a cache monitor to the System Load Viewer applet using 'cache/dirty' and 
'cache/writeback' infos from ksysguard 5.9.0

The monitor displays the dirty + writeback amount proportionaly scaled with the 
maximal amount reached, until the remaining dirty amount goes below a minimal 
threshold of 10MB.

An interesting usecase is to show the real progress of a datas transfer to a 
slow storage device like a USB drive.


Diffs
-

  applets/systemloadviewer/package/contents/config/main.xml 6bf16d5aa 
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml b9247aa15 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml f1ab40a1b 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc0649 

Diff: https://git.reviewboard.kde.org/r/129917/diff/


Testing
---

I use it since several months without issue.


Thanks,

Pascal VITOUX