Re: Symmy in kde-review

[Elvis Angelaccio]

On 27/04/19 18:46, Ingo Klöcker wrote:
> On Montag, 22. April 2019 17:57:42 CEST Elvis Angelaccio wrote:
>> On 12/04/19 13:12, Adriaan de Groot wrote:
>>> # Runtime
>>>
>>> Since it's supposed to be a CLI application, you might want to massage the
>>> QPA loading a bit, since when I run it (ssh'ed in to my build machine) It
>>> does
>>> this:
>> Note that even if it can be used from CLI, it's still a GUI app as it
>> needs Qt Widgets to show the passphrase dialogs.
> 
> Hmm. I'm wondering why you don't leave the passphrase handling to gpg (resp. 
> gpg-agent) which will show a passphrase dialog (via one of the pinentry 
> implementations) if necessary. One of the major design goals of the gpg2 
> architecture was that passphrase and secret key handling is done by gpg-agent 
> exclusively.

Hi Ingo,

the passphrase handling is still done by gpg-agent. gpgme allows to use
a custom dialog instead of pinentry, which is what I've done to achieve
better integration with Plasma.

Cheers,
Elvis


> 
> Regards,
> Ingo
> 

Re: Symmy in kde-review

[Ingo Klöcker]

On Montag, 22. April 2019 17:57:42 CEST Elvis Angelaccio wrote:
> On 12/04/19 13:12, Adriaan de Groot wrote:
> > # Runtime
> > 
> > Since it's supposed to be a CLI application, you might want to massage the
> > QPA loading a bit, since when I run it (ssh'ed in to my build machine) It
> > does
> > this:
> Note that even if it can be used from CLI, it's still a GUI app as it
> needs Qt Widgets to show the passphrase dialogs.

Hmm. I'm wondering why you don't leave the passphrase handling to gpg (resp. 
gpg-agent) which will show a passphrase dialog (via one of the pinentry 
implementations) if necessary. One of the major design goals of the gpg2 
architecture was that passphrase and secret key handling is done by gpg-agent 
exclusively.

Regards,
Ingo


signature.asc
Description: This is a digitally signed message part.

Re: Symmy in kde-review

[Elvis Angelaccio]

Hi Adriaan

On 12/04/19 13:12, Adriaan de Groot wrote:
> On Friday, April 12, 2019 10:13:10 AM CEST Jonathan Riddell wrote:
>> On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio  
> wrote:
>>> symmy has been moved to kde-review for the usual review process.
>>>
>>> It's a tiny frontend for the symmetric encryption functionality of GPG. It
>>> doesn't handle signing or public/private keys, as we already have kgpg or
>>> kleopatra for that.
>>>
>>> Symmy can be useful if you have to send some sensitive file to someone, of
>>> if you want to store it on some proprietary cloud service.
> 
> I should have piped up earlier:
> 
> # Compatibility
> 
> I wonder about Messages.sh. It claims to need bash, but I don't actually see 
> any bash-ism in it. $() command substitution is POSIX-compatible.

Fixed, thanks.

> 
> I haven't looked at tooling to produce manpages from docbook, but good on you 
> for including a manpage.
> 
> Compiled without meaningful warnings w/ clang 6 (which is often more picky 
> than gcc).
> 
> # Licensing
> 
> You might want to add SPDX identifiers to files, but that's icing on the 
> cake. 
> Looks like a consistent GPLv2+ codebase, well-documented.
> 
> # Runtime
> 
> Since it's supposed to be a CLI application, you might want to massage the 
> QPA 
> loading a bit, since when I run it (ssh'ed in to my build machine) It does 
> this:

Note that even if it can be used from CLI, it's still a GUI app as it
needs Qt Widgets to show the passphrase dialogs.

> 
> [adridg@beastie ~/src/kde/symmy/build]$ ./src/symmy 
> qt.qpa.xcb: could not connect to display 
> qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though 
> it was found.
> This application failed to start because no Qt platform plugin could be 
> initialized. Reinstalling the application may fix this problem.
> 
> Available platform plugins are: wayland-org.kde.kwin.qpa, bsdfb, minimal, 
> offscreen, vnc, xcb.
> 
> Abort trap (core dumped)
> 
> 
> 
> But overall: well done, welcome to extragear.
> 
> [ade]

Cheers,
Elvis

Re: Symmy in kde-review

[Adriaan de Groot]

On Friday, April 12, 2019 10:13:10 AM CEST Jonathan Riddell wrote:
> On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio  
wrote:
> > symmy has been moved to kde-review for the usual review process.
> > 
> > It's a tiny frontend for the symmetric encryption functionality of GPG. It
> > doesn't handle signing or public/private keys, as we already have kgpg or
> > kleopatra for that.
> > 
> > Symmy can be useful if you have to send some sensitive file to someone, of
> > if you want to store it on some proprietary cloud service.

I should have piped up earlier:

# Compatibility

I wonder about Messages.sh. It claims to need bash, but I don't actually see 
any bash-ism in it. $() command substitution is POSIX-compatible.

I haven't looked at tooling to produce manpages from docbook, but good on you 
for including a manpage.

Compiled without meaningful warnings w/ clang 6 (which is often more picky 
than gcc).

# Licensing

You might want to add SPDX identifiers to files, but that's icing on the cake. 
Looks like a consistent GPLv2+ codebase, well-documented.

# Runtime

Since it's supposed to be a CLI application, you might want to massage the QPA 
loading a bit, since when I run it (ssh'ed in to my build machine) It does 
this:

[adridg@beastie ~/src/kde/symmy/build]$ ./src/symmy 
qt.qpa.xcb: could not connect to display 
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though 
it was found.
This application failed to start because no Qt platform plugin could be 
initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-org.kde.kwin.qpa, bsdfb, minimal, 
offscreen, vnc, xcb.

Abort trap (core dumped)



But overall: well done, welcome to extragear.

[ade]


signature.asc
Description: This is a digitally signed message part.

Re: Symmy in kde-review

[Jonathan Riddell]

This has now moved into extragear/utils.

Jonathan

On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio  wrote:
>
> Hi,
> symmy has been moved to kde-review for the usual review process.
>
> It's a tiny frontend for the symmetric encryption functionality of GPG. It
> doesn't handle signing or public/private keys, as we already have kgpg or
> kleopatra for that.
>
> Symmy can be useful if you have to send some sensitive file to someone, of
> if you want to store it on some proprietary cloud service.
>
> It comes with a CLI application and plugins for GUI integration with
> Dolphin/Plasma.
>
> I'd like to move it to either extragear-utils or kde-utils, if everything
> looks good.
>
> Thanks,
> Elvis

Re: Symmy in kde-review

[Jonathan Riddell]

I'm bumping this thread again to get a decision on symmy passing
kdereview.  The technical problems have been fixed.  The question of
whether it would be better to add to kgpg is open but as it has not
been added to kgpg and nobody is planning to do so it's a moot point.
So give symmy a final review if you wish else I'll put it into
extragear.

Jonathan

On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio  wrote:
>
> Hi,
> symmy has been moved to kde-review for the usual review process.
>
> It's a tiny frontend for the symmetric encryption functionality of GPG. It
> doesn't handle signing or public/private keys, as we already have kgpg or
> kleopatra for that.
>
> Symmy can be useful if you have to send some sensitive file to someone, of
> if you want to store it on some proprietary cloud service.
>
> It comes with a CLI application and plugins for GUI integration with
> Dolphin/Plasma.
>
> I'd like to move it to either extragear-utils or kde-utils, if everything
> looks good.
>
> Thanks,
> Elvis

Re: Symmy in kde-review

[Elvis Angelaccio]

On lunedì 4 dicembre 2017 22:49:20 CET, Rolf Eike Beer wrote:

Am Montag, 4. Dezember 2017, 22:14:14 schrieb Elvis Angelaccio:

On lunedì 4 dicembre 2017 10:25:48 CET, Tomaz Canabrava wrote:

On Sun, Dec 3, 2017 at 11:14 PM, Albert Astals Cid  wrote:
El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis 
Angelaccio va


escriure: ...


Not sure, perhaps Eike can better answer that (kgpg already does symmetric
encryption).
I chose to go with an external process (+ qgpgme) for technical reasons
(basically, to not freeze the dolphin UI). Since this means we get a
self-contained binary, it can as well go in its own repo imho.


Right click on a file, Actions, Encrypt File, click Options, 
chose "symmetric 
encryption".


Too many steps for the average user, imho. This is why with symmy there is 
just "Right click -> Encrypt", done.



All in a different process, so Dolphin is not blocked.


Right. I see other issues though:

* no way to stop the job from the notification applet
* job progress is not reported

symmy uses gpgme and thus it was easy to implement the above features.

Cheers,
Elvis

Re: Symmy in kde-review

[Albert Astals Cid]

El dilluns, 4 de desembre de 2017, a les 22:32:41 CET, Elvis Angelaccio va 
escriure:
> On domenica 3 dicembre 2017 23:14:58 CET, Albert Astals Cid wrote:
> > El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va
> > 
> > escriure:
> >> Hi,
> >> symmy has been moved to kde-review for the usual review process.
> >> 
> >> It's a tiny frontend for the symmetric encryption functionality of GPG.
> >> It
> >> doesn't handle signing or public/private keys, as we already have kgpg or
> >> kleopatra for that. ...
> > 
> > I built symmy and did:
> >  * cd builddir
> >  * symmy Makefile
> >  * wrote a password
> > 
> > Now what? Where is my encrypted file?
> 
> This should be fixed now, it was a QUrl bug.
> 
> > Also i'd say that the i18n from symmy/plugin won't load the
> > symmy catalog? you
> > probably want to use the i18nd variants?
> 
> I added a TRANSLATION_DOMAIN define, is that enough?

Yeah that should work too.

Cheers,
  Albert

> 
> > And you also KLocalizedString::setApplicationDomain in your main.cpp?
> 
> Added the KLocalizedString::setApplicationDomain() call in main.cpp.
> 
> > Cheers,
> > 
> >   Albert
> >> 
> >> I'd like to move it to either extragear-utils or kde-utils, if everything
> >> looks good.
> >> 
> >> Thanks,
> >> Elvis

Re: Symmy in kde-review

[Elvis Angelaccio]

On domenica 3 dicembre 2017 23:14:58 CET, Albert Astals Cid wrote:
El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va 
escriure:

Hi,
symmy has been moved to kde-review for the usual review process.

It's a tiny frontend for the symmetric encryption functionality of GPG. It
doesn't handle signing or public/private keys, as we already have kgpg or
kleopatra for that. ...


I built symmy and did:
 * cd builddir
 * symmy Makefile 
 * wrote a password


Now what? Where is my encrypted file?


This should be fixed now, it was a QUrl bug.



Also i'd say that the i18n from symmy/plugin won't load the 
symmy catalog? you 
probably want to use the i18nd variants?


I added a TRANSLATION_DOMAIN define, is that enough?



And you also KLocalizedString::setApplicationDomain in your main.cpp?


Added the KLocalizedString::setApplicationDomain() call in main.cpp.



Cheers,
  Albert



I'd like to move it to either extragear-utils or kde-utils, if everything
looks good.

Thanks,
Elvis

Re: Symmy in kde-review

[Elvis Angelaccio]

On lunedì 4 dicembre 2017 10:25:48 CET, Tomaz Canabrava wrote:



On Sun, Dec 3, 2017 at 11:14 PM, Albert Astals Cid  wrote:
El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va
escriure:

Hi,
symmy has been moved to kde-review for the usual review process.

It's a tiny frontend for the symmetric encryption functionality of GPG. It
doesn't handle signing or public/private keys, as we already have kgpg or
kleopatra for that.


How hard would be to make that functionality to kgpg (simple 
encryption without public / private keys) instead of yet - 
another tool to handle file encryption?


Not sure, perhaps Eike can better answer that (kgpg already does symmetric 
encryption).
I chose to go with an external process (+ qgpgme) for technical reasons 
(basically, to not freeze the dolphin UI). Since this means we get a 
self-contained binary, it can as well go in its own repo imho.






Symmy can be useful if you have to send some sensitive file to someone, of
if you want to store it on some proprietary cloud service.

It comes with a CLI application and plugins for GUI integration with
Dolphin/Plasma.


I built symmy and did:
 * cd builddir
 * symmy Makefile
 * wrote a password

Now what? Where is my encrypted file?

Also i'd say that the i18n from symmy/plugin won't load the 
symmy catalog? you

probably want to use the i18nd variants?

And you also KLocalizedString::setApplicationDomain in your main.cpp?

Cheers,
  Albert



I'd like to move it to either extragear-utils or kde-utils, if everything
looks good.

Thanks,
Elvis

Re: Symmy in kde-review

[Rolf Eike Beer]

Am Montag, 4. Dezember 2017, 22:14:14 schrieb Elvis Angelaccio:
> On lunedì 4 dicembre 2017 10:25:48 CET, Tomaz Canabrava wrote:
> > On Sun, Dec 3, 2017 at 11:14 PM, Albert Astals Cid  wrote:
> > El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va
> > 
> > escriure:
> >> Hi,
> >> symmy has been moved to kde-review for the usual review process.
> >> 
> >> It's a tiny frontend for the symmetric encryption functionality of GPG.
> >> It
> >> doesn't handle signing or public/private keys, as we already have kgpg or
> >> kleopatra for that.
> > 
> > How hard would be to make that functionality to kgpg (simple
> > encryption without public / private keys) instead of yet -
> > another tool to handle file encryption?
> 
> Not sure, perhaps Eike can better answer that (kgpg already does symmetric
> encryption).
> I chose to go with an external process (+ qgpgme) for technical reasons
> (basically, to not freeze the dolphin UI). Since this means we get a
> self-contained binary, it can as well go in its own repo imho.

Right click on a file, Actions, Encrypt File, click Options, chose "symmetric 
encryption". All in a different process, so Dolphin is not blocked. If it's 
really an issue adding an own option to trigger this through their own action 
from the context menu.

Eike

signature.asc
Description: This is a digitally signed message part.

Re: Symmy in kde-review

[Tomaz Canabrava]

On Sun, Dec 3, 2017 at 11:14 PM, Albert Astals Cid  wrote:

> El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va
> escriure:
> > Hi,
> > symmy has been moved to kde-review for the usual review process.
> >
> > It's a tiny frontend for the symmetric encryption functionality of GPG.
> It
> > doesn't handle signing or public/private keys, as we already have kgpg or
> > kleopatra for that.
>

How hard would be to make that functionality to kgpg (simple encryption
without public / private keys) instead of yet - another tool to handle file
encryption?

>
> > Symmy can be useful if you have to send some sensitive file to someone,
> of
> > if you want to store it on some proprietary cloud service.
> >
> > It comes with a CLI application and plugins for GUI integration with
> > Dolphin/Plasma.
>
> I built symmy and did:
>  * cd builddir
>  * symmy Makefile
>  * wrote a password
>
> Now what? Where is my encrypted file?
>
> Also i'd say that the i18n from symmy/plugin won't load the symmy catalog?
> you
> probably want to use the i18nd variants?
>
> And you also KLocalizedString::setApplicationDomain in your main.cpp?
>
> Cheers,
>   Albert
>
> >
> > I'd like to move it to either extragear-utils or kde-utils, if everything
> > looks good.
> >
> > Thanks,
> > Elvis
>
>
>

Re: Symmy in kde-review

[Albert Astals Cid]

El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va 
escriure:
> Hi,
> symmy has been moved to kde-review for the usual review process.
> 
> It's a tiny frontend for the symmetric encryption functionality of GPG. It
> doesn't handle signing or public/private keys, as we already have kgpg or
> kleopatra for that.
> 
> Symmy can be useful if you have to send some sensitive file to someone, of
> if you want to store it on some proprietary cloud service.
> 
> It comes with a CLI application and plugins for GUI integration with
> Dolphin/Plasma.

I built symmy and did:
 * cd builddir
 * symmy Makefile 
 * wrote a password

Now what? Where is my encrypted file?

Also i'd say that the i18n from symmy/plugin won't load the symmy catalog? you 
probably want to use the i18nd variants?

And you also KLocalizedString::setApplicationDomain in your main.cpp?

Cheers,
  Albert

> 
> I'd like to move it to either extragear-utils or kde-utils, if everything
> looks good.
> 
> Thanks,
> Elvis

Symmy in kde-review

[Elvis Angelaccio]

Hi,
symmy has been moved to kde-review for the usual review process.

It's a tiny frontend for the symmetric encryption functionality of GPG. It 
doesn't handle signing or public/private keys, as we already have kgpg or 
kleopatra for that.


Symmy can be useful if you have to send some sensitive file to someone, of 
if you want to store it on some proprietary cloud service.


It comes with a CLI application and plugins for GUI integration with 
Dolphin/Plasma.


I'd like to move it to either extragear-utils or kde-utils, if everything 
looks good.


Thanks,
Elvis