Re: kwalletmanager ui refactor
On Tuesday 05 February 2013 00:28:37 Till Schäfer wrote: 2. While typing a search phrase the tree elements are collapsed and need to be opened by hand. This leads to three more clicks: - - open the folder - - the category (passwords, pairs, binary data, ...) - - select the entry I suggest to directly select the first item that matches the search phrase and open all folders which contain matching entries. 3. The search field does not have the focus when opening a wallet. You need to click in the field to start typing. It may be a good thing to have the focus directly in the search field, so that you can start typing immediately. These two items are now implemented. The code is still in the ui-refactor branch of kdeutils/kwallet. I plan to request ui-refactor branch review soon. Hopefully we'll get this refactoring out in time for 4.11. Best regards, -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
On Sunday 03 February 2013 17:50:05 Andrei Sebastian Cîmpean wrote: On Sunday 03 February 2013 16:40:04 Anders Lund wrote: Søndag den 3. februar 2013 14:50:33 skrev Valentin Rusu: Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? Anders Or just show the pane if there are more than one wallets. This is now done, e.g. the wallet list only shows when user has more than one wallet. The code is not yet merged to master, but you can check the ui-refactor branch if you're feeling adventurous :) -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
On Tuesday 12 February 2013 14:10:23 Aurélien Gâteau wrote: Le Wednesday 06 February 2013 23:14:59 Valentin Rusu a écrit : Thanks, I understand it better now. Assuming it was also possible to get a list of the authorized applications, I created a new revision of the mockups which show the list of currently connected applications as well as the list of authorized applications: http://agateau.com/tmp/kwalletmanager/3/ I think it is good to create a separate tab for those because this way the application can provide an explanation of the list(s). Being not intimate with the way KWalletManager works, I didn't understand what the Disconnect button would do. This may happen to others as well :) Nice proposal. I'll stick with your sketch as it'll provide also for the future, when we'll switch to ksecretsservice. Thanks. Great! Well, you can now see the results in kdeutils/kwallet:ui-refactor branch. Any feedback? Oh, in order to get the menus correctly built, you may want to do the make install from the ui-refactor branch. However, don't be afraid as the code is pretty stable - I'm already using it on my system. :) -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
Le Wednesday 06 February 2013 23:14:59 Valentin Rusu a écrit : Thanks, I understand it better now. Assuming it was also possible to get a list of the authorized applications, I created a new revision of the mockups which show the list of currently connected applications as well as the list of authorized applications: http://agateau.com/tmp/kwalletmanager/3/ I think it is good to create a separate tab for those because this way the application can provide an explanation of the list(s). Being not intimate with the way KWalletManager works, I didn't understand what the Disconnect button would do. This may happen to others as well :) Nice proposal. I'll stick with your sketch as it'll provide also for the future, when we'll switch to ksecretsservice. Thanks. Great! It's worth asking however if users really need a list of the applications currently accessing the wallet. I have the feeling users are more concerned about which applications are allowed to read their wallet than which applications are currently doing so, but maybe I am missing a situation in which one would want to disconnect applications? Well, it's also about providing application information for hackers. Why hide information if it's freely available? :-) Every information you expose is an information the user has to understand, so there is a balance to find here. On the other hand, this information is in a separate tab in my mockup so it is not exposed to users unless they are actively looking around. It is probably OK in this situation, as long as the short explanatory text is there. Aurélien
Re: kwalletmanager ui refactor
On 05.02.2013 21:34, Valentin Rusu wrote: On Tuesday 05 February 2013 10:49:55 Aurélien Gâteau wrote: 2. The disconnect button should be kept, in my opinnion. Here is a screen capture with the disconnect menu for my main wallet: http://imgur.com/JG6rr8b And here is another one showing the capture for another test wallet: http://imgur.com/UsKIfwH The menu entries are obtained from kwalletd which keeps track of it's clients. 4. Autorized applications tab - well I think that's not a bad idea to get it from kwallet settings here. This would be simply about managing access rights, isn't it :-) I assumed the Disconnect button listed applications authorized to access the wallet. The Authorized applications tab was thus another way to show its content. But it seems I got it wrong. What does the Disconnect button really list? kwalletd keeps track of the applications that open wallets. It's dbus interface provide a command to selectively disconnect an application from it. kwalletmanager obtains the list of the applications connected to the current wallet and build from it the popup menu under the disconnect button. Thanks, I understand it better now. Assuming it was also possible to get a list of the authorized applications, I created a new revision of the mockups which show the list of currently connected applications as well as the list of authorized applications: http://agateau.com/tmp/kwalletmanager/3/ I think it is good to create a separate tab for those because this way the application can provide an explanation of the list(s). Being not intimate with the way KWalletManager works, I didn't understand what the Disconnect button would do. This may happen to others as well :) It's worth asking however if users really need a list of the applications currently accessing the wallet. I have the feeling users are more concerned about which applications are allowed to read their wallet than which applications are currently doing so, but maybe I am missing a situation in which one would want to disconnect applications? Aurélien
Re: kwalletmanager ui refactor
On Wednesday 06 February 2013 14:28:17 Aurélien Gâteau wrote: On 05.02.2013 21:34, Valentin Rusu wrote: I assumed the Disconnect button listed applications authorized to access the wallet. The Authorized applications tab was thus another way to show its content. But it seems I got it wrong. What does the Disconnect button really list? kwalletd keeps track of the applications that open wallets. It's dbus interface provide a command to selectively disconnect an application from it. kwalletmanager obtains the list of the applications connected to the current wallet and build from it the popup menu under the disconnect button. Thanks, I understand it better now. Assuming it was also possible to get a list of the authorized applications, I created a new revision of the mockups which show the list of currently connected applications as well as the list of authorized applications: http://agateau.com/tmp/kwalletmanager/3/ I think it is good to create a separate tab for those because this way the application can provide an explanation of the list(s). Being not intimate with the way KWalletManager works, I didn't understand what the Disconnect button would do. This may happen to others as well :) Nice proposal. I'll stick with your sketch as it'll provide also for the future, when we'll switch to ksecretsservice. Thanks. It's worth asking however if users really need a list of the applications currently accessing the wallet. I have the feeling users are more concerned about which applications are allowed to read their wallet than which applications are currently doing so, but maybe I am missing a situation in which one would want to disconnect applications? Well, it's also about providing application information for hackers. Why hide information if it's freely available? :-) -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
Le Monday 04 February 2013 23:50:49 Valentin Rusu a écrit : On Monday 04 February 2013 19:28:42 Aurélien Gâteau wrote: Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO Hey, Nice work! Thanks! I put together a mockup which reorganize the buttons and split the Wallet menu. I think it make things easier to understand. You can find it here: http://agateau.com/tmp/kwalletmanager/ OK, I get the idea. Thanks for the sketches! Here is my feedback : 1. The main problem is about the two buttons new folder and delete folder. Just take a look to the existing wallet editor. Right clicking in the tree list, the one wich shows the folders, have a contextual menu, depending on what it's right clicked: - on folders you get new folder and delete this folder, - on folder items you get new ... - on passwords you get new, rename. If right clicking in this list seems not to be obvious for the users, maybe we could put a text hint saying right click the list above instead of the buttons? However, I doubt users will not try right click, as this is largely used by all the applications out-there. And it'll keep the ui less cluttered. Oh, do you mean the Wallet... menu has different content depending on the selection in the folder list? I assumed the New folder and Delete folder actions were always there and thus could be moved below the list. I agree with you we can expect users to try right-click, especially since the actions present in the folder context menus are not the most used ones. No need for a text hint. 2. The disconnect button should be kept, in my opinnion. Here is a screen capture with the disconnect menu for my main wallet: http://imgur.com/JG6rr8b And here is another one showing the capture for another test wallet: http://imgur.com/UsKIfwH The menu entries are obtained from kwalletd which keeps track of it's clients. 4. Autorized applications tab - well I think that's not a bad idea to get it from kwallet settings here. This would be simply about managing access rights, isn't it :-) I assumed the Disconnect button listed applications authorized to access the wallet. The Authorized applications tab was thus another way to show its content. But it seems I got it wrong. What does the Disconnect button really list? Finally, here is my slightly adjusted sketch version: http://www.rusu.info/kwalletmanager/ As you said, this looks closely like my second version :) Aurélien
Re: kwalletmanager ui refactor
On February 3, 2013 04:51:49 PM Thomas Lübking wrote: Btw: does anybody actually use the systray thing? I need to see that window ~ once a week and then just launch the walletmanager (so the systray icon is disabled, but that's afaik not the default, is it?) Is it really necessary to have a systray icon anyways? Or would it better to use some alternate way to deal with wallets? The icon seems to provide only three options: 1) Configure KWallet 2) Close all wallets 3) Launch the main UI. Instead of launching an extra program in the background for those functions, would we be better serviced by a plasmoid applet for dealing with 1+2+3 (or just 2+3) and using an application shortcut for 3? Having an extra program running in the background seems like a waste of resources for such a simple task. Instead it could be launched only when necessary, and the applet would handle the quick use cases. I'd think in the long run that would be the best solution for all. Matthew
Re: kwalletmanager ui refactor
Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : Hello, Lots of us are frequently using kwalletmanager to get/store the secrets for the ever extending sensitive information. We click it's icon to pop the main window, then double click the main wallet icon to pop another window, that will eventually go to the second display (that's my case). Perhaps you put aside a quick thought that this should be changed, but return to the task under hand. And then forget about this until you'll next need to use kwalletmanager. :-) During last days I finally sat down and did a ui-refactor and now kwalletmanager handles all the wallets inside a single, KPageWidget based design. A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO Hey, Nice work! I put together a mockup which reorganize the buttons and split the Wallet menu. I think it make things easier to understand. You can find it here: http://agateau.com/tmp/kwalletmanager/ Hope this is useful, Aurélien
Re: kwalletmanager ui refactor
On Sunday 03 February 2013 13:34:24 Michael Pyne wrote: On Sunday, February 03, 2013 14:50:33 Valentin Rusu wrote: During last days I finally sat down and did a ui-refactor and now kwalletmanager handles all the wallets inside a single, KPageWidget based design. A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO It looks great! One thing I'd add is that it seemed to inherit the old kwalletmanager size, which is too small for the new layout; perhaps ignore the old saved size and prefer sizeHint if the old size is sizeHint (or just have a kconf_update script which removes the old saved size?) Oh, that's not really the case. It's a size I arbitrarily decided :) However, I'll add code to save window size to the rc file. I don't intend to save window position though, to avoid troubles on multiple screens. Or perhaps should I? P.S. For those wondering how best to review in the face of the source code being moved around, try this git command line: $ git diff -M -C origin/master..origin/ui-refactor -M tries to find renames, -C tries to find copies (not that there should be any here). If you just want to see a summary you can put add --stat (but you might want to try --stat=120 to use more width, other you'll only see partial renames) Wonderful git tip! However, the reviewer should keep in mind I started the ui-refactor just after master commit f7ef5aa7cf2b35b3c942acc879 and since then I see two new commits to master. Thanks -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
El Dilluns, 4 de febrer de 2013, a les 19:28:42, Aurélien Gâteau va escriure: Le Sunday 03 February 2013 14:50:33 Valentin Rusu a écrit : Hello, Lots of us are frequently using kwalletmanager to get/store the secrets for the ever extending sensitive information. We click it's icon to pop the main window, then double click the main wallet icon to pop another window, that will eventually go to the second display (that's my case). Perhaps you put aside a quick thought that this should be changed, but return to the task under hand. And then forget about this until you'll next need to use kwalletmanager. :-) During last days I finally sat down and did a ui-refactor and now kwalletmanager handles all the wallets inside a single, KPageWidget based design. A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO Hey, Nice work! I put together a mockup which reorganize the buttons and split the Wallet menu. I think it make things easier to understand. You can find it here: http://agateau.com/tmp/kwalletmanager/ Any reason a simple app such as kwalletmanager should not follow KDE standards for UI (i.e. use a More button instead of a toolbar or a menu?) Cheers, Albert Hope this is useful, Aurélien
Re: kwalletmanager ui refactor
On Monday 04 February 2013 03:03:13 Matthew Dawson wrote: On February 3, 2013 04:51:49 PM Thomas Lübking wrote: Btw: does anybody actually use the systray thing? I need to see that window ~ once a week and then just launch the walletmanager (so the systray icon is disabled, but that's afaik not the default, is it?) Is it really necessary to have a systray icon anyways? Or would it better to use some alternate way to deal with wallets? The icon seems to provide only three options: 1) Configure KWallet 2) Close all wallets 3) Launch the main UI. Instead of launching an extra program in the background for those functions, would we be better serviced by a plasmoid applet for dealing with 1+2+3 (or just 2+3) and using an application shortcut for 3? Well, I actually plan to put in some QML UI, especially for the moment when ksecretsservice will become available. Having an extra program running in the background seems like a waste of resources for such a simple task. Instead it could be launched only when necessary, and the applet would handle the quick use cases. I'd think in the long run that would be the best solution for all. The wallet manager is not necessary to run in background. As a matter of fact, it's even not needed most of the time. For that to happen, it's enough to uncheck the show manager in system tray in system settings/account details/kde wallet. Matthew -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
kwalletmanager ui refactor
Hello, Lots of us are frequently using kwalletmanager to get/store the secrets for the ever extending sensitive information. We click it's icon to pop the main window, then double click the main wallet icon to pop another window, that will eventually go to the second display (that's my case). Perhaps you put aside a quick thought that this should be changed, but return to the task under hand. And then forget about this until you'll next need to use kwalletmanager. :-) During last days I finally sat down and did a ui-refactor and now kwalletmanager handles all the wallets inside a single, KPageWidget based design. A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO As you may see, the ancien kwalleteditor window moved inside a KPageWidgetItem. All the legacy code was left untouched. Only slight adjustements were done, to allow ui objects reference changes. I tried to preserve as much code history as possible. This also prevents regressions. The sources layout was also slightly changed to be more KF5 compliant. There's now a src subdirectory that has a manager and a konfigurator subdirectory. All this refactoring was done in a dedicated branch named ui-refactor I just pushed to the main repository. The application is fully functional and you can just checkout that branch, compile and replace your current kwalletmanager ;-) Next things to be done are: - review these changes - here I need your precious feedback - implementing features you may suggest - update the handbook - merge the code to the main branch when decided Thanks, PS I'd like to say a big *thank you* to the *gammaray* team who did a really great tool that showed very handy when analysing existing ui layout. -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
Søndag den 3. februar 2013 14:50:33 skrev Valentin Rusu: Hello, Lots of us are frequently using kwalletmanager to get/store the secrets for the ever extending sensitive information. We click it's icon to pop the main window, then double click the main wallet icon to pop another window, that will eventually go to the second display (that's my case). Perhaps you put aside a quick thought that this should be changed, but return to the task under hand. And then forget about this until you'll next need to use kwalletmanager. :-) During last days I finally sat down and did a ui-refactor and now kwalletmanager handles all the wallets inside a single, KPageWidget based design. A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? Anders
Re: kwalletmanager ui refactor
On Sunday 03 February 2013 16:40:04 Anders Lund wrote: Søndag den 3. februar 2013 14:50:33 skrev Valentin Rusu: During last days I finally sat down and did a ui-refactor and now kwalletmanager handles all the wallets inside a single, KPageWidget based design. A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? Well, you're perhaps right. I personnaly don't use more than wallet also. However, care should be taken not to induce regressions for those who use several wallets. And the code is already there :) -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
On Sonntag, 3. Februar 2013 16:40:04 CEST, Anders Lund wrote: Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? One could maybe conditionally hide the pageview (because the majortiy of ppl. will not be interested in 1 wallets but those who are will then likely prefer a more direct access?) Btw: does anybody actually use the systray thing? I need to see that window ~ once a week and then just launch the walletmanager (so the systray icon is disabled, but that's afaik not the default, is it?) Cheers, Thomas
Re: kwalletmanager ui refactor
On Sunday 03 February 2013 16:51:49 Thomas Lübking wrote: On Sonntag, 3. Februar 2013 16:40:04 CEST, Anders Lund wrote: Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? One could maybe conditionally hide the pageview (because the majortiy of ppl. will not be interested in 1 wallets but those who are will then likely prefer a more direct access?) Btw: does anybody actually use the systray thing? I'm actually using it. I prefer clicking the tray icon if it's present instead of keying-in ALT+F2. I need to see that window ~ once a week and then just launch the walletmanager (so the systray icon is disabled, but that's afaik not the default, is it?) Yes, that's not the default, but one could disable the tray icon in wallet system settings. Cheers, -- Valentin Rusu (vrusu) IRC: valir KSecretsService (aka KSecretService, KWallet replacement)
Re: kwalletmanager ui refactor
Søndag den 3. februar 2013 16:51:49 skrev Thomas Lübking: On Sonntag, 3. Februar 2013 16:40:04 CEST, Anders Lund wrote: Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? One could maybe conditionally hide the pageview (because the majortiy of ppl. will not be interested in 1 wallets but those who are will then likely prefer a more direct access?) Btw: does anybody actually use the systray thing? I need to see that window ~ once a week and then just launch the walletmanager (so the systray icon is disabled, but that's afaik not the default, is it?) I think it is on by default. I use it relatively often, but rarely more than once a day, and absolutely not every day. Anders
Re: kwalletmanager ui refactor
On Sunday, February 03, 2013 14:50:33 Valentin Rusu wrote: Hello, Lots of us are frequently using kwalletmanager to get/store the secrets for the ever extending sensitive information. We click it's icon to pop the main window, then double click the main wallet icon to pop another window, that will eventually go to the second display (that's my case). Perhaps you put aside a quick thought that this should be changed, but return to the task under hand. And then forget about this until you'll next need to use kwalletmanager. :-) During last days I finally sat down and did a ui-refactor and now kwalletmanager handles all the wallets inside a single, KPageWidget based design. A screen capture is far better than a hundred words so here it is: http://imgur.com/MD3GDxO It looks great! One thing I'd add is that it seemed to inherit the old kwalletmanager size, which is too small for the new layout; perhaps ignore the old saved size and prefer sizeHint if the old size is sizeHint (or just have a kconf_update script which removes the old saved size?) P.S. For those wondering how best to review in the face of the source code being moved around, try this git command line: $ git diff -M -C origin/master..origin/ui-refactor -M tries to find renames, -C tries to find copies (not that there should be any here). If you just want to see a summary you can put add --stat (but you might want to try --stat=120 to use more width, other you'll only see partial renames) Regards, - Michael Pyne signature.asc Description: This is a digitally signed message part.
Re: kwalletmanager ui refactor
On Sunday 03 February 2013 16:40:04 Anders Lund wrote: Søndag den 3. februar 2013 14:50:33 skrev Valentin Rusu: Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? Anders Or just show the pane if there are more than one wallets. signature.asc Description: This is a digitally signed message part.
Re: kwalletmanager ui refactor
On Sunday 03 February 2013 16:51:49 Thomas Lübking wrote: On Sonntag, 3. Februar 2013 16:40:04 CEST, Anders Lund wrote: Great to get rid of that extra window! What I think is why even the graphical representation of it? How many people have more than one wallet? And would they loose functionality if the option to switch was represented by a menu (Files-Wallet-)? I use three wallets (though one's just a backup). Can't see any harm in the extra list but wouldn't bother me too much to lose it. One could maybe conditionally hide the pageview (because the majortiy of ppl. will not be interested in 1 wallets but those who are will then likely prefer a more direct access?) Btw: does anybody actually use the systray thing? I need to see that window ~ once a week and then just launch the walletmanager (so the systray icon is disabled, but that's afaik not the default, is it?) I also use that a lot (10 times a day maybe). Looks really cool, would definitely save me a couple of clicks!
