Re: plasma-active-window-control - was -Re: 2 New Plasmoids in Kdereview

[Martin Kostolný]

Alright, I promise :). This project is now (thanks to Ben) also scheduled for 
building in KDE CI.

If there is anything I should clarify or change, please let me know.

Thanks!
Martin


On pondělí 15. ledna 2018 22:59:54 CET Albert Astals Cid wrote:
> El dilluns, 15 de gener de 2018, a les 0:15:59 CET, Martin Kostolný va 
> escriure:
> > You are right, integration of global-menu functionality is copied from
> > appmenu widget code. It is also mentioned in
> > plasma-active-window-control/plugin/README.
> > 
> > I consider it a temporary solution before a proper appmenu datasource is
> > introduced. David Edmundson wrote a while ago that the datasource is on the
> > way but it needs polishing and that I could look into that. I didn't yet
> > have enough time to look it up and dive in but I intend to.
> > 
> > In the meantime I use the copied code. Is it possible to use the existing
> > code without copying? Of course I can prepare a script that would
> > automatically copy it from another repo (plasma-workspace) and patch it but
> > it seems a bit hacky. I also don't know how would I integrate it in cmake
> > including making it work in KDE CI. Should I try to do that? Also there is
> > (I believe) no way to use a private plugin of a different widget.
> 
> Nah, don't do that, if you *promise* a solution is in the works and you'll 
> help with it i guess that's enough.
> 
> Any script or other solution will be a pain.
> 
> Cheers,
>   Albert
> 
> > 
> > Is there another way to solve this problem?
> > 
> > Thanks!
> > Martin
> > 
> > PS: It seems my mails to kde-core-devel have sometimes delays more then 1
> > day before they actually arrive to the archives. Is it normal or there is a
> > problem on my side?
> > On neděle 14. ledna 2018 23:47:53 CET Albert Astals Cid wrote:
> > > El dissabte, 13 de gener de 2018, a les 10:46:01 CET, Martin Kostolný va
> > > 
> > > escriure:
> > > > 2) On the other hand plasma-active-window-control could be part of
> > > > kdeplasma-addons because it is multiplatform, has C++ plugin and uses
> > > > e.g.
> > > > TaskManager module of Plasma which changes from time to time. So it
> > > > would
> > > > be nice to release always compatible version of this widget.
> > > 
> > > There seems to be lots of copied code in here.
> > > 
> > > Why?
> > > 
> > > Cheers,
> > > 
> > >   Albert
> 
> 

Re: plasma-active-window-control - was -Re: 2 New Plasmoids in Kdereview

[Albert Astals Cid]

El dilluns, 15 de gener de 2018, a les 0:15:59 CET, Martin Kostolný va 
escriure:
> You are right, integration of global-menu functionality is copied from
> appmenu widget code. It is also mentioned in
> plasma-active-window-control/plugin/README.
> 
> I consider it a temporary solution before a proper appmenu datasource is
> introduced. David Edmundson wrote a while ago that the datasource is on the
> way but it needs polishing and that I could look into that. I didn't yet
> have enough time to look it up and dive in but I intend to.
> 
> In the meantime I use the copied code. Is it possible to use the existing
> code without copying? Of course I can prepare a script that would
> automatically copy it from another repo (plasma-workspace) and patch it but
> it seems a bit hacky. I also don't know how would I integrate it in cmake
> including making it work in KDE CI. Should I try to do that? Also there is
> (I believe) no way to use a private plugin of a different widget.

Nah, don't do that, if you *promise* a solution is in the works and you'll 
help with it i guess that's enough.

Any script or other solution will be a pain.

Cheers,
  Albert

> 
> Is there another way to solve this problem?
> 
> Thanks!
> Martin
> 
> PS: It seems my mails to kde-core-devel have sometimes delays more then 1
> day before they actually arrive to the archives. Is it normal or there is a
> problem on my side?
> On neděle 14. ledna 2018 23:47:53 CET Albert Astals Cid wrote:
> > El dissabte, 13 de gener de 2018, a les 10:46:01 CET, Martin Kostolný va
> > 
> > escriure:
> > > 2) On the other hand plasma-active-window-control could be part of
> > > kdeplasma-addons because it is multiplatform, has C++ plugin and uses
> > > e.g.
> > > TaskManager module of Plasma which changes from time to time. So it
> > > would
> > > be nice to release always compatible version of this widget.
> > 
> > There seems to be lots of copied code in here.
> > 
> > Why?
> > 
> > Cheers,
> > 
> >   Albert

Re: plasma-active-window-control - was -Re: 2 New Plasmoids in Kdereview

[Ben Cooksley]

On Mon, Jan 15, 2018 at 12:15 PM, Martin Kostolný  wrote:
> You are right, integration of global-menu functionality is copied from 
> appmenu widget code. It is also mentioned in 
> plasma-active-window-control/plugin/README.

Hi Martin,

>
> I consider it a temporary solution before a proper appmenu datasource is 
> introduced. David Edmundson wrote a while ago that the datasource is on the 
> way but it needs polishing and that I could look into that. I didn't yet have 
> enough time to look it up and dive in but I intend to.
>
> In the meantime I use the copied code. Is it possible to use the existing 
> code without copying? Of course I can prepare a script that would 
> automatically copy it from another repo (plasma-workspace) and patch it but 
> it seems a bit hacky. I also don't know how would I integrate it in cmake 
> including making it work in KDE CI. Should I try to do that? Also there is (I 
> believe) no way to use a private plugin of a different widget.
>
> Is there another way to solve this problem?
>
> Thanks!
> Martin
>
> PS: It seems my mails to kde-core-devel have sometimes delays more then 1 day 
> before they actually arrive to the archives. Is it normal or there is a 
> problem on my side?

I've now moderated the mailing list queue, and it seems there were a
few messages stuck in there waiting for approval.
This is fairly normal for kde-core-devel, which is a moderated list.

In terms of enabling CI, please file a Sysadmin ticket and we can
arrange this fairly easily.

Cheers,
Ben


>
>
> On neděle 14. ledna 2018 23:47:53 CET Albert Astals Cid wrote:
>> El dissabte, 13 de gener de 2018, a les 10:46:01 CET, Martin Kostolný va
>> escriure:
>> > 2) On the other hand plasma-active-window-control could be part of
>> > kdeplasma-addons because it is multiplatform, has C++ plugin and uses e.g.
>> > TaskManager module of Plasma which changes from time to time. So it would
>> > be nice to release always compatible version of this widget.
>>
>> There seems to be lots of copied code in here.
>>
>> Why?
>>
>> Cheers,
>>   Albert
>
>
>
>
>

Re: plasma-active-window-control - was -Re: 2 New Plasmoids in Kdereview

[Martin Kostolný]

You are right, integration of global-menu functionality is copied from appmenu 
widget code. It is also mentioned in plasma-active-window-control/plugin/README.

I consider it a temporary solution before a proper appmenu datasource is 
introduced. David Edmundson wrote a while ago that the datasource is on the way 
but it needs polishing and that I could look into that. I didn't yet have 
enough time to look it up and dive in but I intend to.

In the meantime I use the copied code. Is it possible to use the existing code 
without copying? Of course I can prepare a script that would automatically copy 
it from another repo (plasma-workspace) and patch it but it seems a bit hacky. 
I also don't know how would I integrate it in cmake including making it work in 
KDE CI. Should I try to do that? Also there is (I believe) no way to use a 
private plugin of a different widget.

Is there another way to solve this problem?

Thanks!
Martin

PS: It seems my mails to kde-core-devel have sometimes delays more then 1 day 
before they actually arrive to the archives. Is it normal or there is a problem 
on my side?


On neděle 14. ledna 2018 23:47:53 CET Albert Astals Cid wrote:
> El dissabte, 13 de gener de 2018, a les 10:46:01 CET, Martin Kostolný va 
> escriure:
> > 2) On the other hand plasma-active-window-control could be part of
> > kdeplasma-addons because it is multiplatform, has C++ plugin and uses e.g.
> > TaskManager module of Plasma which changes from time to time. So it would
> > be nice to release always compatible version of this widget.
> 
> There seems to be lots of copied code in here.
> 
> Why?
> 
> Cheers,
>   Albert

plasma-active-window-control - was -Re: 2 New Plasmoids in Kdereview

[Albert Astals Cid]

El dissabte, 13 de gener de 2018, a les 10:46:01 CET, Martin Kostolný va 
escriure:
> 2) On the other hand plasma-active-window-control could be part of
> kdeplasma-addons because it is multiplatform, has C++ plugin and uses e.g.
> TaskManager module of Plasma which changes from time to time. So it would
> be nice to release always compatible version of this widget.

There seems to be lots of copied code in here.

Why?

Cheers,
  Albert