D12696: Use the new uds implementation

[Luca Beltrame]

lbeltrame added a comment.


  I wonder if this is related to timeline:/ no longer working properly in the 
file dialog. (didn't investigate yet).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: lbeltrame, asturmlechner, martinkostolny, kde-frameworks-devel, bruns, 
michaelh, ngraham

Re: Kde CI setup

[Ben Cooksley]

On Tue, Jun 5, 2018 at 9:37 AM, Michael Reeves  wrote:
> I am the mantainer for kdiff3. Thanks for the reply. What systems are
> currently part of this CI? I want to try and catch any issues before getting
> this turned on.

It depends on what platforms you want to have enabled.

Currently we have support for Linux, FreeBSD and Windows.
On the Binary Factory (installer generation) side, we have Windows and
macOS, although you will have to setup a Craft recipe for your
application first.

Cheers,
Ben

>
> On Mon, Jun 4, 2018, 4:24 PM Thomas Baumgart  wrote:
>>
>> Michael,
>>
>> do you work on a KDE project? Is it in the KDE git repository? If so, open
>> a sysadmin ticket to include it on the CI. If not, it might not be available
>> for your project.
>>
>> Regards
>>
>> Thomas
>>
>> On Montag, 4. Juni 2018 17:20:54 CEST Michael Reeves wrote:
>>
>> > I'm sending this again because I've been having issues with this mail
>> > ing
>> > list I haven't received any response so I don't know if it went through.
>> >
>> > On Mon, May 14, 2018, 2:19 PM Michael Reeves 
>> > wrote:
>> >
>> > > How does one use kde's ci system? Is there a way to test a projects
>> > > setup
>> > > before going live with it?
>> > >
>> >
>>
>> --
>>
>> Regards
>>
>> Thomas Baumgart
>>
>> https://www.telegram.org/   Telegram, the better WhatsApp
>> -
>> 'Debugging is twice as hard as writing the code in the first place.
>> Therefore, if you write the code as cleverly as possible, you are,
>> by definition, not smart enough to debug it.' - Brian W. Kernighan
>> -

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  I'm finding it difficult to implement it , can you help?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Can I make "show word count" checkbox as "show word count and total lines"?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  I'm unable to apply this patch, dont know why

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D12696: Use the new uds implementation

[Andreas Sturmlechner]

asturmlechner added a comment.


  No crash in my case, but this commit makes links with sftp:/ inaccessible.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: asturmlechner, martinkostolny, kde-frameworks-devel, bruns, michaelh, 
ngraham

KDE Frameworks 5.47.0 released

[David Faure]

09th June 2018. KDE today announces the release of KDE Frameworks 5.47.0.

KDE Frameworks are 78 addon libraries to Qt which provide a wide variety of·
commonly needed functionality in mature, peer reviewed and well tested·
libraries with friendly licensing terms. For an introduction see the·
Frameworks 5.0 release announcement.


Baloo

  Terminate query execution early if subterm returns empty result set
  Avoid crash when reading corrupt data from document terms db (bug 392877)
  handle string lists as input
  Ignore more types of source files (bug 382117)

Breeze Icons

  updated handles and overflow-menu

Extra CMake Modules

  Android toolchain: allow to specify extra libs manually
  Android: Don't define qml-import-paths if it's empty

KArchive

  handle zip files embedded within zip files (bug 73821)

KCMUtils

  [KCModuleQml] Ignore disabled controls when tabbing

KConfig

  kcfg.xsd - do not require a kcfgfile element

KConfigWidgets

  Fix the "Default" color scheme to match Breeze again

KDeclarative

  Set kcm context property on the correct context
  [Plotter] Don't render if m_node is null (bug 394283)

KDocTools

  Update the list of Ukrainian entities
  add entity OSD to general.entites
  Add entities CIFS, NFS, Samba, SMB to general.entities
  Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general 
entities

KFileMetaData

  check that ffmpeg is at least version 3.1 that introduce the API we require
  NOTE: in case of a compilation failure due to the ffmpeg version, apply the 
patch from https://phabricator.kde.org/D13302

  search for album artist and albumartist tags in taglibextractor
  popplerextractor: don't try to guess the title if there isn't one

KGlobalAccel

  Make sure ungrab keyboard request is processed before emitting shortcut (bug 
394689)

KHolidays #

  holiday_es_es - Fix day of the "Comunidad de Madrid"

KIconThemes

  Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

KImageFormats

  Remove duplicated mime types from json files

KIO

  Check if destination exists also when pasting binary data (bug 394318)
  Auth support: Return the actual length of socket buffer
  Auth support: Unify API for file descriptor sharing
  Auth support: Create socket file in user's runtime directory
  Auth support: Delete socket file after use
  Auth support: Move task of cleaning up socket file to FdReceiver
  Auth support: In linux don't use abstract socket to share file descriptor
  [kcoredirlister] Remove as many url.toString() as possible
  KFileItemActions: fallback to default mimetype when selecting only files (bug 
393710)
  Introduce KFileItemListProperties::isFile()
  KPropertiesDialogPlugin can now specify multiple supported protocols using 
X-KDE-Protocols
  Preserve fragment when redirecting from http to https
  [KUrlNavigator] Emit tabRequested when path in path selector menu is 
middle-clicked
  Performance: use the new uds implementation
  Don't redirect smb:/ to smb:// and then to smb:///
  Allow accepting by double-click in save dialog (bug 267749)
  Enable preview by default in the filepicker dialog
  Hide file preview when icon is too small
  i18n: use plural form again for plugin message
  Use a regular dialog rather than a list dialog when trashing or deleting a 
single file
  Make the warning text for deletion operations emphasize its permanency and 
irreversibility
  Revert "Show view mode buttons in the open/save dialog's toolbar"

Kirigami

  Show action.main more prominently on the ToolBarApplicationHeader
  Allow Kirigami build without KWin tablet mode dependency
  correct swipefilter on RTL
  correct resizing of contentItem
  fix --reverse behavior
  share contextobject to always access i18n
  make sure tooltip is hidden
  make sure to not assign invalid variants to the tracked proeprties
  handle not a MouseArea, dropped() signal
  no hover effects on mobile
  proper icons overflow-menu-left and right
  Drag handle to reorder items in a ListView
  Use Mnemonics on the toolbar buttons
  Added missing files in QMake's .pri
  [API dox] Fix Kirigami.InlineMessageType -> Kirigami.MessageType
  fix applicationheaders in applicationitem
  Don't allow showing/hiding the drawer when there's no handle (bug 393776)

KItemModels

  KConcatenateRowsProxyModel: properly sanitize input

KNotification

  Fix crashes in NotifyByAudio when closing applications

KPackage Framework

  kpackage_install_*package: fix missing dep between .desktop and .json
  make sure paths in rcc are never derived from absolute paths

KRunner

  Process DBus replies in the ::match thread (bug 394272)

KTextEditor

  Don't use title case for the "show word count" checkbox
  Make the word/char count a global preference

KWayland

  Increase org_kde_plasma_shell interface version
  Add "SkipSwitcher" to API
  Add XDG Output Protocol

KWidgetsAddons

  [KCharSelect] Fix table cell size with Qt 5.11
  [API dox] Remove usage of \overload, resulting in broken docs

KDE Frameworks 5.47.0 released

[David Faure]

09th June 2018. KDE today announces the release of KDE Frameworks 5.47.0.

KDE Frameworks are 78 addon libraries to Qt which provide a wide variety of·
commonly needed functionality in mature, peer reviewed and well tested·
libraries with friendly licensing terms. For an introduction see the·
Frameworks 5.0 release announcement.


Baloo

  Terminate query execution early if subterm returns empty result set
  Avoid crash when reading corrupt data from document terms db (bug 392877)
  handle string lists as input
  Ignore more types of source files (bug 382117)

Breeze Icons

  updated handles and overflow-menu

Extra CMake Modules

  Android toolchain: allow to specify extra libs manually
  Android: Don't define qml-import-paths if it's empty

KArchive

  handle zip files embedded within zip files (bug 73821)

KCMUtils

  [KCModuleQml] Ignore disabled controls when tabbing

KConfig

  kcfg.xsd - do not require a kcfgfile element

KConfigWidgets

  Fix the "Default" color scheme to match Breeze again

KDeclarative

  Set kcm context property on the correct context
  [Plotter] Don't render if m_node is null (bug 394283)

KDocTools

  Update the list of Ukrainian entities
  add entity OSD to general.entites
  Add entities CIFS, NFS, Samba, SMB to general.entities
  Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general 
entities

KFileMetaData

  check that ffmpeg is at least version 3.1 that introduce the API we require
  NOTE: in case of a compilation failure due to the ffmpeg version, apply the 
patch from https://phabricator.kde.org/D13302

  search for album artist and albumartist tags in taglibextractor
  popplerextractor: don't try to guess the title if there isn't one

KGlobalAccel

  Make sure ungrab keyboard request is processed before emitting shortcut (bug 
394689)

KHolidays #

  holiday_es_es - Fix day of the "Comunidad de Madrid"

KIconThemes

  Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

KImageFormats

  Remove duplicated mime types from json files

KIO

  Check if destination exists also when pasting binary data (bug 394318)
  Auth support: Return the actual length of socket buffer
  Auth support: Unify API for file descriptor sharing
  Auth support: Create socket file in user's runtime directory
  Auth support: Delete socket file after use
  Auth support: Move task of cleaning up socket file to FdReceiver
  Auth support: In linux don't use abstract socket to share file descriptor
  [kcoredirlister] Remove as many url.toString() as possible
  KFileItemActions: fallback to default mimetype when selecting only files (bug 
393710)
  Introduce KFileItemListProperties::isFile()
  KPropertiesDialogPlugin can now specify multiple supported protocols using 
X-KDE-Protocols
  Preserve fragment when redirecting from http to https
  [KUrlNavigator] Emit tabRequested when path in path selector menu is 
middle-clicked
  Performance: use the new uds implementation
  Don't redirect smb:/ to smb:// and then to smb:///
  Allow accepting by double-click in save dialog (bug 267749)
  Enable preview by default in the filepicker dialog
  Hide file preview when icon is too small
  i18n: use plural form again for plugin message
  Use a regular dialog rather than a list dialog when trashing or deleting a 
single file
  Make the warning text for deletion operations emphasize its permanency and 
irreversibility
  Revert "Show view mode buttons in the open/save dialog's toolbar"

Kirigami

  Show action.main more prominently on the ToolBarApplicationHeader
  Allow Kirigami build without KWin tablet mode dependency
  correct swipefilter on RTL
  correct resizing of contentItem
  fix --reverse behavior
  share contextobject to always access i18n
  make sure tooltip is hidden
  make sure to not assign invalid variants to the tracked proeprties
  handle not a MouseArea, dropped() signal
  no hover effects on mobile
  proper icons overflow-menu-left and right
  Drag handle to reorder items in a ListView
  Use Mnemonics on the toolbar buttons
  Added missing files in QMake's .pri
  [API dox] Fix Kirigami.InlineMessageType -> Kirigami.MessageType
  fix applicationheaders in applicationitem
  Don't allow showing/hiding the drawer when there's no handle (bug 393776)

KItemModels

  KConcatenateRowsProxyModel: properly sanitize input

KNotification

  Fix crashes in NotifyByAudio when closing applications

KPackage Framework

  kpackage_install_*package: fix missing dep between .desktop and .json
  make sure paths in rcc are never derived from absolute paths

KRunner

  Process DBus replies in the ::match thread (bug 394272)

KTextEditor

  Don't use title case for the "show word count" checkbox
  Make the word/char count a global preference

KWayland

  Increase org_kde_plasma_shell interface version
  Add "SkipSwitcher" to API
  Add XDG Output Protocol

KWidgetsAddons

  [KCharSelect] Fix table cell size with Qt 5.11
  [API dox] Remove usage of \overload, resulting in broken docs

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Thank you cullman, will try to finish it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  For the config stuff, here is a analog addition of UI parts for the "show 
word count":
  
  
https://cgit.kde.org/ktexteditor.git/patch/src/dialogs/katedialogs.cpp?id=594c51bbf61dcf7014a44727519afb4a6b58c074
  
  For the column: just ignore that, we can finish the stuff with the line ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  And about the column thing, does it have any importance rather than just 
telling the number of characters in the current line?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Now I understood,since i,m a novice can you tell how can that configuration 
option be implemented?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  Sorry, I did mix up things, more clear, hopefully:
  
  1. I think one shall have a configuration option to turn the "of ..." part 
on/off, people might not like it, and as it is always visible, that might be bad
  2. One might think about showing "Column x of y", too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Cullman I didnt get you, do u want a display for max column, isnt the maximum 
column same  as opposed to line.Is it req?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

[Christoph Cullmann]

cullmann added a comment.


  I wonder if that really makes sense, given not all blocks contain ranges at 
all and they not really correlate with the block size.
  Does that change really make it much faster or just shift the costs?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12897

To: jtamate, #kate, #frameworks
Cc: cullmann, dhaumann, mwolff, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, sars

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  Actually, it might make sense to show the maximal column, too.
  But perhaps we should make that configurable.
  Options are bad on one side, but the space in the statusbar is not that large 
if you have a smaller windows.
  Could you add a preference for that?
  We don't need a menu entry, just a global preference to show max line/column 
info.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13026: Make menu-bearing toolbar buttons show their menus with normal click rather than click-and-hold

[Nathaniel Graham]

ngraham retitled this revision from "Open Schema toolbar button with normal 
click rather than click-and-hold" to "Make menu-bearing toolbar buttons show 
their menus with normal click rather than click-and-hold".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

[Nathaniel Graham]

ngraham updated this revision to Diff 35890.
ngraham added a comment.


  Also make this change for all other toolButtons that open menus

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13026?vs=34604=35890

BRANCH
  schema-toolbar-button-opens-on-normal-click (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13026

AFFECTED FILES
  src/mode/katemodemenu.h
  src/schema/kateschema.h
  src/script/katescriptaction.cpp
  src/syntax/katehighlightmenu.h
  src/utils/kateautoindent.cpp
  src/utils/katebookmarks.cpp

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  I don't think being `delayed` was a deliberate choice; it's simply the 
default interaction method for toolbuttons that open menus in Qt (for some odd 
reason). Every menu toolbutton throughout KDE software that shows its menu 
instantly does `setDelayed(false);`, and I've never seen the menu have to 
visually build itself while open.
  
  Let me handle those other cases with this patch, too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  I was expressing support for the current state, no need for changes from my 
perspective. :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Should I display it as a fraction or leave it, having mixed reactions

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Nathaniel Graham]

ngraham added a comment.


  +1, this seems like a good way to display it to me!
  
  I rather like seeing the total number of lines, especially as implemented 
with this patch, as expressed as a sort of fraction. I think it gives the user 
a good sense of position.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Dominik Haumann]

dhaumann added a comment.


  Personally, I belong to the group that does not care about the total number 
of lines. To me, this is visual noise. The current line number is relevant for 
me, since it identifies a unique location in the document. But if you think 
this is required I will not stop this patch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham updated this revision to Diff 35886.
shubham added a comment.


  hopefully this is the final patch.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13442?vs=35881=35886

REVISION DETAIL
  https://phabricator.kde.org/D13442

AFFECTED FILES
  src/view/katestatusbar.cpp

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  Will change that too

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  It makes sense to be consistent.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  In D13442#276202 , @brauch wrote:
  
  > Since the other two number displays use QLocale().toString(), probaly this 
should too ...
  
  
  Is it mandatory?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

Re: Kde translation.

[Michael Reeves]

Thanks.

On Mon, Jun 4, 2018, 5:23 PM Albert Astals Cid  wrote:

> El dijous, 26 d’abril de 2018, a les 13:59:18 CEST, Michael Reeves va
> escriure:
> > How are translations handled as far distribution goes?
>
> This question is a bit vague.
>
> Are you asking what we do with the translations?
>   We put them in the tarballs and install them as any other regular file
>
> Are you asking how to put them in a tarball of your creation?
>   There's scripts that do it, don't roll your own, you'll do it wrong
>
> Are you asking something else?
>
> Cheers,
>   Albert
>
>
>

Re: Kde CI setup

[Michael Reeves]

I am the mantainer for kdiff3. Thanks for the reply. What systems are
currently part of this CI? I want to try and catch any issues before
getting this turned on.

On Mon, Jun 4, 2018, 4:24 PM Thomas Baumgart  wrote:

> Michael,
>
> do you work on a KDE project? Is it in the KDE git repository? If so, open
> a sysadmin ticket to include it on the CI. If not, it might not be
> available for your project.
>
> Regards
>
> Thomas
>
> On Montag, 4. Juni 2018 17:20:54 CEST Michael Reeves wrote:
>
> > I'm sending this again because I've been having issues with this mail ing
> > list I haven't received any response so I don't know if it went through.
> >
> > On Mon, May 14, 2018, 2:19 PM Michael Reeves 
> wrote:
> >
> > > How does one use kde's ci system? Is there a way to test a projects
> setup
> > > before going live with it?
> > >
> >
>
> --
>
> Regards
>
> Thomas Baumgart
>
> https://www.telegram.org/   Telegram, the better WhatsApp
> -
> 'Debugging is twice as hard as writing the code in the first place.
> Therefore, if you write the code as cleverly as possible, you are,
> by definition, not smart enough to debug it.' - Brian W. Kernighan
> -
>

D13442: Implemented displaying of total lines in kate

[Sven Brauch]

brauch added a comment.


  Since the other two number displays use QLocale().toString(), probaly this 
should too ...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Dominik Haumann]

dhaumann added a comment.


  Indeed, question is if wrapping helps: If you see 5 entries, and you see the 
last one is correct, then moving up would be ok.
  But if the completion contains >> 10 entries, this will not work. And then, 
there is still the "End" key on the keyboard as dedicated action.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12768

To: sraizada, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D12271: Don't remove trailing whitespace from cursor line

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  See arguments above: If we change it, another one will come over time and 
submit yet another patch to revert again, and again. This patch cannot go in as 
is.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12271

To: sraizada, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, dhaumann, anthonyfieroni, #ktexteditor, 
michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, 
#frameworks

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Christoph Cullmann]

cullmann added a comment.


  I think the idea was that it is an easy way out of the completion.
  I am not sure if wrapping is what one would expect.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12768

To: sraizada, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D12768: Allow wrapping selection off top/bottom of autocomplete results

[Dominik Haumann]

dhaumann added subscribers: cullmann, dhaumann.
dhaumann added a comment.


  I remember that @cullmann intentionally implemented it this way: Going 
upwards will hide the completion list and not wrap around.
  
  @cullmann Any take on this? Either accept, or reject.
  
  Also, the unit test need fixing obviously...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12768

To: sraizada, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, 
#ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, kfunk, 
sars

D12854: Awk: fix regex in a function and update syntax for gawk

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d5c5f4d3c85a: Awk: fix regex in a function and update 
syntax for gawk (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12854?vs=34098=35882

REVISION DETAIL
  https://phabricator.kde.org/D12854

AFFECTED FILES
  autotests/folding/highlight.awk.fold
  autotests/html/highlight.awk.html
  autotests/input/highlight.awk
  autotests/reference/highlight.awk.ref
  data/syntax/awk.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12854: Awk: fix regex in a function and update syntax for gawk

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me, will integrate.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  awk

REVISION DETAIL
  https://phabricator.kde.org/D12854

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

[Dominik Haumann]

dhaumann added subscribers: mwolff, dhaumann.
dhaumann added a comment.


  @mwolff To me this looks ok - do you see an issue with this? E.g. that 
KTextEditor will require much more memory for almost no gain?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12897

To: jtamate, #kate, #frameworks
Cc: dhaumann, mwolff, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, ngraham, bruns, demsking, cullmann, sars

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham updated this revision to Diff 35881.
shubham added a comment.


  This should be fine?

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13442?vs=35872=35881

REVISION DETAIL
  https://phabricator.kde.org/D13442

AFFECTED FILES
  src/view/katestatusbar.cpp

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

[Dominik Haumann]

dhaumann added a comment.


  The same holds true for other actions such as: Tools > Highlighting, Mode, 
Indentation, Script.
  
  Question here is: Is this delayed thing needed for building the contents 
on-the-fly (look at the aboutToShow() functions)?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13026

To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D13395: Pony: fix single quote escape and a possible infinite loop with #

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0ec0100e5948: Pony: fix single quote escape and a 
possible infinite loop with # (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13395?vs=35731=35880

REVISION DETAIL
  https://phabricator.kde.org/D13395

AFFECTED FILES
  autotests/folding/highlight.pony.fold
  autotests/html/highlight.pony.html
  autotests/input/highlight.pony
  autotests/reference/highlight.pony.ref
  data/syntax/pony.xml

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13395: Pony: fix single quote escape and a possible infinite loop with #

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Works - will integrate. Thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-pony

REVISION DETAIL
  https://phabricator.kde.org/D13395

To: jpoelen, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added a comment.


  As you wish , will implement in the next patch

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Christoph Cullmann]

cullmann added a comment.


  Hi,
  I can understand that some people want that, but I think in this way, it 
takes a lot of space.
  If we want that, could we not just say
  
  Line 20 of 100, Column 34?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham edited reviewers, added: brauch; removed: ngraham.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham added reviewers: cullmann, ngraham.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

Re: Closing old Plasma 4 bugs

[Boudewijn Rempt]

On vrijdag 8 juni 2018 22:37:56 CEST Nate Graham wrote:
> This work is done; all the bugs and feature requests in the plasma4
> product have been closed. Hope all of your inboxes survived the onslaught!

Nice! https://bugs.kde.org/weekly-bug-summary.cgi tells me

User# Resolved
n...@kde.org2627

which must be a record :-)

-- 
https://www.valdyas.org | https://www.krita.org

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham edited reviewers, added: KTextEditor; removed: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham edited reviewers, added: cullmann; removed: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D13442: Implemented displaying of total lines in kate

[Shubham]

shubham created this revision.
shubham added a reviewer: KTextEditor.
shubham created this object with visibility "All Users".
shubham added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Feature: 387362

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

AFFECTED FILES
  src/view/katestatusbar.cpp

To: shubham, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann