D24621: [RFC] New Konsole and Yakuake icons

[Noah Davis]

ndavis added a comment.


  The Yakuake icon is a major improvement. The little angled rectangle making 
the prompt arrow look like a Y is a little distracting, but also kind of 
charming and helps to distinguish it from Konsole. I kind of still prefer the 
plainer ">_" version though.
  
  I think the K in most of the Konsole variants is a bit too much and I think 
it would be too distracting. It's not immediately obvious that it's a K. When I 
look at it, the first thing my eyes see is "**>**__|**<**__", rather than 
"**>**__K__", which is confusing. I think that green color is not particularly 
Breeze-like and there's no clear reason why green would be a symbol for 
Konsole. The reason why blue is commonly used is because of Plasma Blue 
(`#3daee9`), Plasma's main accent/highlight color. I do like the idea of tabs 
on the bottom, but they look a bit off somehow. Maybe it's because they don't 
look like Breeze tabs? We may want to consider changing the look of Breeze tabs 
in the future though, so it's probably best if we don't try too hard to match 
the look of the Breeze widget theme. 
  Maybe something like this? I'm not sure. F7592258: 
Screenshot_20191014_011043.png  F7592287: 
konsole.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24537: Icons for windy weather

[Noah Davis]

ndavis added a comment.


  In D24537#546733 , @cblack wrote:
  
  > I think cyan is an appropriate choice considering that people tend to 
associate air with shades of blue, even if air is transparent and that's just 
the colour of the sky. The shade could be changed if necessary, but I 
personally think it looks fine.
  
  
  It just sticks out way too much. I know you like bold color choices, but it 
really bothers me. If you must pick a color, pick blue. As you said, shades of 
blue are associated with air. Blue also fits in better with the rest of 
breeze-icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24537: Icons for windy weather

[Carson Black]

cblack updated this revision to Diff 67874.
cblack added a comment.


  Shift wind emblem to the right, clean scratch work, and rename night icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24537?vs=67625=67874

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

AFFECTED FILES
  icons-dark/applets/48/weather-clear-wind-night.svg
  icons-dark/applets/48/weather-clear-wind.svg
  icons-dark/applets/48/weather-clouds-night-wind.svg
  icons-dark/applets/48/weather-clouds-wind.svg
  icons-dark/applets/48/weather-few-clouds-wind-night.svg
  icons-dark/applets/48/weather-few-clouds-wind.svg
  icons-dark/applets/48/weather-many-clouds-wind.svg
  icons-dark/applets/48/weather-overcast-wind.svg
  icons/applets/48/weather-clear-wind-night.svg
  icons/applets/48/weather-clear-wind.svg
  icons/applets/48/weather-clouds-wind.svg
  icons/applets/48/weather-few-clouds-night-wind.svg
  icons/applets/48/weather-few-clouds-wind-night.svg
  icons/applets/48/weather-few-clouds-wind.svg
  icons/applets/48/weather-many-clouds-wind.svg
  icons/applets/48/weather-overcast-wind.svg

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24537: Icons for windy weather

[Carson Black]

cblack added a comment.


  In D24537#545187 , @ndavis wrote:
  
  > That cyan looks odd. It sticks out way too much and AFAIK, it isn't 
commonly used to represent wind. Gray on more gray is going to be tricky as 
well though, especially when you've got partly cloudy vs cloudy. What if the 
wind was a bit more monochromatic? Wind is invisible, so it only really has 
shapes that are associated with how it moves around objects to represent it. 
Perhaps we can use darker colors for lighter backgrounds and lighter colors for 
darker backgrounds then? Here's an idea for an alternate shape type, but you 
don't have to use it: F7571622: Screenshot_20191011_041547.png 

  
  
  I think cyan is an appropriate choice considering that people tend to 
associate air with shades of blue, even if air is transparent and that's just 
the colour of the sky. The shade could be changed if necessary, but I 
personally think it looks fine.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis
Cc: vkrause, ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24593: Modified breeze shadows

[Lucas Andrade]

Luwx added a comment.


  Making good looking pure svg box shadows is a bit tricky.
  
  A while back I tried to create one:
  
  F7590931: shadow.png 
  
  The right one uses blur (like breeze decoration does) and the left uses 
gradients with quite a few stops to emulate the blurred square (I don't know if 
this has any effect on performance), radial gradients were used only in the 
corners.
  
  It this is of any help, here is the svg: F7590940: shadow.svg 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

[Aleix Pol]

On Sun, Oct 13, 2019 at 10:57 PM Albert Astals Cid  wrote:
>
> I find the merge behavior to be not what we've been doing in phabricator so 
> given the idea is to maintain our workflows i'd appreciate if we can agree on 
> continue doing the same.
>
> https://docs.gitlab.com/ee/user/project/merge_requests/fast_forward_merge.html

+1

This is the enterprise version though, does this apply to the community?

Adding sysadmin as CC, since they're the ones who will have to put it
to work in the end.

Aleix

D24621: [RFC] New Konsole and Yakuake icons

[Carson Black]

cblack added a comment.


  They look nice, but I'm not sure how well they fit in with other Breeze icons.
  Comparison montages:
  F7590391: image.png 
  F7590397: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24621: [RFC] New Konsole and Yakuake icons

[Mariusz Glebocki]

mglb created this revision.
mglb added reviewers: VDG, Konsole, Yakuake.
mglb added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mglb requested review of this revision.

REVISION SUMMARY
  Variants:
  
  F7589725: konsole-yakuake-icons.png 
  
  Which one do you like? The patch (so far) contains Konsole and Yakuake icons, 
48px, variant A. Personally I like variant C for Konsole the most.
  
  Note that in T10243  I've published 
following version, with slightly different colors:
  F7524018: konsole-icon.png 
  
  If you like these colors (especially dark bg), I can use them.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-konsole-yakuake-icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

AFFECTED FILES
  icons/apps/48/konsole.svg
  icons/apps/48/yakuake.svg

To: mglb, #vdg, #konsole, #yakuake
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re:Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

[Nate Graham]

+1


Nate




 On Sun, 13 Oct 2019 14:57:20 -0600 aa...@kde.org wrote 


I find the merge behavior to be not what we've been doing in phabricator so 
given the idea is to maintain our workflows i'd appreciate if we can agree on 
continue doing the same.

https://docs.gitlab.com/ee/user/project/merge_requests/fast_forward_merge.html

Opinions?

Cheers,
Albert

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

[Carl Schwan]

+ 1 Commit with the name "Merge branch 'branch-name' into 'master' are not 
helpful.

Cheers,
Carl

On Sunday, October 13, 2019 10:57:20 PM CEST Albert Astals Cid wrote:
> I find the merge behavior to be not what we've been doing in phabricator so
> given the idea is to maintain our workflows i'd appreciate if we can agree
> on continue doing the same.
> 
> https://docs.gitlab.com/ee/user/project/merge_requests/fast_forward_merge.ht
> ml
> 
> Opinions?
> 
> Cheers,
>   Albert






publickey - 
Description: application/pgp-key


signature.asc
Description: OpenPGP digital signature

Re: Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

[Nicolas Fella]

+1

On Sun, 13 Oct 2019, 22:58 Albert Astals Cid,  wrote:

> I find the merge behavior to be not what we've been doing in phabricator
> so given the idea is to maintain our workflows i'd appreciate if we can
> agree on continue doing the same.
>
>
> https://docs.gitlab.com/ee/user/project/merge_requests/fast_forward_merge.html
>
> Opinions?
>
> Cheers,
>   Albert
>
>
>

Can we agree to change gitlab default behaviour from merge to fast-forward merge for all repos?

[Albert Astals Cid]

I find the merge behavior to be not what we've been doing in phabricator so 
given the idea is to maintain our workflows i'd appreciate if we can agree on 
continue doing the same.

https://docs.gitlab.com/ee/user/project/merge_requests/fast_forward_merge.html

Opinions?

Cheers,
  Albert

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a reviewer: dfaure.
cullmann added a comment.


  Perhaps David could give feedback if the file actually captures the intend to 
do proper KDE Frameworks/libs like formatting.
  I had a mistake with the indented case statements, that should be fixed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, 
apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24620: Windows MSVC compile fix

[Christoph Cullmann]

cullmann updated this revision to Diff 67869.
cullmann added a comment.


  Missed to add file with proper compiler guard :/

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24620?vs=67867=67869

REVISION DETAIL
  https://phabricator.kde.org/D24620

AFFECTED FILES
  src/resultset.h
  src/resultset_iterator.cpp
  src/utils/lazy_val.h

To: cullmann, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24620: Windows MSVC compile fix

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  This patch is since "long" in craft blueprints, can we merge that?

TEST PLAN
  make && make test

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24620

AFFECTED FILES
  src/resultset.h
  src/resultset_iterator.cpp
  src/utils/lazy_val.h

To: cullmann, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[TrickyRicky]

trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  Please optimize the SVG files using one of these methods: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
  
  In D24598#546420 , @astippich 
wrote:
  
  > F7585764: elisaSmallNew.png 
  >
  > F7585766: elisaBigNew.png 
  
  
  About the design itself, I think the area where the "Elisa" branding was 
previously looks a bit empty now. I would suggest you either find some nice 
pattern to put there or simply center the tape window in the colored area.
  Overall I think this is a good improvement, the letters in that icon were 
what kept me from putting Elisa permanently in my dock :P

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24568: Provide clang-format target with a KDE Frameworks style file

[Milian Wolff]

mwolff added a comment.


  In D24568#545942 , @cullmann wrote:
  
  > In D24568#545736 , @apol wrote:
  >
  > > I'm not sure how this works, but would it be possible to have a target 
that only works on a patch? You usually want to make sure what you modified 
didn't diverge from the code.
  >
  >
  > I think there is some hack around that:
  >  http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
  >
  > But actually, if your sources are already clang-formatted, you just need to 
run the clang-format target once before you commit, the your new code will be 
the only thing altered.
  
  
  For our projects at work where we have the liberty to dictate the coding 
style, we also use clang format. To do that properly, we have a pre-commit 
check locally and then a gerrit bot similar to the Qt coding style bot which 
checks the formatting introduced by a patch. This way, one can be sure that the 
style doesn't deteriorate over time.
  
  Some links on that matter:
  
  - https://github.com/nghttp2/nghttp2/blob/master/pre-commit is what I use to 
check my commits, there are probably other, better hooks available somewhere, 
but this one has suited me well so far
  - when the hook complains, I run `git clang-format` which is part of the 
clang package that also ships clang-format on ArchLinux
  
  I guess the commit hook can also be used for a server check, but I'm not sure 
how this is done with gerrit for us, or how one would do it with 
phabricator/gitlab for KDE.
  
  Anyhow: big +1 form my side for using clang-format for all of KDE 
(eventually) and KDE frameworks in the near future as a starting point.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks
Cc: mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, 
apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24555: Add draw-arrow icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b55f299b1733: Add draw-arrow icons (authored by Rafael 
Brandmaier rafael.brandma...@kdemail.net).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24555?vs=67690=67864

REVISION DETAIL
  https://phabricator.kde.org/D24555

AFFECTED FILES
  icons-dark/actions/16/draw-arrow.svg
  icons-dark/actions/22/draw-arrow.svg
  icons/actions/16/draw-arrow.svg
  icons/actions/22/draw-arrow.svg

To: trickyricky26, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/12/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 13 Oct 2019 18:24:46 +
 Build duration:
2 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

Re: Get Hot New Stuff Dead or Alive?

[Ben Cooksley]

On Mon, Oct 14, 2019 at 6:06 AM Allen Winter  wrote:
>
> or maybe renamed?

Hi Allen,

>
> How do I find out if there are any GHNS for KOrganizer.
> The Import->GHNS menu in KOrganizer starts and I see the import dialog ok.
> but that dialog is empty.
>
> I need to know if something is broken with the KOrganizer implementation
> or if I should remove that feature.  Or maybe just nothing to import, which
> makes me think I should remove the feature.
>
>

As a first starting point, i'd suggest asking what endpoint your
implementation is reaching out to.
Depending on when it was last updated, there are at least 3 different
places KOrganizer could be trying to fetch from.

Two of them are essentially static, unchangeable archives for legacy
implementations now, while the other one is store.kde.org.

Cheers,
Ben

D24617: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, aacid.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to Baloo to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DBALOO_CORE_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DBALOO_CORE_NO_DEPRECATED
- -DBALOO_CORE_DEPRECATED_WARNINGS_SINCE
- -DBALOO_CORE_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build Baloo optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.55.0,
  CURRENT.

REPOSITORY
  R293 Baloo

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24617

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/resultiterator.cpp
  src/lib/resultiterator.h

To: kossebau, #frameworks, aacid
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24608: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  Seems ok for me

REPOSITORY
  R302 KIconThemes

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24608

To: kossebau, #frameworks, cfeck, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Get Hot New Stuff Dead or Alive?

[Allen Winter]

or maybe renamed?

How do I find out if there are any GHNS for KOrganizer.
The Import->GHNS menu in KOrganizer starts and I see the import dialog ok.
but that dialog is empty.

I need to know if something is broken with the KOrganizer implementation
or if I should remove that feature.  Or maybe just nothing to import, which
makes me think I should remove the feature.

D24593: Modified breeze shadows

[Filip Fila]

filipf added a comment.


  > b) radial gradients instead of linear on the four sides to make the center 
darker than the angles.
  
  Other than this, they look great to me. I think they should be uniformly 
dispersed.
  
  One of the things with shadows is that the user shouldn't really notice them. 
With the radial style I can't help but notice there's shadows missing in the 
corners.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D24593#546309 , @ngraham wrote:
  
  > In D24593#546042 , @niccolove 
wrote:
  >
  > > I'm sorry, when I use scour on svg files, it looks like git does not 
recognize that the file has changed. How can I fix that?
  >
  >
  > That means that the files actually haven't changed compared to the prior 
version. It looks like the diff is messed up and is using the scoured version 
as the base rather than the latest git master.
  
  
  It now shows me a diff, is relatively to master or to my previous svg? in 
that case, I can do another diff  without messing up 
(hopefully)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 67853.
niccolove added a comment.


  Re-done the widgets/panel-background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67852=67853

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 67852.
niccolove added a comment.


  Re-done the dialogs/background.svg

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67790=67852

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24612: Use the text rather than highlight color for rating/star emblem

[Nathaniel Graham]

ngraham added a dependent revision: D24613: Use a lighter star color for 
non-default devices.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24612

To: ngraham, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24612: Use the text rather than highlight color for rating/star emblem

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: ndavis, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The problem with using the highlight color is that the emblem becomes 
invisible when
  applied to a UI element that's selectable and (correctly) uses the default 
selection
  color. Making it use the text color instead fixes the bug in all cases.

TEST PLAN
  Stars in various UIs (Discover, Dolphin) are now black rather than blue, and 
the icon
  can now be used on buttons without becoming invisible.

REPOSITORY
  R266 Breeze Icons

BRANCH
  monochrome-rating-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24612

AFFECTED FILES
  icons/emblems/16/rating.svg
  icons/emblems/22/rating.svg
  icons/emblems/8/rating.svg

To: ngraham, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.


  Do we have tests for the thing you discovered breaks? Do we need them?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24611: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KFileMetaData to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKFILEMETADATA_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKFILEMETADATA_NO_DEPRECATED
- -DKFILEMETADATA_DEPRECATED_WARNINGS_SINCE
- -DKFILEMETADATA_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KFileMetaData optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.50.0, 5.60.0,
  CURRENT.

REPOSITORY
  R286 KFileMetaData

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24611

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/properties.h

To: kossebau, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Re: KPublicTransport in kdereview

[Albert Astals Cid]

El dissabte, 12 d’octubre de 2019, a les 12:54:31 CEST, Volker Krause va 
escriure:
> Hi,
> 
> KPublicTransport has been moved to kdereview:
> 
> https://phabricator.kde.org/source/kpublictransport/
> 
> KPublicTransport is a library for accessing real-time public transport 
> information (location, departure and journey queries) via a C++ or QML API, 
> aggregating results from Navitia.io as well as a few vendor-specific backends.
> 
> KPublicTransport originated inside KDE Itinerary but was split out at the 
> beginning of this year based on demand from KTrip. In order to get both apps 
> released eventually we need a release of KPublicTransport, therefore the 
> promotion out of playground now.
> 
> While KPublicTransport aims to become a framework, it's not mature enough for 
> committing to API stability yet I think, so the more appropriate destination 
> for now would probably be extragear/lib I guess. Becoming part of the release 
> service once that is decoupled from the Applications product would be very 
> much appreciated though.

Had a look, didn't find anything obviously wrong.

The only thing is that the public API returns const & to vectors, which we've 
historically not done since it ties you to having a vector internally forever, 
but i'm fine accepting that

Micro minor thing, clang tidy said

src/backends/abstractbackend.cpp:199:16: error: the const qualified variable 
'headers' is copy-constructed from a const reference; consider making it a 
const reference 
[performance-unnecessary-copy-initialization,-warnings-as-errors]
const auto headers = netReply->rawHeaderPairs();

Cheers,
  Albert

> 
> At this point this is would be classified as a Tier 1 Functional framework, I 
> expect this to change though once we need translated strings, which will 
> become necessary for offering a way for the user to select which backends to 
> use.
> 
> Regards,
> Volker
> 
> 

D24610: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KItemViews to hide deprecated API up to a given version 
or silence deprecation warnings after a given version, using
- -DKITEMVIEWS_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKITEMVIEWS_NO_DEPRECATED
- -DKITEMVIEWS_DEPRECATED_WARNINGS_SINCE
- -DKITEMVIEWS_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KItemViews optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.2.0, 4.4.0,
  5.0.0, 5.50.0, CURRENT.

REPOSITORY
  R276 KItemViews

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24610

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/kcategorizedsortfilterproxymodel.cpp
  src/kcategorizedsortfilterproxymodel.h
  src/kcategorizedview.cpp
  src/kcategorizedview.h
  src/kcategorydrawer.h
  src/kfilterproxysearchline.cpp
  src/kfilterproxysearchline.h
  src/klistwidgetsearchline.h
  src/ktreewidgetsearchline.h
  src/kwidgetitemdelegate.cpp
  src/kwidgetitemdelegate.h

To: kossebau, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24608: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KIconThemes to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKICONTHEMES_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKICONTHEMES_NO_DEPRECATED
- -DKICONTHEMES_DEPRECATED_WARNINGS_SINCE
- -DKICONTHEMES_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KIconThemes optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.8.0, 5.0.0,
  5.63.0, CURRENT.

REPOSITORY
  R302 KIconThemes

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24608

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Lovely!

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

[Laurent Montel]

mlaurent added reviewers: dvratil, vkrause.

REPOSITORY
  R7 Konversation

REVISION DETAIL
  https://phabricator.kde.org/D24597

To: ahmadsamir, #konversation, dvratil, vkrause
Cc: kde-frameworks-devel, #konversation

D24568: Provide clang-format target with a KDE Frameworks style file

[Olivier Churlaud]

ochurlaud added a comment.


  In D24568#546289 , @kossebau wrote:
  
  > There is also https://techbase.kde.org/Policies/Frameworks_Coding_Style 
which though missed the move from techbase to community, other than the other 
policies.
  >
  > I suspect that page should be moved over now as well, to become the real KF 
coding style page (so that "kdelibs" named one is no longer needed).
  >
  > @nalvarez @ochurlaud  Do you remember why this page was not moved?
  
  
  This must have been a mistake. Please make sure it's findable on community.ko!

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks
Cc: ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, 
ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/11/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 13 Oct 2019 12:09:04 +
 Build duration:
2 min 58 sec and counting
   CONSOLE OUTPUT
  Started by user Friedrich W. H. KossebauRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on Windows Builder 3 in C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] bat[2019-10-13T12:09:13.133Z] [2019-10-13T12:09:13.133Z] C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13>if exist "C:\CI\Software Installs\ktextwidgets" rmdir /s /q "C:\CI\Software Installs\ktextwidgets" [Pipeline] checkout[2019-10-13T12:09:15.405Z] No credentials specified[2019-10-13T12:09:15.525Z] Cloning the remote Git repository[2019-10-13T12:09:14.952Z] Cloning repository git://anongit.kde.org/ktextwidgets[2019-10-13T12:09:14.952Z]  > git init C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13 # timeout=10[2019-10-13T12:09:16.276Z] Fetching upstream changes from git://anongit.kde.org/ktextwidgets[2019-10-13T12:09:16.277Z]  > git --version # timeout=10[2019-10-13T12:09:16.498Z]  > git fetch --tags --progress git://anongit.kde.org/ktextwidgets +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-13T12:11:14.163Z] Checking out Revision 5cd5d6a412d146b683c7afad1b77035b19dd6cd4 (origin/master)[2019-10-13T12:11:10.808Z]  > git config remote.origin.url git://anongit.kde.org/ktextwidgets # timeout=10[2019-10-13T12:11:11.004Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-13T12:11:11.382Z]  > git config remote.origin.url git://anongit.kde.org/ktextwidgets # timeout=10[2019-10-13T12:11:11.775Z] Fetching upstream changes from git://anongit.kde.org/ktextwidgets[2019-10-13T12:11:11.775Z]  > git fetch --tags --progress git://anongit.kde.org/ktextwidgets +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-13T12:11:13.146Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-10-13T12:11:13.501Z]  > git config core.sparsecheckout # timeout=10[2019-10-13T12:11:13.735Z]  > git checkout -f 5cd5d6a412d146b683c7afad1b77035b19dd6cd4 # timeout=10[2019-10-13T12:11:21.131Z] Commit message: "Use ECMGenerateExportHeader to manage deprecated API better"[2019-10-13T12:11:20.468Z]  > git rev-list --no-walk 5cd5d6a412d146b683c7afad1b77035b19dd6cd4 # timeout=10[Pipeline] checkout[2019-10-13T12:11:22.146Z] No credentials specified[2019-10-13T12:11:22.231Z] Cloning the remote Git repository[2019-10-13T12:11:21.568Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-10-13T12:11:21.569Z]  > git init C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13\ci-tooling # timeout=10[2019-10-13T12:11:23.428Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-10-13T12:11:23.429Z]  > git --version # timeout=10[2019-10-13T12:11:23.735Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-13T12:12:01.452Z] ERROR: Error cloning remote repo 'origin'[2019-10-13T12:12:01.452Z] hudson.plugins.git.GitException: Command "git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2019-10-13T12:12:01.452Z] stdout: [2019-10-13T12:12:01.452Z] stderr: fatal: unable to access 'https://anongit.kde.org/sysadmin/ci-tooling/': OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to anongit.kde.org:443 [2019-10-13T12:12:01.452Z] [2019-10-13T12:12:01.452Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-10-13T12:12:01.452Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1905)[2019-10-13T12:12:01.452Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:81)[2019-10-13T12:12:01.452Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:488)[2019-10-13T12:12:01.452Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:712)[2019-10-13T12:12:01.452Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2019-10-13T12:12:01.452Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2019-10-13T12:12:01.452Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2019-10-13T12:12:01.452Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2019-10-13T12:12:01.452Z] 	at 

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.13/10/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 13 Oct 2019 11:41:13 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] Start of Pipeline[Pipeline] nodeRunning on Windows Builder 3 in C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] bat[2019-10-13T11:41:19.691Z] [2019-10-13T11:41:19.691Z] C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13>if exist "C:\CI\Software Installs\ktextwidgets" rmdir /s /q "C:\CI\Software Installs\ktextwidgets" [Pipeline] checkout[2019-10-13T11:41:33.230Z] No credentials specified[2019-10-13T11:41:33.315Z] Cloning the remote Git repository[2019-10-13T11:41:32.771Z] Cloning repository git://anongit.kde.org/ktextwidgets[2019-10-13T11:41:32.771Z]  > git init C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13 # timeout=10[2019-10-13T11:43:58.489Z] Fetching upstream changes from git://anongit.kde.org/ktextwidgets[2019-10-13T11:43:58.489Z]  > git --version # timeout=10[2019-10-13T11:43:59.285Z]  > git fetch --tags --progress git://anongit.kde.org/ktextwidgets +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-13T11:48:08.797Z]  > git config remote.origin.url git://anongit.kde.org/ktextwidgets # timeout=10[2019-10-13T11:48:11.883Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-13T11:48:12.265Z]  > git config remote.origin.url git://anongit.kde.org/ktextwidgets # timeout=10[2019-10-13T11:48:13.937Z] Fetching upstream changes from git://anongit.kde.org/ktextwidgets[2019-10-13T11:48:13.937Z]  > git fetch --tags --progress git://anongit.kde.org/ktextwidgets +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-10-13T11:49:27.190Z] Checking out Revision 5cd5d6a412d146b683c7afad1b77035b19dd6cd4 (origin/master)[2019-10-13T11:49:23.764Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-10-13T11:49:26.559Z]  > git config core.sparsecheckout # timeout=10[2019-10-13T11:49:26.723Z]  > git checkout -f 5cd5d6a412d146b683c7afad1b77035b19dd6cd4 # timeout=10[2019-10-13T11:49:40.245Z] Commit message: "Use ECMGenerateExportHeader to manage deprecated API better"[2019-10-13T11:49:39.614Z]  > git rev-list --no-walk 151ae7ea072c25f2ce196e280c8ba64a74652dc3 # timeout=10[Pipeline] checkout[2019-10-13T11:49:47.611Z] No credentials specified[2019-10-13T11:49:47.702Z] Cloning the remote Git repository[2019-10-13T11:49:47.060Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-10-13T11:49:47.060Z]  > git init C:\CI\workspace\Frameworks\ktextwidgets\kf5-qt5 WindowsMSVCQt5.13\ci-tooling # timeout=10[2019-10-13T11:49:49.494Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-10-13T11:49:49.495Z]  > git --version # timeout=10[2019-10-13T11:49:49.747Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-10-13T11:55:50.770Z] ERROR: Error cloning remote repo 'origin'[2019-10-13T11:55:50.770Z] hudson.plugins.git.GitException: Command "git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/*" returned status code 128:[2019-10-13T11:55:50.770Z] stdout: [2019-10-13T11:55:50.770Z] stderr: fatal: unable to access 'https://anongit.kde.org/sysadmin/ci-tooling/': OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to anongit.kde.org:443 [2019-10-13T11:55:50.770Z] [2019-10-13T11:55:50.770Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2318)[2019-10-13T11:55:50.770Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1905)[2019-10-13T11:55:50.770Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$400(CliGitAPIImpl.java:81)[2019-10-13T11:55:50.770Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:488)[2019-10-13T11:55:50.770Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:712)[2019-10-13T11:55:50.770Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)[2019-10-13T11:55:50.770Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)[2019-10-13T11:55:50.770Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)[2019-10-13T11:55:50.770Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)[2019-10-13T11:55:50.770Z] 	at hudson.remoting.Request$2.run(Request.java:369)[2019-10-13T11:55:50.770Z] 	at 

D24595: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R310:5cd5d6a412d1: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R310 KTextWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24595?vs=67793=67837

REVISION DETAIL
  https://phabricator.kde.org/D24595

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/widgets/ktextedit.h

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[Alexander Stippich]

astippich added a comment.


  F7585764: elisaSmallNew.png 
  
  F7585766: elisaBigNew.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24598: Update elisa icon

[Alexander Stippich]

astippich updated this revision to Diff 67836.
astippich added a comment.


  - update

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=67799=67836

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann retitled this revision from "Provide clang-format target with a common 
KDE style file" to "Provide clang-format target with a KDE Frameworks style 
file".

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks
Cc: ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, 
ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24597: [Konversation] Port from deprecated KTcpSocket to QSslSocket

[Ahmad Samir]

ahmadsamir updated this revision to Diff 67835.
ahmadsamir retitled this revision from "Port from deprecated KTcpSocket to 
QSslSocket" to "[Konversation] Port from deprecated KTcpSocket to QSslSocket".
ahmadsamir added a comment.


  Better commit message

REPOSITORY
  R7 Konversation

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24597?vs=67833=67835

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24597

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/irc/server.cpp
  src/irc/server.h

To: ahmadsamir, #konversation
Cc: kde-frameworks-devel, #konversation

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

[Ahmad Samir]

ahmadsamir updated this revision to Diff 67834.
ahmadsamir retitled this revision from "[SslUi] Overload askIgnoreSslErrors() 
to take a QSslSocket" to "[SslUi] Add api docs for askIgnoreSslErrors()".
ahmadsamir added a comment.


  Since I wrote the docs bit anyway

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24588?vs=67818=67834

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24588

AFFECTED FILES
  src/widgets/sslui.h

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[Ahmad Samir]

ahmadsamir removed a task: T11577: Port Konversation away from KTcpSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24597: Port from deprecated KTcpSocket to QSslSocket

[Ahmad Samir]

ahmadsamir updated this revision to Diff 67833.
ahmadsamir edited the summary of this revision.
ahmadsamir removed reviewers: hein, mlaurent.
ahmadsamir added a comment.


  Use KSslErrorUiData directly when calling askIgnoreSslErrors

REPOSITORY
  R7 Konversation

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24597?vs=67798=67833

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24597

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/irc/server.cpp
  src/irc/server.h

To: ahmadsamir, #konversation, hein, mlaurent
Cc: kde-frameworks-devel, #konversation

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[Ahmad Samir]

ahmadsamir added a comment.


  In D24588#546367 , @vkrause wrote:
  
  > In D24588#546229 , @dfaure wrote:
  >
  > > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or 
even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  > >  Don't know, just wondering (not objecting). @vkrause, any opinion?
  >
  >
  > That would be my gut feeling as well, ie. have sslui depend on the abstract 
error representation, not on all possible error sources. OTOH it's not changing 
the dependency situation overall here so no strong objection to that either. In 
any case the KTcpSocket variant should be deprecated eventually.
  
  
  That makes more sense, (so I take what I said previously back... partly 
anyway; this way the implementation detail, i.e. the socket type, is hidden 
from SslUi so that it needs only a KSslErrorUiData).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24603: Port away from deprecated KDELibs4Support

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R103:e3b8910670e3: Port away from deprecated KDELibs4Support 
(authored by ahmadsamir).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24603?vs=67820=67831

REVISION DETAIL
  https://phabricator.kde.org/D24603

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  treeview.cpp

To: ahmadsamir, mlaurent, vkrause
Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24603: Port away from deprecated KDELibs4Support

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.


  Thanks!

REPOSITORY
  R103 KMenu Editor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24603

To: ahmadsamir, mlaurent, vkrause
Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

[Volker Krause]

vkrause added a comment.


  In D24588#546229 , @dfaure wrote:
  
  > Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or 
even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`.
  >  Don't know, just wondering (not objecting). @vkrause, any opinion?
  
  
  That would be my gut feeling as well, ie. have sslui depend on the abstract 
error representation, not on all possible error sources. OTOH it's not changing 
the dependency situation overall here so no strong objection to that either. In 
any case the KTcpSocket variant should be deprecated eventually.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

[Volker Krause]

vkrause updated this revision to Diff 67828.
vkrause added a comment.
This revision is now accepted and ready to land.


  Deal with errors with full QSslError level of detail until kssld is ported, 
make variables const.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24590?vs=67785=67828

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

[Volker Krause]

vkrause planned changes to this revision.
vkrause added a comment.


  This actually breaks things when the error comes from a Qt source rather than 
a KIO one, as we now carry the QSslError level of detail forward far enough and 
compare it to the stored KSslError. This is a temporary problem until the kssld 
side is ported too, but it nevertheless needs a workaround until that is done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24603: Port away from deprecated KDELibs4Support

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R103 KMenu Editor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24603

To: ahmadsamir, mlaurent
Cc: plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24595: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24595

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[Matthieu Gallien]

mgallien added a comment.


  In D24598#546135 , @astippich 
wrote:
  
  > I have no intention on taking over D12992 
 as I would like rather like to code for 
Elisa. I am no designer.
  >  I was unsatisfied with the icon and @mgallien agreed on some slight 
adjustments to the current one.
  >  D12992  has been around for ages. I 
hope that this incremental update can be agreed upon faster and land for next 
frameworks release. Especially I find the "Elisa" text ugly and worth removing 
it quickly.
  
  
  I am in support of the work that is done here. Thanks @astippich

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien
Cc: GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, mnesbitt, LeGast00n, 
carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, ashwind, 
fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, lcmscheid, 
nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, ngraham, bruns, 
kmf, lemuel, mgallien