Re: Proposal: "Noteworthy" label for Promo application updates

[Nate Graham]

Given the impending GitLab transition, it might make more sense to just 
use GitLab's tags/labels feature, yeah. That solves the problem of 
people forgetting to use the keyword before committing since it can 
always be added later, and it makes it easy for promo people to find the 
relevant commits using the web interface so they don't have to check out 
every repo and use a script.


Nate


On 4/19/20 2:34 AM, XYQuadrat wrote:
If we implement such a system (that is, just resurrect what is already 
present), I definitely think it would be sensible to make guidelines on 
what commits we are interested in publicly available.
The thing I'm not sure about is how easy it'd be to automate grabbing 
all the CHANGELOG commits from a given date range - can someone more 
experienced with our git/repo infrastructure shed some light here?


Best regards,
Julian / xyquadrat

On 17.04.20 01:19, Johannes Zarl-Zierl wrote:

On Donnerstag, 16. April 2020 23:15:18 CEST Nate Graham wrote:

On 4/16/20 2:38 PM, Albert Astals Cid wrote:

It may make sense to highlight them a bit more somehow, suggestions
welcome i guess.

The promo people just need a list of all CHANGELOG entries in a release
so they can rewrite it in more human-friendly terms. Right now this is
done manually by me and others by looking through commit logs and blog
posts and adding the equivalent of CHANGELOG text into an
etherpad/share.kde.org document. Automating that somehow would be nice.
From a developer point of view, a tag in the commit itself seems like 
a nice
interface. One thing I fear, though, is that people like me forget to 
actually

add it to the commit before pushing, so maybe something that can be added
later would definitely have its advantages.

Personally, I'd like to have some clear guidelines from the promo team 
on what

kind of features they are looking for. That way it's way easier for me to
match those expectations ;-)

Btw. isn't the DIGEST keyword as documented in the standard commit 
template

basically the same idea?

Cheers,
Johannes

D29032: Add 16px Vvave icon

[Noah Davis]

ndavis added a comment.


  There is already a newer vvave icon with a different style, but not at 16px.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29032

To: manueljlin, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29033: Remove duplicated code

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Went through it while reviewing some code.

TEST PLAN
  Been running it for a while, including direct testing of the code while 
investigating something else

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29033

AFFECTED FILES
  src/windowsystem/waylandintegration.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Downtime for SVN - Action Required

[Nicolás Alvarez]

Translations are still in SVN, they have not moved to Git. We only
moved the SVN repository to a different server, and integrated SVN ssh
key management with the GitLab website.

-- 
Nicolás

El lun., 20 de abr. de 2020 a la(s) 19:56, Agron Selimaj
(as9902...@gmail.com) escribió:
>
> Guys I just need a little clarification for submitting translated file to the 
> gitlab repository.
>
> My first question is - is the migration over and can I submit translated 
> files?
>
> Second, with SVN all I did was commit (of course after compiling and other 
> tests). Now with Git, I fork + clone, translate and then send a merge 
> request? Right? Is there a guide for submitting po files?
>
> Third, I need a little git/kde geography. What path do I clone from, from 
> git? Is there an efficient path that concerns translations only or more 
> specifically albanian translations.
>
> Thanks,
> //Agron
>
>
>
>
> On Sat, Apr 18, 2020 at 6:36 AM Nicolás Alvarez  wrote:
>>
>> El dom., 12 de abr. de 2020 a la(s) 05:57, Ben Cooksley
>> (bcooks...@kde.org) escribió:
>> >
>> > Hi all,
>> >
>> > As you may be aware, KDE is currently undertaking a migration to Gitlab.
>> >
>> > As part of this, we also need to migrate our Subversion repository
>> > from the server it currently resides on to the new system that also
>> > hosts Gitlab. To simplify our systems we will also transition
>> > management of SSH keys to Gitlab when we do this.
>> >
>> > It is intended at this time that we perform the migration of the
>> > Subversion repository next weekend.
>> >
>> > We therefore need all holders of a Developer account, even if they
>> > only use our Subversion repository, to login to Gitlab and upload
>> > their SSH keys there.
>> >
>> > Our Gitlab instance can be found at https://invent.kde.org/ and you
>> > should be able to login there using your KDE Identity
>> > (identity.kde.org) details.
>> >
>> > Additionally, following this migration we will begin limiting access
>> > to the Subversion repository to those actively using it. The list of
>> > people whose access will be continued can be found at
>> > https://cgit.kde.org/repo-management.git/tree/svn-ssh-keys/users-list
>> >
>> > Should you still need access to the repository, but are not on the
>> > above list, please let us know by emailing sysad...@kde.org.
>> >
>> > If anyone has any questions on the above, please let us know.
>>
>> Hi all,
>>
>> I wanted to add that this server migration will also change the SSH
>> host keys for "svn.kde.org". After we switch servers, you will get the
>> nasty "WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!" message from
>> ssh when you use SVN. To avoid this, you should add the new keys to
>> your ~/.ssh/known_hosts. You don't need to wait for the server switch,
>> you can add it now (keeping both old and new keys in the file) and it
>> will Just Work.
>>
>> I have added instructions for all these changes and the new ssh host
>> keys to the wiki:
>> https://community.kde.org/Infrastructure/Subversion/2020_Changes
>>
>> --
>> Nicolás
>> KDE Sysadmin Team

Re: Downtime for SVN - Action Required

[Nicolás Alvarez]

Translations are still in SVN, they have not moved to Git. We only
moved the SVN repository to a different server, and integrated SVN ssh
key management with the GitLab website.

-- 
Nicolás

El lun., 20 de abr. de 2020 a la(s) 19:56, Agron Selimaj
(as9902...@gmail.com) escribió:
>
> Guys I just need a little clarification for submitting translated file to the 
> gitlab repository.
>
> My first question is - is the migration over and can I submit translated 
> files?
>
> Second, with SVN all I did was commit (of course after compiling and other 
> tests). Now with Git, I fork + clone, translate and then send a merge 
> request? Right? Is there a guide for submitting po files?
>
> Third, I need a little git/kde geography. What path do I clone from, from 
> git? Is there an efficient path that concerns translations only or more 
> specifically albanian translations.
>
> Thanks,
> //Agron
>
>
>
>
> On Sat, Apr 18, 2020 at 6:36 AM Nicolás Alvarez  wrote:
>>
>> El dom., 12 de abr. de 2020 a la(s) 05:57, Ben Cooksley
>> (bcooks...@kde.org) escribió:
>> >
>> > Hi all,
>> >
>> > As you may be aware, KDE is currently undertaking a migration to Gitlab.
>> >
>> > As part of this, we also need to migrate our Subversion repository
>> > from the server it currently resides on to the new system that also
>> > hosts Gitlab. To simplify our systems we will also transition
>> > management of SSH keys to Gitlab when we do this.
>> >
>> > It is intended at this time that we perform the migration of the
>> > Subversion repository next weekend.
>> >
>> > We therefore need all holders of a Developer account, even if they
>> > only use our Subversion repository, to login to Gitlab and upload
>> > their SSH keys there.
>> >
>> > Our Gitlab instance can be found at https://invent.kde.org/ and you
>> > should be able to login there using your KDE Identity
>> > (identity.kde.org) details.
>> >
>> > Additionally, following this migration we will begin limiting access
>> > to the Subversion repository to those actively using it. The list of
>> > people whose access will be continued can be found at
>> > https://cgit.kde.org/repo-management.git/tree/svn-ssh-keys/users-list
>> >
>> > Should you still need access to the repository, but are not on the
>> > above list, please let us know by emailing sysad...@kde.org.
>> >
>> > If anyone has any questions on the above, please let us know.
>>
>> Hi all,
>>
>> I wanted to add that this server migration will also change the SSH
>> host keys for "svn.kde.org". After we switch servers, you will get the
>> nasty "WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!" message from
>> ssh when you use SVN. To avoid this, you should add the new keys to
>> your ~/.ssh/known_hosts. You don't need to wait for the server switch,
>> you can add it now (keeping both old and new keys in the file) and it
>> will Just Work.
>>
>> I have added instructions for all these changes and the new ssh host
>> keys to the wiki:
>> https://community.kde.org/Infrastructure/Subversion/2020_Changes
>>
>> --
>> Nicolás
>> KDE Sysadmin Team

D29032: Add 16px Vvave icon

[Manuel Jesús de la Fuente]

manueljlin created this revision.
manueljlin added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
manueljlin requested review of this revision.

REVISION SUMMARY
  This adds a 16px version of the "babe.svg" icon

REPOSITORY
  R266 Breeze Icons

BRANCH
  vvave16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29032

AFFECTED FILES
  icons-dark/apps/16/babe.svg
  icons/apps/16/babe.svg

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29018: Align description in metainfo.yaml with the one of README.md

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R174 KContacts

BRANCH
  fixmetainfodescription

REVISION DETAIL
  https://phabricator.kde.org/D29018

To: kossebau, mlaurent, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D7563: Add privilegeExecution field to file protocol description

[Alexander Saoutkin]

feverfew added a comment.


  In D7563#653171 , @elvisangelaccio 
wrote:
  
  > In D7563#650117 , @ngraham wrote:
  >
  > > [insert I-have-no-idea-what-I'm-doing dog meme here]
  > >
  > > When trying to create items in root-owned locations, I'm getting an 
errors saying "The process for the file protocol died unexpectedly." or else 
Dolphin simply crashes with a totally unhelpful backtrace.
  >
  >
  > If it's still happening, please have a look at 
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves
  
  
  I managed to find and fix one of the crashes (not sure if it's the same one 
that @ngraham had).
  
  However, even with this patch I can't get it to work, I notice this in the 
debug output: `kf5.kauth tried to start an invalid action`
  
  This sounds to me like I'm testing wrong but I can't tell what...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D7563#650117 , @ngraham wrote:
  
  > [insert I-have-no-idea-what-I'm-doing dog meme here]
  >
  > When trying to create items in root-owned locations, I'm getting an errors 
saying "The process for the file protocol died unexpectedly." or else Dolphin 
simply crashes with a totally unhelpful backtrace.
  
  
  If it's still happening, please have a look at 
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/Debugging_IOSlaves

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/12/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 20 Apr 2020 22:00:07 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

On Thu, Apr 16, 2020 at 10:26 PM David Edmundson
 wrote:
>
> > Given Doodle's take forever and everyone's probably quarantined
> > anyway, I propose we do it just after the Monday Plasma meeting. If
> > someone is eager to share an opinion and can't make that, message here
> > and we'll choose something more formally.
>
> That didn't really work out. Doodle it is!
>
> https://doodle.com/poll/k8gzdvwhgibn7hma
>
> Then we'll meet in #kwin on IRC

Decision made, lets have an IRC meeting Thursday 17.30 European Time
(please adjust for your timezone, or see Doodle).
Let's all agree on a decision (though I think there's some direction)
by the end of that meeting with some action plans for both client and
server both shortterm and long term.

David

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

> > The slight twist on that which we need to be wary of is that client
> > code will return shared objects if you request a
> > KWaylandClient::PlasmaShellSurface::get(window())
> > for the same window from two places you'll get the same PlasmaShell
> > instance returned - and therefore the same wl_resource.
> > If we hypothetically had a kwayland2::client also have a
> > plasmashellsurface::get() method we would have two plasma_shellsurface
> > wl_resources's for the same wl_surface which is a protocol error and
> > our client will get violently killed.
>
> Honestly you lost me here. :-)

Mixing libs for different protocols within one client is ok.
Mixing libs for the same protocol within one client is bad.

Hopefully the other kwin people will understand what I meant.

David

D29027: Move document corner fold to top right in two icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 424 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/424/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 20 Apr 2020 21:42:21 +
 Build duration:
4 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 7 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.pagepool/tst_pagepool.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_actiontoolbar.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerouter.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/5)0%
(0/34)0%
(0/34)0%
(0/3624)0%
(0/2445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/1)0%
(0/1)0%
(0/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/19)0%
(0/19)0%
(0/2612)0%
(0/1694)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/691)0%
(0/603)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

D29027: Move document corner fold to top right in two icons

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/27/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 20 Apr 2020 21:41:28 +
 Build duration:
3 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 7 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.pagepool/tst_pagepool.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_actiontoolbar.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerouter.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/5)0%
(0/34)0%
(0/34)0%
(0/3624)0%
(0/2445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/1)0%
(0/1)0%
(0/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/19)0%
(0/19)0%
(0/2612)0%
(0/1694)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/691)0%
(0/603)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 423 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/423/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 20 Apr 2020 21:38:17 +
 Build duration:
4 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 7 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.pagepool/tst_pagepool.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_actiontoolbar.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerouter.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/5)0%
(0/34)0%
(0/34)0%
(0/3624)0%
(0/2445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/1)0%
(0/1)0%
(0/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/19)0%
(0/19)0%
(0/2612)0%
(0/1694)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/691)0%
(0/603)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 26 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/26/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 20 Apr 2020 21:38:17 +
 Build duration:
3 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 7 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.pagepool/tst_pagepool.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_actiontoolbar.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerouter.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/5)0%
(0/34)0%
(0/34)0%
(0/3624)0%
(0/2445)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests0%
(0/1)0%
(0/1)0%
(0/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/19)0%
(0/19)0%
(0/2612)0%
(0/1694)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/691)0%
(0/603)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Nathaniel Graham]

ngraham added a comment.


  I pondered that myself but every app needs to implement its own behavior, and 
we're not even consistent about making this a toggle action vs two separate 
actions.
  
  That alone is probably a good reason to make a standard action, though.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28802

To: ngraham, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Does it make sense to also create a standard action in kconfigwidgets?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28802

To: ngraham, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28802: Add standard shortcut for "Show/Hide Hidden Files"

[Elvis Angelaccio]

elvisangelaccio added a comment.


  > and F8 seems kind of random.
  
  I was asking myself why F8 was chosen and yes, it looks like it was totally 
random: 
https://github.com/KDE/kdelibs/commit/8e26f7410a9280b504d97cdfbe5d3568cfa7b9d4

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28802

To: ngraham, dfaure, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29027: Move document corner fold to top right in two icons

[David Hurka]

davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two icons

[David Hurka]

davidhurka updated this revision to Diff 80707.
davidhurka added a comment.


  - Use Highlight instead of ButtonFocus, Noah already decided that somewhere 
else

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29027?vs=80702=80707

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

AFFECTED FILES
  icons-dark/actions/16/document-close.svg
  icons-dark/actions/16/gnumeric-link-internal.svg
  icons-dark/actions/22/document-close.svg
  icons-dark/actions/22/gnumeric-link-internal.svg
  icons/actions/16/document-close.svg
  icons/actions/16/gnumeric-link-internal.svg
  icons/actions/22/document-close.svg
  icons/actions/22/gnumeric-link-internal.svg

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two icons

[David Hurka]

davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R292:be0ef896c3f3: Add imperial gallon and US pint (authored 
by riiga, committed by ngraham).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28995?vs=80686=80703

REVISION DETAIL
  https://phabricator.kde.org/D28995

AFFECTED FILES
  src/fuel_efficiency.cpp
  src/unit.h
  src/volume.cpp

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D28995: Add imperial gallon and US pint

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, and sorry for the earlier confusion.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29027: Move document corner fold to top right in two icons

[David Hurka]

davidhurka retitled this revision from "Move document corner fold to top right 
in two icons

This updates document-close in the sizes below 32px and gnumeric-link-internal 
to the new style. I forgot them in D28203.
gnumeric-link-internal uses ButtonFocus." to "Move document corner fold to top 
right in two icons".
davidhurka edited the summary of this revision.
davidhurka edited the test plan for this revision.
davidhurka added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two iconsThis updates document-close in the sizes below 32px and gnumeric-link-internal to the new style. I forgot them in D28203.gnumeric-link-intern

[David Hurka]

davidhurka created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidhurka requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

AFFECTED FILES
  icons-dark/actions/16/document-close.svg
  icons-dark/actions/16/gnumeric-link-internal.svg
  icons-dark/actions/22/document-close.svg
  icons-dark/actions/22/gnumeric-link-internal.svg
  icons/actions/16/document-close.svg
  icons/actions/16/gnumeric-link-internal.svg
  icons/actions/22/document-close.svg
  icons/actions/22/gnumeric-link-internal.svg

To: davidhurka
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Nathaniel Graham]

ngraham added a comment.


  T13008: Figure out a good UI for the "show which settings have been changed" 
feature 

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: abetts, bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Nathaniel Graham]

ngraham added a comment.


  Let's have the rest of the discussion in a central phab patch, which I 
probably should have pushed for at the start. I'll make one...

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: abetts, bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Noah Davis]

ndavis added a comment.


  I'm sorry this happened. I was working with what I could see. For what it's 
worth, I would have accepted it if you said it could not be done well. I know I 
don't know as much about the technical side of this as you do.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: abetts, bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

Re: Proposal: "Noteworthy" label for Promo application updates

[Johannes Zarl-Zierl]

On Montag, 20. April 2020 13:46:47 CEST Carl Schwan wrote:
> I think the easiest would be to use the GitLab tags. Hopefully, we will soon
> use Gitlab for everything and then it won't be a problem.
> 
> For example, promo will just need to go to these two links to find all the
> information we need:
> 
> * https://invent.kde.org/groups/kde/-/issues?label_name%5B%5D=Noteworthy
> * https://invent.kde.org/groups/kde/-/merge_requests?
label_name%5B%5D=Noteworthy

Actually this seems like a good approach. At KPhotoAlbum, we don't use the 
merge request workflow much, but use issues (well, currently Phabricator 
tasks) to track feature development.
Having both issue and merge-request labels should fit most projects, I 
guess...

Cheers,
Johannes




signature.asc
Description: This is a digitally signed message part.

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Andres Betts]

abetts added a comment.


  My opinion on this patch from the beginning has been that it really doesn't 
add much more than was there before. Visually, it clutters the UI. The icon 
selected for it might also not be visually appealing or meaningful enough. I 
believe there should be a different approach to this request. However, I am 
also open to just dropping the idea completely.
  
  Some ideas for better UX on this:
  
  1. Hover over the "Defaults" button and the UI shows highlighted controls and 
labels that have changed. If you want to return things to default, click the 
button.
  2. Color controls and labels differently once they have changed to a 
non-default state. From Breeze Blue to a lighter blue, for example. (This could 
be confusing to some users)
  3. Keyboard shortcut. Use a keyboard shortcut to return settings back to 
their default state. Control + Z comes to mind.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: abetts, bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

D29021: Remove checks for notification service and fallback to KPassivePopup

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella edited the test plan for this revision.
nicolasfella added reviewers: Frameworks, Plasma, broulik.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D29021

To: nicolasfella, #frameworks, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

[Felix Riiga]

riiga updated this revision to Diff 80686.
riiga added a comment.


  Changed to regular unit from common unit.

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28995?vs=80587=80686

REVISION DETAIL
  https://phabricator.kde.org/D28995

AFFECTED FILES
  src/fuel_efficiency.cpp
  src/unit.h
  src/volume.cpp

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29021: Remove checks for notification service and fallback to KPassivePopup

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  nofallback2

REVISION DETAIL
  https://phabricator.kde.org/D29021

AFFECTED FILES
  src/notifybypopup.cpp
  src/notifybypopup.h

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29020: Add example/test application

[Nicolas Fella]

nicolasfella updated this revision to Diff 80685.
nicolasfella added a comment.


  - Add license header

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29020?vs=80684=80685

BRANCH
  example

REVISION DETAIL
  https://phabricator.kde.org/D29020

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/notificationtester.cpp
  examples/notificationtester.qml
  examples/resources.qrc

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Re: I am not able to submit to svn.kde.org.

[Ben Cooksley]

On Tue, Apr 21, 2020 at 12:42 AM Pan Yi-Jyun  wrote:
>
> Well, after I added my SSH key into there, I still got this error:
>
>
>
> $ ssh s...@svn.kde.org
>
> s...@svn.kde.org: Permission denied (publickey).
>

SSH Keys are only synced from invent.kde.org to svn.kde.org once per
hour, so there is some delay between you logging in there and you
being able to access svn.kde.org.

Given it has been more than an hour, I'd recommend trying again.

Cheers,
Ben

>
>
> BTW, I’m in the permitted list.
>
>
>
> 寄件者: Carl Schwan
> 傳送時間: 2020年4月20日 20:22:23
> 收件者: kde-devel@kde.org
> 主旨: Re: I am not able to submit to svn.kde.org.
>
>
>
> Did you see these instructions? 
> https://community.kde.org/Infrastructure/Subversion/2020_Changes
>
>
>
> ‐‐‐ Original Message ‐‐‐
>
> Le lundi, avril 20, 2020 12:02 PM,  a écrit :
>
>
>
> > Hi,
>
> > I can't submit changs to / fetch changes from svn.kde.org. Here is the
>
> > verbose message:
>
> >
>
>
>
> > `Committing to svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW ... 
> > Can't create session: Unable to connect to a repository at URL 
> > 'svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW': To better debug 
> > SSH connection problems, remove the -q option from 'ssh' in the [tunnels] 
> > section of your Subversion configuration file. at /usr/lib/git-core/git-svn 
> > line 1015.`
>
> >
>
>
>
> > 1) The SSH public key in local is same as that one I've uploaded
>
> > to identify.kde.org
>
> > > The uploaded SSH Key is already present.
>
> >
>
>
>
> > 2) On my primary machine, when I do "ssh...@svn.kde.org", it returns:
>
> > `$ ssh s...@svn.kde.org "s...@svn.kde.org: Permission denied (publickey)."`
>
> >
>
>
>
> > 3) And I also tried on my another machine (uses same SSH key), but
>
> > it looks like same.
>
> > `pan93@DESKTOP-JN5TNJH  ~  ssh s...@svn.kde.org The authenticity of host 
> > 'svn.kde.org (195.201.182.103)' can't be established. ECDSA key fingerprint 
> > is SHA256:UutSIkXdSGgyxQxL35dDEEAD2Owel+zEdKZ5I/JMqrA. Are you sure you 
> > want to continue connecting (yes/no/[fingerprint])? yes Warning: 
> > Permanently added 'svn.kde.org,195.201.182.103' (ECDSA) to the list of 
> > known hosts. s...@svn.kde.org: Permission denied (publickey).`
>
> >
>
>
>
> > 4) Some details:
>
> > svn.kde.org is pointed to 195.201.182.103.
>
> > My identify.kde.org account is "ppeter".
>
> >
>
>
>
> > Thanks!
>
> > Yi-Jyun Pan.
>
>
>
>

D29020: Add example/test application

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The purpose of this is twofold. It serves as a code example, but most 
importantly it can be used to test changes in KNotifications. It is currently 
very basic, but can be expanded in the future

REPOSITORY
  R289 KNotifications

BRANCH
  example

REVISION DETAIL
  https://phabricator.kde.org/D29020

AFFECTED FILES
  CMakeLists.txt
  examples/CMakeLists.txt
  examples/notificationtester.cpp
  examples/notificationtester.qml
  examples/resources.qrc

To: nicolasfella, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Nathaniel Graham]

ngraham added a comment.


  Yeah, I'm sorry about that.
  
  If VDG people ask for something that's technically impossible, you've gotta 
push back on that. They often don't know what is and isn't possible, or 
reasonable. We've been trying to help VDG people be more technical so they 
don't propose impossible things, but it's not perfect. The whole process needs 
to be a push-and-pull compromise where the design people accept when a design 
isn't technically feasible, and the tech people faithfully implement the design 
without diverging too far from it due to minor technical limitations, or 
letting the design people push them into something impossible due to major 
technical limitations.
  
  The basic problem with this feature is that I think we never did the initial 
design work to figure out who the target audience was, what their needs were, 
and why they would use and benefit from this feature. Even with an inline 
indicator like a glowing outline around the widget, we'd have the same problem 
that we do with the dot proposal in the sidebar view that it would be look like 
non-obvious visual noise to people. And with that, we'd lose the functionality 
of being able to revert individual settings. But is that needed? Who benefits 
from it? And so on. Such a complex and all-encompassing feature needs to have 
these kinds of questions answered first before implementation begins. We've 
found that Phabricator tasks are perfect for this, and we use them extensively 
to plan out work before coding begins for many projects.
  
  I know we're all exhausted and frustrated at this point, but maybe we can do 
that so we can push this forward in a way that makes everyone happy in the end?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

ervin added a comment.


  You know it started as a proper painted indicator within the widget area, 
right? As such it couldn't have any of the issues you're pointing out now... 
Who pushed me to have them at distance I wonder? Right, was people from the 
VDG. So I find grand that then it goes all to revert because after weeks of 
pushing me to add more weird constraints then disappearing letting me alone 
trying to figure out where to go (and it was a large struggle at every step), 
the conclusion is "let's revert because VDG wasn't involved". There were 
technical reasons for the very first iteration and they had to be disregarded 
for design license.
  
  Honestly I'm disgusted by the way it's been handled.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

[Nathaniel Graham]

ngraham added a comment.


  In D28995#652857 , @riiga wrote:
  
  > The imperial gallon has limited use in the UK as liters mostly are used 
these days except for mileage which is in miles per imperial gallon. So I agree 
that it shouldn't be a common unit for volume.
  >
  > @ngraham How widespread is usage of the pint in the US? Does it make sense 
to keep both pints as a common unit? (The British pint is still used widely in 
the UK.)
  
  
  Pints are not very commonly used in the USA. So yeah, I guess both of these 
new units should be non-common units.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29014: Fix the exclusive group box case for default indicators

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:14ecec53296a: Fix the exclusive group box case for 
default indicators (authored by ervin).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29014?vs=80664=80682

REVISION DETAIL
  https://phabricator.kde.org/D29014

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: ervin, ngraham, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

[Nathaniel Graham]

ngraham added a comment.


  Great. There are still a few more bugs though:
  
  When you install certain global themes, they ask for authentication so 
install an SDDM theme. However when you uninstall that theme, it doesn't 
request authentication to remove them SDDM theme. So `/usr/share/sddm/themes` 
accumulates a growing collection of unused themes:
  
ls /usr/share/sddm/themes/
breeze  breeze-openSUSE  elarun  Layan  maldives  maya  McMojave  plasmaX  
Sweet
  
  When I install and uninstall the Sweet global theme, its Plasma theme still 
shows up in the Plasma style KCM. And looking in 
`~/.local/share/plasma/desktoptheme/`, there are several orphaned plasma themes 
left over from global themes that I deleted from the GHNS dialog on the global 
themes KCM:
  
ls ~/.local/share/plasma/desktoptheme/
Arc-Dark  kpluginindex.json  Layan  Sweet
  
  Their color schemes and icon themes are still there too.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80677.
apol added a comment.


  Improve how we initialise the sourceId

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80662=80677

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28780

To: bruns, #frameworks, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

[Felix Riiga]

riiga added a comment.


  The imperial gallon has limited use in the UK as liters mostly are used these 
days except for mileage which is in miles per imperial gallon. So I agree that 
it shouldn't be a common unit for volume.
  
  @ngraham How widespread is usage of the pint in the US? Does it make sense to 
keep both pints as a common unit? (The British pint is still used widely in the 
UK.)

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29018: Align description in metainfo.yaml with the one of README.md

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R174 KContacts

BRANCH
  fixmetainfodescription

REVISION DETAIL
  https://phabricator.kde.org/D29018

AFFECTED FILES
  metainfo.yaml

To: kossebau, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29017: WIP: Introduce three new methods that return all "entries" in a folder

[Ahmad Samir]

ahmadsamir added a comment.


  Todo: port kwalletmanager locally and see if it still works (which isn't 
saying much as I don't use kwallet that much). I think we can delay this to KF 
5.71, to get more testing.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29017

To: ahmadsamir, #frameworks, dfaure
Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

[Nathaniel Graham]

ngraham added a comment.


  Ah, I see.
  
  I wonder if it actually makes sense to mark the non-US imperial measurements 
as common. Are these units still widely used outside of the USA? Speaking as an 
American where everything is gallons, it will be kind of annoying to see 
imperial gallons appear in KRunner first.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D28780: [FstabWatcher] Fix loosing of fstab watcher

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28780

To: bruns, #frameworks, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  Talking with kbroulik on irc confirms your POV, the format of those patterns 
aren't documented anywhere so changing the matching now would change the 
behaviour...
  
  I'll abandon this, (I suggest that X-Plasma-DropUrlPatterns should be 
documented somewhere so that there's a defined format on which to base the 
contract of not breaking API :/).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol, broulik
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29017: WIP: Introduce three new methods that return all "entries" in a folder

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  As was discussed in https://phabricator.kde.org/D28880 with dfaure, it
  seems that all users (only two, KWalletManager and Falkon) of the current
  read{Entry,Map,Passowrd}list() methods basically use "*" as a wildcard
  to get a list of all the "entries" in a folder. Therefore it makes sense
  to introduce new methods that do just that, this gets rid of regular
  expression usage for matching a certain pattern. This fits with how .e.g.
  KWalletManager is using readEntryList(), to get a list of all the entries
  to fill a list view with them, then the "matching" is done with a QSFPM-like
  class.

TEST PLAN
  - make && ctest
  - Ported Falkon locally, and it seems to work

REPOSITORY
  R311 KWallet

BRANCH
  l-kwallet-dump-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29017

AFFECTED FILES
  CMakeLists.txt
  src/api/KWallet/CMakeLists.txt
  src/api/KWallet/kwallet.cpp
  src/api/KWallet/kwallet.h
  src/api/KWallet/org.kde.KWallet.xml
  src/runtime/kwalletd/backend/kwalletbackend.cc
  src/runtime/kwalletd/backend/kwalletbackend.h
  src/runtime/kwalletd/kwalletd.cpp
  src/runtime/kwalletd/kwalletd.h

To: ahmadsamir, #frameworks, dfaure
Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28776

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

[Stefan Brüns]

bruns added a reviewer: ngraham.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28780

To: bruns, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added a comment.


  Ping!

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28780

To: bruns, #frameworks, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham updated this revision to Diff 80668.
ngraham added a comment.


  Maybe fix a thing

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=80645=80668

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Nathaniel Graham]

ngraham added a subscriber: GB_2.
ngraham added a comment.


  In D27540#652692 , @ervin wrote:
  
  > In D27540#652664 , @ngraham 
wrote:
  >
  > > David asked for VDG to approve before this landed, which wasn't done.
  >
  >
  > Dude, I jumped through all the hoops for the past weeks. Also it got no 
further reply after I updated the screenshot almost two weeks ago so yes I 
assumed you guys had nothing else.
  
  
  Sorry I didn't have the time to test it again. It's not just about the UI 
design itself, but also avoid obvious visual glitches, like this: F8249569: 
Screenshot_20200420_104632.png 
  
  There are also numerous cases in other KCMs where the indicator gets cut off, 
positioned strangely, or isn't visible at all for a non-default setting:
  F8249574: Screenshot_20200420_105414.png 

  F8249578: Screenshot_20200420_105450.png 

  F8249582: Peek 2020-04-20 10-57.webm 
  
  How are we going to fix that? The diversity of user interfaces we have 
throughout KDE software makes me skeptical that any kind of auto-generated icon 
placement can ever work, let alone look good. Where will the icons go in list 
items? Grid views? And so on. To be completely honest, if nobody could come up 
with a good UI, it might be a sign that the feature itself needs to be 
re-thought. I remain unconvinced that this is the best way to show that there 
are changed settings. I think @gb_2's idea of displaying the original or 
previous state when hovering over the Defaults or Reset button made more sense. 
As is, I don't really understand who the target user is for this feature.
  
  IMO this feature would have benefited from being outlined first in a 
Phabricator task and soliciting #VDG  
feedback before coding began, so we didn't frustratingly go back and forth in 
the patches. Given the above visual regressions and broken behavior on multiple 
KCMs, I think this needs to be reverted and discussed and re-thought in a 
central location. Sorry. :(

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns

D29014: Fix the exclusive group box case for default indicators

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29014

To: ervin, ngraham, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28995: Add imperial gallon and US pint

[Felix Riiga]

riiga added a comment.


  In D28995#652764 , @ngraham wrote:
  
  > Aren't Imperial and US the same thing?The USA is the only country that 
still officially uses the imperiaI system.
  
  
  The US uses USC  
units which are derived from the British imperial system, but some units differ 
such as the volume of the gallon and pint. So there is an American gallon and a 
British gallon, and an American pint and a British pint and probably even more 
variants. Prevoiusly the US gallon and British pint had been added. I've added 
the US pint and the British gallon (which it seems had been added for fuel 
efficiency calucations, but not regular calculations).

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D28995: Add imperial gallon and US pint

[Stefan Brüns]

bruns added a comment.


  In D28995#652764 , @ngraham wrote:
  
  > Aren't Imperial and US the same thing?The USA is the only country that 
still officially uses the imperiaI system.
  
  
  Every time you use "is the same as" in reference to imperial measures, a 
kitten dies ...
  
  https://en.wikipedia.org/wiki/Gallon

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D28995: Add imperial gallon and US pint

[Nathaniel Graham]

ngraham added a comment.


  Aren't Imperial and US the same thing?The USA is the only country that still 
officially uses the imperiaI system.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D28995

To: riiga, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29014: Fix the exclusive group box case for default indicators

[Kevin Ottens]

ervin updated this revision to Diff 80664.
ervin added a comment.


  Fix misplaced *

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29014?vs=80661=80664

REVISION DETAIL
  https://phabricator.kde.org/D29014

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: ervin, ngraham, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80662.
apol added a comment.


  Iterate tests (which work now) and uses

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80658=80662

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

ervin added a comment.


  In D27540#652669 , @ngraham wrote:
  
  > Finally clicking on the revert button in Spectacle's settings page causes a 
segfault for me: P590 Spectacle crash backtrace 

  
  
  Couldn't quite reproduce it the way you described, but indeed managed to get 
it to crash. It's fixed with D29014 

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29014: Fix the exclusive group box case for default indicators

[Kevin Ottens]

ervin created this revision.
ervin added reviewers: ngraham, davidedmundson, bport, crossi.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ervin requested review of this revision.

REVISION SUMMARY
  Turns out there was an oversight here, in case of an exclusive group
  box, the emitter widget is a button inside the group box which can have
  any name (this was thus caught by the assert).
  
  So now we also check if the sender is a button and if that's the case we
  verify if its in one of the known exclusive group boxes. If yes we use
  the group box as reference for the indicator work.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29014

AFFECTED FILES
  src/kconfigdialogmanager.cpp

To: ervin, ngraham, davidedmundson, bport, crossi
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/24/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Mon, 20 Apr 2020 15:54:40 +
 Build duration:
2 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1662/3632)31%
(752/2409)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1190/2664)31%
(533/1694)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 421 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/421/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 20 Apr 2020 15:54:40 +
 Build duration:
2 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1662/3632)31%
(752/2409)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1190/2664)31%
(533/1694)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/28/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 20 Apr 2020 15:54:39 +
 Build duration:
1 min 18 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80658.
apol added a comment.


  Fix test

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80637=80658

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

ervin added a comment.


  In D27540#652664 , @ngraham wrote:
  
  > David asked for VDG to approve before this landed, which wasn't done.
  
  
  Dude, I jumped through all the hoops for the past weeks. Also it got no 
further reply after I updated the screenshot almost two weeks ago so yes I 
assumed you guys had nothing else.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29011: Fix variable mixup

[David Redondo]

davidre abandoned this revision.
davidre added a comment.


  Oh I diffed the wrong repo...

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29011

To: davidre, #breeze, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29011: Fix variable mixup

[David Redondo]

davidre added reviewers: Breeze, Plasma.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D29011

To: davidre, #breeze, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29011: Fix variable mixup

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Caused icons to be not longer recolored when changing the color scheme until 
an
  application is started again

TEST PLAN
  Change color scheme while having an application open, icons should change 
color correctly

REPOSITORY
  R302 KIconThemes

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29011

AFFECTED FILES
  src/kiconloader.cpp

To: davidre
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Nathaniel Graham]

ngraham added a comment.


  I have concerns about this. The button has no tooltip so it's not obvious 
what will happen when clicked on. It should at least say "Revert to default 
setting" in a tooltip, and preferably even the name or text of the default 
setting that will be reverted to.
  
  Also, we now have a new inconsistency in that a small fraction of System 
Settings KCMs and app settings windows will display these indicators, but not 
others.
  
  Finally clicking on the revert button in Spectacle's settings page causes a 
segfault for me: P590 Spectacle crash backtrace 


REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Nathaniel Graham]

ngraham added a comment.


  David asked for VDG to approve before this landed, which wasn't done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

Re: Polish translation of "Cancel"

[Nate Graham]

Thanks for getting this done, Łukasz!

Nate


On 4/17/20 2:05 PM, Łukasz Wojniłowicz wrote:

No problem but give me some time. I must schedule that but I'm not sure of
Luigi's plans in that matter.
--
Łukasz

Dnia piątek, 17 kwietnia 2020 21:56:02 CEST Nate Graham pisze:

Thanks! When it's done, can you close the bug report or let us know?

Nate

On 4/17/20 1:53 PM, Łukasz Wojniłowicz wrote:

Nothing. I would do that myself. I see that's the only way to solve this
tension.

Dnia piątek, 17 kwietnia 2020 21:26:03 CEST Luigi Toscano pisze:

Let me ask clearly: if I commit the patch from
https://bugs.kde.org/show_bug.cgi?id=404286#c65

what will you do?

D27840: Introduce SettingState* elements to ease KCM writing

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:24211925f835: Introduce SettingState* elements to ease 
KCM writing (authored by ervin).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27840?vs=80305=80654

REVISION DETAIL
  https://phabricator.kde.org/D27840

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/CMakeLists.txt
  src/qmlcontrols/kcmcontrols/kcmcontrolsplugin.cpp
  src/qmlcontrols/kcmcontrols/qml/SettingStateBinding.qml
  src/qmlcontrols/kcmcontrols/qml/SettingStateIndicator.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir
  src/qmlcontrols/kcmcontrols/settingstatebindingprivate.cpp
  src/qmlcontrols/kcmcontrols/settingstatebindingprivate.h
  src/qmlcontrols/kcmcontrols/settingstateproxy.cpp
  src/qmlcontrols/kcmcontrols/settingstateproxy.h

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/9/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 20 Apr 2020 14:35:14 +
 Build duration:
55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:dfc144bf3f45: Port desktoptheme, icons and workspace KCMs 
to SettingStateBinding (authored by ervin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27841?vs=76953=80655

REVISION DETAIL
  https://phabricator.kde.org/D27841

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/workspaceoptions/package/contents/ui/main.qml

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27839: Properly name the content of the kcmcontrols project

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:3501bcbe8da6: Properly name the content of the 
kcmcontrols project (authored by ervin).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27839?vs=76951=80653

REVISION DETAIL
  https://phabricator.kde.org/D27839

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/CMakeLists.txt

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:11186c056198: KCModule: Indicate when a setting has been 
changed from the default or previous… (authored by ervin).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27540?vs=79656=80652

REVISION DETAIL
  https://phabricator.kde.org/D27540

AFFECTED FILES
  src/CMakeLists.txt
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h
  src/kconfigdialogmanager_p.h
  src/settingsstatusindicator.cpp
  src/settingsstatusindicator_p.h

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Assuming VDG are happy, go for it.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27840

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27841

To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, 
#frameworks, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  Heh. That can happen. :)
  
  Maybe try again once the adaptive transparency patch has landed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a task: T11925: Breeze Desktop Theme Transparency.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham updated this revision to Diff 80645.
ngraham added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=80644=80645

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

[Nathaniel Graham]

ngraham updated this revision to Diff 80644.
ngraham added a comment.


  Install auth helper too

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=80343=80644

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, 
LeGast00n, cblack, michaelh, bruns

Re: Re: I am not able to submit to svn.kde.org.

[Pan Yi-Jyun]

Well, after I added my SSH key into there, I still got this error: $ ssh s...@svn.kde.orgs...@svn.kde.org: Permission denied (publickey). BTW, I’m in the permitted list. 寄件者: Carl Schwan傳送時間: 2020年4月20日 20:22:23收件者: kde-devel@kde.org主旨: Re: I am not able to submit to svn.kde.org. Did you see these instructions? https://community.kde.org/Infrastructure/Subversion/2020_Changes ‐‐‐ Original Message ‐‐‐Le lundi, avril 20, 2020 12:02 PM,  a écrit : > Hi,> I can't submit changs to / fetch changes from svn.kde.org. Here is the> verbose message:>  > `Committing to svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW ... Can't create session: Unable to connect to a repository at URL 'svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW': To better debug SSH connection problems, remove the -q option from 'ssh' in the [tunnels] section of your Subversion configuration file. at /usr/lib/git-core/git-svn line 1015.`>  > 1) The SSH public key in local is same as that one I've uploaded> to identify.kde.org> > The uploaded SSH Key is already present.>  > 2) On my primary machine, when I do "ssh...@svn.kde.org", it returns:> `$ ssh s...@svn.kde.org "s...@svn.kde.org: Permission denied (publickey)."`>  > 3) And I also tried on my another machine (uses same SSH key), but> it looks like same.> `pan93@DESKTOP-JN5TNJH  ~  ssh s...@svn.kde.org The authenticity of host 'svn.kde.org (195.201.182.103)' can't be established. ECDSA key fingerprint is SHA256:UutSIkXdSGgyxQxL35dDEEAD2Owel+zEdKZ5I/JMqrA. Are you sure you want to continue connecting (yes/no/[fingerprint])? yes Warning: Permanently added 'svn.kde.org,195.201.182.103' (ECDSA) to the list of known hosts. s...@svn.kde.org: Permission denied (publickey).`>  > 4) Some details:> svn.kde.org is pointed to 195.201.182.103.> My identify.kde.org account is "ppeter".>  > Thanks!> Yi-Jyun Pan.  

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/8/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Mon, 20 Apr 2020 12:35:19 +
 Build duration:
1 min 17 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D28805: Tweak kcmcontrols docs

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:b8accaad1eda: Tweak kcmcontrols docs (authored by 
nicolasfella).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28805?vs=80044=80640

REVISION DETAIL
  https://phabricator.kde.org/D28805

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: nicolasfella, #frameworks, jucato, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: I am not able to submit to svn.kde.org.

[Carl Schwan]

Did you see these instructions? 
https://community.kde.org/Infrastructure/Subversion/2020_Changes

‐‐‐ Original Message ‐‐‐
Le lundi, avril 20, 2020 12:02 PM,  a écrit :

> Hi,
> I can't submit changs to / fetch changes from svn.kde.org. Here is the
> verbose message:
> 

> `Committing to svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW ... 
> Can't create session: Unable to connect to a repository at URL 
> 'svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW': To better debug 
> SSH connection problems, remove the -q option from 'ssh' in the [tunnels] 
> section of your Subversion configuration file. at /usr/lib/git-core/git-svn 
> line 1015.`
> 

> 1) The SSH public key in local is same as that one I've uploaded
> to identify.kde.org
> > The uploaded SSH Key is already present.
> 

> 2) On my primary machine, when I do "ssh...@svn.kde.org", it returns:
> `$ ssh s...@svn.kde.org "s...@svn.kde.org: Permission denied (publickey)."`
> 

> 3) And I also tried on my another machine (uses same SSH key), but
> it looks like same.
> `pan93@DESKTOP-JN5TNJH  ~  ssh s...@svn.kde.org The authenticity of host 
> 'svn.kde.org (195.201.182.103)' can't be established. ECDSA key fingerprint 
> is SHA256:UutSIkXdSGgyxQxL35dDEEAD2Owel+zEdKZ5I/JMqrA. Are you sure you want 
> to continue connecting (yes/no/[fingerprint])? yes Warning: Permanently added 
> 'svn.kde.org,195.201.182.103' (ECDSA) to the list of known hosts. 
> s...@svn.kde.org: Permission denied (publickey).`
> 

> 4) Some details:
> svn.kde.org is pointed to 195.201.182.103.
> My identify.kde.org account is "ppeter".
> 

> Thanks!
> Yi-Jyun Pan.



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove abandoned this revision.
niccolove added a comment.


  I've tweaked it so many times that I eventually ended up with something that 
looks almost identical to default without even noticing. I still think there is 
margin for improvement over the default, but I need to take some more time to 
tweak the values again until I get to something I'm again really confident 
proposing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

I am not able to submit to svn.kde.org.

[pan93412]

Hi,
I can't submit changs to / fetch changes from svn.kde.org. Here is the
verbose message:

```
Committing to svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW ...
Can't create session: Unable to connect to a repository at URL
'svn+ssh://s...@svn.kde.org/home/kde/trunk/l10n-kf5/zh_TW':
   To better debug SSH connection problems, remove the -q option
from 'ssh' in the
   [tunnels] section of your Subversion configuration file.
   at /usr/lib/git-core/git-svn line 1015.
```


1) The SSH public key in local is same as that one I've uploaded
to identify.kde.org
   > The uploaded SSH Key is already present.

2) On my primary machine, when I do "ssh s...@svn.kde.org", it returns:
   ```
   $ ssh s...@svn.kde.org
   "s...@svn.kde.org: Permission denied (publickey)."
   ```

3) And I also tried on my another machine (uses same SSH key), but
it looks like same.
   ```
   pan93@DESKTOP-JN5TNJH  ~  ssh s...@svn.kde.org
   The authenticity of host 'svn.kde.org (195.201.182.103)' can't
be established.
   ECDSA key fingerprint is
SHA256:UutSIkXdSGgyxQxL35dDEEAD2Owel+zEdKZ5I/JMqrA.
   Are you sure you want to continue connecting (yes/no/[fingerprint])? yes
   Warning: Permanently added 'svn.kde.org,195.201.182.103'
(ECDSA) to the list of known hosts.
   s...@svn.kde.org: Permission denied (publickey).
   ```

4) Some details:
   svn.kde.org is pointed to 195.201.182.103.
   My identify.kde.org account is "ppeter".

Thanks!
Yi-Jyun Pan.

Re: Proposal: "Noteworthy" label for Promo application updates

[Carl Schwan]

I think the easiest would be to use the GitLab tags. Hopefully, we will soon use
Gitlab for everything and then it won't be a problem.

For example, promo will just need to go to these two links to find all the 
information
we need:

 

* https://invent.kde.org/groups/kde/-/issues?label_name%5B%5D=Noteworthy
* https://invent.kde.org/groups/kde/-/merge_requests?label_name%5B%5D=Noteworthy

Carl

‐‐‐ Original Message ‐‐‐
Le dimanche, avril 19, 2020 9:15 AM, Ben Cooksley  a écrit :

> On Sun, Apr 19, 2020 at 8:34 PM XYQuadrat m...@xyquadrat.ch wrote:
> 

> > If we implement such a system (that is, just resurrect what is already
> > present), I definitely think it would be sensible to make guidelines on
> > what commits we are interested in publicly available.
> > The thing I'm not sure about is how easy it'd be to automate grabbing
> > all the CHANGELOG commits from a given date range - can someone more
> > experienced with our git/repo infrastructure shed some light here?
> 

> That depends on whether you have local, up to date, clones of the
> repositories in question.
> If you have them locally it should be reasonably trivial with a bit of
> scripting to get a list of commits and the repositories to which they
> belong.
> 

> If you don't, then the only other option you would have would be
> Gitlab's APIs but that isn't ideal from an infrastructural point of
> view.
> 

> > Best regards,
> > Julian / xyquadrat
> 

> Cheers,
> Ben
> 

> > On 17.04.20 01:19, Johannes Zarl-Zierl wrote:
> > 

> > > On Donnerstag, 16. April 2020 23:15:18 CEST Nate Graham wrote:
> > > 

> > > > On 4/16/20 2:38 PM, Albert Astals Cid wrote:
> > > > 

> > > > > It may make sense to highlight them a bit more somehow, suggestions
> > > > > welcome i guess.
> > > > > The promo people just need a list of all CHANGELOG entries in a 
> > > > > release
> > > > > so they can rewrite it in more human-friendly terms. Right now this is
> > > > > done manually by me and others by looking through commit logs and blog
> > > > > posts and adding the equivalent of CHANGELOG text into an
> > > > > etherpad/share.kde.org document. Automating that somehow would be 
> > > > > nice.
> > > > > From a developer point of view, a tag in the commit itself seems like
> > > > > a nice
> > > > > interface. One thing I fear, though, is that people like me forget to
> > > > > actually
> > > > > add it to the commit before pushing, so maybe something that can be 
> > > > > added
> > > > > later would definitely have its advantages.
> > > 

> > > Personally, I'd like to have some clear guidelines from the promo team
> > > on what
> > > kind of features they are looking for. That way it's way easier for me to
> > > match those expectations ;-)
> > > Btw. isn't the DIGEST keyword as documented in the standard commit
> > > template
> > > basically the same idea?
> > > Cheers,
> > > Johannes



publickey - carl@carlschwan.eu - 0x7F564CB5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80637.
apol added a comment.


  iterate test

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80605=80637

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28805: Tweak kcmcontrols docs

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  tweakdocs

REVISION DETAIL
  https://phabricator.kde.org/D28805

To: nicolasfella, #frameworks, jucato, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

[Ben Cooksley]

On Mon, Apr 20, 2020 at 10:29 AM Friedrich W. H. Kossebau
 wrote:
>
> Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley:
> > Hi all,
> >
> > Another breakage in Qt?
>
> Should be fixed now (restarted build now completed), with similar traps also
> removed for the future, thanks to David Faure for the work done and Ade for
> the root detecting investigations.

Thanks all for taking a look into this and making the necessary fixes!

>
> Seems Qt changed for Qt 5.14.1 -> 5.14.2 some wrappers around QSet-related API
> from
> #if QT_VERSION < QT_VERSION_CHECK(6,0,0)
> to
> #if QT_DEPRECATED_SINCE(5, 14) && QT_VERSION < QT_VERSION_CHECK(6,0,0)
> and by that stronger rules some projects no longer saw code they saw before,
> thus had started to fail.
>
> Cheers
> Friedrich
>
>

Cheers,
Ben

D6794: assert the testpackage appstream data validates

[Ben Cooksley]

bcooksley added a comment.


  I've added it in 
https://invent.kde.org/sysadmin/ci-tooling/commit/cd1eb8d0a91502f8aaf0c7fc402060bd38a3cf25
 and have now initiated an image rebuild

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D6794

To: sitter, sebas, apol
Cc: bcooksley, dfaure, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns