KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.15 - Build # 721 - Still Unstable!

2022-01-05 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.15/721/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Thu, 06 Jan 2022 01:14:49 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515 Failed: 16 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.pagepool/tst_layers.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.pagepool/tst_pagepool.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_actiontoolbar.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_avatar.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_icon.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_keynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_listskeynavigation.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_mnemonicdata.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_pagerouter.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_pagerow.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_routerwindow.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.tst_theme.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.wheelhandler/tst_filterMouseEvents.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.wheelhandler/tst_invokables.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.wheelhandler/tst_onWheel.qmlFailed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt515.autotests.wheelhandler/tst_scrolling.qml

Re: Translation of plural string in English with spaces

2022-01-05 Thread Albert Astals Cid
El dimecres, 5 de gener de 2022, a les 21:07:34 (CET), Johnny Jazeix va 
escriure:
> Hi,
> 
> for GCompris we have one complicated sentence to translate:
> "Place %n boy(s) and %n girl(s) in the center. Then split %n pieces of
> candy equally between them." (context in this image:
> https://gcompris.net/screenshots_qt/middle/share.png)
> 
> There are mixed plurals and to have the plural correctly translated we use:
> //~ singular Place %n boy
> //~ plural Place %n boys
> text = qsTr("Place %n boy(s) ", "First part of Place %n boy(s) and
> %n girl(s) in the center. Then split %n pieces of candy equally between
> them.", boys);
> 
> //~ singular and %n girl in the center.
> //~ plural and %n girls in the center.
> text += qsTr("and %n girl(s) in the center. ", "Second part of
> Place %n boy(s) and %n girl(s) in the center. Then split %n pieces of candy
> equally between them.", girls);
> 
> //~ singular Then split %n candy equally between them.
> //~ plural Then split %n candies equally between them.
> text += qsTr("Then split %n pieces of candy equally between them.",
> "Third part of Place %n boy(s) and %n girl(s) in the center. Then split %n
> pieces of candy equally between them.", candies);
> 
> For American English, it takes the string from the " //~ singular/plural "
> lines.
> The issue we have is that we don't manage to have the extra space in the
> English translation at the end of "boy(s) " (same if we put the space at
> the beginning of the other part to translate (" and %n girl(s))").
> 
> If we add double quotes, they are part of the translation. And if we have
> an extra space at the end, it is removed.
> 
> Is there a way to handle it properly in the code or even reformulate the
> sentence to make it work more easily while keeping the meaning?
> 
> I'm cc-ing multiple list because, in the ideal, we'd like to fix the code
> without impacting the string for the next release but we can have a better
> string for after.

As you've found the current tooling we use to autofill the en.po files from the 
comments doesn't allow spaces at the end, and that "can't be fixed" since it 
means a change in lupdate from qt.

The typical way to solve this kind of puzzles is to translate the 3 strings 
separately and then have a qsTr("%1 %2. %3") [with lots of context] to merge it 
all together and potentially give the translation teams that need some extra 
possibility of repositioning things if they need to.

Cheers,
  Albert

> 
> Cheers,
> 
> Johnny
> 






KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.15 - Build # 330 - Fixed!

2022-01-05 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.15/330/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Wed, 05 Jan 2022 21:39:01 +
 Build duration:
3 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)79%
(266/337)58%
(146/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)75%
(44/59)54%
(14/26)autotests100%
(5/5)100%
(5/5)80%
(222/278)58%
(132/226)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.15 - Build # 318 - Fixed!

2022-01-05 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.15/318/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Wed, 05 Jan 2022 21:39:01 +
 Build duration:
53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kdav » kf5-qt5 SUSEQt5.15 - Build # 104 - Unstable!

2022-01-05 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdav/job/kf5-qt5%20SUSEQt5.15/104/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Wed, 05 Jan 2022 21:27:56 +
 Build duration:
2 min 34 sec and counting
   BUILD ARTIFACTS
  acc/KF5DAV-5.90.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.kdav_davcollectionsmultifetchjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(3/4)67%
(33/49)67%
(33/49)45%
(1010/2247)25%
(395/1612)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(7/7)100%
(7/7)91%
(360/397)50%
(217/437)src.common63%
(24/38)63%
(24/38)39%
(567/1457)24%
(166/691)src.protocols67%
(2/3)67%
(2/3)28%
(83/299)12%
(12/104)test0%
(0/1)0%
(0/1)0%
(0/94)0%
(0/380)

Translation of plural string in English with spaces

2022-01-05 Thread Johnny Jazeix
Hi,

for GCompris we have one complicated sentence to translate:
"Place %n boy(s) and %n girl(s) in the center. Then split %n pieces of
candy equally between them." (context in this image:
https://gcompris.net/screenshots_qt/middle/share.png)

There are mixed plurals and to have the plural correctly translated we use:
//~ singular Place %n boy
//~ plural Place %n boys
text = qsTr("Place %n boy(s) ", "First part of Place %n boy(s) and
%n girl(s) in the center. Then split %n pieces of candy equally between
them.", boys);

//~ singular and %n girl in the center.
//~ plural and %n girls in the center.
text += qsTr("and %n girl(s) in the center. ", "Second part of
Place %n boy(s) and %n girl(s) in the center. Then split %n pieces of candy
equally between them.", girls);

//~ singular Then split %n candy equally between them.
//~ plural Then split %n candies equally between them.
text += qsTr("Then split %n pieces of candy equally between them.",
"Third part of Place %n boy(s) and %n girl(s) in the center. Then split %n
pieces of candy equally between them.", candies);

For American English, it takes the string from the " //~ singular/plural "
lines.
The issue we have is that we don't manage to have the extra space in the
English translation at the end of "boy(s) " (same if we put the space at
the beginning of the other part to translate (" and %n girl(s))").

If we add double quotes, they are part of the translation. And if we have
an extra space at the end, it is removed.

Is there a way to handle it properly in the code or even reformulate the
sentence to make it work more easily while keeping the meaning?

I'm cc-ing multiple list because, in the ideal, we'd like to fix the code
without impacting the string for the next release but we can have a better
string for after.

Cheers,

Johnny


[sysadmin/ci-management] seeds: Due to Plasma Framework having a hard dependency on KGlobalAccel we are forced to build it on Windows as well.

2022-01-05 Thread Ben Cooksley
Git commit b22096531b29c572197a6c5e78f0248ab5e84274 by Ben Cooksley.
Committed on 05/01/2022 at 18:37.
Pushed by bcooksley into branch 'master'.

Due to Plasma Framework having a hard dependency on KGlobalAccel we are forced 
to build it on Windows as well.
Just like KAuth/KTextEditor this falls into the category of no-op so we should 
probably look at a way of eliminating this hard dependency (unless 
plasma-framework makes no sense on Windows either of course...)

CCMAIL: kde-frameworks-devel@kde.org

M  +1-1seeds/frameworks-latest.yml

https://invent.kde.org/sysadmin/ci-management/commit/b22096531b29c572197a6c5e78f0248ab5e84274

diff --git a/seeds/frameworks-latest.yml b/seeds/frameworks-latest.yml
index 4b86e04..90ce94a 100644
--- a/seeds/frameworks-latest.yml
+++ b/seeds/frameworks-latest.yml
@@ -57,6 +57,7 @@
 "frameworks/kdoctools": "master"
 "frameworks/kemoticons": "master"
 "frameworks/kfilemetadata": "master"
+"frameworks/kglobalaccel": "master"
 "frameworks/khtml": "master"
 "frameworks/kidletime": "master"
 "frameworks/kinit": "master"
@@ -85,7 +86,6 @@
 "frameworks/baloo": "master"
 "frameworks/kactivities-stats": "master"
 "frameworks/kdesu": "master"
-"frameworks/kglobalaccel": "master"
 "frameworks/kpty": "master"
 "frameworks/kwayland": "master"
 


KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.15 - Build # 335 - Still Unstable!

2022-01-05 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.15/335/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Wed, 05 Jan 2022 16:13:52 +
 Build duration:
50 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.KDEFetchTranslationsName: projectroot.home.jenkins.workspace.Frameworks.extra-cmake-modules Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 76 test(s), Skipped: 0 test(s), Total: 76 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

Re: Includes (was: Re: KF6 meeting notes 2022-01-04)

2022-01-05 Thread Volker Krause
On Dienstag, 4. Januar 2022 19:41:45 CET Friedrich W. H. Kossebau wrote:
> Am Dienstag, 4. Januar 2022, 18:07:45 CET schrieb Volker Krause:
> > - in some places includes with the framework prefix don't seem to work
> > anymore (ie.  vs ), any idea where those extra
> > include directories came from/got lost?
> 
> FTR, pointed on irc to some insights about design of include folder layout
> noted in an older comment here:
> https://invent.kde.org/pim/akonadi/-/merge_requests/70#note_300273
> 
> And follow-up on what makes path relative to "include/KF5" work:
> https://invent.kde.org/pim/akonadi/-/merge_requests/70#note_300304

Thanks for the input, that explains a few things indeed :)

> Seems at least the version files as currently installed do not match the
> pattern as described above, but that might have been just a mistake which
> happened to work, so no-one noticed.
> Installing kfoo_version.h instead of to include/KF5 to include/KF5/KFoo
> should still work as before., at least for anything which reads include
> paths from installed metadata like cmake config files, pkgconfig files or
> qmake pri files.
> 
> The currently by KF5 modules provided pkgconfig files or qmake pri files
> seem to even never add "include/KF5" in the samples I looked at, so any
> #include  would have never worked with them.
> 
> So I would propose to fix things and adapt the version files to be installed
> into the module prefix now already. Any serious project should get the
> include paths from the build metadata and not try to heuristically find
> version headers and try to heuristically detect the version from that.

Here's a pilot MR for this: 
https://invent.kde.org/frameworks/kio/-/merge_requests/693

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.


KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 FreeBSDQt5.15 - Build # 294 - Still Unstable!

2022-01-05 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20FreeBSDQt5.15/294/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Wed, 05 Jan 2022 16:13:52 +
 Build duration:
7 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.KDEFetchTranslationsName: projectroot.tests Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

Re: SPDX and docbook documentation, how to do properly?

2022-01-05 Thread Luigi Toscano
Harald Sitter ha scritto:
> On Wed, Jan 5, 2022 at 1:45 PM Friedrich W. H. Kossebau
>  wrote:
>>
>> Hi,
>>
>> the section "License Statements in Non-Source-Code Files" at
>> https://community.kde.org/Guidelines_and_HOWTOs/
>> Licensing#License_Statements_in_Non-Source-Code_Files
>> currently does not hold an example how to add SPDX tags. And by a quick look
>> it seems not many docbook files in KDE repos currently have any such info, so
>> no pattern could be derived from the real world samples.
>>
>> Also unclear to me how to best integrate with the predefined docbook tags, or
>> if duplication is needed?
>>
>> Could we have some example given by those with insights?
> 
> I know next to nothing about docbook, but generally speaking this
> should simply follow the XML approach I expect
> 
> 
> <...docbook entity stuff>
> 
> 
> As for the duplication: It is my understanding that we route all our
> docbooks through meinproc5, so presumably that could be a place where
> we find the SPDX tags and auto-inject them into the docbook DOM - i.e.
> my thinking is we turn SPDX into the canonical author information and
> then have meinproc inject the DOM nodes accordingly, on the fly. Not
> sure how feasible that is though.

I have the feeling it's better to keep them separate and duplicate them. Some
entities are translatable and I'm not sure how to achive it in a proper way.
Better leave the SPDX headers in the comments at the top of the for now.

-- 
Luigi


Re: SPDX and docbook documentation, how to do properly?

2022-01-05 Thread David Hurka
> how to add SPDX tags.

Aren’t docbooks just XML files? The reuse tool would add them as XML comment.

Approximately like this:

$ reuse addheader --style xml --copyright ... index.docbook







> predefined docbook tags,

Do you think it is important to not duplicate authors in the license statement 
and in the  section?
I think just duplicating this makes it easier for the reuse tool.




Re: SPDX and docbook documentation, how to do properly?

2022-01-05 Thread Harald Sitter
On Wed, Jan 5, 2022 at 1:45 PM Friedrich W. H. Kossebau
 wrote:
>
> Hi,
>
> the section "License Statements in Non-Source-Code Files" at
> https://community.kde.org/Guidelines_and_HOWTOs/
> Licensing#License_Statements_in_Non-Source-Code_Files
> currently does not hold an example how to add SPDX tags. And by a quick look
> it seems not many docbook files in KDE repos currently have any such info, so
> no pattern could be derived from the real world samples.
>
> Also unclear to me how to best integrate with the predefined docbook tags, or
> if duplication is needed?
>
> Could we have some example given by those with insights?

I know next to nothing about docbook, but generally speaking this
should simply follow the XML approach I expect


<...docbook entity stuff>


As for the duplication: It is my understanding that we route all our
docbooks through meinproc5, so presumably that could be a place where
we find the SPDX tags and auto-inject them into the docbook DOM - i.e.
my thinking is we turn SPDX into the canonical author information and
then have meinproc inject the DOM nodes accordingly, on the fly. Not
sure how feasible that is though.

HS


SPDX and docbook documentation, how to do properly?

2022-01-05 Thread Friedrich W. H. Kossebau
Hi,

the section "License Statements in Non-Source-Code Files" at
https://community.kde.org/Guidelines_and_HOWTOs/
Licensing#License_Statements_in_Non-Source-Code_Files 
currently does not hold an example how to add SPDX tags. And by a quick look 
it seems not many docbook files in KDE repos currently have any such info, so 
no pattern could be derived from the real world samples.

Also unclear to me how to best integrate with the predefined docbook tags, or 
if duplication is needed?

Could we have some example given by those with insights?

Cheers
Friedrich