Re: NetworkManagerQt

[Jan Grulich]

Hi

pá 27. 5. 2022 v 21:51 odesílatel Kovour, Sathyanarayana <
sathyanarayana_kov...@baxter.com> napsal:

> Hi
>
>
>
> My name is Sathya Kovour, I am part of Baxter International, a medical
> device manufacturer.
>
> We come across NetworkManagerQt
> https://marketplace.qt.io/products/networkmanagerqt, and we have a few
> questions while we are making decision to use this very convenient modules
> in our project.
>
>
>
>- As per above link this project is accessible for us with LGPL
>v2.1+.  According to our legal department this is very restrictive for our
>distribution scenarios.  I am wondering if you offer any additional
>licenses for this project to be used in our commercial setup without copy
>left clause.
>- I understand Linux Network Manager 1.16 support WPA3, does
>NetworkManagerQt enables us to use WPA3 capabilities if we have a
>compatible network manager installed on our embedded system?
>
> Yes, it should:
1)
https://invent.kde.org/frameworks/networkmanager-qt/-/commit/4a6a5e7080771660b0c705bcb533fe432fb2cd1b
2)
https://invent.kde.org/frameworks/networkmanager-qt/-/commit/03e3b060703e0dc8854820f9a3f5893b15af7f5d

If there is any issue with WPA3 support, we can always help to fix it.

Regards,
Jan Grulich

Re: Not able to take screenshots with KDE Plasma 5.20.80

[Jan Grulich]

Hi,

the file is named "org.freedesktop.impl.portal.desktop.kde.desktop" and
should be most likely located in /usr/share/applications.

Regards,
Jan

út 27. 10. 2020 v 22:10 odesílatel Damir Porobic 
napsal:

> Hi Jan,
>
> I have searched for files with that name and found following:
>
> /usr/share/xdg-desktop-portal-kde
> /usr/share/lintian/overrides/xdg-desktop-portal-kde
> /usr/share/doc/xdg-desktop-portal-kde
> /usr/lib/x86_64-linux-gnu/libexec/xdg-desktop-portal-kde
>
> The first and third are directories, the fourth is a library. I've added
> the string you mentioned to the second file but the behavior seems to be
> the same. Did you mean a different file?
>
> Regards,
> Damir
>
> ----------
> *From:* kde-devel  on behalf of Jan Grulich <
> jgrul...@redhat.com>
> *Sent:* Monday, October 19, 2020 07:34
> *To:* kde-devel@kde.org 
> *Subject:* Re: Not able to take screenshots with KDE Plasma 5.20.80
>
> Hi,
>
> can you try to add "X-KDE-DBUS-Restricted-Interfaces=org.kde.kwin.Screenshot"
> into the xdg-desktop-portal-kde desktop file and restart it?
>
> Regards,
> Jan
>
> ne 18. 10. 2020 v 22:50 odesílatel Damir Porobic 
> napsal:
>
> Hello,
>
> anyone any feedback on this one? Kind of breaks all non KDE Screenshot
> tools under Wayland.
> Would be nice to know if this is by error or some additional steps are
> required now.
>
> Best regards,
> Damir
>
> --
> *From:* Damir Porobic 
> *Sent:* Wednesday, October 14, 2020 21:34
> *To:* kde-devel@kde.org 
> *Subject:* Re: Not able to take screenshots with KDE Plasma 5.20.80
>
> Seems to be related to this change here https://phabricator.kde.org/D29407
>
> Also, I see the same error when using org.freedesktop.portal.Screenshot
> which requires already confirmation by default so I'm bit confused why
> both, authorization and confirmation? Also, looking quickly through the
> discussion I haven't found any clue how a non KDE application could get
> access to those screenshot interfaces.
>
> Best regards,
> Damir
> --
> *From:* kde-devel  on behalf of Damir Porobic <
> damir_poro...@live.com>
> *Sent:* Wednesday, October 14, 2020 21:22
> *To:* kde-devel@kde.org 
> *Subject:* Not able to take screenshots with KDE Plasma 5.20.80
>
> Hello,
>
> one of my users informed me that he's not able to take screenshots with
> KDE Plasma Wayland anymore. I've just tested myself, with Plasma 5.19.5
> everything is working, with Plasma 5.20.80, it's not. My application
> supports two ways of taking screenshots under KDE Plasma, one is using
> "org.kde.kwin.Screenshot" like Spectacle and the other is using
> "org.freedesktop.portal.Screenshot". Interesting is that both stopped
> working with 5.20.80 but Spectacle seems to be able to take screenshot
> still. My imageGrabber that uses "org.kde.kwin.Screenshot" is basically a
> copy of Spectacles imageGrabber, so I'm wondering why it works for
> Spectacle and not for my application.
>
> Looking at the dbus-monitor sessions, I've notices an error saying:
> error_name=org.kde.kwin.Screenshot.Error.NoAuthorized reply_serial=32
> string "The process is not authorized to take a screenshot"
>
> That's something new. How can a process be authorized to take screenshots?
>
> Regards,
> Damir
>
>
>
> --
>
> Jan Grulich,
>
> Senior Software Engineer, Desktop Team
>
> Red Hat
>


-- 

Jan Grulich,

Senior Software Engineer, Desktop Team

Red Hat

Re: Not able to take screenshots with KDE Plasma 5.20.80

[Jan Grulich]

Hi,

can you try to add "X-KDE-DBUS-Restricted-Interfaces=org.kde.kwin.Screenshot"
into the xdg-desktop-portal-kde desktop file and restart it?

Regards,
Jan

ne 18. 10. 2020 v 22:50 odesílatel Damir Porobic 
napsal:

> Hello,
>
> anyone any feedback on this one? Kind of breaks all non KDE Screenshot
> tools under Wayland.
> Would be nice to know if this is by error or some additional steps are
> required now.
>
> Best regards,
> Damir
>
> --
> *From:* Damir Porobic 
> *Sent:* Wednesday, October 14, 2020 21:34
> *To:* kde-devel@kde.org 
> *Subject:* Re: Not able to take screenshots with KDE Plasma 5.20.80
>
> Seems to be related to this change here https://phabricator.kde.org/D29407
>
> Also, I see the same error when using org.freedesktop.portal.Screenshot
> which requires already confirmation by default so I'm bit confused why
> both, authorization and confirmation? Also, looking quickly through the
> discussion I haven't found any clue how a non KDE application could get
> access to those screenshot interfaces.
>
> Best regards,
> Damir
> --
> *From:* kde-devel  on behalf of Damir Porobic <
> damir_poro...@live.com>
> *Sent:* Wednesday, October 14, 2020 21:22
> *To:* kde-devel@kde.org 
> *Subject:* Not able to take screenshots with KDE Plasma 5.20.80
>
> Hello,
>
> one of my users informed me that he's not able to take screenshots with
> KDE Plasma Wayland anymore. I've just tested myself, with Plasma 5.19.5
> everything is working, with Plasma 5.20.80, it's not. My application
> supports two ways of taking screenshots under KDE Plasma, one is using
> "org.kde.kwin.Screenshot" like Spectacle and the other is using
> "org.freedesktop.portal.Screenshot". Interesting is that both stopped
> working with 5.20.80 but Spectacle seems to be able to take screenshot
> still. My imageGrabber that uses "org.kde.kwin.Screenshot" is basically a
> copy of Spectacles imageGrabber, so I'm wondering why it works for
> Spectacle and not for my application.
>
> Looking at the dbus-monitor sessions, I've notices an error saying:
> error_name=org.kde.kwin.Screenshot.Error.NoAuthorized reply_serial=32
> string "The process is not authorized to take a screenshot"
>
> That's something new. How can a process be authorized to take screenshots?
>
> Regards,
> Damir
>
>

-- 

Jan Grulich,

Senior Software Engineer, Desktop Team

Red Hat

Re: Using xdg-desktop-portal-kde to take screenshots

[Jan Grulich]

th=/org/freedesktop/DBus;
> interface=org.freedesktop.DBus; member=GetNameOwner
>string "org.kde.kded5"
> method return time=1601192692.082918 sender=org.freedesktop.DBus ->
> destination=:1.60 serial=10 reply_serial=20
>string ":1.6"
> method call time=1601192692.083083 sender=:1.60 ->
> destination=org.kde.kded5 serial=21 path=/modules/desktopnotifier;
> interface=org.kde.DesktopNotifier; member=watchDir
>string "/home/dporobic"
> method call time=1601192692.083099 sender=:1.60 ->
> destination=org.freedesktop.DBus serial=22 path=/org/freedesktop/DBus;
> interface=org.freedesktop.DBus; member=RemoveMatch
>string
> "type='signal',sender='org.freedesktop.DBus',interface='org.freedesktop.DBus',member='NameOwnerChanged',arg0='org.kde.kded5'"
> signal time=1601192696.749626 sender=:1.17 -> destination=(null
> destination) serial=57 path=/scheduler; interface=org.kde.baloo.scheduler;
> member=stateChanged
>int32 4
> signal time=1601192696.749779 sender=:1.17 -> destination=(null
> destination) serial=58 path=/scheduler; interface=org.kde.baloo.scheduler;
> member=stateChanged
>int32 0
>
> **
>
> And this is what my application console output spits out:
>
> **
> Got reply
> The path: /org/freedesktop/portal/desktop/request/1_50/u3
> **
>
> The call seems to be correct I guess. Any idea?
>
> Regards,
> Damir
>
> --
> *From:* Damir Porobic 
> *Sent:* Monday, September 21, 2020 10:31
> *To:* kde-devel@kde.org 
> *Subject:* Re: Using xdg-desktop-portal-kde to take screenshots
>
>
> When you run "dbus-monitor --session" and you perform the screenshot, do
> you see this signal to be called at all?
>
>
> Thanks Jan, I'll try that.
>
> Unfortunately no, again a limitation of the portal API as the portal is
> supposed to return an URI. You can however directly use KWin DBus interface
> to get a screenshot, specifying directly what type of screenshot you want
> to tak and you get the raw image. This however will make it work only in
> Plasma and will not work in an application running in sandbox without
> giving it access to DBus.
>
> My Application already supports native Plasma and Gnome Wayland
> Screenshots, but that does don't work if the application is packaged as
> Snap or when non Plasma or Gnome environments are used, so I'm trying to
> make this generic  Wayland solution work.
>
> Also, I've been playing around with this under Gnome too and they have
> also a Dialog but with a Share button instead of Save. I believe they are
> doing it like with the native Wayland solution by saving the image in a
> temp directory that is deleted on reboot and just providing the path to the
> image. The user can decide what to do with the image, save it permanently
> or do nothing and the image is gone. Though there I have the same problem
> that the gotScreenshotResponse is never called.
>
> Best regards,
> Damir
>
> --
> *From:* kde-devel  on behalf of Jan Grulich <
> jgrul...@redhat.com>
> *Sent:* Monday, September 21, 2020 08:08
> *To:* kde-devel@kde.org 
> *Subject:* Re: Using xdg-desktop-portal-kde to take screenshots
>
> Hi,
>
> ne 20. 9. 2020 v 18:37 odesílatel Damir Porobic 
> napsal:
>
> Hello Jan,
>
> finally I  found some time to upgrade my OS and got a newer Plasma Version
> but I'm still struggling with the Screenshot Portal.
>
> Here is my implementation, almost identical to yours from the test that
> you have linked me (pasting here only the relevant methods):I get the
> dialog which asks me what type of screenshot I want to take I select it, a
> small image is show in the dialog and I can click on save (which saves the
> image in my home directory) but the gotScreenshotResponse is never called.
> Any idea why?
>
>
> I have no idea. The code looks good and identical to what I have in the
> example. When you run "dbus-monitor --session" and you perform the
> screenshot, do you see this signal to be called at all?
>
>
> Can I tell the dialog where to save those images?
>
>
> Unfortunately no, I made it very basic, but patches are welcomed, it won't
> be a hard task to implement it.
>
>
> Can I tell the dialog right away what type of screenshot I want to take?
>
>
> Unfortunately no, this is not supported by the portal API.
>
>
> Can I just share the screenshot with my application without saving it?
>
>
> Unfortunately no, again a limitation of the portal API as the portal is
> supposed to return an URI. You can however directly use KWin DBus interface
> to get a screenshot, specifying directly what type of screenshot you want
> to tak and you get the raw image. This however will make it work only in
> Plasma and will not work in an application running in sandbox without
> giving it access to DBus.
>
> Regards,
> Jan
>
>

Re: Using xdg-desktop-portal-kde to take screenshots

[Jan Grulich]

Hi,

ne 20. 9. 2020 v 18:37 odesílatel Damir Porobic 
napsal:

> Hello Jan,
>
> finally I  found some time to upgrade my OS and got a newer Plasma Version
> but I'm still struggling with the Screenshot Portal.
>
> Here is my implementation, almost identical to yours from the test that
> you have linked me (pasting here only the relevant methods):I get the
> dialog which asks me what type of screenshot I want to take I select it, a
> small image is show in the dialog and I can click on save (which saves the
> image in my home directory) but the gotScreenshotResponse is never called.
> Any idea why?
>

I have no idea. The code looks good and identical to what I have in the
example. When you run "dbus-monitor --session" and you perform the
screenshot, do you see this signal to be called at all?


> Can I tell the dialog where to save those images?
>

Unfortunately no, I made it very basic, but patches are welcomed, it won't
be a hard task to implement it.


> Can I tell the dialog right away what type of screenshot I want to take?
>

Unfortunately no, this is not supported by the portal API.


> Can I just share the screenshot with my application without saving it?
>

Unfortunately no, again a limitation of the portal API as the portal is
supposed to return an URI. You can however directly use KWin DBus interface
to get a screenshot, specifying directly what type of screenshot you want
to tak and you get the raw image. This however will make it work only in
Plasma and will not work in an application running in sandbox without
giving it access to DBus.

Regards,
Jan

Re: Using xdg-desktop-portal-kde to take screenshots

[Jan Grulich]

Hi,

unfortunately the Screenshot portal doesn't seem to be present in Plasma
5.12, it was added into Plasma 5.13.

Regards,
Jan

ne 30. 8. 2020 v 10:38 odesílatel Damir Porobic 
napsal:

> Hey Jan,
>
> thanks for the Feedback, that is indeed a good tip, I'll have a look at
> it.
> Another question, do I need to activate it or is it available only after a
> specific version?
> I'm using Plasma 5.12.8 and it doesn't seem to be available.
>
> Regards,
> Damir
>
> --
> *From:* kde-devel  on behalf of Jan Grulich <
> jgrul...@redhat.com>
> *Sent:* Sunday, August 23, 2020 14:58
> *To:* kde-devel@kde.org 
> *Subject:* Re: Using xdg-desktop-portal-kde to take screenshots
>
> Hi,
>
> you can check how we use it in xdg-portal-test-kde (a simple app to test
> various portals).
>
> The code is here:
> https://invent.kde.org/libraries/xdg-portal-test-kde/-/blob/master/src/portaltest.cpp#L498
>
> Regards,
> Jan
>
> út 18. 8. 2020 v 12:59 odesílatel Méven  napsal:
>
> Le mar. 18 août 2020 à 12:04,  a écrit :
>
> Date: Mon, 17 Aug 2020 12:44:35 +
> From: Damir Porobic 
> To: "kde-devel@kde.org" 
> Subject: Re: Using xdg-desktop-portal-kde to take screenshots
> Message-ID:
> <
> am0pr09mb389099fac1a15b22f0e6d4afe5...@am0pr09mb3890.eurprd09.prod.outlook.com
> >
>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hello,
>
> has anyone experience with this portal?
>
> Best regards,
> Damir
>
> 
> From: kde-devel  on behalf of Damir Porobic <
> damir_poro...@live.com>
> Sent: Thursday, August 13, 2020 16:16
> To: kde-devel@kde.org 
> Subject: Using xdg-desktop-portal-kde to take screenshots
>
> Hello,
>
> I'm trying use the xdg-desktop-portal-kde (
> https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/blob/master/src/screenshot.cpp)
> portal in order to take screenshots under Wayland.
>
> If I understand correctly, making a DBus Call like this should open a
> Dialog with a Screenshot that can be shared with my application.
>
> *
> QDBusInterface interface(QStringLiteral("org.freedesktop.portal.Desktop"),
> QStringLiteral("/org/freedesktop/portal/Screenshot"),
> QStringLiteral("org.freedesktop.portal.Screenshot"));
> QDBusPendingReply reply;
>
> reply = interface.call(QStringLiteral("Screenshot"), "", QVariantMap());
>
> if (reply.isError()) {
> qCritical("Invalid reply from DBus: %s",
> qPrintable(reply.error().message()));
> emit canceled();
> } else {
> qCritical("Dbus success: %s",
> qPrintable(reply.argumentAt<0>().path()));
> }
> *
>
> But the path to the image is not returned in the result from this call.
> How am I supposed to get the result?
>
> Is there any example implementation that uses this portal? In Spectacle I
> have only seen the solution using org.kde.plasmashell, but not the portal
> solution.
>
> Thanks in advance!
>
> Best regards
> Damir
>
>
> Hi Damir,
>
> You need to pass an instance of QVariantMap that will be filled up with a
> uri field according to the code:
>
> auto result = QVariantMap();
> reply = interface.call(QStringLiteral("Screenshot"), "", );
> result.value("uri");
>
> But you might be missing parameters also :
>
> uint Screenshot(const QDBusObjectPath ,
> const QString _id,
> const QString _window,
> const QVariantMap ,
> QVariantMap );
>
> Also the file is saved in QStandardPaths::PicturesLocation with a
> timestamp.
>
> Documentation is at
> https://flatpak.github.io/xdg-desktop-portal/portal-docs.html#gdbus-org.freedesktop.impl.portal.Screenshot
>
> I hope this helps,
>
> Kind regards,
>
> --
> Méven
>
>
>

Re: Using xdg-desktop-portal-kde to take screenshots

[Jan Grulich]

Hi,

you can check how we use it in xdg-portal-test-kde (a simple app to test
various portals).

The code is here:
https://invent.kde.org/libraries/xdg-portal-test-kde/-/blob/master/src/portaltest.cpp#L498

Regards,
Jan

út 18. 8. 2020 v 12:59 odesílatel Méven  napsal:

> Le mar. 18 août 2020 à 12:04,  a écrit :
>
>> Date: Mon, 17 Aug 2020 12:44:35 +
>> From: Damir Porobic 
>> To: "kde-devel@kde.org" 
>> Subject: Re: Using xdg-desktop-portal-kde to take screenshots
>> Message-ID:
>> <
>> am0pr09mb389099fac1a15b22f0e6d4afe5...@am0pr09mb3890.eurprd09.prod.outlook.com
>> >
>>
>> Content-Type: text/plain; charset="iso-8859-1"
>>
>> Hello,
>>
>> has anyone experience with this portal?
>>
>> Best regards,
>> Damir
>>
>> 
>> From: kde-devel  on behalf of Damir Porobic <
>> damir_poro...@live.com>
>> Sent: Thursday, August 13, 2020 16:16
>> To: kde-devel@kde.org 
>> Subject: Using xdg-desktop-portal-kde to take screenshots
>>
>> Hello,
>>
>> I'm trying use the xdg-desktop-portal-kde (
>> https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/blob/master/src/screenshot.cpp)
>> portal in order to take screenshots under Wayland.
>>
>> If I understand correctly, making a DBus Call like this should open a
>> Dialog with a Screenshot that can be shared with my application.
>>
>> *
>> QDBusInterface
>> interface(QStringLiteral("org.freedesktop.portal.Desktop"),
>> QStringLiteral("/org/freedesktop/portal/Screenshot"),
>> QStringLiteral("org.freedesktop.portal.Screenshot"));
>> QDBusPendingReply reply;
>>
>> reply = interface.call(QStringLiteral("Screenshot"), "", QVariantMap());
>>
>> if (reply.isError()) {
>> qCritical("Invalid reply from DBus: %s",
>> qPrintable(reply.error().message()));
>> emit canceled();
>> } else {
>> qCritical("Dbus success: %s",
>> qPrintable(reply.argumentAt<0>().path()));
>> }
>> *
>>
>> But the path to the image is not returned in the result from this call.
>> How am I supposed to get the result?
>>
>> Is there any example implementation that uses this portal? In Spectacle I
>> have only seen the solution using org.kde.plasmashell, but not the portal
>> solution.
>>
>> Thanks in advance!
>>
>> Best regards
>> Damir
>>
>
> Hi Damir,
>
> You need to pass an instance of QVariantMap that will be filled up with a
> uri field according to the code:
>
> auto result = QVariantMap();
> reply = interface.call(QStringLiteral("Screenshot"), "", );
> result.value("uri");
>
> But you might be missing parameters also :
>
> uint Screenshot(const QDBusObjectPath ,
> const QString _id,
> const QString _window,
> const QVariantMap ,
> QVariantMap );
>
> Also the file is saved in QStandardPaths::PicturesLocation with a
> timestamp.
>
> Documentation is at
> https://flatpak.github.io/xdg-desktop-portal/portal-docs.html#gdbus-org.freedesktop.impl.portal.Screenshot
>
> I hope this helps,
>
> Kind regards,
>
> --
> Méven
>

D28882: Create protocol to manage video feeds

[Jan Grulich]

jgrulich added a comment.


  I have tested this and it now works as before, tested with Chromium, while 
checking all the values we pass to the portal and PipeWire which seem to be 
correct.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29121: Replace foreach with range-for

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-5 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29121

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29091

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

[Jan Grulich]

jgrulich accepted this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29086

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29086: [NetworkManager-qt] Replace foreach with range/index for loop

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29086

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29068: [NetworkManager-qt] replace foreach (deprecated) with range-for, first pass

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-1 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29068

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Jan Grulich]

jgrulich added a comment.


  In D28882#653483 , @jgrulich wrote:
  
  > Doesn't seem to build here:
  >
  >   In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:
  >   
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121:
 error: ‘std::function’ has not been declared
  >  32 | ScreencastingSource(const QString , const QString 
, bool isOutput, const QRect , std::function);
  > |   
  ^~~~
  >   In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:
  >   
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:129:
 error: expected ‘,’ or ‘...’ before ‘<’ token
  >  32 | ScreencastingSource(const QString , const QString 
, bool isOutput, const QRect , std::function);
  > |   
  ^
  >   
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:41:1:
 error: no declaration matches 
‘KWayland::Server::ScreencastingSource::ScreencastingSource(const QString&, 
const QString&, bool, const QRect&, std::function)’
  >  41 | ScreencastingSource::ScreencastingSource(const QString 
, const QString , bool isOutput, const QRect , 
std::function call)
  > | ^~~
  >
  >
  
  
  Missing #include 

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Jan Grulich]

jgrulich added a comment.


  Doesn't seem to build here:
  
In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:

/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:121:
 error: ‘std::function’ has not been declared
   32 | ScreencastingSource(const QString , const QString 
, bool isOutput, const QRect , std::function);
  | 
^~~~
In file included from 
/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:7:

/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.h:32:129:
 error: expected ‘,’ or ‘...’ before ‘<’ token
   32 | ScreencastingSource(const QString , const QString 
, bool isOutput, const QRect , std::function);
  | 
^

/home/jgrulich/development/projects/kde/kwayland/src/server/screencasting_interface.cpp:41:1:
 error: no declaration matches 
‘KWayland::Server::ScreencastingSource::ScreencastingSource(const QString&, 
const QString&, bool, const QRect&, std::function)’
   41 | ScreencastingSource::ScreencastingSource(const QString 
, const QString , bool isOutput, const QRect , 
std::function call)
  | ^~~

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> screencast.xml:13
> +
> +
> +

Can we switch the values to follow xdg-desktop-portal specification?

See 
https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.impl.portal.ScreenCast.xml#L168.

Even not following the specs, output will be the most used one.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28241: Check correct file for sandbox detection

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R271:7f8d778b0a05: Check correct file for sandbox detection 
(authored by jgrulich).

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28241?vs=78362=78363

REVISION DETAIL
  https://phabricator.kde.org/D28241

AFFECTED FILES
  src/kdbusservice.cpp

To: jgrulich, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28241: Check correct file for sandbox detection

[Jan Grulich]

jgrulich created this revision.
jgrulich added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28241

AFFECTED FILES
  src/kdbusservice.cpp

To: jgrulich, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27932

To: cordlandwehr, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27769: modemmanager-qt: Convert license headers to SPDX expressions

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27769

To: cordlandwehr, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27665: Support SAE in securityTypeFromConnectionSetting

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:8142b3cfa66a: Support SAE in 
securityTypeFromConnectionSetting (authored by Haochen Tong 
i...@hexchain.org, committed by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27665?vs=76428=76513

REVISION DETAIL
  https://phabricator.kde.org/D27665

AFFECTED FILES
  src/utils.cpp

To: hexchain, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27665: Support SAE in securityTypeFromConnectionSetting

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  securityTypeFromConnectionSetting-support-SAE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27665

To: hexchain, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27327: Drop qmake pri file generation & installation, currently broken

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  dropbrokenprifile

REVISION DETAIL
  https://phabricator.kde.org/D27327

To: kossebau, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27328: Drop qmake pri file generation & installation, currently broken

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  dropbrokenprifile

REVISION DETAIL
  https://phabricator.kde.org/D27328

To: kossebau, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27328: Drop qmake pri file generation & installation, currently broken

[Jan Grulich]

jgrulich added a comment.


  Looking at some other frameworks, they basically have same code to generate 
pri files, are they all broken?
  
  For example: https://cgit.kde.org/bluez-qt.git/tree/src/CMakeLists.txt#n195

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D27328

To: kossebau, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27207: Use a less convoluted way to check if it's in flatpak

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27207

To: apol, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26461: [networkmanager-qt] Port QRegExp to QRegularExpression

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26461

To: ahmadsamir, #frameworks, jgrulich, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich closed this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich added a comment.


  In D23766#533644 , @apol wrote:
  
  > The patch looks good to me, is there a reason why it wasn't accepted?
  
  
  I'm not sure from the comment whether David requested some changes to be made 
now or whether this is good for now and we can improve this in future.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:4a6a5e708077: Add support for SAE authentication used by 
WPA3 (authored by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24689?vs=68156=68157

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich updated this revision to Diff 68156.
jgrulich added a comment.


  - Coding style

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24689?vs=68029=68156

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich added a dependent revision: D24691: Add support for WPA3.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D24689

To: jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich updated this revision to Diff 68029.
jgrulich added a comment.


  Compare against lowercase value

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24689?vs=68028=68029

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich added a reviewer: Frameworks.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D24689

To: jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D23713

To: rrichmond, fvogt, jgrulich
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

[Jan Grulich]

jgrulich added a comment.


  Do not enable "Custom cipher proposals" by default, that forces everyone to 
uncheck it.

REVISION DETAIL
  https://phabricator.kde.org/D23713

To: rrichmond, fvogt, jgrulich
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich updated this revision to Diff 65600.
jgrulich added a comment.


  Bump framework version
  
  Apparently KDE Frameworks 5.62 are already out.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23766?vs=65557=65600

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23766

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich added a dependent revision: D23769: Add support for keyboard key press 
and release from fake input protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> jgrulich wrote in fakeinput.h:222
> I will need a little bit of help to understand what type of key event should 
> be used and I don't remember where I got the information it expects codes 
> defined from linux/input-event-codes.h (I copied it from the previous review)
> 
> Anyway, for the remote desktop portal, we will need to support both keysym  
> and keycodes [1].
> 
> [1] - 
> https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.impl.portal.RemoteDesktop.xml#L226

Ok, I think I understand now.

KWin uses KeyboardInputRedirection::processKey(uint32_t key, 
InputRedirection::KeyboardKeyState state, uint32_t time, LibInput::Device 
*device), where Xkb::updateKey(uint32_t key, InputRedirection::KeyboardKeyState 
state) is called. The second method expects a key code as  defined in 
linux/input-event-codes.h and passing **key + 8** to xkb_state_update_key() 
call.

So I think we want to keep it this way and accept key codes as defined in 
linux/input-event-codes.h so we can directly bind this in KWin to a key press 
event.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> fakeinput.h:222
> + * Request a keyboard button release.
> + * @param linuxButton The button code as defined in 
> linux/input-event-codes.h
> + *

I will need a little bit of help to understand what type of key event should be 
used and I don't remember where I got the information it expects codes defined 
from linux/input-event-codes.h (I copied it from the previous review)

Anyway, for the remote desktop portal, we will need to support both keysym  and 
keycodes [1].

[1] - 
https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.impl.portal.RemoteDesktop.xml#L226

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich added reviewers: davidedmundson, apol, Plasma, romangg.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23766

To: jgrulich, davidedmundson, apol, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  Adds support for keyboard button press and release as defined in 
linux/input-event-codes.h

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23766

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

[Jan Grulich]

jgrulich added a comment.


  I'm not sure the "Cipher Proposals" groupbox should be inside the "Options" 
groupbox, imo it should be separated groupbox

INLINE COMMENTS

> strongswanwidget.cpp:100
>  d->ui.ipComp->setChecked(dataMap[NM_STRONGSWAN_IPCOMP] == "yes");
> +d->ui.proposal->setChecked(dataMap[NM_STRONGSWAN_PROPOSAL] == "yes");
> +d->ui.ike->setText(dataMap[NM_STRONGSWAN_IKE]);

Same here, probably pointless to set "IKE" and "ESP" when "Enable custom 
proposals" is false.

> pino wrote in strongswanwidget.cpp:155-156
> should these be set only when the custom proposals are accepted?

Indeed, they should be set only when the "Enable custom proposals" checkbox  is 
checked.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23713

To: rrichmond, fvogt, jgrulich
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> meven wrote in wirelessdevice.h:143
> I chose lastRequestScanTime to have RequestScan in the name, that is the 
> function, it keeps the last time called from.
> 
> The Time suffix does not feel great indeed.
> 
> I can make an adjustment to `lastRequestScan`, I will adjust D23578 
>  then

Please do, you can push it directly, it's just a function rename.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> wirelessdevice.h:143
> + */
> +QDateTime lastRequestScanTime() const;
>  /**

Thinking about it now, wouldn't be this wording better?

QDateTime lastScanRequestTime() const;

Maybe even without the "Time" at the end so it's consistent with "lastScan".

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich accepted this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Sorry, I missed that last one. Once it's fixed it's ready to go.

INLINE COMMENTS

> wirelessdevice.h:232
> + */
> +void lastScanChanged(const QDateTime timestamp);
>  

const QDateTime 

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> utils.h:86
> +
> +QDateTime clockBootTimeToQDateTime(const qlonglong );
>  }

1. Missing NETWORKMANAGERQT_EXPORT
2. I would remove 'Q' from the name → clockBootTimeToDateTime
3. just qlonglong clockBoottime, no const and &

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> meven wrote in wirelessdevice.cpp:250
> LastScan is in CLOCK_BOOTIME which is complicated to work with.
> So I use naively the signal time rather than the LastScan value.
> This will need a bit of work just to work with it:
> https://github.com/NetworkManager/NetworkManager/blob/a7d8fe0ea5eb7be42a86527226ea54fd221fb1b4/shared/nm-glib-aux/nm-time-utils.c#L193

Then cannot you work with it as with qlonglong? It shouldn't matter then if 
it's in CLOCK_BOOTIME .

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> wirelessdevice.h:133
> + * The time when the last "LastScan" property change was received
> + * @since 5.62.0
> + * @return

Add something like:
@note will always return invalid QDateTime when runtime NM < 1.12

> wirelessdevice.h:228
> + * @since 5.62.0
> + * @see lastScanTime
> + */

Add something like:
@note will never be emitted when runtime NM < 1.12

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> wirelessdevice.cpp:250
> +} else if (property == QLatin1String("LastScan")) {
> +lastScanTime = QDateTime::currentDateTime();
> +Q_EMIT q->lastScanTimeChanged(lastScanTime);

Don't use QDateTime::currentDateTime() as it might be different from the actual 
value returned by NetworkManager.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScan to WirelessDevice and associated change signal

[Jan Grulich]

jgrulich added a comment.


  In D23576#522340 , @meven wrote:
  
  > I am hesitant to add a second field "previousScan" that would store the 
previous lastScan timeStamp when a new one arrives.
  >  This would be used to compute the time elapsed between the scans which is 
necessary to do since Network manager requires scans to be at least 10 seconds 
apart :
  >  
https://github.com/NetworkManager/NetworkManager/blob/master/src/devices/wifi/nm-device-wifi.c#L1205
  
  
  That would be useful I guess and could be used in plasma-nm.
  
  1. You should set initial lastScan property to "-1" which should indicate 
there was no scan attempt
  2. Mention that it will work only when NM 1.12+ is running, older NM releases 
don't support this property
  3. Above mentioned will be a problem when you would like to rely on that in 
plasma-nm, because we should be working even with older NM versions

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Flatpak/Snap/Appimage BoF at Akademy

[Jan Grulich]

Hi,

do we want to do another Flatpak/Snap/Appimage BoF at Akademy this year? From 
my side it definitely can be useful and we can also have new people around 
this time and help them to package their applications if anyone is interested.

Which day would you prefer? There is AGM on Monday and a daytrip on Wednesday, 
while most of the Tuesday is taken by Plasma, which is where I expect most of 
the people. Does Thursday sound good to you?

Regards,
Jan

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  In D18114#498642 , @romangg wrote:
  
  > @jgrulich With D22571  looking 
promising do you want to put the keyboard parts of this diff into a separate 
one? There is still the question about keysyms and key events but we should 
discuss this in the new diff. Maybe we can have both: Keysyms for special keys 
/ combinations like Alt+Tab and text input via text-input protocol?
  
  
  I currently don't have that much time to look into this, but I'm glad we can 
move with this further. Maybe Akademy is a good opportunity to work on this, 
there are also some things which would be nice to improve in screen sharing 
support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: romangg, graesslin, zzag, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:2d5a66004425: device: include reapplyConnection() in the 
interface (authored by aleksanderm, committed by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20238?vs=55395=61585

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R281:a3d262f58d2f: Allow updating default DBus timeout on 
every interface (authored by aleksanderm, committed by jgrulich).

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22395?vs=61582=61583

REVISION DETAIL
  https://phabricator.kde.org/D22395

AFFECTED FILES
  src/bearer.cpp
  src/bearer.h
  src/call.cpp
  src/call.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/sim.cpp
  src/sim.h
  src/sms.cpp
  src/sms.h

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  aleksander/dbus-timeout

REVISION DETAIL
  https://phabricator.kde.org/D22395

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

[Jan Grulich]

jgrulich added a comment.


  I think all the methods should be called timeout() and setTimeout(), you are 
not changing default timeout which will always be 25s if -1 is set as timeout 
value. Also the getters should be const methods.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D22395

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21486: Don't fetch device statistics upon construction

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21486

To: apol, #plasma, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20833: Simpler check for flatpak

[Jan Grulich]

jgrulich added a comment.


  Lookgs good to me, I'll wait for Kai to approve this since he is the 
maintainer. One thing to consider maybe, did /.flatpak-info always exist or is 
it something new? I always assumed there is just one flatpak-info file in 
$XDG_RUNTIME_DIR. Just to be sure it will work for older Flatpak versions.

INLINE COMMENTS

> broulik wrote in knotificationmanager.cpp:94
> Do you need this check now, even, since you're not using it anymore?

I think Kai is right, since there is /.flatpak-info (which I didn't know about 
until now), you don't need to check $XDG_RUNTIME_DIR.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20833

To: apol, #frameworks
Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20649: [Notify by Portal] Support default action and priority hints

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Works for me. I tested both like the default action and urgency.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20649

To: broulik, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include Reapply() in the interface

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> device.h:241
> + */
> +QDBusPendingReply<> reapplyInterface(NMVariantMapMap connection, 
> qulonglong version_id, uint flags);
>  /**

1. const NMVariantMapMap 

2. I would maybe pick a different name, because it doesn't reapply interface, 
but it reapplies or updates connection. I would maybe use "reapplyConnection()"

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:12b58edd254a: FakeInput: add support for pointer move 
with absolute coordinates (authored by jgrulich).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49133=51668

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18762: Add support for portals in KRun

[Jan Grulich]

jgrulich added a comment.


  Looks good from the portal point of view, but I would rather wait for someone 
who knows KRun internally to approve this review.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  Ping @graesslin?
  
  Martin, can you please look into this?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  Hi, can I get please this re-approved? It's now just again about the 
additional mouse support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich updated this revision to Diff 49133.
jgrulich added a comment.


  Drop keyboard support from this review

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49087=49133

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich retitled this revision from "FakeInput: add support for pointer move 
with absolute coordinates and keyboard key press and release" to "FakeInput: 
add support for pointer move with absolute coordinates".
jgrulich edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich updated this revision to Diff 49087.
jgrulich added a comment.


  Fix documentation

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49082=49087

BRANCH
  fake-input-keyboard-key

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich added a comment.


  I didn't intent to push this together, but when creating a branch from master 
which already had first round of changes caused my second part of changes to be 
pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to 
get exception from David Faure to include this with KDE Frameworks 5.54. I 
thought the tagging is this saturday and tarballs are made after that, but I 
was wrong. I would really like to push the remote desktop support into Plasma 
5.15, I have almost complete support in xdg-desktop-portal-kde and krfb.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich retitled this revision from "FakeInput: add support for pointer move 
with absolute coordinates" to "FakeInput: add support for pointer move with 
absolute coordinates and keyboard key press and release".
jgrulich edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49082.
jgrulich added a comment.


  Add support for keyboard key press and release

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49081=49082

BRANCH
  fake-input-keyboard-key

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49081.
jgrulich added a comment.


  Bump fake interface version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49071=49081

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49071.
jgrulich added a comment.


  Coding style

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49070=49071

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49070.
jgrulich added a comment.


  Fix review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49069=49070

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49069.
jgrulich added a comment.


  Adress review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49066=49069

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49066.
jgrulich added a comment.


  Add information when new methods were introduced and bump version of 
FakeInput in registry

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49064=49066

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49064.
jgrulich added a comment.


  Revert unwanted changes in CMakeLists

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49046=49064

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked 4 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49046.
jgrulich added a comment.


  Use QPointF instead of QSizeF and bump interface version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49028=49046

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  CMakeLists.txt
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a dependent revision: D18115: Add support for fake pointer move 
with absolute coordinates.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a reviewer: davidedmundson.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jgrulich requested review of this revision.

REVISION SUMMARY
  For remote desktop support, we need to move with the pointer using absolute 
position.

TEST PLAN
  I tested this with xdg-desktop-portal-kde and krfb and it worked.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17743: Extend getExtensionFromPatternList reg exp filtering

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17743

To: davidedmundson, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich added a comment.


  In D17529#375913 , @wbauer wrote:
  
  > In D17529#375909 , @jgrulich 
wrote:
  >
  > > So maybe go with the easiest approach and just instead of defines use 0 
and 1?
  >
  >
  > Fine with me.
  >
  > Should I make that conditional depending on the NM version maybe, or just 
unconditionally use the numbers?
  
  
  Unconditionally. It doesn't matter if it uses defines or numbers directly.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich added a comment.


  So maybe go with the easiest approach and just instead of defines use 0 and 1?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17529: [proxysetting] Fix build with NM 1.4

[Jan Grulich]

jgrulich added a comment.


  I think the easiest solution here is just to set 0 and 1 to the enum values, 
instead of NM defines. I'm not sure if adding/removing enum is ABI compatible 
change, because the enum will disapper once you build it against NM 1.6.0+.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17529

To: wbauer, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: Added DCB settings

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:4332597370b8: Added DCB settings (authored by pranavgade, 
committed by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17425?vs=47338=47340#toc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17425?vs=47338=47340

REVISION DETAIL
  https://phabricator.kde.org/D17425

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  src/CMakeLists.txt
  src/settings/dcbsetting.cpp
  src/settings/dcbsetting.h
  src/settings/dcbsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D17425: Added DCB settings

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D17425: Added DCB settings

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> dcbsetting.cpp:491
> +
> +if (priorityFlowControl(7) > 0) {
> +setting.insert(QLatin1String(NM_SETTING_DCB_PRIORITY_FLOW_CONTROL), 
> QVariant::fromValue(priorityFlowControl()));

I think all those should be added all the time, checking whether the last one 
is higher can sometime avoid adding them to the map when one of previous ones 
is set to non-default value.

> dcbsetting.cpp:527
> +dbg.nospace() << NM_SETTING_DCB_PRIORITY_FLOW_CONTROL_FLAGS << ": " << 
> setting.priorityFlowControlFlags() << '\n';
> +
> +return dbg.maybeSpace();

You don't print priorityBandwith, priororityGroupBandwidth and others.

> dcbsetting.h:43
> +
> +enum DcbFlagsType {
> +None = 0,

Rename to DcbFlagType

> dcbsetting.h:124
> +};
> +
> +NETWORKMANAGERQT_EXPORT QDebug operator<<(QDebug dbg, const DcbSetting 
> );

Please also add Q_DECLARE_OPERATORS_FOR_FLAGS(DcbSetting::DcbFlags)

> setting.h:97
>  Q_DECLARE_FLAGS(SecretFlags, SecretFlagType)
> -
> +
>  enum MacAddressRandomization {

Remove trailing spaces. They are not visible here, but once I apply this patch, 
I see them in KDevelop.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17425

To: pranavgade, jgrulich
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D17497: A minor typo in ipv4 test

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:7036e0ade135: A minor typo in ipv4 test (authored by 
jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17497?vs=47321=47322

REVISION DETAIL
  https://phabricator.kde.org/D17497

AFFECTED FILES
  autotests/settings/ipv4settingtest.cpp

To: pranavgade, jgrulich, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns