Re: VDG application design sprint?

[Marco Martin]

for me would work either first half of june or july

On Thu, Apr 11, 2024 at 4:26 PM Nicolas Fella  wrote:
>
> On 1/24/23 00:43, Nicolas Fella wrote:
> > Hi,
> >
> > I think it would make sense for us to have a VDG sprint of sorts in the
> > near-ish future. This would allow to discuss some larger design topics
> > and set a vision for the longer-term future. I believe this is important
> > for us to be able to work together effectively.
> >
> > I'd suggest to focus on application design topics, like layout,
> > structure, and arrangement of apps, and less on things like Plasma and
> > styles/themes. I'd also suggest to approach this more from a design/UX
> > PoV and don't let us be driven by implementation details. But these are
> > just my suggestions that are subject to debate.
> >
> > Time/place/modality is all to be discussed, I'm mainly writing this to
> > gauge interest, so if you are interested let me know.
>
> Hi,
>
> I'd like to pick up this topic again since it's as relevant as ever.
>
> I have a possible venue in central Germany where I live (in an old
> castle, so in good KDE tradition). We could accomodate up to 10 people
> there, and more people nearby if needed.
>
> For those interested, what would be a good timeframe in terms of dates
> and duration?
>
> Cheers
>
> Nico
>

Re: Proposal unify back our release schedules

[Marco Martin]

On Friday, 19 April 2024 17.50.44 CEST Neal Gompa wrote:
> > > * "KDE Framework" will still exists as an entity and its ABI and API
> > > 
> > >   compatibility requirement. Only change is the release frequency and
> > >   the
> > > 
> > > introduction of a stable branch in sync with the other components.
> > 
> > That part I'm against for the above mentioned reasons, KF's release
> > frequency is a major feature of it.
> 
> As a distribution, I found it tremendously helpful to integrate and
> qualify the MegaRelease. That doesn't mean that we need *every*
> release of KF and Gear to be MegaReleases.

One thing I would like to hear from the distribution standpoint, is that in 
the past i also heard our release schedule being part of the reasons some 
enterprise distros dropped our stuff completely from the official release (suse 
and red hat). In part it sounded kinda an excuse to me, but if there is any 
part of truth is worth exploring.

is changing frequency or dates something that would help significantly distros? 
is there something about our current schedules that is a significant hindrance 
for distributions to the point "we don't feel we can adequately support it"?

a part of this discussion should have the point of a good relatioship with 
downstream in consideration (also because is part of the broader "getting to 
more users")

-- 
Marco Martin

Re: KSvg in kdereview

[Marco Martin]

I fixed CI, passes now

On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley  wrote:
>
> Hi all,
>
> Sysadmin has just received a request to move this repository to Frameworks, 
> however after seeing some of the comments raised here regarding the 
> repository I took a look myself to see if they had been corrected.
>
> At this time CI is still broken in KSvg, for both platforms - something that 
> was mentioned in an earlier email here.
> This does not inspire confidence that the code is up to scratch.
>
> I've therefore declined to move it to Frameworks at this time.
>
> Would be appreciated, given this is looking to be promoted to Frameworks, if 
> people could please have a further look at this repository and comment as 
> appropriate.
>
> Thanks,
> Ben
>
> On Wed, Jun 14, 2023 at 9:12 PM Marco Martin  wrote:
>>
>> Hi all,
>> Some time has passes, and changes have been done in the repo to
>> address some of the points.
>> Now there are review requests in plasma-framework which depends on
>> this repo (and accompanying plasma-workspace, plasma-desktop etc)
>> It would probably be better to have this in frameworks to have the
>> rest depending from it?
>>
>> On Thu, Apr 20, 2023 at 10:25 AM Marco Martin  wrote:
>> >
>> > Hi all,
>> > A part of plasma-framewrok, which is the one to do SVG-based themes,
>> > has now been splitted in a standalone library which is intended to be
>> > a new framework in KF6 (all usages of the plasma-framework version
>> > will be ported once this officially lands, and then those classes will
>> > be removed)
>> > The repo for now lives in
>> > https://invent.kde.org/libraries/plasmasvg
>> >
>> > In the end it will be renamed in ksvg
>> >
>> > Comments? reviews?
>> >
>> >
>> > --
>> > Marco Martin
>>
>> --
>> Marco Martin

Re: KSvg in kdereview

[Marco Martin]

Hi all,
Some time has passes, and changes have been done in the repo to
address some of the points.
Now there are review requests in plasma-framework which depends on
this repo (and accompanying plasma-workspace, plasma-desktop etc)
It would probably be better to have this in frameworks to have the
rest depending from it?

On Thu, Apr 20, 2023 at 10:25 AM Marco Martin  wrote:
>
> Hi all,
> A part of plasma-framewrok, which is the one to do SVG-based themes,
> has now been splitted in a standalone library which is intended to be
> a new framework in KF6 (all usages of the plasma-framework version
> will be ported once this officially lands, and then those classes will
> be removed)
> The repo for now lives in
> https://invent.kde.org/libraries/plasmasvg
>
> In the end it will be renamed in ksvg
>
> Comments? reviews?
>
>
> --
> Marco Martin

-- 
Marco Martin

Re: KSvg in kdereview

[Marco Martin]

On Fri, May 12, 2023 at 3:41 PM Friedrich W. H. Kossebau
 wrote:
> Did some small fixes (library e.g. was installed with literal ".SOVERSION" as
> suffix...), but the more I did and more I saw... IMHO this should not have yet
> been passed to kdereview, being in alpha state for my taste.

ouch, sorry :/ and thanks
one thing that will make the landing even longer is that at the plasma
sprint we decided it was the case
 for making it depend from a new (also not yet landed) framework (the
new home for KColorScheme) so
it will still take more time.

> E.g. "TODO KF6" ideally would not be handled during the review phase, but
> before.

there was still one todo kf6 which after some tought and discussion
was then removed
as doing that it would cause a regression in themes we don't want.

> And the README and other docs not (yet) mentioning what the scope & purpose of
> the library, but being dead copies from Plasma Framwworks also makes things
> harder to assess.

ok, i'll write a more comprehensive introduction there

> Builds on CI all failing ever since and before also looks a bit unattractive.
> Currently still with FreeBSD.

fixed it now

> For the name, "KSvg" sounds very unspecifc to me, ideally the name would
> reflect the purpose & scope of the library some more (but then that is not
> defined somewhere also, so... ;) ). Something with SVG, but what exactly?
> Perhaps "KSvgTheme" (proposed by Sune on irc) or similar might make it more
> clear?

I'm not sure, compared to the plasma version the "theming" part has
been scaled down a bit
(so that the "theme" class becaume "imageset" as most of the
kcolorscheme wrapping api is gone)
I'm not opposed to changing the name again, but not sure what other
names could actually be more clear.
so, basically the things that does over qsvg (the why for using qtsvg
not directly) are:

* disk caching of the rendered pixmaps to have things faster
* stylesheet based recoloring
* the fact that svgs can come in bundles (the theming part, tough is
not the main thing, so i would not give the name of the whole library
after that)
* the 9 patch framesvg for doing rectangular things
* qml bindings

> Also using "KSvg" as namespace results in class names like KSvg::;Svg,
> KSvg::SvgItem, etc. which looks a bit strange to my eyes on consumer side due
> to the duplication. In my perfect world the naming would see some overhaul
> given this is a new library. Yes, some one-time porting pain, but sanity
> afterwards, for a certain type of sustainability ;)

one thing is that the library is really about svgs and nothing else,
and the Svg class is about rendering one single svg,
so I don't see many ways around about both contianing "svg" ? (I was
aware there was an old kde3 ksvg library,
 though talking about it in some tuesday meeting didn't seem to be an issue)
Open to ideas :)

-- 
Marco Martin

Re: KSvg in kdereview

[Marco Martin]

On Sun, Apr 23, 2023 at 11:05 AM Albert Astals Cid  wrote:
> > Comments? reviews?
>
> There's a few "TODO KF6" in the code, should those be addressed?

ok, I'll go over all of them in the review period

> Is the plan to make it less plasma-specific with the rename?
>
> i.e. the ImageSet constructor says
>
> Default constructor. It will be the global theme configured in plasmarc
>
> Is that wanted or not (i've no opinion, just asking to make sure since the
> rename seems to want to make it "less plasma").

hm, it looks like there is still some stray documentation which
doesn't completely  reflect truth anymore
(right now it doesn't use that config file anymore, it's up tp the
user's code) will correct

-- 
Marco Martin

KSvg in kdereview

[Marco Martin]

Hi all,
A part of plasma-framewrok, which is the one to do SVG-based themes,
has now been splitted in a standalone library which is intended to be
a new framework in KF6 (all usages of the plasma-framework version
will be ported once this officially lands, and then those classes will
be removed)
The repo for now lives in
https://invent.kde.org/libraries/plasmasvg

In the end it will be renamed in ksvg

Comments? reviews?


-- 
Marco Martin

Meeting notes about Plasma::Svg

[Marco Martin]

All the svg stuff in plasma will be split in a new standalone
framework, at the moment repo living at:
https://invent.kde.org/mart/plasmasvg

New framework atm is called PlasmaSvg but is a library that should be
ok for apps as well (svgs with caching could be nice on android as
well for instance) -> Decided to call it KSvg (a library with that
name existed in kde3 times but not relevant anymore)

We will continue the standalone library, publish it as a framework
then start to move everything plasma to it, after that, we'll kill svg
from Plasma

No changes in Plasma svg stuff should be made anymore in plasma-framework

The framework will have a public library and a QML import
Public library:
* Svg   ->  almost unchanged
* FrameSvg  ->  almost unchanged   (do we still need the distinction
between margins and fixedmargins?)
* Theme ->  Ideally should die, but we would still need some of it
remaining (more on that later)

QML import:
* SvgItem  -> almost unchanged: the svg property should become an
imagePath string method instead
* FrameSvgItem -> almost unchanged
* Units-> used for the devicepixelratio scaling, as we want to
kill it, this unit will go.
* Theme-> shouldn't be accessible in QML anymore, it was used
only for colors, Kirigami::Theme should be used instead (which it
should give plasma colors when used in plasma)
* ColorScope   -> should be removed, all it did is the inherit featue
of Kirigami::Theme

* Plasma::Dialog uses framesvgItem internally from c++, what to do?
have those items publicly exported?


Plasma::Theme
It does separate things:
* path resolution for the svg files (almost like KPackage but slightly different
* colors: should be Kirigami::Theme
* wallpaper in theme  -> kill
* fonts from theme-> kill
* image and rects cache for the svgs  ->  should be internal api not
an exposed symbol (so we can start requiring timestamps)
* stuff that wraps KWindowSystemS: those are used to choose between
the opaque, normal or translucent versions based on composite and blur
effect, it should become api set by Plasma


Summary of dependencies:
Can something be further slimmed down?
Archiveto read svgz and do stylesheet before giving it
to the renderer
ConfigWidgets  KColorScheme, read colorscheme from theme
folder, apply it to stylesheet
GuiAddons  KImageCache
IconThemes KIconEffects (can it be hardcoded at this
point? effect is not even exposed in systemsettings anymore)
WindowSystem+x11   Loading files from the "translucent" folder
when compositing/blur effect is active, will be replaced by api
exposed by some singleton called by plasma
Kirigami2  If we are going to directly call Theme/Units
from C++, as SvgItem/FrameSvgItem do for the plasma counterparts


-- 
Marco Martin

Re: kirigami2 and oxygen-icons5 in kf6

[Marco Martin]

On Fri, Jan 27, 2023 at 12:04 PM Jonathan Riddell  wrote:
> There's one outlier which is kirigami where the tar is named kirigami2
> https://invent.kde.org/frameworks/kirigami
>
> That was to make it co-installable with kirigami 1 but nothing uses that now 
> so it can be dropped.  Can I suggest renaming "kirigami2" tar to be 
> "kirigami" again?

+1 from me to rename it back to just kirigami

-- 
Marco Martin

Splitting Plasma-frameworks

[Marco Martin]

Hi all,
I've resurrected a project i started a long time ago. Since Plasma
Dataengines are now deprecated, but being able to port away everything
for Plasma 6.0 is not a given, I've started a split as a standalone
dataengines library called Plasma5Support, so far in my personal area
https://invent.kde.org/mart/plasma5support

Even in the unlikely event if we can port all the things in time and
end up not releasing this, It will allow to having what we don't want
removed from libplasma to not have big unwanted thing there for the 6
lifetime.

as soon as workspace goes kf6, i would then port plsmoids to use that,
and then remove dataengines from p-f

I would like after ironing out the obvious big rough edges to make it
a module in workspace (after workspace is kf6 of course)

Opinions? comments?


-- 
Marco Martin

Re: Urgent: kirigami unittest broken

[Marco Martin]

On Sat, Jul 2, 2022 at 3:17 PM David Faure  wrote:
>
> On samedi 2 juillet 2022 15:09:21 CEST ivan tkachenko wrote:
> > https://invent.kde.org/frameworks/kirigami/-/commit/
> > 7775fea13c02c3bf836f5c0bf0580284d0f3904d
> >
> > Should be good now. Again, sorry for the trouble.
>
> All green (well, blue), thanks Ivan, that was quick!
>
Thanks Ivan indeed :)

This may mitigate the problem in the future,
https://invent.kde.org/frameworks/kirigami/-/merge_requests/588
requiring tests passing only on BSD for now as on linux being a bunch of
qt6 porting is still missing (like things depending on custom shaders)
they are still expected to fail


-- 
Marco Martin

Re: KF 5.95-rc1 delayed

[Marco Martin]

On Wed, Jun 8, 2022 at 11:01 PM Luca Carlon  wrote:
>
> On Wed, Jun 8, 2022 at 11:41 AM David Faure  wrote:
>
> > > > This also seems like something we should also fix before tagging:
> > > > https://bugs.kde.org/show_bug.cgi?id=454635#c11
> >
> > Luca, Marco: I need your input quickly on this one.
>
> https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/545
>
> Isn't this also pretty relevant?
> https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/535

Both are approved


-- 
Marco Martin

Re: Request for help for developing new XDG StatusNotifier/AppIndicator spec for KDE+GNOME

[Marco Martin]

On lunedì 17 gennaio 2022 22:16:12 CET Neal Gompa wrote:
> The new specification development has been kicked off with an issue on
> the xdg-specs repository:
> https://gitlab.freedesktop.org/xdg/xdg-specs/-/issues/84

Modernizing the spec to be usable in sandboxed apps would be a thing i'm 
intersted in.. (original spec dates as back as 2009 btw so yeah, they really 
weren't a thing back then)
On the KDE side I'm wondering what would be the best approach, we would 
probably have to migrate both the semi-deprecated kstatusnotifieritem in 
knotifications and qdbussystemtray upstream in Qt

-- 
Marco Martin

Re: Moving plasma-frameworks & krunner to Plasma release set for *6? (was: Re: KF6 meeting notes 2021-04-17)

[Marco Martin]

On sabato 17 aprile 2021 16:38:32 CEST Friedrich W. H. Kossebau wrote:
> It seems these days the only real user of plasma-frameworks & krunner
> libraries is the Plasma shell itself, with other applications only providing
> plugins/extensions and only targeting Plasma again. IIRC Amarok was the
> only other project ever making use of Plasmoid technology, but not sure
> that still works even. For KRunner, which also seems to have been once
> designed for other, non-shell purposes, I am not aware of anything else.

The plan is to actually split plasma-framework in several pieces, some of 
which will go into frameworks, some in frameworks, some in workspace



-- 
Marco Martin

Re: Plasma Bigscreen in Kdereview

[Marco Martin]

On Mon, Jan 25, 2021 at 10:51 PM Albert Astals Cid  wrote:

> > like all those in plasma-desktop do as well
>
>   kcms/audio-device-chooser/CMakeLists.txt:25 (kpackage_install_package)
>   kcms/wifi/CMakeLists.txt:25 (kpackage_install_package)
>   kcms/kdeconnect/CMakeLists.txt:25 (kpackage_install_package)

yes, is exactly like kcms in plasma-desktop, where all the package
names are all library name, so kcm_foo i would prefer to keep that
consistent with those? (then, is definitely possible to do
kcm_org.kde.foo ir required, for both package and library)

--
Marco Martin

Re: Plasma Bigscreen in Kdereview

[Marco Martin]

On Sun, Jan 24, 2021 at 10:19 PM Albert Astals Cid  wrote:
>
> > we just converted license headers to SPDX, the code should be in
> > fairly good shape by now
>
> The ATTRIBUTION file on the root feels like it would need some qualification 
> over to which files it applies.
>
> There's a few
>  KPackage components should be specified in reverse domain notation.
> on cmake time, not sure how bad those are.

What are those that are not ok? i can only see it in kcms, which need
to have same package name as the kcm library name, so usually kcm_foo
like all those in plasma-desktop do as well

> Your cmake deps says you support Qt 5.9, but your QML imports say otherwise. 
> Given that you seem to require Plasma 5.19, I would suggest to increase your 
> cmake/KF5/Qt5 deps to that of what Plasma 5.19 requires.
>
> files in ./kcms/plasma-settings-shell have i18n calls but as far as I can see 
> not included in any Message.sh

those are fixed

> files in ./shell/contents/configuration have i18n calls but as far as I can 
> see not included in any Message.sh

those are "special" and can't really be translatable, but none of
those qml files have strings anymore

-- 
Marco Martin

Re: Plasma Bigscreen in Kdereview

[Marco Martin]

On Fri, Jan 22, 2021 at 12:38 PM Yuri Chornoivan  wrote:
>
> пʼятниця, 22 січня 2021 р. 12:48:07 EET Marco Martin написано:
> > Hi all,
> > We would like a release of the Plasma Bigscreen project
> > which has been moved to kdereview, its repo is:
> > https://invent.kde.org/plasma/plasma-bigscreen
> >
> > It's a Plasma shell intended to use on smart tv kind of devices (ideal
> > is a setup like a raspberry pi4 attached to a tv) It's pretty much a
> > big tiles grid launcher for apps (which can be media-related apps,
> > clients for streaming services and what not)
> > It is also integrated with the Mycroft voice assistant open source
> > project, so supports voice commands and some apps like the youtube
> > client are done as internal mycroft skills.
> >
> > we just converted license headers to SPDX, the code should be in
> > fairly good shape by now
>
> Hi,
>
> 1. Translatable messages from /shell and /kcms/plasma-settings-shell are not
> extracted (no Messages.sh).

that should be fixed for shell. /kcms/plasma-settings-shell actually
can't be extracted (is going to be installed inside another package
and going to use the same domain of this other thing. in the end there
was a single message that wasn't even shown, so removed the message
and the whole folder shouldn't have any user visible labels now.

> 2. i18nd() usage in QMLs is at least inconsistent.

now the pieces that do need a domain to be translatable should include
the correct one.



-- 
Marco Martin

Plasma Bigscreen in Kdereview

[Marco Martin]

Hi all,
We would like a release of the Plasma Bigscreen project
which has been moved to kdereview, its repo is:
https://invent.kde.org/plasma/plasma-bigscreen

It's a Plasma shell intended to use on smart tv kind of devices (ideal
is a setup like a raspberry pi4 attached to a tv) It's pretty much a
big tiles grid launcher for apps (which can be media-related apps,
clients for streaming services and what not)
It is also integrated with the Mycroft voice assistant open source
project, so supports voice commands and some apps like the youtube
client are done as internal mycroft skills.

we just converted license headers to SPDX, the code should be in
fairly good shape by now

-- 
Marco Martin

D29390: Respect QIcon::fallbackSearchpaths()

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  go for it :)

REPOSITORY
  R302 KIconThemes

BRANCH
  fallback

REVISION DETAIL
  https://phabricator.kde.org/D29390

To: nicolasfella, #plasma, #frameworks, mart
Cc: mart, kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D27223: add kirigami-gallery icon

[Marco Martin]

mart added a comment.


  can we fix this and go ahead?
  @mbruchert can you still work on it? want to put it on invent?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

Re: Recent breakage in kwallet

[Marco Martin]

would the recent patch
https://invent.kde.org/frameworks/kwallet/-/merge_requests/1
fix anything?

On Sat, May 16, 2020 at 10:40 AM David Faure  wrote:
>
> On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote:
> > Hi all,
> > Recently, the package of KWallet framework for neon (devel unstable,
> > package built out of current master state) seems to be broken: kwallet
> > now can't open anymore wallets previously created (it works if the
> > local kwallet data is deleted and recreated)
> > the weird thing is that it seems that with a manual build it works instead.
> > The only kinda suspicious commit is
> > 850219f83e7d746 fix compilation with -Werror=undef
> > which seems to fix.. big endian for everyone?
>
> It was supposed to only fix compiler warnings without changing behaviour at
> all.
>
> #if Q_BYTE_ORDER == Q_BIG_ENDIAN
> when neither is defined, evaluates to #if 0 == 0  (and warns)
>
> I defined both to 1, for the same result, but so that -Wundef doesn't warn.
>
> > still no idea why is broken only the distro-built package
>
> Any neon-specific patches to kwallet?
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

D29232: Introduce the Header color set

[Marco Martin]

mart closed this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack, ndavis
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: Introduce the Header color set

[Marco Martin]

mart marked 9 inline comments as done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: Introduce the Header color set

[Marco Martin]

mart retitled this revision from "[WIP][RFC]Introduce the Header color set" to 
"Introduce the Header color set".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

[Marco Martin]

mart updated this revision to Diff 83090.
mart added a comment.


  - update to new colors

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29232?vs=81363=83090

BRANCH
  arcpatch-D29232

REVISION DETAIL
  https://phabricator.kde.org/D29232

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29463

To: Zren, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  create-kcmshell-openSystemSettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

[Marco Martin]

mart added a comment.


  hmm, should probably check before whether systemsettings5 and kinfocenter 
exist beforehand and fallback to kcmshell if not?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Recent breakage in kwallet

[Marco Martin]

Hi all,
Recently, the package of KWallet framework for neon (devel unstable,
package built out of current master state) seems to be broken: kwallet
now can't open anymore wallets previously created (it works if the
local kwallet data is deleted and recreated)
the weird thing is that it seems that with a manual build it works instead.
The only kinda suspicious commit is
850219f83e7d746 fix compilation with -Werror=undef
which seems to fix.. big endian for everyone?
still no idea why is broken only the distro-built package

-- 
Marco Martin

D29527: Add MapProxySource

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  works perfectly :)

REPOSITORY
  R1049 KQuickCharts

BRANCH
  mapproxysource

REVISION DETAIL
  https://phabricator.kde.org/D29527

To: ahiemstra, mart
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29412: Add smallFont to Kirigami plasma style

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cblack/smallfont-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29412

To: cblack, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29222: Fix update auto selection

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-update-autoselection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29222

To: leinir, #frameworks, #plasma, bugseforuns, ngraham, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  add-kpackage-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

[Marco Martin]

mart added a comment.


  indeed, a bit more documentation then go for it

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D29201

To: alex, #plasma, ngraham, meven, broulik
Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28701: Add KPackage support to KNewStuffCore

[Marco Martin]

mart added a comment.


  +1 from me.
  does it need to go into next release or can also get in next+1?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29232: [WIP][RFC]Introduce the Header color set

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidre wrote in kcolorscheme.cpp:271
> Because the new colors are the replacement for theses colors. I thought one 
> of those might map to this

i also added a question on the task, whether final colors are decided for it, 
they should go up here
https://phabricator.kde.org/T10201

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

[Marco Martin]

mart requested review of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

[Marco Martin]

mart retitled this revision from "[WIP][RFC]Introduce the Tools color set" to 
"[WIP][RFC]Introduce the Header color set".
mart edited the summary of this revision.
mart edited the test plan for this revision.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Tools color set

[Marco Martin]

mart updated this revision to Diff 81363.
mart added a comment.


  call it Header

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29232?vs=81352=81363

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Tools color set

[Marco Martin]

mart retitled this revision from "Introduce the Tools color set" to 
"[WIP][RFC]Introduce the Tools color set".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29232: Introduce the Tools color set

[Marco Martin]

mart created this revision.
mart added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  This introduces two concepts: a new color set for Tools (or: titlebar?
  open question)
  and the possibility for a color set to have a different config group (a
  sub group) for different states (there, for inactive)
  
  the Tools area should probably also going to slowly relace the WM
  section of color themes
  
  This is needed for implement properly T10201 
, this graphical union
  between the titlebar and the toolbar.
  
  There is a problem of NColorSets that has been recently added,
  because it makes impossible to hard/impossible to
  properly add a set in a 100% abi compatible way, strictly speaking it
  should be compatible tough keeping NColorSets as the last value, is a
  kindof behavior change, though *should* be acceptable (old users would
  get the Tools value as NColorSets but everything working never the less)

TEST PLAN
  doing a color set with Tools group, the proper values get read

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: mart, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28701: Add KPackage support to KNewStuffCore

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> kpackagejob.cpp:55
> +
> +class KPackageTask : public QObject, public QRunnable
> +{

is it worth encapsulating it in a runnable? the installation of a package is 
already in a separathe thread.

> kpackagejob.cpp:97
> +});
> +loop.exec();
> +} else {

this would freeze a thread waiting another thread is done, while just using the 
job in an async wayshouldn't be much more heavy on the gui thread?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28805: Tweak kcmcontrols docs

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  tweakdocs

REVISION DETAIL
  https://phabricator.kde.org/D28805

To: nicolasfella, #frameworks, jucato, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> iconitem.cpp:40
>  
> +class IconItemSource : public QObject
> +{

does it have to be a QObject? it doesn't have properties, signals or 
invokables.. qobject is an expensive class so if you don't have to use oits 
features is better to avoid

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

D28620: Add readmes clarifying state of plasma component versions

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28620

To: davidedmundson, #plasma, apol, romangg, mart
Cc: romangg, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28606: Add iconSize property to PC2 ToolButton

[Marco Martin]

mart added a comment.


  I don't think we should put any new feature in plasmacomponents2. it will be 
removed in qt6 anyways and work should be more concentrated to a) port away 
from it altogether abd b) if the pc3 version doesn't work, put effort in fixing 
that

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D28466: Added Page element

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28466

To: niccolove, #plasma, ngraham, mart
Cc: ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28372: Added a merged look to the plasmoidheading and remove roundedborders

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> niccolove wrote in PlasmoidHeading.qml:77
> I'd go with no SVG, to make sure that the theme creators will see that it's 
> broken and add a merged- look. Keep in mind that the plasmoidheading svg was 
> added barely one month ago, and no big Plasma release had it yet, so I find 
> it very hard to believe that any third party theme already has it.

agree with nicolove

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28372

To: niccolove, #plasma
Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Marco Martin]

mart added a comment.


  In D28033#630450 , @ngraham wrote:
  
  >
  
  
  
  
  > shortDuration: 150ms
  >  longDuration: 250ms
  >  veryLongDuration: 500ms
  
  veryLongDuration doesn't sound too good, but if longduration goes 500ms 
probably a lot of existing things are going to look way too slow so +1 for 
compatibility

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28130: Introduce api for passive notifications

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:cebaeb4daf59: Introduce api for passive notifications 
(authored by mart).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77983=77987

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart, broulik
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28131: listen to passiveNotificationRequested

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:3fe22e067a73: listen to passiveNotificationRequested 
(authored by mart).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28131?vs=77984=77988

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28131: listen to passiveNotificationRequested

[Marco Martin]

mart updated this revision to Diff 77984.
mart added a comment.


  - const QVariant 

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28131?vs=77941=77984

BRANCH
  phab/passiveNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart updated this revision to Diff 77983.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77982=77983

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart updated this revision to Diff 77982.
mart added a comment.


  - const QVariant &

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28130?vs=77940=77982

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow which is better to not have inconsitencies

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28033: Create ExpandableListItem

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ExpandableListItem.qml:230
> If it's multiplied by a factor it's not a "standard duration" anymore.

to me this tells more that

- default durations right now are waaay too short
- we don't take into account that for movements and resizes, the actual 
duration should be a function of the travel distance, rather than a fixed 
duration

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Marco Martin]

mart added a comment.


  In D28033#630073 , @ngraham wrote:
  
  > (WRT duration) What should I do then? Hardcode something? Add a new 
duration in a separate patch? The only standard durations we have are all quite 
short; neither one feels suitable for the animation I'm using here.
  
  
  to me the real problem is really the default settings for durations 
longDuration became 150ms or so, (shortduration is something so short that 
usually the animation frames just gets dropped altogether so it's pointless to 
even use it ever)
  I know this was done in the attempt of improving animations, but the end 
effect is ridiculous and makes animations actually looking worse, either 
comically fast (super fast fades are ok, item movements or resizes shouldn't 
actually be too fast, or be perceived as threatening) or no frames rendered at 
all even if there is code for it
  the original default values of 150 and 250 msecs for short and long were 
quite fine actually
  
  also, we should probably start into looking using SmoothedAnimation speed 
more rather than durations (to not fix travel time, but travel speed) (as 
animators don't support it and we would need something that reacts to global 
animations settings probably we would need our implementation of the speed 
concept)
  
  https://valhead.com/2016/05/05/how-fast-should-your-ui-animations-be/
  https://www.nngroup.com/articles/too-fast-ux/
  
https://uxdesign.cc/the-ultimate-guide-to-proper-use-of-animation-in-ux-10bd98614fa9

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28130: Introduce api for passive notifications

[Marco Martin]

mart added a comment.


  In D28130#630325 , @davidre wrote:
  
  > I wonder if it's for the use case wehere an InlineMessage doesn't work does 
it need to contain actions?
  
  
  doesn't really *need* it, but matches the existing api already existing in 
ApplicationWindow

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28131: listen to passiveNotificationRequested

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28131

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28131: listen to passiveNotificationRequested

[Marco Martin]

mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  show passive notifications when the kcm asks to
  see D28130 

REPOSITORY
  R295 KCMUtils

BRANCH
  phab/passiveNotifications

REVISION DETAIL
  https://phabricator.kde.org/D28131

AFFECTED FILES
  src/kcmoduleqml.cpp

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart edited the summary of this revision.
mart edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28130

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28130: Introduce api for passive notifications

[Marco Martin]

mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  showPassiveNotification which mirrors
  ApplicationWindow.showPassiveNotification
  some kcms need to show a tiny non interrupting message for which neither
  a dialog nor an InlineMessage are adapt.

REPOSITORY
  R296 KDeclarative

BRANCH
  phab/passivenot

REVISION DETAIL
  https://phabricator.kde.org/D28130

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Marco Martin]

mart added a comment.


  to me it should be in plasma extracomponents
  
  (and with a warning in the docs that such an item should be used only in 
lists that are known to have always very few items)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28028: [KCM Controls GridDelegate] Use `ShadowedRectangle`

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D28028

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> PlasmoidHeading.qml:52
> +enabledBorders: {
> +var borders = new Array()
> +borders.push('LeftBorder')

this can be an int
and instead of borders.push('LeftBorder')
borders |= PlasmaCore.FrameSvg.LeftBorder

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Marco Martin]

mart added a comment.


  In D27695#621985 , @niccolove 
wrote:
  
  > - Is code on line 51 fine? Lines are a bit long there
  
  
  yeah, is fine..
  unfortunately sunch superlong lines end up being very common in QML

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Marco Martin]

mart added a comment.


  I would call the component PlasmoidHeading, to make clear it's only for use 
in plasmoids

INLINE COMMENTS

> TopArea.qml:28
> +
> +property bool flipped: false
> + 

enum Location {

  Header,
  Footer

(maybe a middle as well?)

  }

property Location location

> TopArea.qml:30
> + 
> +Layout.fillWidth: true
> +Layout.bottomMargin: flipped ? 0 : topAreaSvg.margins.top

shouldn't assume it's in a layout..
maybe keep Layout.fillwidth to keep it compact, layout margins shouldn't be 
necessary.

> TopArea.qml:37
> +
> +leftInset: -topAreaSvg.margins.left
> +rightInset: -topAreaSvg.margins.right

topAreaSvg.fixedMargins so works also when you disable them

> TopArea.qml:43
> +background: PlasmaCore.FrameSvgItem {
> +id: topAreaSvg
> +imagePath: "test"

you can check for headers:
plasmoid.location === Plasmacore.Types.TopEdge and disable the top border

same thing for footers, disabling bottom edge when 
plasmoid.location === Plasmacore.Types.BottomEdge

> TopArea.qml:44
> +id: topAreaSvg
> +imagePath: "test"
> +prefix: flipped? 'flipped' : ''

"plasmoidheading" svg name

> TopArea.qml:45
> +imagePath: "test"
> +prefix: flipped? 'flipped' : ''
> +}

prefixes as "header" and "footer"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart
Cc: davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27628: Buttons: allow to scale up icons

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0b89e7f3f089: Buttons: allow to scale up icons (authored 
by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27628?vs=76310=76769

REVISION DETAIL
  https://phabricator.kde.org/D27628

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack, ngraham, mart
Cc: mart, wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27628: Buttons: allow to scale up icons

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27628: Buttons: allow to scale up icons

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  always scale icons unless a size is specified in the api.
  this makes icon sizing more in line with plasma components 2

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/anothersizehint

REVISION DETAIL
  https://phabricator.kde.org/D27628

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/toolbutton3.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> iconitem.cpp:600
>  } else if (!m_icon.isNull()) {
> +
> KIconLoader::global()->setCustomPalette(KColorScheme::createApplicationPalette(Plasma::Theme().colorScheme()));
>  result = m_icon.pixmap(QSize(size, size) * (window() ? 
> window()->devicePixelRatio() : qApp->devicePixelRatio()));

maybe Plasma::Theme should have a qpalette getter?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack, ngraham, mart
Cc: mart, wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27444: Added top area

[Marco Martin]

mart added a comment.


  i also wonder if the normal "toolbar2 element already existing can be used..

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27444: Added top area

[Marco Martin]

mart added a comment.


  some considerations:
  
  - this toparea will need to "overflow" its parent for the exact distance 
needed to perfectly fuse with the background, and has to work with both dialogs 
and widgets-on-desktop (so we're kinda assuming those 2 backgrounds have the 
exact same shape) for this reason also fallback should be disabled and be used 
only in themes that directly provide it.
  - we need 2 margins here: how much we want to overflow, which i would say 
should be the actual framesvg margins, so one doesn't have to *ever* access the 
dialog instance or the applet background, and the margins we want to actually 
use as padding for its contents. we can decide either to put both as hints in 
the svg, or to use units.smallspacing as padding for the contents and be happy 
with it
  - i would provide one single svg with top and bottom areas so one can use 
something like that as a footer as well (and probably a frame that has nothing 
rounded)
  - if you have a top panel the top won't be rounded, we need a way to know 
this.. perhaps with plasmoid.location... not sure yet

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27444

To: niccolove, #vdg, ngraham, ndavis
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27460: fix layout size hints for button labels

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ba0b637de94a: fix layout size hints for button labels 
(authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75976=75977

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml
  tests/components/tabbar3.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Button.qml:62
> I don't understand this part about constraining the width to the parent 
> height  (for all 3)
> 
> If I remove it all the tests still pass.

was an extra constraint to have buttons always square, but i added some test 
and removed this , they seem to behave always well without it

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart updated this revision to Diff 75976.
mart marked an inline comment as done.
mart added a comment.


  - remove extra check for squareness

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75972=75976

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml
  tests/components/tabbar3.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in button3.qml:90
> You didn't even run this :(
> 
> 1. icon.name not icon.source
> 2. now the comment next to it is wrong
> 3. there's a binding loop
> 
> 4. if I make a test without any text, which is what the thing you're 
> supposedly fixing was doing, I don't get an icon

sorry,
tested, fixed the problem and added new tests

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart updated this revision to Diff 75972.
mart marked an inline comment as done.
mart added a comment.


  - fix button display property
  - add a test for tabbar

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75927=75972

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml
  tests/components/tabbar3.qml
  tests/components/toolbutton3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart updated this revision to Diff 75927.
mart added a comment.


  - add an icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75922=75927

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in button3.qml:90
> this doesn't contain an icon, which is the majority of what this patch is 
> about

added

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart added a comment.


  latest version, plasmacontrols 2 and 3 one beside the other
  F8110874: Screenshot_20200218_160904.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart updated this revision to Diff 75922.
mart added a comment.


  - some quirks to make it more similar to pc2

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27460?vs=75833=75922

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/button3.qml

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27460: fix layout size hints for button labels

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  icon sizes and label placements tested correct in  several scenarios
  
  - control.icon.width/height is used as maximum size of the icon
  - if the button is smaller icons always scale down
  - icons stay ccentered regardless of button size when there is no text

TEST PLAN
  fixes icon sizes without workarounds like D27260 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/buttonslayout

REVISION DETAIL
  https://phabricator.kde.org/D27460

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26769: Always strip html if server does not support it

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  stripcorrently

REVISION DETAIL
  https://phabricator.kde.org/D26769

To: nicolasfella, #frameworks, broulik, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27399: make sure the size hints are integer and even

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:667dce502acf: make sure the size hints are integer and 
even (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27399?vs=75681=75688

REVISION DETAIL
  https://phabricator.kde.org/D27399

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27399: make sure the size hints are integer and even

[Marco Martin]

mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  for retrocompatibility with pc2 units.gridUnit * 1.6 is used
  a lot as size hint (we have to guarantee buttons and
  textfields have the same height by default for perfect
  horizontal alignment.
  tough we have make sure that size is integer and even otherwise
  we'll have a lot of internal misalignments

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/sizefixes

REVISION DETAIL
  https://phabricator.kde.org/D27399

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27396: support icon.width/height

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3de1c2462eda: support icon.width/height (authored by 
mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75677=75678

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart updated this revision to Diff 75677.
mart added a comment.


  - don't expose externally default size

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75675=75677

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart updated this revision to Diff 75675.
mart added a comment.


  - default icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75672=75675

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart added a comment.


  In D27396#611425 , @broulik wrote:
  
  > Don't we want to set a default? I keep seeing people hardcoding 
`icon.width` all over the place when they used PC3 and I want that to stop
  
  
  then should be i think smallMedium size for toolbuttons (and i guess 
tabbuttons) and small for normal pushbuttons

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  support the icon size hint of the control. Reinstate it in ToolButton
  and add the support for the other controls
  CCBUG:417514

TEST PLAN
  possible to control buttons icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27200: Make the attached property a simple QObject

[Marco Martin]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:68a273aef6c1: Make the attached property a simple QObject 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27200?vs=75133=75383#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27200?vs=75133=75383

REVISION DETAIL
  https://phabricator.kde.org/D27200

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml

To: mart, bshah, #plasma
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27200: Make the attached proeprty a simple QObject

[Marco Martin]

mart edited the test plan for this revision.
mart added reviewers: bshah, Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27200

To: mart, bshah, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27200: Make the attached proeprty a simple QObject

[Marco Martin]

mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  move all the logic in an attached property QObject
  it's a bit less heavy to create so should make things slightly better
  when this is used in delegates

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/qobject

REVISION DETAIL
  https://phabricator.kde.org/D27200

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h

To: mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26898: expose an id for the wallpaper

[Marco Martin]

mart updated this revision to Diff 74320.
mart added a comment.


  plasmoidId to avoid potential future clashes with QML id

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26898?vs=74319=74320

BRANCH
  phab/wallpaperid

REVISION DETAIL
  https://phabricator.kde.org/D26898

AFFECTED FILES
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns