D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/drive.svg
  src/desktoptheme/breeze/icons/edit.svg
  src/desktoptheme/breeze/icons/go.svg
  src/desktoptheme/breeze/icons/list.svg
  src/desktoptheme/breeze/icons/media.svg
  src/desktoptheme/breeze/icons/plasmavault.svg
  src/desktoptheme/breeze/icons/plasmavault_error.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0ff81fe4c728: Align zs to pixel grid in system.svg 
(authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20597?vs=56356=56365

REVISION DETAIL
  https://phabricator.kde.org/D20597

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20597

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This does the same thing as D20586 , but 
for the Breeze desktop theme

TEST PLAN
  Looks exactly the same as D20586 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20597

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:db9fdceac1ac: Sharpen Zs in system-suspend* icons 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20586?vs=56331=56355

REVISION DETAIL
  https://phabricator.kde.org/D20586

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20586

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20586

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  They weren't aligned to the pixel grid before.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sharp-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20586

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#450349 , @GB_2 wrote:
  
  > Ping
  
  
  Sorry, I'm just busy right now and I'm not that familiar with QML, so it 
won't be quick and easy for me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20426: Improve "widget-alternatives" icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I can't think of any more suggestions that would be an obvious improvement, 
so I'll accept this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

[Noah Davis]

ndavis added a comment.


  Can you flip the direction of the 16px version? I know the icon you're 
copying the design of is also like this, but I think it needs to be fixed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:aaa6451d308e: Add go-up/down/next/previous-skip (authored 
by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20435?vs=55938=55939

REVISION DETAIL
  https://phabricator.kde.org/D20435

AFFECTED FILES
  icons-dark/actions/16/go-down-skip.svg
  icons-dark/actions/16/go-next-skip.svg
  icons-dark/actions/16/go-previous-skip.svg
  icons-dark/actions/16/go-up-skip.svg
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/22/go-down-skip.svg
  icons-dark/actions/22/go-next-skip.svg
  icons-dark/actions/22/go-previous-skip.svg
  icons-dark/actions/22/go-up-skip.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/32/go-down-skip.svg
  icons-dark/actions/32/go-next-skip.svg
  icons-dark/actions/32/go-previous-skip.svg
  icons-dark/actions/32/go-up-skip.svg
  icons/actions/16/go-down-skip.svg
  icons/actions/16/go-next-skip.svg
  icons/actions/16/go-previous-skip.svg
  icons/actions/16/go-up-skip.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/22/go-down-skip.svg
  icons/actions/22/go-next-skip.svg
  icons/actions/22/go-previous-skip.svg
  icons/actions/22/go-up-skip.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/32/go-down-skip.svg
  icons/actions/32/go-next-skip.svg
  icons/actions/32/go-previous-skip.svg
  icons/actions/32/go-up-skip.svg

To: ndavis, #vdg, #atelier, ngraham
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-go (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg, #atelier, ngraham
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis updated this revision to Diff 55938.
ndavis edited the summary of this revision.
ndavis added a comment.


  - Turn window-keep-* into symlinks to go-up/down-skip

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20435?vs=55899=55938

BRANCH
  more-go (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20435

AFFECTED FILES
  icons-dark/actions/16/go-down-skip.svg
  icons-dark/actions/16/go-next-skip.svg
  icons-dark/actions/16/go-previous-skip.svg
  icons-dark/actions/16/go-up-skip.svg
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/22/go-down-skip.svg
  icons-dark/actions/22/go-next-skip.svg
  icons-dark/actions/22/go-previous-skip.svg
  icons-dark/actions/22/go-up-skip.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/32/go-down-skip.svg
  icons-dark/actions/32/go-next-skip.svg
  icons-dark/actions/32/go-previous-skip.svg
  icons-dark/actions/32/go-up-skip.svg
  icons/actions/16/go-down-skip.svg
  icons/actions/16/go-next-skip.svg
  icons/actions/16/go-previous-skip.svg
  icons/actions/16/go-up-skip.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/22/go-down-skip.svg
  icons/actions/22/go-next-skip.svg
  icons/actions/22/go-previous-skip.svg
  icons/actions/22/go-up-skip.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/32/go-down-skip.svg
  icons/actions/32/go-next-skip.svg
  icons/actions/32/go-previous-skip.svg
  icons/actions/32/go-up-skip.svg

To: ndavis, #vdg, #atelier, ngraham
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis added a comment.


  Now I'll need to turn `window-keep-above` and `window-keep-below` into 
symlinks to `go-up-skip` and `go-down-skip`. `arc patch` hates it when files or 
symlinks are converted to each other, so I'll hold off doing that until this 
gets accepted.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg, #atelier
Cc: abetts, ngraham, laysrodrigues, kde-frameworks-devel, michaelh, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg
Cc: laysrodrigues, kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.
ndavis added a subscriber: laysrodrigues.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20435

To: ndavis, #vdg
Cc: laysrodrigues, kde-frameworks-devel, michaelh, ngraham, bruns

D20435: Add go-up/down/next/previous-skip

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  These are meant to be used when moving by the normal amount 
(go-up/down/next/previous) is too slow, but skipping all the way to the end of 
something is too far (go-top/bottom/first/last).

REPOSITORY
  R266 Breeze Icons

BRANCH
  more-go (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20435

AFFECTED FILES
  icons-dark/actions/16/go-down-skip.svg
  icons-dark/actions/16/go-next-skip.svg
  icons-dark/actions/16/go-previous-skip.svg
  icons-dark/actions/16/go-up-skip.svg
  icons-dark/actions/22/go-down-skip.svg
  icons-dark/actions/22/go-next-skip.svg
  icons-dark/actions/22/go-previous-skip.svg
  icons-dark/actions/22/go-up-skip.svg
  icons-dark/actions/32/go-down-skip.svg
  icons-dark/actions/32/go-next-skip.svg
  icons-dark/actions/32/go-previous-skip.svg
  icons-dark/actions/32/go-up-skip.svg
  icons/actions/16/go-down-skip.svg
  icons/actions/16/go-next-skip.svg
  icons/actions/16/go-previous-skip.svg
  icons/actions/16/go-up-skip.svg
  icons/actions/22/go-down-skip.svg
  icons/actions/22/go-next-skip.svg
  icons/actions/22/go-previous-skip.svg
  icons/actions/22/go-up-skip.svg
  icons/actions/32/go-down-skip.svg
  icons/actions/32/go-next-skip.svg
  icons/actions/32/go-previous-skip.svg
  icons/actions/32/go-up-skip.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add view-orientation-auto/landscape/portrait

[Noah Davis]

ndavis retitled this revision from "Add screen-rotate-auto-on/off" to "Add 
view-orientation-auto/landscape/portrait".
ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis updated this revision to Diff 55804.
ndavis added a comment.


  - Change to 3 icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19736?vs=53826=55804

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/16/view-orientation-auto.svg
  icons-dark/actions/16/view-orientation-landscape.svg
  icons-dark/actions/16/view-orientation-portrait.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/22/view-orientation-auto.svg
  icons-dark/actions/22/view-orientation-landscape.svg
  icons-dark/actions/22/view-orientation-portrait.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/32/view-orientation-auto.svg
  icons-dark/actions/32/view-orientation-landscape.svg
  icons-dark/actions/32/view-orientation-portrait.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons/actions/16/view-orientation-auto.svg
  icons/actions/16/view-orientation-landscape.svg
  icons/actions/16/view-orientation-portrait.svg
  icons/actions/22/view-orientation-auto.svg
  icons/actions/22/view-orientation-landscape.svg
  icons/actions/22/view-orientation-portrait.svg
  icons/actions/32/view-orientation-auto.svg
  icons/actions/32/view-orientation-landscape.svg
  icons/actions/32/view-orientation-portrait.svg

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  Those curves are perfect 

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg, ngraham, ndavis
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: arvidhansson; removed: ndavis.
ndavis added a comment.


  Alright. I'll finish it when I have time.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: ndavis, #vdg, arvidhansson
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Noah Davis]

ndavis added a comment.


  In D20226#442934 , @bruns wrote:
  
  > Diagonal or round shapes are **not** required to be pixel grid aligned. 
Actually, it is not even possible, as there is **always** some antialiasing. It 
even helps to make round shapes a little bit bit larger than the pixel grid, so 
some of the corner/edge pixels are solid color.
  
  
  I'm aware, but that's not the problem. If you look at the left side of the 
bell and the right side, the right side is wider. Maybe it's not that visible 
at 100%/96 DPI, but we should try to have resizable and reusable shapes when 
possible.
  
  F6749114: Screenshot_20190403_112343.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

[Noah Davis]

ndavis added a comment.


  In D20226#442906 , @GB_2 wrote:
  
  > In D20226#442882 , @ngraham 
wrote:
  >
  > > Also, could we create a 22x22 version too?
  >
  >
  > How can you efficiently do that without having to realign everything to the 
new grid manually?
  
  
  You'll have to create it from scratch again, using the same method you used 
to create the 16px version. If you use the method that I just showed you, it'll 
be much easier than drawing it, but you still need to figure out how to get 
proportions that look right.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Noah Davis]

ndavis added a comment.


  The proportions aren't quite right.
  
  F6749114: Screenshot_20190403_112343.png 

  
  This is one way to make a perfectly smooth bell. Subtract the red shapes from 
the black shapes.
  
  F6749117: Screenshot_20190403_112550.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Noah Davis]

ndavis added a comment.


  In D20166#441863 , @kossebau wrote:
  
  > IMHO the SVG files in the repo may contain comments and metadatas, for 
further work on them. Like source code also has all the oomments and metadata.
  >  Only the deployed graphics resource should then be limited and optimized 
for what is needed at runtime.
  >
  > At least I had dealt with quite some "final rendered" SVG files I would 
have liked to modify for some needs, but could hardly as the base resources 
where not available (and if it was only guides & Co.).
  
  
  I can see where you're coming from, but guides left by other people aren't 
that useful in my experience. I still have to guess how they made their shapes 
in the first place and there
  's no comment field that's visible from within Inkscape. Nobody ever puts 
comments in the code either. As long as you know how to use a Grid, 
Group/Ungroup and Combine/Break Apart, it's not hard to edit most existing 
icons. The few that are hard would not be improved by in-code comments or 
guides.
  
  In D20166#441875 , @bruns wrote:
  
  > [...] Also, stripping any whitespace makes diffs of minor changes quite 
large, as diffs align on lines, not tokens.
  
  
  Then we can use optimization rules that auto format and indent everything. It 
will expand the size of color icons a lot more than monochrome icons, but maybe 
we can live with that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Noah Davis]

ndavis added a comment.


  In D20166#441807 , @ngraham wrote:
  
  > Strictly speaking, there's no need to optimize the SVGs as a part of this, 
so maybe, yeah, let's split that out into a separate feature (and one that the 
Breeze Icons repo would ultimately be interested in as well).
  
  
  Yes. Ideally, designers should optimize their work before it is landed or at 
least not submit an SVG with tons of metadata.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Noah Davis]

ndavis added a comment.


  Be careful that you are not stripping stylesheets when you use SVG Cleaner. 
`scour` is less effective than SVG Cleaner, but it doesn't strip stylesheets 
and it's available in more distros.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20147: Improve executable dialog buttons' icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  Yes, this is much better. Wow, that `application-x-executable` icon is really 
blurry.

REPOSITORY
  R241 KIO

BRANCH
  improve-execute-dialog-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20147

To: ngraham, #vdg, GB_2, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  Another alternative would be to turn the thumbnail outline into a real 
outline instead of a rounded rectangle behind the thumbnailArea. Then it could 
go on top of the thumbnailArea and the thumbnail highlight could fit perfectly 
inside of it. This would give previews of rectangular images rounded corners 
and is significantly more complicated than the current change, but I feel like 
it should be possible.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  Here is how no radius for the thumbnailArea and thumbnail highlight looks: 
F6739553: Screenshot_20190331_131729.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20063: Sublime Merge Icon.

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:69d7182daffc: Sublime Merge Icon. (authored by otavva, 
committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20063?vs=54981=55140

REVISION DETAIL
  https://phabricator.kde.org/D20063

AFFECTED FILES
  icons-dark/apps/48/sublime-merge.svg
  icons/apps/48/sublime-merge.svg

To: otavva, #vdg, ndavis
Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, cblack, 
arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#440989 , @ngraham wrote:
  
  > It's probably going to be more noticeable for High DPI users. It seems like 
there must be a way to fix this rather than just removing the thumbnail radius.
  
  
  I could remove the radius for the thumbnailArea as well. Here's how the 
current change looks at 2x scaling: F6739477: Screenshot_20190331_123652.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis updated this revision to Diff 55106.
ndavis added a comment.


  - Remove radius from thumbnailArea highlight

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20140?vs=55105=55106

BRANCH
  grid-delegate-rectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20140

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  There was a small gap in the corners of the thumbnailArea highlight rectangle 
that was noticable on dark thumbnails.

REPOSITORY
  R296 KDeclarative

BRANCH
  grid-delegate-rectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20140

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20063: Sublime Merge Icon.

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  @otavva I need your email and real name to land your patch with the correct 
author. If you use the Arcanist tool for patches in the future, you will need 
to make sure that your real name is set as your Git user name.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, 
ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, 
GB_2, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, aaronhoneycutt, 
mbohlender

D20063: Sublime Merge Icon.

[Noah Davis]

ndavis added a comment.


  Oh wait no, it's not there yet, but it still looks pretty good.
  
  However, I did notice this on a closer inspection of the shapes:
  F6726111: Screenshot_20190327_182820.png 

  
  @otavva, could you make the top shape more like how it is in the official 
logo?
  
  https://www.sublimemerge.com/images/logo.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, 
ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, 
GB_2, rooty, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D20063: Sublime Merge Icon.

[Noah Davis]

ndavis added a comment.


  In D20063#439465 , @ngraham wrote:
  
  > I don't that version is actually in the patch though. @otavva can you 
update this patch to have that version of the icon? Then we can get it landed 
for you.
  
  
  No, it's there, but for some reason I see myself as the author of the commit 
instead of @otavva F6726093: Screenshot_20190327_182023.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, 
ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, 
GB_2, rooty, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D20063: Sublime Merge Icon.

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  This is very nice.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, 
ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, 
GB_2, rooty, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#439031 , @arvidhansson 
wrote:
  
  > In D19952#438965 , @ndavis wrote:
  >
  > > The rounded corners and bold 1 are not very breeze like, so I don't think 
so, unless he changes his design. Unless you still plan to do the icon 
yourself, you should probably hand off responsibility for the patch to someone 
else.
  >
  >
  > Sorry for the confusion, as I'm new to this I really need help and aren't 
able to do this alone, just just wanted to bring some attention to this and 
learn how to work with KDE. Thanks for all help, should we now use t-ask's 
first icon(the right one) or something else?
  
  
  No problem, it's just unfortunate that you picked an issue where other people 
already had their own ideas planned. If there weren't more than 1 design to 
look at, it would be easier for me to work with you 1-on-1. Why don't you try 
making an icon for an app you like that doesn't already have an icon in Breeze 
Icons? Not Firefox, Thunderbird or proprietary software, but there might be 
some exceptions. If you have questions, bring them up in the VDG chat.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  The rounded corners and bold 1 are not very breeze like, so I don't think so, 
unless he changes his design. Unless you still plan to do the icon yourself, 
you should probably hand off responsibility for the patch to someone else.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D12327: Show Detailed Tree View by default

[Noah Davis]

ndavis added a comment.


  +1
  
  Navigation is so much faster in tree view. I think navigation speed is what 
matters most of the time when people are selecting files or locations.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, apol
Cc: ndavis, kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, 
michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#438130 , @arvidhansson 
wrote:
  
  > In D19952#437726 , @ndavis wrote:
  >
  > > In D19952#437670 , 
@arvidhansson wrote:
  > >
  > > > In D19952#437419 , @ndavis 
wrote:
  > > >
  > > > > This can be done in the system tray widget instead of making a 
separate icon for off. Ever notice how the notifications icon is grey when it's 
not active?
  > > >
  > > >
  > > > Sorry, I don't understand, never had noticed anything special with the 
notifications.
  > >
  > >
  > > Top icon is for notifications (partly transparent), bottom icon is for 
Redshift (100% opacity)
  > >  F6718240: Screenshot_20190324_184101.png 

  > >
  > > In D19952#437664 , 
@arvidhansson wrote:
  > >
  > > > [...] is it just me or is the transparent icon more like grey?
  > >
  > >
  > > It's not just you, but that's how partly transparent black on a white 
background is supposed to look.
  >
  >
  > Okay, I get it, what should we do now?
  
  
  We only make `input-numlock-on`, no off version

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#437670 , @arvidhansson 
wrote:
  
  > In D19952#437419 , @ndavis wrote:
  >
  > > This can be done in the system tray widget instead of making a separate 
icon for off. Ever notice how the notifications icon is grey when it's not 
active?
  >
  >
  > Sorry, I don't understand, never had noticed anything special with the 
notifications.
  
  
  Top icon is for notifications (partly transparent), bottom icon is for 
Redshift (100% opacity)
  F6718240: Screenshot_20190324_184101.png 

  
  In D19952#437664 , @arvidhansson 
wrote:
  
  > [...] is it just me or is the transparent icon more like grey?
  
  
  It's not just you, but that's how partly transparent black on a white 
background is supposed to look.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#436853 , @arvidhansson 
wrote:
  
  > In D19952#436834 , @taskf wrote:
  >
  > > There is one issue I'm not sure about. The user might feel pressured to 
check something if the symbol is stroked as it fells like "something is wrong". 
In that case I would suggest just using the ON version and make it 50% 
transparent in OFF mode.
  >
  >
  > I agree, it isn't  even an caps-lock-off key. A 50% tranparent icon would 
fit better
  
  
  This can be done in the system tray widget instead of making a separate icon 
for off.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, taskf, ndavis, kde-frameworks-devel, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  Here's my attempt: F6711669: montage-breeze-Background.png 

  
  F6711673: input-numlock-on.16.svg 
  
  F6711674: input-numlock-on.22.svg 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#436425 , @taskf wrote:
  
  > Hi, I created some icons a week ago, just didn't post them as @arvidhansson 
was already on the task.
  >
  > They are not polished as you can see from the screenshot. The left version 
symbolizes a lock, while the right one, which I like more, symbolizes a 
keyboard key.
  >
  > F6711403: Screenshot_20190322_211216.png 

  
  
  I like the one on the right more. Our locks don't look like the once on the 
left.
  
  Normally, our strikethroughs (the red diagonal line) go from the top left to 
the bottom right, similar to the No symbol 
.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  You need to make the icons on 16x16px and 22x22px canvases. If you use a grid 
with 1 line every pixel, it will be easier to make icons look sharp.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  That "1" is too blurry. Did you use the font tool or did you draw it with the 
pen or rectangle tools?
  
  Since this is "numlock" Wouldn't it make more sense to put a "1" inside of a 
lock?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis added a comment.


  In D19736#434274 , @ngraham wrote:
  
  > Maybe the rectangle itself doesn't need to be so big? Or maybe it could be 
even bigger and have the arrows inside?
  
  
  I can make the rectangle slightly smaller. I can't make the rectangle bigger 
because of margins, but I might be able to fit some small arrows inside at the 
current size

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis added a comment.


  In D19736#434616 , @apol wrote:
  
  > How about having 3 icons? autorotate, locked portrait and locked landscape?
  >
  > This way we don't need to have a weird red strike-through.
  
  
  That's what I asked about the first time in D19690#430032 
 :P
  
  Sure, I can agree to that. I think being able to force a landscape or 
portrait orientation without going to the system settings would be a good 
feature.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis added a comment.


  This is what the current 32px version with arrowheads added looks like, but 
it can't be done like that with 16px or 22px. 
  F6701152: montage.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis added a comment.


  @ngraham Here's something similar to what you asked for: F6701127: 
Screenshot_20190318_235338.png 
  
  This is 22px. I couldn't get it to work for 16px.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

[Noah Davis]

ndavis added a comment.


  In D19812#433941 , @guoyunhe wrote:
  
  > In D19812#433916 , @ndavis wrote:
  >
  > > Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds 
since those are the colors we normally use for window backgrounds?
  >
  >
  > Like this?
  >
  > F6700542: image.png 
  
  
  Yes

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

[Noah Davis]

ndavis added a comment.


  Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds 
since those are the colors we normally use for window backgrounds?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:559782c5f5b4: Give applications-games and input-gaming 
more contrast with Breeze Dark (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17469?vs=53925=54035

REVISION DETAIL
  https://phabricator.kde.org/D17469

AFFECTED FILES
  icons-dark/categories/32/applications-games.svg
  icons-dark/devices/64/input-gaming.svg
  icons/categories/32/applications-games.svg
  icons/devices/64/input-gaming.svg

To: ndavis, #breeze, #vdg, guoyunhe, ngraham, rooty, filipf
Cc: rooty, abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, 
bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D19733

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

[Noah Davis]

ndavis retitled this revision from "Give applications-games more contrast with 
Breeze Dark" to "Give applications-games and input-gaming more contrast with 
Breeze Dark".

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis updated this revision to Diff 53925.
ndavis added a comment.


  Update input-gaming and make circle around dpad and colored buttons darker

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17469?vs=53839=53925

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

AFFECTED FILES
  icons-dark/categories/32/applications-games.svg
  icons-dark/devices/64/input-gaming.svg
  icons/categories/32/applications-games.svg
  icons/devices/64/input-gaming.svg

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Noah Davis]

ndavis added a comment.


  In D19733#431237 , @GB_2 wrote:
  
  > In D19733#431139 , @ndavis wrote:
  >
  > > I think `preferences-desktop-theme-applications` is fine, but 
`preferences-desktop-theme-windowdecorations` looks odd with that border. 
F6691545: Screenshot_20190314_135511.png 
  >
  >
  > Well, what do you suggest? This is the most accurate design.
  
  
  I think making it the same as the current `preferences-desktop-theme` is 
fine. Then `preferences-desktop-theme` can become a symlink to 
`preferences-desktop-theme-applications`.

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Noah Davis]

ndavis added a comment.


  I think `preferences-desktop-theme-applications` is fine, but 
`preferences-desktop-theme-windowdecorations` looks odd with that border. 
F6691545: Screenshot_20190314_135511.png 

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis added a comment.


  In D17469#430647 , @ngraham wrote:
  
  > Hmm, I see what you mean. Okay, let's go with this one!
  >
  > BTW, the duplicate test fails as of 
f2509047d4372f1a59d8f8b5ff009146f1a6adcb 
:
  >
  >   * Start testing of DupeTest *
  >   Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 7.3.0)
  >   PASS   : DupeTest::initTestCase()
  >   FAIL!  : DupeTest::test_duplicates() 
  > The following files are duplicates but not links:
  >   - /home/dev/kde/src/breeze-icons/icons/actions/22/go-up.svg
  >   - /home/dev/kde/src/breeze-icons/icons/actions/24/go-up.svg
  >  
  >  Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
  >   FAIL!  : DupeTest::test_duplicates() 
  > The following files are duplicates but not links:
  >   - /home/dev/kde/src/breeze-icons/icons-dark/actions/22/go-up.svg
  >   - /home/dev/kde/src/breeze-icons/icons-dark/actions/24/go-up.svg
  >  
  >  Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
  >
  >
  > Do you think you could fix that after landing this?
  
  
  Looks like I forgot to make the icon actually 24 px when I copied in the 22px 
version. I'll be sure to fix that.
  
  I should probably also update the 64px device icons for gamepads to match 
this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis added a comment.


  In D17469#430616 , @ngraham wrote:
  
  > No room? Instead of widening the grips by one pixel to make room for the 
contrast border, how about building it in, effectively narrowing the grips by 
one pixel?
  
  
  That's what I had in mind to begin with when you said to add a border. It 
just doesn't look right. There's no controller in existence that looks like 
that.
  F669: Screenshot_20190313_194137.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis updated this revision to Diff 53839.
ndavis added a comment.


  Darken the handle grips

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17469?vs=53836=53839

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

AFFECTED FILES
  icons-dark/categories/32/applications-games.svg
  icons/categories/32/applications-games.svg

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis added a comment.


  In D17469#430573 , @ngraham wrote:
  
  > Better, but the dark parts of the dark version still disappear against a 
dark background. Most of the time we solve this with a transparent outline (we 
did this for the clock icon recently), and I think that could work well here 
too.
  
  
  No, there are too many details and not enough room. It worked for the clock 
icon because a lot of clocks have a frame like that around them.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis added a comment.


  In D19736#430545 , @ngraham wrote:
  
  > Hmm, TBH it feels too busy for me, especially at the smaller sizes. I 
wonder if it might benefit from using a single circular line with an arrowhead 
instead, like this comically crude mockup illustrates: F6689810: 
Screenshot_20190313_150037.png 
  
  
  Unfortunately, there's just not enough space for that kind of icon at 16px. 
The screen in the icon has to be way too small, the arrow(s) has to be small 
enough that it turns into noise in the `off` version, the arrow has to make the 
icon weirdly uncentered or I need to forget about respecting the margins.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis retitled this revision from "applications-games icon for dark theme" to 
"Give applications-games more contrast with Breeze Dark".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

[Noah Davis]

ndavis updated this revision to Diff 53836.
ndavis added a comment.


  Change style for Breeze and Breeze Dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17469?vs=47254=53836

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

AFFECTED FILES
  icons-dark/categories/32/applications-games.svg
  icons/categories/32/applications-games.svg

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Noah Davis]

ndavis added a comment.


  We did agree to have Qt and GTK settings separate in T8871 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Noah Davis]

ndavis added a comment.


  BTW, when you change an icon into a symlink or vice versa, can you delete the 
icon you're changing in a separate commit and then add the new version of the 
icon? `arc patch` doesn't work when a file has been changed from or to a 
symlink.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Noah Davis]

ndavis added a comment.


  I don't think the light/dark window background looks good. It also gives the 
wrong message because the Colors KCM is what controls the Window background. 
The Window Decoration KCM icon has the same issue, but that already exists. 
Perhaps you should put buttons or sliders on the icon instead of using 
alternating background.s

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis updated this revision to Diff 53826.
ndavis edited the test plan for this revision.
ndavis added a comment.


  - Increase spacing between outside rotation marks and screen

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19736?vs=53825=53826

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons/actions/16/screen-rotate-auto-off.svg
  icons/actions/16/screen-rotate-auto-on.svg
  icons/actions/22/screen-rotate-auto-off.svg
  icons/actions/22/screen-rotate-auto-on.svg
  icons/actions/32/screen-rotate-auto-off.svg
  icons/actions/32/screen-rotate-auto-on.svg
  icons/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons/actions/symbolic/screen-rotate-auto-on-symbolic.svg

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Screen auto rotate icons for D19690 

REPOSITORY
  R266 Breeze Icons

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons/actions/16/screen-rotate-auto-off.svg
  icons/actions/16/screen-rotate-auto-on.svg
  icons/actions/22/screen-rotate-auto-off.svg
  icons/actions/22/screen-rotate-auto-on.svg
  icons/actions/32/screen-rotate-auto-off.svg
  icons/actions/32/screen-rotate-auto-on.svg
  icons/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons/actions/symbolic/screen-rotate-auto-on-symbolic.svg

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: guoyunhe; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

[Noah Davis]

ndavis added a comment.


  @guoyunhe Do you mind if I commandeer this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: guoyunhe, #breeze, #vdg, ndavis
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse/expand-all, window-shade/unshade

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b128afbbfe62: Add collapse/expand-all, 
window-shade/unshade (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19575?vs=53746=53751

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/16/window-shade.svg
  icons-dark/actions/16/window-unshade.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/22/window-shade.svg
  icons-dark/actions/22/window-unshade.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all-symbolic.svg
  icons-dark/actions/symbolic/expand-all-symbolic.svg
  icons-dark/actions/symbolic/window-shade-symbolic.svg
  icons-dark/actions/symbolic/window-unshade-symbolic.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/16/window-shade.svg
  icons/actions/16/window-unshade.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/22/window-shade.svg
  icons/actions/22/window-unshade.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all-symbolic.svg
  icons/actions/symbolic/expand-all-symbolic.svg
  icons/actions/symbolic/window-shade-symbolic.svg
  icons/actions/symbolic/window-unshade-symbolic.svg

To: ndavis, #vdg, ngraham, trickyricky26
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse/expand-all, window-shade/unshade

[Noah Davis]

ndavis retitled this revision from "Add collapse-all and expand-all action 
icons" to "Add collapse/expand-all, window-shade/unshade".
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: ndavis, #vdg, ngraham, trickyricky26
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis updated this revision to Diff 53746.
ndavis added a comment.


  - Add window-shade/unshade

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19575?vs=53744=53746

BRANCH
  arcpatch-D19575

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/16/window-shade.svg
  icons-dark/actions/16/window-unshade.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/22/window-shade.svg
  icons-dark/actions/22/window-unshade.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all-symbolic.svg
  icons-dark/actions/symbolic/expand-all-symbolic.svg
  icons-dark/actions/symbolic/window-shade-symbolic.svg
  icons-dark/actions/symbolic/window-unshade-symbolic.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/16/window-shade.svg
  icons/actions/16/window-unshade.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/22/window-shade.svg
  icons/actions/22/window-unshade.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all-symbolic.svg
  icons/actions/symbolic/expand-all-symbolic.svg
  icons/actions/symbolic/window-shade-symbolic.svg
  icons/actions/symbolic/window-unshade-symbolic.svg

To: ndavis, #vdg, ngraham, trickyricky26
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis updated this revision to Diff 53744.
ndavis added a comment.


  Lower down arrow on expand-all

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19575?vs=53522=53744

BRANCH
  arcpatch-D19575

REVISION DETAIL
  https://phabricator.kde.org/D19575

AFFECTED FILES
  icons-dark/actions/16/collapse-all.svg
  icons-dark/actions/16/expand-all.svg
  icons-dark/actions/22/collapse-all.svg
  icons-dark/actions/22/expand-all.svg
  icons-dark/actions/24/collapse-all.svg
  icons-dark/actions/24/expand-all.svg
  icons-dark/actions/32/collapse-all.svg
  icons-dark/actions/32/expand-all.svg
  icons-dark/actions/symbolic/collapse-all-symbolic.svg
  icons-dark/actions/symbolic/expand-all-symbolic.svg
  icons/actions/16/collapse-all.svg
  icons/actions/16/expand-all.svg
  icons/actions/22/collapse-all.svg
  icons/actions/22/expand-all.svg
  icons/actions/24/collapse-all.svg
  icons/actions/24/expand-all.svg
  icons/actions/32/collapse-all.svg
  icons/actions/32/expand-all.svg
  icons/actions/symbolic/collapse-all-symbolic.svg
  icons/actions/symbolic/expand-all-symbolic.svg

To: ndavis, #vdg, ngraham, trickyricky26
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: trickyricky26; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: ndavis, #vdg, ngraham, trickyricky26
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

[Noah Davis]

ndavis added a comment.


  @trickyricky26 do you mind if I commandeer this so I can get it finished 
today?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19575

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:3bc4079c220e: Improve consistency of window-* and add 
more (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19633?vs=53571=53607

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/16/window-unpin.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/22/window-unpin.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons-dark/actions/symbolic/window-unpin-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/16/window-restore.svg
  icons/actions/16/window-unpin.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/22/window-restore.svg
  icons/actions/22/window-unpin.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg
  icons/actions/symbolic/window-unpin-symbolic.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis added a comment.


  window-shade can be added in a later patch so that this one isn't 
unnecessarily held back

REPOSITORY
  R266 Breeze Icons

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis updated this revision to Diff 53571.
ndavis added a comment.


  - Add window-unpin-symbolic

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19633?vs=53569=53571

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/16/window-unpin.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/22/window-unpin.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons-dark/actions/symbolic/window-unpin-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/16/window-restore.svg
  icons/actions/16/window-unpin.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/22/window-restore.svg
  icons/actions/22/window-unpin.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg
  icons/actions/symbolic/window-unpin-symbolic.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19633

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

[Noah Davis]

ndavis updated this revision to Diff 53569.
ndavis added a comment.


  - Add window-unpin

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19633?vs=53516=53569

BRANCH
  window-states (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19633

AFFECTED FILES
  icons-dark/actions/16/window-keep-above.svg
  icons-dark/actions/16/window-keep-below.svg
  icons-dark/actions/16/window-maximize.svg
  icons-dark/actions/16/window-minimize.svg
  icons-dark/actions/16/window-pin.svg
  icons-dark/actions/16/window-restore.svg
  icons-dark/actions/16/window-unpin.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/22/window-keep-above.svg
  icons-dark/actions/22/window-keep-below.svg
  icons-dark/actions/22/window-maximize.svg
  icons-dark/actions/22/window-minimize.svg
  icons-dark/actions/22/window-pin.svg
  icons-dark/actions/22/window-restore.svg
  icons-dark/actions/22/window-unpin.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/actions/symbolic/window-close-symbolic.svg
  icons-dark/actions/symbolic/window-keep-above-symbolic.svg
  icons-dark/actions/symbolic/window-keep-below-symbolic.svg
  icons-dark/actions/symbolic/window-maximize-symbolic.svg
  icons-dark/actions/symbolic/window-pin-symbolic.svg
  icons-dark/actions/symbolic/window-restore-symbolic.svg
  icons/actions/16/window-keep-above.svg
  icons/actions/16/window-keep-below.svg
  icons/actions/16/window-maximize.svg
  icons/actions/16/window-minimize.svg
  icons/actions/16/window-pin.svg
  icons/actions/16/window-restore.svg
  icons/actions/16/window-unpin.svg
  icons/actions/22/window-close.svg
  icons/actions/22/window-keep-above.svg
  icons/actions/22/window-keep-below.svg
  icons/actions/22/window-maximize.svg
  icons/actions/22/window-minimize.svg
  icons/actions/22/window-pin.svg
  icons/actions/22/window-restore.svg
  icons/actions/22/window-unpin.svg
  icons/actions/32/window-close.svg
  icons/actions/symbolic/window-close-symbolic.svg
  icons/actions/symbolic/window-keep-above-symbolic.svg
  icons/actions/symbolic/window-keep-below-symbolic.svg
  icons/actions/symbolic/window-maximize-symbolic.svg
  icons/actions/symbolic/window-pin-symbolic.svg
  icons/actions/symbolic/window-restore-symbolic.svg

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:24067c74c2d6: Make go-bottom/first/last/top look more 
like media-skip* (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19638?vs=53563=53564

REVISION DETAIL
  https://phabricator.kde.org/D19638

AFFECTED FILES
  icons-dark/actions/16/go-bottom.svg
  icons-dark/actions/16/go-first.svg
  icons-dark/actions/16/go-last.svg
  icons-dark/actions/16/go-top.svg
  icons-dark/actions/22/go-bottom.svg
  icons-dark/actions/22/go-first.svg
  icons-dark/actions/22/go-last.svg
  icons-dark/actions/22/go-top.svg
  icons-dark/actions/24/go-bottom.svg
  icons-dark/actions/24/go-first.svg
  icons-dark/actions/24/go-last.svg
  icons-dark/actions/24/go-top.svg
  icons-dark/actions/32/go-bottom.svg
  icons-dark/actions/32/go-first.svg
  icons-dark/actions/32/go-last.svg
  icons-dark/actions/32/go-top.svg
  icons/actions/16/go-bottom.svg
  icons/actions/16/go-first.svg
  icons/actions/16/go-last.svg
  icons/actions/16/go-top.svg
  icons/actions/22/go-bottom.svg
  icons/actions/22/go-first.svg
  icons/actions/22/go-last.svg
  icons/actions/22/go-top.svg
  icons/actions/24/go-bottom.svg
  icons/actions/24/go-first.svg
  icons/actions/24/go-last.svg
  icons/actions/24/go-top.svg
  icons/actions/32/go-bottom.svg
  icons/actions/32/go-first.svg
  icons/actions/32/go-last.svg
  icons/actions/32/go-top.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns