Re: Review Request 129379: [baloo] Remove unused functions

[Christian Ehrlicher]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129379/
---

(Updated Nov. 15, 2016, 7:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Baloo and David Faure.


Changes
---

Submitted with commit e40689fb56fbcd12ca4eeaef1b44e93f5afc6d7d by Christian 
Ehrlicher to branch master.


Repository: baloo


Description
---

As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. 
With this patch I removed all the unused stuff and moved out a temporary buffer 
to avoid reallocating this buffer on every call to putDifferentialVarInt32()


Diffs
-

  src/codecs/coding.h 3d55a40 
  src/codecs/coding.cpp 73e2fa2 
  src/codecs/positioncodec.cpp 22f4895 

Diff: https://git.reviewboard.kde.org/r/129379/diff/


Testing
---

Unittests still working as expected


Thanks,

Christian Ehrlicher

Re: Review Request 129379: [baloo] Remove unused functions

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129379/#review100820
---


Fix it, then Ship it!





src/codecs/coding.cpp (line 95)


Can you document the method? Somewhat unusual API, given that it writes to 
both baTmp and dst :)



src/codecs/positioncodec.cpp (line 35)


typo: missing r before y


- David Faure


On Nov. 11, 2016, 5:09 p.m., Christian Ehrlicher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129379/
> ---
> 
> (Updated Nov. 11, 2016, 5:09 p.m.)
> 
> 
> Review request for Baloo and David Faure.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. 
> With this patch I removed all the unused stuff and moved out a temporary 
> buffer to avoid reallocating this buffer on every call to 
> putDifferentialVarInt32()
> 
> 
> Diffs
> -
> 
>   src/codecs/coding.h 3d55a40 
>   src/codecs/coding.cpp 73e2fa2 
>   src/codecs/positioncodec.cpp 22f4895 
> 
> Diff: https://git.reviewboard.kde.org/r/129379/diff/
> 
> 
> Testing
> ---
> 
> Unittests still working as expected
> 
> 
> Thanks,
> 
> Christian Ehrlicher
> 
>

Review Request 129379: [baloo] Remove unused functions

[Christian Ehrlicher]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129379/
---

Review request for Baloo and David Faure.


Repository: baloo


Description
---

As discussed in REVIEW 129186 there is a lot of bit rotting in coding.cpp/.h. 
With this patch I removed all the unused stuff and moved out a temporary buffer 
to avoid reallocating this buffer on every call to putDifferentialVarInt32()


Diffs
-

  src/codecs/coding.h 3d55a40 
  src/codecs/coding.cpp 73e2fa2 
  src/codecs/positioncodec.cpp 22f4895 

Diff: https://git.reviewboard.kde.org/r/129379/diff/


Testing
---

Unittests still working as expected


Thanks,

Christian Ehrlicher