Re: Reviewer for Konqueror needed
On Tue, Nov 1, 2022 at 7:26 AM Reindl Harald wrote: > Am 01.11.22 um 09:31 schrieb Stefano Crocco: > > Are you sure? On my system it works as expected. Maybe you don't have the > > corresponding option enabled > then some random update disabled it - i use konqueror since 2006 as my > primary file manager > > but better not remember the unholy migration from KF4 to KF5 when old > configs where completly ignored - for the sake of god read the old > configs and write your new ones whereever you want, i don't care as user > > with every Fedora dist-upgrade a few other apps where ported to KF5 > > i had this mess with KDE3->KDE4, KDE4->KDE5 was exactly identical > terrible - if the same happens with KDE6 i switch to openbox > > > since this feature is off by default. It's in the > > General page of the settings dialog. > > well, i didn't expect that such expected basic behavior isn't enabled by > default Please don't steer the conversation off topic.
Re: Reviewer for Konqueror needed
Am 01.11.22 um 09:31 schrieb Stefano Crocco: On lunedì 31 ottobre 2022 23:52:20 CET Reindl Harald wrote: Am 31.10.22 um 20:51 schrieb Stefano Crocco: Hello to everyone, I'm the current Konqueror maintainer can you *please* restore close tabs by middle-click like in any other browser? that got lost a few years ago with one of the KF5 updates and is really annoying Are you sure? On my system it works as expected. Maybe you don't have the corresponding option enabled then some random update disabled it - i use konqueror since 2006 as my primary file manager but better not remember the unholy migration from KF4 to KF5 when old configs where completly ignored - for the sake of god read the old configs and write your new ones whereever you want, i don't care as user with every Fedora dist-upgrade a few other apps where ported to KF5 i had this mess with KDE3->KDE4, KDE4->KDE5 was exactly identical terrible - if the same happens with KDE6 i switch to openbox since this feature is off by default. It's in the General page of the settings dialog. well, i didn't expect that such expected basic behavior isn't enabled by default
Re: Reviewer for Konqueror needed
On martedì 1 novembre 2022 01:28:48 CET Albert Astals Cid wrote: > > Does anyone know what should I do in case nobody is willing to review my > > merge requests? Can I go on and merge them without reviews? > > If you have a very high confidence a patch is correct, it's OK to merge it > without reviews after a reasonable waiting period (i'd say not less than a > week in general, but that's just me throwing some random amount of the top > of my tongue). Moreover if you're the maintainer of the app. > > Of course it's better if you can find reviewers because more brains looking > at code is always better, but there's only so much reviewers you can find > sometimes. > > Cheers, > Albert Thanks for the advice Stefano
Re: Reviewer for Konqueror needed
On lunedì 31 ottobre 2022 22:26:16 CET m...@ow.nekobit.net wrote: > I sent some simple reviews, I hope that helps some. Thanks
Re: Reviewer for Konqueror needed
On lunedì 31 ottobre 2022 23:52:20 CET Reindl Harald wrote: > Am 31.10.22 um 20:51 schrieb Stefano Crocco: > > Hello to everyone, > > I'm the current Konqueror maintainer > > can you *please* restore close tabs by middle-click like in any other > browser? that got lost a few years ago with one of the KF5 updates and > is really annoying Are you sure? On my system it works as expected. Maybe you don't have the corresponding option enabled, since this feature is off by default. It's in the General page of the settings dialog. Stefano
Re: Reviewer for Konqueror needed
El dilluns, 31 d’octubre de 2022, a les 20:51:13 (CET), Stefano Crocco va escriure: > Hello to everyone, > I'm the current Konqueror maintainer. Today I've been informed that the > person who has reviewed my merge requests since I started working on > Konqueror some years ago won't be able to do that anymore. > > Since I'm the only developer working on Konqueror, currently there's nobody > which can review my merge requests. Is there anyone willing to help the > Konqueror development by doing so? Currently there are about ten merge > requests which I've created since this summer and some of them (numbers 143, > 141, 136, 135, 133, 125, 122) contain bug fixes which I'd really prefer > went in the 22.12 release. > > Does anyone know what should I do in case nobody is willing to review my > merge requests? Can I go on and merge them without reviews? If you have a very high confidence a patch is correct, it's OK to merge it without reviews after a reasonable waiting period (i'd say not less than a week in general, but that's just me throwing some random amount of the top of my tongue). Moreover if you're the maintainer of the app. Of course it's better if you can find reviewers because more brains looking at code is always better, but there's only so much reviewers you can find sometimes. Cheers, Albert > Is there a > standard procedure for situations like this? > > Thanks in advance > > Stefano
Re: Reviewer for Konqueror needed
Am 31.10.22 um 20:51 schrieb Stefano Crocco: Hello to everyone, I'm the current Konqueror maintainer can you *please* restore close tabs by middle-click like in any other browser? that got lost a few years ago with one of the KF5 updates and is really annoying
Re: Reviewer for Konqueror needed
I sent some simple reviews, I hope that helps some.
Reviewer for Konqueror needed
Hello to everyone, I'm the current Konqueror maintainer. Today I've been informed that the person who has reviewed my merge requests since I started working on Konqueror some years ago won't be able to do that anymore. Since I'm the only developer working on Konqueror, currently there's nobody which can review my merge requests. Is there anyone willing to help the Konqueror development by doing so? Currently there are about ten merge requests which I've created since this summer and some of them (numbers 143, 141, 136, 135, 133, 125, 122) contain bug fixes which I'd really prefer went in the 22.12 release. Does anyone know what should I do in case nobody is willing to review my merge requests? Can I go on and merge them without reviews? Is there a standard procedure for situations like this? Thanks in advance Stefano
