Re: Several new utilities for KDE: KLook and StackFolder
On Thursday 03 May 2012 13:46:27 Denis Koryavov wrote: -- FEATURES -- For now KLook supports: - audio and video files (all that supported by Phonon); - graphic files (png, jpg); - text files; - for files with different mime-types (and folders) user can see its preferences; Does this use KParts in order to embed the viewer for any type of file, or does it contain builtin widgets for each type of file? I suppose the latter, but using KParts as fallback for other types of files, such as PDF, PS, and many others. It takes about 5 lines of code, using KMimeTypeTrader::createPartInstanceFromQuery(). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
Hi. Unfortunately when we tried to use KParts interfaces we got had too many unnecessary graphical elements, and we try to keep KLook minimalistic for better user experience. After contacting maintainer of Okular though it seems there is some mode for preview. I will look into it soon and see if it can be used for our needs. On Fri, May 11, 2012 at 12:50 PM, David Faure fa...@kde.org wrote: On Thursday 03 May 2012 13:46:27 Denis Koryavov wrote: -- FEATURES -- For now KLook supports: - audio and video files (all that supported by Phonon); - graphic files (png, jpg); - text files; - for files with different mime-types (and folders) user can see its preferences; Does this use KParts in order to embed the viewer for any type of file, or does it contain builtin widgets for each type of file? I suppose the latter, but using KParts as fallback for other types of files, such as PDF, PS, and many others. It takes about 5 lines of code, using KMimeTypeTrader::createPartInstanceFromQuery(). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
Good to see these merged into playground! Some things we would need to proposing for KDE extragear/core - Watch your coding style http://techbase.kde.org/Policies/Kdelibs_Coding_Style In particular: Always use braces Don't call classes MySomething. As the My isn't very helpful Make sure the files actually match the names of the class. audio.h, video.h, text.h MyAudio::~MyAudio() use m_mediaObject-deleteLater(); instead of delete (it's safer). Alternatively set a parent on it in the constructor and don't manually delete it. Technically your whitespace is off in many ways too, but that's being pedantic. - Long term rendering of audio/text/video/images etc in QML needs to be moved out of there and into somewhere more generic (some sort of generic QML component that can display any mimetype using the appropriate backends) - This has a lot of duplication with the previewer applet (which is why we need the above to fix it). This still needs a QML port (AFAIK), so it would be a good time to work together as it's basically the same thing. (Frankly yours is a lot better right now) - The way you're embedding video in QML isn't always going to work. (it won't work with xine using xv anyway, but I think that's being deprecated)..you don't have a lot of choice right now, but make sure you talk to someone from KDE Multimedia about what's moving forward with Phonon-QML. - Most importantly you've hardcoded it to match the theme you're using in your distro. However on any other setup (like stock KDE) your buttons look completely different from anything in my normal KDE applications, and completely different from anything in Plasma. Same for the window frame, and the icons etc. It looks absolutely great in your screenshots where it matches the theme you're using, but on any other setup it looks awful/out of place. Inside KDE we need to keep consistency. Not trying to be negative, it's a great start! David Edmundson Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
Hi, On Mon, May 7, 2012 at 7:15 PM, David Edmundson da...@davidedmundson.co.ukwrote: Good to see these merged into playground! Some things we would need to proposing for KDE extragear/core - Watch your coding style http://techbase.kde.org/Policies/Kdelibs_Coding_Style In particular: Always use braces Don't call classes MySomething. As the My isn't very helpful Make sure the files actually match the names of the class. audio.h, video.h, text.h MyAudio::~MyAudio() use m_mediaObject-deleteLater(); instead of delete (it's safer). Alternatively set a parent on it in the constructor and don't manually delete it. Technically your whitespace is off in many ways too, but that's being pedantic. Unlike what many people think the mentioned web-page is the coding-style for kdelibs only. Other kde projects/modules may choose to adopt that style or parts of the style, but its not mandatory for any module to follow it. You're always free to choose whatever style suits you. Andreass Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
On Thu, May 3, 2012 at 11:40 PM, Peter Penz peter.pen...@gmail.com wrote: On 05/03/2012 07:55 PM, Denis Koryavov wrote: От: todd rme toddrme2...@gmail.com [...] I see only the following ways: - The user presses Ctrl + left click on file followed by clicking the KLook-toolbar-button. Makes 2 clicks in sum. - The users activates the rubberband to select a file followed by clicking the KLook-toolbar-button. Again 2 clicks in sum. - The user takes the keyboard to select a file followed by clicking the KLook-toolbar-button (or pressing Space as shortcut). Again at least 2 key-presses or 1 key-press + 1 mouse-click. Hello. Thanks for feedback, we will implement your second suggestion. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
Am 04.05.2012 um 08:56 schrieb Sergey Borovkov serge.borov...@gmail.com: On Thu, May 3, 2012 at 11:40 PM, Peter Penz peter.pen...@gmail.com wrote: On 05/03/2012 07:55 PM, Denis Koryavov wrote: От: todd rme toddrme2...@gmail.com [...] I see only the following ways: - The user presses Ctrl + left click on file followed by clicking the KLook-toolbar-button. Makes 2 clicks in sum. - The users activates the rubberband to select a file followed by clicking the KLook-toolbar-button. Again 2 clicks in sum. - The user takes the keyboard to select a file followed by clicking the KLook-toolbar-button (or pressing Space as shortcut). Again at least 2 key-presses or 1 key-press + 1 mouse-click. Hello. Thanks for feedback, we will implement your second suggestion. I think you missunderstood my mail: All those 3 ways are more inefficient in comparison to just starting an application with one click or just using the information panel. I won't merge one of those suggestions into Dolphin if they are the only way to launch KLook. We need a way to start KLook with _one_ click or keypress. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
04.05.2012 14:21, Peter Penz пишет: Hello. Thanks for feedback, we will implement your second suggestion. I think you missunderstood my mail: All those 3 ways are more inefficient in comparison to just starting an application with one click or just using the information panel. I won't merge one of those suggestions into Dolphin if they are the only way to launch KLook. We need a way to start KLook with _one_ click or keypress. Hello Peter! Yes, you are right. We forgot about 'single click'. OK, I suggest to implement 2 things: - Button on toolbar (maybe it should not be activated by default); - This suggestion (or something like this): http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner I think then, any user will can use KLook as he wants. :) -- WBR, Denis Koryavov. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
Am Donnerstag 03 Mai 2012, 11.46:27 schrieb Denis Koryavov: Hello developers! Good morning Denies Let me first thank you for brining your stuff upstream and your interest to work together! I took a look at the videos below and there is some ideas and questions from my side. Let me introduce itself. I'm Denis Koryavov - the head of UI development department in ROSA, Russia. We work on our distro based on KDE and created several utilities for KDE which we want to submit for your consideration. We'll be happy if you will found them useable. StackFolder StackFolder is an utility that looks like some several utilities from KDE. Originally it is a fork of plasma-applet-folderview that redesigned to look like MacOS X Stask utility (for the time being it rewritten on QML with the parts of old code). Here is the video where you can see the features of StackFolders (this is a old video, but topical): http://www.youtube.com/watch?v=DnH13y_FlHU Looks really nice. You speak about the fork of plasma-applet-folderview. Were you in contact with the Plasma people (plasma-de...@kde.org)? -- SOURCES -- You can download source code from here: https://abf.rosalinux.ru/projects/64692 Or you can use git for fetching the sources: git clone https://abf.rosalinux.ru/uxteam/StackFolder.git KLook KLook is an other utility for KDE, it written in QML. With the help of this utility, user can quickly look at files with different mime-types. In fact, it is practically exact copy of MacOS X QuickLook utility). User can use it directly from the Dolphin file manager by pressing a 'Space' key on keyboard. -- FEATURES -- For now KLook supports: - audio and video files (all that supported by Phonon); - graphic files (png, jpg); - text files; - for files with different mime-types (and folders) user can see its preferences; I like it. First thought was: what about pdf support but then I saw something about this in the video. What's the status about pdfs? We created a video with the demonstration of functions of KLook. You can see it here: http://www.youtube.com/watch?feature=player_embeddedv=iADISfFTyjY This video is also old, but topical. On it you can see 70% functions of the KLook (after we created this video we added integration with the StackFolder, possibility to listen audio files and possibility to see any file, as minimum - its properties). -- SOURCES -- You can download source code from here: https://abf.rosalinux.ru/projects/64689 A patch for KDE 4.8 that allows to use KLook directly from the Dolphin file manager is here: https://abf.rosalinux.ru/projects/64429/blob/master/kdebase-4.8.1-dolphin- klook.patch If it's about Dolphin were you in contact with Peter Penz, the Dolphin maintainer? GIT: git clone https://abf.rosalinux.ru/uxteam/KLook.git Both of these utilities are included in our distro and were well tested by many users. It is time to present them for you. We have resources to work on them and later, and if you will decide that that they are worthy of KDE, we would be happy to work on them in KDE project. Thanks! I think (please others correct me if I'm wrong) a first step would be to get a KDE account and import your software to the KDE git playground area. Thanks for your work on and with KDE software Mario Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
Hi Denis, Am Donnerstag, 3. Mai 2012, 13:46:27 schrieb Denis Koryavov: Hello developers! Let me introduce itself. I'm Denis Koryavov - the head of UI development department in ROSA, Russia. We work on our distro based on KDE and created several utilities for KDE which we want to submit for your consideration. We'll be happy if you will found them useable. [snip content=StackFolder KLook/] Both of these utilities are included in our distro and were well tested by many users. It is time to present them for you. We have resources to work on them and later, and if you will decide that that they are worthy of KDE, we would be happy to work on them in KDE project. Did not yet look at the videos, but what you describe sounds interesting and might indeed make a large group of users happy if that would be integrated and available by default. In case you are interested to have this integrated already in KDE Workspaces 4.9 or KDE Apps 4.9 (whereever it matches better, perhaps also could become part of extragear section) make sure to add it to http://techbase.kde.org/Schedules/KDE4/4.9_Feature_Plan today. As today, May 3rd, is the day of the soft feature freeze, that is, only features listed in the feature plan for 4.9 are allowed after this day to be added to what will become 4.9. See http://techbase.kde.org/Schedules/KDE4/4.9_Release_Schedule As for Dolphin ( Konqueror) integration of KLook make sure to ping the maintainers of both programs directly (Peter Penz David Faure, see the About dialogs), to make sure they get notified. Or ideally write to the mailinglist kfm-devel, see https://mail.kde.org/mailman/listinfo/kfm-devel , they surely read the mailing list. For StackFolder integration please best contact directly the mailinglist Plasma-devel, see https://mail.kde.org/mailman/listinfo/plasma-devel Cheers Friedrich Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
Hello! 03.05.2012, в 14:23, Mario Fux написал(а): Looks really nice. You speak about the fork of plasma-applet-folderview. Were you in contact with the Plasma people (plasma-de...@kde.org)? Our team new in KDE, thus we did not write any emails to kde mailing lists until now. I like it. First thought was: what about pdf support but then I saw something about this in the video. What's the status about pdfs? It is the last feature that we still do not implemented. :) To be honest, we just didn't have time to implement it, but we want to do it some later. If it's about Dolphin were you in contact with Peter Penz, the Dolphin maintainer? No. As I said, I'm new in KDE, thus I do not understand fully what I should do in my situation. So, I wrote my mail to this ML and want ask to your advice what I should do later. It will be normal, if I will write an email to the several ML, or I should write different emails to different mailing lists? GIT: git clone https://abf.rosalinux.ru/uxteam/KLook.git Both of these utilities are included in our distro and were well tested by many users. It is time to present them for you. We have resources to work on them and later, and if you will decide that that they are worthy of KDE, we would be happy to work on them in KDE project. Thanks! I think (please others correct me if I'm wrong) a first step would be to get a KDE account and import your software to the KDE git playground area. OK. We'll do it. -- WBR, Denis Koryavov. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
03.05.2012, в 14:28, Friedrich W. H. Kossebau написал(а): Did not yet look at the videos, but what you describe sounds interesting and might indeed make a large group of users happy if that would be integrated and available by default. In case you are interested to have this integrated already in KDE Workspaces 4.9 or KDE Apps 4.9 (whereever it matches better, perhaps also could become part of extragear section) make sure to add it to http://techbase.kde.org/Schedules/KDE4/4.9_Feature_Plan today. As today, May 3rd, is the day of the soft feature freeze, that is, only features listed in the feature plan for 4.9 are allowed after this day to be added to what will become 4.9. See http://techbase.kde.org/Schedules/KDE4/4.9_Release_Schedule Hello! Thanks for the explanations! We added our features to the list here: http://techbase.kde.org/Schedules/KDE4/4.9_Feature_Plan#kde-baseapps and here: http://techbase.kde.org/Schedules/KDE4/4.9_Feature_Plan#kdeplasma-addons As far as I understood, we should to upload our code to the KDE playground? Where we can find information about how to do this? As for Dolphin ( Konqueror) integration of KLook make sure to ping the maintainers of both programs directly (Peter Penz David Faure, see the About dialogs), to make sure they get notified. Or ideally write to the mailinglist kfm-devel, see https://mail.kde.org/mailman/listinfo/kfm-devel , they surely read the mailing list. For StackFolder integration please best contact directly the mailinglist Plasma-devel, see https://mail.kde.org/mailman/listinfo/plasma-devel OK! We'll do this as soon as we'll upload our code to the KDE playground. Thanks. -- WBR, Denis Koryavov. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
On Thu, May 3, 2012 at 11:46 AM, Denis Koryavov denis.korya...@rosalab.ru wrote: KLook KLook is an other utility for KDE, it written in QML. With the help of this utility, user can quickly look at files with different mime-types. In fact, it is practically exact copy of MacOS X QuickLook utility). User can use it directly from the Dolphin file manager by pressing a 'Space' key on keyboard. In dolphin, you know the + button in the corner that you click to select the file? It would be nice if there was a button in another corner to trigger KLook. It would be much more convenient for people navigating with a mouse to not have to switch over to the keyboard. See here: http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner -Todd Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
- Исходное сообщение - От: todd rme toddrme2...@gmail.com Кому: kde-devel@kde.org Отправленные: Четверг, 3 Май 2012 г 18:46:26 Тема: Re: Several new utilities for KDE: KLook and StackFolder In dolphin, you know the + button in the corner that you click to select the file? It would be nice if there was a button in another corner to trigger KLook. It would be much more convenient for people navigating with a mouse to not have to switch over to the keyboard. See here: http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner Hello! We thought about this function and arrived at a conclusion, that it will be not very useful. Some time ago, we asked our users about selection marker in folders and found, that many users do not understand what is this function intended for. And only very few percent of users use this function (for example, we disabled this function in Mandriva/ROSA by default and did not receive any negative feedback about this). Also, KLook can be used to see multiple files, so it will be not very good usability thing: use action for one object to see several object. I think it will be better to put a button for the KLook to the toolbar, so the users, who want to use mouse to use KLook will can do this. -- WBR, Denis Koryavov. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Several new utilities for KDE: KLook and StackFolder
On 05/03/2012 07:55 PM, Denis Koryavov wrote: От: todd rme toddrme2...@gmail.com [...] http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner Hello! We thought about this function and arrived at a conclusion, that it will be not very useful. Some time ago, we asked our users about selection marker in folders and found, that many users do not understand what is this function intended for. And only very few percent of users use this function (for example, we disabled this function in Mandriva/ROSA by default and did not receive any negative feedback about this). Also, KLook can be used to see multiple files, so it will be not very good usability thing: use action for one object to see several object. I think it will be better to put a button for the KLook to the toolbar, so the users, who want to use mouse to use KLook will can do this. Hm... In opposite to OS X' Finder per default Dolphin and Konqueror use single-click to enter a folder and to open a file. Assuming there is no hover-indicator like suggested at http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner but a button for KLook in the toolbar as you suggest: How will users be able to select one file/folder to launch KLook with the toolbar button? I see only the following ways: - The user presses Ctrl + left click on file followed by clicking the KLook-toolbar-button. Makes 2 clicks in sum. - The users activates the rubberband to select a file followed by clicking the KLook-toolbar-button. Again 2 clicks in sum. - The user takes the keyboard to select a file followed by clicking the KLook-toolbar-button (or pressing Space as shortcut). Again at least 2 key-presses or 1 key-press + 1 mouse-click. Now in comparison to the suggestion given at http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner there it is only needed to hover the file and press the preview-button... Considering that KLook is inspired by Quick Look from Apple I think it is mandatory that starting KLook must be more efficient (quick) than starting e.g. Gwenview, Okular or Dragon Player ;-) Of course the suggestion at http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner might not be the final solution and I'm aware that the selection-toggle might not be suitable for all users. But as long as we keep single-click per default for Dolphin and Konqueror we must come up with a way to start KLook with one action and not more - otherwise simply opening the application or using the Information Panel would be more efficient. And only very few percent of users use this function (for example, we disabled this function in Mandriva/ROSA by default and did not receive any negative feedback about this). Users of course cannot complain about a missing functionality they are not aware of because it has been disabled. Instead they complain on bugs.kde.org that selecting in Dolphin/Konqueror is tricky and that it should use double-click per default ;-) We had this single-click/double-click discussion already 12 years ago and the outcome was that there simply is no default setting that satisfies all users out there. From the feedback at bugs.kde.org it seems that most users stay with the single-click setting and are fine with this, but the situation might probably be the same if we'd have chosen double-click per default. I don't know. In any case: The hover-buttons seem to work well in Gwenview, the folder-plasmoid and (at least from the feedback I got) also in Dolphin. So the idea at http://forum.kde.org/viewtopic.php?f=83t=38913hilit=dolphin+corner is worth to consider from my point of view. Best regards, Peter -- WBR, Denis Koryavov. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
