[kde-doc-english] [trojita] src/Gui: GUI: prevent findbar from taking significant amount of space

[Caspar Schutijser]

Git commit 795fa33376babcca963573063833004a4ac74a1c by Caspar Schutijser.
Committed on 26/05/2016 at 18:21.
Pushed by gerrit into branch 'master'.

GUI: prevent findbar from taking significant amount of space

in the MessageHeadersWidget and MessageSourceWidget.

Change-Id: I68731f5639c7866c4fe393b4e9e5bee28122f020

M  +1-1src/Gui/MessageHeadersWidget.cpp
M  +1-1src/Gui/MessageSourceWidget.cpp

http://commits.kde.org/trojita/795fa33376babcca963573063833004a4ac74a1c

diff --git a/src/Gui/MessageHeadersWidget.cpp b/src/Gui/MessageHeadersWidget.cpp
index 1306921..ddb0e41 100644
--- a/src/Gui/MessageHeadersWidget.cpp
+++ b/src/Gui/MessageHeadersWidget.cpp
@@ -61,7 +61,7 @@ MessageHeadersWidget::MessageHeadersWidget(QWidget *parent, 
const QModelIndex &m
 
 auto layout = new QVBoxLayout(this);
 layout->setContentsMargins(0, 0, 0, 0);
-layout->addWidget(m_widget);
+layout->addWidget(m_widget, 1);
 layout->addWidget(m_findBar);
 setLayout(layout);
 }
diff --git a/src/Gui/MessageSourceWidget.cpp b/src/Gui/MessageSourceWidget.cpp
index e563508..23295e8 100644
--- a/src/Gui/MessageSourceWidget.cpp
+++ b/src/Gui/MessageSourceWidget.cpp
@@ -64,7 +64,7 @@ MessageSourceWidget::MessageSourceWidget(QWidget *parent, 
const QModelIndex &mes
 
 auto layout = new QVBoxLayout(this);
 layout->setContentsMargins(0, 0, 0, 0);
-layout->addWidget(m_widget);
+layout->addWidget(m_widget, 1);
 layout->addWidget(m_findBar);
 setLayout(layout);
 }
___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127867: Update KmPlot handbook to 16.04

[Burkhard Lück]

> On Mai 26, 2016, 10:02 nachm., Jeremy Whiting wrote:
> > Ship It!

Thanks for review.
Can you reproduce the scripting issue via dbus?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127867/#review95896
---


On Mai 8, 2016, 7:51 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127867/
> ---
> 
> (Updated Mai 8, 2016, 7:51 vorm.)
> 
> 
> Review request for Documentation and KDE Edu.
> 
> 
> Repository: kmplot
> 
> 
> Description
> ---
> 
> merge into one docbook
> remove entity package kdeedu
> bump date + releaseinfo
> remove chapter developers + appendix
> rename chapter dcop to dbus
> new screenshots already commited
> 
> scripting via dbus does not work for me in 15.12 + master, what is wrong?
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 001e6f1 
>   doc/man-kmplot.1.docbook da16eeb 
> 
> Diff: https://git.reviewboard.kde.org/r/127867/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127867: Update KmPlot handbook to 16.04

[Jeremy Whiting]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127867/#review95896
---


Ship it!




Ship It!

- Jeremy Whiting


On May 8, 2016, 1:51 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127867/
> ---
> 
> (Updated May 8, 2016, 1:51 a.m.)
> 
> 
> Review request for Documentation and KDE Edu.
> 
> 
> Repository: kmplot
> 
> 
> Description
> ---
> 
> merge into one docbook
> remove entity package kdeedu
> bump date + releaseinfo
> remove chapter developers + appendix
> rename chapter dcop to dbus
> new screenshots already commited
> 
> scripting via dbus does not work for me in 15.12 + master, what is wrong?
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 001e6f1 
>   doc/man-kmplot.1.docbook da16eeb 
> 
> Diff: https://git.reviewboard.kde.org/r/127867/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127906: Remove qt5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/#review95890
---



If we want to provide a qt5options manpage we need at least these options:

http://doc.qt.io/qt-5/qapplication.html#QApplication

-style= style, sets the application GUI style. Possible values depend on the 
system configuration. 
If Qt is compiled with additional styles or has additional styles as plugins 
these will be available to the -style command line option.

-style style, is the same as listed above.

-stylesheet= stylesheet, sets the application styleSheet. The value must be a 
path to a file that contains the Style Sheet.

-stylesheet stylesheet, is the same as listed above.

-widgetcount, prints debug message at the end about number of widgets left 
undestroyed and maximum number of widgets existed at the same time

-reverse, sets the application's layout direction to Qt::RightToLeft

-qmljsdebugger=, activates the QML/JS debugger with a specified port. The value 
must be of format port:1234[,block], where block is optional and will make the 
application wait until a debugger connects to it.



http://doc.qt.io/qt-5/qguiapplication.html#QGuiApplication

-platform platformName[:options], specifies the Qt Platform Abstraction (QPA) 
plugin.

-platformpluginpath path, specifies the path to platform plugins.

-platformtheme platformTheme, specifies the platform theme.

-plugin plugin, specifies additional plugins to load. The argument may appear 
multiple times.

-qmljsdebugger=, activates the QML/JS debugger with a specified port. The value 
must be of format port:1234[,block], where block is optional and will make the 
application wait until a debugger connects to it.

-qwindowgeometry geometry, specifies window geometry for the main window using 
the X11-syntax. For example: -qwindowgeometry 100x100+50+50

-qwindowicon, sets the default window icon

-qwindowtitle, sets the title of the first window

-reverse, sets the application's layout direction to Qt::RightToLeft. This 
option is intended to aid debugging and should not be used in production. The 
default value is automatically detected from the user's 
locale (see also QLocale::textDirection()).

-session session, restores the application from an earlier session.


The following standard command line options are available for X11:

-display hostname:screen_number, switches displays on X11.
Overrides the DISPLAY environment variable.

-geometry geometry, same as -qwindowgeometry.


Platform-Specific Arguments

The following parameters are available for -platform windows:

dialogs=[xp|none], xp uses XP-style native dialogs and none disables them.
fontengine=freetype, uses the FreeType font engine.


http://doc.qt.io/qt-5/qcommandlineparser.html

the help option (-h, --help and -? on Windows) This option is handled 
automatically by QCommandLineParser.

Remember to use setApplicationDescription to set the application description, 
which will be displayed when this option is used.

the -v / --version option, which displays the version string of the application.

- Burkhard Lück


On Mai 13, 2016, 2:12 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127906/
> ---
> 
> (Updated Mai 13, 2016, 2:12 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> All options in this docbook like
> 
> display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
> title, visual, inputstyle, im, noxim, reverse, stylesheet
> 
> are valid for Qt 3.3 QApplication, see
> 
> http://doc.qt.io/archives/3.3/qapplication.html#QApplication
> 
> 
> In Qt 5.6 a QApplication automatically supports a few command line options 
> like 
> style, stylesheet, widgetcount, reverse, qmljsdebugger
> see http://doc.qt.io/qt-5/qapplication.html
> 
> 
> Do we really want to provide a manpage docbook for that?
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt 4efee3b 
>   docs/qt5options/CMakeLists.txt 7e31e0f 
>   docs/qt5options/man-qt5options.7.docbook d5891eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127683: Update KSystemlog docbook to 16.04

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127683/#review95888
---



any objections to commit this?

- Burkhard Lück


On April 18, 2016, 7:30 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127683/
> ---
> 
> (Updated April 18, 2016, 7:30 nachm.)
> 
> 
> Review request for Documentation and Vyacheslav Matyushin.
> 
> 
> Repository: ksystemlog
> 
> 
> Description
> ---
> 
> proofread, bump date+releaseinfo
> remove antity package, not used any more
> remove appendix
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 388c048 
> 
> Diff: https://git.reviewboard.kde.org/r/127683/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127903: Update kf5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/#review95887
---



Please review

- Burkhard Lück


On Mai 26, 2016, 3:01 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127903/
> ---
> 
> (Updated Mai 26, 2016, 3:01 nachm.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> replace the obsolete content with updates
> Use case for option desktopfile borrowed von Martin Gräßlins commit log
> 
> See Also: qt5options - does that really make sense for a kf5 app?
> I really doubt that the qt5options manpage is uptodate
> 
> 
> Diffs
> -
> 
>   docs/kf5options/man-kf5options.7.docbook f79d42c 
> 
> Diff: https://git.reviewboard.kde.org/r/127903/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127730: Add commonly used entities for keys to en/user.entities

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127730/#review95886
---



any objections to commit?

- Burkhard Lück


On Mai 6, 2016, 7:11 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127730/
> ---
> 
> (Updated Mai 6, 2016, 7:11 vorm.)
> 
> 
> Review request for Documentation and Localization and Translation (l10n).
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Del 25 x in l10n-kf5/documentation
> Ins 13 x in l10n-kf5/documentation
> 
> 
> Diffs
> -
> 
>   src/customization/en/user.entities de68e30 
> 
> Diff: https://git.reviewboard.kde.org/r/127730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127901: Update Parley handbook to 16.04

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127901/#review95885
---



Please review

- Burkhard Lück


On Mai 18, 2016, 5:11 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127901/
> ---
> 
> (Updated Mai 18, 2016, 5:11 vorm.)
> 
> 
> Review request for Documentation, KDE Edu and Julian Helfferich.
> 
> 
> Repository: parley
> 
> 
> Description
> ---
> 
> proofreading
> new screenshots, not uploaded
> Please review the FIXME's with questions
> 
> Who should be added for review?
> 
> 
> Diffs
> -
> 
>   docs/parley/index.docbook 420d137 
> 
> Diff: https://git.reviewboard.kde.org/r/127901/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127890: Update general.entities

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127890/#review95884
---



Please review

- Burkhard Lück


On Mai 10, 2016, 8:22 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127890/
> ---
> 
> (Updated Mai 10, 2016, 8:22 nachm.)
> 
> 
> Review request for Documentation.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> move kde-ftp + kword to section deprecated
> correct sort order for kollision, kolorlines, konversation + kopete
> add knavalbattle, kwalletmanager5, lokalize, sweeper
> 
> knavalbattle + kwalletmanager5 have a space in the entity definition,
> probably they have to be translatable?
> 
> 
> Diffs
> -
> 
>   src/customization/entities/general.entities 38d3f70 
> 
> Diff: https://git.reviewboard.kde.org/r/127890/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127867: Update KmPlot handbook to 16.04

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127867/#review95883
---



Please review

- Burkhard Lück


On Mai 8, 2016, 7:51 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127867/
> ---
> 
> (Updated Mai 8, 2016, 7:51 vorm.)
> 
> 
> Review request for Documentation and KDE Edu.
> 
> 
> Repository: kmplot
> 
> 
> Description
> ---
> 
> merge into one docbook
> remove entity package kdeedu
> bump date + releaseinfo
> remove chapter developers + appendix
> rename chapter dcop to dbus
> new screenshots already commited
> 
> scripting via dbus does not work for me in 15.12 + master, what is wrong?
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 001e6f1 
>   doc/man-kmplot.1.docbook da16eeb 
> 
> Diff: https://git.reviewboard.kde.org/r/127867/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127991: kdesvn handbook update

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127991/#review95882
---



please review

- Burkhard Lück


On Mai 23, 2016, 12:15 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127991/
> ---
> 
> (Updated Mai 23, 2016, 12:15 nachm.)
> 
> 
> Review request for Documentation and Christian Ehrlicher.
> 
> 
> Repository: kdesvn
> 
> 
> Description
> ---
> 
> proofread + update
> remove comments
> bump date+releaseinfo
> from kde, not for kde
> add some missing items
> remove appendix
> 
> 
> What is "Logs follow node changes"?
> 
> Do we really need the FAQ, seems outdated to me?
> 
> 
> Diffs
> -
> 
>   doc/index.docbook 3594b5c 
> 
> Diff: https://git.reviewboard.kde.org/r/127991/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kate] doc/katepart: by kde, not for kde + fix wrong shortcut

[Burkhard Lück]

Git commit 22489824f88cab7edb5a93ba08321ca191b08890 by Burkhard Lück.
Committed on 26/05/2016 at 20:21.
Pushed by lueck into branch 'master'.

by kde, not for kde + fix wrong shortcut

M  +1-1doc/katepart/index.docbook
M  +1-1doc/katepart/menus.docbook

http://commits.kde.org/kate/22489824f88cab7edb5a93ba08321ca191b08890

diff --git a/doc/katepart/index.docbook b/doc/katepart/index.docbook
index df72693..9f9338b 100644
--- a/doc/katepart/index.docbook
+++ b/doc/katepart/index.docbook
@@ -58,7 +58,7 @@
 Frameworks 5.21
 
 
-&katepart; is a fully featured editor component for &Qt; and &kde;
+&katepart; is a fully featured editor component by &Qt; and &kde;
 applications.
 
 
diff --git a/doc/katepart/menus.docbook b/doc/katepart/menus.docbook
index 4cf52a3..b930aeb 100644
--- a/doc/katepart/menus.docbook
+++ b/doc/katepart/menus.docbook
@@ -601,7 +601,7 @@ document in one window are reflected in the other window 
and vice versa.
 
 
 
-F7
+F7
 
 View
 Switch to Command Line
___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127981: add sects for symbolviewer + backtracebrowser

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127981/
---

(Updated May 26, 2016, 12:06 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Kate.


Changes
---

Submitted with commit 528746cf4b1d142fdaf16f7f76a0f773a6b3896e by Burkhard Lück 
to branch master.


Repository: kate


Description
---

the sects in this docbook will replace the FIXME's in plugins.docbook
new screenshots, not uploaded


Diffs
-

  doc/kate/symbolviewer-backtracebrowser.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127981/diff/


Testing
---

valid xml


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kate] doc/kate: add sects for symbolviewer + backtracebrowser plugins

[Burkhard Lück]

Git commit 528746cf4b1d142fdaf16f7f76a0f773a6b3896e by Burkhard Lück.
Committed on 26/05/2016 at 19:05.
Pushed by lueck into branch 'master'.

add sects for symbolviewer + backtracebrowser plugins

REVIEW:127981

A  +---doc/kate/backtrace-settings.png
A  +---doc/kate/build-output.png
M  +124  -11   doc/kate/plugins.docbook
A  +---doc/kate/symbolviewer-settings.png

http://commits.kde.org/kate/528746cf4b1d142fdaf16f7f76a0f773a6b3896e

diff --git a/doc/kate/backtrace-settings.png b/doc/kate/backtrace-settings.png
new file mode 100644
index 000..cfe80fa
Binary files /dev/null and b/doc/kate/backtrace-settings.png differ
diff --git a/doc/kate/build-output.png b/doc/kate/build-output.png
new file mode 100644
index 000..e34fdb1
Binary files /dev/null and b/doc/kate/build-output.png differ
diff --git a/doc/kate/plugins.docbook b/doc/kate/plugins.docbook
index b2e1578..532c59e 100644
--- a/doc/kate/plugins.docbook
+++ b/doc/kate/plugins.docbook
@@ -37,7 +37,8 @@ The available application plugins are:
 
 
 
-Backtrace Browser - Backtrace navigation tool view
+Backtrace 
Browser
+- Backtrace navigation tool view
 
 
 Build Plugin - 
Compile or Make and parse error messages
@@ -100,7 +101,8 @@ Search or replace patterns in opened documents or in files 
on disk
 query on SQL databases
 
 
-Symbol Viewer - Extract and show reference symbols from source
+Symbol Viewer
+- Extract and show reference symbols from source
 
 
 Terminal tool 
view - Tool view embedding a terminal widget
@@ -118,11 +120,64 @@ attributes, attribute values and entities allowed by 
DTD
 
 
 
-
+
+
@@ -2538,10 +2593,68 @@ writing much of this section.
 
 
 
-
+
+

[kde-doc-english] [kate] doc/kate: add sects for close except like + openheader + textfilter plugins

[Burkhard Lück]

Git commit 10275aa3ffcc18ca7c32fba2e4796667034c200f by Burkhard Lück.
Committed on 26/05/2016 at 18:56.
Pushed by lueck into branch 'master'.

add sects for close except like + openheader + textfilter plugins

REVIEW:127977

A  +---doc/kate/close-except-like.png
M  +0-23   doc/kate/menus.docbook
M  +205  -10   doc/kate/plugins.docbook
A  +---doc/kate/textfilter.png

http://commits.kde.org/kate/10275aa3ffcc18ca7c32fba2e4796667034c200f

diff --git a/doc/kate/close-except-like.png b/doc/kate/close-except-like.png
new file mode 100644
index 000..6696815
Binary files /dev/null and b/doc/kate/close-except-like.png differ
diff --git a/doc/kate/menus.docbook b/doc/kate/menus.docbook
index eb9d684..e23b550 100644
--- a/doc/kate/menus.docbook
+++ b/doc/kate/menus.docbook
@@ -265,29 +265,6 @@ not be reopened during startup, because they are not 
accessible anymore.
 
 
 
-
-
-File
-Close Except
- (Close Except/Like plugin)
-
-Close all documents in the file list, 
-except those which match the path selected from this
-submenu.
-
-
-
-
-
-File
-Close Like
- (Close Except/Like plugin)
-
-Close all documents in the file list which match the 
path 
-selected from this submenu.
-
-
-
 
 
 
diff --git a/doc/kate/plugins.docbook b/doc/kate/plugins.docbook
index c70fc15..b2e1578 100644
--- a/doc/kate/plugins.docbook
+++ b/doc/kate/plugins.docbook
@@ -43,7 +43,8 @@ The available application plugins are:
 Build Plugin - 
Compile or Make and parse error messages
 
 
-Close Except/Like - Close group of documents based on a common path or 
file extension
+Close 
Except/Like 
+- Close group of documents based on a common path or file extension
 
 
 CTags -
@@ -74,7 +75,8 @@ simple &gdb; frontend
 is a Autocompletion Plugin for D, using the DCD autocompletion server
 
 
-Open Header - Opens the corresponding .h/[.cpp|.c] file
+Open Header
+- Opens the corresponding .h/[.cpp|.c] file
 
 
 Project Plugin - 
Project plugin for kate
@@ -104,7 +106,7 @@ query on SQL databases
 Terminal tool 
view - Tool view embedding a terminal widget
 
 
-Text Filter - Easy text filtering
+Text Filter - 
Easy text filtering
 
 
 &XML;Completetion - Lists 
&XML; elements,
@@ -308,8 +310,75 @@ writing much of this section.
 
 
 
-
+
+
+Close Except/Like Plugin
+
+
+Introduction
+
+This plugin allows you to close a group of documents based on their 
extension and path.
+
+
+
+
+Using the Close Except/Like Plugin
+
+Assumed you have these documents opened in &kate;:
+
+
+/tmp/subfolder/test.h
+/tmp/test.cpp
+/tmp/test.txt
+
+
+Then you have the following options to close documents as displayed in 
the screenshot:
+
+
+Close Except
+
+
+
+
+
+Use the checkbox in the last item of the list to enable or disable a 
confirmation dialog.
+The selected option will be applied to both close actions.
+
+
+
+
+
+Menu Structure
+
+
+
+
+File
+Close Except
+
+
+Close all open documents, except
+those which match the path or file extension selected from the submenu.
+
+
+
+
+
+File
+Close Like
+
+
+Close all open documents
+which match the path or file extension selected from the submenu.
+
+
+
+
+
+
+
+
+
 
 
 
+
+
+Open Header Plugin
+
+
+Using the Open Header Plugin
+
+When editing C or C++ code, this command will switch between a header 
file and
+its corresponding C/C++ file or vice verca.
+
+For example, if you are editing myclass.cpp, this 
action will change
+to myclass.h if this file is available in the same 
folder.
+
+Pairs of the following filename extensions will work:
+
+
+Header files: h, H, hh, hpp
+Source files: c, cpp, cc, cp, cxx
+
+
+
+
+
+Menu Structure
+
+
+
+
+
+
+F12
+
+File
+Open .h/.cpp/.c
+
+
+Open the corresponding header or source files for the 
active document.
+
+
+
+
+
+
+
+
+
 
 
 
@@ -2545,11 +2658,92 @@ so the calling program is aware you have finished 
editing the file.
 
-
+
+
+Text Filter Plugin
+
+
+Using the Text Filter Plugin
+
+You can use this plugin to execute shell commands. A selection will
+be used as argument for the shell command, the output will either replace the 
selection
+or copied to the clipboard.
+
+
+
+Examples:
+
+less /etc/fstab - paste the context of this file or copy it 
to the clipboard
+
+
+wc - count lines, words and characters of the selection and
+paste this into the document or copy it to the clipboard
+
+
+sort - sort lines of the selection and paste the result into
+the document or copy it to the clipboard
+
+
+
+
+
+
+Menu Structure
+
+
+
+
+
+
+&Ctrl;\
+
+Tools
+Filter Text
+
+
+
+Opens the Text Filter dialog:
+
+
+Text Filter dialog
+
+
+
+
+
+Enter the shell command into the combobox or select a previous command 
from the history.
+
+
+
+
+Copy the result instead of pasting it
+
+Copy the result to clipboard leaving a document unchanged.
+
+
+
+
+Merge STDOUT and STDERR
+
+
+If checked, an output from STDOUT and STDERR will be merged and no errors will 
be reported.
+Otherwise, STDERR will be displayed as a passive message.
+
+
+
+
+
+
+
+
+
+
+
+
+
 
-
 
+
 
 
 &Daniel.Nab

Re: [kde-doc-english] Review Request 127977: add sects for close+openheader+textfilter plugins

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127977/
---

(Updated May 26, 2016, 6:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Kate.


Changes
---

Submitted with commit 10275aa3ffcc18ca7c32fba2e4796667034c200f by Burkhard Lück 
to branch master.


Repository: kate


Description
---

the sects in this docbook will replace the FIXME's in plugins.docbook
new screenshots, not uploaded


Diffs
-

  doc/kate/close-openheader-textfilter.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127977/diff/


Testing
---

valid xml


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128025: add sect for rust plugin

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128025/
---

(Updated May 26, 2016, 6:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Kate and Eike Hein.


Changes
---

Submitted with commit 535749305137f5ccc112aa56a36a3d7f267686ff by Burkhard Lück 
to branch master.


Repository: kate


Description
---

the sect in this docbook will replace the FIXME rust in plugins.docbook
new screenshots


Diffs
-

  doc/kate/rust.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128025/diff/


Testing
---

valid xml imported into plugins.docbook


File Attachments


rust-configuration.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/150c84d6-260e-463a-a059-84a8497b2429__rust-configuration.png
rust-completion.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/892a0b61-419c-4071-ba20-e72240f572a7__rust-completion.png


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kate] doc/kate: add sect for rust plugin

[Burkhard Lück]

Git commit 535749305137f5ccc112aa56a36a3d7f267686ff by Burkhard Lück.
Committed on 26/05/2016 at 18:43.
Pushed by lueck into branch 'master'.

add sect for rust plugin

REVIEW:128025

M  +47   -3doc/kate/plugins.docbook
A  +---doc/kate/rust-completion.png
A  +---doc/kate/rust-configuration.png

http://commits.kde.org/kate/535749305137f5ccc112aa56a36a3d7f267686ff

diff --git a/doc/kate/plugins.docbook b/doc/kate/plugins.docbook
index 95659b6..c70fc15 100644
--- a/doc/kate/plugins.docbook
+++ b/doc/kate/plugins.docbook
@@ -83,7 +83,8 @@ is a Autocompletion Plugin for D, using the DCD 
autocompletion server
 Replicode
 
 
-Rust code completion - Code completion for Rust source code
+Rust code completion
+- Code completion for Rust source code
 
 
 Search & 
Replace -
@@ -1575,8 +1576,51 @@ context menu Project->Lookup:xxx
 
 
-
+
+

Re: [kde-doc-english] Review Request 128015: add sect for ctags plugin

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128015/
---

(Updated May 26, 2016, 6:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Kate and Kåre Särs.


Changes
---

Submitted with commit b86f3a6ed33945ca89e9030ba46b747eb4cdf0cf by Burkhard Lück 
to branch master.


Repository: kate


Description
---

the sects in this docbook will replace the FIXME ctags in plugins.docbook
new screenshots, not uploaded


Diffs
-

  doc/kate/ctags.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128015/diff/


Testing
---

valid xml


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kate] doc/kate: add sect for ctags plugin

[Burkhard Lück]

Git commit b86f3a6ed33945ca89e9030ba46b747eb4cdf0cf by Burkhard Lück.
Committed on 26/05/2016 at 18:38.
Pushed by lueck into branch 'master'.

add sect for ctags plugin

REVIEW:128015

A  +---doc/kate/ctags-global-setting.png
A  +---doc/kate/ctags-session-setting.png
M  +171  -5doc/kate/plugins.docbook

http://commits.kde.org/kate/b86f3a6ed33945ca89e9030ba46b747eb4cdf0cf

diff --git a/doc/kate/ctags-global-setting.png 
b/doc/kate/ctags-global-setting.png
new file mode 100644
index 000..a3c1e66
Binary files /dev/null and b/doc/kate/ctags-global-setting.png differ
diff --git a/doc/kate/ctags-session-setting.png 
b/doc/kate/ctags-session-setting.png
new file mode 100644
index 000..d796f4a
Binary files /dev/null and b/doc/kate/ctags-session-setting.png differ
diff --git a/doc/kate/plugins.docbook b/doc/kate/plugins.docbook
index 9adcc5d..95659b6 100644
--- a/doc/kate/plugins.docbook
+++ b/doc/kate/plugins.docbook
@@ -46,7 +46,8 @@ The available application plugins are:
 Close Except/Like - Close group of documents based on a common path or 
file extension
 
 
-CTags - Look up definitions/declarations with CTags
+CTags -
+Look up definitions/declarations with CTags
 
 
 Document 
switcher -
@@ -309,10 +310,175 @@ writing much of this section.
 
 
-
+
+
+
+
+
+
+
+
+Menu Structure
+
+
+
+
+
+CTags
+Jump one step back
+
+
+Navigate back in the history to the last visited tag.
+
+
+
+
+
+CTags
+Lookup Current Text
+
+
+Opens the Lookup tab of the CTags view and displays 
all
+language objects matching the current text selection in the list.
+
+
+
+
+
+CTags
+Goto Declaration
+
+
+If the cursor is in a definition object this will open the document
+containing the corresponding declaration if needed, activate its view and
+place the cursor at the start of the declaration.
+
+
+
+
+
+CTags
+Goto Definition
+
+
+If the cursor is in a declaration object this will open the document
+containing the corresponding definition if needed, activate its view and
+place the cursor at the start of the definition.
+
+
+
+
+
+
+
+
+
+
 
 
 
___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kate] doc/kate: add sects for documentswitcher + lumen plugins

[Burkhard Lück]

Git commit 601f0e60ae1c94e7b5b7f3062a0d6b92e55ac3fa by Burkhard Lück.
Committed on 26/05/2016 at 18:31.
Pushed by lueck into branch 'master'.

add sects for documentswitcher + lumen plugins

REVIEW:128003

A  +---doc/kate/documentswitcher.png
A  +---doc/kate/lumen-calltips.png
A  +---doc/kate/lumen-completition-overload.png
A  +---doc/kate/lumen-completition.png
A  +---doc/kate/lumen-import.png
M  +111  -13   doc/kate/plugins.docbook

http://commits.kde.org/kate/601f0e60ae1c94e7b5b7f3062a0d6b92e55ac3fa

diff --git a/doc/kate/documentswitcher.png b/doc/kate/documentswitcher.png
new file mode 100644
index 000..9c59348
Binary files /dev/null and b/doc/kate/documentswitcher.png differ
diff --git a/doc/kate/lumen-calltips.png b/doc/kate/lumen-calltips.png
new file mode 100644
index 000..1d9d7f4
Binary files /dev/null and b/doc/kate/lumen-calltips.png differ
diff --git a/doc/kate/lumen-completition-overload.png 
b/doc/kate/lumen-completition-overload.png
new file mode 100644
index 000..1c4ab05
Binary files /dev/null and b/doc/kate/lumen-completition-overload.png differ
diff --git a/doc/kate/lumen-completition.png b/doc/kate/lumen-completition.png
new file mode 100644
index 000..8ba879c
Binary files /dev/null and b/doc/kate/lumen-completition.png differ
diff --git a/doc/kate/lumen-import.png b/doc/kate/lumen-import.png
new file mode 100644
index 000..f4d6735
Binary files /dev/null and b/doc/kate/lumen-import.png differ
diff --git a/doc/kate/plugins.docbook b/doc/kate/plugins.docbook
index 8a63444..9adcc5d 100644
--- a/doc/kate/plugins.docbook
+++ b/doc/kate/plugins.docbook
@@ -49,7 +49,8 @@ The available application plugins are:
 CTags - Look up definitions/declarations with CTags
 
 
-Document switcher - Quick document switching with &Alt;	 behavior
+Document 
switcher -
+Quick document switching with &Alt;	 
behavior
 
 
 File system 
browser -
@@ -68,7 +69,8 @@ simple &gdb; frontend
 
 -->
 
-Lumen - Lumen is a Autocompletion Plugin for D, using the DCD 
autocompletion server
+Lumen - Lumen
+is a Autocompletion Plugin for D, using the DCD autocompletion server
 
 
 Open Header - Opens the corresponding .h/[.cpp|.c] file
@@ -312,8 +314,48 @@ 
https://kate-editor.org/2012/11/02/using-the-projects-plugin-in-kate/
 Menu CTags with 5 items
 -->
 
-
+
+
+Document Switcher Plugin
+
+
+Menu Structure
+
+
+
+
+
+
+&Ctrl;	
+
+View
+Last Used Views
+
+
+
+Opens a list with the last viewed documents:
+
+
+Last viewed documents
+
+
+
+
+
+Keep the shortcut &Ctrl;	 
pressed and
+can use the Up, Down, Home 
or
+End keys to navigate in the list. Pressing a char key 
consecutively
+will cycle through all items with the first matching in the list.
+If you release the shortcut keys the view will switch to the selected document 
in the list.
+
+
+
+
+
+
+
+
+
 
 
 
@@ -480,14 +522,9 @@ list, and order them using the arrow buttons at the side 
of the list.
 
 
 
-
 
 The Documents List
-
+
+
+
+Lumen Plugin
+
+Lumen is a plugin providing code-completion for the https://en.wikipedia.org/wiki/D_(programming_language)">
+D programming language. It is just a connection between the editor and 
the D Completion
+Daemon (a server providing all the information) called DCD. The plugin 
currently supports
+all major features of the completion server: feeding the server with import 
files,
+displaying documentation and several types of completion:
+
+
+Imports:
+
+Imports
+
+
+
+
+
+Basic Completion:
+
+Basic Completion
+
+
+
+
+
+Completion (overloaded Function):
+
+Completion (overloaded Function)
+
+
+
+
+
+Calltips:
+
+Calltips
+
+
+
+
+
+To make Lumen work you have to install DCD, using the information 
provided by
+the https://dlang.org/";>D community.
+
+
+After installing DCD edit ~/.config/dcd/dcd.conf 
(create if it does not exist already)
+and add a path to your D include/import files ⪚ /usr/include/dlang/dmd
+or /usr/include/d.
+
+
+Furthermore Lumen will try to read a .lumenconfig 
in every parent folder
+of the currently opened D source file and add every line in this file as 
include path to the
+DCD server. Add all dependencies of your current project to this file.
+
+
+Now start the completion server with dcd-server, 
enable the Lumen
+plugin in your settings and you will have code completion for the D programming
+language in &kate;
+
+
+
+
 
 
___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128003: add sects for documentswitcher + lumen plugins

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128003/
---

(Updated May 26, 2016, 6:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Kate and David Herberth.


Changes
---

Submitted with commit 601f0e60ae1c94e7b5b7f3062a0d6b92e55ac3fa by Burkhard Lück 
to branch master.


Repository: kate


Description
---

the sects in this docbook will replace the FIXME's in plugins.docbook
lumen info from 
kate-editor.org/2014/02/20/lumen-a-code-completion-plugin-for-the-d-programming-language/
new screenshots, not uploaded


Diffs
-

  doc/kate/documentswitcher-lumen.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128003/diff/


Testing
---

valid xml


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kate] doc/kate: add sect for project plugin

[Burkhard Lück]

Git commit 860ee0804e43e6f1030d97a671a2351cd66155b0 by Burkhard Lück.
Committed on 26/05/2016 at 18:19.
Pushed by lueck into branch 'master'.

add sect for project plugin

REVIEW:127998

M  +0-42   doc/kate/menus.docbook
M  +332  -4doc/kate/plugins.docbook
A  +---doc/kate/project-completition.png
A  +---doc/kate/project-configure.png
A  +---doc/kate/project-current-analysis.png
A  +---doc/kate/project-quickopen.png
A  +---doc/kate/project-search.png
A  +---doc/kate/project-view.png
A  +---doc/kate/snippets-repository.png

http://commits.kde.org/kate/860ee0804e43e6f1030d97a671a2351cd66155b0

diff --git a/doc/kate/menus.docbook b/doc/kate/menus.docbook
index 1c95b3e..eb9d684 100644
--- a/doc/kate/menus.docbook
+++ b/doc/kate/menus.docbook
@@ -1195,48 +1195,6 @@ Show Word Count -> Displays the number of words and 
characters in the document a
 
 
 
-
-The Projects Menu
-
-The Projects menu allows you to switch between
-currently open projects.  It is displayed by the Project plugin.
-
-
-Menu Items
-
-
-
-
-
-
-&Ctrl;&Alt;Left
-
-Projects
-Back
-
-
-Switch to the previous project.
-
-
-
-
-
-
-&Ctrl;&Alt;Right
-
-Projects
-Forward
-
-
-Switch to the next project.
-
-
-
-
-
-
-
 
 The Bookmarks Menu
 
diff --git a/doc/kate/plugins.docbook b/doc/kate/plugins.docbook
index b84db72..8a63444 100644
--- a/doc/kate/plugins.docbook
+++ b/doc/kate/plugins.docbook
@@ -74,7 +74,7 @@ simple &gdb; frontend
 Open Header - Opens the corresponding .h/[.cpp|.c] file
 
 
-Project Plugin - Project plugin for kate
+Project Plugin - 
Project plugin for kate
 
 
 Replicode
@@ -976,9 +976,337 @@ 
https://kate-editor.org/2014/02/20/lumen-a-code-completion-plugin-for-the-d-prog
 
 
-
+
+
+
+Project Plugin
+
+
+Introduction
+
+The basic idea of the Project plugin is to have a structured list of
+files belonging to the project with the following properties:
+
+
+Provide a structured view of the files
+Make it easy and very fast to open and switch 
projects
+Support search and replace for a project
+Provide simple auto completion
+Make it simple to quickly open files in the 
project
+Support for building the project
+
+
+
+
+Structured View of the Files
+
+Once the Project plugin is loaded in the &kate; configuration page, open 
a file
+in a project and a sidebar
+appears that lists all projects as well as the project files as follows:
+
+
+Project View
+
+
+
+
+
+As you can see, the currently active project is Kate, and 
it’s contents is
+listed in the tree view. Clicking on files in the tree view opens the file in 
the
+editor. Further, a context menu is provided with which you can open files with
+other applications, such as a .ui file 
with Qt Designer.
+You can filter the items by typing parts of the file name you are 
looking for into the search bar
+at the bottom of the list.
+
+
+
+Switching Projects
+
+The idea is that you never have to open a project manually, this is even 
not
+supported at all. Hence, what happens if you open a file, the Project plugin 
quickly
+scans the folder and its parent folders for a 
.kateproject file. If found, the project
+is automatically loaded.
+
+Furthermore, if you open another document in &kate;, that belongs to 
another project,
+the Project plugin automatically switches the current project. So intuitively, 
always the
+correct project is active. Of course, you can also switch the currently active 
project
+using the combo box.
+
+
+
+
+Search and Replace in Projects
+
+&kate; has a Search and Replace plugin that shows up in the
+bottom sidebar. If a project is loaded, open the Search and Replace sidebar,
+and switch to the mode to search and replace in the current project:
+
+
+Search in Projects
+
+
+
+
+
+
+
+
+Simple Auto Completion
+
+With the knowledge of all files belonging to a project, the Project 
plugin provides
+simple auto completion facilities based on CTags. If a project is initially 
opened, CTags
+parses all project files in a background thread and saves the CTags 
information to
+/tmp. This file then is used to 
populate the auto
+completion popup in &kate;.
+
+In contrast, without this auto completion, &kate; is only capable of 
showing auto
+completion items based on the words in the current file. So the auto 
completion provided
+by the Project plugin is much more powerful.
+
+
+Completion in Projects
+
+
+
+
+
+If CTags is missing, a passive popup warns you about this issue. It is 
also noteworthy,
+that the CTags file in /tmp is cleaned 
up when &kate;
+exits, so the plugin does not pollute any folder with unwanted files.
+
+
+
+
+Quick Opening Files
+
+As clicking on files in the tree view is not the fastest way to open a 
file, &kate;
+provides a built-in quick open mechanism you can activate with
+&Ctrl;&Alt;O.
+What you the get is a list like this:
+
+
+Quick Open
+
+
+
+
+
+You can filter by typing parts of the file name you are looking for, and 
you can
+also navigate with the arrow keys and page up/

Re: [kde-doc-english] Review Request 127998: add sect for project plugin

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127998/
---

(Updated May 26, 2016, 8:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Kate and Kåre Särs.


Changes
---

Submitted with commit 860ee0804e43e6f1030d97a671a2351cd66155b0 by Burkhard Lück 
to branch master.


Repository: kate


Description
---

the sects in this docbook will replace the FIXME projects in plugins.docbook
new screenshots, not uploaded


Diffs
-

  doc/kate/projectplugin.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127998/diff/


Testing
---

valid xml


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/
---

(Updated May 26, 2016, 5:58 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Kate.


Changes
---

Submitted with commit c77180deefe44dd5f3a9080690447826f1890327 by Burkhard Lück 
to branch master.


Repository: kate


Description
---

kate is by kde, not for kde
move all plugin related info to plugin.docbook
remove all obsolete infos for kate plugins
add a lot of FIXME's for missing content, will be updated in next RR
objective of this RR is to get all obsolete/wrong info stripped off from the 
docbook
feel free to add comments/reviews to my FIXME's, but even without them the 
updated docbooks are better for our users


Diffs
-

  doc/kate/configuring.docbook 5d11629 
  doc/kate/fundamentals.docbook 3f6bcc2 
  doc/kate/gdb-settings.png 0c92bb8 
  doc/kate/index.docbook 368cf63 
  doc/kate/menus.docbook 717bddd 
  doc/kate/plugins.docbook d24c3d0 
  doc/kate/snippets-form.png 66875c1 
  doc/kate/snippets-panel.png 281948c 
  doc/kate/snippets-usage.png 7851e05 

Diff: https://git.reviewboard.kde.org/r/127949/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Christoph Cullmann]

> On May 26, 2016, 3:41 p.m., Christoph Cullmann wrote:
> > Hi, ok, arrived here now.
> > 
> > Feel free to commit this.
> > 
> > I have commited one plugin doc change for the revived xmlcheck plugin:
> > 
> > https://phabricator.kde.org/rKATE8721cd331f4c
> > 
> > If this messes something up for you, revert it and apply your stuff and 
> > ping me to reapply that afterwards.
> > Thanks.
> > 
> > Sorry that I had no time to look at stuff here since long :/
> 
> Burkhard Lück wrote:
> Your commit with the xmlcheck plugin (much appreciated by me, thanks) 
> introduced an additional para + one varlistentry:
> 
> 1)
> 
> File Type
> Select the file type(s) you want the snippet repository 
> to apply
> to.  It is set to * by default, so the repository applies 
> to all files.  You
> can change it to something like C++ for instance, 
> or select
> from a list by hitting the Edit.  You can specify 
> more
> than one file type by separating them with 
> ;.
> 
> 
> Afaik this is not correct because you have to press &Shift; to specify 
> more than one file; not to type ";"
> and this is already in line 1434-1441 in the patch for plugins.docbook, 
> so I would remove it.
> 
> 2)
> In Snippet Content you can specify variables 
> with
> ${name} or
> %{name}.  These can be 
> filled
> by QtScript or when the snippet is used.  There is a special variable -
> ${cursor} or %{cursor} - which automatically sets the cursor to its first
> occurrence.
> 
> This is already in lines 1471 - 1492 in the patch for plugins.docbook, 
> right?

>Afaik this is not correct because you have to press &Shift; to specify more 
>than one file; not to type ";"
>and this is already in line 1434-1441 in the patch for plugins.docbook, 
>so I would remove it.
Please do so ;=)
 
> This is already in lines 1471 - 1492 in the patch for plugins.docbook, right?
Seems duplicated, yeah :/

Btw.: Thanks for all your fixes and improvements!


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/#review95850
---


On May 19, 2016, 2:21 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127949/
> ---
> 
> (Updated May 19, 2016, 2:21 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> kate is by kde, not for kde
> move all plugin related info to plugin.docbook
> remove all obsolete infos for kate plugins
> add a lot of FIXME's for missing content, will be updated in next RR
> objective of this RR is to get all obsolete/wrong info stripped off from the 
> docbook
> feel free to add comments/reviews to my FIXME's, but even without them the 
> updated docbooks are better for our users
> 
> 
> Diffs
> -
> 
>   doc/kate/configuring.docbook 5d11629 
>   doc/kate/fundamentals.docbook 3f6bcc2 
>   doc/kate/gdb-settings.png 0c92bb8 
>   doc/kate/index.docbook 368cf63 
>   doc/kate/menus.docbook 717bddd 
>   doc/kate/plugins.docbook d24c3d0 
>   doc/kate/snippets-form.png 66875c1 
>   doc/kate/snippets-panel.png 281948c 
>   doc/kate/snippets-usage.png 7851e05 
> 
> Diff: https://git.reviewboard.kde.org/r/127949/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Burkhard Lück]

> On Mai 26, 2016, 3:41 nachm., Christoph Cullmann wrote:
> > Hi, ok, arrived here now.
> > 
> > Feel free to commit this.
> > 
> > I have commited one plugin doc change for the revived xmlcheck plugin:
> > 
> > https://phabricator.kde.org/rKATE8721cd331f4c
> > 
> > If this messes something up for you, revert it and apply your stuff and 
> > ping me to reapply that afterwards.
> > Thanks.
> > 
> > Sorry that I had no time to look at stuff here since long :/

Your commit with the xmlcheck plugin (much appreciated by me, thanks) 
introduced an additional para + one varlistentry:

1)

File Type
Select the file type(s) you want the snippet repository to apply
to.  It is set to * by default, so the repository applies to all 
files.  You
can change it to something like C++ for instance, or 
select
from a list by hitting the Edit.  You can specify more
than one file type by separating them with 
;.


Afaik this is not correct because you have to press &Shift; to specify more 
than one file; not to type ";"
and this is already in line 1434-1441 in the patch for plugins.docbook, 
so I would remove it.

2)
In Snippet Content you can specify variables with
${name} or
%{name}.  These can be filled
by QtScript or when the snippet is used.  There is a special variable -
${cursor} or %{cursor} - which automatically sets the cursor to its first
occurrence.

This is already in lines 1471 - 1492 in the patch for plugins.docbook, right?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/#review95850
---


On Mai 19, 2016, 2:21 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127949/
> ---
> 
> (Updated Mai 19, 2016, 2:21 nachm.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> kate is by kde, not for kde
> move all plugin related info to plugin.docbook
> remove all obsolete infos for kate plugins
> add a lot of FIXME's for missing content, will be updated in next RR
> objective of this RR is to get all obsolete/wrong info stripped off from the 
> docbook
> feel free to add comments/reviews to my FIXME's, but even without them the 
> updated docbooks are better for our users
> 
> 
> Diffs
> -
> 
>   doc/kate/configuring.docbook 5d11629 
>   doc/kate/fundamentals.docbook 3f6bcc2 
>   doc/kate/gdb-settings.png 0c92bb8 
>   doc/kate/index.docbook 368cf63 
>   doc/kate/menus.docbook 717bddd 
>   doc/kate/plugins.docbook d24c3d0 
>   doc/kate/snippets-form.png 66875c1 
>   doc/kate/snippets-panel.png 281948c 
>   doc/kate/snippets-usage.png 7851e05 
> 
> Diff: https://git.reviewboard.kde.org/r/127949/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128015: add sect for ctags plugin

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128015/#review95863
---


Ship it!




Yep, ship it, like the base patch.

- Christoph Cullmann


On May 26, 2016, 7:31 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128015/
> ---
> 
> (Updated May 26, 2016, 7:31 a.m.)
> 
> 
> Review request for Documentation, Kate and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sects in this docbook will replace the FIXME ctags in plugins.docbook
> new screenshots, not uploaded
> 
> 
> Diffs
> -
> 
>   doc/kate/ctags.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128015/diff/
> 
> 
> Testing
> ---
> 
> valid xml
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128003: add sects for documentswitcher + lumen plugins

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128003/#review95861
---


Ship it!




Yep, ship this, sorry for the delay :/

- Christoph Cullmann


On May 24, 2016, 1:18 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128003/
> ---
> 
> (Updated May 24, 2016, 1:18 p.m.)
> 
> 
> Review request for Documentation, Kate and David Herberth.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sects in this docbook will replace the FIXME's in plugins.docbook
> lumen info from 
> kate-editor.org/2014/02/20/lumen-a-code-completion-plugin-for-the-d-programming-language/
> new screenshots, not uploaded
> 
> 
> Diffs
> -
> 
>   doc/kate/documentswitcher-lumen.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128003/diff/
> 
> 
> Testing
> ---
> 
> valid xml
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127998: add sect for project plugin

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127998/#review95859
---


Ship it!




Nice, finally some good description, perhaps that will help more people to use 
that plugin.

- Christoph Cullmann


On May 25, 2016, 8:04 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127998/
> ---
> 
> (Updated May 25, 2016, 8:04 a.m.)
> 
> 
> Review request for Documentation, Kate and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sects in this docbook will replace the FIXME projects in plugins.docbook
> new screenshots, not uploaded
> 
> 
> Diffs
> -
> 
>   doc/kate/projectplugin.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127998/diff/
> 
> 
> Testing
> ---
> 
> valid xml
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Christoph Cullmann]

> On May 19, 2016, 2:31 p.m., Burkhard Lück wrote:
> > doc/kate/plugins.docbook, lines 1605-1609
> > 
> >
> > 
> > You may enter the beginningof the snippets name before or after 
> > pressing this key combination
> > 
> > Does not work for me.

Then remove this, guess not up-to-date with the current state. The snippet 
stuff was redone several times :/


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/#review95610
---


On May 19, 2016, 2:21 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127949/
> ---
> 
> (Updated May 19, 2016, 2:21 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> kate is by kde, not for kde
> move all plugin related info to plugin.docbook
> remove all obsolete infos for kate plugins
> add a lot of FIXME's for missing content, will be updated in next RR
> objective of this RR is to get all obsolete/wrong info stripped off from the 
> docbook
> feel free to add comments/reviews to my FIXME's, but even without them the 
> updated docbooks are better for our users
> 
> 
> Diffs
> -
> 
>   doc/kate/configuring.docbook 5d11629 
>   doc/kate/fundamentals.docbook 3f6bcc2 
>   doc/kate/gdb-settings.png 0c92bb8 
>   doc/kate/index.docbook 368cf63 
>   doc/kate/menus.docbook 717bddd 
>   doc/kate/plugins.docbook d24c3d0 
>   doc/kate/snippets-form.png 66875c1 
>   doc/kate/snippets-panel.png 281948c 
>   doc/kate/snippets-usage.png 7851e05 
> 
> Diff: https://git.reviewboard.kde.org/r/127949/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127981: add sects for symbolviewer + backtracebrowser

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127981/#review95858
---


Ship it!




Nice, too, not that im an expert for these plugins.

- Christoph Cullmann


On May 20, 2016, 9:01 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127981/
> ---
> 
> (Updated May 20, 2016, 9:01 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sects in this docbook will replace the FIXME's in plugins.docbook
> new screenshots, not uploaded
> 
> 
> Diffs
> -
> 
>   doc/kate/symbolviewer-backtracebrowser.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127981/diff/
> 
> 
> Testing
> ---
> 
> valid xml
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Christoph Cullmann]

> On May 19, 2016, 2:31 p.m., Burkhard Lück wrote:
> > doc/kate/plugins.docbook, lines 1440-1443
> > 
> >
> > Commented, because does not work here.
> > Is it really not possible to load a local snippet repository file?

Actually not sure here :/


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/#review95610
---


On May 19, 2016, 2:21 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127949/
> ---
> 
> (Updated May 19, 2016, 2:21 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> kate is by kde, not for kde
> move all plugin related info to plugin.docbook
> remove all obsolete infos for kate plugins
> add a lot of FIXME's for missing content, will be updated in next RR
> objective of this RR is to get all obsolete/wrong info stripped off from the 
> docbook
> feel free to add comments/reviews to my FIXME's, but even without them the 
> updated docbooks are better for our users
> 
> 
> Diffs
> -
> 
>   doc/kate/configuring.docbook 5d11629 
>   doc/kate/fundamentals.docbook 3f6bcc2 
>   doc/kate/gdb-settings.png 0c92bb8 
>   doc/kate/index.docbook 368cf63 
>   doc/kate/menus.docbook 717bddd 
>   doc/kate/plugins.docbook d24c3d0 
>   doc/kate/snippets-form.png 66875c1 
>   doc/kate/snippets-panel.png 281948c 
>   doc/kate/snippets-usage.png 7851e05 
> 
> Diff: https://git.reviewboard.kde.org/r/127949/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127977: add sects for close+openheader+textfilter plugins

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127977/#review95856
---


Ship it!




Ok, like the base change (added comments to the questions, there, too), this 
can be shipped.

- Christoph Cullmann


On May 20, 2016, 12:28 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127977/
> ---
> 
> (Updated May 20, 2016, 12:28 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sects in this docbook will replace the FIXME's in plugins.docbook
> new screenshots, not uploaded
> 
> 
> Diffs
> -
> 
>   doc/kate/close-openheader-textfilter.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127977/diff/
> 
> 
> Testing
> ---
> 
> valid xml
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Christoph Cullmann]

> On May 19, 2016, 2:31 p.m., Burkhard Lück wrote:
> > doc/kate/plugins.docbook, lines 1385-1387
> > 
> >
> > Everywere else the docbbooks (and the GUI) says JavaScript, not 
> > QtScript.
> > Why QtScript only here?

Just JavaScript would be better I guess.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/#review95610
---


On May 19, 2016, 2:21 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127949/
> ---
> 
> (Updated May 19, 2016, 2:21 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> kate is by kde, not for kde
> move all plugin related info to plugin.docbook
> remove all obsolete infos for kate plugins
> add a lot of FIXME's for missing content, will be updated in next RR
> objective of this RR is to get all obsolete/wrong info stripped off from the 
> docbook
> feel free to add comments/reviews to my FIXME's, but even without them the 
> updated docbooks are better for our users
> 
> 
> Diffs
> -
> 
>   doc/kate/configuring.docbook 5d11629 
>   doc/kate/fundamentals.docbook 3f6bcc2 
>   doc/kate/gdb-settings.png 0c92bb8 
>   doc/kate/index.docbook 368cf63 
>   doc/kate/menus.docbook 717bddd 
>   doc/kate/plugins.docbook d24c3d0 
>   doc/kate/snippets-form.png 66875c1 
>   doc/kate/snippets-panel.png 281948c 
>   doc/kate/snippets-usage.png 7851e05 
> 
> Diff: https://git.reviewboard.kde.org/r/127949/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Christoph Cullmann]

> On May 19, 2016, 2:31 p.m., Burkhard Lück wrote:
> > doc/kate/fundamentals.docbook, lines 680-683
> > 
> >
> > Is this para about KATE_PID still correct?

Yes.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/#review95610
---


On May 19, 2016, 2:21 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127949/
> ---
> 
> (Updated May 19, 2016, 2:21 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> kate is by kde, not for kde
> move all plugin related info to plugin.docbook
> remove all obsolete infos for kate plugins
> add a lot of FIXME's for missing content, will be updated in next RR
> objective of this RR is to get all obsolete/wrong info stripped off from the 
> docbook
> feel free to add comments/reviews to my FIXME's, but even without them the 
> updated docbooks are better for our users
> 
> 
> Diffs
> -
> 
>   doc/kate/configuring.docbook 5d11629 
>   doc/kate/fundamentals.docbook 3f6bcc2 
>   doc/kate/gdb-settings.png 0c92bb8 
>   doc/kate/index.docbook 368cf63 
>   doc/kate/menus.docbook 717bddd 
>   doc/kate/plugins.docbook d24c3d0 
>   doc/kate/snippets-form.png 66875c1 
>   doc/kate/snippets-panel.png 281948c 
>   doc/kate/snippets-usage.png 7851e05 
> 
> Diff: https://git.reviewboard.kde.org/r/127949/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 127949: Update/proofread Kate handbook

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127949/#review95850
---


Ship it!




Hi, ok, arrived here now.

Feel free to commit this.

I have commited one plugin doc change for the revived xmlcheck plugin:

https://phabricator.kde.org/rKATE8721cd331f4c

If this messes something up for you, revert it and apply your stuff and ping me 
to reapply that afterwards.
Thanks.

Sorry that I had no time to look at stuff here since long :/

- Christoph Cullmann


On May 19, 2016, 2:21 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127949/
> ---
> 
> (Updated May 19, 2016, 2:21 p.m.)
> 
> 
> Review request for Documentation and Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> kate is by kde, not for kde
> move all plugin related info to plugin.docbook
> remove all obsolete infos for kate plugins
> add a lot of FIXME's for missing content, will be updated in next RR
> objective of this RR is to get all obsolete/wrong info stripped off from the 
> docbook
> feel free to add comments/reviews to my FIXME's, but even without them the 
> updated docbooks are better for our users
> 
> 
> Diffs
> -
> 
>   doc/kate/configuring.docbook 5d11629 
>   doc/kate/fundamentals.docbook 3f6bcc2 
>   doc/kate/gdb-settings.png 0c92bb8 
>   doc/kate/index.docbook 368cf63 
>   doc/kate/menus.docbook 717bddd 
>   doc/kate/plugins.docbook d24c3d0 
>   doc/kate/snippets-form.png 66875c1 
>   doc/kate/snippets-panel.png 281948c 
>   doc/kate/snippets-usage.png 7851e05 
> 
> Diff: https://git.reviewboard.kde.org/r/127949/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kate] doc/kate: re-add docs about xmlcheck plugin

[Christoph Cullmann]

Git commit 8721cd331f4c69d66995ca7408edd8232ea105f5 by Christoph Cullmann.
Committed on 26/05/2016 at 15:00.
Pushed by cullmann into branch 'master'.

re-add docs about xmlcheck plugin

REVIEW: 126173

Patch by dev Laptander 

M  +87   -23   doc/kate/plugins.docbook

http://commits.kde.org/kate/8721cd331f4c69d66995ca7408edd8232ea105f5

diff --git a/doc/kate/plugins.docbook b/doc/kate/plugins.docbook
index d24c3d0..85871a5 100644
--- a/doc/kate/plugins.docbook
+++ b/doc/kate/plugins.docbook
@@ -81,7 +81,7 @@ simple &gdb; frontend
 Rust code completion - Code completion for Rust source code
 
 
-Search & 
Replace - 
+Search & 
Replace -
 Search or replace patterns in opened documents or in files on disk
 
 
@@ -104,6 +104,9 @@ query on SQL databases
 &XML;Completetion - Lists 
&XML; elements,
 attributes, attribute values and entities allowed by DTD
 
+
+&XML; 
Validation- Validates &XML; files using xmllint
+
 
 
 
@@ -823,7 +826,7 @@ for the Search in Folder mode and the results of your 
search.
 
 Find
 
-This is where you type in what you want to find.  You may enter standard text, 
+This is where you type in what you want to find.  You may enter standard text,
 or a regular expression if enabled.
 
 
@@ -851,7 +854,7 @@ When you've finished configuring everything, just press the
 When you've finished configuring everything, just press the
 Replace button to replace the text entered in the
 Find text box with that of the 
Replace
-text box.  You may also press &Enter; in the Replace text 
+text box.  You may also press &Enter; in the Replace text
 box to do the same.
 
 
@@ -922,7 +925,7 @@ Project to search all the files listed in the 
currently open project.
 
 You may enter the path of the folder you wish to search.  For instance, you 
might
 enter ~/development/kde/kate/ if you wished to search 
the
-&kate; source code.  This option is only available when using 
+&kate; source code.  This option is only available when using
 in Folder mode.
 
 
@@ -930,7 +933,7 @@ enter ~/development/kde/kate/ if you 
wished to search the
 
 Open file dialog
 
-Press this button to locate the folder in your desktop's folder browser. This 
+Press this button to locate the folder in your desktop's folder browser. This
 button only works when using in Folder mode.
 
 
@@ -939,7 +942,7 @@ button only works when using in Folder 
mode.
 Up
 
 Press this button to change Folder to the parent of the
-currently selected folder. This button only works when using 
+currently selected folder. This button only works when using
 in Folder mode.
 
 
@@ -948,7 +951,7 @@ currently selected folder. This button only works when using
 Restore Current Folder
 
 This button will set the Folder entry to the folder in 
which
-the currently open document is located. This  button only works when using 
+the currently open document is located. This  button only works when using
 in Folder mode.
 
 
@@ -969,8 +972,8 @@ option is not available when using in Open 
files mode.
 Exclude
 
 The opposite of Filter, this prevents &kappname; from
-searching files that match the specified patterns.  As with 
-Filter, you can enter multiple patterns separated with a 
+searching files that match the specified patterns.  As with
+Filter, you can enter multiple patterns separated with a
 comma (,). This option is not available when using
 in Open files mode.
 
@@ -980,7 +983,7 @@ comma (,). This option is not 
available when using
 Recursive
 
 If this option is enabled, &kappname; will also search in all subfolders of the
-selected folder. This option is only available when using 
+selected folder. This option is only available when using
 in Folder mode.
 
 
@@ -989,7 +992,7 @@ selected folder. This option is only available when using
 Include hidden
 
 If this option is enabled, &kappname; will also search in files or folders that
-are typically hidden by your &OS;. This option is only available when using 
+are typically hidden by your &OS;. This option is only available when using
 in Folder mode.
 
 
@@ -1000,7 +1003,7 @@ are typically hidden by your &OS;. This option is only 
available when using
 The Search in Files plugin typically doesn't follow
 http://en.wikipedia.org/wiki/Symbolic_link";>symbolic links.
 When this option is enabled, the plugin will follow them instead and search 
inside
-the files or folders they reference. This option is only available when using 
+the files or folders they reference. This option is only available when using
 in Folder mode.
 
 It's possible for symbolic links to reference a folder that is 
the
@@ -1034,7 +1037,7 @@ automatically be displayed as soon as a search is 
performed.
 your search query, followed by the number of matches found in that file.
 
 To see a list of matches in that file, simply click the expansion arrow
-to the left of the file name.  (If you selected the Expand 
+to the left of the file name.  (If you selected the Expand
 results option, this will already be done for you.)  The line number

Re: [kde-doc-english] Review Request 127903: Update kf5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/
---

(Updated Mai 26, 2016, 3:01 nachm.)


Review request for Documentation and KDE Frameworks.


Changes
---

remove trailing whitespace


Repository: kdoctools


Description
---

replace the obsolete content with updates
Use case for option desktopfile borrowed von Martin Gräßlins commit log

See Also: qt5options - does that really make sense for a kf5 app?
I really doubt that the qt5options manpage is uptodate


Diffs (updated)
-

  docs/kf5options/man-kf5options.7.docbook f79d42c 

Diff: https://git.reviewboard.kde.org/r/127903/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128025: add sect for rust plugin

[Christoph Cullmann]

> On May 26, 2016, 2:38 p.m., Christoph Cullmann wrote:
> > Cool, thanks for filling in the missing pieces!
> 
> Burkhard Lück wrote:
> Thanks for review and the "Ship it!", but you are aware that this RR 
> along with 127977, 127981, 127998, 128003 and 128015 (all about kate 
> plugins)
> depends on https://git.reviewboard.kde.org/r/127949/ ?
> 
> https://git.reviewboard.kde.org/r/127949/ from Mai 17, 2016 
> with 4 issues raised by me has no review so far :-(

I am sorry for that, I am just on my way over all requests.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128025/#review95835
---


On May 26, 2016, 1:51 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128025/
> ---
> 
> (Updated May 26, 2016, 1:51 p.m.)
> 
> 
> Review request for Documentation, Kate and Eike Hein.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sect in this docbook will replace the FIXME rust in plugins.docbook
> new screenshots
> 
> 
> Diffs
> -
> 
>   doc/kate/rust.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128025/diff/
> 
> 
> Testing
> ---
> 
> valid xml imported into plugins.docbook
> 
> 
> File Attachments
> 
> 
> rust-configuration.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/150c84d6-260e-463a-a059-84a8497b2429__rust-configuration.png
> rust-completion.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/892a0b61-419c-4071-ba20-e72240f572a7__rust-completion.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128025: add sect for rust plugin

[Burkhard Lück]

> On Mai 26, 2016, 2:38 nachm., Christoph Cullmann wrote:
> > Cool, thanks for filling in the missing pieces!

Thanks for review and the "Ship it!", but you are aware that this RR 
along with 127977, 127981, 127998, 128003 and 128015 (all about kate plugins)
depends on https://git.reviewboard.kde.org/r/127949/ ?

https://git.reviewboard.kde.org/r/127949/ from Mai 17, 2016 
with 4 issues raised by me has no review so far :-(


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128025/#review95835
---


On Mai 26, 2016, 1:51 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128025/
> ---
> 
> (Updated Mai 26, 2016, 1:51 nachm.)
> 
> 
> Review request for Documentation, Kate and Eike Hein.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sect in this docbook will replace the FIXME rust in plugins.docbook
> new screenshots
> 
> 
> Diffs
> -
> 
>   doc/kate/rust.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128025/diff/
> 
> 
> Testing
> ---
> 
> valid xml imported into plugins.docbook
> 
> 
> File Attachments
> 
> 
> rust-configuration.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/150c84d6-260e-463a-a059-84a8497b2429__rust-configuration.png
> rust-completion.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/892a0b61-419c-4071-ba20-e72240f572a7__rust-completion.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128025: add sect for rust plugin

[Christoph Cullmann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128025/#review95835
---


Ship it!




Cool, thanks for filling in the missing pieces!

- Christoph Cullmann


On May 26, 2016, 1:51 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128025/
> ---
> 
> (Updated May 26, 2016, 1:51 p.m.)
> 
> 
> Review request for Documentation, Kate and Eike Hein.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sect in this docbook will replace the FIXME rust in plugins.docbook
> new screenshots
> 
> 
> Diffs
> -
> 
>   doc/kate/rust.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128025/diff/
> 
> 
> Testing
> ---
> 
> valid xml imported into plugins.docbook
> 
> 
> File Attachments
> 
> 
> rust-configuration.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/150c84d6-260e-463a-a059-84a8497b2429__rust-configuration.png
> rust-completion.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/892a0b61-419c-4071-ba20-e72240f572a7__rust-completion.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [trojita] src/Gui: GUI: let zooming shortcuts go through ShortcutHandler

[Caspar Schutijser]

Git commit 6fa54e7e2d2cfe5e622187c7b84143e494abb457 by Caspar Schutijser.
Committed on 23/05/2016 at 20:15.
Pushed by gerrit into branch 'master'.

GUI: let zooming shortcuts go through ShortcutHandler

Change-Id: Id0a4add59c5e2fa643c1a895d1f473cfa369f699

M  +4-5src/Gui/MessageView.cpp
M  +5-2src/Gui/Window.cpp

http://commits.kde.org/trojita/6fa54e7e2d2cfe5e622187c7b84143e494abb457

diff --git a/src/Gui/MessageView.cpp b/src/Gui/MessageView.cpp
index 5532b79..3040f96 100644
--- a/src/Gui/MessageView.cpp
+++ b/src/Gui/MessageView.cpp
@@ -62,6 +62,7 @@
 #include "Imap/Model/Utils.h"
 #include "Imap/Network/MsgPartNetAccessManager.h"
 #include "Plugins/PluginManager.h"
+#include "ShortcutHandler/ShortcutHandler.h"
 #include "UiUtils/IconLoader.h"
 
 namespace Gui
@@ -86,17 +87,15 @@ MessageView::MessageView(QWidget *parent, QSettings 
*settings, Plugins::PluginMa
 setFocusPolicy(Qt::StrongFocus); // not by the wheel
 
 
-m_zoomIn = new QAction(UiUtils::loadIcon(QStringLiteral("zoom-in")), 
tr("Zoom In"), this);
-m_zoomIn->setShortcut(QKeySequence::ZoomIn);
+m_zoomIn = 
ShortcutHandler::instance()->createAction(QStringLiteral("action_zoom_in"), 
this);
 addAction(m_zoomIn);
 connect(m_zoomIn, &QAction::triggered, this, &MessageView::zoomIn);
 
-m_zoomOut = new QAction(UiUtils::loadIcon(QStringLiteral("zoom-out")), 
tr("Zoom Out"), this);
-m_zoomOut->setShortcut(QKeySequence::ZoomOut);
+m_zoomOut = 
ShortcutHandler::instance()->createAction(QStringLiteral("action_zoom_out"), 
this);
 addAction(m_zoomOut);
 connect(m_zoomOut, &QAction::triggered, this, &MessageView::zoomOut);
 
-m_zoomOriginal = new 
QAction(UiUtils::loadIcon(QStringLiteral("zoom-original")), tr("Original 
Size"), this);
+m_zoomOriginal = 
ShortcutHandler::instance()->createAction(QStringLiteral("action_zoom_original"),
 this);
 addAction(m_zoomOriginal);
 connect(m_zoomOriginal, &QAction::triggered, this, 
&MessageView::zoomOriginal);
 
diff --git a/src/Gui/Window.cpp b/src/Gui/Window.cpp
index f8d3227..9de36f6 100644
--- a/src/Gui/Window.cpp
+++ b/src/Gui/Window.cpp
@@ -143,13 +143,13 @@ MainWindow::MainWindow(QSettings *settings): 
QMainWindow(), m_imapAccess(0), m_m
 connect(m_imapAccess, &Imap::ImapAccess::cacheError, this, 
&MainWindow::cacheError);
 connect(m_imapAccess, &Imap::ImapAccess::checkSslPolicy, this, 
&MainWindow::checkSslPolicy, Qt::QueuedConnection);
 
-createWidgets();
-
 ShortcutHandler *shortcutHandler = new ShortcutHandler(this);
 shortcutHandler->setSettingsObject(m_settings);
 defineActions();
 shortcutHandler->readSettings(); // must happen after defineActions()
 
+createWidgets();
+
 Imap::migrateSettings(m_settings);
 
 m_senderIdentities = new Composer::SenderIdentitiesModel(this);
@@ -236,6 +236,9 @@ void MainWindow::defineActions()
 shortcutHandler->defineAction(QStringLiteral("action_network_online"), 
QStringLiteral("network-connect"), tr("&Free Access"));
 
shortcutHandler->defineAction(QStringLiteral("action_messagewindow_close"), 
QStringLiteral("window-close"), tr("Close Standalone Message Window"));
 shortcutHandler->defineAction(QStringLiteral("action_oneattime_go_back"), 
QStringLiteral("go-previous"), tr("Navigate Back"), 
QKeySequence(QKeySequence::Back).toString());
+shortcutHandler->defineAction(QStringLiteral("action_zoom_in"), 
QStringLiteral("zoom-in"), tr("Zoom In"), QKeySequence::ZoomIn);
+shortcutHandler->defineAction(QStringLiteral("action_zoom_out"), 
QStringLiteral("zoom-out"), tr("Zoom Out"), QKeySequence::ZoomOut);
+shortcutHandler->defineAction(QStringLiteral("action_zoom_original"), 
QStringLiteral("zoom-original"), tr("Original Size"));
 }
 
 void MainWindow::createActions()

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] Review Request 128025: add sect for rust plugin

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128025/
---

Review request for Documentation, Kate and Eike Hein.


Repository: kate


Description
---

the sect in this docbook will replace the FIXME rust in plugins.docbook
new screenshots


Diffs
-

  doc/kate/rust.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128025/diff/


Testing
---

valid xml imported into plugins.docbook


File Attachments


rust-configuration.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/150c84d6-260e-463a-a059-84a8497b2429__rust-configuration.png
rust-completion.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/26/892a0b61-419c-4071-ba20-e72240f572a7__rust-completion.png


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [trojita] src/Gui: GUI: Enable QWebView's zooming

[Jan Kundrát]

Git commit f3ca4e6f96e905a05ac8313e0ec5b5d2f2095e08 by Jan Kundrát.
Committed on 21/05/2016 at 15:25.
Pushed by gerrit into branch 'master'.

GUI: Enable QWebView's zooming

This is using QWebView's native zooming features. The zooming is
implemented through a context menu and a pait of standard shortcuts.

Thanks to an accessibility report by Dan Miner  over
the ML.

Change-Id: Id9ecc2829782a98209a21b2b1be1f6205a451b31

M  +14   -0src/Gui/EmbeddedWebView.cpp
M  +3-0src/Gui/EmbeddedWebView.h
M  +19   -0src/Gui/SimplePartWidget.cpp
M  +1-0src/Gui/SimplePartWidget.h

http://commits.kde.org/trojita/f3ca4e6f96e905a05ac8313e0ec5b5d2f2095e08

diff --git a/src/Gui/EmbeddedWebView.cpp b/src/Gui/EmbeddedWebView.cpp
index 103849c..283042d 100644
--- a/src/Gui/EmbeddedWebView.cpp
+++ b/src/Gui/EmbeddedWebView.cpp
@@ -234,6 +234,20 @@ void EmbeddedWebView::mouseReleaseEvent(QMouseEvent *e)
 QWebView::mouseReleaseEvent(e);
 }
 
+const auto zoomConstant = 1.1;
+
+void EmbeddedWebView::zoomIn()
+{
+setZoomFactor(zoomFactor() * zoomConstant);
+constrainSize();
+}
+
+void EmbeddedWebView::zoomOut()
+{
+setZoomFactor(zoomFactor() / zoomConstant);
+constrainSize();
+}
+
 void EmbeddedWebView::findScrollParent()
 {
 if (m_scrollParent)
diff --git a/src/Gui/EmbeddedWebView.h b/src/Gui/EmbeddedWebView.h
index 020efe8..2c0b091 100644
--- a/src/Gui/EmbeddedWebView.h
+++ b/src/Gui/EmbeddedWebView.h
@@ -71,6 +71,9 @@ protected:
 void mouseReleaseEvent(QMouseEvent *e);
 void showEvent(QShowEvent *se);
 void addCustomStylesheet(const QString &css);
+protected slots:
+void zoomIn();
+void zoomOut();
 private:
 void findScrollParent();
 private slots:
diff --git a/src/Gui/SimplePartWidget.cpp b/src/Gui/SimplePartWidget.cpp
index 0e562ea..c9b388f 100644
--- a/src/Gui/SimplePartWidget.cpp
+++ b/src/Gui/SimplePartWidget.cpp
@@ -84,6 +84,20 @@ SimplePartWidget::SimplePartWidget(QWidget *parent, 
Imap::Network::MsgPartNetAcc
 connect(m_findAction, &QAction::triggered, this, 
&SimplePartWidget::searchDialogRequested);
 addAction(m_findAction);
 
+m_zoomIn = new QAction(UiUtils::loadIcon(QStringLiteral("zoom-in")), 
tr("Zoom In"), this);
+m_zoomIn->setShortcut(QKeySequence::ZoomIn);
+addAction(m_zoomIn);
+connect(m_zoomIn, &QAction::triggered, this, &SimplePartWidget::zoomIn);
+
+m_zoomOut = new QAction(UiUtils::loadIcon(QStringLiteral("zoom-out")), 
tr("Zoom Out"), this);
+m_zoomOut->setShortcut(QKeySequence::ZoomOut);
+addAction(m_zoomOut);
+connect(m_zoomOut, &QAction::triggered, this, &SimplePartWidget::zoomOut);
+
+m_zoomReset = new 
QAction(UiUtils::loadIcon(QStringLiteral("zoom-original")), tr("Original 
Size"), this);
+addAction(m_zoomReset);
+connect(m_zoomReset, &QAction::triggered, this, [this]() { 
setZoomFactor(1); });
+
 setContextMenuPolicy(Qt::CustomContextMenu);
 
 // It is actually OK to construct this widget without any connection to a 
messageView -- this is often used when
@@ -177,6 +191,11 @@ void SimplePartWidget::buildContextMenu(const QPoint 
&point, QMenu &menu) const
 }
 a->setActionGroup(ag);
 }
+
+auto zoomMenu = menu.addMenu(UiUtils::loadIcon(QStringLiteral("zoom")), 
tr("Zoom"));
+zoomMenu->addAction(m_zoomIn);
+zoomMenu->addAction(m_zoomOut);
+zoomMenu->addAction(m_zoomReset);
 }
 
 void SimplePartWidget::slotDownloadPart()
diff --git a/src/Gui/SimplePartWidget.h b/src/Gui/SimplePartWidget.h
index 9d59a37..7c6f12d 100644
--- a/src/Gui/SimplePartWidget.h
+++ b/src/Gui/SimplePartWidget.h
@@ -74,6 +74,7 @@ private:
 QAction *m_savePart;
 QAction *m_saveMessage;
 QAction *m_findAction;
+QAction *m_zoomIn, *m_zoomOut, *m_zoomReset;
 MessageView *m_messageView;
 Imap::Network::MsgPartNetAccessManager *m_netAccessManager;
 

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [trojita] src/Gui: GUI: Update zoom mode for all parts in sync

[Jan Kundrát]

Git commit 64055232b202328252e3bea28524614968453372 by Jan Kundrát.
Committed on 21/05/2016 at 16:12.
Pushed by gerrit into branch 'master'.

GUI: Update zoom mode for all parts in sync

This is similar to that Ctrl-F shortcut handling -- if we have more than
a single part in an e-mail, multiple actions with the same shortcut are
going to be active, which is a Bad Thing™.

Let's handle this centrally, then. Provisions are still in place for a
possibility of no enclosing MessageView.

Change-Id: I778f479877b830824e0556220ae8d3a0d50819c7

M  +3-0src/Gui/AbstractPartWidget.h
M  +10   -4src/Gui/AttachmentView.cpp
M  +3-0src/Gui/AttachmentView.h
M  +0-28   src/Gui/EmbeddedWebView.cpp
M  +1-5src/Gui/EmbeddedWebView.h
M  +10   -4src/Gui/LoadablePartWidget.cpp
M  +6-3src/Gui/LoadablePartWidget.h
M  +42   -7src/Gui/MessageView.cpp
M  +6-2src/Gui/MessageView.h
M  +30   -19   src/Gui/PartWidget.cpp
M  +19   -7src/Gui/PartWidget.h
M  +37   -17   src/Gui/SimplePartWidget.cpp
M  +6-3src/Gui/SimplePartWidget.h

http://commits.kde.org/trojita/64055232b202328252e3bea28524614968453372

diff --git a/src/Gui/AbstractPartWidget.h b/src/Gui/AbstractPartWidget.h
index e0a1c15..78e1cbd 100644
--- a/src/Gui/AbstractPartWidget.h
+++ b/src/Gui/AbstractPartWidget.h
@@ -34,6 +34,9 @@ public:
 virtual QString quoteMe() const = 0;
 virtual ~AbstractPartWidget() {}
 virtual void reloadContents() = 0;
+virtual void zoomIn() = 0;
+virtual void zoomOut() = 0;
+virtual void zoomOriginal() = 0;
 };
 
 }
diff --git a/src/Gui/AttachmentView.cpp b/src/Gui/AttachmentView.cpp
index dee7ead..10043e9 100644
--- a/src/Gui/AttachmentView.cpp
+++ b/src/Gui/AttachmentView.cpp
@@ -373,12 +373,18 @@ QString AttachmentView::quoteMe() const
 return widget && !m_contentWidget->isHidden() ? widget->quoteMe() : 
QString();
 }
 
-void AttachmentView::reloadContents()
-{
-if (AbstractPartWidget *w = 
dynamic_cast(m_contentWidget))
-w->reloadContents();
+#define IMPL_PART_FORWARD_ONE_METHOD(METHOD) \
+void AttachmentView::METHOD() \
+{\
+if (AbstractPartWidget *w = 
dynamic_cast(m_contentWidget)) \
+w->METHOD(); \
 }
 
+IMPL_PART_FORWARD_ONE_METHOD(reloadContents)
+IMPL_PART_FORWARD_ONE_METHOD(zoomIn)
+IMPL_PART_FORWARD_ONE_METHOD(zoomOut)
+IMPL_PART_FORWARD_ONE_METHOD(zoomOriginal)
+
 void AttachmentView::showMessageSource()
 {
 auto w = MainWindow::messageSourceWidget(m_partIndex);
diff --git a/src/Gui/AttachmentView.h b/src/Gui/AttachmentView.h
index 3abf1d4..1c40441 100644
--- a/src/Gui/AttachmentView.h
+++ b/src/Gui/AttachmentView.h
@@ -61,6 +61,9 @@ public:
MessageView *messageView, QWidget *contentWidget);
 virtual QString quoteMe() const;
 virtual void reloadContents();
+virtual void zoomIn();
+virtual void zoomOut();
+virtual void zoomOriginal();
 protected:
 virtual void mouseMoveEvent(QMouseEvent *event);
 virtual void mousePressEvent(QMouseEvent *event);
diff --git a/src/Gui/EmbeddedWebView.cpp b/src/Gui/EmbeddedWebView.cpp
index 9e0128e..103849c 100644
--- a/src/Gui/EmbeddedWebView.cpp
+++ b/src/Gui/EmbeddedWebView.cpp
@@ -234,34 +234,6 @@ void EmbeddedWebView::mouseReleaseEvent(QMouseEvent *e)
 QWebView::mouseReleaseEvent(e);
 }
 
-void EmbeddedWebView::wheelEvent(QWheelEvent *e)
-{
-if (e->modifiers() == Qt::ControlModifier) {
-if (e->delta() > 0) {
-zoomIn();
-} else {
-zoomOut();
-}
-e->accept();
-} else {
-e->ignore();
-}
-}
-
-const auto zoomConstant = 1.1;
-
-void EmbeddedWebView::zoomIn()
-{
-setZoomFactor(zoomFactor() * zoomConstant);
-constrainSize();
-}
-
-void EmbeddedWebView::zoomOut()
-{
-setZoomFactor(zoomFactor() / zoomConstant);
-constrainSize();
-}
-
 void EmbeddedWebView::findScrollParent()
 {
 if (m_scrollParent)
diff --git a/src/Gui/EmbeddedWebView.h b/src/Gui/EmbeddedWebView.h
index 283a6e9..9ac83d1 100644
--- a/src/Gui/EmbeddedWebView.h
+++ b/src/Gui/EmbeddedWebView.h
@@ -69,19 +69,15 @@ protected:
 bool eventFilter(QObject *o, QEvent *e);
 void mouseMoveEvent(QMouseEvent *e);
 void mouseReleaseEvent(QMouseEvent *e);
-void wheelEvent(QWheelEvent *e);
 void showEvent(QShowEvent *se);
 void addCustomStylesheet(const QString &css);
-protected slots:
-void zoomIn();
-void zoomOut();
+void constrainSize();
 private:
 void findScrollParent();
 private slots:
 void autoScroll();
 void slotLinkClicked(const QUrl &url);
 void handlePageLoadFinished();
-void constrainSize();
 private:
 QWidget *m_scrollParent;
 int m_scrollParentPadding;
diff --git a/src/Gui/LoadablePartWidget.cpp b/src/Gui/LoadablePartWidget.cpp
index 31dce1e..211acb4 100644
--- a/src/Gui/LoadablePartWidget.cpp
+++ b/src/Gui/LoadablePartWidget.cpp
@@ -89,10 +89,16 @@ void LoadablePartWidget::showEvent(QShowEvent *event)
 }
 }
 
-void Lo

[kde-doc-english] [trojita] src/Gui: GUI: Implement message zooming via Ctrl+Wheel scrolling

[Jan Kundrát]

Git commit d3a4b236bfd36052adf437ec3f624b20bea33995 by Jan Kundrát.
Committed on 21/05/2016 at 15:26.
Pushed by gerrit into branch 'master'.

GUI: Implement message zooming via Ctrl+Wheel scrolling

Change-Id: Id1b00c11ed56cb5c273f3d5a6051d1be6236f030

M  +14   -0src/Gui/EmbeddedWebView.cpp
M  +1-0src/Gui/EmbeddedWebView.h
M  +1-1src/Gui/MessageView.cpp

http://commits.kde.org/trojita/d3a4b236bfd36052adf437ec3f624b20bea33995

diff --git a/src/Gui/EmbeddedWebView.cpp b/src/Gui/EmbeddedWebView.cpp
index 283042d..9e0128e 100644
--- a/src/Gui/EmbeddedWebView.cpp
+++ b/src/Gui/EmbeddedWebView.cpp
@@ -234,6 +234,20 @@ void EmbeddedWebView::mouseReleaseEvent(QMouseEvent *e)
 QWebView::mouseReleaseEvent(e);
 }
 
+void EmbeddedWebView::wheelEvent(QWheelEvent *e)
+{
+if (e->modifiers() == Qt::ControlModifier) {
+if (e->delta() > 0) {
+zoomIn();
+} else {
+zoomOut();
+}
+e->accept();
+} else {
+e->ignore();
+}
+}
+
 const auto zoomConstant = 1.1;
 
 void EmbeddedWebView::zoomIn()
diff --git a/src/Gui/EmbeddedWebView.h b/src/Gui/EmbeddedWebView.h
index 2c0b091..283a6e9 100644
--- a/src/Gui/EmbeddedWebView.h
+++ b/src/Gui/EmbeddedWebView.h
@@ -69,6 +69,7 @@ protected:
 bool eventFilter(QObject *o, QEvent *e);
 void mouseMoveEvent(QMouseEvent *e);
 void mouseReleaseEvent(QMouseEvent *e);
+void wheelEvent(QWheelEvent *e);
 void showEvent(QShowEvent *se);
 void addCustomStylesheet(const QString &css);
 protected slots:
diff --git a/src/Gui/MessageView.cpp b/src/Gui/MessageView.cpp
index bac957b..829164c 100644
--- a/src/Gui/MessageView.cpp
+++ b/src/Gui/MessageView.cpp
@@ -302,7 +302,7 @@ void MessageView::stopAutoMarkAsRead()
 
 bool MessageView::eventFilter(QObject *object, QEvent *event)
 {
-if (event->type() == QEvent::Wheel) {
+if (event->type() == QEvent::Wheel && 
static_cast(event)->modifiers() == Qt::NoModifier) {
 // while the containing scrollview has Qt::StrongFocus, the event 
forwarding breaks that
 // -> completely disable focus for the following wheel event ...
 parentWidget()->setFocusPolicy(Qt::NoFocus);

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] [ktuberling] doc: fix typo kde5-config -> kf5-config

[Luigi Toscano]

On Thursday 26 of May 2016 10:37:46 Burkhard Lück wrote:
> Am Donnerstag, 19. Mai 2016, 16:09:42 CEST schrieb Luigi Toscano:
> > In data giovedì 19 maggio 2016 07:12:48, Burkhard Lück ha scritto:
> > > Git commit e449c24b81d30f1f591bb25ae3467235e1265985 by Burkhard Lück.
> > > Committed on 19/05/2016 at 07:12.
> > > Pushed by lueck into branch 'master'.
> > > 
> > > fix typo kde5-config -> kf5-config
> > 
> > On vacation, so I can't answer too much, but kf5-config should not be
> > used,
> > as it is part of kdelibs4support and deprecated. The relevant paths can be
> > retrieved using qtpaths. See also the discussion here:
> > https://git.reviewboard.kde.org/r/124711/
> 
> You are right that kf5-config is part of kdelibs4support and deprecated, but
> using
> ls $(kf5-config --prefix)/share/
> works in distribution + compiled from sources
> 
> Whereas using qtpaths or XDG_DATA* does not work:
> 
> LANG=C ls $(qtpaths --paths GenericDataLocation)
> ls: cannot access '/home/bb/.local/share:/usr/share/usr/share/xsessions/
> plasma:/usr/local/share:/usr/share:/var/lib/snapd/desktop': No such file or
> directory
> 
> LANG=C ls $XDG_DATA_DIRS
> ls: cannot access
> '/usr/share//usr/share/xsessions/plasma:/usr/local/share/:/
> usr/share/:/var/lib/snapd/desktop': No such file or directory

It seems that the semantic is different, and there are multiple values 
returned, so you can't directly do ls on a single. But ask on kde-core-devel 
of kde-frameworks-devel, they will tell you the same: kf5-config should not be 
used, it could be potentially not even available.

-- 
Luigi
___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] [ktuberling] doc: fix typo kde5-config -> kf5-config

[Burkhard Lück]

Am Donnerstag, 19. Mai 2016, 16:09:42 CEST schrieb Luigi Toscano:
> In data giovedì 19 maggio 2016 07:12:48, Burkhard Lück ha scritto:
> > Git commit e449c24b81d30f1f591bb25ae3467235e1265985 by Burkhard Lück.
> > Committed on 19/05/2016 at 07:12.
> > Pushed by lueck into branch 'master'.
> > 
> > fix typo kde5-config -> kf5-config
> 
> On vacation, so I can't answer too much, but kf5-config should not be used,
> as it is part of kdelibs4support and deprecated. The relevant paths can be
> retrieved using qtpaths. See also the discussion here:
> https://git.reviewboard.kde.org/r/124711/
> 
You are right that kf5-config is part of kdelibs4support and deprecated, but 
using
ls $(kf5-config --prefix)/share/ 
works in distribution + compiled from sources

Whereas using qtpaths or XDG_DATA* does not work:

LANG=C ls $(qtpaths --paths GenericDataLocation)
ls: cannot access '/home/bb/.local/share:/usr/share/usr/share/xsessions/
plasma:/usr/local/share:/usr/share:/var/lib/snapd/desktop': No such file or 
directory

LANG=C ls $XDG_DATA_DIRS
ls: cannot access '/usr/share//usr/share/xsessions/plasma:/usr/local/share/:/
usr/share/:/var/lib/snapd/desktop': No such file or directory

-- 
Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128015: add sect for ctags plugin

[Kåre Särs]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128015/#review95807
---


Ship it!




Ship It!

- Kåre Särs


On May 26, 2016, 7:31 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128015/
> ---
> 
> (Updated May 26, 2016, 7:31 a.m.)
> 
> 
> Review request for Documentation, Kate and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sects in this docbook will replace the FIXME ctags in plugins.docbook
> new screenshots, not uploaded
> 
> 
> Diffs
> -
> 
>   doc/kate/ctags.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128015/diff/
> 
> 
> Testing
> ---
> 
> valid xml
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128015: add sect for ctags plugin

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128015/
---

(Updated Mai 26, 2016, 7:31 vorm.)


Review request for Documentation, Kate and Kåre Särs.


Changes
---

fix wrong help call
add hint about shortcuts
fix 'Jump one step back'


Repository: kate


Description
---

the sects in this docbook will replace the FIXME ctags in plugins.docbook
new screenshots, not uploaded


Diffs (updated)
-

  doc/kate/ctags.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128015/diff/


Testing
---

valid xml


Thanks,

Burkhard Lück

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

Re: [kde-doc-english] Review Request 128015: add sect for ctags plugin

[Burkhard Lück]

> On Mai 25, 2016, 7:31 nachm., Kåre Särs wrote:
> > doc/kate/ctags.docbook, line 107
> > 
> >
> > I wonder if it would be good to add the navigation features to project 
> > and then deprecate the CTags plugin...

would make sense from a users pov


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128015/#review95788
---


On Mai 25, 2016, 5:06 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128015/
> ---
> 
> (Updated Mai 25, 2016, 5:06 nachm.)
> 
> 
> Review request for Documentation, Kate and Kåre Särs.
> 
> 
> Repository: kate
> 
> 
> Description
> ---
> 
> the sects in this docbook will replace the FIXME ctags in plugins.docbook
> new screenshots, not uploaded
> 
> 
> Diffs
> -
> 
>   doc/kate/ctags.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128015/diff/
> 
> 
> Testing
> ---
> 
> valid xml
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[kde-doc-english] [kdesvn] doc: fix wrong help call + remove kf5options reference, this is no gui app

[Burkhard Lück]

Git commit 879cfdcf2bba52a765be168c13717b3053719e20 by Burkhard Lück.
Committed on 26/05/2016 at 07:00.
Pushed by lueck into branch 'master'.

fix wrong help call + remove kf5options reference, this is no gui app

M  +1-2doc/man-kdesvnaskpass.1.docbook

http://commits.kde.org/kdesvn/879cfdcf2bba52a765be168c13717b3053719e20

diff --git a/doc/man-kdesvnaskpass.1.docbook b/doc/man-kdesvnaskpass.1.docbook
index 67528d5..c6c065f 100644
--- a/doc/man-kdesvnaskpass.1.docbook
+++ b/doc/man-kdesvnaskpass.1.docbook
@@ -55,9 +55,8 @@
 See Also
 
 Full user documentation is available through the &khelpcenter;. You 
can also enter the &URL;
-help:/kdesvnaskpass directly into &konqueror; or you can 
run `khelpcenter help:/kdesvnaskpass'
+help:/kdesvn directly into &konqueror; or you can run 
`khelpcenter help:/kdesvn'
 from the command-line.
-kf5options(1)
 
 
 
___
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english