Re: Workflow with orig doc on userbase

2019-11-17 Thread Albert Astals Cid
El diumenge, 17 de novembre de 2019, a les 19:23:08 CET, Yuri Chornoivan va 
escriure:
> неділя, 17 листопада 2019 р. 20:09:19 EET Albert Astals Cid написано:
> > El dimarts, 5 de novembre de 2019, a les 11:02:05 CET, dand...@get2net.dk 
> > va 
> escriure:
> > > Hi, I have calligraplan doc on userbase, still very much WIP but it
> > > would be nice to know how things are meant to work to get dco included
> > > in release and updated on docs.kde.org.
> > > 
> > > Since it is WIP, and is likely to be for considerable time, I would like
> > > to know what options I have.
> > 
> > So you want to convert an userbase wiki to docbook?
> > 
> > I guess you want
> > https://userbase.kde.org/How_To_Convert_a_UserBase_Manual_to_Docbook (no
> > idea how up to date or working that is)
> 
> It is up-to-date and working.
> 
> See this thread
> 
> https://userbase.kde.org/User_talk:Danders#Create_version_.28copy.
> 29_of_the_manual_3028
> 
> The docs were converted into DocBook, tested for conversion into PDF, 
> reviewed, and sent to Dag (as the index.docbook file and optimized 
> screenshots).
> 
> Dag wants (for some reason) to put the docs on d.c.o. without putting them 
> into Plan's repo.

Honestly I don't think that's possible or event sensible to do.

Cheers,
  Albert

> 
> Best regards,
> Yuri
> 
> > 
> > Cheers,
> >   Albert
> > 
> > > Cheers, Dag
> 
> 
> 
> 
> 






D25342: Mention all fetch project sources in the documentation

2019-11-17 Thread Aleix Pol Gonzalez
apol accepted this revision.

REPOSITORY
  R32 KDevelop

BRANCH
  392550

REVISION DETAIL
  https://phabricator.kde.org/D25342

To: adrianchavesfernandez, yurchor, apol
Cc: yurchor, kdevelop-devel, kde-doc-english, hmitonneau, christiant, gennad, 
fbampaloukas, glebaccon, domson, antismap, iodelay, alexeymin, skadinna, 
geetamc, Pilzschaf, akshaydeo, surgenight, arrowd


Re: Workflow with orig doc on userbase

2019-11-17 Thread Yuri Chornoivan
неділя, 17 листопада 2019 р. 20:09:19 EET Albert Astals Cid написано:
> El dimarts, 5 de novembre de 2019, a les 11:02:05 CET, dand...@get2net.dk va 
escriure:
> > Hi, I have calligraplan doc on userbase, still very much WIP but it
> > would be nice to know how things are meant to work to get dco included
> > in release and updated on docs.kde.org.
> > 
> > Since it is WIP, and is likely to be for considerable time, I would like
> > to know what options I have.
> 
> So you want to convert an userbase wiki to docbook?
> 
> I guess you want
> https://userbase.kde.org/How_To_Convert_a_UserBase_Manual_to_Docbook (no
> idea how up to date or working that is)

It is up-to-date and working.

See this thread

https://userbase.kde.org/User_talk:Danders#Create_version_.28copy.
29_of_the_manual_3028

The docs were converted into DocBook, tested for conversion into PDF, 
reviewed, and sent to Dag (as the index.docbook file and optimized 
screenshots).

Dag wants (for some reason) to put the docs on d.c.o. without putting them 
into Plan's repo.

Best regards,
Yuri

> 
> Cheers,
>   Albert
> 
> > Cheers, Dag






Re: Workflow with orig doc on userbase

2019-11-17 Thread Albert Astals Cid
El dimarts, 5 de novembre de 2019, a les 11:02:05 CET, dand...@get2net.dk va 
escriure:
> Hi, I have calligraplan doc on userbase, still very much WIP but it 
> would be nice to know how things are meant to work to get dco included 
> in release and updated on docs.kde.org.
> 
> Since it is WIP, and is likely to be for considerable time, I would like 
> to know what options I have.

So you want to convert an userbase wiki to docbook?

I guess you want 
https://userbase.kde.org/How_To_Convert_a_UserBase_Manual_to_Docbook (no idea 
how up to date or working that is)

Cheers,
  Albert

> 
> Cheers, Dag
> 






D25085: improve Reconciliation doc

2019-11-17 Thread Stephane Mankowski
smankowski closed this revision.

REPOSITORY
  R469 Skrooge

REVISION DETAIL
  https://phabricator.kde.org/D25085

To: spage, #skrooge, yurchor, smankowski
Cc: smankowski, yurchor, kde-doc-english, gennad, jdb314, fbampaloukas, 
skadinna, scheirle


D25085: improve Reconciliation doc

2019-11-17 Thread Stephane Mankowski
smankowski accepted this revision.
smankowski added a comment.


  I did the commit. Thank you for your contribution.

REPOSITORY
  R469 Skrooge

BRANCH
  arcpatch-D25085

REVISION DETAIL
  https://phabricator.kde.org/D25085

To: spage, #skrooge, yurchor, smankowski
Cc: smankowski, yurchor, kde-doc-english, gennad, jdb314, fbampaloukas, 
skadinna, scheirle


[skrooge] doc: improve Reconciliation doc

2019-11-17 Thread Stephane MANKOWSKI
Git commit f525111c20c8f30b4e7e7f7dbdc33d12d62f1026 by Stephane MANKOWSKI.
Committed on 17/11/2019 at 17:56.
Pushed by smankowski into branch 'master'.

improve Reconciliation doc
BUG:D25085

M  +11   -11   doc/index.docbook

https://commits.kde.org/skrooge/f525111c20c8f30b4e7e7f7dbdc33d12d62f1026

diff --git a/doc/index.docbook b/doc/index.docbook
index e81b98b15..1f32e5faa 100644
--- a/doc/index.docbook
+++ b/doc/index.docbook
@@ -713,7 +713,7 @@
   
CSV Specificities
Since CSV has no strictly defined format, there is no way for 
 to know where it is supposed to find dates, categories, values... To 
do so,  expects your CSV file to contain some headers indicating what 
is the column for. The file must contain at least columns "Date" and 
"Amount".
-   You may manually define how the file is set up ( ignoring the headers in 
the file) by setting them in the application settings 
(Settings Configure 
), in the Import / 
Export section.
+   You may manually define how the file is set up ( ignoring the headers in 
the file) by setting them in the application's settings (Settings Configure 
), in the Import / 
Export section.
   
   
   
@@ -1519,8 +1519,8 @@ file is opened. It is also recommended to create a 
different account ( "ETF"
   
   
Reconciliation
-   Reconciliation is the process by which you ensure that all 
operations are aligned with your account's position from the bank point of 
view. It will involve you, your account's position, and a pen. Reconciliation 
can happen only for an account at one point in time.
-   In the operation view, select the account you wish to 
reconciliate from the drop down box. Switch into reconciliation mode using the 
Switch Information button  below the 
operations table.
+   Reconciliation is the process by which you ensure that all 
operations in an account match the bank's view of that account. It will involve 
you, your account's position, and a pen. Reconciliation can happen only for an 
account at one point in time.
+   First, enter all the operations for the account up to that point 
in time; if you can, download transactions from the bank and import them into  to minimize data entry. 
Then, in the Operations view, select the account you wish to reconcile from the 
drop-down box; or in the Accounts view, double-click the account name or bring 
up the contextual menu and choose Open 
operations Switch into reconciliation mode using the 
Switch Information button  below the 
operations table.


  
@@ -1529,22 +1529,22 @@ file is opened. It is also recommended to create a 
different account ( "ETF"
  


-   Enter the position of your account as provided by your bank in 
the dedicated field. Now, you can proceed to checking in  every 
operation that appears on the account recordings. For the moment, the check box 
for this operation will appear half greyed, until you really validate the 
reconciliation.
+   Enter the position of your account as provided by your bank in 
the dedicated field. Now, you can proceed to pointing in  every 
operation that appears in the bank's statement: you can either click on its 
checkbox in the status column or bring up the contextual menu and choose 
Point. The check box for this operation will appear 
part filled, until you complete reconciliation.

-   As you check operations, you will see  display in the 
information zone:
+   As you point operations, you will see  display in the 
information zone:

- Delta: the difference between the previously entered 
account position and the sum of all checked operations
- Expenditure:the total amount of 
expenses
- Income: the total amount of incomes
+ Delta: the difference between the previously entered 
account position and the sum of all checked 
operations
+ Expenditure:the total amount of Pointed 
debits
+ Income: the total amount of Pointed 
credits


-   This may be useful when trying to spot operations you may have 
forgot to enter in . When all relevant operations have been checked, 
Delta is equal to 0, and the Validate checked operations button 
 is activated. Click on this 
button to validate the reconciliation: all checked operations are now 
validated.
+   These running totals help you spot operations you may have 
forgotten to enter in . Many bank statements provide similar totals 
such as "Withdrawals" or "Deposits and Credits", although they may have 
separate totals for "Interest", "Fees". When the Delta is equal to 0, you 
may have pointed all operations matching the bank's 
record. For example, you may have mistakenly pointed a debit of 8€ and a credit 
of 2€, and overlooked a bank debit of 6€; the net is the same, minus 6€. When 
the Delta is 0, the Validate pointed operations button 
 is enabled. Click on this 
button to complete your 

D22594: [Dolphin] Open Preferred Search Tool action

2019-11-17 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes.
Closed by commit R318:537dc7864ae3: [Dolphin] Open Preferred Search Tool action 
(authored by pdabrowski, committed by elvisangelaccio).

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22594?vs=69855=69884

REVISION DETAIL
  https://phabricator.kde.org/D22594

AFFECTED FILES
  doc/index.docbook
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphinpart.cpp
  src/dolphinpart.h
  src/dolphinui.rc

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov


[dolphin] /: [Dolphin] Open Preferred Search Tool action

2019-11-17 Thread Elvis Angelaccio
Git commit 537dc7864ae31e7c1c9a0a0ecf559b7cace23a82 by Elvis Angelaccio, on 
behalf of Piotr Henryk Dabrowski.
Committed on 17/11/2019 at 17:15.
Pushed by elvisangelaccio into branch 'master'.

[Dolphin] Open Preferred Search Tool action

Summary:
Added "Open Preferred Search Tool" action to Tools menu.

It runs preferred (topmost) external search tool as configured in the "More 
Search Tools" menu.

By default Ctrl+Shift+F shortcut is assigned to this action.

FEATURE: 384798
FIXED-IN: 20.03.80

{F7134238}
{F7134240}
{F7134242}

Reviewers: #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham

Subscribers: pkloc, kfm-devel, kde-doc-english

Tags: #dolphin, #documentation

Differential Revision: https://phabricator.kde.org/D22594

M  +11   -0doc/index.docbook
M  +90   -9src/dolphinmainwindow.cpp
M  +22   -0src/dolphinmainwindow.h
M  +11   -1src/dolphinpart.cpp
M  +1-1src/dolphinpart.h
M  +2-1src/dolphinui.rc

https://commits.kde.org/dolphin/537dc7864ae31e7c1c9a0a0ecf559b7cace23a82

diff --git a/doc/index.docbook b/doc/index.docbook
index d2c06c6a02..71ac3cfc20 100644
--- a/doc/index.docbook
+++ b/doc/index.docbook
@@ -2018,6 +2018,17 @@ for this action.
 Opens  within the current 
folder.
 
 
+
+
+
+F
+
+Tools
+Open Preferred Search Tool
+
+Opens preferred search tool in the current 
folder.
+
+
 
 
 Tools
diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index e28b18cd3d..e615fbab8a 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -57,6 +57,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -197,6 +198,8 @@ DolphinMainWindow::DolphinMainWindow() :
 toolBar()->installEventFilter(middleClickEventFilter);
 
 setupWhatsThis();
+
+QTimer::singleShot(0, this, 
::setupUpdateOpenPreferredSearchToolAction);
 }
 
 DolphinMainWindow::~DolphinMainWindow()
@@ -933,23 +936,88 @@ void DolphinMainWindow::toggleShowMenuBar()
 }
 }
 
-void DolphinMainWindow::openTerminal()
+QString DolphinMainWindow::activeContainerLocalPath()
 {
-QString dir(QDir::homePath());
-
-// If the given directory is not local, it can still be the URL of an
-// ioslave using UDS_LOCAL_PATH which to be converted first.
 KIO::StatJob* statJob = KIO::mostLocalUrl(m_activeViewContainer->url());
 KJobWidgets::setWindow(statJob, this);
 statJob->exec();
 QUrl url = statJob->mostLocalUrl();
-
-//If the URL is local after the above conversion, set the directory.
 if (url.isLocalFile()) {
-dir = url.toLocalFile();
+return url.toLocalFile();
+}
+return QDir::homePath();
+}
+
+QPointer DolphinMainWindow::preferredSearchTool()
+{
+m_searchTools.clear();
+KMoreToolsMenuFactory("dolphin/search-tools").fillMenuFromGroupingNames(
+_searchTools, { "files-find" }, 
QUrl::fromLocalFile(activeContainerLocalPath())
+);
+QList actions = m_searchTools.actions();
+if (actions.isEmpty()) {
+return nullptr;
+}
+QAction* action = actions.first();
+if (action->isSeparator()) {
+return nullptr;
+}
+return action;
+}
+
+void DolphinMainWindow::setupUpdateOpenPreferredSearchToolAction()
+{
+QAction* openPreferredSearchTool = 
actionCollection()->action(QStringLiteral("open_preferred_search_tool"));
+const QList widgets = 
openPreferredSearchTool->associatedWidgets();
+for (QWidget* widget : widgets) {
+QMenu* menu = qobject_cast(widget);
+if (menu) {
+connect(menu, ::aboutToShow, this, 
::updateOpenPreferredSearchToolAction);
+}
 }
 
-KToolInvocation::invokeTerminal(QString(), dir);
+// Update the open_preferred_search_tool action *before* the Configure 
Shortcuts window is shown,
+// since this action is then listed in that window and it should be 
up-to-date when it is displayed.
+// This update is instantaneous if user made no changes to the search 
tools in the meantime.
+// Maybe all KStandardActions should defer calls to their slots, so that 
we could simply connect() to trigger()?
+connect(
+
actionCollection()->action(KStandardAction::name(KStandardAction::KeyBindings)),
 ::hovered,
+this, ::updateOpenPreferredSearchToolAction
+);
+
+updateOpenPreferredSearchToolAction();
+}
+
+void DolphinMainWindow::updateOpenPreferredSearchToolAction()
+{
+QAction* openPreferredSearchTool = 
actionCollection()->action(QStringLiteral("open_preferred_search_tool"));
+if (!openPreferredSearchTool) {
+return;
+}
+QPointer tool = preferredSearchTool();
+if (tool) {
+openPreferredSearchTool->setVisible(true);
+openPreferredSearchTool->setText(i18nc("@action:inmenu Tools", "Open 
%1", tool->text()));
+openPreferredSearchTool->setIcon(tool->icon());
+} else {
+openPreferredSearchTool->setVisible(false);
+// still visible in Shortcuts configuration window
+

D22594: [Dolphin] Open Preferred Search Tool action

2019-11-17 Thread Elvis Angelaccio
elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov


D22594: [Dolphin] Open Preferred Search Tool action

2019-11-17 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  Okay, that makes sense.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov


D22594: [Dolphin] Open Preferred Search Tool action

2019-11-17 Thread Nathaniel Graham
ngraham added a comment.


  @elvisangelaccio, all good now?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov


D22594: [Dolphin] Open Preferred Search Tool action

2019-11-17 Thread Piotr Dabrowski
pdabrowski added inline comments.

INLINE COMMENTS

> ngraham wrote in dolphinmainwindow.cpp:1162
> Since this patch was made, we've re-organized the hamburger menu a bit to 
> simplify it and hide not-commonly-used functionality. I think this feature 
> counts, since it's an alternative to the built-in search, and as such, it 
> won't be useful for the majority of Dolphin's users who use the built-in 
> search instead. Could you remove it from the hamburger menu?

One more thing to consider: no alternative tool (including KFind) is installed 
by default (at least in Kubuntu and KDE Neon). So by default this action will 
not appear at all.
And if user chooses to manually install KFind or another alternative, then they 
may expect to have it easily accessible from this menu.
What do you think?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov


D25085: improve Reconciliation doc

2019-11-17 Thread Yuri Chornoivan
yurchor accepted this revision.

REPOSITORY
  R469 Skrooge

BRANCH
  arcpatch-D25085

REVISION DETAIL
  https://phabricator.kde.org/D25085

To: spage, #skrooge, yurchor
Cc: yurchor, kde-doc-english, gennad, jdb314, fbampaloukas, skadinna, scheirle, 
smankowski


D25085: improve Reconciliation doc

2019-11-17 Thread S Page
spage updated this revision to Diff 69870.
spage added a comment.


  - address yurchor's doc comments in Differential

REPOSITORY
  R469 Skrooge

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25085?vs=69084=69870

BRANCH
  arcpatch-D25085

REVISION DETAIL
  https://phabricator.kde.org/D25085

AFFECTED FILES
  doc/index.docbook

To: spage, #skrooge, yurchor
Cc: yurchor, kde-doc-english, gennad, jdb314, fbampaloukas, skadinna, scheirle, 
smankowski


D22594: [Dolphin] Open Preferred Search Tool action

2019-11-17 Thread Piotr Dabrowski
pdabrowski added inline comments.

INLINE COMMENTS

> ngraham wrote in dolphinmainwindow.cpp:1162
> Since this patch was made, we've re-organized the hamburger menu a bit to 
> simplify it and hide not-commonly-used functionality. I think this feature 
> counts, since it's an alternative to the built-in search, and as such, it 
> won't be useful for the majority of Dolphin's users who use the built-in 
> search instead. Could you remove it from the hamburger menu?

I've added this action everywhere where "Open Terminal" appeared. If you say 
the hamburger menu should not contain it though, I will remove it from there.
My only concern is that it will be hard for users to notice that it become 
available as optional toolbar button or direct shortcut. Even if someone 
anticipated this feature, they may easily miss it and continue not to use it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: pkloc, kfm-devel, kde-doc-english, pberestov, iasensio, fprice, gennad, 
MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, skadinna, emmanuelp, mikesomov