D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-30 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R40:25879726e1ff: Improve the discoverability of the Filter 
Text plugin and its menu item (authored by ngraham).

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14390?vs=38536=38812

REVISION DETAIL
  https://phabricator.kde.org/D14390

AFFECTED FILES
  addons/textfilter/plugin_katetextfilter.cpp
  addons/textfilter/textfilterplugin.desktop
  doc/kate/plugins.docbook

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann


D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-29 Thread Christoph Cullmann
cullmann accepted this revision.

REPOSITORY
  R40 Kate

BRANCH
  make-filter-text-plugin-more-discoverable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14390

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann


D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-29 Thread Christoph Cullmann
cullmann added a comment.


  Ok with me, too.
  A command for F7 would be nice.

REPOSITORY
  R40 Kate

BRANCH
  make-filter-text-plugin-more-discoverable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14390

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann


D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-28 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Ok with me.
  
  BTW, has the text filter plug-in also have a command line command (F7)?

REPOSITORY
  R40 Kate

BRANCH
  make-filter-text-plugin-more-discoverable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14390

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann


D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-28 Thread Nathaniel Graham
ngraham added a comment.


  All good now?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D14390

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann


D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-26 Thread Nathaniel Graham
ngraham marked an inline comment as done.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D14390

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann


D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-26 Thread Dominik Haumann
dhaumann added inline comments.

INLINE COMMENTS

> plugins.docbook:2884
> +The selection will be used as input for the command, and the output will 
> either
> +replace the selection or copied to the clipboard, depending on the user's 
> preference.
>  

...be copied... I think a be is missing here.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D14390

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann


D14390: Improve the discoverability of the Filter Text plugin and its menu item

2018-07-26 Thread Nathaniel Graham
ngraham updated this revision to Diff 38511.
ngraham edited the test plan for this revision.
ngraham added a comment.
Restricted Application added a project: Documentation.
Restricted Application added a subscriber: kde-doc-english.


  Update docbook accordingly

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14390?vs=38467=38511

BRANCH
  make-filter-text-plugin-more-discoverable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14390

AFFECTED FILES
  addons/textfilter/plugin_katetextfilter.cpp
  addons/textfilter/textfilterplugin.desktop
  doc/kate/plugins.docbook

To: ngraham, #kate, dhaumann, cullmann
Cc: kde-doc-english, lueck, kwrite-devel, michaelh, kevinapavew, ngraham, 
demsking, skadinna, cullmann, sars, dhaumann