D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-21 Thread Pino Toscano
pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  In D17649#380233 , @habacker wrote:
  
  > On opensuse there are the cross compile helper packages
  >
  > mingw32-cross-kde4-tools
  > mingw32-cross-kf5-tools
  >
  > both containing docbookl10nhelper and nothing prevents them from been 
installed in parallel
  
  
  Nothing says that both must be installed at the same time. Just add conflicts 
to these packages against each other, so it is clearly marked that they are not 
coinstallable.
  Furthermore, as already mentioned in D17650: Install kioslave as kioslave5 on 
Windows , just focus the efforts on KF5 
stuff, instead of wasting work to make umbrello & alkimia dual Qt4/Qt5, and 
adding more features to a stable Qt4 branch (4.8) of kmymoney.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker, pino
Cc: pino, ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, 
bruns, skadinna


D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-20 Thread Ralf Habacker
habacker added a comment.


  On opensuse there are the cross compile helper packages
  
  mingw32-cross-kde4-tools
  mingw32-cross-kf5-tools
  
  both containing docbookl10nhelper and nothing prevents them from been 
installed in parallel

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, 
skadinna


D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-18 Thread Ralf Habacker
habacker added a comment.


  In D17649#378737 , @ltoscano wrote:
  
  > The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is 
exported), and in general it should not exist in the same build root of its 
kdelibs 4.x counterpart.
  
  
  This tools is required for cross compiling kdoctools 
https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win64:KF547/mingw64-kdoctools
 and therefore installed. obs has KDE4 and KF5 packages side by side

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, 
skadinna


D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-18 Thread Luigi Toscano
ltoscano added a comment.


  The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is 
exported), and in general it should not exist in the same build root of its 
kdelibs 4.x counterpart.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D17649

To: habacker
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, 
skadinna


D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-18 Thread Ralf Habacker
habacker created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  FIXED-IN:5.54
  BUG:373928

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17649

AFFECTED FILES
  src/CMakeLists.txt

To: habacker
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna