D27404: Hide empty top-level menu items

2020-03-04 Thread Yuri Chornoivan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R125:4bb32e2da884: Hide empty top-level menu items (authored 
by alnikiforov, committed by yurchor).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27404?vs=75694=76960#toc

REPOSITORY
  R125 KHelpCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27404?vs=75694=76960

REVISION DETAIL
  https://phabricator.kde.org/D27404

AFFECTED FILES
  navigator.cpp

To: alnikiforov, yurchor, mlaurent, ltoscano
Cc: kde-doc-english, gennad, fbampaloukas, skadinna

D27404: Hide empty top-level menu items

2020-02-18 Thread Laurent Montel 
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  seems ok for me

REPOSITORY
  R125 KHelpCenter

REVISION DETAIL
  https://phabricator.kde.org/D27404

To: alnikiforov, yurchor, mlaurent, ltoscano
Cc: kde-doc-english, gennad, fbampaloukas, skadinna

D27404: Hide empty top-level menu items

2020-02-18 Thread Aleksei Nikiforov 
alnikiforov added a comment.


  Could you please take a look at this change as well?

REPOSITORY
  R125 KHelpCenter

REVISION DETAIL
  https://phabricator.kde.org/D27404

To: alnikiforov, yurchor, mlaurent, ltoscano
Cc: kde-doc-english, gennad, fbampaloukas, skadinna

D27404: Hide empty top-level menu items

2020-02-14 Thread Aleksei Nikiforov 
alnikiforov added a comment.


  Here's how empty "Other Settings Modules" looks when selected:
  
  F8103780: Screenshot_20200214_162537_1.png 


REPOSITORY
  R125 KHelpCenter

REVISION DETAIL
  https://phabricator.kde.org/D27404

To: alnikiforov, yurchor, mlaurent, ltoscano
Cc: kde-doc-english, gennad, fbampaloukas, skadinna

D27404: Hide empty top-level menu items

2020-02-14 Thread Aleksei Nikiforov 
alnikiforov created this revision.
alnikiforov added reviewers: yurchor, mlaurent, ltoscano.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.
alnikiforov requested review of this revision.

REVISION SUMMARY
  If there's no data, it looks like it's bugged. Let's hide it in such case.
  
  Similar to: D27403 

TEST PLAN
  1. Start khelpcenter
  2. Open every top level menu item
  3. Every top level item shouldn't be empty
  
  For me, top level items "Konqueror Settings Modules" and "Other Settings 
Modules" are empty. With this change they'd be hidden instead.

REPOSITORY
  R125 KHelpCenter

REVISION DETAIL
  https://phabricator.kde.org/D27404

AFFECTED FILES
  khelpcenter/navigator.cpp

To: alnikiforov, yurchor, mlaurent, ltoscano
Cc: kde-doc-english, gennad, fbampaloukas, skadinna