[kde-doc-english] [trojita] src/Gui: GUI: use a fallback MIME icon if the exact one cannot be found
Git commit 2258f9759ce3fd34dc88d81ebbbd5e3db18eb67a by Jan Kundr?t.
Committed on 19/08/2013 at 18:32.
Pushed by jkt into branch 'master'.
GUI: use a fallback MIME icon if the exact one cannot be found
This is even described in the QMimeType's docs -- not sure how come that I
missed this when implementing this the first time.
REVIEW: 112166
M +3-1src/Gui/AttachmentView.cpp
http://commits.kde.org/trojita/2258f9759ce3fd34dc88d81ebbbd5e3db18eb67a
diff --git a/src/Gui/AttachmentView.cpp b/src/Gui/AttachmentView.cpp
index f7259b4..987727c 100644
--- a/src/Gui/AttachmentView.cpp
+++ b/src/Gui/AttachmentView.cpp
@@ -73,7 +73,9 @@ AttachmentView::AttachmentView(QWidget *parent,
Imap::Network::MsgPartNetAccessM
QMimeType mimeType = QMimeDatabase().mimeTypeForName(mimeDescription);
if (mimeType.isValid() && !mimeType.isDefault()) {
mimeDescription = mimeType.comment();
-QIcon icon = QIcon::fromTheme(mimeType.iconName(),
loadIcon(QLatin1String("mail-attachment")));
+QIcon icon = QIcon::fromTheme(mimeType.iconName(),
+
QIcon::fromTheme(mimeType.genericIconName(),
loadIcon(QLatin1String("mail-attachment")))
+ );
lbl->setPixmap(icon.pixmap(iconSize));
} else {
lbl->setPixmap(loadIcon(QLatin1String("mail-attachment")).pixmap(iconSize));
[kde-doc-english] [trojita] src: GUI: update mailbox contents whenever clicking through messages or mailboxes
Git commit 0671e1af3432957839d1556fade9389141daf37b by Jan Kundr?t.
Committed on 19/08/2013 at 14:40.
Pushed by jkt into branch 'master'.
GUI: update mailbox contents whenever clicking through messages or mailboxes
The IMAP code is currently multiplexing a single connection among many
mailboxes. There are situations where a parallel action might switch away from
the "currently selected" mailbox, at least as shown in the UI, to some other
place. An example of such action is when the composer wants to make a message
with the \Answered flag.
Typically, the mailbox is automatically switched when the user opens a message
--
either because of the request to have it marked as read, or because some of the
parts are not available form the cache. However, if the message being opened was
already cached and marked as read, no IMAP traffic was actually required, and
therefore there was no reason for issuing a SELECT, either.
This might or might not be the best fix -- from the user's point of view, it
makes a lot of sense to receive updates about mailbox state as often as
possible, and having the mailbox opened (with the usual IDLE or NOP polling) is
the usual way to go. On the other hand, this might result in slightly bigger
IMAP traffic, especially on servers which do not support CONDSTORE/QRESYNC.
The ideal fix for the future is to switch to multiple connections, but that
opens a whole new can of worms. In the meanwhile, let's just fulfil the naive
expectation that clicking on any message in a mailbox (or any mailbox, for that
matter) will at least refresh the current view.
REVIEW: 112158
M +6-2src/Gui/Window.cpp
M +5-2src/Imap/Model/MsgListModel.cpp
http://commits.kde.org/trojita/0671e1af3432957839d1556fade9389141daf37b
diff --git a/src/Gui/Window.cpp b/src/Gui/Window.cpp
index 8ff0074..093c8e6 100644
--- a/src/Gui/Window.cpp
+++ b/src/Gui/Window.cpp
@@ -908,9 +908,13 @@ void MainWindow::msgListClicked(const QModelIndex &index)
// Be sure to update the toolbar/actions with the state of the current
message
updateMessageFlags();
+// Because it's quite possible that we have switched into another mailbox,
make sure that we're in the "current" one so that
+// user will be notified about new arrivals, etc.
+QModelIndex translated;
+Imap::Mailbox::Model::realTreeItem(index, 0, &translated);
+model->switchToMailbox(translated.parent().parent());
+
if (index.column() == Imap::Mailbox::MsgListModel::SEEN) {
-QModelIndex translated;
-Imap::Mailbox::Model::realTreeItem(index, 0, &translated);
if (!translated.data(Imap::Mailbox::RoleIsFetched).toBool())
return;
Imap::Mailbox::FlagsOperation flagOp =
translated.data(Imap::Mailbox::RoleMessageIsMarkedRead).toBool() ?
diff --git a/src/Imap/Model/MsgListModel.cpp b/src/Imap/Model/MsgListModel.cpp
index f5b4c72..9b8a80f 100644
--- a/src/Imap/Model/MsgListModel.cpp
+++ b/src/Imap/Model/MsgListModel.cpp
@@ -484,9 +484,12 @@ void MsgListModel::setMailbox(const QModelIndex &index)
msgListPtr->resetWasUnreadState();
RESET_MODEL;
emit mailboxChanged(index);
-// We want to tell the Model that it should consider starting the IDLE
command.
-const_cast(model)->switchToMailbox(index);
}
+
+// We want to tell the Model that it should consider starting the IDLE
command.
+// This shall happen regardless on what this model's idea about a "current
mailbox" is because the IMAP connection might have
+// switched to another mailbox behind the scenes.
+const_cast(model)->switchToMailbox(index);
}
/** @short Change mailbox to the one specified by its name */
[kde-doc-english] Entity 'Scarlett.Clark.mail' not defined
On Wednesday, August 21, 2013 01:27:35 PM you wrote: > Hi Scarlett, > > I hope that you had nice vacations! :) > > On Tuesday 20 August 2013 11:02:54 Scarlett Clark wrote: > > That ENTITY is defined in: > > kdelibs/kdoctools/customization/entities/contributor.entities:91: > Scarlett.Clark.mail 'scarlett at scarlettgatelyclark.com'> > > I have kdelibs 4.10.5 installed which normally works and is completely fine > for the build process. > > > Maybe you need to build kdelibs? Sorry I am not an expert, so this is only > > a guess. I have not had any issues with the build though. > > You probably have a more recent kdelibs. But please don't not introduce > dependencies to new kdelibs versions if not really necessary. And if > necessary that dependency should be reflected in the CMake scripts. > > Maybe we should take this to the list? Good idea :) I do not do anything with kdelibs. > > Kind Regards, > Torsten
[kde-doc-english] Entity 'Scarlett.Clark.mail' not defined
Am Mittwoch, 21. August 2013, 05:48:40 schrieb Scarlett Clark: > On Wednesday, August 21, 2013 01:27:35 PM Torsten Grote: > > Hi Scarlett, > > > > I hope that you had nice vacations! :) > > > > On Tuesday 20 August 2013 11:02:54 Scarlett Clark wrote: > > > That ENTITY is defined in: > > > kdelibs/kdoctools/customization/entities/contributor.entities:91: > > Y > > > Scarlett.Clark.mail 'scarlett at scarlettgatelyclark.com'> > > > > I have kdelibs 4.10.5 installed which normally works and is completely > > fine for the build process. > > > > > Maybe you need to build kdelibs? Sorry I am not an expert, so this is > > > only a guess. I have not had any issues with the build though. > > > > You probably have a more recent kdelibs. But please don't not introduce > > dependencies to new kdelibs versions if not really necessary. And if > > necessary that dependency should be reflected in the CMake scripts. > > > > Maybe we should take this to the list? > The entity "Scarlett.Clark.mail" is defined twice, once in the header of kmail/index.docbook and second in kdelibs since 4.11.0 KDEPim docbooks with this entity (so far only kmail/*docbooks + the new kmailcvt/index.docbook) are only valid for kdepim >= 4.11.0, not for kdepim 4.10.x This is no new dependency, you simply can not build kdepim 4.11 with kdelibs 4.10. Building documentation from kde x.y with a kdelibs
[kde-doc-english] Review Request 112194: Documentation: Menus, Composer settings and edit menus. Improvement to Fundamentals links.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112194/ --- Review request for Documentation, KDEPIM and Laurent Montel. Description --- Updated Edit and Settings menus, added link to Help fundamentals. Moved all Fundamental links to appropriate menu documentation, we cannot assume users will read the Menus documentation from the beginning. Diffs - doc/kmail/menus.docbook 4e487e1 Diff: http://git.reviewboard.kde.org/r/112194/diff/ Testing --- EBN, checkXML, meinproc4 khelpcenter preview. Thanks, Scarlett Clark -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20130821/3451e0d2/attachment.html>
[kde-doc-english] Help
Wed, 21 Aug 2013 20:09:09 +0300, : > How do I establish an account to get help to learn to use KDE? > Two days ago I thought I established an account with name = * > and email address = aa0pmail at gmail.com > and password = *. > > Today when I try to log in with above name and password > the next window states " * is not known" (something to that effect) > When I ask for new password to be sent to "aa0pmail#@gmail.com" > the next window states "that email address is already taken" > > There seems to be a catch22 there. > How do I establish an account to get help to learn to use KDE? > > Thank you, > Steve Hi, Sorry, but this is public mailing list. I discarded your message to keep your login and password private. Can you share some information about where you have registered (please do not send passwords anymore)? Was it KDE forum on forum.kde.org, UserBase wiki, kubuntu forum or just this mailing list? Best regards, Yuri
[kde-doc-english] Review Request 112194: Documentation: Menus, Composer settings and edit menus. Improvement to Fundamentals links.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112194/#review38294 --- Ship it! doc/kmail/menus.docbook <http://git.reviewboard.kde.org/r/112194/#comment28312> should be replaced with link to Help Menu of the &kde; Fundamentals doc/kmail/menus.docbook <http://git.reviewboard.kde.org/r/112194/#comment28319> This is "Rich Text Editing" in 4.11 doc/kmail/menus.docbook <http://git.reviewboard.kde.org/r/112194/#comment28313> should be replaced with link to Help Menu of the &kde; Fundamentals - Burkhard L?ck On Aug. 21, 2013, 5:22 p.m., Scarlett Clark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112194/ > --- > > (Updated Aug. 21, 2013, 5:22 p.m.) > > > Review request for Documentation, KDEPIM and Laurent Montel. > > > Description > --- > > Updated Edit and Settings menus, added link to Help fundamentals. Moved all > Fundamental links to appropriate menu documentation, we cannot assume users > will read the Menus documentation from the beginning. > > > Diffs > - > > doc/kmail/menus.docbook 4e487e1 > > Diff: http://git.reviewboard.kde.org/r/112194/diff/ > > > Testing > --- > > EBN, checkXML, meinproc4 khelpcenter preview. > > > Thanks, > > Scarlett Clark > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20130821/31fb0b32/attachment.html>
[kde-doc-english] [kdepim] doc/kmail: Documentation: Menus, Composer settings and edit menus. Improvement to Fundamentals links.
Git commit cf416240740f88de945635b0be39766d706cac3d by Scarlett Clark. Committed on 21/08/2013 at 19:18. Pushed by scarlettclark into branch 'master'. Documentation: Menus, Composer settings and edit menus. Improvement to Fundamentals links. REVIEW:112194 M +88 -286 doc/kmail/menus.docbook http://commits.kde.org/kdepim/cf416240740f88de945635b0be39766d706cac3d diff --git a/doc/kmail/menus.docbook b/doc/kmail/menus.docbook index 4e487e1..2b7483c 100644 --- a/doc/kmail/menus.docbook +++ b/doc/kmail/menus.docbook @@ -45,17 +45,11 @@ Command and Menu Reference - - &kmail; has common &kde; Edit, Settings, and -Help menu items, for more information read the sections about the Edit Menu, Settings Menu, and Help Menu -of the &kde; Fundamentals. - Each &kmail; specific menu item is discussed below. When there is a keyboard shortcut that performs a menu item function, the default shortcut is listed with the menu item. - -The Main &kmail; Reader Window + +The &kmail; Reader Window File Menu @@ -259,7 +253,8 @@ This allows you to choose which server to send your queued messages from. They m Edit Menu - +If the menu item you are looking for is missing, please see Edit Menu of the &kde; Fundamentals. + The items listed here are &kmail; specific. @@ -1180,14 +1175,14 @@ Please see next section for details. Brings up the Export Data Wizard dialog which assists in easily exporting your settings and email. Please see Export &kmail; Data for details. - + Tools Configure Automatic Archiving... Brings up the dialog to set up automatic archiving. Please see Automatic Archiving for details. - + Tools Configure Send Later Agent... @@ -1225,7 +1220,8 @@ Please see next section for details. Settings Menu - +If the menu item you are looking for is missing, please see Settings Menu of the &kde; Fundamentals. + The items listed here are &kmail; specific. @@ -1262,7 +1258,8 @@ Please see next section for details. Help Menu -&help.menu.documentation; + +Help Menu of the &kde; Fundamentals. @@ -1395,222 +1392,82 @@ Please see next section for details. -Edit Menu - +Edit Menu +If the menu item you are looking for is missing, please see Edit Menu of the &kde; Fundamentals. + The items listed here are &kmail; specific. - - - - + + + +&Ctrl;&Shift;O + Edit Paste as Quotation - - - -Pastes the text from the clipboard marked as quotation. - - - - - - -&Ctrl;Z -Edit -Undo - - - -Undo your steps in editing the current message. - - - - - - -&Ctrl;&Shift;Z -Edit -Redo - - - -Redo your steps in editing the current message. - + +Pastes the text from the clipboard marked as quotation. - - - - -&Ctrl;X + + Edit -Cut - - - -Cutting text works as with most editors: the selected text is -removed and put into the clipboard. Note that you can also select text and -drag it to a new position. - +Paste as Attachment + +Pastes the text from the clipboard as an attachment. - - - - -&Ctrl;C + + + +&Ctrl;&Shift;V Edit -Copy - - - -Copying text works as with most editors: the selected text is copied to the clipboard. -Note that you can also select text while holding the &Ctrl; key, and drag it to a new -position to copy it. - - - - - - -&Ctrl;V -Edit -Paste - - - -Pasting works the same as with most editors: the text from the -clipboard is pasted at the current cursor position. - - - - - - -&Ctrl;A -Edit -Select All - - - -Selects all of the text in your message. - - - - - - -&Ctrl;F -Edit -Find... - - - -Opens a dialog to search for strings in the current message. - - - - - - -F3 -Edit -Find Next - - - -Goes to the next occurrence of the previously searched string. - - - - - - -&Ctrl;R -Edit -Replace... - - - -Opens a dialog that lets you replace strings in your message with other strings. - +Paste Without Formatting, + +Pastes the text from the clipboard exactly as is, with no formatting. - - - - + + Edit Clean Spaces - - - -This replaces multiple line breaks or spaces with single line breaks or spaces. -It works on the current selection or on the complete message if there is no selection. - + +This replaces multiple line breaks or spaces with single line breaks or spaces. +It works on the current selection or the complete message text if there is no selection. - - - - + + Edit Add Quote Characters - - - -Prepends the selected text with quotation marks. - + +Prepends the selected text with quotation marks. - - - - + + Edit Remove Quote Characters - - - -Removes the left-most quotation marks from the selected text. - + +Removes the left-most quotation marks from the selected text. - - - - + + Edit Uppercase - - - -Uppercase selected text. - + +Convert the selected text to uppercase. - - - - + + Edit Lowercase - - - -Lowercase selected text. - + +Convert the selected text to lowercase. - - - - + + Edit Insert Special Characters - - - -It allows to insert special character in composer. - + +It allows you to insert spe
[kde-doc-english] Review Request 112194: Documentation: Menus, Composer settings and edit menus. Improvement to Fundamentals links.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112194/#review38301 --- This review has been submitted with commit cf416240740f88de945635b0be39766d706cac3d by Scarlett Clark to branch master. - Commit Hook On Aug. 21, 2013, 5:22 p.m., Scarlett Clark wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112194/ > --- > > (Updated Aug. 21, 2013, 5:22 p.m.) > > > Review request for Documentation, KDEPIM and Laurent Montel. > > > Description > --- > > Updated Edit and Settings menus, added link to Help fundamentals. Moved all > Fundamental links to appropriate menu documentation, we cannot assume users > will read the Menus documentation from the beginning. > > > Diffs > - > > doc/kmail/menus.docbook 4e487e1 > > Diff: http://git.reviewboard.kde.org/r/112194/diff/ > > > Testing > --- > > EBN, checkXML, meinproc4 khelpcenter preview. > > > Thanks, > > Scarlett Clark > > -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20130821/102c1724/attachment.html>
[kde-doc-english] Review Request 112194: Documentation: Menus, Composer settings and edit menus. Improvement to Fundamentals links.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112194/ --- (Updated Aug. 21, 2013, 7:25 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDEPIM and Laurent Montel. Description --- Updated Edit and Settings menus, added link to Help fundamentals. Moved all Fundamental links to appropriate menu documentation, we cannot assume users will read the Menus documentation from the beginning. Diffs - doc/kmail/menus.docbook 4e487e1 Diff: http://git.reviewboard.kde.org/r/112194/diff/ Testing --- EBN, checkXML, meinproc4 khelpcenter preview. Thanks, Scarlett Clark -- next part -- An HTML attachment was scrubbed... URL: <http://mail.kde.org/pipermail/kde-doc-english/attachments/20130821/d1b10f4c/attachment.html>
[kde-doc-english] [trojita] src/Gui: GUI: manage the enabled state of buttons which modify the message flags
Git commit 2c563d108a3ff536a27196fbfe96d95e3360e8b1 by Jan Kundr?t.
Committed on 21/08/2013 at 08:28.
Pushed by jkt into branch 'master'.
GUI: manage the enabled state of buttons which modify the message flags
BUG: 320618
M +12 -2src/Gui/Window.cpp
http://commits.kde.org/trojita/2c563d108a3ff536a27196fbfe96d95e3360e8b1
diff --git a/src/Gui/Window.cpp b/src/Gui/Window.cpp
index c435fdb..800a49e 100644
--- a/src/Gui/Window.cpp
+++ b/src/Gui/Window.cpp
@@ -467,6 +467,8 @@ void MainWindow::createActions()
m_mainToolbar->addSeparator();
m_mainToolbar->addAction(showMenuBar);
m_mainToolbar->addAction(configSettings);
+
+updateMessageFlags();
}
void MainWindow::connectModelActions()
@@ -715,8 +717,11 @@ void MainWindow::setupModels()
connect(msgListModel, SIGNAL(messagesAvailable()), msgListWidget->tree,
SLOT(scrollToBottom()));
connect(msgListModel, SIGNAL(rowsInserted(QModelIndex,int,int)),
msgListWidget, SLOT(slotAutoEnableDisableSearch()));
connect(msgListModel, SIGNAL(rowsRemoved(QModelIndex,int,int)),
msgListWidget, SLOT(slotAutoEnableDisableSearch()));
+connect(msgListModel, SIGNAL(rowsRemoved(QModelIndex,int,int)), this,
SLOT(updateMessageFlags()));
connect(msgListModel, SIGNAL(layoutChanged()), msgListWidget,
SLOT(slotAutoEnableDisableSearch()));
+connect(msgListModel, SIGNAL(layoutChanged()), this,
SLOT(updateMessageFlags()));
connect(msgListModel, SIGNAL(modelReset()), msgListWidget,
SLOT(slotAutoEnableDisableSearch()));
+connect(msgListModel, SIGNAL(modelReset()), this,
SLOT(updateMessageFlags()));
connect(msgListModel, SIGNAL(mailboxChanged(QModelIndex)), this,
SLOT(slotMailboxChanged(QModelIndex)));
connect(model, SIGNAL(alertReceived(const QString &)), this,
SLOT(alertReceived(const QString &)));
@@ -1446,8 +1451,11 @@ void MainWindow::updateMessageFlags()
void MainWindow::updateMessageFlags(const QModelIndex &index)
{
-
markAsRead->setChecked(index.data(Imap::Mailbox::RoleMessageIsMarkedRead).toBool());
-
markAsDeleted->setChecked(index.data(Imap::Mailbox::RoleMessageIsMarkedDeleted).toBool());
+bool okToModify = model->isNetworkAvailable() && index.isValid() &&
index.data(Imap::Mailbox::RoleMessageUid).toUInt() > 0;
+markAsRead->setEnabled(okToModify);
+markAsDeleted->setEnabled(okToModify);
+markAsRead->setChecked(okToModify &&
index.data(Imap::Mailbox::RoleMessageIsMarkedRead).toBool());
+markAsDeleted->setChecked(okToModify &&
index.data(Imap::Mailbox::RoleMessageIsMarkedDeleted).toBool());
}
void MainWindow::updateActionsOnlineOffline(bool online)
@@ -1652,6 +1660,8 @@ void MainWindow::slotMailboxChanged(const QModelIndex
&mailbox)
tree->showColumn(MsgListModel::FROM);
}
}
+
+updateMessageFlags();
}
void MainWindow::showConnectionStatus(QObject *parser, Imap::ConnectionState
state)
[kde-doc-english] Entity 'Scarlett.Clark.mail' not defined
Op woensdag 21 augustus 2013 05:48:40 schreef Scarlett Clark: > On Wednesday, August 21, 2013 01:27:35 PM you wrote: > > Hi Scarlett, > > > > I hope that you had nice vacations! :) > > > > On Tuesday 20 August 2013 11:02:54 Scarlett Clark wrote: > > > That ENTITY is defined in: > > > kdelibs/kdoctools/customization/entities/contributor.entities:91: > > Y > > > Scarlett.Clark.mail 'scarlett at scarlettgatelyclark.com'> > > > > I have kdelibs 4.10.5 installed which normally works and is completely > > fine > > for the build process. > > > > > Maybe you need to build kdelibs? Sorry I am not an expert, so this is > > > only > > > a guess. I have not had any issues with the build though. > > > > You probably have a more recent kdelibs. But please don't not introduce > > dependencies to new kdelibs versions if not really necessary. And if > > necessary that dependency should be reflected in the CMake scripts. > > > > Maybe we should take this to the list? > > Good idea :) I do not do anything with kdelibs. > > > Kind Regards, > > Torsten I simply copied the 4.11 file to the proper place on my 4.10 system and after that generating the 4.11 documentation works fine. With git I keep an up-to-date copy of kdelibs on my system. -- fr.gr. Freek de Kruijf
