Re: Review Request 110264: Change uses of QCoreApplication::translate() with no context to tr() in tier1 frameworks.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110264/#review31987 --- tier1/kcodecs/src/kcharsets.h http://git.reviewboard.kde.org/r/110264/#comment23840 you have some weird indentation here ... repeats below tier1/kcodecs/src/kencodingprober.cpp http://git.reviewboard.kde.org/r/110264/#comment23841 not needed tier1/kcodecs/src/kencodingprober.cpp http://git.reviewboard.kde.org/r/110264/#comment23842 you could add the missing spaces around the equal signs as you are changing this code ... - Oswald Buddenhagen On May 3, 2013, 8:35 p.m., George Goldberg wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110264/ --- (Updated May 3, 2013, 8:35 p.m.) Review request for KDE Frameworks and David Faure. Description --- Change uses of QCoreApplication::translate() with no context to QObject::tr() in tier1 frameworks. There are no changes needed in tier 2. Issues outstanding: * What do we do with the QT_TRANSLATE_NOOP_3 macro usage that we put in when changing it to QCoreApplication::translate() previously? I'd propose leaving it as is, because it seems like it would still work the same, but maybe that's not the neatest plan * kconfig/src/core/kconfig.cpp uses QCoreApplication::translate with the KConfig context in one instance. Should this be left alone? Diffs - tier1/kcodecs/src/kcharsets.h a075e5348b6ca9305cf77f3d05062fed2ca5b229 tier1/kcodecs/src/kcharsets.cpp 45f80b609abfdd131eded0cbe91e2287973046ca tier1/kcodecs/src/kencodingprober.h d6a940b275317f75e53f097e25bc92ecf2fd4435 tier1/kcodecs/src/kencodingprober.cpp 3008f3ba5fc833ae999194f7d33b9a8d95170398 tier1/solid/src/solid/backends/fstab/fstabmanager.cpp 46415e0776fcef4a8576ccc1f57417f5465d5484 tier1/solid/src/solid/backends/hal/haldevice.cpp 8e433d9a96a9e15245f0c2d735950dfca8730ae6 tier1/solid/src/solid/backends/kupnp/internetgatewaydevice1.cpp 2cff30781764dcadde045fbed1f8a5ea24aa1b1f tier1/solid/src/solid/backends/kupnp/kupnprootdevice.cpp 664e72e5fbffb246402f7f1c87132125f7d87720 tier1/solid/src/solid/backends/kupnp/mediaserver1.cpp 28e8267afefe23382898dac5c86242db41746d6f tier1/solid/src/solid/backends/kupnp/mediaserver2.cpp 9967680429accc7fe7e45a73d65e7c33a6b308d5 tier1/solid/src/solid/backends/kupnp/mediaserver3.cpp 3805a5c52d89043046d66c2aaaf01b3699e5a13f tier1/solid/src/solid/backends/udev/udevdevice.cpp e00c37c816cb1c7c94a3460341f5b0b13088eb3a tier1/solid/src/solid/backends/udev/udevmanager.cpp 1446868cca7a42155478be0dc75be2fd47725e7f tier1/solid/src/solid/backends/udisks/udisksdevice.cpp e1c47afc952bf232b9fce1ffe053cce1b3b80a67 tier1/solid/src/solid/backends/udisks/udisksmanager.cpp 31e581656d98c0e103d6ceb605b3b0bfb4b00a54 tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp 1aa7b6d139be3ba5dc6d78e1ae55b2d0841dbfbd tier1/solid/src/solid/backends/udisks2/udisksmanager.cpp e76dfd1c94b39009ae4522ce9d3f535fc2c5eac2 tier1/solid/src/solid/backends/upnp/upnpdevicemanager.cpp e3cf29954da081bb5f23b859310f4f5a57e2702c tier1/solid/src/solid/backends/upower/upowerdevice.cpp c61bee940cf5e8295d99f055582317e7e626eedd tier1/solid/src/solid/backends/upower/upowermanager.cpp ee198a0ae0da44e35cc911e9fd830a78241bc867 tier1/solid/src/solid/backends/wmi/wmibattery.cpp 4b72f80514afa7fd7bbfe706d231ec669ed2f8d4 tier1/solid/src/solid/backends/wmi/wmidevice.cpp 0e85ae9c31eaab8c863e86845733dff17453456a tier1/solid/src/solid/deviceinterface.cpp 0cfc8e84ddbcbf31b44e881055ae173a6c589fdb Diff: http://git.reviewboard.kde.org/r/110264/diff/ Testing --- Everything still compiles. Thanks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #429
See http://build.kde.org/job/plasma-framework_master_qt5/429/changes Changes: [ervin] New frameworks appeared, update the list -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson6679730306794490894.sh + /home/jenkins/scripts/setup-env.sh From git://anongit.kde.org/plasma-framework 051ed6c..27266d5 master - origin/master Branch jenkins set up to track remote branch master from origin. Success build forhudson.tasks.Shell@50970d79 Checkout:plasma-framework_master_qt5 / http://build.kde.org/job/plasma-framework_master_qt5/ws/ - hudson.remoting.Channel@72bdc993:LinuxSlave - 1 Using strategy: Default Last Built Revision: Revision 051ed6c8edad46e9f86c712276a7569f13d4606b (refs/heads/jenkins) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 27266d5582f4f0ad8890111778d79f2074b2eb19 (refs/heads/jenkins) Checking out Revision 27266d5582f4f0ad8890111778d79f2074b2eb19 (refs/heads/jenkins) [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson8837011769069500149.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: extra-cmake-modules - Branch master strigidaemon - Branch master phonon - Branch phonon4qt5 kdelibs - Branch frameworks attica - Branch master libstreamanalyzer - Branch master strigiutils - Branch master strigiclient - Branch master qt5 - Branch dev libstreams - Branch master == Cleaning Source Tree HEAD is now at 27266d5 New frameworks appeared, update the list Removing build/ Removing install/ == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Commencing Build Process -- The C compiler identification is GNU 4.6.0 -- The CXX compiler identification is GNU 4.6.0 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at /srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM-0.0.8/find-modules/FindKF5.cmake:104 (message): KF5: requested unknown components ki18n;kguiaddons;kservice;kwidgets;ItemViews;KCompletion;KNotifications;KJobWidgets;KConfigWidgets;KIconThemes Call Stack (most recent call first): CMakeLists.txt:51 (find_package) -- Configuring incomplete, errors occurred! Build step exited with non-zero code, assuming failure to build from source for project plasma-framework. Build step 'Execute shell' marked build as failure [WARNINGS] Skipping publisher since build result is FAILURE Recording test results ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #585
See http://build.kde.org/job/kdelibs_frameworks_qt5/585/changes Changes: [ervin] Remove dead code [ervin] KNumInput isn't needed since we use the spinbox only [ervin] Remove unused include [ervin] We use only QToolBar here [ervin] Remove unused includes [ervin] A QObject is enough here [ervin] Remove unused includes [ervin] Remove unused includes [ervin] Use the right macros [ervin] Remove dead code [ervin] Looks like overkill for it, remove the dependency [ervin] Use QDesktopServices instead of KHelpClient [ervin] Use qDebug here [ervin] Don't depend on KIconEffect anymore [ervin] Position programIconName as a dynamic property [ervin] Don't depend directly on KAboutData [ervin] Don't depend on KLocale [ervin] KHelpMenu doesn't depend on KActionCollection anymore [ervin] We don't really need KInputDialog here [ervin] Remove dead code [ervin] Create the ItemViews framework [ervin] Create a new KCompletion framework [ervin] Create a new KConfigWidgets framework [ervin] The session properties are on QGuiApplication now [ervin] Create new KDE4Attic framework [ervin] Port away from kde_file.h [ervin] Create a new KIconThemes framework [ervin] Create a new KJobWidgets framework [ervin] Doesn't really use KNotification ATM [ervin] Clean KNotification a bit [ervin] Create a new KNotifications framework [ervin] Don't depend on KActionCollection at compile time [ervin] Move KStandardShortcut to KWidgets [ervin] Decouple KGuiItem from KStandardGuiItem [ervin] Move KGuiItem in KWidgetsAddons [ervin] Move KDualAction to KWidgetsAddons [ervin] Make KSelectAction independent of KComboBox [ervin] We don't use KDebug in there [ervin] Move KSelectAction and children to KWidgets [ervin] Move KToggleAction and KToggleFullScreenAction to KWidgetAddons [ervin] Move KPasteTextAction to KWidgets [ervin] Move KStandardAction to KWidgets [ervin] Use QDebug instead of KDebug [ervin] Get rid of KLocalizedString [ervin] KAboutData is not used here [ervin] Get rid of KMessageBox [ervin] Move KGlobalAccel to KWindowSystem [ervin] Move KTitleWidget to KWidgetsAddons [ervin] Make it easier to use from the outside [ervin] Make it more similar to other frameworks and easier to reuse [ervin] Move KHelpClient back in kdeui [ervin] Make it independent from kdecore [ervin] Make it independent from ki18n [ervin] Simply use QTextEdit for the sample text [ervin] Export the system fixed font as a dynamic property [ervin] Don't depend on KGlobalSettings [ervin] Move KFontChooser to KWidgetsAddons [ervin] Move KSqueezedTextLabel to KWidgetsAddons [ervin] Make kwidgets independent of kdeui -- [...truncated 4131 lines...] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kcodecs/autotests/kcharsetstest.cpp: In member function ‘void KCharsetsTest::testToEntity()’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kcodecs/autotests/kcharsetstest.cpp:135:16: warning: unused variable ‘singleton’ [-Wunused-variable] [ 35%] Building CXX object tier1/kcodecs/autotests/CMakeFiles/kcharsetstest.dir/kcharsetstest_automoc.cpp.o Linking CXX executable kcharsetstest [ 35%] Built target kcharsetstest Scanning dependencies of target kencodingprobertest [ 35%] Building CXX object tier1/kcodecs/autotests/CMakeFiles/kencodingprobertest.dir/kencodingprobertest.cpp.o [ 35%] Building CXX object tier1/kcodecs/autotests/CMakeFiles/kencodingprobertest.dir/kencodingprobertest_automoc.cpp.o Linking CXX executable kencodingprobertest [ 35%] Built target kencodingprobertest Scanning dependencies of target kidletime_example [ 35%] Building CXX object tier1/kidletime/examples/CMakeFiles/kidletime_example.dir/main.cpp.o [ 35%] Building CXX object tier1/kidletime/examples/CMakeFiles/kidletime_example.dir/KIdleTest.cpp.o [ 35%] Building CXX object tier1/kidletime/examples/CMakeFiles/kidletime_example.dir/kidletime_example_automoc.cpp.o Linking CXX executable kidletime_example [ 35%] Built target kidletime_example Scanning dependencies of target fixx11h_test [ 35%] Building CXX object tier1/kwindowsystem/autotests/CMakeFiles/fixx11h_test.dir/fixx11h_test.cpp.o [ 35%] Building CXX object tier1/kwindowsystem/autotests/CMakeFiles/fixx11h_test.dir/fixx11h_test_automoc.cpp.o Linking CXX executable fixx11h_test [ 35%] Built target fixx11h_test Scanning dependencies of target fixx11h_test2 [ 35%] Building CXX object tier1/kwindowsystem/autotests/CMakeFiles/fixx11h_test2.dir/fixx11h_test2.cpp.o [ 35%] Building CXX object tier1/kwindowsystem/autotests/CMakeFiles/fixx11h_test2.dir/fixx11h_test2_automoc.cpp.o Linking CXX executable fixx11h_test2 [ 35%] Built target fixx11h_test2 Scanning dependencies of target kglobalshortcuttest [ 35%] Building CXX object tier1/kwindowsystem/autotests/CMakeFiles/kglobalshortcuttest.dir/kglobalshortcuttest.cpp.o Scanning dependencies of target kstartupinfo_unittest [ 35%] Building CXX object
Build failed in Jenkins: kdelibs_frameworks_qt5 #586
See http://build.kde.org/job/kdelibs_frameworks_qt5/586/changes Changes: [ervin] Oops, wrong copy... thx dfaure for spotting it -- [...truncated 4098 lines...] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kcodecs/autotests/kcharsetstest.cpp: In member function ‘void KCharsetsTest::testToEntity()’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kcodecs/autotests/kcharsetstest.cpp:135:16: warning: unused variable ‘singleton’ [-Wunused-variable] Scanning dependencies of target kledtest [ 34%] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/kledtest.dir/kledtest.cpp.o [ 34%] Built target kxmessages_unittest [ 34%] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/kledtest.dir/kledtest_automoc.cpp.o [ 34%] Building CXX object tier1/kwidgetsaddons/autotests/CMakeFiles/kdualactiontest.dir/kdualactiontest_automoc.cpp.o Scanning dependencies of target kseparatortest [ 34%] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/kseparatortest.dir/kseparatortest.cpp.o [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/policyagentinterface.cpp.o [ 34%] [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/org_kde_solid_networking_client.cpp.o Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fstab/fstabdevice.cpp.o [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fstab/fstabnetworkshare.cpp.o Scanning dependencies of target ksqueezedtextlabeltest [ 34%] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/ksqueezedtextlabeltest.dir/ksqueezedtextlabeltest.cpp.o Linking CXX executable kledtest [ 34%] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/kseparatortest.dir/kseparatortest_automoc.cpp.o Linking CXX executable kseparatortest Linking CXX executable kcharsetstest [ 34%] Built target kseparatortest [ 34%] Built target kcharsetstest [ 34%] [ 34%] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/ksqueezedtextlabeltest.dir/ksqueezedtextlabeltest_automoc.cpp.o Building CXX object tier1/solid/src/solid/CMakeFiles/Solid.dir/Solid_automoc.cpp.o [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fstab/fstabstorageaccess.cpp.o [ 34%] Built target kledtest [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fstab/fstabhandling.cpp.o Scanning dependencies of target ktitlewidgettest [ 34%] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/autotests/kglobalshortcuttest.cpp: In member function ‘void KGlobalShortcutTest::setupTest(QString)’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/autotests/kglobalshortcuttest.cpp:77:60: warning: ‘QListQStringList KGlobalAccel::allMainComponents()’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/src/kglobalaccel.h:284) [-Wdeprecated-declarations] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/autotests/kglobalshortcuttest.cpp: In member function ‘void KGlobalShortcutTest::testListActions()’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/autotests/kglobalshortcuttest.cpp:249:60: warning: ‘QListQStringList KGlobalAccel::allMainComponents()’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/src/kglobalaccel.h:284) [-Wdeprecated-declarations] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/autotests/kglobalshortcuttest.cpp:257:73: warning: ‘QListQStringList KGlobalAccel::allActionsForComponent(const QStringList)’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/src/kglobalaccel.h:293) [-Wdeprecated-declarations] http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/autotests/kglobalshortcuttest.cpp: In member function ‘void KGlobalShortcutTest::testForgetGlobalShortcut()’: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/autotests/kglobalshortcuttest.cpp:393:60: warning: ‘QListQStringList KGlobalAccel::allMainComponents()’ is deprecated (declared at http://build.kde.org/job/kdelibs_frameworks_qt5/ws/tier1/kwindowsystem/src/kglobalaccel.h:284) [-Wdeprecated-declarations] Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/ktitlewidgettest.dir/ktitlewidgettest.cpp.o Linking CXX executable kglobalshortcuttest [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/backends/fstab/fstabwatcher.cpp.o [ 34%] Linking CXX executable ksqueezedtextlabeltest Building CXX object tier1/kwidgetsaddons/tests/CMakeFiles/ktitlewidgettest.dir/ktitlewidgettest_automoc.cpp.o [ 34%] Building CXX object tier1/solid/src/solid/CMakeFiles/Solid_static.dir/powermanagementinterface.cpp.o [ 34%] Building CXX object
Build failed in Jenkins: kdelibs_frameworks_qt5 #588
See http://build.kde.org/job/kdelibs_frameworks_qt5/588/changes Changes: [ervin] Complete the fixedFont export [ervin] Add missing license -- [...truncated 14378 lines...] -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindAGG.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindAkode.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindAlsa.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindAvahi.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindBerkeleyDB.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindBlitz.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindBlueZ.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindCarbon.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindDBusMenuQt.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindDNSSD.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindENCHANT.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindEigen.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindEigen2.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindExiv2.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindFFmpeg.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindFlac.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindFlex.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindFontconfig.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindGLIB2.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindGMP.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindGObject.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindGSSAPI.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindGStreamer.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindGettext.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindGphoto2.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindIOKit.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/share/cmake/modules/FindKDE4Workspace.cmake -- Installing:
Jenkins build is back to normal : kdelibs_frameworks_qt5 #589
See http://build.kde.org/job/kdelibs_frameworks_qt5/589/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 #430
See http://build.kde.org/job/plasma-framework_master_qt5/430/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: RFC: a replacement for KPluginLoader
On Saturday 04 May 2013 18:04:13 Aaron J. Seigo wrote: If we keep the current solution thenwhy deprecate it? Simply keeping what is there would be the best thing from an app developer's POV. Great, then let's do that. The *only* reason I'm touching this item is because the class is marked as deprecated. Which class do you see as marked as deprecated? KPluginFactory is not deprecated, only K_EXPORT_PLUGIN is (because Qt forced it out). KPluginLoader is not deprecated either. And both of these classes are in the kservice framework, not in something like kde4support. That means it likely will not be in minimal builds (e.g. ones targeting small devices) and will one day disappear on us. K_EXPORT_PLUGIN, yes, but not the KPlugin* classes. I think all this is a rather large misunderstanding. KPluginLoader and KPluginFactory are not deprecated, exactly for the reason you found out: we have nothing better at the moment. So that's what we have, let's use that. I don't want a plasma specific solution. I also am not able to sit here with no solution. Could you give this solution a try? Keep KPluginLoader and KPluginFactory, and write a replacement macro for K_EXPORT_PLUGIN which creates a QObject with the metadata line (hmm, macro inside macro, will that work?). That's the bit that's missing, right? Exporting the factory as the one object returned by the qt plugin framework? If this works, then it should be added to kpluginfactory.h -- no reason to make it plasma-specific, as we both agree upon. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 110264: Change uses of QCoreApplication::translate() with no context to tr() in tier1 frameworks.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110264/ --- (Updated May 4, 2013, 6:27 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Fix review comments. Description --- Change uses of QCoreApplication::translate() with no context to QObject::tr() in tier1 frameworks. There are no changes needed in tier 2. Issues outstanding: * What do we do with the QT_TRANSLATE_NOOP_3 macro usage that we put in when changing it to QCoreApplication::translate() previously? I'd propose leaving it as is, because it seems like it would still work the same, but maybe that's not the neatest plan * kconfig/src/core/kconfig.cpp uses QCoreApplication::translate with the KConfig context in one instance. Should this be left alone? Diffs (updated) - tier1/kcodecs/src/kcharsets.h a075e5348b6ca9305cf77f3d05062fed2ca5b229 tier1/kcodecs/src/kcharsets.cpp 45f80b609abfdd131eded0cbe91e2287973046ca tier1/kcodecs/src/kencodingprober.h d6a940b275317f75e53f097e25bc92ecf2fd4435 tier1/kcodecs/src/kencodingprober.cpp 3008f3ba5fc833ae999194f7d33b9a8d95170398 tier1/solid/src/solid/backends/fstab/fstabmanager.cpp 46415e0776fcef4a8576ccc1f57417f5465d5484 tier1/solid/src/solid/backends/hal/haldevice.cpp 8e433d9a96a9e15245f0c2d735950dfca8730ae6 tier1/solid/src/solid/backends/kupnp/internetgatewaydevice1.cpp 2cff30781764dcadde045fbed1f8a5ea24aa1b1f tier1/solid/src/solid/backends/kupnp/kupnprootdevice.cpp 664e72e5fbffb246402f7f1c87132125f7d87720 tier1/solid/src/solid/backends/kupnp/mediaserver1.cpp 28e8267afefe23382898dac5c86242db41746d6f tier1/solid/src/solid/backends/kupnp/mediaserver2.cpp 9967680429accc7fe7e45a73d65e7c33a6b308d5 tier1/solid/src/solid/backends/kupnp/mediaserver3.cpp 3805a5c52d89043046d66c2aaaf01b3699e5a13f tier1/solid/src/solid/backends/udev/udevdevice.cpp e00c37c816cb1c7c94a3460341f5b0b13088eb3a tier1/solid/src/solid/backends/udev/udevmanager.cpp 1446868cca7a42155478be0dc75be2fd47725e7f tier1/solid/src/solid/backends/udisks/udisksdevice.cpp e1c47afc952bf232b9fce1ffe053cce1b3b80a67 tier1/solid/src/solid/backends/udisks/udisksmanager.cpp 31e581656d98c0e103d6ceb605b3b0bfb4b00a54 tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp 1aa7b6d139be3ba5dc6d78e1ae55b2d0841dbfbd tier1/solid/src/solid/backends/udisks2/udisksmanager.cpp e76dfd1c94b39009ae4522ce9d3f535fc2c5eac2 tier1/solid/src/solid/backends/upnp/upnpdevicemanager.cpp e3cf29954da081bb5f23b859310f4f5a57e2702c tier1/solid/src/solid/backends/upower/upowerdevice.cpp c61bee940cf5e8295d99f055582317e7e626eedd tier1/solid/src/solid/backends/upower/upowermanager.cpp ee198a0ae0da44e35cc911e9fd830a78241bc867 tier1/solid/src/solid/backends/wmi/wmibattery.cpp 4b72f80514afa7fd7bbfe706d231ec669ed2f8d4 tier1/solid/src/solid/backends/wmi/wmidevice.cpp 0e85ae9c31eaab8c863e86845733dff17453456a tier1/solid/src/solid/deviceinterface.cpp 0cfc8e84ddbcbf31b44e881055ae173a6c589fdb Diff: http://git.reviewboard.kde.org/r/110264/diff/ Testing --- Everything still compiles. Thanks, George Goldberg ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: please make it easier to hack on frameworks
On Monday 29 April 2013, Aaron J. Seigo wrote: hi ... today i am unable to work on plasma-frameworks. this is because i am currently unable to compile the frameworks branch of kdelibs. in turn, this is because i do not have a recent enough version of cmake. the cmake version required is 2.8.10.20130411. this isn't even a release version of cmake, but a dated snapshot! i am left with the option of moving to cmake from git (something i really would like to avoid) or not working on plasma-frameworks (which is not really an option for me). i am sure there was a good reason to move to this new version of cmake. i am also sure that requiring devel versions of build tools to work on frameworks limits the people who can and will work on it. would it be possible for someone who feels reponsible for frameworks 5 to institute some more developer-friendly requirements here? I just updated Qt. Great that the git updating step is now on http://community.kde.org/Frameworks/Building#Qt_5 :-) Now it fails building: make[3]: Entering directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' /home/alex/src/packages/qt5/build/qtbase/bin/qmake -o Makefile /home/alex/src/packages/qt5/qtbase/src/corelib/corelib.pro /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module.prf:56: Cannot find feature qt_module_pris /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module_headers.prf:29: Unexpected return(). /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module.prf:180: Cannot find feature qt_common /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/default_post.prf:7: Cannot find feature resolve_config /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.prf:12: Cannot find feature cmake_functions /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.prf:19: 'cmakeModuleName' is not a recognized replace function. /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.prf:21: 'cmakeModuleList' is not a recognized replace function. /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_functions.prf:183: resolve_depends(var, prefix) requires one or two arguments. /home/alex/src/packages/qt5/build/qtbase/bin/rcc: error while loading shared libraries: libQt5Bootstrap.so.5: cannot open shared object file: No such file or directory make[3]: Leaving directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' make[3]: Entering directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' /home/alex/src/packages/qt5/build/qtbase/bin/moc -DQT_NO_USING_NAMESPACE - DQT_BUILD_CORE_LIB -DQT_BUILDING_QT -DQT_NO_CAST_TO_ASCII - DQT_ASCII_CAST_WARNINGS -DQT_MOC_COMPAT -DQT_USE_QSTRINGBUILDER - DQT_DEPRECATED_WARNINGS -DQT_DISABLE_DEPRECATED_BEFORE=0x05 - DELF_INTERPRETER=\/lib/ld-linux.so.2\ -DQT_USE_ICU -DPCRE_HAVE_CONFIG_H - DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG - I/home/alex/src/packages/qt5/qtbase/mkspecs/linux-g++ - I/home/alex/src/packages/qt5/qtbase/src/corelib -I../../include - I../../include/QtCore -I../../include/QtCore/5.1.0 - I../../include/QtCore/5.1.0/QtCore -Iglobal - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/pcre - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/harfbuzz/src - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/md5 - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/md4 - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/sha3 -I.moc/release-shared - I. -I/usr/include -I/usr/lib/gcc/i486-slackware- linux/4.5.2/../../../../include/c++/4.5.2 -I/usr/lib/gcc/i486-slackware- linux/4.5.2/../../../../include/c++/4.5.2/backward -I/usr/lib/gcc/i486- slackware-linux/4.5.2/../../../../include/c++/4.5.2/i486-slackware-linux - I/usr/lib/gcc/i486-slackware-linux/4.5.2/include -I/usr/lib/gcc/i486- slackware-linux/4.5.2/include-fixed -I/usr/lib/qt/include -I/usr/local/include /home/alex/src/packages/qt5/qtbase/src/corelib/animation/qabstractanimation.h -o .moc/release-shared/moc_qabstractanimation.cpp /home/alex/src/packages/qt5/build/qtbase/bin/moc: error while loading shared libraries: libQt5Bootstrap.so.5: cannot open shared object file: No such file or directory make[3]: *** [.moc/release-shared/moc_qabstractanimation.cpp] Error 127 make[3]: Leaving directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' make[2]: *** [sub-corelib-make_first] Error 2 Do I have to run configure again, or is qmake in the meantime able to handle this ? Again with the full list of parameters ? If something of that is required, it should be also on that wiki page. (I could figure it out, but I'm kind of testing our documentation by just following it, so I get the same as probably every other contributor...) Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: please make it easier to hack on frameworks
On Saturday 04 May 2013 20:59:32 Alexander Neundorf wrote: On Monday 29 April 2013, Aaron J. Seigo wrote: hi ... today i am unable to work on plasma-frameworks. this is because i am currently unable to compile the frameworks branch of kdelibs. in turn, this is because i do not have a recent enough version of cmake. the cmake version required is 2.8.10.20130411. this isn't even a release version of cmake, but a dated snapshot! i am left with the option of moving to cmake from git (something i really would like to avoid) or not working on plasma-frameworks (which is not really an option for me). i am sure there was a good reason to move to this new version of cmake. i am also sure that requiring devel versions of build tools to work on frameworks limits the people who can and will work on it. would it be possible for someone who feels reponsible for frameworks 5 to institute some more developer-friendly requirements here? I just updated Qt. Great that the git updating step is now on http://community.kde.org/Frameworks/Building#Qt_5 :-) Now it fails building: make[3]: Entering directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' /home/alex/src/packages/qt5/build/qtbase/bin/qmake -o Makefile /home/alex/src/packages/qt5/qtbase/src/corelib/corelib.pro /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module.prf:56: Cannot find feature qt_module_pris /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module_headers. prf:29: Unexpected return(). /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module.prf:180: Cannot find feature qt_common /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/default_post.prf:7 : Cannot find feature resolve_config /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.prf:1 2: Cannot find feature cmake_functions /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.prf:1 9: 'cmakeModuleName' is not a recognized replace function. /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.prf:2 1: 'cmakeModuleList' is not a recognized replace function. /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_functions.prf:1 83: resolve_depends(var, prefix) requires one or two arguments. /home/alex/src/packages/qt5/build/qtbase/bin/rcc: error while loading shared libraries: libQt5Bootstrap.so.5: cannot open shared object file: No such file or directory make[3]: Leaving directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' make[3]: Entering directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' /home/alex/src/packages/qt5/build/qtbase/bin/moc -DQT_NO_USING_NAMESPACE - DQT_BUILD_CORE_LIB -DQT_BUILDING_QT -DQT_NO_CAST_TO_ASCII - DQT_ASCII_CAST_WARNINGS -DQT_MOC_COMPAT -DQT_USE_QSTRINGBUILDER - DQT_DEPRECATED_WARNINGS -DQT_DISABLE_DEPRECATED_BEFORE=0x05 - DELF_INTERPRETER=\/lib/ld-linux.so.2\ -DQT_USE_ICU -DPCRE_HAVE_CONFIG_H - DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG - I/home/alex/src/packages/qt5/qtbase/mkspecs/linux-g++ - I/home/alex/src/packages/qt5/qtbase/src/corelib -I../../include - I../../include/QtCore -I../../include/QtCore/5.1.0 - I../../include/QtCore/5.1.0/QtCore -Iglobal - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/pcre - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/harfbuzz/src - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/md5 - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/md4 - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/sha3 -I.moc/release-shared - I. -I/usr/include -I/usr/lib/gcc/i486-slackware- linux/4.5.2/../../../../include/c++/4.5.2 -I/usr/lib/gcc/i486-slackware- linux/4.5.2/../../../../include/c++/4.5.2/backward -I/usr/lib/gcc/i486- slackware-linux/4.5.2/../../../../include/c++/4.5.2/i486-slackware-linux - I/usr/lib/gcc/i486-slackware-linux/4.5.2/include -I/usr/lib/gcc/i486- slackware-linux/4.5.2/include-fixed -I/usr/lib/qt/include -I/usr/local/include /home/alex/src/packages/qt5/qtbase/src/corelib/animation/qabstractanimation .h -o .moc/release-shared/moc_qabstractanimation.cpp /home/alex/src/packages/qt5/build/qtbase/bin/moc: error while loading shared libraries: libQt5Bootstrap.so.5: cannot open shared object file: No such file or directory make[3]: *** [.moc/release-shared/moc_qabstractanimation.cpp] Error 127 make[3]: Leaving directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' make[2]: *** [sub-corelib-make_first] Error 2 Do I have to run configure again, or is qmake in the meantime able to handle this ? Nope I generally have to run configure again. Again with the full list of parameters ? I do (I in fact have a small script which call configure for me as I often do the same qt builds). I have no idea if that's mandatory of not. If something of that is required, it should be also on that wiki page. (I could figure it out, but I'm kind of testing our
Re: please make it easier to hack on frameworks
On Saturday 04 May 2013, Kevin Ottens wrote: On Saturday 04 May 2013 20:59:32 Alexander Neundorf wrote: On Monday 29 April 2013, Aaron J. Seigo wrote: hi ... today i am unable to work on plasma-frameworks. this is because i am currently unable to compile the frameworks branch of kdelibs. in turn, this is because i do not have a recent enough version of cmake. the cmake version required is 2.8.10.20130411. this isn't even a release version of cmake, but a dated snapshot! i am left with the option of moving to cmake from git (something i really would like to avoid) or not working on plasma-frameworks (which is not really an option for me). i am sure there was a good reason to move to this new version of cmake. i am also sure that requiring devel versions of build tools to work on frameworks limits the people who can and will work on it. would it be possible for someone who feels reponsible for frameworks 5 to institute some more developer-friendly requirements here? I just updated Qt. Great that the git updating step is now on http://community.kde.org/Frameworks/Building#Qt_5 :-) Now it fails building: make[3]: Entering directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' /home/alex/src/packages/qt5/build/qtbase/bin/qmake -o Makefile /home/alex/src/packages/qt5/qtbase/src/corelib/corelib.pro /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module.prf:5 6: Cannot find feature qt_module_pris /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module_heade rs. prf:29: Unexpected return(). /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_module.prf:1 80: Cannot find feature qt_common /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/default_post.pr f:7 : Cannot find feature resolve_config /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.pr f:1 2: Cannot find feature cmake_functions /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.pr f:1 9: 'cmakeModuleName' is not a recognized replace function. /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/create_cmake.pr f:2 1: 'cmakeModuleList' is not a recognized replace function. /home/alex/src/packages/qt5/build/qtbase/mkspecs/features/qt_functions.pr f:1 83: resolve_depends(var, prefix) requires one or two arguments. /home/alex/src/packages/qt5/build/qtbase/bin/rcc: error while loading shared libraries: libQt5Bootstrap.so.5: cannot open shared object file: No such file or directory make[3]: Leaving directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' make[3]: Entering directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' /home/alex/src/packages/qt5/build/qtbase/bin/moc -DQT_NO_USING_NAMESPACE - DQT_BUILD_CORE_LIB -DQT_BUILDING_QT -DQT_NO_CAST_TO_ASCII - DQT_ASCII_CAST_WARNINGS -DQT_MOC_COMPAT -DQT_USE_QSTRINGBUILDER - DQT_DEPRECATED_WARNINGS -DQT_DISABLE_DEPRECATED_BEFORE=0x05 - DELF_INTERPRETER=\/lib/ld-linux.so.2\ -DQT_USE_ICU -DPCRE_HAVE_CONFIG_H - DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG - I/home/alex/src/packages/qt5/qtbase/mkspecs/linux-g++ - I/home/alex/src/packages/qt5/qtbase/src/corelib -I../../include - I../../include/QtCore -I../../include/QtCore/5.1.0 - I../../include/QtCore/5.1.0/QtCore -Iglobal - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/pcre - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/harfbuzz/src - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/md5 - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/md4 - I/home/alex/src/packages/qt5/qtbase/src/3rdparty/sha3 -I.moc/release-shared - I. -I/usr/include -I/usr/lib/gcc/i486-slackware- linux/4.5.2/../../../../include/c++/4.5.2 -I/usr/lib/gcc/i486-slackware- linux/4.5.2/../../../../include/c++/4.5.2/backward -I/usr/lib/gcc/i486- slackware-linux/4.5.2/../../../../include/c++/4.5.2/i486-slackware-linux - I/usr/lib/gcc/i486-slackware-linux/4.5.2/include -I/usr/lib/gcc/i486- slackware-linux/4.5.2/include-fixed -I/usr/lib/qt/include -I/usr/local/include /home/alex/src/packages/qt5/qtbase/src/corelib/animation/qabstractanimati on .h -o .moc/release-shared/moc_qabstractanimation.cpp /home/alex/src/packages/qt5/build/qtbase/bin/moc: error while loading shared libraries: libQt5Bootstrap.so.5: cannot open shared object file: No such file or directory make[3]: *** [.moc/release-shared/moc_qabstractanimation.cpp] Error 127 make[3]: Leaving directory `/home/alex/src/packages/qt5/build/qtbase/src/corelib' make[2]: *** [sub-corelib-make_first] Error 2 Do I have to run configure again, or is qmake in the meantime able to handle this ? Nope I generally have to run configure again. Configured, and still the same :-/ It complains that it cannot find libQt5Bootstrap.so Alex ___ Kde-frameworks-devel
