Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review37187 --- staging/kservice/src/desktoptojson/kconfigtojson.cpp http://git.reviewboard.kde.org/r/111689/#comment27513 if you create a QFileInfo object you can ask it for exits and use its isAbsolute() check later on instead of assuming Unix paths in line 72 - Kevin Krammer On Aug. 5, 2013, 11:29 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 5, 2013, 11:29 p.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/src/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/src/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/src/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/src/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #549
See http://build.kde.org/job/plasma-framework_master_qt5/549/ -- [...truncated 567 lines...] from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:60:52: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63: warning: ‘KCmdLineOptions’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:121:72: warning: ‘KCmdLineOptions’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:128:57: warning: ‘KCmdLineOptions’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:128:57: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:423:73: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:434:70: warning: ‘KCmdLineArgs’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:279) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:654:38: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:30:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h: In function ‘T KGlobal::findDirectChild(const QObject*)’: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:514:31: warning: ‘QObject* KGlobal::findDirectChild_helper(const QObject*, const QMetaObject)’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:504) [-Wdeprecated-declarations] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:31:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h: At global scope: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140:59: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:152:27: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:163:24: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:261:73: warning: ‘List’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:316:71: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:362:23: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:380:55: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:903:17:
Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37193 --- I was just working on the same thing. I'm not sure if we want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets. Strigi doesn't need to be ported to Qt5 since it is does not use Qt. Soprano will have to be, but I don't think this code uses Soprano. - Vishesh Handa On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 5, 2013, 6:06 p.m.) Review request for KDE Frameworks and Vishesh Handa. Description --- As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support. It's worth noting that there are 2 plugins (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp Diffs - kio/CMakeLists.txt 035cf70 kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d kio/kfile/kfilemetadataconfigurationwidget.cpp kio/kfile/kfilemetadataprovider.cpp kio/kfile/kfilemetadataprovider_p.h 8009bf4 kio/kfile/kfilemetadatareader.cpp kio/kfile/kfilemetadatareader_p.h kio/kfile/kfilemetadatareaderprocess.cpp kio/kfile/kfilemetadatawidget.h 2dc4677 kio/kfile/kfilemetadatawidget.cpp kio/kfile/kmetaprops.h a08c380 kio/kfile/kmetaprops.cpp kio/kfile/knfotranslator.cpp kio/kfile/knfotranslator_p.h kio/kfile/kpreviewprops.h 8a974da kio/kfile/kpreviewprops.cpp kio/kfile/kpropertiesdialog.cpp 687e4bf staging/kde4support/src/CMakeLists.txt 1d6369f staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 Diff: http://git.reviewboard.kde.org/r/111897/diff/ Testing --- builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status? Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111905: Actually emit iconChanged
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Description --- The signal doesn't seem to be ever emitted, emit it when KIconLoaderGlobalData does Diffs - staging/kiconthemes/src/kiconloader.cpp 31e013e Diff: http://git.reviewboard.kde.org/r/111905/diff/ Testing --- Tested it on KdePLatformTheme, it worked nice. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Ki18n mostly ready
[: Albert Astals Cid :] to make it more obvious maybe it should be KI18N_TRANSLATION_DOMAIN ? Well possibly, but to me it looks redundant: translation domain is already Gettext-specific terminology, and it would be bizarre to use more than one Gettext-based system in the same piece of code so as to need differentiating between them. [: Chusslove Illich :] Code files can get TRANSLATION_DOMAIN everywhere through CMake-configured header (.h.cmake). [: Albert Astals Cid :] What includes that header? For simplicity, I would make every .cpp file include it. This is e.g. what I did inside kdelibs/staging/kunitconversion/. Of course, if there is already a private header included by all files, this header can include the generated one. (But see also below.) Anything that needs manual intervention will break because most people don't care about i18n and almost noone tries their code with a non english locale, so let's not go for anything manual if possible. One nice thing about static binding of calls to catalogs is that now we can have code checks which alarm when something is amiss! There is no more the need to analyze the code for entry points where to put insertCatalog() calls, and which catalogs should be inserted. In other words, one can now fix translation without understanding the code initialization, one being orthogonal to the other. For example, it should not be too hard to check that each main() (outside of tests/) has setApplicationCatalog(), and if there is no main() in the project, that each file with some i18n() calls eventually includes a header file with TRANSLATION_DOMAIN definition. And for .rc files, even if we leave it at manual adding of translation domain attribute, it is totally easy to verify that each .rc file has this attribute, and that it matches the TRANSLATION_DOMAIN set in the first parent CMakeLists.txt. In fact, the check could take as reference not CMakeLists.txt, but Messages.sh, and then proceed veryfing everything below it. (Yes, this would need a bit more discipline in Messages.sh, e.g. that it extracts exactly one .pot file, but I think this is a good idea anyway.) -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Ki18n mostly ready
[: Sebastian Kügler :] Putting KLocalizedString::insertCatalog in is good enough, mark it DEPRECATED so we get warned that porting work is coming up. The way I see it, there are no more KLocalizedString::insertCatalog() calls anywhere :) All newly incoming code for porting will have the older KGlobal::locale()-insertCatalog() form, which cannot be reintroduced as dummy. So, in fact, in the quick note in KDE5PORTING.html I should refer to this older form. [: Sebastian Kügler :] Having someone fix the build (by removing the insertCatalog call, for example) will hide this porting task once there's a proper solution, and I'm sure it will lead to a large amount of insertCatalog calls simply not being ported. [...] See my remark on static code checking in the other message. That should be sufficient to avoid most cracks in translation coverage due to porting. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37195 --- You seem to have forgotten about kcommentwidget. It can be discarded/moved as well. - Vishesh Handa On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 5, 2013, 6:06 p.m.) Review request for KDE Frameworks and Vishesh Handa. Description --- As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support. It's worth noting that there are 2 plugins (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp Diffs - kio/CMakeLists.txt 035cf70 kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d kio/kfile/kfilemetadataconfigurationwidget.cpp kio/kfile/kfilemetadataprovider.cpp kio/kfile/kfilemetadataprovider_p.h 8009bf4 kio/kfile/kfilemetadatareader.cpp kio/kfile/kfilemetadatareader_p.h kio/kfile/kfilemetadatareaderprocess.cpp kio/kfile/kfilemetadatawidget.h 2dc4677 kio/kfile/kfilemetadatawidget.cpp kio/kfile/kmetaprops.h a08c380 kio/kfile/kmetaprops.cpp kio/kfile/knfotranslator.cpp kio/kfile/knfotranslator_p.h kio/kfile/kpreviewprops.h 8a974da kio/kfile/kpreviewprops.cpp kio/kfile/kpropertiesdialog.cpp 687e4bf staging/kde4support/src/CMakeLists.txt 1d6369f staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 Diff: http://git.reviewboard.kde.org/r/111897/diff/ Testing --- builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status? Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111905: Actually emit iconChanged
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/#review37197 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 6, 2013, 9:16 a.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/ --- (Updated Aug. 6, 2013, 9:16 a.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Description --- The signal doesn't seem to be ever emitted, emit it when KIconLoaderGlobalData does Diffs - staging/kiconthemes/src/kiconloader.cpp 31e013e Diff: http://git.reviewboard.kde.org/r/111905/diff/ Testing --- Tested it on KdePLatformTheme, it worked nice. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111905: Actually emit iconChanged
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/ --- (Updated Aug. 6, 2013, 9:58 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Aleix Pol Gonzalez. Description --- The signal doesn't seem to be ever emitted, emit it when KIconLoaderGlobalData does Diffs - staging/kiconthemes/src/kiconloader.cpp 31e013e Diff: http://git.reviewboard.kde.org/r/111905/diff/ Testing --- Tested it on KdePLatformTheme, it worked nice. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #550
See http://build.kde.org/job/plasma-framework_master_qt5/550/changes Changes: [hein] Make the setData() accessor take a QVariant as payload. -- [...truncated 563 lines...] http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/draganddrop/DeclarativeDragArea.cpp: In member function ‘virtual void DeclarativeDragArea::mouseMoveEvent(QMouseEvent*)’: http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/draganddrop/DeclarativeDragArea.cpp:211:38: warning: suggest parentheses around ‘’ within ‘||’ [-Wparentheses] [ 17%] Building CXX object src/plasma/CMakeFiles/plasma.dir/private/componentinstaller.cpp.o [ 18%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDropArea.cpp.o Scanning dependencies of target fullmodelaccesstest [ 19%] [ 19%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/columnproxymodeltest.cpp.o Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/columnproxymodel.cpp.o Generating moc_view.cpp Generating moc_widgetexplorer.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_layouttemplatepackagestructure.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_kcategorizeditemsviewmodels_p.cpp Generating moc_plasmaappletitemmodel_p.cpp Generating moc_widgetexplorerview.cpp [ 19%] Built target plasma-shell_automoc [ 20%] Building CXX object src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/__/core/tests/modeltest.cpp.o [ 20%] Building CXX object src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeMimeData.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/columnproxymodel.cpp:162:6: warning: unused parameter ‘source’ [-Wunused-parameter] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:60:52: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63: warning: ‘KCmdLineOptions’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:121:72: warning: ‘KCmdLineOptions’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:128:57: warning: ‘KCmdLineOptions’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:128:57: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:423:73: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:434:70: warning: ‘KCmdLineArgs’ is deprecated (declared at /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:279) [-Wdeprecated-declarations] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:654:38: warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations] In file included from /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:30:0, from http://build.kde.org/job/plasma-framework_master_qt5/ws/src/declarativeimports/qtextracomponents/tests/columnproxymodeltest.cpp:23: /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h: In function ‘T KGlobal::findDirectChild(const QObject*)’:
Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support
On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: I was just working on the same thing. I'm not sure if we want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets. Strigi doesn't need to be ported to Qt5 since it is does not use Qt. Soprano will have to be, but I don't think this code uses Soprano. You were working on it? -.- it didn't have your name on it... I think that the classes called plugin should be removed, there's not much else to remove otherwise. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37193 --- On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 5, 2013, 6:06 p.m.) Review request for KDE Frameworks and Vishesh Handa. Description --- As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support. It's worth noting that there are 2 plugins (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp Diffs - kio/CMakeLists.txt 035cf70 kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d kio/kfile/kfilemetadataconfigurationwidget.cpp kio/kfile/kfilemetadataprovider.cpp kio/kfile/kfilemetadataprovider_p.h 8009bf4 kio/kfile/kfilemetadatareader.cpp kio/kfile/kfilemetadatareader_p.h kio/kfile/kfilemetadatareaderprocess.cpp kio/kfile/kfilemetadatawidget.h 2dc4677 kio/kfile/kfilemetadatawidget.cpp kio/kfile/kmetaprops.h a08c380 kio/kfile/kmetaprops.cpp kio/kfile/knfotranslator.cpp kio/kfile/knfotranslator_p.h kio/kfile/kpreviewprops.h 8a974da kio/kfile/kpreviewprops.cpp kio/kfile/kpropertiesdialog.cpp 687e4bf staging/kde4support/src/CMakeLists.txt 1d6369f staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 Diff: http://git.reviewboard.kde.org/r/111897/diff/ Testing --- builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status? Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support
On Aug. 6, 2013, 9:39 a.m., Vishesh Handa wrote: You seem to have forgotten about kcommentwidget. It can be discarded/moved as well. Ok! Will do. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37195 --- On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 5, 2013, 6:06 p.m.) Review request for KDE Frameworks and Vishesh Handa. Description --- As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support. It's worth noting that there are 2 plugins (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp Diffs - kio/CMakeLists.txt 035cf70 kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d kio/kfile/kfilemetadataconfigurationwidget.cpp kio/kfile/kfilemetadataprovider.cpp kio/kfile/kfilemetadataprovider_p.h 8009bf4 kio/kfile/kfilemetadatareader.cpp kio/kfile/kfilemetadatareader_p.h kio/kfile/kfilemetadatareaderprocess.cpp kio/kfile/kfilemetadatawidget.h 2dc4677 kio/kfile/kfilemetadatawidget.cpp kio/kfile/kmetaprops.h a08c380 kio/kfile/kmetaprops.cpp kio/kfile/knfotranslator.cpp kio/kfile/knfotranslator_p.h kio/kfile/kpreviewprops.h 8a974da kio/kfile/kpreviewprops.cpp kio/kfile/kpropertiesdialog.cpp 687e4bf staging/kde4support/src/CMakeLists.txt 1d6369f staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 Diff: http://git.reviewboard.kde.org/r/111897/diff/ Testing --- builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status? Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support
On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: I was just working on the same thing. I'm not sure if we want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets. Strigi doesn't need to be ported to Qt5 since it is does not use Qt. Soprano will have to be, but I don't think this code uses Soprano. Aleix Pol Gonzalez wrote: You were working on it? -.- it didn't have your name on it... I think that the classes called plugin should be removed, there's not much else to remove otherwise. I'd just started today morning, then I decided to try and compile everything. It has been 5 hours since then. I'm still compiling. There is just one user visible class - KFileMetadataWidget. The rest of the classes are helper code. A large part of the helper code uses Nepomuk1. If we move this to kde4support, then those Nepomuk1 dependencies have to be removed. Removing them would make this into a wrapper over Strigi. The question is - do we want that? Or do we just want to discard this class completely? Based on [1] there seem to be 3 clients. Dolphin which uses it when Nepomuk compilation is disabled. Conquirere, which is a Nepomuk based app and should just use the one in nepomuk-widgets, and Konversation - I'm not sure what to do about them. If we throw away this class then we will just be breaking Konversation. I'm obviously in favor of discarding the class. Opinions? This also raises the larger question if we want classes in kde4support to depend on unmaintained code? (Strigi) [1] http://lxr.kde.org/ident?i=KFileMetaDataWidget - Vishesh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37193 --- On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 5, 2013, 6:06 p.m.) Review request for KDE Frameworks and Vishesh Handa. Description --- As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support. It's worth noting that there are 2 plugins (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp Diffs - kio/CMakeLists.txt 035cf70 kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d kio/kfile/kfilemetadataconfigurationwidget.cpp kio/kfile/kfilemetadataprovider.cpp kio/kfile/kfilemetadataprovider_p.h 8009bf4 kio/kfile/kfilemetadatareader.cpp kio/kfile/kfilemetadatareader_p.h kio/kfile/kfilemetadatareaderprocess.cpp kio/kfile/kfilemetadatawidget.h 2dc4677 kio/kfile/kfilemetadatawidget.cpp kio/kfile/kmetaprops.h a08c380 kio/kfile/kmetaprops.cpp kio/kfile/knfotranslator.cpp kio/kfile/knfotranslator_p.h kio/kfile/kpreviewprops.h 8a974da kio/kfile/kpreviewprops.cpp kio/kfile/kpropertiesdialog.cpp 687e4bf staging/kde4support/src/CMakeLists.txt 1d6369f staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 Diff: http://git.reviewboard.kde.org/r/111897/diff/ Testing --- builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status? Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support
On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: I was just working on the same thing. I'm not sure if we want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets. Strigi doesn't need to be ported to Qt5 since it is does not use Qt. Soprano will have to be, but I don't think this code uses Soprano. Aleix Pol Gonzalez wrote: You were working on it? -.- it didn't have your name on it... I think that the classes called plugin should be removed, there's not much else to remove otherwise. Vishesh Handa wrote: I'd just started today morning, then I decided to try and compile everything. It has been 5 hours since then. I'm still compiling. There is just one user visible class - KFileMetadataWidget. The rest of the classes are helper code. A large part of the helper code uses Nepomuk1. If we move this to kde4support, then those Nepomuk1 dependencies have to be removed. Removing them would make this into a wrapper over Strigi. The question is - do we want that? Or do we just want to discard this class completely? Based on [1] there seem to be 3 clients. Dolphin which uses it when Nepomuk compilation is disabled. Conquirere, which is a Nepomuk based app and should just use the one in nepomuk-widgets, and Konversation - I'm not sure what to do about them. If we throw away this class then we will just be breaking Konversation. I'm obviously in favor of discarding the class. Opinions? This also raises the larger question if we want classes in kde4support to depend on unmaintained code? (Strigi) [1] http://lxr.kde.org/ident?i=KFileMetaDataWidget Dolphin which uses it when Nepomuk compilation is disabled. Yes. However, I think we might want to drop the option to compile Dolphin without Nepomuk 2 when porting to Frameworks. Maintaining all the HAVE_NEPOMUK #ifdefs is not much fun, in particular not if the only benefit for the users who compile from source is that they can make Dolphin use unmaintained code. I'm obviously in favor of discarding the class. Opinions? I think that this is a good idea. Maybe one could make it a typedef for (or a very thin wrapper around) Nepomuk2::MetaDataWidget? Then removing all this unmaintained code would even be a source compatible change. Maybe this is not possible right now because kdelibs cannot depend on nepomuk-widgets, but in the long term, it makes sense IMHO to have kde4support depend on all KDE libs that are required to make the porting as easy as possible. - Frank --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37193 --- On Aug. 5, 2013, 6:06 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 5, 2013, 6:06 p.m.) Review request for KDE Frameworks and Vishesh Handa. Description --- As far as I've understood, we should have an alternative by Nepomuk for file previewing for KF5, this patch moves the KFileMetaInfo and the files that depend on it to KDE4Support. It's worth noting that there are 2 plugins (they're actually not plugins) of the KPropertiesDialog that have been disabled because they had to be moved with KFileMetaInfo. That is the kmetaprops.cpp and kpreviewprops.cpp Diffs - kio/CMakeLists.txt 035cf70 kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d kio/kfile/kfilemetadataconfigurationwidget.cpp kio/kfile/kfilemetadataprovider.cpp kio/kfile/kfilemetadataprovider_p.h 8009bf4 kio/kfile/kfilemetadatareader.cpp kio/kfile/kfilemetadatareader_p.h kio/kfile/kfilemetadatareaderprocess.cpp kio/kfile/kfilemetadatawidget.h 2dc4677 kio/kfile/kfilemetadatawidget.cpp kio/kfile/kmetaprops.h a08c380 kio/kfile/kmetaprops.cpp kio/kfile/knfotranslator.cpp kio/kfile/knfotranslator_p.h kio/kfile/kpreviewprops.h 8a974da kio/kfile/kpreviewprops.cpp kio/kfile/kpropertiesdialog.cpp 687e4bf staging/kde4support/src/CMakeLists.txt 1d6369f staging/kde4support/src/config-kde4support.h.cmake 03d3bf4 Diff: http://git.reviewboard.kde.org/r/111897/diff/ Testing --- builds... actually i'm not sure if there's Qt5 soprano/strigi. what's hte status? Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111906: Update QToolbar's when icon changes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/#review37205 --- staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp http://git.reviewboard.kde.org/r/111906/#comment27517 You could use a Q_FOREACH here. - Aurélien Gâteau On Aug. 6, 2013, 1:13 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/ --- (Updated Aug. 6, 2013, 1:13 p.m.) Review request for KDE Frameworks. Description --- This is the first part of: QToolBar should take its default settings from the global settings when running in a Plasma Workspace session (see loadKDESettings from KToolBar) Updates all the QToolbar's in the application when there is a change in the KIconLoader::Toolbar group. Diffs - staging/frameworkintegration/src/platformtheme/kdeplatformtheme.h edac8db staging/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp d46b5c8 Diff: http://git.reviewboard.kde.org/r/111906/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- Review request for KDE Frameworks and Plasma. Description --- Add KConfigLoader from Plasma Framework to KConfigGui The ConfigLoader is way to awesome to not be directly in KConfig. Diffs - tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111908/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 #552
See http://build.kde.org/job/plasma-framework_master_qt5/552/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w31
Kevin Ottens wrote:
On Thursday 01 August 2013 00:38:51 Stephen Kelly wrote:
Kevin Ottens wrote:
So, if this target/variable task is deferred until CMake 2.8.13 can be
used, the variables don't have to be used even in an intermediate
state.
I see, but when is 2.8.13 supposed to be released? I'd rather have us
move forward.
2.8.12 will be released in a few weeks. 2.8.13 about 3 months after that.
That's way too far in the future to be useful. Hopefully by then we'll
have started splitting (crossing fingers).
The feature was merged to CMake master today, so it will be part of 2.8.12.
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=370bf55415
So, we'll end up having code something like this:
add_library(KArchive ${karchive_SRCS})
# Read-only use of 'KF5::KArchive' is now the same as
# using 'KArchive' directly.
add_library(KF5::KArchive ALIAS KArchive)
# Works before and after split:
target_link_libraries(anything KF5::KArchive)
Thanks,
Steve.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111910: Deprecate unused methods + enum values in KEMailSettings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111910/ --- Review request for KDE Frameworks. Description --- I've looked through all usages of KEMailSettings on lxr, deprecated things in diff are nowhere used. Diffs - staging/kio/src/core/kemailsettings.h 873c222 staging/kio/src/core/kemailsettings.cpp 39dc9f7 Diff: http://git.reviewboard.kde.org/r/111910/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37219 --- As a non-Plasma user of this class, I fully support it being here. tier1/kconfig/src/gui/kconfigloader.h http://git.reviewboard.kde.org/r/111908/#comment27526 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now. tier1/kconfig/src/gui/kconfigloader.h http://git.reviewboard.kde.org/r/111908/#comment27527 const? See above. tier1/kconfig/src/gui/kconfigloader.h http://git.reviewboard.kde.org/r/111908/#comment27528 const? See above. - David Edmundson On Aug. 6, 2013, 12:25 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 6, 2013, 12:25 p.m.) Review request for KDE Frameworks and Plasma. Description --- Add KConfigLoader from Plasma Framework to KConfigGui The ConfigLoader is way to awesome to not be directly in KConfig. Diffs - tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111908/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now. please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37219 --- On Aug. 6, 2013, 2:25 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 6, 2013, 2:25 p.m.) Review request for KDE Frameworks and Plasma. Description --- Add KConfigLoader from Plasma Framework to KConfigGui The ConfigLoader is way to awesome to not be directly in KConfig. Diffs - tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111908/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111789: Improve KFileItemList memory usage and performance
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111789/#review37222 --- This review has been submitted with commit 0c01e89b329a846718e67dc59d216cdf6440e3f3 by Frank Reininghaus to branch frameworks. - Commit Hook On July 29, 2013, 10:39 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111789/ --- (Updated July 29, 2013, 10:39 p.m.) Review request for KDE Frameworks and David Faure. Description --- The other day, I noticed that KFileItem is not declared as a Q_MOVABLE_TYPE. Therefore, QList does not store KFileItems directly, but only pointers to them, and allocates memory for every single KFileItem separately. This wastes quite a bit of memory. It looks like now might be a good moment to fix this because we can break binary compatibility with KDE 4.x. Diffs - staging/kio/src/core/kfileitem.h 2c33f3c Diff: http://git.reviewboard.kde.org/r/111789/diff/ Testing --- My poor man's aproach to test the memory usage and performace is here: http://paste.kde.org/p46abc91f/ (the reason for the 10 second delay is that I needed some time to take a KSysGuard screen shot). It creates a KFileItemList with 1 million empty KFileItems. The memory usage change is shown in the pictures. I used both massif/massif-visualizer and KSysGuard to measure how much memory it uses. The KSysGuard measurement shows a far bigger difference - this is because massif only measures the net memory consumption and fails to consider the overhead which is caused by the memory allocator itself. The latter is quite considerable when many small memory allocations are made. Moreover, I also measured the runtime of the test (without massif). 5 measurements without patch required between 171 ms and 189 ms. 5 measurements with patch required between 98 ms and 106 ms. File Attachments Memory usage WITHOUT patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/before.png Memory usage WITH patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/after.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_frameworks_qt5 #982
See http://build.kde.org/job/kdelibs_frameworks_qt5/982/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2013-w32
Hello everyone, This is the minutes of the Week 31 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, albertvaka, apol, d_ed, mck182, mgraesslin, miroslav, PovAddict, sandsmark, sebas, shadeslayer, Sho, teo, vHanda and myself. Announcements: * Please pay attention to SC in your changes, it got broken too often lately. * KDEUI Crumble is done! Topics discussed: * afiestas finally merged SH_Widget_Animate in Qt/dev, will reach qt5.git soon, at that point the code will be ported away from KGlobalSettings; * he's also working on having QToolBar integrate with our settings; * agateau got his patches for icons in line and text edit context menus merged in; * he's looking in QTextEdit spellchecking; * he's also fixed sonnet plugins discovery; * albertvaka is working on the url dropping feature for QLineEdit and QComboBox; * mck182 is working on the icon overlays; * he's moving toward the printing support with shadeslayer and vHanda; * apol is working on the kde_file.h porting and is moving KFileMetaInfo to kde4support; * QCollator getting public is stuck, waiting for a decision to be taken in Qt regarding the patch; * shadeslayer is working on the QSplitter opaque resize task; * mgraesslin merged his changes in KWindowSystem and is working on Qt changes needed for KWin; * sandsmark confirmed the failing kpty test is indeed a regression, still trying to find where the error comes from; * sebas is half-way through his KPluginFactory related changes; * he's now reducing K_EXPORT_PLUGIN uses; * teo has been working on QMainWindow HIG compliant caption patch... turns out dfaure solved it already; * he's now looking into QSessionManager; * he's having some issues with kdesrc-build ignoring qtdir in some cases, to be reported to mpyne; * vHanda is giving a hand in the kde_file.h porting; * I've been working on cleaning up left overs in kdecore and kdeui; * currently kdeui and kdecore contain only kglobalsettings and kde_file; * kwidgets has been removed and some classes moved around as such; * KImageCache is in KGuiAddons now; * d_ed is working on having the default QKeySequence come from QPA's platform theme (and then our settings); * PovAddict is working on the repository splitting scripts. Action items still open: * [sandsmark] Finish the work on KPtyProcess * [steveire] Write a CMake for frameworks guideline in the wiki If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111911/
---
Review request for KDE Frameworks.
Description
---
A couple of issues -
1. KDE::open/stat/etc take a QString and convert it to a char* via
QFile::encodeName(str).constData(). Qt obviously does not have methods to do
so. Instead of me doing it manually for each call to QT_OPEN/QT_STAT/etc, would
be it okay for me to declare local functions called KDE::stat/open?
Something along the lines of -
namespace KDE {
int open(const QString filePath, ...) {
return QT_OPEN(QFile::encodeName(filePath).constData()), ...);
}
}
2. The kioslave uses KDE::utime to set the utime of file. I've used ::utime,
but that obviously won't work on non-unix platforms. What is the correct
solution?
One option is to add utime in qplatformdefs.h, but that is non trivial since Qt
seems to support about 104 different qplatformdefs and therefore all of them
will have to be updated.
Diffs
-
kioslave/ftp/ftp.cpp a0da54b
Diff: http://git.reviewboard.kde.org/r/111911/diff/
Testing
---
Doesn't even compile right now. With (1) it will start to compile.
Thanks,
Vishesh Handa
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/ --- Review request for KDE Frameworks. Description --- This patch introduces a new class: Sonnet::TextEditInstaller. It makes it easy to add spellcheck support to a QTextEdit. Spellcheck support means two things: 1. Install Sonnet::Highlighter to highlight spelling error. 2. Intercept context menu to replace it with a list of suggestions when user right-clicks on a misspelled word. Minimal usage is simple: create a new TextEditInstaller, passing it the QTextEdit as argument. The patch adds a test_textedit executable which demonstrates the class. I am posting it early to get feedback on the API and the class name, I am not completely happy with either. PS: This patch includes my plugin fixes [1], since it is useless without them. [1]: https://git.reviewboard.kde.org/r/111895/ Diffs - tier1/sonnet/src/core/loader.cpp 035cf64 tier1/sonnet/src/plugins/aspell/CMakeLists.txt 70f06d1 tier1/sonnet/src/ui/CMakeLists.txt 723d8f3 tier1/sonnet/src/ui/highlighter.h c303db1 tier1/sonnet/src/ui/highlighter.cpp e8ba703 tier1/sonnet/src/ui/texteditinstaller.h PRE-CREATION tier1/sonnet/src/ui/texteditinstaller.cpp PRE-CREATION tier1/sonnet/tests/CMakeLists.txt 90b3ab0 tier1/sonnet/tests/test_textedit.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111912/diff/ Testing --- Tested with test_textedit. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now. Martin Gräßlin wrote: please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged. Make you can add a comment or warning? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37219 --- On Aug. 6, 2013, 12:25 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 6, 2013, 12:25 p.m.) Review request for KDE Frameworks and Plasma. Description --- Add KConfigLoader from Plasma Framework to KConfigGui The ConfigLoader is way to awesome to not be directly in KConfig. Diffs - tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111908/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111916: Port khtml_part away from kde_file.h
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/ --- Review request for KDE Frameworks. Description --- Port khtml_part away from kde_file.h Diffs - khtml/khtml_part.cpp 189a98e Diff: http://git.reviewboard.kde.org/r/111916/diff/ Testing --- Compiles. The tests seem to segfault with and without this patch. I'll try to diagnose it. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 #555
See http://build.kde.org/job/plasma-framework_master_qt5/555/changes Changes: [ervin] KWidgets is gone [ervin] Add missing includes -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild steps [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson3152496609839654195.sh + /home/jenkins/scripts/setup-env.sh From git://anongit.kde.org/plasma-framework 100c940..418bcfa master - origin/master Branch jenkins set up to track remote branch master from origin. Success build forhudson.tasks.Shell@6964e4a3 Checkout:plasma-framework_master_qt5 / http://build.kde.org/job/plasma-framework_master_qt5/ws/ - hudson.remoting.Channel@604c442b:LinuxSlave - 3 Using strategy: Default Last Built Revision: Revision 7e8f62acad0cab5cd3b4db482ee62ad7ac0bd42a (refs/heads/jenkins) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 418bcfa75abb8fcf470a4cb378bca1ce676e0add (refs/heads/jenkins) Checking out Revision 418bcfa75abb8fcf470a4cb378bca1ce676e0add (refs/heads/jenkins) [plasma-framework_master_qt5] $ /bin/sh -xe /tmp/hudson1054324067206724.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: plasma-framework - Branch master == Build Dependencies: strigiclient - Branch master extra-cmake-modules - Branch master attica - Branch master strigiutils - Branch master kdelibs - Branch frameworks libstreamanalyzer - Branch master libstreams - Branch master qt5 - Branch dev strigidaemon - Branch master == Cleaning Source Tree HEAD is now at 418bcfa Add missing includes Removing build/ Removing install/ == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.6.0 -- The CXX compiler identification is GNU 4.6.0 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECMakeSettings.cmake -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- KF5[Compiler]: Loaded settings from /srv/jenkins/install/linux/x64_64/g++/qt5/kdesupport/extra-cmake-modules/master/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[KIdleTime]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake -- KF5[ItemModels]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ItemModels/ItemModelsConfig.cmake -- KF5[KWidgetsAddons]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake -- KF5[KWindowSystem]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake -- KF5[KCodecs]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCodecs/KCodecsConfig.cmake -- KF5[KArchive]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KArchive/KArchiveConfig.cmake -- KF5[KCoreAddons]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake -- KF5[Solid]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/Solid/SolidConfig.cmake -- KF5[ThreadWeaver]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake -- KF5[KConfig]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KConfig/KConfigConfig.cmake -- KF5[KAuth]: Loaded /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KAuth/KAuthConfig.cmake -- KF5[KJS]: Loaded
Jenkins build is back to normal : kdelibs_frameworks_qt5 #987
See http://build.kde.org/job/kdelibs_frameworks_qt5/987/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : plasma-framework_master_qt5 #556
See http://build.kde.org/job/plasma-framework_master_qt5/556/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kdelibs_stable #755
See http://build.kde.org/job/kdelibs_stable/755/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111927: remove K_EXPORT_PLUGIN macro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/ --- Review request for KDE Frameworks. Description --- Remove K_EXPORT_PLUGIN throughout. The recent changes to the K_PLUGIN_FACTORY macro make this unnecessary. The macro is in fact already a no-op. I have this branch split out in patches per module. Diffs - interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp b5b0f7b kfile/kfilemodule.cpp 1c51d16 kio/kssl/kcm/kcmssl.cpp 6dd19e4 kio/misc/kpac/proxyscout.cpp 6451c04 kioslave/http/kcookiejar/kcookieserver.cpp 5432859 kparts/tests/notepad.cpp 5eb9fcf kparts/tests/plugin_spellcheck.cpp 15509d8 kutils/kcmodulecontainer.h db6e435 kutils/ksettings/README.dox 7f2210d kutils/ksettings/pluginpage.h ded17e7 staging/kconfigwidgets/src/kcmodule.h 74333c1 staging/kde4support/autotests/klibloadertest4_module.cpp 7c1eec2 staging/kemoticons/src/providers/adium/adium_emoticons.cpp 35414e9 staging/kemoticons/src/providers/kde/kde_emoticons.cpp 570afb3 staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp d24792f staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 12ee96a staging/kio/src/kssld/kssld.cpp 52bc7b6 staging/kio/src/widgets/kabstractfileitemactionplugin.h 19b872b staging/kservice/src/plugin/kpluginloader.h 7562ee4 tier1/kconfig/src/core/kconfigbackend.h bce9fd1 Diff: http://git.reviewboard.kde.org/r/111927/diff/ Testing --- No regressions observed in tests. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review37244 --- This review has been submitted with commit 4df6c4926ef1d01acea6a85dfc5bca3bea8a40df by Sebastian Kügler to branch frameworks. - Commit Hook On Aug. 7, 2013, 1:20 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 7, 2013, 1:20 a.m.) Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/src/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/src/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/src/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/src/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 7, 2013, 1:28 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Description --- Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system. Diffs - staging/kservice/src/desktoptojson/CMakeLists.txt PRE-CREATION staging/kservice/src/desktoptojson/kconfigtojson.h PRE-CREATION staging/kservice/src/desktoptojson/kconfigtojson.cpp PRE-CREATION staging/kservice/src/desktoptojson/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111689/diff/ Testing --- Converted metadata of several plugins and used them from QPluginLoader -- works. Thanks, Sebastian Kügler ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_frameworks_qt5 #990
See http://build.kde.org/job/kdelibs_frameworks_qt5/990/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui
On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.h, line 112 http://git.reviewboard.kde.org/r/111908/diff/1/?file=176360#file176360line112 This looks like it should be const I suspect it wasn't because KCoreConfigSeleton::findItem was not const in KDE4, but it appears to be now. Martin Gräßlin wrote: please note that I just moved the code over and changed the name from Plasma::ConfigLoader to KConfigLoader. I did not change the code and I think it would be wrong to change the code in the same step. Because of that I drop the three issues, though it would probably make sense to do these changes after this review is merged. Aleix Pol Gonzalez wrote: Make you can add a comment or warning? Albert Astals Cid wrote: What's the point of this review request if you're not going to accept any review? IOW what are you expecting people to say in this review request? IOW what are you expecting people to say in this review request? That it's OK to move the code to this location. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37219 --- On Aug. 6, 2013, 2:25 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 6, 2013, 2:25 p.m.) Review request for KDE Frameworks and Plasma. Description --- Add KConfigLoader from Plasma Framework to KConfigGui The ConfigLoader is way to awesome to not be directly in KConfig. Diffs - tier1/kconfig/autotests/CMakeLists.txt PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.h PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.cpp PRE-CREATION tier1/kconfig/autotests/kconfigloadertest.xml PRE-CREATION tier1/kconfig/src/gui/CMakeLists.txt PRE-CREATION tier1/kconfig/src/gui/kconfigloader.h PRE-CREATION tier1/kconfig/src/gui/kconfigloader.cpp PRE-CREATION tier1/kconfig/src/gui/kconfigloader_p.h PRE-CREATION tier1/kconfig/src/gui/kconfigloaderhandler_p.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/111908/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
