Re: Superbuild in kdelibs
Le vendredi 22 novembre 2013 19:55:52 Ben Cooksley a écrit : On Fri, Nov 22, 2013 at 3:52 AM, Aurélien Gâteau agat...@kde.org wrote: Hi, Hi, This morning I merged my superbuild changes in the frameworks branch. Superbuild support was originally enabled by default, but I turned it off because it broke on build.kde.org. You can turn it on by passing -DSUPERBUILD=ON to cmake. When superbuild is enabled, you can build any framework standalone with `make sb_$framework`. This will: - create a separate build dir for the framework in $build/superbuild/$framework - run cmake in this dir - run make - run make install You can also build all frameworks standalone at once with `make sb_all`. Regarding build.kde.org: build failed because it defines a DESTDIR environment variable but does not set CMAKE_SKIP_RPATH, which superbuild does not like: CMake Error at superbuild/SuperBuild.cmake:61 (message): The DESTDIR environment variable is set to /srv/jenkins/workspace/kdelibs_frameworks_qt5/install, but CMAKE_SKIP_RPATH is not set to TRUE. This would produce binaries with bad RPATHs. Call Stack (most recent call first): superbuild/CMakeLists.txt:7 (include) I am not sure what is the best approach to this, advices are welcome. Once this is sorted out, I would like to see build.kde.org run `make sb_all` before running the classic `make` command so that we can catch standalone breakage. We can do that. In terms of CMAKE_SKIP_RPATH, that sounds like a bad idea as it will probably break things like meinproc5 for the regular (non-Super) build. I've no idea why it is complaining about DESTDIR being set - it should have no effect as far as I know, but i'm no expert in these matters. I'd suggest disabling this check if we can, but i'll defer to those who know more in the area of RPATH and equivalent variables. Up to this point it has not caused us any issues wrt execution of tests for any of the binaries used on the CI system - otherwise CMake itself, kdeinit, kded, etc wouldn't work. I just disabled it, so that you can give it a try. Can you modify kdelibs job definition so that cmake is called with -DSUPERBUILD=ON and make sb_all is called first, then make? Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: K4AboutData
On Tuesday 26 November 2013 09:56:54 Stephen Kelly wrote: I looked into this to try to understand, but I still don't understand why a patch something like this can not be applied: The problem is with the code in main(), that would call this. KCmdLineArgs *has* to be used before the QCoreApplication constructor. KAboutData requires i18n() or tr(). i18n() or tr() has to be used *after* the QCoreApplication constructor. GOTO 10. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: imageformat plugins
Le mardi 26 novembre 2013 00:54:16 Alex Merry a écrit : It occurred to me that KGuiAddons might not be the best place for the imageformat plugins, and that they should maybe become their own framework (either tier1 or tier4). The only thing that relates the KGuiAddons library and the imageformat plugins is that they are both to do with QtGui. Each can be used without the other just fine, and there is no particular reason why someone wanting the library should want to install the plugins or vice versa. What do other people think about this? Having the imageformat plugins in their own repositories makes sense to me. I think they can go in tier1, but I am not the master of the tiers. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: further coinstallability
On Tuesday 26 November 2013 15:04:09 Aurélien Gâteau wrote: Le samedi 23 novembre 2013 18:19:53 Jonathan Riddell a écrit : some libs with an soname of 5 in kdelibs4 keep an soname of 5 in KF5. I found libkhtml.so.5 which is now libKHtml.so.5 which will clash for package names which are all lower case. There may be others. Ah damned... This problem solved itself since all the libraries with a +1 version are gone... all except one in fact. Really overlooked khtml there. :-/ Maybe the name of the lib could be changed so that the KF5 version of KHTML becomes libKhtml5.so? Yes, let's do that for khtml. This would be similar to what Qt5 libs do: they all start with libQt5. Makes me wonder, is it something we'd like to do too? Having all our libs named libKf5Foo? I don't think I have an opinion either way. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: imageformat plugins
On 26/11/13 14:36, Kevin Ottens wrote: On Tuesday 26 November 2013 15:00:08 Aurélien Gâteau wrote: Le mardi 26 novembre 2013 00:54:16 Alex Merry a écrit : What do other people think about this? Having the imageformat plugins in their own repositories make sense to me. I think they can go in tier1, but I am not the master of the tiers. OK, please someone make it happen then. And yes tier1 is the right place for that one. Will do. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: imageformat plugins
On Tuesday 26 November 2013 02:12:25 Christoph Feck wrote: What remains could even be upstreamed to QtImageFormats repository? This requires rewriting the code from scratch, though, for licensing reasons. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review44506 --- Ship it! tier1/kwindowsystem/src/kstartupinfo.cpp http://git.reviewboard.kde.org/r/113877/#comment31792 The TODO seems to be very old and a leftover, I would remove it, now that we know what this is actually for. Or replace with give kdesu time to get a password - David Faure On Nov. 26, 2013, 6:31 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 26, 2013, 6:31 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- If there were multiple KStartupInfoIds which were removed at the same time, it was possible that the map got changed while being iterated, thus the data corrupted and we hit a crash later on. This changes to a QMutableMapIterator for checking the cleanup and allowing to safely remove ids during the iteration. Diffs - tier1/kwindowsystem/autotests/kstartupinfo_unittest.cpp 17890ff tier1/kwindowsystem/src/kstartupinfo.cpp c2ff7c2 Diff: http://git.reviewboard.kde.org/r/113877/diff/ Testing --- When running the unit tests on the old code base it isn't guaranteed that it crashes as it's a race and also depends on X. Just run a few times and it will certainly hit the abort condition. For reference the backtrace of the crash before fix: #0 0x750131e5 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x75016398 in __GI_abort () at abort.c:90 #2 0x75c3d402 in qt_message_fatal (context=..., message=...) at global/qlogging.cpp:979 #3 0x75c3afce in QMessageLogger::fatal (this=0x7fffbbc0, msg=0x75f8d9f8 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:384 #4 0x75c369e6 in qt_assert (assertion=0x75f8b7f0 size == 0 || offset 0 || size_t(offset) = sizeof(QArrayData), file=0x75f8b7b0 ../../include/QtCore/../../src/corelib/tools/qarraydata.h, line=62) at global/qglobal.cpp:2088 #5 0x75c29bf8 in QArrayData::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:61 #6 0x75c3015e in QTypedArrayDatachar::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:207 #7 0x75c2fde7 in QByteArray::constData (this=0x6f4760) at ../../include/QtCore/../../src/corelib/tools/qbytearray.h:433 #8 0x75c5 in qstrcmp (str1=..., str2=...) at tools/qbytearray.cpp:347 #9 0x77ba4625 in operator (a1=..., a2=...) at /opt/qt5/include/QtCore/qbytearray.h:550 #10 0x77ba0eb9 in KStartupInfoId::operator (this=0x693858, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:1175 #11 0x77ba67b5 in qMapLessThanKeyKStartupInfoId (key1=..., key2=...) at /opt/qt5/include/QtCore/qmap.h:75 #12 0x77ba6ef3 in QMapNodeKStartupInfoId, KStartupInfo::Data::lowerBound (this=0x693840, akey=...) at /opt/qt5/include/QtCore/qmap.h:145 #13 0x77ba66b4 in QMapDataKStartupInfoId, KStartupInfo::Data::findNode (this=0x700870, akey=...) at /opt/qt5/include/QtCore/qmap.h:292 #14 0x77ba5a73 in QMapKStartupInfoId, KStartupInfo::Data::remove (this=0x65acc0, akey=...) at /opt/qt5/include/QtCore/qmap.h:897 #15 0x77b9dd42 in KStartupInfo::Private::remove_startup_info_internal (this=0x65acb0, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:399 #16 0x77ba039b in KStartupInfo::Private::startups_cleanup_internal (this=0x65acb0, age_P=true) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:984 #17 0x77ba02bf in KStartupInfo::Private::startups_cleanup (this=0x65acb0) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:965 #18 0x77ba3d1c in KStartupInfo::qt_static_metacall (_o=0x7fffdc60, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fffbf70) at /opt/build/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/moc_kstartupinfo.cpp:106 #19 0x75ef8c9f in QMetaObject::activate (sender=0x684d50, signalOffset=3, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3530 #20 0x75ef84f0 in QMetaObject::activate (sender=0x684d50, m=0x763ab980 QTimer::staticMetaObject, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3405 #21 0x75f88fc3 in QTimer::timeout (this=0x684d50) at .moc/moc_qtimer.cpp:189 #22 0x75f03bc5 in QTimer::timerEvent (this=0x684d50, e=0x7fffca30) at
KF5 Update Meeting Minutes 2013-w48
Hello everyone, This is the minutes of the Week 48 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, dfaure, markg85, mgraesslin, miroslav, randomguy3, Riddell, sebas, svuorela, teo and myself. Announcement: * We're close to be ready for splitting, please finish all pending tasks and patches, don't start any new work otherwise; * I will be unavailable for the next three tuesdays, afiestas will replace me during those three weeks; * afiestas has been mostly working on kde-workspace (powerdevil, plasma2 using kded5, etc.); * he'll work on the last kstyle task as wojtask9 is MIA; * agateau kept working on the standalone builds; * he found out with dfaure that the cmake dependency issue might not be one after all, so please people don't add too many dependencies for now; * he also pushed a workaround for the desktop_to_json race condition (still requires a proper fix); * and last but not least he fixed superbuild on build.k.o (to be enabled); * in other news dbusmenu-qt config files got upstreamed; * apol worked on the standalone builds for the tier4 modules; * he also started to remove kde4support dependencies when possible; * markg85 is trying to revive some patches to QFSW for Qt 5.3 which might allow to deprecate KDirWatch in KF 5.1; * mgraesslin is putting the final touch to his changes for startup info; * dfaure worked on a script to split the repository including git graft to reach old history (same setup as Qt); * he's also working on an astyle based script; * and he also helped to get everything running in superbuild; * miroslav is preparing some further improvements for threadweaver; * randomguy3 has further patches related to the splitting; * in particular they move the last remaining staging bits to their final place; * and a patch is coming to move the imageformat plugins out of kguiaddons; * Riddell is still working on coinstallability; * he's also working on finding proper homes for kde-runtime components; * sebas is still working on the panel applets; * teo is making progress on ksmserver but a change in kservice introduced a regression; * ervin reviews as usual; * helped with the standalone builds to get it completed; * also did test for the splitting script and preparing the transition plan. If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114127: Fix KIO superbuild dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114127/#review44511 --- Ship it! Ship It! - Kevin Ottens On Nov. 25, 2013, 10:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114127/ --- (Updated Nov. 25, 2013, 10:50 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KIO superbuild dependencies KIO require KNotifications to build. Without this patch, running make sb_kio in a clean environment (no existing KF5 installation) fails. Diffs - superbuild/CMakeLists.txt b98f09181de49c0c76394a9bdcc237f2e70fc221 Diff: http://git.reviewboard.kde.org/r/114127/diff/ Testing --- make sb_kio now succeeds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114127: Fix KIO superbuild dependencies
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114127/#review44512 --- This review has been submitted with commit 12aa8a754e97522e0f1ca7aa2de2fa655b3d903f by Alex Merry to branch frameworks. - Commit Hook On Nov. 25, 2013, 10:50 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114127/ --- (Updated Nov. 25, 2013, 10:50 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix KIO superbuild dependencies KIO require KNotifications to build. Without this patch, running make sb_kio in a clean environment (no existing KF5 installation) fails. Diffs - superbuild/CMakeLists.txt b98f09181de49c0c76394a9bdcc237f2e70fc221 Diff: http://git.reviewboard.kde.org/r/114127/diff/ Testing --- make sb_kio now succeeds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Split imageformat plugins from kguiaddons, as kimageformats Fix KIO superbuild dependencies Diffs - superbuild/CMakeLists.txt b98f09181de49c0c76394a9bdcc237f2e70fc221 tier1/CMakeLists.txt 5b41494837166f73d786a9d3c907b858357ca5a8 tier1/kguiaddons/CMakeLists.txt 763883a39eb4701c349b5f4c7c8870e8f724acbb tier1/kguiaddons/cmake/FindOpenEXR.cmake tier1/kguiaddons/src/CMakeLists.txt 61e7320353cbac3b91196e74ff33f00f08f5a0ef tier1/kguiaddons/src/lib/CMakeLists.txt ca94f4b074deb916ce60fd40b9af756d226ec873 tier1/kguiaddons/src/lib/colors/kcolorcollection.h tier1/kguiaddons/src/lib/colors/kcolorcollection.cpp tier1/kguiaddons/src/lib/colors/kcolormimedata.h tier1/kguiaddons/src/lib/colors/kcolormimedata.cpp tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h tier1/kguiaddons/src/lib/colors/kcolorutils.h tier1/kguiaddons/src/lib/colors/kcolorutils.cpp tier1/kguiaddons/src/lib/colors/kguiaddons_colorhelpers_p.h tier1/kguiaddons/src/lib/fonts/kfontutils.h tier1/kguiaddons/src/lib/fonts/kfontutils.cpp tier1/kguiaddons/src/lib/text/kdatevalidator.h tier1/kguiaddons/src/lib/text/kdatevalidator.cpp tier1/kguiaddons/src/lib/text/kwordwrap.h tier1/kguiaddons/src/lib/text/kwordwrap.cpp tier1/kguiaddons/src/lib/util/kiconutils.h tier1/kguiaddons/src/lib/util/kiconutils.cpp tier1/kguiaddons/src/lib/util/kimagecache.h tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.h tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.cpp tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.h tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp tier1/kguiaddons/src/lib/util/urlhandler.cpp tier1/kguiaddons/src/plugins/imageformats/AUTHORS tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt tier1/kguiaddons/src/plugins/imageformats/Mainpage.dox tier1/kguiaddons/src/plugins/imageformats/README tier1/kguiaddons/src/plugins/imageformats/bmp.desktop tier1/kguiaddons/src/plugins/imageformats/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/imageformats/dds.h tier1/kguiaddons/src/plugins/imageformats/dds.cpp tier1/kguiaddons/src/plugins/imageformats/dds.desktop tier1/kguiaddons/src/plugins/imageformats/dds.json tier1/kguiaddons/src/plugins/imageformats/eps.cpp tier1/kguiaddons/src/plugins/imageformats/eps.desktop tier1/kguiaddons/src/plugins/imageformats/eps.h tier1/kguiaddons/src/plugins/imageformats/eps.json tier1/kguiaddons/src/plugins/imageformats/exr.cpp tier1/kguiaddons/src/plugins/imageformats/exr.desktop tier1/kguiaddons/src/plugins/imageformats/exr.h tier1/kguiaddons/src/plugins/imageformats/exr.json tier1/kguiaddons/src/plugins/imageformats/gif.desktop tier1/kguiaddons/src/plugins/imageformats/gimp.h tier1/kguiaddons/src/plugins/imageformats/hdr.cpp tier1/kguiaddons/src/plugins/imageformats/hdr.desktop tier1/kguiaddons/src/plugins/imageformats/hdr.h tier1/kguiaddons/src/plugins/imageformats/ico.desktop tier1/kguiaddons/src/plugins/imageformats/jp2.cpp tier1/kguiaddons/src/plugins/imageformats/jp2.desktop tier1/kguiaddons/src/plugins/imageformats/jp2.h tier1/kguiaddons/src/plugins/imageformats/jp2.json tier1/kguiaddons/src/plugins/imageformats/jpeg.desktop tier1/kguiaddons/src/plugins/imageformats/mng.desktop tier1/kguiaddons/src/plugins/imageformats/pbm.desktop tier1/kguiaddons/src/plugins/imageformats/pcx.cpp tier1/kguiaddons/src/plugins/imageformats/pcx.desktop tier1/kguiaddons/src/plugins/imageformats/pcx.h tier1/kguiaddons/src/plugins/imageformats/pcx.json tier1/kguiaddons/src/plugins/imageformats/pgm.desktop tier1/kguiaddons/src/plugins/imageformats/pic.cpp tier1/kguiaddons/src/plugins/imageformats/pic.desktop tier1/kguiaddons/src/plugins/imageformats/pic.h tier1/kguiaddons/src/plugins/imageformats/pic.json tier1/kguiaddons/src/plugins/imageformats/pic_read.cpp tier1/kguiaddons/src/plugins/imageformats/pic_rw.h tier1/kguiaddons/src/plugins/imageformats/pic_write.cpp tier1/kguiaddons/src/plugins/imageformats/png.desktop tier1/kguiaddons/src/plugins/imageformats/pnm.desktop tier1/kguiaddons/src/plugins/imageformats/ppm.desktop tier1/kguiaddons/src/plugins/imageformats/psd.cpp tier1/kguiaddons/src/plugins/imageformats/psd.desktop
Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/ --- (Updated Nov. 26, 2013, 4:30 p.m.) Review request for KDE Frameworks. Changes --- Oops, another commit got tangled up in the first diff. Repository: kdelibs Description (updated) --- Split imageformat plugins from kguiaddons, as kimageformats Diffs (updated) - superbuild/CMakeLists.txt b98f091 tier1/CMakeLists.txt 5b41494 tier1/kguiaddons/CMakeLists.txt 763883a tier1/kguiaddons/cmake/FindOpenEXR.cmake b4ae656 tier1/kguiaddons/src/CMakeLists.txt 61e7320 tier1/kguiaddons/src/colors/kcolorcollection.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorcollection.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.h PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces_p.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.cpp PRE-CREATION tier1/kguiaddons/src/colors/kguiaddons_colorhelpers_p.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.cpp PRE-CREATION tier1/kguiaddons/src/lib/CMakeLists.txt ca94f4b tier1/kguiaddons/src/lib/colors/kcolorcollection.h 11845af tier1/kguiaddons/src/lib/colors/kcolorcollection.cpp 4d1dca7 tier1/kguiaddons/src/lib/colors/kcolormimedata.h 859b164 tier1/kguiaddons/src/lib/colors/kcolormimedata.cpp fd3ad4a tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 25fd8dd tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h 7630d09 tier1/kguiaddons/src/lib/colors/kcolorutils.h 8d1b13e tier1/kguiaddons/src/lib/colors/kcolorutils.cpp e7034d9 tier1/kguiaddons/src/lib/colors/kguiaddons_colorhelpers_p.h 6d653ae tier1/kguiaddons/src/lib/fonts/kfontutils.h d0a5651 tier1/kguiaddons/src/lib/fonts/kfontutils.cpp 3a80039 tier1/kguiaddons/src/lib/text/kdatevalidator.h a93d7fb tier1/kguiaddons/src/lib/text/kdatevalidator.cpp 8d9d7c1 tier1/kguiaddons/src/lib/text/kwordwrap.h 0e3bacf tier1/kguiaddons/src/lib/text/kwordwrap.cpp 49c0cfd tier1/kguiaddons/src/lib/util/kiconutils.h a7e15b2 tier1/kguiaddons/src/lib/util/kiconutils.cpp 00b24c9 tier1/kguiaddons/src/lib/util/kimagecache.h 682aa66 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.h dc86426 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.cpp 394eac0 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.h a5b1785 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp 7068d6f tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp 696c577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp a184ba5 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h 676f577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 77cce38 tier1/kguiaddons/src/lib/util/urlhandler.cpp b555dfd tier1/kguiaddons/src/plugins/imageformats/AUTHORS 8d72dc9 tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 614bba0 tier1/kguiaddons/src/plugins/imageformats/Mainpage.dox d63f10e tier1/kguiaddons/src/plugins/imageformats/README a72aa1d tier1/kguiaddons/src/plugins/imageformats/bmp.desktop bb880ae tier1/kguiaddons/src/plugins/imageformats/config-kimgio.h.cmake 1ef5135 tier1/kguiaddons/src/plugins/imageformats/dds.cpp 19ddbe0 tier1/kguiaddons/src/plugins/imageformats/dds.desktop 27f0318 tier1/kguiaddons/src/plugins/imageformats/dds.h 51c9fd7 tier1/kguiaddons/src/plugins/imageformats/dds.json bc30795 tier1/kguiaddons/src/plugins/imageformats/eps.cpp af521d7 tier1/kguiaddons/src/plugins/imageformats/eps.desktop 4a4160f tier1/kguiaddons/src/plugins/imageformats/eps.h df2b3ff tier1/kguiaddons/src/plugins/imageformats/eps.json 4a7aeaf tier1/kguiaddons/src/plugins/imageformats/exr.cpp 5d8a502 tier1/kguiaddons/src/plugins/imageformats/exr.desktop 6725314 tier1/kguiaddons/src/plugins/imageformats/exr.h 3ae9e16 tier1/kguiaddons/src/plugins/imageformats/exr.json f5ae145 tier1/kguiaddons/src/plugins/imageformats/gif.desktop a507b76 tier1/kguiaddons/src/plugins/imageformats/gimp.h cb697b8 tier1/kguiaddons/src/plugins/imageformats/hdr.cpp f59fc95 tier1/kguiaddons/src/plugins/imageformats/hdr.desktop d355d52 tier1/kguiaddons/src/plugins/imageformats/hdr.h 1b948de tier1/kguiaddons/src/plugins/imageformats/ico.desktop 9cf9cd3 tier1/kguiaddons/src/plugins/imageformats/jp2.cpp c0856dd tier1/kguiaddons/src/plugins/imageformats/jp2.desktop 3d673c6 tier1/kguiaddons/src/plugins/imageformats/jp2.h b8d4c7f tier1/kguiaddons/src/plugins/imageformats/jp2.json 3ff6cde tier1/kguiaddons/src/plugins/imageformats/jpeg.desktop 7614ef6 tier1/kguiaddons/src/plugins/imageformats/mng.desktop 12ddefd
Re: Review Request 112463: Port SMB kioslave to KF5/Qt5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review44515 --- It's been stalled for almost three months now, any chance to see progress or should it be discarded? - Kevin Ottens On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ --- (Updated Sept. 2, 2013, 7:16 p.m.) Review request for KDE Runtime and KDE Frameworks. Repository: kde-runtime Description --- This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly. Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x Once i know that this is actually working then i will comment some qDebug lines. Diffs - kioslave/CMakeLists.txt ff66ab6 kioslave/smb/CMakeLists.txt a3a2265 kioslave/smb/kio_smb.h 55efb44 kioslave/smb/kio_smb.cpp 2c2523a kioslave/smb/kio_smb_auth.cpp 4d236b4 kioslave/smb/kio_smb_browse.cpp fec6449 kioslave/smb/kio_smb_config.cpp 81ce29c kioslave/smb/kio_smb_dir.cpp 5573266 kioslave/smb/kio_smb_file.cpp 827a519 kioslave/smb/kio_smb_internal.h b895b81 kioslave/smb/kio_smb_internal.cpp 3c35583 kioslave/smb/kio_smb_mount.cpp a5a7e8e Diff: http://git.reviewboard.kde.org/r/112463/diff/ Testing --- It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats
On Nov. 26, 2013, 5:23 p.m., Kevin Ottens wrote: tier1/kimageformats/src/CMakeLists.txt, line 1 http://git.reviewboard.kde.org/r/114141/diff/2/?file=220425#file220425line1 No need for this extra sub-folder IMO. Just put it all under src/ It's needed to make the test app work (QtGui expects the plugins to be in a folder called imageformats). - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/#review44519 --- On Nov. 26, 2013, 4:30 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/ --- (Updated Nov. 26, 2013, 4:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Split imageformat plugins from kguiaddons, as kimageformats Diffs - superbuild/CMakeLists.txt b98f091 tier1/CMakeLists.txt 5b41494 tier1/kguiaddons/CMakeLists.txt 763883a tier1/kguiaddons/cmake/FindOpenEXR.cmake b4ae656 tier1/kguiaddons/src/CMakeLists.txt 61e7320 tier1/kguiaddons/src/colors/kcolorcollection.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorcollection.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.h PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces_p.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.cpp PRE-CREATION tier1/kguiaddons/src/colors/kguiaddons_colorhelpers_p.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.cpp PRE-CREATION tier1/kguiaddons/src/lib/CMakeLists.txt ca94f4b tier1/kguiaddons/src/lib/colors/kcolorcollection.h 11845af tier1/kguiaddons/src/lib/colors/kcolorcollection.cpp 4d1dca7 tier1/kguiaddons/src/lib/colors/kcolormimedata.h 859b164 tier1/kguiaddons/src/lib/colors/kcolormimedata.cpp fd3ad4a tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 25fd8dd tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h 7630d09 tier1/kguiaddons/src/lib/colors/kcolorutils.h 8d1b13e tier1/kguiaddons/src/lib/colors/kcolorutils.cpp e7034d9 tier1/kguiaddons/src/lib/colors/kguiaddons_colorhelpers_p.h 6d653ae tier1/kguiaddons/src/lib/fonts/kfontutils.h d0a5651 tier1/kguiaddons/src/lib/fonts/kfontutils.cpp 3a80039 tier1/kguiaddons/src/lib/text/kdatevalidator.h a93d7fb tier1/kguiaddons/src/lib/text/kdatevalidator.cpp 8d9d7c1 tier1/kguiaddons/src/lib/text/kwordwrap.h 0e3bacf tier1/kguiaddons/src/lib/text/kwordwrap.cpp 49c0cfd tier1/kguiaddons/src/lib/util/kiconutils.h a7e15b2 tier1/kguiaddons/src/lib/util/kiconutils.cpp 00b24c9 tier1/kguiaddons/src/lib/util/kimagecache.h 682aa66 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.h dc86426 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.cpp 394eac0 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.h a5b1785 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp 7068d6f tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp 696c577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp a184ba5 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h 676f577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 77cce38 tier1/kguiaddons/src/lib/util/urlhandler.cpp b555dfd tier1/kguiaddons/src/plugins/imageformats/AUTHORS 8d72dc9 tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 614bba0 tier1/kguiaddons/src/plugins/imageformats/Mainpage.dox d63f10e tier1/kguiaddons/src/plugins/imageformats/README a72aa1d tier1/kguiaddons/src/plugins/imageformats/bmp.desktop bb880ae tier1/kguiaddons/src/plugins/imageformats/config-kimgio.h.cmake 1ef5135 tier1/kguiaddons/src/plugins/imageformats/dds.cpp 19ddbe0 tier1/kguiaddons/src/plugins/imageformats/dds.desktop 27f0318 tier1/kguiaddons/src/plugins/imageformats/dds.h 51c9fd7 tier1/kguiaddons/src/plugins/imageformats/dds.json bc30795 tier1/kguiaddons/src/plugins/imageformats/eps.cpp af521d7 tier1/kguiaddons/src/plugins/imageformats/eps.desktop 4a4160f tier1/kguiaddons/src/plugins/imageformats/eps.h df2b3ff tier1/kguiaddons/src/plugins/imageformats/eps.json 4a7aeaf tier1/kguiaddons/src/plugins/imageformats/exr.cpp 5d8a502 tier1/kguiaddons/src/plugins/imageformats/exr.desktop 6725314 tier1/kguiaddons/src/plugins/imageformats/exr.h 3ae9e16 tier1/kguiaddons/src/plugins/imageformats/exr.json f5ae145 tier1/kguiaddons/src/plugins/imageformats/gif.desktop a507b76
Re: Review Request 114128: Move kmediaplayer to tier3
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114128/ --- (Updated Nov. 26, 2013, 5:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Move kmediaplayer to tier3 Diffs - staging/CMakeLists.txt 5b5cc2c7df4c3ca8b44bd25d1368e35a1fada4d9 staging/kmediaplayer/CMakeLists.txt staging/kmediaplayer/KMediaPlayerConfig.cmake.in staging/kmediaplayer/autotests/CMakeLists.txt staging/kmediaplayer/autotests/playertest.cpp staging/kmediaplayer/autotests/testplayer.h staging/kmediaplayer/autotests/testview.h staging/kmediaplayer/autotests/viewtest.cpp staging/kmediaplayer/src/CMakeLists.txt staging/kmediaplayer/src/kmediaplayer/CMakeLists.txt staging/kmediaplayer/src/kmediaplayer/Mainpage.dox staging/kmediaplayer/src/kmediaplayer/kmediaplayer.desktop staging/kmediaplayer/src/kmediaplayer/kmediaplayeradaptor.cpp staging/kmediaplayer/src/kmediaplayer/kmediaplayeradaptor_p.h staging/kmediaplayer/src/kmediaplayer/kmediaplayerengine.desktop staging/kmediaplayer/src/kmediaplayer/org.kde.KMediaPlayer.xml staging/kmediaplayer/src/kmediaplayer/player.h staging/kmediaplayer/src/kmediaplayer/player.cpp staging/kmediaplayer/src/kmediaplayer/view.h staging/kmediaplayer/src/kmediaplayer/view.cpp superbuild/CMakeLists.txt b98f09181de49c0c76394a9bdcc237f2e70fc221 tier3/CMakeLists.txt c959a32f195cc042202d635d286c08de42a6a4c1 Diff: http://git.reviewboard.kde.org/r/114128/diff/ Testing --- Both `make` and `make sb_kmediaplayer` succeed (the latter with #114127 applied). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kdelibs_frameworks_qt5 #1775
See http://build.kde.org/job/kdelibs_frameworks_qt5/1775/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1776
See http://build.kde.org/job/kdelibs_frameworks_qt5/1776/ -- [...truncated 7257 lines...] [ 59%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/utils.cpp.o [ 59%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdevice.cpp.o [ 59%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevmanager.cpp.o [ 60%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdeviceinterface.cpp.o [ 60%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/shared/udevqtclient.cpp.o [ 60%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevgenericinterface.cpp.o [ 61%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/shared/udevqtdevice.cpp.o [ 61%] [ 61%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/cpuinfo.cpp.o Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halacadapter.cpp.o [ 61%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevprocessor.cpp.o [ 61%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halaudiointerface.cpp.o [ 61%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halbattery.cpp.o [ 62%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevcamera.cpp.o [ 62%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevvideo.cpp.o [ 63%] [ 63%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halblock.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevaudiointerface.cpp.o [ 64%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevnetworkinterface.cpp.o [ 64%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halbutton.cpp.o [ 64%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevserialinterface.cpp.o [ 64%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halcamera.cpp.o [ 64%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevaudiointerface_p.cpp.o [ 64%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevportablemediaplayer.cpp.o [ 65%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdvbinterface.cpp.o [ 65%] [ 65%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevblock.cpp.o Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halcdrom.cpp.o [ 65%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevbutton.cpp.o [ 66%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/haldeviceinterface.cpp.o [ 66%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/haldvbinterface.cpp.o [ 66%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevkeyboard.cpp.o [ 67%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevpointingdevice.cpp.o [ 67%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/shared/udevqtclient.cpp.o [ 67%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/shared/udevqtdevice.cpp.o [ 68%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halacadapter.cpp.o [ 68%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halfstabhandling.cpp.o [ 69%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halgenericinterface.cpp.o [ 69%] [ 69%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halaudiointerface.cpp.o Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/haldevice.cpp.o [ 69%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halbattery.cpp.o [ 69%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halblock.cpp.o [ 69%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halmanager.cpp.o [ 70%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halbutton.cpp.o [ 70%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halnetworkinterface.cpp.o [ 70%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halcamera.cpp.o [ 70%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halcdrom.cpp.o [ 71%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halserialinterface.cpp.o [ 72%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/haldeviceinterface.cpp.o [ 72%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halopticaldisc.cpp.o [ 72%] [ 72%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halportablemediaplayer.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/haldvbinterface.cpp.o [ 73%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/hal/halprocessor.cpp.o [ 73%]
Re: Superbuild in kdelibs
On Wed, Nov 27, 2013 at 2:33 AM, Aurélien Gâteau agat...@kde.org wrote: Le vendredi 22 novembre 2013 19:55:52 Ben Cooksley a écrit : On Fri, Nov 22, 2013 at 3:52 AM, Aurélien Gâteau agat...@kde.org wrote: Hi, Hi, This morning I merged my superbuild changes in the frameworks branch. Superbuild support was originally enabled by default, but I turned it off because it broke on build.kde.org. You can turn it on by passing -DSUPERBUILD=ON to cmake. When superbuild is enabled, you can build any framework standalone with `make sb_$framework`. This will: - create a separate build dir for the framework in $build/superbuild/$framework - run cmake in this dir - run make - run make install You can also build all frameworks standalone at once with `make sb_all`. Regarding build.kde.org: build failed because it defines a DESTDIR environment variable but does not set CMAKE_SKIP_RPATH, which superbuild does not like: CMake Error at superbuild/SuperBuild.cmake:61 (message): The DESTDIR environment variable is set to /srv/jenkins/workspace/kdelibs_frameworks_qt5/install, but CMAKE_SKIP_RPATH is not set to TRUE. This would produce binaries with bad RPATHs. Call Stack (most recent call first): superbuild/CMakeLists.txt:7 (include) I am not sure what is the best approach to this, advices are welcome. Once this is sorted out, I would like to see build.kde.org run `make sb_all` before running the classic `make` command so that we can catch standalone breakage. We can do that. In terms of CMAKE_SKIP_RPATH, that sounds like a bad idea as it will probably break things like meinproc5 for the regular (non-Super) build. I've no idea why it is complaining about DESTDIR being set - it should have no effect as far as I know, but i'm no expert in these matters. I'd suggest disabling this check if we can, but i'll defer to those who know more in the area of RPATH and equivalent variables. Up to this point it has not caused us any issues wrt execution of tests for any of the binaries used on the CI system - otherwise CMake itself, kdeinit, kded, etc wouldn't work. Hi, I just disabled it, so that you can give it a try. Can you modify kdelibs job definition so that cmake is called with -DSUPERBUILD=ON and make sb_all is called first, then make? That has now been done in 6a67a97e79f1c0251bf0038e8ecd46dbe59cae72 to sysadmin/build-kde-org. Unfortunately the build failed. Aurélien Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/ --- (Updated Nov. 26, 2013, 11:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Split imageformat plugins from kguiaddons, as kimageformats Diffs - superbuild/CMakeLists.txt b98f091 tier1/CMakeLists.txt 5b41494 tier1/kguiaddons/CMakeLists.txt 763883a tier1/kguiaddons/cmake/FindOpenEXR.cmake b4ae656 tier1/kguiaddons/src/CMakeLists.txt 61e7320 tier1/kguiaddons/src/colors/kcolorcollection.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorcollection.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.h PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces_p.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.cpp PRE-CREATION tier1/kguiaddons/src/colors/kguiaddons_colorhelpers_p.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.cpp PRE-CREATION tier1/kguiaddons/src/lib/CMakeLists.txt ca94f4b tier1/kguiaddons/src/lib/colors/kcolorcollection.h 11845af tier1/kguiaddons/src/lib/colors/kcolorcollection.cpp 4d1dca7 tier1/kguiaddons/src/lib/colors/kcolormimedata.h 859b164 tier1/kguiaddons/src/lib/colors/kcolormimedata.cpp fd3ad4a tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 25fd8dd tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h 7630d09 tier1/kguiaddons/src/lib/colors/kcolorutils.h 8d1b13e tier1/kguiaddons/src/lib/colors/kcolorutils.cpp e7034d9 tier1/kguiaddons/src/lib/colors/kguiaddons_colorhelpers_p.h 6d653ae tier1/kguiaddons/src/lib/fonts/kfontutils.h d0a5651 tier1/kguiaddons/src/lib/fonts/kfontutils.cpp 3a80039 tier1/kguiaddons/src/lib/text/kdatevalidator.h a93d7fb tier1/kguiaddons/src/lib/text/kdatevalidator.cpp 8d9d7c1 tier1/kguiaddons/src/lib/text/kwordwrap.h 0e3bacf tier1/kguiaddons/src/lib/text/kwordwrap.cpp 49c0cfd tier1/kguiaddons/src/lib/util/kiconutils.h a7e15b2 tier1/kguiaddons/src/lib/util/kiconutils.cpp 00b24c9 tier1/kguiaddons/src/lib/util/kimagecache.h 682aa66 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.h dc86426 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.cpp 394eac0 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.h a5b1785 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp 7068d6f tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp 696c577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp a184ba5 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h 676f577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 77cce38 tier1/kguiaddons/src/lib/util/urlhandler.cpp b555dfd tier1/kguiaddons/src/plugins/imageformats/AUTHORS 8d72dc9 tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 614bba0 tier1/kguiaddons/src/plugins/imageformats/Mainpage.dox d63f10e tier1/kguiaddons/src/plugins/imageformats/README a72aa1d tier1/kguiaddons/src/plugins/imageformats/bmp.desktop bb880ae tier1/kguiaddons/src/plugins/imageformats/config-kimgio.h.cmake 1ef5135 tier1/kguiaddons/src/plugins/imageformats/dds.cpp 19ddbe0 tier1/kguiaddons/src/plugins/imageformats/dds.desktop 27f0318 tier1/kguiaddons/src/plugins/imageformats/dds.h 51c9fd7 tier1/kguiaddons/src/plugins/imageformats/dds.json bc30795 tier1/kguiaddons/src/plugins/imageformats/eps.cpp af521d7 tier1/kguiaddons/src/plugins/imageformats/eps.desktop 4a4160f tier1/kguiaddons/src/plugins/imageformats/eps.h df2b3ff tier1/kguiaddons/src/plugins/imageformats/eps.json 4a7aeaf tier1/kguiaddons/src/plugins/imageformats/exr.cpp 5d8a502 tier1/kguiaddons/src/plugins/imageformats/exr.desktop 6725314 tier1/kguiaddons/src/plugins/imageformats/exr.h 3ae9e16 tier1/kguiaddons/src/plugins/imageformats/exr.json f5ae145 tier1/kguiaddons/src/plugins/imageformats/gif.desktop a507b76 tier1/kguiaddons/src/plugins/imageformats/gimp.h cb697b8 tier1/kguiaddons/src/plugins/imageformats/hdr.cpp f59fc95 tier1/kguiaddons/src/plugins/imageformats/hdr.desktop d355d52 tier1/kguiaddons/src/plugins/imageformats/hdr.h 1b948de tier1/kguiaddons/src/plugins/imageformats/ico.desktop 9cf9cd3 tier1/kguiaddons/src/plugins/imageformats/jp2.cpp c0856dd tier1/kguiaddons/src/plugins/imageformats/jp2.desktop 3d673c6 tier1/kguiaddons/src/plugins/imageformats/jp2.h b8d4c7f tier1/kguiaddons/src/plugins/imageformats/jp2.json 3ff6cde tier1/kguiaddons/src/plugins/imageformats/jpeg.desktop 7614ef6 tier1/kguiaddons/src/plugins/imageformats/mng.desktop 12ddefd
Re: Review Request 114141: Split imageformat plugins from kguiaddons, as kimageformats
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/#review44549 --- This review has been submitted with commit 8f4e4fc803e5df4f0f0fd4f94dfce528077ef0ed by Alex Merry to branch frameworks. - Commit Hook On Nov. 26, 2013, 4:30 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114141/ --- (Updated Nov. 26, 2013, 4:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Split imageformat plugins from kguiaddons, as kimageformats Diffs - superbuild/CMakeLists.txt b98f091 tier1/CMakeLists.txt 5b41494 tier1/kguiaddons/CMakeLists.txt 763883a tier1/kguiaddons/cmake/FindOpenEXR.cmake b4ae656 tier1/kguiaddons/src/CMakeLists.txt 61e7320 tier1/kguiaddons/src/colors/kcolorcollection.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorcollection.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.h PRE-CREATION tier1/kguiaddons/src/colors/kcolormimedata.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces.cpp PRE-CREATION tier1/kguiaddons/src/colors/kcolorspaces_p.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.h PRE-CREATION tier1/kguiaddons/src/colors/kcolorutils.cpp PRE-CREATION tier1/kguiaddons/src/colors/kguiaddons_colorhelpers_p.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.h PRE-CREATION tier1/kguiaddons/src/fonts/kfontutils.cpp PRE-CREATION tier1/kguiaddons/src/lib/CMakeLists.txt ca94f4b tier1/kguiaddons/src/lib/colors/kcolorcollection.h 11845af tier1/kguiaddons/src/lib/colors/kcolorcollection.cpp 4d1dca7 tier1/kguiaddons/src/lib/colors/kcolormimedata.h 859b164 tier1/kguiaddons/src/lib/colors/kcolormimedata.cpp fd3ad4a tier1/kguiaddons/src/lib/colors/kcolorspaces.cpp 25fd8dd tier1/kguiaddons/src/lib/colors/kcolorspaces_p.h 7630d09 tier1/kguiaddons/src/lib/colors/kcolorutils.h 8d1b13e tier1/kguiaddons/src/lib/colors/kcolorutils.cpp e7034d9 tier1/kguiaddons/src/lib/colors/kguiaddons_colorhelpers_p.h 6d653ae tier1/kguiaddons/src/lib/fonts/kfontutils.h d0a5651 tier1/kguiaddons/src/lib/fonts/kfontutils.cpp 3a80039 tier1/kguiaddons/src/lib/text/kdatevalidator.h a93d7fb tier1/kguiaddons/src/lib/text/kdatevalidator.cpp 8d9d7c1 tier1/kguiaddons/src/lib/text/kwordwrap.h 0e3bacf tier1/kguiaddons/src/lib/text/kwordwrap.cpp 49c0cfd tier1/kguiaddons/src/lib/util/kiconutils.h a7e15b2 tier1/kguiaddons/src/lib/util/kiconutils.cpp 00b24c9 tier1/kguiaddons/src/lib/util/kimagecache.h 682aa66 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.h dc86426 tier1/kguiaddons/src/lib/util/klocalimagecacheimpl.cpp 394eac0 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.h a5b1785 tier1/kguiaddons/src/lib/util/kmodifierkeyinfo.cpp 7068d6f tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider.cpp 696c577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp a184ba5 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h 676f577 tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 77cce38 tier1/kguiaddons/src/lib/util/urlhandler.cpp b555dfd tier1/kguiaddons/src/plugins/imageformats/AUTHORS 8d72dc9 tier1/kguiaddons/src/plugins/imageformats/CMakeLists.txt 614bba0 tier1/kguiaddons/src/plugins/imageformats/Mainpage.dox d63f10e tier1/kguiaddons/src/plugins/imageformats/README a72aa1d tier1/kguiaddons/src/plugins/imageformats/bmp.desktop bb880ae tier1/kguiaddons/src/plugins/imageformats/config-kimgio.h.cmake 1ef5135 tier1/kguiaddons/src/plugins/imageformats/dds.cpp 19ddbe0 tier1/kguiaddons/src/plugins/imageformats/dds.desktop 27f0318 tier1/kguiaddons/src/plugins/imageformats/dds.h 51c9fd7 tier1/kguiaddons/src/plugins/imageformats/dds.json bc30795 tier1/kguiaddons/src/plugins/imageformats/eps.cpp af521d7 tier1/kguiaddons/src/plugins/imageformats/eps.desktop 4a4160f tier1/kguiaddons/src/plugins/imageformats/eps.h df2b3ff tier1/kguiaddons/src/plugins/imageformats/eps.json 4a7aeaf tier1/kguiaddons/src/plugins/imageformats/exr.cpp 5d8a502 tier1/kguiaddons/src/plugins/imageformats/exr.desktop 6725314 tier1/kguiaddons/src/plugins/imageformats/exr.h 3ae9e16 tier1/kguiaddons/src/plugins/imageformats/exr.json f5ae145 tier1/kguiaddons/src/plugins/imageformats/gif.desktop a507b76 tier1/kguiaddons/src/plugins/imageformats/gimp.h cb697b8 tier1/kguiaddons/src/plugins/imageformats/hdr.cpp f59fc95 tier1/kguiaddons/src/plugins/imageformats/hdr.desktop d355d52 tier1/kguiaddons/src/plugins/imageformats/hdr.h 1b948de
Build failed in Jenkins: kdelibs_frameworks_qt5 #1778
See http://build.kde.org/job/kdelibs_frameworks_qt5/1778/changes Changes: [kde] Split imageformat plugins from kguiaddons, as kimageformats -- [...truncated 7844 lines...] [ 3%] -- Detecting C compiler ABI info Automatic moc for target KJsEmbed -- The C compiler identification is GNU 4.7.2 [ 3%] Built target KJsEmbed_automoc make[4]: *** [all] Error 2 make[3]: *** [superbuild/CMakeFiles/SuperBuild/stampfiles/kjsembed/sb_kjsembed-build] Error 2 make[2]: *** [superbuild/CMakeFiles/sb_kjsembed.dir/all] Error 2 make[2]: *** Waiting for unfinished jobs -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- The CXX compiler identification is GNU 4.7.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Detecting CXX compiler ABI info - done -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Looking for mmap -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Looking for mmap - found -- Looking for posix_madvise Linking CXX shared library libKJobWidgets.so -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- Looking for posix_madvise - not found -- Configuring done -- -- The following REQUIRED packages have been found: * Qt5Core (required version = 5.2.0) * ECM (required version = 0.0.9) * Qt5Gui (required version = 5.2.0) * Qt5Widgets * Qt5DBus * KAuth (required version = 5.0.0) * KCoreAddons (required version = 5.0.0) * KCodecs (required version = 5.0.0) * Qt5Xml * KConfig (required version = 5.0.0) * KArchive (required version = 5.0.0) * KDocTools (required version = 5.0.0) * KGuiAddons (required version = 5.0.0) * KJS (required version = 5.0.0) * KI18n (required version = 5.0.0) * KWidgetsAddons (required version = 5.0.0) * Qt5Test * Qt5 (required version = 5.2.0) -- Configuring done -- Generating done -- Build files have been written to: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/superbuild/kservice [ 62%] Performing build step for 'sb_kservice' -- Generating done -- Build files have been written to: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/build/superbuild/kconfigwidgets Scanning dependencies of target kbuildsycoca5-manpage-man-kbuildsycoca5 Scanning dependencies of target desktoptojson_automoc Scanning dependencies of target kdeinit5-manpage-man-kdeinit5 Scanning dependencies of target KService_automoc Scanning dependencies of target fakeplugin_automoc Scanning dependencies of target kautostarttest_automoc Scanning dependencies of target kbuildsycoca5_automoc [ 2%] [ 2%] [ 4%] [ 5%] [ 5%] [ 62%] [ 6%] [ 7%] Generating kbuildsycoca5.8 Automatic moc for target desktoptojson Automatic moc for target fakeplugin Generating kdeinit5.8 Automatic moc for target KService Performing build step for 'sb_kconfigwidgets' Automatic moc for target kautostarttest Automatic moc for target kbuildsycoca5 man-kbuildsycoca5.8.docbook:4: warning: failed to load external entity dtd/kdex.dtd ] ^ man-kbuildsycoca5.8.docbook:6: validity error : Validation failed: no DTD found ! refentry ^ man-kbuildsycoca5.8.docbook:9: parser error : Entity 'kde' not defined titlekde; User's Manual/title ^ man-kbuildsycoca5.8.docbook:19: parser error : Entity 'kde' not defined releaseinfo1.1 (kde; 4.4)/releaseinfo ^ man-kbuildsycoca5.8.docbook:63: parser error : Entity 'kde' not defined commandkbuildsycoca5/command, as part of the kde; command line ^ man-kbuildsycoca5.8.docbook:64: parser error : Entity 'kde' not defined tools ensures the proper operation of kde; by reading in all the ^ man-kbuildsycoca5.8.docbook:72: parser error : Entity 'kde' not defined kde; itself accesses this
Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/#review44557 --- This review has been submitted with commit 2391542aea6fe7b64cd98f983881553fb4cde3ea by Martin Gräßlin to branch frameworks. - Commit Hook On Nov. 26, 2013, 6:31 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 26, 2013, 6:31 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- If there were multiple KStartupInfoIds which were removed at the same time, it was possible that the map got changed while being iterated, thus the data corrupted and we hit a crash later on. This changes to a QMutableMapIterator for checking the cleanup and allowing to safely remove ids during the iteration. Diffs - tier1/kwindowsystem/autotests/kstartupinfo_unittest.cpp 17890ff tier1/kwindowsystem/src/kstartupinfo.cpp c2ff7c2 Diff: http://git.reviewboard.kde.org/r/113877/diff/ Testing --- When running the unit tests on the old code base it isn't guaranteed that it crashes as it's a race and also depends on X. Just run a few times and it will certainly hit the abort condition. For reference the backtrace of the crash before fix: #0 0x750131e5 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x75016398 in __GI_abort () at abort.c:90 #2 0x75c3d402 in qt_message_fatal (context=..., message=...) at global/qlogging.cpp:979 #3 0x75c3afce in QMessageLogger::fatal (this=0x7fffbbc0, msg=0x75f8d9f8 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:384 #4 0x75c369e6 in qt_assert (assertion=0x75f8b7f0 size == 0 || offset 0 || size_t(offset) = sizeof(QArrayData), file=0x75f8b7b0 ../../include/QtCore/../../src/corelib/tools/qarraydata.h, line=62) at global/qglobal.cpp:2088 #5 0x75c29bf8 in QArrayData::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:61 #6 0x75c3015e in QTypedArrayDatachar::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:207 #7 0x75c2fde7 in QByteArray::constData (this=0x6f4760) at ../../include/QtCore/../../src/corelib/tools/qbytearray.h:433 #8 0x75c5 in qstrcmp (str1=..., str2=...) at tools/qbytearray.cpp:347 #9 0x77ba4625 in operator (a1=..., a2=...) at /opt/qt5/include/QtCore/qbytearray.h:550 #10 0x77ba0eb9 in KStartupInfoId::operator (this=0x693858, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:1175 #11 0x77ba67b5 in qMapLessThanKeyKStartupInfoId (key1=..., key2=...) at /opt/qt5/include/QtCore/qmap.h:75 #12 0x77ba6ef3 in QMapNodeKStartupInfoId, KStartupInfo::Data::lowerBound (this=0x693840, akey=...) at /opt/qt5/include/QtCore/qmap.h:145 #13 0x77ba66b4 in QMapDataKStartupInfoId, KStartupInfo::Data::findNode (this=0x700870, akey=...) at /opt/qt5/include/QtCore/qmap.h:292 #14 0x77ba5a73 in QMapKStartupInfoId, KStartupInfo::Data::remove (this=0x65acc0, akey=...) at /opt/qt5/include/QtCore/qmap.h:897 #15 0x77b9dd42 in KStartupInfo::Private::remove_startup_info_internal (this=0x65acb0, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:399 #16 0x77ba039b in KStartupInfo::Private::startups_cleanup_internal (this=0x65acb0, age_P=true) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:984 #17 0x77ba02bf in KStartupInfo::Private::startups_cleanup (this=0x65acb0) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:965 #18 0x77ba3d1c in KStartupInfo::qt_static_metacall (_o=0x7fffdc60, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fffbf70) at /opt/build/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/moc_kstartupinfo.cpp:106 #19 0x75ef8c9f in QMetaObject::activate (sender=0x684d50, signalOffset=3, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3530 #20 0x75ef84f0 in QMetaObject::activate (sender=0x684d50, m=0x763ab980 QTimer::staticMetaObject, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3405 #21 0x75f88fc3 in QTimer::timeout (this=0x684d50) at .moc/moc_qtimer.cpp:189 #22 0x75f03bc5 in QTimer::timerEvent (this=0x684d50, e=0x7fffca30) at kernel/qtimer.cpp:255 #23 0x75ef2314 in QObject::event (this=0x684d50, e=0x7fffca30) at kernel/qobject.cpp:1101 #24 0x7710e24e in
Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 27, 2013, 6:10 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- If there were multiple KStartupInfoIds which were removed at the same time, it was possible that the map got changed while being iterated, thus the data corrupted and we hit a crash later on. This changes to a QMutableMapIterator for checking the cleanup and allowing to safely remove ids during the iteration. Diffs - tier1/kwindowsystem/autotests/kstartupinfo_unittest.cpp 17890ff tier1/kwindowsystem/src/kstartupinfo.cpp c2ff7c2 Diff: http://git.reviewboard.kde.org/r/113877/diff/ Testing --- When running the unit tests on the old code base it isn't guaranteed that it crashes as it's a race and also depends on X. Just run a few times and it will certainly hit the abort condition. For reference the backtrace of the crash before fix: #0 0x750131e5 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #1 0x75016398 in __GI_abort () at abort.c:90 #2 0x75c3d402 in qt_message_fatal (context=..., message=...) at global/qlogging.cpp:979 #3 0x75c3afce in QMessageLogger::fatal (this=0x7fffbbc0, msg=0x75f8d9f8 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:384 #4 0x75c369e6 in qt_assert (assertion=0x75f8b7f0 size == 0 || offset 0 || size_t(offset) = sizeof(QArrayData), file=0x75f8b7b0 ../../include/QtCore/../../src/corelib/tools/qarraydata.h, line=62) at global/qglobal.cpp:2088 #5 0x75c29bf8 in QArrayData::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:61 #6 0x75c3015e in QTypedArrayDatachar::data (this=0x6cb830) at ../../include/QtCore/../../src/corelib/tools/qarraydata.h:207 #7 0x75c2fde7 in QByteArray::constData (this=0x6f4760) at ../../include/QtCore/../../src/corelib/tools/qbytearray.h:433 #8 0x75c5 in qstrcmp (str1=..., str2=...) at tools/qbytearray.cpp:347 #9 0x77ba4625 in operator (a1=..., a2=...) at /opt/qt5/include/QtCore/qbytearray.h:550 #10 0x77ba0eb9 in KStartupInfoId::operator (this=0x693858, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:1175 #11 0x77ba67b5 in qMapLessThanKeyKStartupInfoId (key1=..., key2=...) at /opt/qt5/include/QtCore/qmap.h:75 #12 0x77ba6ef3 in QMapNodeKStartupInfoId, KStartupInfo::Data::lowerBound (this=0x693840, akey=...) at /opt/qt5/include/QtCore/qmap.h:145 #13 0x77ba66b4 in QMapDataKStartupInfoId, KStartupInfo::Data::findNode (this=0x700870, akey=...) at /opt/qt5/include/QtCore/qmap.h:292 #14 0x77ba5a73 in QMapKStartupInfoId, KStartupInfo::Data::remove (this=0x65acc0, akey=...) at /opt/qt5/include/QtCore/qmap.h:897 #15 0x77b9dd42 in KStartupInfo::Private::remove_startup_info_internal (this=0x65acb0, id_P=...) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:399 #16 0x77ba039b in KStartupInfo::Private::startups_cleanup_internal (this=0x65acb0, age_P=true) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:984 #17 0x77ba02bf in KStartupInfo::Private::startups_cleanup (this=0x65acb0) at /home/martin/src/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/kstartupinfo.cpp:965 #18 0x77ba3d1c in KStartupInfo::qt_static_metacall (_o=0x7fffdc60, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fffbf70) at /opt/build/kf5/kdelibs-frameworks/tier1/kwindowsystem/src/moc_kstartupinfo.cpp:106 #19 0x75ef8c9f in QMetaObject::activate (sender=0x684d50, signalOffset=3, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3530 #20 0x75ef84f0 in QMetaObject::activate (sender=0x684d50, m=0x763ab980 QTimer::staticMetaObject, local_signal_index=0, argv=0x0) at kernel/qobject.cpp:3405 #21 0x75f88fc3 in QTimer::timeout (this=0x684d50) at .moc/moc_qtimer.cpp:189 #22 0x75f03bc5 in QTimer::timerEvent (this=0x684d50, e=0x7fffca30) at kernel/qtimer.cpp:255 #23 0x75ef2314 in QObject::event (this=0x684d50, e=0x7fffca30) at kernel/qobject.cpp:1101 #24 0x7710e24e in QApplicationPrivate::notify_helper (this=0x60f010, receiver=0x684d50, e=0x7fffca30) at kernel/qapplication.cpp:3467 #25 0x7710b805 in QApplication::notify (this=0x7fffdc90, receiver=0x684d50, e=0x7fffca30) at kernel/qapplication.cpp:2888 #26 0x75eb6908 in QCoreApplication::notifyInternal (this=0x7fffdc90, receiver=0x684d50, event=0x7fffca30) at kernel/qcoreapplication.cpp:878 #27 0x75eba4f1 in QCoreApplication::sendEvent
Build failed in Jenkins: kdelibs_frameworks_qt5 #1779
See http://build.kde.org/job/kdelibs_frameworks_qt5/1779/changes Changes: [mgraesslin] Properly erase KSartupInfoIds in remove_startup_info_internal -- [...truncated 7560 lines...] -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kunitconversion/value.h -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kunitconversion/unit.h -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kunitconversion/unitcategory.h -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kunitconversion/kunitconversion_export.h Linking CXX executable klineedit_unittest [ 50%] Completed 'sb_kunitconversion' [ 50%] Built target sb_kunitconversion [100%] Built target klineedit_unittest [ 50%] Performing install step for 'sb_kcompletion' [ 3%] Automatic moc for target KCompletion [ 3%] Built target KCompletion_automoc [ 74%] [ 6%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halfstabhandling.cpp.o Automatic moc for target kcomboboxtest [ 9%] Automatic moc for target kcompletionuitest [ 9%] Built target kcomboboxtest_automoc [ 9%] Built target kcompletionuitest_automoc [ 12%] Automatic moc for target klineedittest [ 12%] Built target klineedittest_automoc [ 16%] Automatic moc for target kcombobox_unittest [ 16%] Built target kcombobox_unittest_automoc [ 19%] Automatic moc for target kcompletioncoretest [ 19%] Built target kcompletioncoretest_automoc [ 22%] Automatic moc for target klineedit_unittest [ 22%] Built target klineedit_unittest_automoc [ 25%] Automatic moc for target ksortablelisttest [ 25%] Built target ksortablelisttest_automoc [ 54%] Built target KCompletion [ 61%] Built target kcomboboxtest [ 74%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/halgenericinterface.cpp.o [ 67%] Built target kcompletionuitest [ 74%] Built target klineedittest [ 74%] [ 80%] Built target kcombobox_unittest Building CXX object src/solid/CMakeFiles/Solid.dir/backends/upower/upowerdevice.cpp.o [ 87%] Built target kcompletioncoretest [ 93%] Built target klineedit_unittest [ 75%] [ 75%] Building CXX object src/solid/CMakeFiles/Solid.dir/backends/upower/upowermanager.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/hal/haldevice.cpp.o [100%] Built target ksortablelisttest Install the project... -- Install configuration: Debug -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCompletion/KCompletionConfig.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCompletion/KCompletionConfigVersion.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCompletion/KCompletionTargets.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/cmake/KCompletion/KCompletionTargets-debug.cmake -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcompletion_version.h -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/libKCompletion.so.5.0.0 -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/libKCompletion.so.5 -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/libKCompletion.so -- Set runtime path of http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64/libKCompletion.so.5.0.0; to /srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64:/srv/jenkins/install/linux/x86_64/g++/qt5/qt5/stable/lib -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcombobox.h -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcompletion.h -- Installing: http://build.kde.org/job/kdelibs_frameworks_qt5/ws/install/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcompletionbox.h -- Installing:
Re: Review Request 114116: [tier3/kservice] Improve dependency specification
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114116/#review44559 --- This review has been submitted with commit fddb5b906d6523a7d431bad991dba232fdd2aacb by Johannes Huber to branch frameworks. - Commit Hook On Nov. 25, 2013, 6:58 p.m., Johannes Huber wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114116/ --- (Updated Nov. 25, 2013, 6:58 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Tests is only used in sub directory, so move it there. Remove KWindowSystem as it is not needed to build. Diffs - tier3/kservice/autotests/CMakeLists.txt 7d8cb47 tier3/kservice/CMakeLists.txt 098a4a0 Diff: http://git.reviewboard.kde.org/r/114116/diff/ Testing --- Builds with and without autotests subdirectory. Thanks, Johannes Huber ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114116: [tier3/kservice] Improve dependency specification
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114116/ --- (Updated Nov. 27, 2013, 7:21 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Tests is only used in sub directory, so move it there. Remove KWindowSystem as it is not needed to build. Diffs - tier3/kservice/autotests/CMakeLists.txt 7d8cb47 tier3/kservice/CMakeLists.txt 098a4a0 Diff: http://git.reviewboard.kde.org/r/114116/diff/ Testing --- Builds with and without autotests subdirectory. Thanks, Johannes Huber ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs_frameworks_qt5 #1780
See http://build.kde.org/job/kdelibs_frameworks_qt5/1780/changes Changes: [johu] Improve dependency specification -- [...truncated 7428 lines...] ^ man-kdeinit5.8.docbook:9: parser error : Entity 'kde' not defined titlekde; User's Manual/title ^ man-kdeinit5.8.docbook:46: parser error : Entity 'kde' not defined refpurposekde; process launcher./refpurpose ^ man-kdeinit5.8.docbook:73: parser error : Entity 'kde' not defined famous commandinit/command used for booting UNIX. It executes kde; ^ man-kdeinit5.8.docbook:77: parser error : Entity 'kde' not defined paraUsing kdeinit5 to launch kde; applications makes starting a typical ^ man-kdeinit5.8.docbook:78: parser error : Entity 'kde' not defined kde; application a couple times faster and reduces memory consumption by ^ man-kdeinit5.8.docbook:81: parser error : Entity 'kde' not defined parakdeinit5 is linked against all libraries a standard kde; application ^ man-kdeinit5.8.docbook:218: parser error : Entity 'kde' not defined paraIf set, tells kdeinit5 that the kde; programs are pre-linked./para ^ man-kdeinit5.8.docbook:226: parser error : Entity 'kde' not defined paraIf set, tells kdeinit5 that it is running on a kde; desktop./para ^ Building CXX object src/solid/CMakeFiles/Solid.dir/backends/fstab/fstabwatcher.cpp.o [ 71%] make[6]: *** [docs/kdeinit5/kdeinit5.8] Error 1 make[5]: *** [docs/kdeinit5/CMakeFiles/kdeinit5-manpage-man-kdeinit5.dir/all] Error 2 [ 71%] [ 6%] [ 71%] Built target desktoptojson_automoc Building CXX object src/solid/CMakeFiles/Solid.dir/inhibitinterface.cpp.o Building CXX object src/solid/CMakeFiles/Solid.dir/powermanagementinterface.cpp.o [ 72%] Building CXX object src/solid/CMakeFiles/Solid.dir/policyagentinterface.cpp.o [ 72%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakevolume.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/fakehw/fakesmartcardreader.cpp.o [ 73%] Building CXX object src/solid/CMakeFiles/Solid.dir/org_kde_solid_networking_client.cpp.o [ 73%] [ 73%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/shared/cpufeatures.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/shared/rootdevice.cpp.o [ 74%] [ 74%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/utils.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdevice.cpp.o [ 74%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevmanager.cpp.o [ 75%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdeviceinterface.cpp.o [ 75%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevgenericinterface.cpp.o [ 75%] Building CXX object src/solid/CMakeFiles/Solid.dir/Solid_automoc.cpp.o [ 75%] Generating nsaplugin.moc Generating moc_nsaplugin.cpp [ 75%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/cpuinfo.cpp.o [ 6%] Built target fakeplugin_automoc Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevprocessor.cpp.o [ 76%] [ 76%] [ 76%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevvideo.cpp.o [ 77%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevcamera.cpp.o [ 77%] Generating moc_kbuildsycoca.cpp Generating moc_vfolder_menu.cpp [ 6%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevaudiointerface.cpp.o Built target kbuildsycoca5_automoc Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevnetworkinterface.cpp.o [ 77%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevserialinterface.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevaudiointerface_p.cpp.o [ 77%] [ 78%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevportablemediaplayer.cpp.o [ 78%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevdvbinterface.cpp.o [ 78%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevblock.cpp.o [ 78%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevbutton.cpp.o Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevkeyboard.cpp.o [ 79%] [ 79%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/udev/udevpointingdevice.cpp.o [ 79%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/shared/udevqtclient.cpp.o [ 80%] Building CXX object src/solid/CMakeFiles/Solid_static.dir/backends/shared/udevqtdevice.cpp.o [ 80%] [
