Re: Can't use DNSSD
On Sun, Dec 15, 2013 at 11:18 PM, Albert Astals Cid aa...@kde.org wrote: Any reason i hage to use KF5::KF5DNSSD instead of KF5::DNSSD in target_link_libraries like it would seem logical due to the other frameworks naming? This was a porting bug, sorry. I've pushed a fix, now you can use KF5:DNSSD again (cleaning build dir should be enough). Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tracking bugs in Frameworks
On Saturday 14 December 2013 19:00:04 Frank Reininghaus wrote: IMHO, it would be much more transparent for bug triagers, developers, and users if there was a nice 1:1 correspondence between the split repositories/frameworks and the bugzilla products. One could argue that each repository could also be a component of the product Frameworks, but this would remove the option to define more fine-grained components for a particular framework (e.g., the current product kfile has some different components for different parts of that library). I agree, it's the right time to make this cleaner. Maybe one could create a bugzilla product for each Framework (unless the product exists already, like kio). One could set up a version frameworks in each of them as long as the frameworks don't have proper versions yet. I disagree with a frameworks version. In 2 years, how will we distinguish which version of KF5 that is? The version should be 5.0, instead (matching @since tags and .so version numbers). Or maybe 4.9.90 for now, if you want. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Fwd: Tracking bugs in Frameworks
On Sat, Dec 14, 2013 at 7:00 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi, 2013/12/14 David Edmundson: As we gear Frameworks up for release we need a way to track bugs that exist in the new Frameworks. We have two options; either we copy all the bugs in kdelibs, triaging, testing and moving to the right new component or we start fresh. There are approximate 1400 open bugs marked against in kdelibs; many of these I think are invalid duplicates. It's not an impossible amount to triage, but it would still be a large amount of work to test and then either move or resolve them. Given we still plan to support bugs in kdelibs officially for a while yet and I personally think it would be easiest for everyone to make a new bugzilla product called Frameworks and add newly found Frameworks bugs there. an alternative would be to let every Framework have its own product. Some parts of kdelibs have had their own products for quite some time (e.g., kio and kfile), whereas others are tracked at the generic product kdelibs, or at yet other products (like konqeuror/khtml) That's a good option. I think if we did that it would be a good idea to prefix the names with a common element like frameworks-coreaddons frameworks-kio etc. Otherwise it will be difficult to find anything, especially as some of the framework names are very generic. IMHO, it would be much more transparent for bug triagers, developers, and users if there was a nice 1:1 correspondence between the split repositories/frameworks and the bugzilla products. One could argue that each repository could also be a component of the product Frameworks, but this would remove the option to define more fine-grained components for a particular framework (e.g., the current product kfile has some different components for different parts of that library). Making each repository a component was my original idea, but you are right that it makes it harder to then add a finer grain of control. I'm equally happy with your proposed plan. Maybe one could create a bugzilla product for each Framework (unless the product exists already, like kio). One could set up a version frameworks in each of them as long as the frameworks don't have proper versions yet. KIO is an interesting discussion; that old component is mostly the IOslaves that used to be in kde-runtime, not the library itself. It even also currently includes the audio slave which is in kdemultimedia somewhere. With frameworks some of the slaves moved to frameworks, but not all of them. About the existing kdelibs bugs: I think they should just remain assigned to kdelibs as long as 4.x is supported. If any of these bugs is fixed, one just has to remember to forward-port the fix to the split frameworks repositories. ++. It's also an opportunity to subtly let all the old wishlist requests and unreproducible crashes that have built up over all this time fade away without causing too much drama. In a few years we can close kdelibs for new requests and hide the product. It gives us a clean slate to be better at triaging with. Finally, I think it's crucial to consider the opinion of the people who do the most work at bugs.kde.org. I've CC'ed some of them because I'm not sure if they follow this mailing list. Thanks. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
On 15/12/13 21:18, Kevin Ottens wrote: On Sunday 15 December 2013 10:58:35 Alex Merry wrote: I'd like to rename the makekdewidgets executable to something like kgendesignerplugin, to be more descriptive; this should be SC providing we keep the old CMake variables around, but should probably still happen before the TP, I guess? Can happen either before or after IMO. You can go ahead with it (as it looks small enough) if you manage to produce the change before Ben starts splitting the repositories. :-) Huh, looks like kdewidgets was never renamed to kf5designerplugin at all. I'm on a train (and hence off the internet) for most of this afternoon. Working on the assumption the splitting won't happen today, I'll work on renaming that framework (including the executable). I'll also move the .desktop files for Qt's imageformat plugins from kimageformats to kde4support (to be with their user, KImageIO), on the basis that you shouldn't need to install kimageformats to use KImageIO on Qt's imageformat plugins. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Do we want to have a meeting Tomorrow Tuesday?
I haven't seen that much action in Frameworks since it is kinda frozen and getting prepare for splitting. Do we still want to hold a meeting tomorrow? Cheers. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tracking bugs in Frameworks
On Mon, Dec 16, 2013 at 11:58 AM, David Edmundson da...@davidedmundson.co.uk wrote: I think if we did that it would be a good idea to prefix the names with a common element like frameworks-coreaddons frameworks-kio etc. +1. However I'd propose shorter prefix - kf-foo maybe? Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kdelibs_frameworks_qt5 #1863
See http://build.kde.org/job/kdelibs_frameworks_qt5/1863/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
Le samedi 14 décembre 2013 20:30:14 Kevin Ottens a écrit : Hello everyone, Now we're really getting there! Epics and review board are clean, thanks to everyone who helped to get there. Now it's the time to go for the last push. For that I opened what will be the last epic for the 5.0 release: http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation Do you want us to add ourselves as contacts in the table or do you plan to fill it later? If the former, I would assign myself to Get the dependency graph generator script ready, Have the frameworks on api.kde.org (already did some work in that area last week, http://api.kde.org/frameworks/kdelibs-apidocs/ looks more complete now) and I'd like to help with Reduce the KDE footprint in ECM as much as possible. Regarding the split: what is going to happen to the frameworks branch of the kdelibs repository after the split? Is it going to be removed or is it going to stay there with the framework folders pointing to the framework repositories through git sub-modules? The work on the graph generator and api.kde.org will be different depending on what the branch becomes. Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114496: Rename kdewidgets to kf5designerplugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/#review45782 --- Looks good. Just replace kdewidgets with kf5designerplugin in superbuild/CMakeLists.txt. SuperBuild is likely going away soon, but it is still useful for the remaining days before the split. - Aurélien Gâteau On Dec. 16, 2013, 2:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/ --- (Updated Dec. 16, 2013, 2:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Rename kdewidgets to kf5designerplugin This includes renaming makekdewidgets to kgendesignerplugin. Just throwing this at reviewboard before I dash for a train. Diffs - tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 tier3/kdewidgets/KDEWidgetsConfig.cmake d38c875c67a3073e7634bd6f873a38411127b759 tier3/kdewidgets/KDEWidgetsMacros.cmake 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 tier3/kdewidgets/docs/CMakeLists.txt 2b38f53f807c528fdcd6ea128567f6087bd8c673 tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt c283b926f542402d80e22cc42406b119e400a05f tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook cab0c5b51f2bb5be29960f43fe6fb940fffb5402 tier3/kdewidgets/src/AUTHORS tier3/kdewidgets/src/CMakeLists.txt e8626c84227a2ccd0459c5732a51e9ecea49f699 tier3/kdewidgets/src/README tier3/kdewidgets/src/classpreviews.h tier3/kdewidgets/src/classpreviews.cpp tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 tier3/kdewidgets/src/kdewebkit.widgets tier3/kdewidgets/src/kdewebkitwidgets.qrc tier3/kdewidgets/src/kdewidgets.qrc tier3/kdewidgets/src/makekdewidgets.cpp d20e49956a939a06fe3bc2280d57c5c6d31fe24c tier3/kdewidgets/src/pics/CMakeLists.txt 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 tier3/kdewidgets/src/pics/k3iconview.png tier3/kdewidgets/src/pics/k3listview.png tier3/kdewidgets/src/pics/kactionselector.png tier3/kdewidgets/src/pics/kactivelabel.png tier3/kdewidgets/src/pics/kcharselect.png tier3/kdewidgets/src/pics/kcmodule.png tier3/kdewidgets/src/pics/kcolorbutton.png tier3/kdewidgets/src/pics/kcolorcombo.png tier3/kdewidgets/src/pics/kcombobox.png tier3/kdewidgets/src/pics/kdatepicker.png tier3/kdewidgets/src/pics/kdatetable.png tier3/kdewidgets/src/pics/kdualcolorbutton.png tier3/kdewidgets/src/pics/keditlistwidget.png tier3/kdewidgets/src/pics/kfontcombo.png tier3/kdewidgets/src/pics/kfontrequester.png tier3/kdewidgets/src/pics/kgradientselector.png tier3/kdewidgets/src/pics/khistorycombo.png tier3/kdewidgets/src/pics/khsselector.png tier3/kdewidgets/src/pics/kiconbutton.png tier3/kdewidgets/src/pics/kkeybutton.png tier3/kdewidgets/src/pics/kled.png tier3/kdewidgets/src/pics/klineedit.png tier3/kdewidgets/src/pics/klistbox.png tier3/kdewidgets/src/pics/kpalettetable.png tier3/kdewidgets/src/pics/kpasswordedit.png tier3/kdewidgets/src/pics/kruler.png tier3/kdewidgets/src/pics/ksqueezedtextlabel.png tier3/kdewidgets/src/pics/ktextedit.png tier3/kdewidgets/src/pics/kurlcomborequester.png tier3/kdewidgets/src/pics/kurllabel.png tier3/kdewidgets/src/pics/kurlrequester.png tier3/kdewidgets/tests/CMakeLists.txt tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf tier3/kdewidgets/tests/sums tier3/kdewidgets/tests/test.widgets tier3/kf5designerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION tier3/kf5designerplugin/Mainpage.dox PRE-CREATION tier3/kf5designerplugin/docs/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook PRE-CREATION tier3/kf5designerplugin/src/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/tests/README PRE-CREATION tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c tier4/kde4support/src/KDEUIMacros.cmake 31a180c1aab14f22e6a157e8aabfa901db15081a tier4/kde4support/src/kdedeprecated.widgets 604358ac69ba8a8cfbdd8b41a796405fdddebd12 tier4/kde4support/src/pics/CMakeLists.txt c0e1c2064af67e9ad90d8f5e8a9c892208c6cda0 Diff: http://git.reviewboard.kde.org/r/114496/diff/ Testing
Re: Tracking bugs in Frameworks
El lunes, 16 de diciembre de 2013, Martin Klapetek escribió:
On Mon, Dec 16, 2013 at 11:58 AM, David Edmundson
da...@davidedmundson.co.uk javascript:_e({}, 'cvml',
'da...@davidedmundson.co.uk'); wrote:
I think if we did that it would be a good idea to prefix the names
with a common element like
frameworks-coreaddons frameworks-kio etc.
+1. However I'd propose shorter prefix - kf-foo maybe?
+1 for a shorter prefix.
--
Nicolás
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113805: Do not change the build types available with cmake
On Nov. 12, 2013, 8:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply has to not-load the file KDECompilerSettings. If the developer has decided to load this file, it is not surprising that he gets modified compiler flags, because this is what he decided to do. 2) You removed e.g. the flags for the build types COVERAGE and PROFILE. CMake doesn't provide these build types or flags itself, so the patch removes support for these buildtypes. I don't see the need to remove support for profile or coverage builds. CMake itself comes with debug, minsizerel, release and relwithdebinfo. 3) You remove the flags for Linux and/or gcc. Why didn't you remove them for other compilers/operating systems ? I know that what we are doing in this file is not the cmake-recommended way. From cmake, the variables for the flags are cache variables which are set to some default. The idea is that the person who compiles some package can adjust them to his liking. This is from my experience not what we expect from the average KDE contributor. He should get a working set up, with known compiler flags so it is easy to fix buid bugs (or avoid them in the first place). By simply setting the normal (non-cache) variables, the person building the package can set the cache variables to whatever he wants, it will be overridden to what is set in KDECompilerSettings.cmake. Maybe the way this is done could be improved by doing something like if(NOT DEFINED SOME_CXX_FLAGS_ALREADY_PRESET) set(SOME_CXX_FLAGS_ALREADY_PRESET TRUE CACHE BOOL docs... ) set(SOME_CXX_FLAGS --some-flag --another-flag CACHE STRING docs... FORCE) endif() This way it would be only on the initial cmake run forced into the cache, and afterwards the user should be able to change them as he wants. Sune Vuorela wrote: 1) THis file is used by all kde frameworks, so it should not put in surprises for the developers there. ONe shouldn't be 100% familiar with all the internals to hack on stuff. 2) IF we want to add such things, it should be in a ECMAddProfileBuildType or similar. 3) For the other compilers, the build types aren't touched. ANd note that this doesn't modify the flags that covers everything. That I'm saving for another patch. And let us do thhings the cmake way, one step at a time. Alexander Neundorf wrote: 1) I don't really understand. You say no surprises and at the same time you say that developers shouldn't have to be familiar with all internals to hack on stuff. If you want no surprises, remove the line include(KDECompilerSettings) from the project. That's why it has been separated out, to make it optional for users who don't want it. Then you get plain cmake, and can/have to take care of the compiler settings yourself. Add that line, and you get no need to care about internals. Is your plan also to remove the added defintions, linker flags, etc. ? I'm fine if you post a patch which removes the file completely. I just doubt that the KDE community will be happy with this. This is the state as it was May 2006: http://quickgit.kde.org/?p=kdelibs.gita=blobhb=5713bc5ddd7f11ef73e63cf67c4a0ba69180ef3af=cmake%2Fmodules%2FFindKDE4Internal.cmake You'll see that it was quite different from what we have today. It is much less than today. Back then I also started with a minimal set of flags to get KDE built at all. But between then and now, all those changes have gone in for a reason, each single one of them. P.S. I am not objecting, just giving comments. Sune Vuorela wrote: 1) By no surprises I mean by 3rd party users, skilled in Qt and cmake, of a KDE framework - like if I end up using one at work and some of my colleagues need to fix a bug or add a feature, then this would be a unpleasant surprise when dealing with a standalone framework. My plan isn't - yet - to remove the file completely, but first to slice it down to a size where one can see what happens and what side effects it has. I have at least concrete plans for two or three more chunks to remove, but I prefer slice it down chunks at a time. Alexander Neundorf wrote: 1) Let's assume karchive. You have currently at least the following options find_package(KArchive REQUIRED NO_MODULE) This finds the library, KDECompilerSettings.cmake is not involved at all. OR find_package(KF5 REQUIRED NO_MODULE COMPONENTS KArchive) This finds the library, via tier1/kf5umbrella/, KDECompilerSettings.cmake is not involved at all. OR (when
Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS. One less KDE4 reference. I have a matching patch for kdelibs once this goes in. When the kdelibs patch is in, the temporary definition of KDE4_ENABLE_EXCEPTIONS can be removed. Would be good to also factorize the definition and decide once and for all if it should include -UQT_NO_EXCEPTIONS, but that's for another review. Diffs - kde-modules/KDECompilerSettings.cmake 6dafc5f Diff: http://git.reviewboard.kde.org/r/114501/diff/ Testing --- kdelibs build. Checked with `make VERBOSE=1` the exception flags are still correctly passed. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Fwd: Tracking bugs in Frameworks
On Monday 16 December 2013 11:58:35 David Edmundson wrote: I think if we did that it would be a good idea to prefix the names with a common element like frameworks-coreaddons frameworks-kio etc. I don't think it needs the prefix. For a description, we have the product description in bugzilla. So that should be fine. We don't have users who report bugs against frameworks directly, they neither know kio nor frameworks- kio. For our triaging team it shouldn't matter much and from us developers I expect that we know it. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/ Diffs - tier4/khtml/src/CMakeLists.txt a8eb322 tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 tier3/kio/src/kpac/CMakeLists.txt 57d5694 tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 Diff: http://git.reviewboard.kde.org/r/114502/diff/ Testing --- kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from ECM (see ECM review). Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- (Updated Dec. 16, 2013, 6:10 p.m.) Review request for Build System and KDE Frameworks. Changes --- Add link to kdelibs patch Repository: extra-cmake-modules Description (updated) --- Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS. One less KDE4 reference. I have a matching patch for kdelibs once this goes in. When the kdelibs patch is in, the temporary definition of KDE4_ENABLE_EXCEPTIONS can be removed. Would be good to also factorize the definition and decide once and for all if it should include -UQT_NO_EXCEPTIONS, but that's for another review. kdelibs patch: https://git.reviewboard.kde.org/r/114502/ Diffs - kde-modules/KDECompilerSettings.cmake 6dafc5f Diff: http://git.reviewboard.kde.org/r/114501/diff/ Testing --- kdelibs build. Checked with `make VERBOSE=1` the exception flags are still correctly passed. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
Hello, On Monday 16 December 2013 15:16:42 Aurélien Gâteau wrote: Do you want us to add ourselves as contacts in the table or do you plan to fill it later? If the former, I would assign myself to Get the dependency graph generator script ready, Have the frameworks on api.kde.org (already did some work in that area last week, http://api.kde.org/frameworks/kdelibs-apidocs/ looks more complete now) and I'd like to help with Reduce the KDE footprint in ECM as much as possible. As usual, put your name next to it when you turn it into in progress. I pre- allocated a couple because I knew some discussion was going on (maybe I shouldn't have). Regarding the split: what is going to happen to the frameworks branch of the kdelibs repository after the split? Is it going to be removed or is it going to stay there with the framework folders pointing to the framework repositories through git sub-modules? The work on the graph generator and api.kde.org will be different depending on what the branch becomes. Consider it removed from the graph generator pov. Technically it'll stay but will be frozen (no push allowed). Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45802 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 16, 2013, 5:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- (Updated Dec. 16, 2013, 5:10 p.m.) Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS. One less KDE4 reference. I have a matching patch for kdelibs once this goes in. When the kdelibs patch is in, the temporary definition of KDE4_ENABLE_EXCEPTIONS can be removed. Would be good to also factorize the definition and decide once and for all if it should include -UQT_NO_EXCEPTIONS, but that's for another review. kdelibs patch: https://git.reviewboard.kde.org/r/114502/ Diffs - kde-modules/KDECompilerSettings.cmake 6dafc5f Diff: http://git.reviewboard.kde.org/r/114501/diff/ Testing --- kdelibs build. Checked with `make VERBOSE=1` the exception flags are still correctly passed. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45801 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Dec. 16, 2013, 5:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- (Updated Dec. 16, 2013, 5:10 p.m.) Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/ Diffs - tier4/khtml/src/CMakeLists.txt a8eb322 tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 tier3/kio/src/kpac/CMakeLists.txt 57d5694 tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 Diff: http://git.reviewboard.kde.org/r/114502/diff/ Testing --- kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from ECM (see ECM review). Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Fwd: Tracking bugs in Frameworks
On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin mgraess...@kde.org wrote: On Monday 16 December 2013 11:58:35 David Edmundson wrote: I think if we did that it would be a good idea to prefix the names with a common element like frameworks-coreaddons frameworks-kio etc. I don't think it needs the prefix. For a description, we have the product description in bugzilla. So that should be fine. We don't have users who report bugs against frameworks directly, they neither know kio nor frameworks- kio. For our triaging team it shouldn't matter much and from us developers I expect that we know it. I disagree. We will (hopefully) have a lot of developers who use Frameworks who are not 'KDE' reporting bugs on the parts they do use. Having the frameworks scattered over a huge list of 'noise' when they are sorted alphabetically would be really annoying. Certainly when I have to update all the versions in bugzilla after a release I do not want to have to go hunting to find all of them. That said, I don't want to bikeshed over what isn't a particularly massive point. Maybe someone can make an executive decision. David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Fwd: Tracking bugs in Frameworks
On Monday 16 December 2013 19:01:25 David Edmundson wrote: On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin mgraess...@kde.org wrote: On Monday 16 December 2013 11:58:35 David Edmundson wrote: I think if we did that it would be a good idea to prefix the names with a common element like frameworks-coreaddons frameworks-kio etc. I don't think it needs the prefix. For a description, we have the product description in bugzilla. So that should be fine. We don't have users who report bugs against frameworks directly, they neither know kio nor frameworks- kio. For our triaging team it shouldn't matter much and from us developers I expect that we know it. I disagree. We will (hopefully) have a lot of developers who use Frameworks who are not 'KDE' reporting bugs on the parts they do use. You mean 3rd party developers using e.g. KF5Archive? In that case I expect that a) they know that they use KArchive b) they will use Ctrl+F to find it in the product list. Hey even I do that to get to KWin, I'm not scrolling a list of hundreds of products starting with K. It would be just the same with a prefix frameworks. Having the frameworks scattered over a huge list of 'noise' when they are sorted alphabetically would be really annoying. Certainly when I have to update all the versions in bugzilla after a release I do not want to have to go hunting to find all of them. No, you don't want to create those versions in the first place. If we have to create a version for each of the frameworks manually through the web interface we do something wrong. That said, I don't want to bikeshed over what isn't a particularly massive point. Maybe someone can make an executive decision. neither do I and this time I cannot bring the argument that you have no clue about bugzilla to silence your argument :-P So executive decision sounds fine. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where's kf5_add_ui_files ?
[: Albert Astals Cid :]
ki18n_wrap_ui doesn't seem to be usable outside kdelibs.
[ 51%] Generating ui_kgamethemeselector.h
CMake Error: Error processing file: /kf5i18nuic.cmake
I guess the proper fix is largely a matter of convention, which I don't know
what it is. But does the attached patch solve the problem?
--
Chusslove Illich (Часлав Илић)
diff --git a/tier2/ki18n/cmake/KF5I18NMacros.cmake b/tier2/ki18n/cmake/KF5I18NMacros.cmake
index ac557ed..1bf2fa1 100644
--- a/tier2/ki18n/cmake/KF5I18NMacros.cmake
+++ b/tier2/ki18n/cmake/KF5I18NMacros.cmake
@@ -24,7 +24,7 @@ macro (KI18N_WRAP_UI _sources )
-DKDE_UIC_FILE:FILEPATH=${_tmp_FILE}
-DKDE_UIC_H_FILE:FILEPATH=${_header}
-DKDE_UIC_BASENAME:STRING=${_basename}
- -P ${KI18N_MODULE_DIR}/kf5i18nuic.cmake
+ -P ${CMAKE_CURRENT_LIST_DIR}/kf5i18nuic.cmake
MAIN_DEPENDENCY ${_tmp_FILE}
)
list(APPEND ${_sources} ${_header})
signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Can't use DNSSD
El Dilluns, 16 de desembre de 2013, a les 10:36:07, Martin Klapetek va escriure: On Sun, Dec 15, 2013 at 11:18 PM, Albert Astals Cid aa...@kde.org wrote: Any reason i hage to use KF5::KF5DNSSD instead of KF5::DNSSD in target_link_libraries like it would seem logical due to the other frameworks naming? This was a porting bug, sorry. I've pushed a fix, now you can use KF5:DNSSD again (cleaning build dir should be enough). That works now :-) Cheers, Albert Cheers ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114496: Rename kdewidgets to kf5designerplugin
On Dec. 16, 2013, 2:23 p.m., Aurélien Gâteau wrote: Looks good. Just replace kdewidgets with kf5designerplugin in superbuild/CMakeLists.txt. SuperBuild is likely going away soon, but it is still useful for the remaining days before the split. Yeah, I noticed that when I tried building it on the train :-) - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/#review45782 --- On Dec. 16, 2013, 1:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/ --- (Updated Dec. 16, 2013, 1:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Rename kdewidgets to kf5designerplugin This includes renaming makekdewidgets to kgendesignerplugin. Just throwing this at reviewboard before I dash for a train. Diffs - tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 tier3/kdewidgets/KDEWidgetsConfig.cmake d38c875c67a3073e7634bd6f873a38411127b759 tier3/kdewidgets/KDEWidgetsMacros.cmake 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 tier3/kdewidgets/docs/CMakeLists.txt 2b38f53f807c528fdcd6ea128567f6087bd8c673 tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt c283b926f542402d80e22cc42406b119e400a05f tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook cab0c5b51f2bb5be29960f43fe6fb940fffb5402 tier3/kdewidgets/src/AUTHORS tier3/kdewidgets/src/CMakeLists.txt e8626c84227a2ccd0459c5732a51e9ecea49f699 tier3/kdewidgets/src/README tier3/kdewidgets/src/classpreviews.h tier3/kdewidgets/src/classpreviews.cpp tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 tier3/kdewidgets/src/kdewebkit.widgets tier3/kdewidgets/src/kdewebkitwidgets.qrc tier3/kdewidgets/src/kdewidgets.qrc tier3/kdewidgets/src/makekdewidgets.cpp d20e49956a939a06fe3bc2280d57c5c6d31fe24c tier3/kdewidgets/src/pics/CMakeLists.txt 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 tier3/kdewidgets/src/pics/k3iconview.png tier3/kdewidgets/src/pics/k3listview.png tier3/kdewidgets/src/pics/kactionselector.png tier3/kdewidgets/src/pics/kactivelabel.png tier3/kdewidgets/src/pics/kcharselect.png tier3/kdewidgets/src/pics/kcmodule.png tier3/kdewidgets/src/pics/kcolorbutton.png tier3/kdewidgets/src/pics/kcolorcombo.png tier3/kdewidgets/src/pics/kcombobox.png tier3/kdewidgets/src/pics/kdatepicker.png tier3/kdewidgets/src/pics/kdatetable.png tier3/kdewidgets/src/pics/kdualcolorbutton.png tier3/kdewidgets/src/pics/keditlistwidget.png tier3/kdewidgets/src/pics/kfontcombo.png tier3/kdewidgets/src/pics/kfontrequester.png tier3/kdewidgets/src/pics/kgradientselector.png tier3/kdewidgets/src/pics/khistorycombo.png tier3/kdewidgets/src/pics/khsselector.png tier3/kdewidgets/src/pics/kiconbutton.png tier3/kdewidgets/src/pics/kkeybutton.png tier3/kdewidgets/src/pics/kled.png tier3/kdewidgets/src/pics/klineedit.png tier3/kdewidgets/src/pics/klistbox.png tier3/kdewidgets/src/pics/kpalettetable.png tier3/kdewidgets/src/pics/kpasswordedit.png tier3/kdewidgets/src/pics/kruler.png tier3/kdewidgets/src/pics/ksqueezedtextlabel.png tier3/kdewidgets/src/pics/ktextedit.png tier3/kdewidgets/src/pics/kurlcomborequester.png tier3/kdewidgets/src/pics/kurllabel.png tier3/kdewidgets/src/pics/kurlrequester.png tier3/kdewidgets/tests/CMakeLists.txt tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf tier3/kdewidgets/tests/sums tier3/kdewidgets/tests/test.widgets tier3/kf5designerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION tier3/kf5designerplugin/Mainpage.dox PRE-CREATION tier3/kf5designerplugin/docs/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook PRE-CREATION tier3/kf5designerplugin/src/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/tests/README PRE-CREATION tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c tier4/kde4support/src/KDEUIMacros.cmake 31a180c1aab14f22e6a157e8aabfa901db15081a tier4/kde4support/src/kdedeprecated.widgets 604358ac69ba8a8cfbdd8b41a796405fdddebd12 tier4/kde4support/src/pics/CMakeLists.txt
Re: Where's kf5_add_ui_files ?
El Dilluns, 16 de desembre de 2013, a les 19:46:51, Chusslove Illich va escriure: [: Albert Astals Cid :] ki18n_wrap_ui doesn't seem to be usable outside kdelibs. [ 51%] Generating ui_kgamethemeselector.h CMake Error: Error processing file: /kf5i18nuic.cmake I guess the proper fix is largely a matter of convention, which I don't know what it is. But does the attached patch solve the problem? No, that doesn't help [ 51%] Generating ui_kgamethemeselector.h CMake Error: Error processing file: /home/frameworks/libkdegames/kf5i18nuic.cmake Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45811 --- Ship it! Ship It! - Kevin Ottens On Dec. 16, 2013, 5:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- (Updated Dec. 16, 2013, 5:10 p.m.) Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS. One less KDE4 reference. I have a matching patch for kdelibs once this goes in. When the kdelibs patch is in, the temporary definition of KDE4_ENABLE_EXCEPTIONS can be removed. Would be good to also factorize the definition and decide once and for all if it should include -UQT_NO_EXCEPTIONS, but that's for another review. kdelibs patch: https://git.reviewboard.kde.org/r/114502/ Diffs - kde-modules/KDECompilerSettings.cmake 6dafc5f Diff: http://git.reviewboard.kde.org/r/114501/diff/ Testing --- kdelibs build. Checked with `make VERBOSE=1` the exception flags are still correctly passed. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45812 --- Ship it! Ship It! - Kevin Ottens On Dec. 16, 2013, 5:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- (Updated Dec. 16, 2013, 5:10 p.m.) Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/ Diffs - tier4/khtml/src/CMakeLists.txt a8eb322 tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 tier3/kio/src/kpac/CMakeLists.txt 57d5694 tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 Diff: http://git.reviewboard.kde.org/r/114502/diff/ Testing --- kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from ECM (see ECM review). Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114496: Rename kdewidgets to kf5designerplugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/#review45813 --- Shouldn't KDEWidgetsMacros.cmake be renamed too? tier3/CMakeLists.txt http://git.reviewboard.kde.org/r/114496/#comment32728 Now that I see it, it makes me think it could be named kdesignerplugin, no need to repeat the kf5 here imo. - Kevin Ottens On Dec. 16, 2013, 1:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/ --- (Updated Dec. 16, 2013, 1:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Rename kdewidgets to kf5designerplugin This includes renaming makekdewidgets to kgendesignerplugin. Just throwing this at reviewboard before I dash for a train. Diffs - tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 tier3/kdewidgets/KDEWidgetsConfig.cmake d38c875c67a3073e7634bd6f873a38411127b759 tier3/kdewidgets/KDEWidgetsMacros.cmake 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 tier3/kdewidgets/docs/CMakeLists.txt 2b38f53f807c528fdcd6ea128567f6087bd8c673 tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt c283b926f542402d80e22cc42406b119e400a05f tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook cab0c5b51f2bb5be29960f43fe6fb940fffb5402 tier3/kdewidgets/src/AUTHORS tier3/kdewidgets/src/CMakeLists.txt e8626c84227a2ccd0459c5732a51e9ecea49f699 tier3/kdewidgets/src/README tier3/kdewidgets/src/classpreviews.h tier3/kdewidgets/src/classpreviews.cpp tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 tier3/kdewidgets/src/kdewebkit.widgets tier3/kdewidgets/src/kdewebkitwidgets.qrc tier3/kdewidgets/src/kdewidgets.qrc tier3/kdewidgets/src/makekdewidgets.cpp d20e49956a939a06fe3bc2280d57c5c6d31fe24c tier3/kdewidgets/src/pics/CMakeLists.txt 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 tier3/kdewidgets/src/pics/k3iconview.png tier3/kdewidgets/src/pics/k3listview.png tier3/kdewidgets/src/pics/kactionselector.png tier3/kdewidgets/src/pics/kactivelabel.png tier3/kdewidgets/src/pics/kcharselect.png tier3/kdewidgets/src/pics/kcmodule.png tier3/kdewidgets/src/pics/kcolorbutton.png tier3/kdewidgets/src/pics/kcolorcombo.png tier3/kdewidgets/src/pics/kcombobox.png tier3/kdewidgets/src/pics/kdatepicker.png tier3/kdewidgets/src/pics/kdatetable.png tier3/kdewidgets/src/pics/kdualcolorbutton.png tier3/kdewidgets/src/pics/keditlistwidget.png tier3/kdewidgets/src/pics/kfontcombo.png tier3/kdewidgets/src/pics/kfontrequester.png tier3/kdewidgets/src/pics/kgradientselector.png tier3/kdewidgets/src/pics/khistorycombo.png tier3/kdewidgets/src/pics/khsselector.png tier3/kdewidgets/src/pics/kiconbutton.png tier3/kdewidgets/src/pics/kkeybutton.png tier3/kdewidgets/src/pics/kled.png tier3/kdewidgets/src/pics/klineedit.png tier3/kdewidgets/src/pics/klistbox.png tier3/kdewidgets/src/pics/kpalettetable.png tier3/kdewidgets/src/pics/kpasswordedit.png tier3/kdewidgets/src/pics/kruler.png tier3/kdewidgets/src/pics/ksqueezedtextlabel.png tier3/kdewidgets/src/pics/ktextedit.png tier3/kdewidgets/src/pics/kurlcomborequester.png tier3/kdewidgets/src/pics/kurllabel.png tier3/kdewidgets/src/pics/kurlrequester.png tier3/kdewidgets/tests/CMakeLists.txt tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf tier3/kdewidgets/tests/sums tier3/kdewidgets/tests/test.widgets tier3/kf5designerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION tier3/kf5designerplugin/Mainpage.dox PRE-CREATION tier3/kf5designerplugin/docs/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook PRE-CREATION tier3/kf5designerplugin/src/CMakeLists.txt PRE-CREATION tier3/kf5designerplugin/tests/README PRE-CREATION tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c tier4/kde4support/src/KDEUIMacros.cmake 31a180c1aab14f22e6a157e8aabfa901db15081a tier4/kde4support/src/kdedeprecated.widgets 604358ac69ba8a8cfbdd8b41a796405fdddebd12 tier4/kde4support/src/pics/CMakeLists.txt c0e1c2064af67e9ad90d8f5e8a9c892208c6cda0 Diff:
Re: Where's kf5_add_ui_files ?
[: Albert Astals Cid :]
No, that doesn't help
[ 51%] Generating ui_kgamethemeselector.h
CMake Error: Error processing file:
/home/frameworks/libkdegames/kf5i18nuic.cmake
How about this instead?
--
Chusslove Illich (Часлав Илић)
diff --git a/tier2/ki18n/KF5I18nConfig.cmake.in b/tier2/ki18n/KF5I18nConfig.cmake.in
index dcd..dd3b92e 100644
--- a/tier2/ki18n/KF5I18nConfig.cmake.in
+++ b/tier2/ki18n/KF5I18nConfig.cmake.in
@@ -3,6 +3,8 @@
find_dependency(KF5JS @KF5_VERSION@)
+set(KI18N_MODULE_DIR ${PACKAGE_PREFIX_DIR}/@CMAKECONFIG_INSTALL_DIR@)
+
include(${CMAKE_CURRENT_LIST_DIR}/KF5I18nTargets.cmake)
include(${CMAKE_CURRENT_LIST_DIR}/KF5I18NMacros.cmake)
signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114496: Rename kdewidgets to kf5designerplugin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/ --- (Updated Dec. 16, 2013, 9:06 p.m.) Review request for KDE Frameworks. Changes --- Make the directory name kdesignerplugin. Repository: kdelibs Description --- Rename kdewidgets to kf5designerplugin This includes renaming makekdewidgets to kgendesignerplugin. Just throwing this at reviewboard before I dash for a train. Diffs (updated) - superbuild/CMakeLists.txt b53cae64698562588f39ed28b2f30bf0a1f46809 tier3/CMakeLists.txt 374396b3909d5a71dff6d891249ab33194a45522 tier3/kdesignerplugin/KF5DesignerPluginConfig.cmake PRE-CREATION tier3/kdesignerplugin/Mainpage.dox PRE-CREATION tier3/kdesignerplugin/docs/CMakeLists.txt PRE-CREATION tier3/kdesignerplugin/docs/kgendesignerplugin/CMakeLists.txt PRE-CREATION tier3/kdesignerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook PRE-CREATION tier3/kdesignerplugin/src/CMakeLists.txt PRE-CREATION tier3/kdesignerplugin/tests/README PRE-CREATION tier3/kdewidgets/CMakeLists.txt 87c3d5484dfb86018cdd203807588ea6ebd6ac31 tier3/kdewidgets/KDEWidgetsConfig.cmake d38c875c67a3073e7634bd6f873a38411127b759 tier3/kdewidgets/KDEWidgetsMacros.cmake 92d2960a7dfe1645d7c75e3dc6690d78b50706d8 tier3/kdewidgets/Mainpage.dox 85da237c9d4367a37b9b0750565d42e1e73d1ba4 tier3/kdewidgets/docs/CMakeLists.txt 2b38f53f807c528fdcd6ea128567f6087bd8c673 tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt c283b926f542402d80e22cc42406b119e400a05f tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook cab0c5b51f2bb5be29960f43fe6fb940fffb5402 tier3/kdewidgets/src/AUTHORS tier3/kdewidgets/src/CMakeLists.txt e8626c84227a2ccd0459c5732a51e9ecea49f699 tier3/kdewidgets/src/README tier3/kdewidgets/src/classpreviews.h tier3/kdewidgets/src/classpreviews.cpp tier3/kdewidgets/src/kde.widgets 7bcc669d14ed40da6217d09296e25d60a59413b7 tier3/kdewidgets/src/kdewebkit.widgets tier3/kdewidgets/src/kdewebkitwidgets.qrc tier3/kdewidgets/src/kdewidgets.qrc tier3/kdewidgets/src/makekdewidgets.cpp d20e49956a939a06fe3bc2280d57c5c6d31fe24c tier3/kdewidgets/src/pics/CMakeLists.txt 688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180 tier3/kdewidgets/src/pics/k3iconview.png tier3/kdewidgets/src/pics/k3listview.png tier3/kdewidgets/src/pics/kactionselector.png tier3/kdewidgets/src/pics/kactivelabel.png tier3/kdewidgets/src/pics/kcharselect.png tier3/kdewidgets/src/pics/kcmodule.png tier3/kdewidgets/src/pics/kcolorbutton.png tier3/kdewidgets/src/pics/kcolorcombo.png tier3/kdewidgets/src/pics/kcombobox.png tier3/kdewidgets/src/pics/kdatepicker.png tier3/kdewidgets/src/pics/kdatetable.png tier3/kdewidgets/src/pics/kdualcolorbutton.png tier3/kdewidgets/src/pics/keditlistwidget.png tier3/kdewidgets/src/pics/kfontcombo.png tier3/kdewidgets/src/pics/kfontrequester.png tier3/kdewidgets/src/pics/kgradientselector.png tier3/kdewidgets/src/pics/khistorycombo.png tier3/kdewidgets/src/pics/khsselector.png tier3/kdewidgets/src/pics/kiconbutton.png tier3/kdewidgets/src/pics/kkeybutton.png tier3/kdewidgets/src/pics/kled.png tier3/kdewidgets/src/pics/klineedit.png tier3/kdewidgets/src/pics/klistbox.png tier3/kdewidgets/src/pics/kpalettetable.png tier3/kdewidgets/src/pics/kpasswordedit.png tier3/kdewidgets/src/pics/kruler.png tier3/kdewidgets/src/pics/ksqueezedtextlabel.png tier3/kdewidgets/src/pics/ktextedit.png tier3/kdewidgets/src/pics/kurlcomborequester.png tier3/kdewidgets/src/pics/kurllabel.png tier3/kdewidgets/src/pics/kurlrequester.png tier3/kdewidgets/tests/CMakeLists.txt tier3/kdewidgets/tests/README 9dd2132fa7c3601ae04f243a5996aa809b42f7bf tier3/kdewidgets/tests/sums tier3/kdewidgets/tests/test.widgets tier4/kde4support/CMakeLists.txt ccbffd24ede13d5ae6d8386a4aac1853018fcc97 tier4/kde4support/cmake/modules/KDE4Macros.cmake ddfd374607d0eef436fdd6c9e408cd98e59181ae tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c tier4/kde4support/src/KDEUIMacros.cmake 31a180c1aab14f22e6a157e8aabfa901db15081a tier4/kde4support/src/kdedeprecated.widgets 604358ac69ba8a8cfbdd8b41a796405fdddebd12 tier4/kde4support/src/pics/CMakeLists.txt c0e1c2064af67e9ad90d8f5e8a9c892208c6cda0 Diff: http://git.reviewboard.kde.org/r/114496/diff/ Testing --- CMake runs, nothing else tested. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 114512: Move Qt imageformat .desktop files to kde4support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114512/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Move Qt imageformat .desktop files to kde4support These files are installed for the benefit of KImageIO in KDE4Support. The ones for imageformat plugins in Qt should therefore be installed by kde4support itself. Diffs - tier4/kde4support/src/kio/imageformats/CMakeLists.txt PRE-CREATION tier4/kde4support/src/CMakeLists.txt 467e8378e555139774924f053b477050ebba9f5c tier1/kimageformats/src/imageformats/xpm.desktop tier1/kimageformats/src/imageformats/xbm.desktop tier1/kimageformats/src/imageformats/wbmp.desktop tier1/kimageformats/src/imageformats/tiff.desktop tier1/kimageformats/src/imageformats/svg+xml.desktop tier1/kimageformats/src/imageformats/svg+xml-compressed.desktop tier1/kimageformats/src/imageformats/qimageio_plugin.desktop tier1/kimageformats/src/imageformats/ppm.desktop tier1/kimageformats/src/imageformats/png.desktop tier1/kimageformats/src/imageformats/pgm.desktop tier1/kimageformats/src/imageformats/pbm.desktop tier1/kimageformats/src/imageformats/mng.desktop tier1/kimageformats/src/imageformats/jpeg.desktop tier1/kimageformats/src/imageformats/gif.desktop tier1/kimageformats/src/imageformats/ico.desktop tier1/kimageformats/src/imageformats/bmp.desktop tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba078ddc828e4d4f5b1a1ce3f6678248dc99 Diff: http://git.reviewboard.kde.org/r/114512/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where's kf5_add_ui_files ?
El Dilluns, 16 de desembre de 2013, a les 22:07:39, Chusslove Illich va escriure: [: Albert Astals Cid :] No, that doesn't help [ 51%] Generating ui_kgamethemeselector.h CMake Error: Error processing file: /home/frameworks/libkdegames/kf5i18nuic.cmake How about this instead? This works. Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45830 --- This gets rid of the annoying ignoring unknown option '-fexceptions' I kept getting when compiling threadweaver with MSVC. - Nicolás Alvarez On Dec. 16, 2013, 2:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- (Updated Dec. 16, 2013, 2:10 p.m.) Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/ Diffs - tier4/khtml/src/CMakeLists.txt a8eb322 tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 tier3/kio/src/kpac/CMakeLists.txt 57d5694 tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 Diff: http://git.reviewboard.kde.org/r/114502/diff/ Testing --- kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from ECM (see ECM review). Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Fwd: Tracking bugs in Frameworks
On Monday, December 16, 2013 19:30:25 Martin Graesslin wrote: On Monday 16 December 2013 19:01:25 David Edmundson wrote: On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin mgraess...@kde.org On Monday 16 December 2013 11:58:35 David Edmundson wrote: I think if we did that it would be a good idea to prefix the names with a common element like frameworks-coreaddons frameworks-kio etc. I don't think it needs the prefix. For a description, we have the product description in bugzilla. So that should be fine. We don't have users who report bugs against frameworks directly, they neither know kio nor frameworks- kio. For our triaging team it shouldn't matter much and from us developers I expect that we know it. I disagree. We will (hopefully) have a lot of developers who use Frameworks who are not 'KDE' reporting bugs on the parts they do use. You mean 3rd party developers using e.g. KF5Archive? In that case I expect that a) they know that they use KArchive b) they will use Ctrl+F to find it in the product list. Hey even I do that to get to KWin, I'm not scrolling a list of hundreds of products starting with K. It would be just the same with a prefix frameworks. Having the frameworks scattered over a huge list of 'noise' when they are sorted alphabetically would be really annoying. Certainly when I have to update all the versions in bugzilla after a release I do not want to have to go hunting to find all of them. No, you don't want to create those versions in the first place. If we have to create a version for each of the frameworks manually through the web interface we do something wrong. That said, I don't want to bikeshed over what isn't a particularly massive point. Maybe someone can make an executive decision. Let's go for the prefix. Here's my reasoning: if we have a list to choose from, users will see a huge load of generic names (Archive, to name one). If it's prefixed with frameworks, or maybe framework-, it's much easier to dismiss it, and scroll down to the right application (or component). I think it's also clear to those that use our libraries, which is an important (new) target group. neither do I and this time I cannot bring the argument that you have no clue about bugzilla to silence your argument :-P So executive decision sounds fine. You can claim that I have no clue about bugzilla, and you'd be right. But there's your executive decision. Feel free to ignore it. :-) Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Tracking bugs in Frameworks
My two cents from a bug triager's point of view: 1. General * If new products/components are added, it would be nice if one of the maintainers is the default assignee, or - if the generic kdelibs- bugs assignee stays - they are automatically added to the CC list. In case a component is unmaintained, the default assignee should reflect that fact. 2. Re: New bugs * All bug reports are monitored, so the actual product/component does not matter from the perspective of the bug triaging team. I guess practice will show if/how we need to relayout later. * My personal preference would be simply more components for kdelibs, where the splitting previously was not as fine grained as is now needed, e.g. for kdeui or kdecore. * As David already suggested, a simple 5.0, 5.1 etc. version would clearly indicate that the user/developer tested the bug on the frameworks release. 3. Re: Old bugs * Except bugs that are reported against now unmaintained features (KLineEdit etc.), existing bugs are very likely still valid for frameworks (the code, after all, just moved). To keep them into view for whoever maintains a framework, I highly suggest to not let them rot at any old place in bugzilla. * If new products/components are created for frameworks, the bug triaging team will help moving the old reports. Christoph Feck (kdepepo) KDE Quality Team openSUSE Review Team ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Where's kf5_add_ui_files ?
On Mon, Dec 16, 2013 at 10:35 PM, Chusslove Illich caslav.i...@gmx.netwrote: [: Albert Astals Cid :] This works. And it actually looks like things done in some other modules, so I committed it. Thanks for the checks. -- Chusslove Illich (Часлав Илић) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel FWIW, how could this have worked before? :/ Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
On Mon, Dec 16, 2013 at 10:18 AM, Kevin Ottens er...@kde.org wrote: On Sunday 15 December 2013 10:58:35 Alex Merry wrote: On 14/12/13 19:30, Kevin Ottens wrote: Now we're really getting there! Epics and review board are clean, thanks to everyone who helped to get there. Now it's the time to go for the last push. For that I opened what will be the last epic for the 5.0 release: http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation As you can see it is split in two, one part for the tech preview, the second part for what will be needed for a final release. I urge everyone to focus on the tech preview tasks for now. Don't hesitate to give a hand to the people I put in contact for those tasks. I'd like to rename the makekdewidgets executable to something like kgendesignerplugin, to be more descriptive; this should be SC providing we keep the old CMake variables around, but should probably still happen before the TP, I guess? Can happen either before or after IMO. You can go ahead with it (as it looks small enough) if you manage to produce the change before Ben starts splitting the repositories. :-) I have now begun the process of splitting the repositories out. kdelibs[frameworks] has now been frozen for pushes for all except myself, ervin and dfaure to allow for any last minute changes if absolutely necessary. More news on the testing repositories will follow soon. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Let's get in release mode!
On Tue, Dec 17, 2013 at 1:04 PM, Ben Cooksley bcooks...@kde.org wrote: On Mon, Dec 16, 2013 at 10:18 AM, Kevin Ottens er...@kde.org wrote: On Sunday 15 December 2013 10:58:35 Alex Merry wrote: On 14/12/13 19:30, Kevin Ottens wrote: Now we're really getting there! Epics and review board are clean, thanks to everyone who helped to get there. Now it's the time to go for the last push. For that I opened what will be the last epic for the 5.0 release: http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation As you can see it is split in two, one part for the tech preview, the second part for what will be needed for a final release. I urge everyone to focus on the tech preview tasks for now. Don't hesitate to give a hand to the people I put in contact for those tasks. I'd like to rename the makekdewidgets executable to something like kgendesignerplugin, to be more descriptive; this should be SC providing we keep the old CMake variables around, but should probably still happen before the TP, I guess? Can happen either before or after IMO. You can go ahead with it (as it looks small enough) if you manage to produce the change before Ben starts splitting the repositories. :-) I have now begun the process of splitting the repositories out. kdelibs[frameworks] has now been frozen for pushes for all except myself, ervin and dfaure to allow for any last minute changes if absolutely necessary. More news on the testing repositories will follow soon. The repositories have now been created and pushed, with a few exceptions. They can be found at https://projects.kde.org/projects/frameworks, and are available under their respective framework name at g...@git.kde.org:framework name I do have some reservations as to the name of quite a few of those repositories however as they are very generic - and thus tread on common namespace. Suggestions are welcome. There is one exception to the above naming scheme, KWallet - as the kwallet repository already exists it has been called kwallet-framework instead. Also, the following frameworks could not be pushed due to audit (EOL) failures, something which shouldn't exist in final code: - kde4support - kdoctools - kjsembed Everything else went fine as far as I can tell, although it wasn't possible to see if the astyle tools ran or not. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Thanks, Ben Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting 2013-w51 Reminder
Hi there ! Since nobody said anything against it, let's have the last meeting of the year, as always it will happen on #kde-devel today (Tuesday) at 4pm Barcelona (CET / UTC+1) time. If you want me to do any announcement today in the meeting just when the meeting starts either send it as a reply here, or contact me in any way. See you there. Cheers ! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting 2013-w51 Reminder
On Tue, Dec 17, 2013 at 2:30 AM, Àlex Fiestas afies...@kde.org wrote: Hi there ! Since nobody said anything against it, let's have the last meeting of the year, as always it will happen on #kde-devel today (Tuesday) at 4pm Barcelona (CET / UTC+1) time. If you want me to do any announcement today in the meeting just when the meeting starts either send it as a reply here, or contact me in any way. See you there. Cheers ! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Look like Ben will have some announcement... ^^ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- (Updated Dec. 17, 2013, 7:43 a.m.) Status -- This change has been marked as submitted. Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS. One less KDE4 reference. I have a matching patch for kdelibs once this goes in. When the kdelibs patch is in, the temporary definition of KDE4_ENABLE_EXCEPTIONS can be removed. Would be good to also factorize the definition and decide once and for all if it should include -UQT_NO_EXCEPTIONS, but that's for another review. kdelibs patch: https://git.reviewboard.kde.org/r/114502/ Diffs - kde-modules/KDECompilerSettings.cmake 6dafc5f Diff: http://git.reviewboard.kde.org/r/114501/diff/ Testing --- kdelibs build. Checked with `make VERBOSE=1` the exception flags are still correctly passed. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114501: Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/#review45836 --- This review has been submitted with commit d4424389fa9f7605bd8ccf193f902a2c0adc9e81 by Aurélien Gâteau to branch master. - Commit Hook On Dec. 16, 2013, 5:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114501/ --- (Updated Dec. 16, 2013, 5:10 p.m.) Review request for Build System and KDE Frameworks. Repository: extra-cmake-modules Description --- Rename KDE4_ENABLE_EXCEPTIONS to KDE_ENABLE_EXCEPTIONS. One less KDE4 reference. I have a matching patch for kdelibs once this goes in. When the kdelibs patch is in, the temporary definition of KDE4_ENABLE_EXCEPTIONS can be removed. Would be good to also factorize the definition and decide once and for all if it should include -UQT_NO_EXCEPTIONS, but that's for another review. kdelibs patch: https://git.reviewboard.kde.org/r/114502/ Diffs - kde-modules/KDECompilerSettings.cmake 6dafc5f Diff: http://git.reviewboard.kde.org/r/114501/diff/ Testing --- kdelibs build. Checked with `make VERBOSE=1` the exception flags are still correctly passed. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS = KDE_ENABLE_EXCEPTIONS
On Dec. 16, 2013, 11:05 p.m., Nicolás Alvarez wrote: This gets rid of the annoying ignoring unknown option '-fexceptions' I kept getting when compiling threadweaver with MSVC. That's a bit surprising: flags should be the same. I suspect you have not applied the matching ECM patch from https://git.reviewboard.kde.org/r/114501/ :) - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45830 --- On Dec. 16, 2013, 6:10 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- (Updated Dec. 16, 2013, 6:10 p.m.) Review request for Build System and KDE Frameworks. Repository: kdelibs Description --- Use the new KDE_ENABLE_EXCEPTIONS flag, define KDE4_ENABLE_EXCEPTIONS in KDE4Support. Needs https://git.reviewboard.kde.org/r/114501/ Diffs - tier4/khtml/src/CMakeLists.txt a8eb322 tier4/kde4support/cmake/modules/FindKDE4Internal.cmake e3f8c63 tier1/threadweaver/src/Weaver/CMakeLists.txt 8e18b46 tier3/kio/src/kpac/CMakeLists.txt 57d5694 tier1/kimageformats/src/imageformats/CMakeLists.txt 614bba0 Diff: http://git.reviewboard.kde.org/r/114502/diff/ Testing --- kdelibs builds, even after removing the KDE4_ENABLE_EXCEPTIONS definition from ECM (see ECM review). Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
