Re: Why is plasma-framework using /usr/share/kde5?
On Monday 21 of April 2014 17:32:10 you wrote: On Tuesday 15 April 2014 18:14:36 Daniel Vrátil wrote: Hi, I'm wondering why Plasma Framework installs it's .desktop files to /usr/share/kde5 by default? It causes some confusion for packagers: No other framework is using a namespace in /usr/share, they all install into /usr/share/$FrameworkName. I don't see that here. $ find /d/kde/inst/kde_frameworks -name services /d/kde/inst/kde_frameworks/share/plasma/services /d/kde/inst/kde_frameworks/share/kde5/services /d/kde/inst/kde_frameworks/share/dbus-1/services /d/kde/inst/kde_frameworks/share/konqsidebartng/virtual_folders/services The first one, plasma/services, only has some *.operations files. The second one, share/kde5/services/, has all the Type=Service .desktop files from many places (khtml, plasma, kate, baloo, kdevelop, kcm). So this seems consistent to me (unlike your description). I find the inconsistency in some Framework(s?) using a kde5 (or kf5, does not matter) directory namespace, while others don't. Either all frameworks should install to /usr/share/kf5/$framework, or none should. Having /usr/share/services could however lead to various kinds of troubles, so I understand the need for the namespace here, but then I'd expect it everywhere by default. This needs to be a single directory, it can't be /usr/share/plasma because kbuildsycoca5 needs to find all service .desktop files. It's a global database of plugins/services, we can't spread it out. So why does Plasma framework? And if it has to use namespace (but please explain me why), then it should be /usr/share/kf5, not /usr/share/kde5, same as we have /usr/include/KF5 and not /usr/include/KDE5. We can rename kde5 to kf5. It was actually suggested in the past. It's just a bit weird though: /usr/include/KF5 is actually provided by KF5, while here we're talking about plugins provided by the applications. The naming kde5 is historic indeed, but the naming kf5 is arguable. Re Alex Merry's suggestion, at least kde5 or kf5 has a '5' in the name, providing co-installability with version 6 :-). That argument would lead to kservice5, I guess. But not all files in there are related to kservice - e.g. *.protocol files, which are for kio, or ServiceMenus which are for dolphin. This is a good point. So what about co-installability of Plasma framework version 5 and 6 (/usr/share/plasma), KHTML (/usr/share/khtml), KXMLGui (/usr/share/kxmlgui), KJS (/usr/share/kjs). KDocTools is using /usr/share/kdoctools5, so is it expected to have kdoctools6 at some point - why not kservice6? :-) IMHO the naming doesn't matter that much, as long as kbuildsycoca5 can find the files. Sort of. If you want to develop an application that depends on KService only, why should it use /usr/share/kde5/services if it has nothing to do with KDE? Dan -- Daniel Vrátil | dvra...@redhat.com | dvratil on #kde-devel, #kontact, #akonadi KDE Desktop Team Associate Software Engineer, Red Hat, Inc. GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117629: ECMCreateQmFromPoFiles: Plural form support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117629/#review56169 --- This review has been submitted with commit e7ca63c7c5a94279a284bbdcdd14e8c6c5597267 by Aurélien Gâteau to branch master. - Commit Hook On April 18, 2014, 2:29 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117629/ --- (Updated April 18, 2014, 2:29 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- This review is made of two patches --- ECMCreateQmFromPoFiles.cmake: Generate .ts files with correct plural settings --- ECMQmLoader.cpp.in: Always load en translation This way if a plural string is not translated, we fallback to the correct english plural form. Diffs - modules/ECMCreateQmFromPoFiles.cmake b8f3c65 modules/ECMQmLoader.cpp.in fd53060 Diff: https://git.reviewboard.kde.org/r/117629/diff/ Testing --- I created a tool to test plural support. It is available from this repository: g...@git.kde.org:scratch/gateau/qmpluraltest . Instructions to test are in the README.md. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 22, 2014, 9:32 a.m.) Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Changes --- Change API to work with resource types like KStandardDirs. Repository: kcoreaddons Description --- Add class for finding the kde4 config and apps home dirs. To help applications migrating to the kf5/qt5 directories. Diffs (updated) - autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 autotests/kdelibs4migrationtest.cpp PRE-CREATION src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 src/lib/util/kdelibs4migration.h PRE-CREATION src/lib/util/kdelibs4migration.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117511/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117629: ECMCreateQmFromPoFiles: Plural form support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117629/ --- (Updated April 22, 2014, 9:01 a.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- This review is made of two patches --- ECMCreateQmFromPoFiles.cmake: Generate .ts files with correct plural settings --- ECMQmLoader.cpp.in: Always load en translation This way if a plural string is not translated, we fallback to the correct english plural form. Diffs - modules/ECMCreateQmFromPoFiles.cmake b8f3c65 modules/ECMQmLoader.cpp.in fd53060 Diff: https://git.reviewboard.kde.org/r/117629/diff/ Testing --- I created a tool to test plural support. It is available from this repository: g...@git.kde.org:scratch/gateau/qmpluraltest . Instructions to test are in the README.md. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review56172 --- src/lib/util/kdelibs4migration.cpp https://git.reviewboard.kde.org/r/117511/#comment39207 would QStringLiteral work here? src/lib/util/kdelibs4migration.cpp https://git.reviewboard.kde.org/r/117511/#comment39204 Hmm. I think that looks weird. Can this be split in the type definition (struct something) and the constant defintion? src/lib/util/kdelibs4migration.cpp https://git.reviewboard.kde.org/r/117511/#comment39205 Also maybe just a personal taste, but I find it better to explicitly use parentheses when mixing boolean and arithmetic operators, i.e. make it explicit which operator has precendence. In this case putting parentheses around the size calculation. Or even calculating the size as a const int before the loop (can it be done as a const_expr outside the function?). src/lib/util/kdelibs4migration.cpp https://git.reviewboard.kde.org/r/117511/#comment39208 Do we have some logging categories for kdecoreaddons? - Kevin Krammer On April 22, 2014, 9:32 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 22, 2014, 9:32 a.m.) Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Repository: kcoreaddons Description --- Add class for finding the kde4 config and apps home dirs. To help applications migrating to the kf5/qt5 directories. Diffs - autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 autotests/kdelibs4migrationtest.cpp PRE-CREATION src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 src/lib/util/kdelibs4migration.h PRE-CREATION src/lib/util/kdelibs4migration.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117511/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.
On April 22, 2014, 9:50 a.m., Kevin Krammer wrote: src/lib/util/kdelibs4migration.cpp, line 97 https://git.reviewboard.kde.org/r/117511/diff/2/?file=267469#file267469line97 Also maybe just a personal taste, but I find it better to explicitly use parentheses when mixing boolean and arithmetic operators, i.e. make it explicit which operator has precendence. In this case putting parentheses around the size calculation. Or even calculating the size as a const int before the loop (can it be done as a const_expr outside the function?). Or as a std:find_if()? Sorry, have just watched a Going Native talk about no raw loops :) - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review56172 --- On April 22, 2014, 9:32 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 22, 2014, 9:32 a.m.) Review request for KDE Frameworks, Ivan Čukić and Kevin Krammer. Repository: kcoreaddons Description --- Add class for finding the kde4 config and apps home dirs. To help applications migrating to the kf5/qt5 directories. Diffs - autotests/CMakeLists.txt 2f14b3a229b07071ed6e8b0772e03ee798db6c03 autotests/kdelibs4migrationtest.cpp PRE-CREATION src/lib/CMakeLists.txt 39ca3b8e9d5a4f8ffa06ca2ccf017b02ac245fd7 src/lib/util/kdelibs4migration.h PRE-CREATION src/lib/util/kdelibs4migration.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117511/diff/ Testing --- Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117688: Do not skip a language if there is no application catalog for it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Even if an application has not been translated, the libraries it uses might be. It makes sense in this case to load those translations. This is especially useful for small test programs. Diffs - src/klocalizedstring.cpp 43e10ab Diff: https://git.reviewboard.kde.org/r/117688/diff/ Testing --- - Built the kiconthemes framework with translation support (adding -DTRANSLATION_DOMAIN=\kiconthemes5\ definition) - Created and installed a French translation for it. - Ran kicondialogtest: with the patch the dialog is translated, without the patch it is not. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117688: Do not skip a language if there is no application catalog for it
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/#review56183 --- This language skipping was originally motivated precisely because some people thought it bad to have apparent partial translation of an application. I can't point to exact discussion, it was before my time. But therefore I wouldn't change it now without special discussion. If translation is wanted in a small test program, it could set ki18n5 for application catalog. - Chusslove Illich On April 22, 2014, 3:39 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/ --- (Updated April 22, 2014, 3:39 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Even if an application has not been translated, the libraries it uses might be. It makes sense in this case to load those translations. This is especially useful for small test programs. Diffs - src/klocalizedstring.cpp 43e10ab Diff: https://git.reviewboard.kde.org/r/117688/diff/ Testing --- - Built the kiconthemes framework with translation support (adding -DTRANSLATION_DOMAIN=\kiconthemes5\ definition) - Created and installed a French translation for it. - Ran kicondialogtest: with the patch the dialog is translated, without the patch it is not. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2014-w17
Chair: Riddell Reports this week: alexmerry, agateau, apol, mck182, PovAddictW, tosky Observing: markg85, MJD, notmart Announcements: - Sprint: Thursday to Monday, in Barcelona https://sprints.kde.org/sprint/224 notes page: https://notes.kde.org/p/frameworks-sprint-2014 - Beta 2, a week on Thursday, May 1st =Alex Merry= alexmerry I have been doing lots of ECM improvements, getting it in a releasable state alexmerry have a ton of review requests open Riddell alexmerry: svuorela is concerned that the location of directories is set in an ECM file which needs patched by distros and thinks this might not be the best place to set such policy, have you come across that? alexmerry Riddell: yes, but I'm not convinced distros do need to patch it alexmerry other plans for the sprint involve trying to grab people who have access to unusual hardware (non x64_64) for some kimageformats issues =Aurélien Gâteau= agateau working on translations lately agateau Almost done with Qt-based frameworks support. Still need to find out how to handle plural forms: for each framework, a plural-only english .po needs to be kept updated. agateau Question: who should be responsible for this? (I suggested en_GB people but haven't received any feedback for this) (en_GB mostly inactive) =Aleix Pol= apol I have the ongoing effort of moving the documentation around, making sure everything is in place =Martin Klapetek= mck182 I changed the default assignees on the bug reports mck182 and left a default cc to kdelibs-b...@kde.org mck182 there are still lots of frameworks without maintainers mck182 so can people please please update the list mck182 http://community.kde.org/Frameworks/List mck182 that is, if you're a maintainer and your framework says TBD, please update mck182 also I reset the assignee on some bugs mck182 and did some triaging =Nicolás Alvarez= PovAddictW I fixed some more frameworks for buildability on Windows, and started adding emerge (Windows's kdesrc-build) packages for them PovAddictW kio is still waiting on a big patch from arichardson, but all of kio's dependencies are there PovAddictW I also cleaned up leftover if we're building inside monolithic kdelibs checks in all frameworks's CMakeLists.txt =Luigi Toscano= tosky no computer during weekend, so my final (for kf5.0) kdoctools tasks are still ongoing tosky namely, moving the common directory from svn/trunk/l10n-whatever to kdoctools as other common stuff, renaming it and finally install it but I will fix it before the new beta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
UPDATE: Default bugzilla asignees for frameworks
Hey, so as discussed previously, I went over all the BKO frameworks products and made the default assignees for respective frameworks' bugs to be the maintainers as stated in the wiki. I've also reset the assignee on opened bugs, so the current maintainers know about those bugs. The default CC at all bugs is kdelibs-b...@kde.org. Note that there is still 18 frameworks without maintainers Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117688: Do not skip a language if there is no application catalog for it
On April 22, 2014, 3:48 p.m., Chusslove Illich wrote: This language skipping was originally motivated precisely because some people thought it bad to have apparent partial translation of an application. I can't point to exact discussion, it was before my time. But therefore I wouldn't change it now without special discussion. If translation is wanted in a small test program, it could set ki18n5 for application catalog. OK, just sent a mail to kde-i18n-doc to discuss this. - Aurélien --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/#review56183 --- On April 22, 2014, 3:39 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/ --- (Updated April 22, 2014, 3:39 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Even if an application has not been translated, the libraries it uses might be. It makes sense in this case to load those translations. This is especially useful for small test programs. Diffs - src/klocalizedstring.cpp 43e10ab Diff: https://git.reviewboard.kde.org/r/117688/diff/ Testing --- - Built the kiconthemes framework with translation support (adding -DTRANSLATION_DOMAIN=\kiconthemes5\ definition) - Created and installed a French translation for it. - Ran kicondialogtest: with the patch the dialog is translated, without the patch it is not. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : ktexteditor_master_qt5 #365
See http://build.kde.org/job/ktexteditor_master_qt5/365/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117695: change where dynamic replace tabs is performed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56220 --- If the option to reindent pasted code is enabled, does *that* still remove tabs? (Seems like you'd want it too in that case...) - Matthew Woehlke On April 22, 2014, 5:06 p.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 22, 2014, 5:06 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative. I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it. The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;) Diffs - src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 Diff: https://git.reviewboard.kde.org/r/117695/diff/ Testing --- Just some quick manual tests, it seems to still work as intended. Thanks, Sven Brauch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117695: change where dynamic replace tabs is performed
On April 22, 2014, 9:13 p.m., Matthew Woehlke wrote: If the option to reindent pasted code is enabled, does *that* still remove tabs? (Seems like you'd want it too in that case...) Seems it doesn't, I'll look after that. - Sven --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review56220 --- On April 22, 2014, 9:06 p.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated April 22, 2014, 9:06 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- This makes typeChars handle replacing tabs by spaces, instead of insertText. The rationale is that insertText is often called programatically, and the caller should be able to rely on the text he requests to be inserted is actually inserted, and not changed on-the-fly. Examples for where the previous solution caused problems are KDevelop (the codegen) and kte-collaborative. I'm not sure what the code I removed was doing (heh). It looks like it is supposed to advance to the next indent level if the current indent level is odd, but that still works after removing it. The obvious user-visible change here is that tabs in pasted text will no longer be replaced. But since I always found this behaviour undesirable anyways, I did not bother to replicate it. I will instead wait for people to yell at me for removing it. ;) Diffs - src/document/katedocument.cpp 546d3e6aadc57f24c3fa766ce235addc0f02e3c3 Diff: https://git.reviewboard.kde.org/r/117695/diff/ Testing --- Just some quick manual tests, it seems to still work as intended. Thanks, Sven Brauch ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 22, 2014, 10:03 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Fixed warning text. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs (updated) - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w17
On Tuesday, April 22, 2014 03:36:28 PM Jonathan Riddell wrote: Chair: Riddell Reports this week: alexmerry, agateau, apol, mck182, PovAddictW, tosky Observing: markg85, MJD, notmart Announcements: - Sprint: Thursday to Monday, in Barcelona https://sprints.kde.org/sprint/224 notes page: https://notes.kde.org/p/frameworks-sprint-2014 - Beta 2, a week on Thursday, May 1st =Alex Merry= alexmerry I have been doing lots of ECM improvements, getting it in a releasable state alexmerry have a ton of review requests open Riddell alexmerry: svuorela is concerned that the location of directories is set in an ECM file which needs patched by distros and thinks this might not be the best place to set such policy, have you come across that? alexmerry Riddell: yes, but I'm not convinced distros do need to patch it alexmerry other plans for the sprint involve trying to grab people who have access to unusual hardware (non x64_64) for some kimageformats issues =Aurélien Gâteau= agateau working on translations lately agateau Almost done with Qt-based frameworks support. Still need to find out how to handle plural forms: for each framework, a plural-only english .po needs to be kept updated. agateau Question: who should be responsible for this? (I suggested en_GB people but haven't received any feedback for this) (en_GB mostly inactive) =Aleix Pol= apol I have the ongoing effort of moving the documentation around, making sure everything is in place =Martin Klapetek= mck182 I changed the default assignees on the bug reports mck182 and left a default cc to kdelibs-b...@kde.org mck182 there are still lots of frameworks without maintainers mck182 so can people please please update the list mck182 http://community.kde.org/Frameworks/List mck182 that is, if you're a maintainer and your framework says TBD, please update mck182 also I reset the assignee on some bugs mck182 and did some triaging =Nicolás Alvarez= PovAddictW I fixed some more frameworks for buildability on Windows, and started adding emerge (Windows's kdesrc-build) packages for them PovAddictW kio is still waiting on a big patch from arichardson, but all of kio's dependencies are there PovAddictW I also cleaned up leftover if we're building inside monolithic kdelibs checks in all frameworks's CMakeLists.txt =Luigi Toscano= tosky no computer during weekend, so my final (for kf5.0) kdoctools tasks are still ongoing tosky namely, moving the common directory from svn/trunk/l10n-whatever to kdoctools as other common stuff, renaming it and finally install it but I will fix it before the new beta =Allen Winter= For no reason in particular, I thought to try kdesrc-build frameworks on my slow Macbook Pro. So I've been plodding through trying to get a clean build going on Mac. Made some progress with Harald's help. Stuck in docbook hell at the moment (kdoctools/xslt.cpp says it can't find the customizations). Anyway, just thought I'd mention this. -Allen ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w17
El martes, 22 de abril de 2014, Allen Winter win...@kde.org escribió: On Tuesday, April 22, 2014 03:36:28 PM Jonathan Riddell wrote: Chair: Riddell Reports this week: alexmerry, agateau, apol, mck182, PovAddictW, tosky Observing: markg85, MJD, notmart Announcements: - Sprint: Thursday to Monday, in Barcelona https://sprints.kde.org/sprint/224 notes page: https://notes.kde.org/p/frameworks-sprint-2014 - Beta 2, a week on Thursday, May 1st =Alex Merry= alexmerry I have been doing lots of ECM improvements, getting it in a releasable state alexmerry have a ton of review requests open Riddell alexmerry: svuorela is concerned that the location of directories is set in an ECM file which needs patched by distros and thinks this might not be the best place to set such policy, have you come across that? alexmerry Riddell: yes, but I'm not convinced distros do need to patch it alexmerry other plans for the sprint involve trying to grab people who have access to unusual hardware (non x64_64) for some kimageformats issues =Aurélien Gâteau= agateau working on translations lately agateau Almost done with Qt-based frameworks support. Still need to find out how to handle plural forms: for each framework, a plural-only english .po needs to be kept updated. agateau Question: who should be responsible for this? (I suggested en_GB people but haven't received any feedback for this) (en_GB mostly inactive) =Aleix Pol= apol I have the ongoing effort of moving the documentation around, making sure everything is in place =Martin Klapetek= mck182 I changed the default assignees on the bug reports mck182 and left a default cc to kdelibs-b...@kde.org javascript:; mck182 there are still lots of frameworks without maintainers mck182 so can people please please update the list mck182 http://community.kde.org/Frameworks/List mck182 that is, if you're a maintainer and your framework says TBD, please update mck182 also I reset the assignee on some bugs mck182 and did some triaging =Nicolás Alvarez= PovAddictW I fixed some more frameworks for buildability on Windows, and started adding emerge (Windows's kdesrc-build) packages for them PovAddictW kio is still waiting on a big patch from arichardson, but all of kio's dependencies are there PovAddictW I also cleaned up leftover if we're building inside monolithic kdelibs checks in all frameworks's CMakeLists.txt =Luigi Toscano= tosky no computer during weekend, so my final (for kf5.0) kdoctools tasks are still ongoing tosky namely, moving the common directory from svn/trunk/l10n-whatever to kdoctools as other common stuff, renaming it and finally install it but I will fix it before the new beta =Allen Winter= For no reason in particular, I thought to try kdesrc-build frameworks on my slow Macbook Pro. So I've been plodding through trying to get a clean build going on Mac. Made some progress with Harald's help. Stuck in docbook hell at the moment (kdoctools/xslt.cpp says it can't find the customizations). Anyway, just thought I'd mention this. The same error happens on Windows. I have been commenting out add_subdirectory(docs) here and there to get things to build. -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117682: Define _DARWIN_C_SOURCE when building on Mac
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117682/ --- (Updated April 22, 2014, 11:51 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Harald Fernengel. Changes --- add definition of QT_MAC_USE_COCOA Repository: extra-cmake-modules Description --- Must define _DARWIN_C_SOURCE on the Mac in order to get the declarations for readlink(), setegid(), seteuid(), etc i.e for Single Unix Standard v3 (SUSv3) conformance Diffs (updated) - kde-modules/KDECompilerSettings.cmake 229e4f5 Diff: https://git.reviewboard.kde.org/r/117682/diff/ Testing --- works on the Mac didn't break the build on Linux Thanks, Allen Winter ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117604: Fix KDBusServiceStarter::findServiceFor() not returning error string
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/#review56243 --- Ship it! Ship It! - David Faure On April 22, 2014, 10:03 p.m., David Jarvie wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117604/ --- (Updated April 22, 2014, 10:03 p.m.) Review request for KDE Frameworks and David Faure. Repository: kservice Description --- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. This is a copy of https://git.reviewboard.kde.org/r/116951/ for KDE 4, except that the qDebug line has been uncommented on the grounds that it reports an error. Diffs - src/plugin/kdbusservicestarter.cpp 6f011bd Diff: https://git.reviewboard.kde.org/r/117604/diff/ Testing --- Tested for review 116951. Thanks, David Jarvie ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
