Review Request 119241: Fix QExplicitlySharedDataPointer usage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- Review request for KDE Frameworks. Repository: kservice Description --- Fix QExplicitlySharedDataPointer usage One of the constructors of QExplicitlySharedDataPointer got disabled in Qt 5.4 due to being to permissive. Also see: http://kfunk.org/2014/07/10/wrap-up-issues-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/kbuildsycoca/kbuildservicefactory.cpp bc36a22ced38892a92656d37a5d63e768dec6d40 src/kbuildsycoca/kbuildservicegroupfactory.cpp ea0d6ed094347c4bb3f0ce2bfd9a26445a25c545 src/kbuildsycoca/kbuildservicetypefactory.cpp 8f577a4267e8818e7e2cf5109068659439ca3221 src/kbuildsycoca/kbuildsycoca.cpp ed2929f4e60a1841807ce8490c8057d5a7b55827 src/services/kmimetypefactory.cpp a52d07d1dd9040c0a79f36f1665822e714d9b369 src/services/kservicefactory.cpp bb1e0f58396a358c3168c74a89be04315a295fcd src/services/kservicegroup.cpp 0bda1340ae0356c3d5aca9a9f0b3dd5e905638d8 src/services/kservicetypefactory.cpp 7599c4c73220b2aca366f41ac5cd7d05abfa8afc src/sycoca/ksycocadict.cpp a584f933bff10f44bc257ab996aaee3ad38cc79c tests/ksycocatest.cpp d51d80a691427fa4295dd06802de2fb87112f0ff Diff: https://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119242: Fix QExplicitlySharedDataPointer usage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119242/ --- Review request for KDE Frameworks. Repository: kio Description --- Fix QExplicitlySharedDataPointer usage One of the constructors of QExplicitlySharedDataPointer got disabled in Qt 5.4 due to being to permissive. Also see: http://kfunk.org/2014/07/10/wrap-up-issues-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/widgets/kopenwithdialog.cpp 8cb659fde2028892de82bad64e0ea3ff285b5e3a Diff: https://git.reviewboard.kde.org/r/119242/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- Review request for KDE Frameworks. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:01 p.m.) Review request for KDE Frameworks. Changes --- Added compiler output. Repository: kio Description (updated) --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/#review62182 --- tests/ksycocatest.cpp https://git.reviewboard.kde.org/r/119241/#comment43220 Why does it need a static_cast if we're upcasting? Also constructing a shared pointer from the data field in another one seems dangerous... - Aleix Pol Gonzalez On July 12, 2014, 9:41 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- (Updated July 12, 2014, 9:41 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Fix QExplicitlySharedDataPointer usage One of the constructors of QExplicitlySharedDataPointer got disabled in Qt 5.4 due to being to permissive. Also see: http://kfunk.org/2014/07/10/wrap-up-issues-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/kbuildsycoca/kbuildservicefactory.cpp bc36a22ced38892a92656d37a5d63e768dec6d40 src/kbuildsycoca/kbuildservicegroupfactory.cpp ea0d6ed094347c4bb3f0ce2bfd9a26445a25c545 src/kbuildsycoca/kbuildservicetypefactory.cpp 8f577a4267e8818e7e2cf5109068659439ca3221 src/kbuildsycoca/kbuildsycoca.cpp ed2929f4e60a1841807ce8490c8057d5a7b55827 src/services/kmimetypefactory.cpp a52d07d1dd9040c0a79f36f1665822e714d9b369 src/services/kservicefactory.cpp bb1e0f58396a358c3168c74a89be04315a295fcd src/services/kservicegroup.cpp 0bda1340ae0356c3d5aca9a9f0b3dd5e905638d8 src/services/kservicetypefactory.cpp 7599c4c73220b2aca366f41ac5cd7d05abfa8afc src/sycoca/ksycocadict.cpp a584f933bff10f44bc257ab996aaee3ad38cc79c tests/ksycocatest.cpp d51d80a691427fa4295dd06802de2fb87112f0ff Diff: https://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- Review request for KDE Frameworks. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Add kdewin to the groups. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage
On July 12, 2014, 2:01 p.m., Aleix Pol Gonzalez wrote: tests/ksycocatest.cpp, line 104 https://git.reviewboard.kde.org/r/119241/diff/1/?file=289736#file289736line104 Why does it need a static_cast if we're upcasting? Also constructing a shared pointer from the data field in another one seems dangerous... That' a downcast. The hierarchy is KService : KSycocaEntry : QSharedData. Also, construcing it from the data field isn't dangerous -- because the ref-counter is inside the tracked object (QSharedData). Note that QExplicitlySharedDataPointer is missing convenience API like we had in KSharedPtr, e.g. KSharedPtr::staticCast. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/#review62182 --- On July 12, 2014, 9:41 a.m., Kevin Funk wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- (Updated July 12, 2014, 9:41 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Fix QExplicitlySharedDataPointer usage One of the constructors of QExplicitlySharedDataPointer got disabled in Qt 5.4 due to being to permissive. Also see: http://kfunk.org/2014/07/10/wrap-up-issues-with-qexplicitlyshareddatapointer-ksharedptr-successor/ Diffs - src/kbuildsycoca/kbuildservicefactory.cpp bc36a22ced38892a92656d37a5d63e768dec6d40 src/kbuildsycoca/kbuildservicegroupfactory.cpp ea0d6ed094347c4bb3f0ce2bfd9a26445a25c545 src/kbuildsycoca/kbuildservicetypefactory.cpp 8f577a4267e8818e7e2cf5109068659439ca3221 src/kbuildsycoca/kbuildsycoca.cpp ed2929f4e60a1841807ce8490c8057d5a7b55827 src/services/kmimetypefactory.cpp a52d07d1dd9040c0a79f36f1665822e714d9b369 src/services/kservicefactory.cpp bb1e0f58396a358c3168c74a89be04315a295fcd src/services/kservicegroup.cpp 0bda1340ae0356c3d5aca9a9f0b3dd5e905638d8 src/services/kservicetypefactory.cpp 7599c4c73220b2aca366f41ac5cd7d05abfa8afc src/sycoca/ksycocadict.cpp a584f933bff10f44bc257ab996aaee3ad38cc79c tests/ksycocatest.cpp d51d80a691427fa4295dd06802de2fb87112f0ff Diff: https://git.reviewboard.kde.org/r/119241/diff/ Testing --- Thanks, Kevin Funk ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Add kdewin to the groups. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62197 --- src/kdecore/k3resolver.h https://git.reviewboard.kde.org/r/119249/#comment43230 Issue 1: Same as the above. src/kdecore/k3resolver.h https://git.reviewboard.kde.org/r/119249/#comment43231 Issue 1: Same as the above. src/kdemacros.h.cmake https://git.reviewboard.kde.org/r/119249/#comment43229 Issue 1: Use the mechanism discussed here http://lists.kde.org/?l=kde-core-develm=113126965312032w=2 to workaround the full template instantiation issue. src/kdeui/kapplication.cpp https://git.reviewboard.kde.org/r/119249/#comment43232 Issue 2: kaboutdata.h has a forward declaration for being able to declare the namespaced KCrash::defaultCrashHandler as a friend. This is OK until it is included before kcrash.h. MSVC will cosider the first seen declaration (without the export) and will consider the one in kcrash.h a redefinition with different linkage. Please note that this is actually not a KDELibs4Support issue but a KCoreAddons and KCrash interoperability on MSVC issue. src/kdeui/keditlistbox.h https://git.reviewboard.kde.org/r/119249/#comment43233 Issue 5: Nested classes need to be exported to be usable from outside the library (in this case a test). src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43234 Issue 3: See http://msdn.microsoft.com/en-us/library/t72ahzw1.aspx Member methods of exported classes should not be exported explicitly. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43235 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43236 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43237 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43238 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43239 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43240 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43241 Issue 3: Same as the above. tests/kprintpreview_test.cpp https://git.reviewboard.kde.org/r/119249/#comment43242 Issue 4: QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 q:\kdelibs4support\tests\kprintpreview_test.cpp(58) : error C2308: concatenating mismatched strings Concatenating wide Lorem ipsum dolor sit amet, consectetur adipiscing elit. with narrow Nam malesuada massa dolor, sed sollicitudin turpiscongue eu. Pellentesque ac risus felis. Etiam scelerisque It's just a test, do we really need QStringLiteral? - Cristian Oneț On Iulie 12, 2014, 5:02 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 5:02 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff:
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62198 --- Generally seems sensible, apart from the things I noted below. autotests/kdebug_qcoreapptest.cpp https://git.reviewboard.kde.org/r/119249/#comment43245 See later comment about fixing this in KCoreAddons. src/kdeui/kapplication.cpp https://git.reviewboard.kde.org/r/119249/#comment43243 Ooh, that's a nasty trap. We should fix this in KCoreAddons, not work around it here. Possibly by using Q_DECL_IMPORT in the forward declaration. tests/kprintpreview_test.cpp https://git.reviewboard.kde.org/r/119249/#comment43244 This should have a comment, otherwise someone well-meaning will undo your change. - Alex Merry On July 12, 2014, 5:02 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated July 12, 2014, 5:02 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62202 --- Doesn't qplatformdefs.h define this already? - David Faure On July 12, 2014, 2:20 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated July 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
On July 12, 2014, 6:54 p.m., David Faure wrote: Doesn't qplatformdefs.h define this already? Ah not exactly, but you can use QT_STAT_DIR and QT_STAT_REG. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62202 --- On July 12, 2014, 2:20 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated July 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- Review request for KDE Frameworks and kdewin. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
On July 12, 2014, 5:19 p.m., Cristian Oneț wrote: src/kio/netaccess.h, line 197 https://git.reviewboard.kde.org/r/119249/diff/1/?file=289765#file289765line197 Issue 3: See http://msdn.microsoft.com/en-us/library/t72ahzw1.aspx Member methods of exported classes should not be exported explicitly. But they should still be marked as deprecated so that people get a warning when calling these static methods (not sure the deprecation macro on the class will trigger it?). So maybe this should be KDELIBS4SUPPORT_DEPRECATED? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62197 --- On July 12, 2014, 5:02 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated July 12, 2014, 5:02 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
On Iulie 12, 2014, 5:44 p.m., Alex Merry wrote: src/kdeui/kapplication.cpp, lines 22-24 https://git.reviewboard.kde.org/r/119249/diff/1/?file=289763#file289763line22 Ooh, that's a nasty trap. We should fix this in KCoreAddons, not work around it here. Possibly by using Q_DECL_IMPORT in the forward declaration. Opened https://git.reviewboard.kde.org/r/119251/ - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62198 --- On Iulie 12, 2014, 5:02 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 5:02 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 7:09 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 7:15 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Add KDELIBS4SUPPORT_DEPRECATED instead of KDELIBS4SUPPORT_DEPRECATED_EXPORT to keep the deprecation warning but to remove the export. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs (updated) - src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
On Iulie 12, 2014, 6:54 p.m., David Faure wrote: Doesn't qplatformdefs.h define this already? David Faure wrote: Ah not exactly, but you can use QT_STAT_DIR and QT_STAT_REG. Yeah, that was my other option, I'm going to update the diff. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62202 --- On Iulie 12, 2014, 2:20 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 7:25 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Update using QT_STAT_DIR and QT_STAT_REG. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs (updated) - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/#review62209 --- src/lib/kaboutdata.h https://git.reviewboard.kde.org/r/119251/#comment43252 Normally, it goes before the return type. It presumably still works where you put it, but it looks very odd. - Alex Merry On July 12, 2014, 7:02 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated July 12, 2014, 7:02 p.m.) Review request for KDE Frameworks and kdewin. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
On Iulie 12, 2014, 7:26 p.m., Alex Merry wrote: src/lib/kaboutdata.h, line 38 https://git.reviewboard.kde.org/r/119251/diff/1/?file=289784#file289784line38 Normally, it goes before the return type. It presumably still works where you put it, but it looks very odd. You're right, sorry about that, but it do works both ways :). - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/#review62209 --- On Iulie 12, 2014, 7:30 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks. Changes --- Fixed issues. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs (updated) - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62211 --- Ship it! Please make it one commit for each issue you listed (except issue 2, of course, since that's covered in the other review request). - Alex Merry On July 12, 2014, 7:15 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated July 12, 2014, 7:15 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks and kdewin. Changes --- post-review keeps removing kdewin :). Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62213 --- Ship it! Looks good. Grepping for S_ISDIR shows that kdelibs4support has some more (but no other framework does). - David Faure On July 12, 2014, 7:25 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated July 12, 2014, 7:25 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119198: Don't search default paths when finding lconvert.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/#review62214 --- Ship it! Yep, seems sensible to me. We definitely want the lconvert that matches the lrelease we're using. - Alex Merry On July 9, 2014, 2:12 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/ --- (Updated July 9, 2014, 2:12 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Otherwise, if lconvert exists in normal system paths (eg. /usr/bin) that one will be used instead of the one alongside Qt5::lrelease. This could cause Qt4 lconvert to be incorrectly used on some systems. Diffs - modules/ECMPoQmTools.cmake 3ce695817cb3da5ec9eebec86e632438c5941ee6 modules/ECMCreateQmFromPoFiles.cmake 4a31a93e7900780dc5b9424b148f19f5c22061af Diff: https://git.reviewboard.kde.org/r/119198/diff/ Testing --- When building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119164: khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119164/#review62219 --- Ship it! I checked this patch and the rc files do land in share/kxmlgui5/khtml/ as intended. - Marko Käning On July 7, 2014, 9:17 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119164/ --- (Updated July 7, 2014, 9:17 p.m.) Review request for KDE Frameworks, Jonathan Riddell, Marko Käning, and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5) This removes the need to version the file themselves, so revert that. Diffs - src/CMakeLists.txt fe4f49e5799f6b8781eebb217c49b9171600e2f3 src/khtml_part.cpp d7dcb92619d1ba69f015b3a48d9b352f40241196 Diff: https://git.reviewboard.kde.org/r/119164/diff/ Testing --- testkhtml still has menus (even after removing the old files) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated July 12, 2014, 7:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated July 12, 2014, 7:49 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
On Iulie 12, 2014, 7:33 p.m., David Faure wrote: Looks good. Grepping for S_ISDIR shows that kdelibs4support has some more (but no other framework does). The rest is in code the is not compiled on Windows or at least MSVC. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62213 --- On Iulie 12, 2014, 7:25 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 7:25 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated July 12, 2014, 7:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62224 --- Windows has no concept of an integer UID/GID, it uses much longer SIDs to identify users. These are not returned by stat (stat always returns zero in the st_uid member). I would just ifdef away the UDS_USER and UDS_GROUP lines on Windows. - Nicolás Alvarez On Jul. 12, 2014, 11:20 a.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Jul. 12, 2014, 11:20 a.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119164: khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119164/ --- (Updated July 12, 2014, 9:25 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Jonathan Riddell, Marko Käning, and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5) This removes the need to version the file themselves, so revert that. Diffs - src/CMakeLists.txt fe4f49e5799f6b8781eebb217c49b9171600e2f3 src/khtml_part.cpp d7dcb92619d1ba69f015b3a48d9b352f40241196 Diff: https://git.reviewboard.kde.org/r/119164/diff/ Testing --- testkhtml still has menus (even after removing the old files) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translations in frameworks released tarballs
On Wednesday 09 July 2014 11:59:01 Harald Sitter wrote: On Wed, Jul 9, 2014 at 11:27 AM, Alexander Potashev aspotas...@gmail.com wrote: 2014-07-09 2:38 GMT+04:00 David Faure fa...@kde.org: On Tuesday 08 July 2014 23:24:36 Christoph Feck wrote: Is it possible to strip them before the archives are packed? Or can they even be stripped in the repositories? Good question. If kde-i18n-doc says better not strip in the repositories, then I can make the stripping a part of the release scripts. Hi David, I would say better not strip in the repositories. It might be my personal feeling, a fear to forget and lose data, but there might be workflows broken if you strip obsolete messages. Example: someone removes a chunk of code and restores it next day. If you strip obsoletes in between, then translations for the restored code will be lost. Otherwise msgmerge would put them back as fuzzy messages and then translators only need to unfuzzy them which is easy. Even if we decide to strip obsolete messages automatically (daily?), someone might commit a new translation file with some obsolete messages on the tagging/release day and then you still find obsoletes in the release tarballs. FWIW, the releaseme script does stripping at tarball creation time and has done so for many years, it seems the best safeguard against garbage in the tar (and btw, these also ultimately end up in the .mo, unless gettext was changed to not include them). So, regardless of whether we would want to strip them server side I think it would be best if the release script also attempted to strip the obsolete messages; it's plenty cheap. OK, added to my release scripts. kwindowsystem's po subdir goes from 25M to 744K indeed... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
On Iulie 12, 2014, 7:58 p.m., Nicolás Alvarez wrote: Windows has no concept of an integer UID/GID, it uses much longer SIDs to identify users. These are not returned by stat (stat always returns zero in the st_uid member). I would just ifdef away the UDS_USER and UDS_GROUP lines on Windows. That's true, but then is theare a reason to have a KUser(K_UID) constructor on Windows? - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62224 --- On Iulie 12, 2014, 2:20 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
