Attention KDE Frameworks 5 Cookbook authors

[Valorie Zimmerman]

Hi folks, if you intend to get a chapter or section into the first
edition of the cookbook, please commit as soon as possible. We need to
get this all put together and out to a printer in time to have copies
in hand at Akademy. I hope we'll have a copy for each contributor. If
you were not at Randa, you can still contribute! And we need good
reviewers as well as writers.

In fact, if you don't think you can write, but there is already good
material (blogs, techbase, etc.) about the framework(s) you know well,
please collect that material and submit it. We'll make it fit together
coherently. Just be sure that what you submit is technically accurate;
we'll make it readable.

For those of you have not yet seen https://books.kde.org - this is a
living project. Our end goal is to cover all the frameworks, enlarging
the prospective audience from Qt-only developers, to include KDE
developers too, who want to incorporate the frameworks into their
code.

All the best,

Valorie, for the KDE Books team

-- 
http://about.me/valoriez
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

OSX/CI: libkdxraw fails to build on branch frameworks

[Marko Käning]

There are actually two problems here:

---

Building CXX object src/CMakeFiles/LibKDcraw.dir/squeezedcombobox.cpp.o
In file included from 
/Users/marko/WC/KDECI-builds/libkdcraw/src/squeezedcombobox.cpp:31:
/Users/marko/WC/KDECI-builds/libkdcraw/src/squeezedcombobox.h:36:10: fatal 
error: 'QtGui/QComboBox' file not found
#include 
 ^
5 warnings generated.
In file included from 
/Users/marko/WC/KDECI-builds/libkdcraw/src/ractionthreadbase_p.cpp:28:
/Users/marko/WC/KDECI-builds/libkdcraw/src/ractionthreadbase_p.h:40:10: fatal 
error: 'threadweaver/WeaverObserver.h' file not found
#include 
 ^
In file included from 
/Users/marko/WC/KDECI-builds/libkdcraw/src/ractionthreadbase.cpp:47:
/Users/marko/WC/KDECI-builds/libkdcraw/src/ractionthreadbase_p.h:40:10: fatal 
error: 'threadweaver/WeaverObserver.h' file not found
#include 
 ^
1 error generated.
make[2]: *** [src/CMakeFiles/LibKDcraw.dir/ractionthreadbase.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs
1 error generated.
make[2]: *** [src/CMakeFiles/LibKDcraw.dir/ractionthreadbase_p.cpp.o] Error 1

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kdelibs4support fails to build

[Marko Käning]

For cmake it is apparently a good idea to use commit 
3c0d87645f5861e9fd6fd78855697f77ef77144e
from August 18th in order to be able to build KF5 successfully!

Cristian gave me the hint that this version worked for him on Windows. :) Can’t 
thank him
enough, since now kcoreaddons doesn’t get wrecked anymore! :-D

Also FWs kio and kdelibs4support got eventually built successfully and it seems 
like the
rest is going to follow suit! :-)


But, I am puzzled, as I have tried building only kcoreaddons and kauth as a 
test a couple
of times with *more recent* cmake versions than that a while ago...

Perhaps some error gets merged in after Aug 18th?
Looks like as if it’s a good idea trying to bisect this issue at a later time...

For the next few days I’ll give myself a rest, though.
Being only a half-automatic CI system is getting exhausting. ;)

Greets,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65255
---



kde-modules/KDEInstallDirs.cmake


I'd prefix the variable with KDE_.

We are in KDEInstallDirs.cmake after all.

Also make it explicit that it's OFF by default.



kde-modules/KDEInstallDirs.cmake


Indent inside the if() and else()



kde-modules/KDEInstallDirs.cmake


endif()



modules/ECMGeneratePriFile.cmake


This variable is in KDEInstallDirs. It's a weird dependency to have...



modules/ECMGeneratePriFile.cmake


endif()
http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands



modules/ECMQueryQmake.cmake


end*()

http://techbase.kde.org/Policies/CMake_Coding_Style#End_commands


- Aleix Pol Gonzalez


On Aug. 25, 2014, 6 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> ---
> 
> (Updated Aug. 25, 2014, 6 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in 
> ECM.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
>   modules/ECMGeneratePriFile.cmake 34001d6 
>   modules/ECMQueryQmake.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> ---
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119936: Add a basic unit test for KPluginInfo

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119936/
---

Review request for KDE Frameworks.


Repository: kservice


Description
---

Add a basic unit test for KPluginInfo


Diffs
-

  autotests/CMakeLists.txt da83f46a9dcd1fa7801bead5715abf51cd12d668 
  autotests/kplugininfotest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119936/diff/


Testing
---

Unit test passes, however I would like some feedback on the three TODO: 
comments. Is this intended behaviour or should it be fixed?


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119356/
---

(Updated Aug. 25, 2014, 11:26 nachm.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Unlike the original KConfig based tool it now includes all translations
for keys and not just the one for the current locale. Also added a unit
test for it.

Add a verbose option to desktoptojson


Also check for missing entries in the desktoptojson unit test


make the desktoptojson unit test less verbose


install a KF5CoreAddonsMacros.cmake with kcoreaddons_desktop_to_json()


Convert the .desktop files to a new .json format and adapt tests

This format is used by KPluginMetaData and allows removing all the
useless X-KDE-PluginInfo prefixes


Diffs
-

  CMakeLists.txt f45f573e18642c6cf246b90891cce24180a6898a 
  KF5CoreAddonsConfig.cmake.in c471006ee2c8f52b5c22c5edc617554f671237d1 
  KF5CoreAddonsMacros.cmake PRE-CREATION 
  autotests/CMakeLists.txt 96dd263b994ffdc59cec4add161394f7747dce9b 
  autotests/desktoptojsontest.cpp PRE-CREATION 
  src/CMakeLists.txt ef1eea63c92532eea7003c67b59bb3649bc02484 
  src/desktoptojson/CMakeLists.txt PRE-CREATION 
  src/desktoptojson/desktoptojson.h PRE-CREATION 
  src/desktoptojson/desktoptojson.cpp PRE-CREATION 
  src/desktoptojson/main.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119356/diff/


Testing
---

Unit test works and passes.


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kdelibs4support fails to build

[Marko Käning]

Hi David,

ok, than let’s forget about kdelibs4support for now and focus on kio...


On 25 Aug 2014, at 18:59 , David Faure  wrote:
> It's installed by KIO, into include/KF5/KIOCore/ksslsettings.h

It’s nowhere in the OSX/CI system's install root:
---
$ find /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kio/inst/ 
-name ksslsettings.h
$
---


> Within kio, the source file is in src/core/kssl/

And yes, it is indeed in the sources:
---
$ find ~/WC/KDECI-builds/kio/src -name ksslsettings.h
/Users/marko/WC/KDECI-builds/kio/src/core/kssl/ksslsettings.h
---


> 1) check that the file got installed

... but, it’s also not present in the build directory’s local install root 
itself:
---
$ find 
~/WC/KDECI-builds/kio/local-inst/opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kio
 -name ksslsettings.h
$
---


> 2) check which include paths kdelibs4support is using

Well, that’s handled by the CI scripts and should work normally - well, up to 
now it did at least!

Any ideas?

Greets,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

circular dependencies?

[Marko Käning]

Hi,

I just see (on the OSX/CI system) using e.g. 

---
$ cd ~/scripts/dependencies/tools
$ list_dependencies frameworks/kauth
desupport/extra-cmake-modules
Qt5[stable]
frameworks/kcoreaddons
frameworks/kauth
---

that all frameworks depend on themselves.

Is that intended, just an artifact or a bug?

Greets,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65242
---

Ship it!


LOL just when the naming started to make sense, you added mkspecs to it :-)

I can't come up with something better than ECM_INSTALL_QT_STUFF_IN_QT_DIR, so 
I'll stop nitpicking on naming
Anyhow, distros will set it so plugins get installed there, and devs using 
qmake will be happy that mkspecs are following along.

- David Faure


On Aug. 25, 2014, 6 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> ---
> 
> (Updated Aug. 25, 2014, 6 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in 
> ECM.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
>   modules/ECMGeneratePriFile.cmake 34001d6 
>   modules/ECMQueryQmake.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> ---
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

> On Aug. 25, 2014, 10:32 p.m., David Faure wrote:
> > kde-modules/KDEInstallDirs.cmake, line 340
> > 
> >
> > I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what 
> > it's about.
> > 
> > Is this line enough? I thought you had to use option() to make the 
> > option available on the cmake command-line, but maybe I'm missing something.
> 
> Rohan Garg wrote:
> I think ECM_INSTALL_PLUGINS_IN_QT_DIR would be wrong since it's used for 
> both plugins and QtQuick imports.
> 
> David Faure wrote:
> Yeah but as it is now, it sounds like EVERYTHING is going to be installed 
> into the Qt dir :-)
> 
> Calling it ECM_INSTALL_PLUGINS_AND_IMPORTS_IN_QT_DIR would be quite a 
> mouthful.
> 
> In fact, IMHO imports are kind of plugins too. That dir is indeed full of 
> .so plugins... so yeah, I still prefer ECM_INSTALL_PLUGINS_IN_QT_DIR :)

Alright :).


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65234
---


On Aug. 25, 2014, 11:23 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> ---
> 
> (Updated Aug. 25, 2014, 11:23 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in 
> ECM.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
>   modules/ECMGeneratePriFile.cmake 34001d6 
>   modules/ECMQueryQmake.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> ---
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---

(Updated Aug. 25, 2014, 11:23 p.m.)


Review request for Build System and KDE Frameworks.


Changes
---

Also use for the MKSPECS folder


Repository: extra-cmake-modules


Description
---

Use qmake to query dirs for plugins and imports instead of hardcoding them in 
ECM.


Diffs (updated)
-

  kde-modules/KDEInstallDirs.cmake 880539b 
  modules/ECMGeneratePriFile.cmake 34001d6 
  modules/ECMQueryQmake.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119901/diff/


Testing
---

Seems to work on my system.


Thanks,

Rohan Garg

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---

(Updated Aug. 25, 2014, 11:30 p.m.)


Review request for Build System and KDE Frameworks.


Changes
---

Rename to ECM_INSTALL_PLUGINS_IN_QT_DIR


Repository: extra-cmake-modules


Description
---

Use qmake to query dirs for plugins and imports instead of hardcoding them in 
ECM.


Diffs (updated)
-

  kde-modules/KDEInstallDirs.cmake 880539b 
  modules/ECMGeneratePriFile.cmake 34001d6 
  modules/ECMQueryQmake.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119901/diff/


Testing
---

Seems to work on my system.


Thanks,

Rohan Garg

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[David Faure]

> On Aug. 25, 2014, 5:02 p.m., David Faure wrote:
> > kde-modules/KDEInstallDirs.cmake, line 340
> > 
> >
> > I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what 
> > it's about.
> > 
> > Is this line enough? I thought you had to use option() to make the 
> > option available on the cmake command-line, but maybe I'm missing something.
> 
> Rohan Garg wrote:
> I think ECM_INSTALL_PLUGINS_IN_QT_DIR would be wrong since it's used for 
> both plugins and QtQuick imports.

Yeah but as it is now, it sounds like EVERYTHING is going to be installed into 
the Qt dir :-)

Calling it ECM_INSTALL_PLUGINS_AND_IMPORTS_IN_QT_DIR would be quite a mouthful.

In fact, IMHO imports are kind of plugins too. That dir is indeed full of .so 
plugins... so yeah, I still prefer ECM_INSTALL_PLUGINS_IN_QT_DIR :)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65234
---


On Aug. 25, 2014, 5:17 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> ---
> 
> (Updated Aug. 25, 2014, 5:17 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in 
> ECM.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> ---
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---

(Updated Aug. 25, 2014, 10:47 p.m.)


Review request for Build System and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Use qmake to query dirs for plugins and imports instead of hardcoding them in 
ECM.


Diffs (updated)
-

  kde-modules/KDEInstallDirs.cmake 880539b 

Diff: https://git.reviewboard.kde.org/r/119901/diff/


Testing
---

Seems to work on my system.


Thanks,

Rohan Garg

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

> On Aug. 25, 2014, 10:32 p.m., David Faure wrote:
> > kde-modules/KDEInstallDirs.cmake, line 340
> > 
> >
> > I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what 
> > it's about.
> > 
> > Is this line enough? I thought you had to use option() to make the 
> > option available on the cmake command-line, but maybe I'm missing something.

I think ECM_INSTALL_PLUGINS_IN_QT_DIR would be wrong since it's used for both 
plugins and QtQuick imports.


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65234
---


On Aug. 25, 2014, 9:14 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> ---
> 
> (Updated Aug. 25, 2014, 9:14 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in 
> ECM.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> ---
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65234
---



kde-modules/KDEInstallDirs.cmake


I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what it's 
about.

Is this line enough? I thought you had to use option() to make the option 
available on the cmake command-line, but maybe I'm missing something.



kde-modules/KDEInstallDirs.cmake


this bit seems to be the same, with or without the option set. Why not 
extract it out of the if()?
Same thing for QMLDIR.


- David Faure


On Aug. 25, 2014, 3:44 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> ---
> 
> (Updated Aug. 25, 2014, 3:44 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in 
> ECM.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> ---
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: kdelibs4support fails to build

[David Faure]

On Monday 25 August 2014 09:31:39 Marko Käning wrote:
> Building CXX object
> src/CMakeFiles/KF5KDELibs4Support.dir/kssl/ksslutils.cpp.o [ 54%] [ 54%] In
> file included from
> /Users/marko/WC/KDECI-builds/kdelibs4support/src/kssl/kssl.cpp:21:
> /Users/marko/WC/KDECI-builds/kdelibs4support/src/kssl/kssl.h:24:10: fatal
> error: 'ksslsettings.h' file not found

It's installed by KIO, into include/KF5/KIOCore/ksslsettings.h

Within kio, the source file is in src/core/kssl/

1) check that the file got installed
2) check which include paths kdelibs4support is using

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/
---

(Updated Aug. 25, 2014, 9:14 p.m.)


Review request for Build System and KDE Frameworks.


Changes
---

Fix as per suggestions.


Repository: extra-cmake-modules


Description
---

Use qmake to query dirs for plugins and imports instead of hardcoding them in 
ECM.


Diffs (updated)
-

  kde-modules/KDEInstallDirs.cmake 880539b 

Diff: https://git.reviewboard.kde.org/r/119901/diff/


Testing
---

Seems to work on my system.


Thanks,

Rohan Garg

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

[Rohan Garg]

> On Aug. 23, 2014, 1:16 a.m., David Faure wrote:
> > Is this going to lead to "make install" installing plugins into $QTDIR 
> > rather than into $CMAKE_INSTALL_PREFIX? This is a big no-no by default. For 
> > a developer, the path returned by qmake might not even be writable 
> > (/usr/...).
> > 
> > QCA has an option to install into Qt, we could do the same here if you 
> > want, but it should be off by default. Distros can enable it when compiling 
> > packages for /usr.

Ah, yes, I'll fix it so that it doesn't break CMAKE_INSTALL_PREFIX.


- Rohan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65074
---


On Aug. 22, 2014, 6:10 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119901/
> ---
> 
> (Updated Aug. 22, 2014, 6:10 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Use qmake to query dirs for plugins and imports instead of hardcoding them in 
> ECM.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake 880539b 
> 
> Diff: https://git.reviewboard.kde.org/r/119901/diff/
> 
> 
> Testing
> ---
> 
> Seems to work on my system.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119335: Use CMAKE_INSTALL_FULL_LIBEXECDIR

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119335/
---

(Updated Aug. 25, 2014, 1:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcrash


Description
---

resolves the problem of relative vs. absolute LIBEXEC_INSTALL_DIR var usage.


Diffs
-

  src/config-kcrash.h.cmake ca3b86a 
  src/kcrash.cpp 41578d6 

Diff: https://git.reviewboard.kde.org/r/119335/diff/


Testing
---

builds.


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kcmutils_master_qt5 #75

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119563: Ship plasma_workspace.notifyrc with frameworkintegration

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119563/
---

(Updated Aug. 25, 2014, 7:38 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Harald Sitter.


Repository: frameworkintegration


Description
---

Add plasma_workspace.notifyrc to be installed with frameworkintegration. This 
file contains basic notification events and has preconfigured sounds for those, 
with this for example KMessageBox plays a sound etc. It's what used to be 
kde.notifyrc in KDE4 world.

I put it in frameworkintegration as it seems to be the best place for it, the 
default sounds etc. are a workspace integration after all, but plasma-workspace 
is too high in the stack.


Diffs
-

  CMakeLists.txt af3cce8 
  plasma_workspace.notifyrc PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119563/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

OSX/CI: kdelibs4support fails to build

[Marko Käning]

Building CXX object src/CMakeFiles/KF5KDELibs4Support.dir/kssl/ksslutils.cpp.o
[ 54%] [ 54%] In file included from 
/Users/marko/WC/KDECI-builds/kdelibs4support/src/kssl/kssl.cpp:21:
/Users/marko/WC/KDECI-builds/kdelibs4support/src/kssl/kssl.h:24:10: fatal 
error: 'ksslsettings.h' file not found

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel