Re: Qt DevDays is coming; do we want to print up some Frameworks Cookbooks to give to attendees?

[Valorie Zimmerman]

Hi Brian, we did generate a PDF & epub of an early version, but if you
want to see the chapters now, you'll need to clone the git repo and
read it from there.

If there is enough interest, I'm sure Mirko would generate the PDF &
ePub files right now, although I think the README tells you how to do
this for yourself.

There is not enough to publish until we get some more content. I get
that everyone is coding like mad right now, but we are swiftly running
out of time to print before Qt DevDays.

Valorie


On Fri, Oct 3, 2014 at 6:14 AM, Brian Duffy  wrote:
> Why does that url not provide a copy of the book? Is it not ready for
> viewing at all?
>
> On Thu, Oct 2, 2014 at 12:28 PM, Jeremy Whiting  wrote:
>>
>> Valorie,
>>
>> I'm a bit confused. books.kde.org says the book is hosted at
>> flossmanuals, but that url takes me to the oldish "KDE Dev Guide" is
>> thi Frameworks Cookbook a different thing than that old book, right?
>> Is the current wip book available somewhere ? I guess if so we should
>> point that link at it (and also turn the epub, pdf etc. text below the
>> cover there into links) If not what's needed to make it from the git
>> repo? I saw one or so tasks on the kanboard about generating a book,
>> is that to generate the epub/pdf/html from the git repo? or to print
>> the actual hard copy once we have the epub/pdf/html ?
>>
>> thanks,
>> Jeremy
>>
>> On Wed, Oct 1, 2014 at 11:43 PM, Valorie Zimmerman
>>  wrote:
>> > https://www.qtdeveloperdays.com/europe says that Qt DevDays happens
>> > October 6 – 8, at the Berlin Congress Centre in Berlin.
>> >
>> > If we want to print up some books to give away, we need some more
>> > chapters.
>> >
>> > See https://books.kde.org for more details.
>> >
>> > Valorie
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

i18n in frameworks/kio

[Burkhard Lück]

Hi,

frameworks/kio has five translation catalogs:

1) kurifilter with 46 msgs
2) kshorturifilter with 3 msgs
3) kio_trash with 18 msgs
4) kcm_webshortcuts with 2 msgs
5) kio5 with 1066 msgs

The msgs from 1-4 are in catalog 5 as well.

That should be fixed, either by fixing Messages.sh for kio5 (excluding messages 
for catalogs 1-4) or by using one single catalog for frameworks/kio

Btw where is the code to load catalog 2) ?

-- 
Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120267/#review67874
---


no vacations, rather extremely busy, with DevDays preparations :)

I saw this patch, but the hardcoded "dummy" looks strange, where does that 
service name even come from? I don't see any instance of it in kio/src/core nor 
kservice...
There must be a better way of doing this...

- David Faure


On Sept. 18, 2014, 4:33 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120267/
> ---
> 
> (Updated Sept. 18, 2014, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 339123
> https://bugs.kde.org/show_bug.cgi?id=339123
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Only add the actual command and url's otherwise we keep spawning instances of 
> kioexec.
> Maybe we should rename the kioexec service from 'dummy' to 'kioexec-dummy' 
> just to be safe.
> 
> 
> Diffs
> -
> 
>   src/core/desktopexecparser.cpp 9510697 
> 
> Diff: https://git.reviewboard.kde.org/r/120267/diff/
> 
> 
> Testing
> ---
> 
> Run kioexec with local file from command line.
> Remote files don't work (before and after) I'll take a look at that next.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #108

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #822

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kservice_master_qt5 #188

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kpty_master_qt5 #56

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #821

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #820

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #819

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #818

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

[Maarten De Meyer]

> On Oct. 3, 2014, 11:32 a.m., Elias Probst wrote:
> > This patch fixes the issue for me, but I can't really say much about the 
> > quality of the patch -- needs someone with some more domain-specific 
> > knowledge to give you a "ship it".

No problem. I think dfaure is on vacation. Or busy :)
Anyway this I still have to update the unit test for this.
Thanks for taking a look.


- Maarten


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120267/#review67855
---


On Sept. 18, 2014, 4:33 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120267/
> ---
> 
> (Updated Sept. 18, 2014, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 339123
> https://bugs.kde.org/show_bug.cgi?id=339123
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Only add the actual command and url's otherwise we keep spawning instances of 
> kioexec.
> Maybe we should rename the kioexec service from 'dummy' to 'kioexec-dummy' 
> just to be safe.
> 
> 
> Diffs
> -
> 
>   src/core/desktopexecparser.cpp 9510697 
> 
> Diff: https://git.reviewboard.kde.org/r/120267/diff/
> 
> 
> Testing
> ---
> 
> Run kioexec with local file from command line.
> Remote files don't work (before and after) I'll take a look at that next.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kcoreaddons_master_qt5 #145

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120479: Add full C++ KDE Frameworks template

[Simon Wächter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120479/#review67863
---

Ship it!


Thanks for the new template. The patch looks good to me, only a few small 
issues :)


templates/C++/kde-frameworks5/icons/CMakeLists.txt


As bshah said, ecm_install_icons has some new required parameters: In the 
end it looks like ecm_install_icons(ICONS ${var_with_icons} DESTINATION 
${ICON_INSTALL_DIR} THEME hicolor)



templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp


Clang is complaining about the same variable and class name (Build error)



templates/C++/kde-frameworks5/src/main.cpp


There is a missing KAboutData::setApplicationData(aboutData);. That means, 
the about dialog will not show the application/author information (Help --> 
About Simple App)


- Simon Wächter


On Oct. 3, 2014, 4:27 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120479/
> ---
> 
> (Updated Oct. 3, 2014, 4:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Simon Wächter.
> 
> 
> Repository: kapptemplate
> 
> 
> Description
> ---
> 
> Port KDE 4 template to KDE Frameworks
> also fix docs compile
> 
> sample generated app: http://starsky.19inch.net/~jr/tmp/jonathan.tar.gz
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 02df39d6cc0065d1ea95cf236cf4089a40ad6299 
>   templates/C++/kde-frameworks5/kde-frameworks5.png PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAMELC}.desktop PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAMELC}.h PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAMELC}ViewBase.ui PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAMELC}ui.rc PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAMELC}view.h PRE-CREATION 
>   templates/C++/kde-frameworks5/CMakeLists.txt PRE-CREATION 
>   templates/C++/kde-frameworks5/COPYING PRE-CREATION 
>   templates/C++/kde-frameworks5/COPYING.DOC PRE-CREATION 
>   templates/C++/kde-frameworks5/Messages.sh PRE-CREATION 
>   templates/C++/kde-frameworks5/README PRE-CREATION 
>   templates/C++/kde-frameworks5/doc/CMakeLists.txt PRE-CREATION 
>   templates/C++/kde-frameworks5/doc/index.docbook PRE-CREATION 
>   templates/C++/kde-frameworks5/icons/CMakeLists.txt PRE-CREATION 
>   templates/C++/kde-frameworks5/icons/hi16-apps-%{APPNAMELC}.png PRE-CREATION 
>   templates/C++/kde-frameworks5/icons/hi22-apps-%{APPNAMELC}.png PRE-CREATION 
>   templates/C++/kde-frameworks5/icons/hi32-apps-%{APPNAMELC}.png PRE-CREATION 
>   templates/C++/kde-frameworks5/icons/hi48-apps-%{APPNAMELC}.png PRE-CREATION 
>   templates/C++/kde-frameworks5/icons/hisc-apps-%{APPNAMELC}.svgz 
> PRE-CREATION 
>   templates/C++/kde-frameworks5/kde-frameworks5.kdevtemplate PRE-CREATION 
>   doc/index.docbook b3edf623aeac322e4775028a5d7502d80dff7327 
>   templates/C++/CMakeLists.txt 6f31aa3cc7a68748c82965b525c0f7eb7b956652 
>   templates/C++/kde-frameworks5/src/settingsBase.ui PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAMELC}view.cpp PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfg PRE-CREATION 
>   templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfgc PRE-CREATION 
>   templates/C++/kde-frameworks5/src/CMakeLists.txt PRE-CREATION 
>   templates/C++/kde-frameworks5/src/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120479/diff/
> 
> 
> Testing
> ---
> 
> run kapp template, exported, compiled and installed a sample app
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kcoreaddons_master_qt5 #144

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/
---

(Updated Oct. 3, 2014, 3:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
checking ~/.kde then ~/.kde4.
but in Plasma5 we need to be really sure where ~/.kde is since some settings 
are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
create it from kf5, that's why the kdehome() method)
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
configs in user homes is very possible)

this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
_KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
distributions to make this right.
on the other hand if the user changes distribution at the moment of the 
migration between kde4 and plasma5 this may break.


Diffs
-

  src/lib/util/kdelibs4migration.cpp e1ec678 
  src/lib/CMakeLists.txt 5ae5c08 
  src/lib/util/config-kde4home.h.cmake PRE-CREATION 
  src/lib/util/kdelibs4migration.h c26addc 

Diff: https://git.reviewboard.kde.org/r/120480/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/
---

(Updated Oct. 3, 2014, 3:37 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
checking ~/.kde then ~/.kde4.
but in Plasma5 we need to be really sure where ~/.kde is since some settings 
are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
create it from kf5, that's why the kdehome() method)
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
configs in user homes is very possible)

this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
_KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
distributions to make this right.
on the other hand if the user changes distribution at the moment of the 
migration between kde4 and plasma5 this may break.


Diffs (updated)
-

  src/lib/util/kdelibs4migration.cpp e1ec678 
  src/lib/CMakeLists.txt 5ae5c08 
  src/lib/util/config-kde4home.h.cmake PRE-CREATION 
  src/lib/util/kdelibs4migration.h c26addc 

Diff: https://git.reviewboard.kde.org/r/120480/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/#review67864
---

Ship it!


Ship It!

- David Edmundson


On Oct. 3, 2014, 3:34 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120480/
> ---
> 
> (Updated Oct. 3, 2014, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
> checking ~/.kde then ~/.kde4.
> but in Plasma5 we need to be really sure where ~/.kde is since some settings 
> are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
> create it from kf5, that's why the kdehome() method)
> also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
> uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
> configs in user homes is very possible)
> 
> this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
> _KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
> distributions to make this right.
> on the other hand if the user changes distribution at the moment of the 
> migration between kde4 and plasma5 this may break.
> 
> 
> Diffs
> -
> 
>   src/lib/util/config-kde4home.h.cmake PRE-CREATION 
>   src/lib/util/kdelibs4migration.cpp e1ec678 
>   src/lib/CMakeLists.txt 5ae5c08 
> 
> Diff: https://git.reviewboard.kde.org/r/120480/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/
---

(Updated Oct. 3, 2014, 3:34 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
checking ~/.kde then ~/.kde4.
but in Plasma5 we need to be really sure where ~/.kde is since some settings 
are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
create it from kf5, that's why the kdehome() method)
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
configs in user homes is very possible)

this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
_KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
distributions to make this right.
on the other hand if the user changes distribution at the moment of the 
migration between kde4 and plasma5 this may break.


Diffs (updated)
-

  src/lib/util/config-kde4home.h.cmake PRE-CREATION 
  src/lib/util/kdelibs4migration.cpp e1ec678 
  src/lib/CMakeLists.txt 5ae5c08 

Diff: https://git.reviewboard.kde.org/r/120480/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/
---

(Updated Oct. 3, 2014, 3:32 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
checking ~/.kde then ~/.kde4.
but in Plasma5 we need to be really sure where ~/.kde is since some settings 
are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
create it from kf5, that's why the kdehome() method)
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
configs in user homes is very possible)

this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
_KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
distributions to make this right.
on the other hand if the user changes distribution at the moment of the 
migration between kde4 and plasma5 this may break.


Diffs (updated)
-

  src/lib/util/config-kde4home.h.cmake PRE-CREATION 
  src/lib/util/kdelibs4migration.cpp e1ec678 
  src/lib/CMakeLists.txt 5ae5c08 

Diff: https://git.reviewboard.kde.org/r/120480/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/
---

(Updated Oct. 3, 2014, 3:16 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
checking ~/.kde then ~/.kde4.
but in Plasma5 we need to be really sure where ~/.kde is since some settings 
are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
create it from kf5, that's why the kdehome() method)
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
configs in user homes is very possible)

this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
_KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
distributions to make this right.
on the other hand if the user changes distribution at the moment of the 
migration between kde4 and plasma5 this may break.


Diffs (updated)
-

  src/lib/util/kdelibs4migration.cpp e1ec678 
  src/lib/CMakeLists.txt 5ae5c08 
  src/lib/util/config-kde4home.h.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120480/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/
---

(Updated Oct. 3, 2014, 3:12 p.m.)


Review request for KDE Frameworks.


Changes
---

use the hardcoded one just as fallback


Repository: kcoreaddons


Description
---

Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
checking ~/.kde then ~/.kde4.
but in Plasma5 we need to be really sure where ~/.kde is since some settings 
are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
create it from kf5, that's why the kdehome() method)
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
configs in user homes is very possible)

this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
_KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
distributions to make this right.
on the other hand if the user changes distribution at the moment of the 
migration between kde4 and plasma5 this may break.


Diffs (updated)
-

  src/lib/CMakeLists.txt 5ae5c08 
  src/lib/util/kdelibs4migration.h c26addc 
  src/lib/util/kdelibs4migration.cpp e1ec678 

Diff: https://git.reviewboard.kde.org/r/120480/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120480: decide at build time where the home of KDE4 is

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/#review67860
---


util/config-kde4home.h.cmake 


missing git add ?


src/lib/util/kdelibs4migration.h


we don't need this for teh kde4 breeze script.

As long as we give kconfig a valid full path it will make the subfolders.

It was only needed because saveLocation previously returned an empty string 
as kdeHome was unset.


- David Edmundson


On Oct. 3, 2014, 3:01 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120480/
> ---
> 
> (Updated Oct. 3, 2014, 3:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
> checking ~/.kde then ~/.kde4.
> but in Plasma5 we need to be really sure where ~/.kde is since some settings 
> are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
> create it from kf5, that's why the kdehome() method)
> also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
> uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
> configs in user homes is very possible)
> 
> this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
> _KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
> distributions to make this right.
> on the other hand if the user changes distribution at the moment of the 
> migration between kde4 and plasma5 this may break.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt 5ae5c08 
>   src/lib/util/kdelibs4migration.h c26addc 
>   src/lib/util/kdelibs4migration.cpp e1ec678 
> 
> Diff: https://git.reviewboard.kde.org/r/120480/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120480: decide at build time where the home of KDE4 is

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120480/
---

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Kdelibs4Migration used some heuristic to decide where ~/.kde4 was, was simply 
checking ~/.kde then ~/.kde4.
but in Plasma5 we need to be really sure where ~/.kde is since some settings 
are kept in sync even at srtartup (where ~/.kde doesn't exist, and we have to 
create it from kf5, that's why the kdehome() method)
also, checking for ~/.kde and ~/.kde4 may break in cases where a distribution 
uses ~/.kde4 for kde4, and used to have ~/.kde for kde3 (remnants of kde3 
configs in user homes is very possible)

this adds a cmake option _KDE4_DEFAULT_HOME_POSTFIX coherent with 
_KDE_DEFAULT_HOME_POSTFIX of kdelibs4. so it would be responsibility of 
distributions to make this right.
on the other hand if the user changes distribution at the moment of the 
migration between kde4 and plasma5 this may break.


Diffs
-

  src/lib/CMakeLists.txt 5ae5c08 
  src/lib/util/kdelibs4migration.h c26addc 
  src/lib/util/kdelibs4migration.cpp e1ec678 

Diff: https://git.reviewboard.kde.org/r/120480/diff/


Testing
---


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120479: Add full C++ KDE Frameworks template

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120479/
---

(Updated Oct. 3, 2014, 2:27 p.m.)


Review request for KDE Frameworks and Simon Wächter.


Repository: kapptemplate


Description (updated)
---

Port KDE 4 template to KDE Frameworks
also fix docs compile

sample generated app: http://starsky.19inch.net/~jr/tmp/jonathan.tar.gz


Diffs
-

  CMakeLists.txt 02df39d6cc0065d1ea95cf236cf4089a40ad6299 
  templates/C++/kde-frameworks5/kde-frameworks5.png PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}.desktop PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}.h PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}ViewBase.ui PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}ui.rc PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}view.h PRE-CREATION 
  templates/C++/kde-frameworks5/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/COPYING PRE-CREATION 
  templates/C++/kde-frameworks5/COPYING.DOC PRE-CREATION 
  templates/C++/kde-frameworks5/Messages.sh PRE-CREATION 
  templates/C++/kde-frameworks5/README PRE-CREATION 
  templates/C++/kde-frameworks5/doc/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/doc/index.docbook PRE-CREATION 
  templates/C++/kde-frameworks5/icons/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi16-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi22-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi32-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi48-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hisc-apps-%{APPNAMELC}.svgz PRE-CREATION 
  templates/C++/kde-frameworks5/kde-frameworks5.kdevtemplate PRE-CREATION 
  doc/index.docbook b3edf623aeac322e4775028a5d7502d80dff7327 
  templates/C++/CMakeLists.txt 6f31aa3cc7a68748c82965b525c0f7eb7b956652 
  templates/C++/kde-frameworks5/src/settingsBase.ui PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}view.cpp PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfg PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfgc PRE-CREATION 
  templates/C++/kde-frameworks5/src/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/src/main.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120479/diff/


Testing
---

run kapp template, exported, compiled and installed a sample app


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120479: Add full C++ KDE Frameworks template

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120479/
---

Review request for KDE Frameworks and Simon Wächter.


Repository: kapptemplate


Description
---

Port KDE 4 template to KDE Frameworks
also fix docs compile


Diffs
-

  CMakeLists.txt 02df39d6cc0065d1ea95cf236cf4089a40ad6299 
  templates/C++/kde-frameworks5/kde-frameworks5.png PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}.cpp PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}.desktop PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}.h PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}ViewBase.ui PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}ui.rc PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}view.h PRE-CREATION 
  templates/C++/kde-frameworks5/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/COPYING PRE-CREATION 
  templates/C++/kde-frameworks5/COPYING.DOC PRE-CREATION 
  templates/C++/kde-frameworks5/Messages.sh PRE-CREATION 
  templates/C++/kde-frameworks5/README PRE-CREATION 
  templates/C++/kde-frameworks5/doc/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/doc/index.docbook PRE-CREATION 
  templates/C++/kde-frameworks5/icons/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi16-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi22-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi32-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hi48-apps-%{APPNAMELC}.png PRE-CREATION 
  templates/C++/kde-frameworks5/icons/hisc-apps-%{APPNAMELC}.svgz PRE-CREATION 
  templates/C++/kde-frameworks5/kde-frameworks5.kdevtemplate PRE-CREATION 
  doc/index.docbook b3edf623aeac322e4775028a5d7502d80dff7327 
  templates/C++/CMakeLists.txt 6f31aa3cc7a68748c82965b525c0f7eb7b956652 
  templates/C++/kde-frameworks5/src/settingsBase.ui PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAMELC}view.cpp PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfg PRE-CREATION 
  templates/C++/kde-frameworks5/src/%{APPNAME}Settings.kcfgc PRE-CREATION 
  templates/C++/kde-frameworks5/src/CMakeLists.txt PRE-CREATION 
  templates/C++/kde-frameworks5/src/main.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120479/diff/


Testing
---

run kapp template, exported, compiled and installed a sample app


Thanks,

Jonathan Riddell

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt DevDays is coming; do we want to print up some Frameworks Cookbooks to give to attendees?

[Brian Duffy]

Why does that url not provide a copy of the book? Is it not ready for
viewing at all?

On Thu, Oct 2, 2014 at 12:28 PM, Jeremy Whiting  wrote:

> Valorie,
>
> I'm a bit confused. books.kde.org says the book is hosted at
> flossmanuals, but that url takes me to the oldish "KDE Dev Guide" is
> thi Frameworks Cookbook a different thing than that old book, right?
> Is the current wip book available somewhere ? I guess if so we should
> point that link at it (and also turn the epub, pdf etc. text below the
> cover there into links) If not what's needed to make it from the git
> repo? I saw one or so tasks on the kanboard about generating a book,
> is that to generate the epub/pdf/html from the git repo? or to print
> the actual hard copy once we have the epub/pdf/html ?
>
> thanks,
> Jeremy
>
> On Wed, Oct 1, 2014 at 11:43 PM, Valorie Zimmerman
>  wrote:
> > https://www.qtdeveloperdays.com/europe says that Qt DevDays happens
> > October 6 – 8, at the Berlin Congress Centre in Berlin.
> >
> > If we want to print up some books to give away, we need some more
> chapters.
> >
> > See https://books.kde.org for more details.
> >
> > Valorie
> >
> > --
> > http://about.me/valoriez
> > ___
> > Kde-frameworks-devel mailing list
> > Kde-frameworks-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>



-- 
Duff
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: desktoptojson man page

[Burkhard Lück]

Am Freitag, 3. Oktober 2014, 12:22:03 schrieb Alex Merry:
> On 2014-09-16 09:55, Sune Vuorela wrote:
> > On 2014-09-15, Alexander Richardson  wrote:
> >> However, is this even possible? Building manpages seems to require
> >> KDocTools
> >> and kcoreaddons is a tier1 framework which would make this impossible.
> >> Do we really need a manpage for it? It seems to me that it is only
> >> used in cmake code
> > 
> > Or rewrite the man page in troff directly.
> 
> What about translations? Do we translate man pages?
> 
Sure, see 
http://websvn.kde.org/trunk/l10n-kf5/templates/docmessages/frameworks/

— 
Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #817

[KDE CI System]

See 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kio_trash

[Alex Merry]

On 2014-09-22 21:26, David Faure wrote:

On Saturday 13 September 2014 20:29:18 Luigi Toscano wrote:

Luigi Toscano ha scritto:
> Nicolás Alvarez ha scritto:
>> 2014-09-13 15:13 GMT-03:00 Nicolás Alvarez :
>>> Done. The resulting history looks kind of weird though, because we
>>> have the full history of kio_trash but only partial history of kio, if
>>> you didn't graft kdelibs in.
>>
>> In fact, half the commits in kio are now from kio_trash. I didn't push
>> yet. I wonder if we should do the graft thing instead...


Strange, I didn't think there were that many commits to kio_trash.

Indeed, 618 commits - but just 388 after removing scripty.
Most of them qt3->qt4 and qt4->qt5 porting ;)


> It was already done for kdoctools (where you can see two parents). I would
> say it makes sense to import just the post-split commits, as you are
> grafting kdelibs anyway for kio history.

... but kio_trash comes from kde-runtime. Well, double grafting is 
possible

and maybe easier than full import anyway.


I'm fine with grafting, although I guess git-qt-grafts won't work since 
it
only looks at the very first commit in the repo? So I guess this will 
require
manual grafting - which in my case means "cd 
4/kde/kde-runtime/kioslave/trash"

will just be faster anyway.
I still have some kde3 svn modules checked out, so I'll be keeping kde4 
git

modules around for a very long time I'm sure :-)


git-qt-grafts works just fine with multiple graft points. Remember that 
in git, there can be multiple "very first commits".


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

[Elias Probst]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120267/#review67855
---


This patch fixes the issue for me, but I can't really say much about the 
quality of the patch -- needs someone with some more domain-specific knowledge 
to give you a "ship it".

- Elias Probst


On Sept. 18, 2014, 4:33 p.m., Maarten De Meyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120267/
> ---
> 
> (Updated Sept. 18, 2014, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 339123
> https://bugs.kde.org/show_bug.cgi?id=339123
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Only add the actual command and url's otherwise we keep spawning instances of 
> kioexec.
> Maybe we should rename the kioexec service from 'dummy' to 'kioexec-dummy' 
> just to be safe.
> 
> 
> Diffs
> -
> 
>   src/core/desktopexecparser.cpp 9510697 
> 
> Diff: https://git.reviewboard.kde.org/r/120267/diff/
> 
> 
> Testing
> ---
> 
> Run kioexec with local file from command line.
> Remote files don't work (before and after) I'll take a look at that next.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: baloo fails to compile

[Alex Merry]

On 2014-09-28 18:04, Andriy Rysin wrote:

I cleaned all build and install files but baloo refuses to compile in
master:

-- Found Gettext: /usr/bin/msgmerge (found version "0.18.3")
-- Found PythonInterp: /usr/bin/python (found version "2.7.5")
-- Found KF5I18n:
/home/kde5dev/kde5/install/lib64/cmake/KF5I18n/KF5I18nConfig.cmake
(found version "5.3.0")
-- Found KF5Config:
/home/kde5dev/kde5/install/lib64/cmake/KF5Config/KF5ConfigConfig.cmake
(found version "5.3.0")
-- Found KF5IdleTime:
/home/kde5dev/kde5/install/lib64/cmake/KF5IdleTime/KF5IdleTimeConfig.cmake
(found version "5.3.0")
-- Found KF5KCMUtils:
/home/kde5dev/kde5/install/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake
(found version "5.3.0")
-- Found KF5Auth:
/home/kde5dev/kde5/install/lib64/cmake/KF5Auth/KF5AuthConfig.cmake
(found version "5.3.0")
-- Found KF5Crash:
/home/kde5dev/kde5/install/lib64/cmake/KF5Crash/KF5CrashConfig.cmake
(found version "5.3.0")
-- Found KF5Solid:
/home/kde5dev/kde5/install/lib64/cmake/KF5Solid/KF5SolidConfig.cmake
(found version "5.3.0")
-- Found KF5KIO:
/home/kde5dev/kde5/install/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found
version "5.3.0")
-- Found KF5KDELibs4Support:
/home/kde5dev/kde5/install/lib64/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake
(found version "5.3.0")
-- Found KF5: success (found suitable version "5.3.0", minimum required
is "5.0.0") found components:  I18n Config IdleTime KCMUtils Auth Crash
Solid KIO KDELib
s4Support
-- Found KF5FileMetaData:
/home/kde5dev/kde5/install/lib64/cmake/KF5FileMetaData/KF5FileMetaDataConfig.cmake
(found version "5.0.95")
-- Found KF5: success (found suitable version "5.0.95", minimum 
required

is "5.0.95") found components:  FileMetaData
CMake Warning at CMakeLists.txt:40 (find_package):
  Could not find a package configuration file provided by "KF5Akonadi" 
with

  any of the following names:

KF5AkonadiConfig.cmake
kf5akonadi-config.cmake


Although akonadi itself seems to be happy:


# kdesrc-build running: 'gmake' 'install/fast'
# from directory: /home/kde5dev/kde5/build/kdesupport/akonadi
Install the project...
-- Install configuration: "debug"
-- Up-to-date:
/home/kde5dev/kde5/install/share/mime/packages/akonadi-mime.xml
-- Updating MIME database at /home/kde5dev/kde5/install/share/mime
-- Up-to-date:
/home/kde5dev/kde5/install/lib64/cmake/KF5AkonadiServer/KF5AkonadiServerConfig.cmake
-- Up-to-date:
/home/kde5dev/kde5/install/lib64/cmake/KF5AkonadiServer/KF5AkonadiServerConfigVersion.cmake
-- Up-to-date:
/home/kde5dev/kde5/install/lib64/cmake/KF5AkonadiServer/KF5AkonadiServerTargets.cmake
-- Up-to-date:
/home/kde5dev/kde5/install/lib64/cmake/KF5AkonadiServer/KF5AkonadiServerTargets-debug.cmake


Baloo is searching for KF5Akonadi, and you've installed 
KF5AkonadiServer. I'm not sure what's going on here, as I'm a bit out of 
the loop. Is Akonadi even a framework? If not, why is it using a KF5 
prefix?


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: desktoptojson man page

[Alex Merry]

On 2014-09-16 09:55, Sune Vuorela wrote:

On 2014-09-15, Alexander Richardson  wrote:
However, is this even possible? Building manpages seems to require 
KDocTools

and kcoreaddons is a tier1 framework which would make this impossible.
Do we really need a manpage for it? It seems to me that it is only
used in cmake code


Or rewrite the man page in troff directly.


What about translations? Do we translate man pages?

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Move of kglobalacceld from plasma-workspace to kglobalaccel framework

[Alex Merry]

On 2014-09-17 10:47, Martin Gräßlin wrote:

Hi all,

I just prepared moving kglobalacceld from plasma-workspace into 
kglobalaccel.
You can find the code in my personal clone of kglobalaccel at [1] in 
branch

master.

The following steps were performed so far:
* filter-branch on plasma-workspace to just have all kglobalacceld 
commits

* move all files to src/runtime
* merge code in kglobalaccel
* adjust CMakeLists to find additionally needed dependencies for 
runtime part

* raise tier to 3 in metadata

Please have a look at it, whether I have forgotten something or should 
do

something differently.


Git history looks sensible.


Things I'm unsure about is:
* how does the raise of framework needs to be reflected in cmake


It doesn't.


* how do one expose the different licences?


A License section in README.md?

* is it needed to export the new dependencies? After all they are just 
runtime

deps?


No, because they are not needed at compile-time by software that uses 
KGlobalAccel.


Do we want an option to disable compilation of the runtime? Is the 
runtime needed on all platforms? I seem to remember some discussion 
suggesting it either wasn't or needn't be, but I can't remember the 
details.


Alex

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Problem with kdeinit and StartupInfo

[Alex Merry]

On 2014-09-11 10:46, Christoph Cullmann wrote:

Hi,

for Kate, the startup info doesn't work atm in frameworks.

If you launch dolphin KF5 version and open one file => fine,
second file => dolphin blocks and startup info doesn't happen.

If you look at the logs, you see:

 (1975)/(default) KXMessages::broadcastMessageX: KXMessages used on
non-X11 platform! This is an application bug.

Which is on my machine the kdeinit5 process that can't use KXMessages
as the guard
there seems not to work (there is a isX11() check).

Might it be, that this check in QX11Info needs a application instance
which is not there in the kdeinit5 process?


Note that KDBusService has a known limitation where it just doesn't work 
with startup notifications in unique mode - the necessary information is 
never passed to the main application by the secondary instance.


I don't know if this is the cause of the issue, but it might be related.

Alex

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120435: Declare InheritanceChecker before actual use

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120435/#review67853
---

Ship it!


Ship It!

- David Edmundson


On Sept. 30, 2014, 11:36 a.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120435/
> ---
> 
> (Updated Sept. 30, 2014, 11:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Ben Cooksley.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Declare InheritanceChecker before actual use
> 
> This is actually not needed for "proper" compilers, because the use is inside 
> a template,
> The type is only required at instantiation time.
> 
> However, this patch makes the Coverity build tool happy. Without this patch,
> we get an error for every translation unit including
> kpluginfactory.h, telling us that "InheritanceChecker is not a
> template"
> 
> Also see https://communities.coverity.com/thread/2903
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178 
> 
> Diff: https://git.reviewboard.kde.org/r/120435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120435: Declare InheritanceChecker before actual use

[Kevin Funk]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120435/#review67849
---


Bump. This is a super trivial patch. :)

- Kevin Funk


On Sept. 30, 2014, 11:36 a.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120435/
> ---
> 
> (Updated Sept. 30, 2014, 11:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Ben Cooksley.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Declare InheritanceChecker before actual use
> 
> This is actually not needed for "proper" compilers, because the use is inside 
> a template,
> The type is only required at instantiation time.
> 
> However, this patch makes the Coverity build tool happy. Without this patch,
> we get an error for every translation unit including
> kpluginfactory.h, telling us that "InheritanceChecker is not a
> template"
> 
> Also see https://communities.coverity.com/thread/2903
> 
> 
> Diffs
> -
> 
>   src/lib/plugin/kpluginfactory.h 70ffade3e071b839245b9b0d6468f7b804478178 
> 
> Diff: https://git.reviewboard.kde.org/r/120435/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt DevDays is coming; do we want to print up some Frameworks Cookbooks to give to attendees?

[Valorie Zimmerman]

On Thu, Oct 2, 2014 at 9:28 AM, Jeremy Whiting  wrote:
> Valorie,
>
> I'm a bit confused. books.kde.org says the book is hosted at
> flossmanuals, but that url takes me to the oldish "KDE Dev Guide" is
> thi Frameworks Cookbook a different thing than that old book, right?
> Is the current wip book available somewhere ? I guess if so we should
> point that link at it (and also turn the epub, pdf etc. text below the
> cover there into links) If not what's needed to make it from the git
> repo? I saw one or so tasks on the kanboard about generating a book,
> is that to generate the epub/pdf/html from the git repo? or to print
> the actual hard copy once we have the epub/pdf/html ?
>
> thanks,
> Jeremy
>
> On Wed, Oct 1, 2014 at 11:43 PM, Valorie Zimmerman
>  wrote:
>> https://www.qtdeveloperdays.com/europe says that Qt DevDays happens
>> October 6 – 8, at the Berlin Congress Centre in Berlin.
>>
>> If we want to print up some books to give away, we need some more chapters.
>>
>> See https://books.kde.org for more details.
>>
>> Valorie

Yes, the older book is at the top. We eventually would like to get
that book into git as well, so that all devels can easily fix as
needed.

Scroll down for the new book, the Frameworks Cookbook.

Valorie
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel