Re: Review Request 120794: Implement Unique Mode Properly in Rekonq
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69131 --- Ship it! Everything works as described! Many thanks David, your work here is really appreciated :) - Andrea Diamantini On Oct. 25, 2014, 5:26 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/ --- (Updated Oct. 25, 2014, 5:26 a.m.) Review request for KDE Frameworks and rekonq. Repository: rekonq Description --- This is my humble attempt to implement the Unique Mode properly. I have been trying to do this for the longest time in a way that avoids code duplication but I can't find a way to jump over all the hurdles these API impose. I tried learning from other ports from KUniqueApplication but a quick look at LXR shows there are plenty of applications that blindly ported to Unique Mode but didn't bother implementing activateRequested and the one I found that did was plasmawindowedcorona.cpp which does not need a QCommandLineParser, so the code duplication is less evident. At this point, I would like someone who knows about the QCommandLineParser + KDBusAddons dance to look at this and tell if it is reasonable or not. The current patch just makes it possible to open several Rekonq applications. It does not do the right thing when a Rekonq window is already open in the current activity and a user clicks a link elsewhere (step 4 in the Testing Done section) because it starts a brand new Rekonq window, but that's a different patch. It also does some funky thing asking you if you want to restore the previous session when nothing has crashed, I have to check that. Diffs - src/application.h 7ccd60d src/application.cpp c7c297d src/main.cpp 7592f7a Diff: https://git.reviewboard.kde.org/r/120794/diff/ Testing --- 1. Open one Rekonq window 2. Try opening Rekonq again 3. Try opeining Rekonq from a command line with some URLs 4. Assuming Reknoq is your default browser (why wouldn't it be?) click on a link somewhere (I click on the links at the title of the Konversation channels I am in) Before this patch, nothing happens in steps 2 - 4. After a first version of this patch that does not avoid the QCommandLine parser if the argument list is not empty, the window opened at 1 crashes because the activateRequested signal passes an empty list of arguments - not even the binary name - so QCommandLine parser dies. With this patch, every step opens a new window properly. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kdelibs4support_master_qt5 #291
See http://build.kde.org/job/kdelibs4support_master_qt5/291/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 506 lines...] Generating moc_ksharedptrtest.cpp Automatic moc for target ktemporaryfiletest Automatic moc for target ktimezonestest [ 10%] Built target ksharedptrtest_automoc Generating moc_kstandarddirstest.cpp Scanning dependencies of target kuniqueapptest_automoc [ 10%] [ 10%] Built target kstandarddirstest_automoc Scanning dependencies of target kurlmimetest_automoc Automatic moc for target kuniqueapptest [ 11%] Automatic moc for target kurlmimetest Scanning dependencies of target kurltest_automoc [ 11%] Automatic moc for target kurltest Generating moc_ktemporaryfiletest.cpp Generating kmd5benchmark.moc [ 11%] [ 11%] Built target ktemporaryfiletest_automoc Built target kmd5benchmark_automoc Generating moc_ktimezonestest.cpp [ 11%] Scanning dependencies of target naturalcomparetest_automoc Generating moc_kurlmimetest.cpp Built target ktimezonestest_automoc [ 11%] [ 12%] Built target kurlmimetest_automoc Scanning dependencies of target kcmdlineargstest_automoc Automatic moc for target naturalcomparetest [ 13%] Scanning dependencies of target kdatetimewidgettest_automoc Automatic moc for target kcmdlineargstest [ 14%] Scanning dependencies of target kcolordlgtest_automoc Automatic moc for target kdatetimewidgettest [ 14%] Automatic moc for target kcolordlgtest Generating moc_kurltest.cpp [ 14%] [ 14%] [ 14%] Built target kcmdlineargstest_automoc Built target kurltest_automoc Built target kdatetimewidgettest_automoc Scanning dependencies of target kdatewidgettest_automoc [ 14%] Scanning dependencies of target kdebugtest_gui_automoc Built target kcolordlgtest_automoc [ 14%] Scanning dependencies of target kdialogbuttonboxtest_automoc Automatic moc for target kdatewidgettest Generating kuniqueapptest.moc [ 15%] [ 15%] [ 15%] Automatic moc for target kdebugtest_gui Scanning dependencies of target kdialogtest_automoc Built target kuniqueapptest_automoc Automatic moc for target kdialogbuttonboxtest [ 16%] Scanning dependencies of target kdirselectdialogtest_automoc [ 16%] Automatic moc for target kdialogtest [ 16%] [ 16%] Built target kdatewidgettest_automoc Built target kdebugtest_gui_automoc [ 16%] Automatic moc for target kdirselectdialogtest Generating ktabwidget_unittest.moc Built target kdialogbuttonboxtest_automoc [ 16%] [ 16%] Scanning dependencies of target keditlistboxtest_automoc Built target ktabwidget_unittest_automoc Scanning dependencies of target kfiledialogtest_automoc Built target kdialogtest_automoc [ 16%] [ 16%] [ 16%] Scanning dependencies of target kfiletreeviewtest_automoc Generating ktempdirtest.moc Built target kdirselectdialogtest_automoc Scanning dependencies of target kfontdialogtest_automoc Automatic moc for target keditlistboxtest [ 16%] [ 16%] Scanning dependencies of target kfstest_automoc Automatic moc for target kfiledialogtest [ 16%] Built target ktempdirtest_automoc Automatic moc for target kfiletreeviewtest Scanning dependencies of target khboxtest_automoc [ 16%] Automatic moc for target kfontdialogtest Automatic moc for target kfstest [ 16%] Scanning dependencies of target kinputdialogtest_automoc [ 16%] [ 16%] Built target kfiledialogtest_automoc Automatic moc for target khboxtest [ 16%] Built target keditlistboxtest_automoc [ 16%] Built target kfontdialogtest_automoc Automatic moc for target kinputdialogtest Scanning dependencies of target kmdcodectest_automoc Scanning dependencies of target kiopassdlgtest_automoc Scanning dependencies of target kmessageboxqueuedtest_automoc [ 16%] [ 16%] [ 16%] Automatic moc for target kmdcodectest Automatic moc for target kiopassdlgtest Automatic moc for target kmessageboxqueuedtest Generating naturalcomparetest.moc [ 16%] [ 16%] Built target naturalcomparetest_automoc Built target kinputdialogtest_automoc [ 16%] [ 16%] Scanning dependencies of target kmessagetest_automoc Built target kmdcodectest_automoc Built target kiopassdlgtest_automoc Scanning dependencies of target kmfitest_automoc [ 17%] Scanning dependencies of target knuminputtest_automoc [ 17%] Scanning dependencies of target kprintpreview_test_automoc [ 17%] Automatic moc for target kmfitest [ 17%] Generating moc_kfstest.cpp Automatic moc for target kmessagetest [ 17%] Automatic moc for target kprintpreview_test Built target kfstest_automoc Automatic moc for target knuminputtest Scanning dependencies of target kprogressdialogtest_automoc Generating moc_kfiletreeviewtest.cpp [ 17%] [ 17%] Generating moc_khboxtest.cpp Built target kfiletreeviewtest_automoc Built target kmfitest_automoc [ 18%] [ 18%] Built target khboxtest_automoc Automatic moc for target kprogressdialogtest [ 18%] Scanning dependencies of target kshortcuttest_automoc Scanning dependencies of target kscantest_automoc Built target kprintpreview_test_automoc [ 18%] Scanning dependencies of target kstatusbartest_automoc [ 18%]
Build failed in Jenkins: kio_master_qt5 #406
See http://build.kde.org/job/kio_master_qt5/406/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 906 lines...] Generating moc_udsentrytest.cpp [ 12%] Scanning dependencies of target httpheaderdispositiontest_automoc [ 12%] Built target threadtest_automoc [ 12%] Built target udsentrytest_automoc Scanning dependencies of target httpheadertokenizetest_automoc Automatic moc for target httpheaderdispositiontest Generating upurltest.moc Scanning dependencies of target httpobjecttest_automoc [ 12%] [ 12%] Built target upurltest_automoc [ 12%] Automatic moc for target httpheadertokenizetest Automatic moc for target httpobjecttest Scanning dependencies of target kcookiejartest_automoc [ 12%] Automatic moc for target kcookiejartest Generating moc_httpauthenticationtest.cpp [ 12%] Built target httpauthenticationtest_automoc Generating moc_httpheadertokenizetest.cpp [ 12%] Built target httpheadertokenizetest_automoc Generating moc_httpheaderdispositiontest.cpp Scanning dependencies of target kdirlistertest_gui_automoc [ 12%] Scanning dependencies of target getalltest_automoc [ 12%] Built target httpheaderdispositiontest_automoc [ 12%] Automatic moc for target kdirlistertest_gui Automatic moc for target getalltest Scanning dependencies of target kdirmodeltest_gui_automoc [ 13%] [ 13%] Automatic moc for target kdirmodeltest_gui Built target getalltest_automoc Generating httpfiltertest.moc Generating moc_httpfilter.cpp [ 13%] Built target httpfiltertest_automoc Scanning dependencies of target kencodingfiledialogtest_gui_automoc [ 13%] Automatic moc for target kencodingfiledialogtest_gui Scanning dependencies of target kionetrctest_automoc Generating kcookiejartest.moc [ 13%] [ 13%] Built target kcookiejartest_automoc [ 13%] Built target kencodingfiledialogtest_gui_automoc Automatic moc for target kionetrctest Scanning dependencies of target kioslavetest_automoc Scanning dependencies of target kmountpoint_debug_automoc Generating moc_kdirlistertest_gui.cpp [ 13%] [ 13%] [ 14%] Built target kdirlistertest_gui_automoc Automatic moc for target kioslavetest Automatic moc for target kmountpoint_debug Scanning dependencies of target kopenwithtest_automoc [ 14%] [ 14%] [ 14%] Built target kionetrctest_automoc Built target kmountpoint_debug_automoc Automatic moc for target kopenwithtest Scanning dependencies of target kpropertiesdialogtest_automoc Scanning dependencies of target kruntest_automoc [ 14%] [ 14%] Automatic moc for target kruntest Automatic moc for target kpropertiesdialogtest Generating moc_httpfilter.cpp Generating moc_httpobjecttest.cpp Generating moc_http.cpp [ 14%] [ 14%] Built target kopenwithtest_automoc Built target httpobjecttest_automoc Generating kdirmodeltest_gui.moc [ 14%] [ 14%] Built target kpropertiesdialogtest_automoc Built target kdirmodeltest_gui_automoc Scanning dependencies of target ksycocaupdatetest_automoc Scanning dependencies of target kurlrequestertest_gui_automoc Scanning dependencies of target listjobtest_automoc [ 14%] Scanning dependencies of target listrecursivetest_automoc [ 15%] Automatic moc for target ksycocaupdatetest [ 15%] Automatic moc for target kurlrequestertest_gui [ 16%] Automatic moc for target listrecursivetest Automatic moc for target listjobtest [ 16%] [ 16%] Built target ksycocaupdatetest_automoc Built target kurlrequestertest_gui_automoc Scanning dependencies of target previewtest_automoc Scanning dependencies of target udsentrybenchmark_automoc [ 16%] Automatic moc for target previewtest [ 16%] Generating moc_kioslavetest.cpp [ 16%] Generating moc_kruntest.cpp Automatic moc for target udsentrybenchmark Built target kioslavetest_automoc [ 16%] Built target kruntest_automoc [ 17%] Generating org.kde.KCookieServer.xml Scanning dependencies of target KF5KIONTLM [ 17%] Generating listjobtest.moc [ 18%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h [ 18%] Built target listjobtest_automoc Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.o Generating listrecursivetest.moc [ 18%] [ 18%] Built target listrecursivetest_automoc [ 18%] Generating kcookieserverinterface.moc Generating kcookieserveradaptor.cpp, kcookieserveradaptor.h [ 18%] Generating kcookieserveradaptor.moc Generating moc_previewtest.cpp [ 18%] Built target previewtest_automoc Scanning dependencies of target kmailservice5 [ 18%] Building CXX object src/ioslaves/mailto/CMakeFiles/kmailservice5.dir/kmailservice.cpp.o Scanning dependencies of target kcookiejar5 [ 18%] Generating udsentrybenchmark.moc Building CXX object src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/kcookieserverinterface.cpp.o Scanning dependencies of target ktelnetservice5 [ 18%] [ 18%] http://build.kde.org/job/kio_master_qt5/ws/src/kntlm/kntlm.cpp:33:21: fatal error: krandom.h: No such file or directory #include krandom.h ^ compilation terminated. Built target udsentrybenchmark_automoc [ 18%]
Build failed in Jenkins: kinfocenter_master_qt5 #71
See http://build.kde.org/job/kinfocenter_master_qt5/71/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 143 lines...] -- Found KF5KCMUtils: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kcmutils/inst/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version 5.4.0) -- Found KF5KDELibs4Support: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/lib64/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake (found version 5.3.0) -- Found KF5KIO: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kio/inst/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version 5.3.0) -- Found KF5Plasma: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version 5.3.0) -- Found KF5Service: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version 5.3.0) -- Found KF5Solid: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/solid/inst/lib64/cmake/KF5Solid/KF5SolidConfig.cmake (found version 5.4.0) -- Found KF5WidgetsAddons: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwidgetsaddons/inst/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version 5.4.0) -- Found KF5XmlGui: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kxmlgui/inst/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version 5.4.0) -- Found KF5: success (found version 5.3.0) found components: Completion Config ConfigWidgets CoreAddons DBusAddons DocTools I18n IconThemes KCMUtils KDELibs4Support KIO Plasma Service Solid WidgetsAddons XmlGui -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found OpenGL: /usr/lib64/libGL.so -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found EGL: /usr/lib64/libEGL.so (found version 1.4) CMake Warning (dev) at Modules/devinfo/CMakeLists.txt:1 (project): Policy CMP0048 is not set: project() command manages VERSION variables. Run cmake --help-policy CMP0048 for policy details. Use the cmake_policy command to set the policy and suppress this warning. The following variable(s) would be set to empty: PROJECT_VERSION This warning is for project developers. Use -Wno-dev to suppress it. -- Looking for include file devinfo.h -- Looking for include file devinfo.h - not found -- Looking for include file sys/sockio.h -- Looking for include file sys/sockio.h - not found -- Looking for getnameinfo -- Looking for getnameinfo - found -- Performing Test HAVE_STRUCT_SOCKADDR_SA_LEN -- Performing Test HAVE_STRUCT_SOCKADDR_SA_LEN - Failed -- Looking for getifaddrs -- Looking for getifaddrs - found -- Found PCIUTILS: /usr/lib64/libpci.so;/usr/lib64/libresolv.so -- Enabling PCI module based on pciutils library -- Found RAW1394: /usr/lib64/libraw1394.so -- -- The following features have been enabled: * KF5Wayland , Required for Wayland Compositor Information Module * OpenGL support , View OpenGL details in kinfocenter. * OpenGL Utility Library (GLU) , Required for OpenGL details in kinfocenter. -- The following OPTIONAL packages have been found: * OpenGL , The OpenGL libraries , http://www.opengl.org * PkgConfig * EGL , A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG. , https://www.khronos.org/egl/ Required for OpenGL Information Module * KF5Wayland , Required for Wayland Compositor Information Module * X11 , X11 libraries , http://www.x.org Required for building the X11 based workspace * PCIUTILS , PciUtils is a library for direct access to PCI slots , http://atrey.karlin.mff.cuni.cz/~mj/pciutils.shtml View PCI details in kinfocenter. * RAW1394 , library for direct access to IEEE 1394 bus , http://www.linux1394.org/ View FireWire devices in kinfocenter. -- The following REQUIRED packages have been found: * Qt5Core * Qt5Gui * Qt5Widgets * Qt5 (required version = 5.3.0) * KF5Completion * KF5Config * KF5ConfigWidgets * KF5CoreAddons * KF5DBusAddons * KF5DocTools * Gettext * PythonInterp * KF5I18n * KF5IconThemes * KF5KCMUtils * KF5KDELibs4Support * KF5KIO * ECM (required version = 0.0.9) * KF5Plasma * KF5Service * KF5Solid * KF5WidgetsAddons * KF5XmlGui * KF5 -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project:
Build failed in Jenkins: ktexteditor_master_qt5 #714
See http://build.kde.org/job/ktexteditor_master_qt5/714/changes Changes: [dhaumann] cleanup editing stack commit -- [...truncated 158 lines...] ' Using the old result for compatibility since the policy is not set. Call Stack (most recent call first): src/CMakeLists.txt:299 (ecm_generate_pri_file) This warning is for project developers. Use -Wno-dev to suppress it. -- Found Perl: /usr/bin/perl (found version 5.16.2) -- Looking for fdatasync -- Looking for fdatasync - found -- -- The following OPTIONAL packages have been found: * PkgConfig * LibGit2 (required version = 0.20.0) , A plain C library to interface with the git version control system. , https://libgit2.github.com/ -- The following REQUIRED packages have been found: * ECM (required version = 1.3.0) * Qt5Core * Qt5Gui (required version = 5.3.1) * Qt5Widgets * Qt5Script * Qt5PrintSupport * Qt5Xml * Qt5Network (required version = 5.3.1) * Qt5XmlPatterns * KF5Archive (required version = 5.3.0) * KF5Config (required version = 5.3.0) * KF5GuiAddons (required version = 5.3.0) * Gettext * PythonInterp * KF5I18n (required version = 5.3.0) * KF5KIO (required version = 5.3.0) * KF5Parts (required version = 5.3.0) * KF5Sonnet (required version = 5.3.0) * Perl * Qt5Test * Qt5 (required version = 5.2.0) -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/ktexteditor_master_qt5/ws/build == Commencing the Build Scanning dependencies of target GeneratePhpXmlFiles Scanning dependencies of target katehighlightingindexer_automoc Scanning dependencies of target KF5TextEditor_automoc Scanning dependencies of target katepart_automoc Scanning dependencies of target bug286887_automoc Scanning dependencies of target bug313759_automoc [ 0%] [ 0%] [ 0%] [ 0%] Scanning dependencies of target bug317111_automoc Scanning dependencies of target bug313769_automoc Scanning dependencies of target commands_test_automoc [ 0%] [ 1%] Automatic moc for target KF5TextEditor [ 2%] [ 2%] Generating css-php.xml Generating katepart.json Automatic moc for target katehighlightingindexer [ 3%] Automatic moc for target bug286887 Automatic moc for target bug313759 Automatic moc for target bug317111 Automatic moc for target bug313769 Automatic moc for target commands_test [ 4%] Generating html-php.xml [ 4%] Generating javascript-php.xml Generating moc_bug286887.cpp [ 4%] [ 4%] [ 4%] Built target GeneratePhpXmlFiles Built target bug286887_automoc Built target katehighlightingindexer_automoc Scanning dependencies of target completion_test_automoc Scanning dependencies of target katedocument_test_automoc Scanning dependencies of target indenttest_automoc [ 4%] [ 4%] [ 4%] Automatic moc for target indenttest Automatic moc for target katedocument_test Automatic moc for target completion_test Generating moc_bug313769.cpp [ 4%] Built target bug313769_automoc Scanning dependencies of target kateencodingtest_automoc [ 4%] Automatic moc for target kateencodingtest Generated http://build.kde.org/job/ktexteditor_master_qt5/ws/build/src/part/katepart.json [ 4%] Built target kateencodingtest_automoc Scanning dependencies of target katefoldingtest_automoc [ 4%] Automatic moc for target katefoldingtest [ 4%] Automatic moc for target katepart Generating moc_katefoldingtest.cpp [ 4%] Built target katefoldingtest_automoc Scanning dependencies of target katesyntaxtest_automoc [ 5%] Generating moc_indenttest.cpp Generating moc_script_test_base.cpp Generating moc_testutils.cpp Automatic moc for target katesyntaxtest [ 5%] Generating moc_bug317111.cpp Generating moc_testutils.cpp Built target indenttest_automoc [ 5%] Built target bug317111_automoc Scanning dependencies of target katetextbuffertest_automoc Generating moc_commands_test.cpp Generating moc_script_test_base.cpp Generating moc_testutils.cpp Generating moc_bug313759.cpp Generating moc_testutils.cpp [ 6%] Scanning dependencies of target kateview_test_automoc [ 6%] [ 6%] Automatic moc for target katetextbuffertest Built target commands_test_automoc Built target bug313759_automoc [ 7%] Automatic moc for target kateview_test Scanning dependencies of target katewildcardmatcher_test_automoc Scanning dependencies of target kte_documentcursor_automoc [ 8%] [ 9%] Automatic moc for target katewildcardmatcher_test Automatic moc for target kte_documentcursor [ 9%] Built target katewildcardmatcher_test_automoc Scanning dependencies of target messagetest_automoc [ 10%] Generating moc_katesyntaxtest.cpp Automatic moc for target messagetest [ 10%] Built target katesyntaxtest_automoc Scanning dependencies of target modificationsystem_test_automoc Generating moc_kateview_test.cpp [ 11%] [ 11%] Built target kateview_test_automoc Automatic moc for target modificationsystem_test
Build failed in Jenkins: ktexteditor_master_qt5 #715
See http://build.kde.org/job/ktexteditor_master_qt5/715/changes Changes: [dhaumann] fix warning under MSVC2013 -- [...truncated 123 lines...] QT.@PRI_TARGET_BASENAME@.PATCH_VERSION = @PROJECT_VERSION_PATCH@ QT.@PRI_TARGET_BASENAME@.name = @PRI_TARGET_LIBNAME@ QT.@PRI_TARGET_BASENAME@.defines = @PRI_TARGET_DEFINES@ QT.@PRI_TARGET_BASENAME@.includes = @PRI_TARGET_INCLUDES@ QT.@PRI_TARGET_BASENAME@.private_includes = QT.@PRI_TARGET_BASENAME@.libs = @PRI_TARGET_LIBS@ QT.@PRI_TARGET_BASENAME@.depends = @PRI_TARGET_QTDEPS@ ' the old evaluation rules produce: 'QT.KTextEditor.VERSION = 5.4.0 QT.KTextEditor.MAJOR_VERSION = 5 QT.KTextEditor.MINOR_VERSION = 4 QT.KTextEditor.PATCH_VERSION = 0 QT.KTextEditor.name = KF5TextEditor QT.KTextEditor.defines = QT.KTextEditor.includes = /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/ktexteditor/inst/include/KF5/KTextEditor QT.KTextEditor.private_includes = QT.KTextEditor.libs = /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/ktexteditor/inst/lib64 QT.KTextEditor.depends = KParts ' but the new evaluation rules produce: 'QT.@PRI_TARGET_BASENAME@.VERSION = @PROJECT_VERSION_STRING@ QT.@PRI_TARGET_BASENAME@.MAJOR_VERSION = @PROJECT_VERSION_MAJOR@ QT.@PRI_TARGET_BASENAME@.MINOR_VERSION = @PROJECT_VERSION_MINOR@ QT.@PRI_TARGET_BASENAME@.PATCH_VERSION = @PROJECT_VERSION_PATCH@ QT.@PRI_TARGET_BASENAME@.name = @PRI_TARGET_LIBNAME@ QT.@PRI_TARGET_BASENAME@.defines = @PRI_TARGET_DEFINES@ QT.@PRI_TARGET_BASENAME@.includes = @PRI_TARGET_INCLUDES@ QT.@PRI_TARGET_BASENAME@.private_includes = QT.@PRI_TARGET_BASENAME@.libs = @PRI_TARGET_LIBS@ QT.@PRI_TARGET_BASENAME@.depends = @PRI_TARGET_QTDEPS@ ' Using the old result for compatibility since the policy is not set. Call Stack (most recent call first): src/CMakeLists.txt:299 (ecm_generate_pri_file) This warning is for project developers. Use -Wno-dev to suppress it. -- Found Perl: /usr/bin/perl (found version 5.16.2) -- Looking for fdatasync -- Looking for fdatasync - found -- -- The following OPTIONAL packages have been found: * PkgConfig * LibGit2 (required version = 0.20.0) , A plain C library to interface with the git version control system. , https://libgit2.github.com/ -- The following REQUIRED packages have been found: * ECM (required version = 1.3.0) * Qt5Core * Qt5Gui (required version = 5.3.1) * Qt5Widgets * Qt5Script * Qt5PrintSupport * Qt5Xml * Qt5Network (required version = 5.3.1) * Qt5XmlPatterns * KF5Archive (required version = 5.3.0) * KF5Config (required version = 5.3.0) * KF5GuiAddons (required version = 5.3.0) * Gettext * PythonInterp * KF5I18n (required version = 5.3.0) * KF5KIO (required version = 5.3.0) * KF5Parts (required version = 5.3.0) * KF5Sonnet (required version = 5.3.0) * Perl * Qt5Test * Qt5 (required version = 5.2.0) -- Configuring done -- Generating done CMake Warning: Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build files have been written to: http://build.kde.org/job/ktexteditor_master_qt5/ws/build == Commencing the Build Scanning dependencies of target KF5TextEditor_automoc Scanning dependencies of target GeneratePhpXmlFiles Scanning dependencies of target bug286887_automoc Scanning dependencies of target bug313759_automoc Scanning dependencies of target katepart_automoc Scanning dependencies of target bug313769_automoc Scanning dependencies of target katehighlightingindexer_automoc [ 0%] [ 0%] Scanning dependencies of target bug317111_automoc [ 0%] [ 0%] [ 1%] [ 2%] Scanning dependencies of target commands_test_automoc Generating css-php.xml Automatic moc for target bug313759 Automatic moc for target bug286887 [ 2%] Automatic moc for target bug313769 Generating katepart.json [ 2%] Automatic moc for target KF5TextEditor [ 3%] Automatic moc for target katehighlightingindexer Automatic moc for target commands_test Automatic moc for target bug317111 Generated http://build.kde.org/job/ktexteditor_master_qt5/ws/build/src/part/katepart.json [ 3%] Automatic moc for target katepart [ 3%] [ 4%] Built target katehighlightingindexer_automoc Scanning dependencies of target completion_test_automoc Generating html-php.xml [ 4%] Automatic moc for target completion_test [ 4%] Generating javascript-php.xml Generating moc_bug313769.cpp Generating moc_bug286887.cpp [ 4%] [ 4%] [ 4%] Built target GeneratePhpXmlFiles Built target bug313769_automoc Built target bug286887_automoc Scanning dependencies of target indenttest_automoc Scanning dependencies of target katedocument_test_automoc [ 4%] Scanning dependencies of target kateencodingtest_automoc Automatic moc for target indenttest [ 4%] Automatic moc for target katedocument_test [ 4%] Automatic moc for target kateencodingtest Generating
Re: Split kde-baseapps?
On Fri, Oct 10, 2014 at 5:07 PM, David Faure fa...@kde.org wrote: On Thursday 25 September 2014 01:01:27 Aleix Pol wrote: - kioslave/about: I guess it should go either to kioslave-extras or konqueror itself. I guess it's here because the applications use it, so kioslave. It's only used by Konqueror. It's also used by Rekonq and anything building a web browser using KDE software, it should really go to kioslave-extras. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: khtml_master_qt5 #143
See http://build.kde.org/job/khtml_master_qt5/143/changes Changes: [aiacovitti] Do not allow uri in css format where it is not allowed and clean up from parseURL() use. [aiacovitti] Remove surrounding spaces from href value, as per spec. [aiacovitti] Fix url comparison. -- [...truncated 104 lines...] -- Performing Test _OFFT_IS_64BIT -- Performing Test _OFFT_IS_64BIT - Success -- Found Gettext: /usr/bin/msgmerge (found version 0.18.1) -- Found PythonInterp: /usr/bin/python (found version 2.7.3) -- Found Perl: /usr/bin/perl (found version 5.16.2) -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/lib64/libX11.so -- Found JPEG: /usr/lib64/libjpeg.so -- Performing Test GIF_GifFileType_UserData -- Performing Test GIF_GifFileType_UserData - Success -- Found GIF: /usr/lib64/libgif.so (found version 4) -- Found ZLIB: /usr/lib64/libz.so (found version 1.2.7) -- Found PNG: /usr/lib64/libpng.so (found version 1.5.13) -- Found OpenSSL: /usr/lib64/libssl.so;/usr/lib64/libcrypto.so (found version 1.0.1i) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success CMake Warning (dev) at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/kdesupport/extra-cmake-modules/inst/share/ECM/modules/ECMGeneratePriFile.cmake:156 (file): Policy CMP0053 is not set: Simplify variable reference and escape sequence evaluation. Run cmake --help-policy CMP0053 for policy details. Use the cmake_policy command to set the policy and suppress this warning. For input: 'QT.@PRI_TARGET_BASENAME@.VERSION = @PROJECT_VERSION_STRING@ QT.@PRI_TARGET_BASENAME@.MAJOR_VERSION = @PROJECT_VERSION_MAJOR@ QT.@PRI_TARGET_BASENAME@.MINOR_VERSION = @PROJECT_VERSION_MINOR@ QT.@PRI_TARGET_BASENAME@.PATCH_VERSION = @PROJECT_VERSION_PATCH@ QT.@PRI_TARGET_BASENAME@.name = @PRI_TARGET_LIBNAME@ QT.@PRI_TARGET_BASENAME@.defines = @PRI_TARGET_DEFINES@ QT.@PRI_TARGET_BASENAME@.includes = @PRI_TARGET_INCLUDES@ QT.@PRI_TARGET_BASENAME@.private_includes = QT.@PRI_TARGET_BASENAME@.libs = @PRI_TARGET_LIBS@ QT.@PRI_TARGET_BASENAME@.depends = @PRI_TARGET_QTDEPS@ ' the old evaluation rules produce: 'QT.KHtml.VERSION = 5.4.0 QT.KHtml.MAJOR_VERSION = 5 QT.KHtml.MINOR_VERSION = 4 QT.KHtml.PATCH_VERSION = 0 QT.KHtml.name = KF5KHtml QT.KHtml.defines = QT.KHtml.includes = /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/khtml/inst/include/KF5/KHtml QT.KHtml.private_includes = QT.KHtml.libs = /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/khtml/inst/lib64 QT.KHtml.depends = gui KIOCore KJS KI18n KParts ' but the new evaluation rules produce: 'QT.@PRI_TARGET_BASENAME@.VERSION = @PROJECT_VERSION_STRING@ QT.@PRI_TARGET_BASENAME@.MAJOR_VERSION = @PROJECT_VERSION_MAJOR@ QT.@PRI_TARGET_BASENAME@.MINOR_VERSION = @PROJECT_VERSION_MINOR@ QT.@PRI_TARGET_BASENAME@.PATCH_VERSION = @PROJECT_VERSION_PATCH@ QT.@PRI_TARGET_BASENAME@.name = @PRI_TARGET_LIBNAME@ QT.@PRI_TARGET_BASENAME@.defines = @PRI_TARGET_DEFINES@ QT.@PRI_TARGET_BASENAME@.includes = @PRI_TARGET_INCLUDES@ QT.@PRI_TARGET_BASENAME@.private_includes = QT.@PRI_TARGET_BASENAME@.libs = @PRI_TARGET_LIBS@ QT.@PRI_TARGET_BASENAME@.depends = @PRI_TARGET_QTDEPS@ ' Using the old result for compatibility since the policy is not set. Call Stack (most recent call first): src/CMakeLists.txt:799 (ecm_generate_pri_file) This warning is for project developers. Use -Wno-dev to suppress it. -- -- The following OPTIONAL packages have been found: * X11 * ZLIB -- The following RECOMMENDED packages have been found: * OpenSSL , Support for secure network communications (SSL and TLS) , http://openssl.org KDE uses OpenSSL for the bulk of secure communications, including secure web browsing via HTTPS -- The following REQUIRED packages have been found: * ECM (required version = 1.3.0) * Qt5Core (required version = 5.3.1) * Qt5Gui (required version = 5.3.1) * Qt5Widgets * Qt5Network * Qt5DBus * Qt5PrintSupport * Qt5Xml * KF5Archive (required version = 5.3.0) * KF5Codecs (required version = 5.3.0) * KF5GlobalAccel (required version = 5.3.0) * Gettext * PythonInterp * KF5I18n (required version = 5.3.0)
