Re: libnm-qt - a new KF5 framework for Tier 1?
On Thursday 20 of November 2014 17:08 David Edmundson wrote: I'm not a fan of the propertiesChanged() method making it into the public API which we see in most classes, it's very much an implementation detail for QDBusAbstractInterface being rubbish. Should we move it to private classes? I would. Or make each subclass connect to the interface propertyChanged signal itself and not have the propagation. Done, I moved all propertiesChanged() slots to private classes. See https://git.reviewboard.kde.org/r/121304/ Anything else? Jan -- Jan Grulich Red Hat Czech, s.r.o jgrul...@redhat.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- (Updated Dec. 2, 2014, 1:16 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and David Faure. Repository: kio Description --- KDesktopFileActions::run did not accept the optional argument QByteArray asn which meant that any application startup id passed to KRun got dropped at this point when launching a desktop file. This change ensures that an ASN is passed along. This way we can properly pass around the application which launched the process and the timestamp which triggered the launch (otherwise klauncher needs a roundtrip to the X-Server to fetch the latest timestamp). Diffs - src/widgets/kdesktopfileactions.h 7b96ff079c752436aebd0b134b930171ea088f48 src/widgets/kdesktopfileactions.cpp 0cbeb00f0c0344b5b204f0d18b7c269da6c99e7f src/widgets/krun.cpp c623b583716e492622e0d1d1c9cec485c6bcf163 Diff: https://git.reviewboard.kde.org/r/121233/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : frameworkintegration_stable_qt5 #3
See http://build.kde.org/job/frameworkintegration_stable_qt5/3/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext - HTML conversion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- (Updated Dec. 2, 2014, 5:57 p.m.) Review request for KDE Frameworks and Michael Pyne. Repository: kcoreaddons Description (updated) --- This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class takes plaintext string, and converts it to HTML while perserving spacing, converting URLs and email addresses into a href... links and interpreting highligting markup (*bold*, _underline_, /italic/) and wrapping it to corresponding HTML tags. It can also convert text emoticons into img smileys. The last - emoticons conversion - depends on KEmoticons, which we can't use directly from KCoreAddons, so I moved the actual KEmoticons code into KEmoticonsIntegration plugin in KEmoticons. There is a dummy implementation provided by default in KCoreAddons that is loaded when the KEmoticonsIntegration plugin is not available, or when the application is only a QCoreApplication (since KEmoticons require QGuiApplication, so we must not load the plugin). The dummy implementation does nothing and returns the original string unaltered. The reason for moving the class from KPimUtils is that KPimUtils is going to die, and while we could make this internal to KDE PIM, I think this is a rather useful code, that can be used by many applications that need to deal with 3rd party text data and want to provide user-friendly clickable links. If you compare this with the original KPimUtils::LinkLocator you find, that I removed all public API except for the convertToHTML method. This is because the remaining methods (getUrl, getEmailAddress) depend on the actual state of the LinkLocator object, but LinkLocator provides no API for step-by-step parsing, so they were actually useless for public use. For that reason I decided to only publish the convertToHTML method, and hide the remaining methods as internal methods of the KTextToHTMLHelper (useful for unit-testing). This patch also contains a unit-test from KPimUtils. Diffs - autotests/CMakeLists.txt d5a5feb autotests/ktexttohtmltest.h PRE-CREATION autotests/ktexttohtmltest.cpp PRE-CREATION src/lib/CMakeLists.txt 3e055a5 src/lib/CMakeLists.txt.orig PRE-CREATION src/lib/text/.ktexttohtml.cpp.kate-swp PRE-CREATION src/lib/text/ktexttohtml.h PRE-CREATION src/lib/text/ktexttohtml.cpp PRE-CREATION src/lib/text/ktexttohtml_p.h PRE-CREATION src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121094/diff/ Testing --- Unit test passes Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kio_master_qt5 #443
See http://build.kde.org/job/kio_master_qt5/443/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kio_stable_qt5 #7
See http://build.kde.org/job/kio_stable_qt5/7/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: krunner_master_qt5 #108
See http://build.kde.org/job/krunner_master_qt5/108/changes Changes: [scripty] Upgrade ECM and KF5 version requirements for 5.5.0 release. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/krunner_master_qt5/ws/ Running Prebuild steps [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson7395994223900441219.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/krunner d790740..aeb495b master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at d790740 Move private stuff out of a private folder Removing build/ Removing dotdata/ Removing local-inst/ Success build forhudson.tasks.Shell@2d86eed9 git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url git://anongit.kde.org/krunner # timeout=10 Fetching upstream changes from git://anongit.kde.org/krunner git --version # timeout=10 git fetch --tags --progress git://anongit.kde.org/krunner +refs/heads/*:refs/remotes/origin/* git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10 git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10 git rev-parse refs/heads/jenkins^{commit} # timeout=10 Checking out Revision aeb495b8721775e6dca1bca52e4be7c2690b6cbc (refs/heads/jenkins) git config core.sparsecheckout # timeout=10 git checkout -f aeb495b8721775e6dca1bca52e4be7c2690b6cbc git rev-list d790740dababe4b4d2c2046b4c7df4f068afdaae # timeout=10 git tag -a -f -m Jenkins Build #108 jenkins-krunner_master_qt5-108 # timeout=10 Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson7883674115492349370.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: krunner - Branch master == Build Dependencies: kross - Branch master cmake - Branch master kactivities - Branch master knotifications - Branch master kbookmarks - Branch master kconfig - Branch master threadweaver - Branch master kservice - Branch master ki18n - Branch master kwidgetsaddons - Branch master libgit2 - Branch master kconfigwidgets - Branch master qt5 - Branch stable kjs - Branch master attica - Branch master kdeclarative - Branch master kdnssd - Branch master kcodecs - Branch master kxmlgui - Branch master kitemmodels - Branch master plasma-framework - Branch master polkit-qt-1 - Branch master kitemviews - Branch master kio - Branch master kcompletion - Branch master kiconthemes - Branch master kparts - Branch master solid - Branch master kwindowsystem - Branch master sonnet - Branch master extra-cmake-modules - Branch master kunitconversion - Branch master kcoreaddons - Branch master kauth - Branch master dogtail - Branch master kcrash - Branch master karchive - Branch master phonon - Branch master kjobwidgets - Branch master kglobalaccel - Branch master kcmutils - Branch master ktexteditor - Branch master kdbusaddons - Branch master ktextwidgets - Branch master kdoctools - Branch master kwallet - Branch master kidletime - Branch master kguiaddons - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for __GLIBC__ -- Looking for __GLIBC__ - found -- Performing Test _OFFT_IS_64BIT -- Performing Test _OFFT_IS_64BIT - Success -- Found Gettext: /usr/bin/msgmerge (found version 0.18.1) -- Found PythonInterp: /usr/bin/python (found version 2.7.3) CMake Error at CMakeLists.txt:37 (find_package): Could not find a configuration file for package KF5Plasma that is compatible with requested version 5.5.0. The following configuration files were considered but not accepted:
Build failed in Jenkins: krunner_stable_qt5 #4
See http://build.kde.org/job/krunner_stable_qt5/4/changes Changes: [me] Add a simple cli tool to run a query on all runners [me] Move private stuff out of a private folder [scripty] Upgrade ECM and KF5 version requirements for 5.5.0 release. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/krunner_stable_qt5/ws/ Running Prebuild steps [krunner_stable_qt5] $ /bin/sh -xe /tmp/hudson3982973511843528912.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/krunner a2d6951..aeb495b master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at a2d6951 SVN_SILENT made messages (.desktop file) Removing build/ Removing dotdata/ Removing local-inst/ Success build forhudson.tasks.Shell@3b5f4e6 git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url git://anongit.kde.org/krunner # timeout=10 Fetching upstream changes from git://anongit.kde.org/krunner git --version # timeout=10 git fetch --tags --progress git://anongit.kde.org/krunner +refs/heads/*:refs/remotes/origin/* git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10 git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10 git rev-parse refs/heads/jenkins^{commit} # timeout=10 Checking out Revision aeb495b8721775e6dca1bca52e4be7c2690b6cbc (refs/heads/jenkins) git config core.sparsecheckout # timeout=10 git checkout -f aeb495b8721775e6dca1bca52e4be7c2690b6cbc git rev-list a2d6951930e0eb5de9e9946733d9ce12be452f75 # timeout=10 git tag -a -f -m Jenkins Build #4 jenkins-krunner_stable_qt5-4 # timeout=10 Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [krunner_stable_qt5] $ /bin/sh -xe /tmp/hudson6729283477295370438.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: krunner - Branch master == Build Dependencies: kcrash - Branch master knotifications - Branch master kbookmarks - Branch master kconfig - Branch master kactivities - Branch master threadweaver - Branch master kservice - Branch master kwallet - Branch master ki18n - Branch master kconfigwidgets - Branch master qt5 - Branch stable attica - Branch master kcodecs - Branch master ktexteditor - Branch master kxmlgui - Branch master kdeclarative - Branch master kitemmodels - Branch master kjs - Branch master kiconthemes - Branch master kauth - Branch master kitemviews - Branch master kdbusaddons - Branch master kcompletion - Branch master kparts - Branch master solid - Branch master kross - Branch master kwindowsystem - Branch master sonnet - Branch master extra-cmake-modules - Branch master kunitconversion - Branch master kwidgetsaddons - Branch master polkit-qt-1 - Branch master plasma-framework - Branch master kdnssd - Branch master kdoctools - Branch master kidletime - Branch master phonon - Branch master cmake - Branch master kcoreaddons - Branch master kjobwidgets - Branch master kglobalaccel - Branch master karchive - Branch master dogtail - Branch master kio - Branch master ktextwidgets - Branch master kcmutils - Branch master libgit2 - Branch master kguiaddons - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for __GLIBC__ -- Looking for __GLIBC__ - found -- Performing Test _OFFT_IS_64BIT -- Performing Test _OFFT_IS_64BIT - Success -- Found Gettext: /usr/bin/msgmerge (found version 0.18.1) -- Found PythonInterp: /usr/bin/python (found version 2.7.3) CMake Error at CMakeLists.txt:37 (find_package): Could not find a configuration file for package KF5Plasma that is compatible with requested version 5.5.0. The following configuration
Jenkins build became unstable: kio_stable_qt5 #8
See http://build.kde.org/job/kio_stable_qt5/8/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext - HTML conversion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/#review71266 --- Ship it! Good by me :) Two small notes below, but not commit blockers imo. src/lib/text/ktexttohtml_p.h https://git.reviewboard.kde.org/r/121094/#comment49767 Comment is not accurate/relevant anymore src/lib/text/ktexttohtml_p.h https://git.reviewboard.kde.org/r/121094/#comment49766 Comment is not accurate/relevant anymore - Aaron J. Seigo On Dec. 2, 2014, 4:57 p.m., Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- (Updated Dec. 2, 2014, 4:57 p.m.) Review request for KDE Frameworks and Michael Pyne. Repository: kcoreaddons Description --- This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class takes plaintext string, and converts it to HTML while perserving spacing, converting URLs and email addresses into a href... links and interpreting highligting markup (*bold*, _underline_, /italic/) and wrapping it to corresponding HTML tags. It can also convert text emoticons into img smileys. The last - emoticons conversion - depends on KEmoticons, which we can't use directly from KCoreAddons, so I moved the actual KEmoticons code into KEmoticonsIntegration plugin in KEmoticons. There is a dummy implementation provided by default in KCoreAddons that is loaded when the KEmoticonsIntegration plugin is not available, or when the application is only a QCoreApplication (since KEmoticons require QGuiApplication, so we must not load the plugin). The dummy implementation does nothing and returns the original string unaltered. The reason for moving the class from KPimUtils is that KPimUtils is going to die, and while we could make this internal to KDE PIM, I think this is a rather useful code, that can be used by many applications that need to deal with 3rd party text data and want to provide user-friendly clickable links. If you compare this with the original KPimUtils::LinkLocator you find, that I removed all public API except for the convertToHTML method. This is because the remaining methods (getUrl, getEmailAddress) depend on the actual state of the LinkLocator object, but LinkLocator provides no API for step-by-step parsing, so they were actually useless for public use. For that reason I decided to only publish the convertToHTML method, and hide the remaining methods as internal methods of the KTextToHTMLHelper (useful for unit-testing). This patch also contains a unit-test from KPimUtils. Diffs - autotests/CMakeLists.txt d5a5feb autotests/ktexttohtmltest.h PRE-CREATION autotests/ktexttohtmltest.cpp PRE-CREATION src/lib/CMakeLists.txt 3e055a5 src/lib/CMakeLists.txt.orig PRE-CREATION src/lib/text/.ktexttohtml.cpp.kate-swp PRE-CREATION src/lib/text/ktexttohtml.h PRE-CREATION src/lib/text/ktexttohtml.cpp PRE-CREATION src/lib/text/ktexttohtml_p.h PRE-CREATION src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121094/diff/ Testing --- Unit test passes Thanks, Daniel Vrátil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: frameworkintegration_stable_qt5 #4
See http://build.kde.org/job/frameworkintegration_stable_qt5/4/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: frameworkintegration_master_qt5 #137
See http://build.kde.org/job/frameworkintegration_master_qt5/137/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: krunner_master_qt5 #109
See http://build.kde.org/job/krunner_master_qt5/109/changes Changes: [scripty] Upgrade ECM and KF5 version requirements for 5.5.0 release. -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/krunner_master_qt5/ws/ Running Prebuild steps [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson5200987966135550120.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at aeb495b Upgrade ECM and KF5 version requirements for 5.5.0 release. Removing build/ Success build forhudson.tasks.Shell@2d86eed9 git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository git config remote.origin.url git://anongit.kde.org/krunner # timeout=10 Fetching upstream changes from git://anongit.kde.org/krunner git --version # timeout=10 git fetch --tags --progress git://anongit.kde.org/krunner +refs/heads/*:refs/remotes/origin/* git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10 git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10 git rev-parse refs/heads/jenkins^{commit} # timeout=10 Checking out Revision aeb495b8721775e6dca1bca52e4be7c2690b6cbc (refs/heads/jenkins) git config core.sparsecheckout # timeout=10 git checkout -f aeb495b8721775e6dca1bca52e4be7c2690b6cbc git rev-list d790740dababe4b4d2c2046b4c7df4f068afdaae # timeout=10 git tag -a -f -m Jenkins Build #109 jenkins-krunner_master_qt5-109 # timeout=10 Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [krunner_master_qt5] $ /bin/sh -xe /tmp/hudson1459015743253336156.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: krunner - Branch master == Build Dependencies: kdnssd - Branch master cmake - Branch master kitemviews - Branch master kcrash - Branch master knotifications - Branch master kbookmarks - Branch master kconfig - Branch master threadweaver - Branch master kiconthemes - Branch master kservice - Branch master ki18n - Branch master kwallet - Branch master libgit2 - Branch master kconfigwidgets - Branch master qt5 - Branch stable attica - Branch master kcodecs - Branch master kxmlgui - Branch master kitemmodels - Branch master dogtail - Branch master kauth - Branch master kross - Branch master kio - Branch master kcompletion - Branch master kparts - Branch master solid - Branch master kjs - Branch master sonnet - Branch master extra-cmake-modules - Branch master kunitconversion - Branch master kactivities - Branch master kwidgetsaddons - Branch master polkit-qt-1 - Branch master plasma-framework - Branch master kdoctools - Branch master karchive - Branch master phonon - Branch master kwindowsystem - Branch master kjobwidgets - Branch master kglobalaccel - Branch master kcoreaddons - Branch master ktexteditor - Branch master kdbusaddons - Branch master ktextwidgets - Branch master kdeclarative - Branch master kidletime - Branch master kguiaddons - Branch master kcmutils - Branch master == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for __GLIBC__ -- Looking for __GLIBC__ - found -- Performing Test _OFFT_IS_64BIT -- Performing Test _OFFT_IS_64BIT - Success -- Found Gettext: /usr/bin/msgmerge (found version 0.18.1) -- Found PythonInterp: /usr/bin/python (found version 2.7.3) CMake Error at CMakeLists.txt:37 (find_package): Could not find a configuration file for package KF5Plasma that is compatible with requested version 5.5.0. The following configuration files were considered but not accepted: /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/lib64/cmake/KF5Plasma/KF5PlasmaConfig.cmake, version: 5.4.0 -- Configuring incomplete, errors occurred! See also