Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/#review75548 --- README.md https://git.reviewboard.kde.org/r/122453/#comment52248 I find the second part a bit confusing and the people who hold them reads to me like I hold a contact (in my hand?) and so KPeople provides access to me. It's also not clear what all contacts is. I'd simply say A contact aggregation library perhaps? README.md https://git.reviewboard.kde.org/r/122453/#comment52249 I've read this over and over and still find it unclear of what it is. KPeople offers unified way to access contacts from multiple different sources, allowing to aggregate related contacts into 'persons'. These sources are plugin-based which allows for easy extension of the contacts collection. something like that? README.md https://git.reviewboard.kde.org/r/122453/#comment52250 we want to integrate...into our -- this whole Usage part talks about you, so you'll want to use you want to integrate...into your Same for We will mainly find README.md https://git.reviewboard.kde.org/r/122453/#comment52251 This for a change talks in it form :) I'd change that to you again. You should _only_ use it... etc providing support for a new backend type -- only new backend, not a new type. src/persondata.h https://git.reviewboard.kde.org/r/122453/#comment52252 all e-mail addresses? As all e-mails confusingly reads like all emails you received from this contact (in fact, the method should probably not be named allEmails as well for the same reason) src/widgets/mergedialog.h https://git.reviewboard.kde.org/r/122453/#comment52254 By properly merging contacts, the user will end up with more information on each contact...? (it's not like two different email addresses will give me better information on who someone _is_ ;) src/widgets/persondetailsview.h https://git.reviewboard.kde.org/r/122453/#comment52253 -- for which the data will be displayed - Martin Klapetek On Feb. 6, 2015, 3:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/ --- (Updated Feb. 6, 2015, 3:14 p.m.) Review request for KDE Frameworks, KDEPIM and Telepathy. Repository: libkpeople Description --- Adds a README.md and a metainfo.yaml. It also documents some classes and methods that didn't have any documentation. Diffs - src/widgets/CMakeLists.txt bd2cd7e src/widgets/mergedialog.h 305d07b src/widgets/persondetailsview.h 0769d51 CMakeLists.txt 00177f3 README.md PRE-CREATION metainfo.yaml PRE-CREATION src/CMakeLists.txt 7e01976 src/duplicatesfinder_p.h 05f0063 src/persondata.h 0fab902 src/personsmodel.h 32dc1f5 Diff: https://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122462: [KCompletion] Fix typos in documentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Fix typos in documentation - Substitute double space after period for single space - emition -- emission - Re-implemented -- Reimplemented Diffs - src/kcombobox.h 075d42f src/kcompletion.h a6ed372 src/kcompletion_p.h 138c228 src/kcompletionbase.h 6111f9a src/kcompletionbox.h 1759eba src/kcompletionmatches.h 517f111 src/khistorycombobox.h 182ba0a src/klineedit.h 460a2ae src/klineedit_p.h 0be32ba src/kpixmapprovider.h 67917f2 src/ksortablelist.h 8b1b155 src/kzoneallocator_p.h 2d75a83 Diff: https://git.reviewboard.kde.org/r/122462/diff/ Testing --- None needed Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework
On Feb. 6, 2015, 11:24 p.m., Martin Klapetek wrote: src/widgets/persondetailsview.h, line 49 https://git.reviewboard.kde.org/r/122453/diff/1/?file=347207#file347207line49 -- for which the data will be displayed s/data/details - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/#review75548 --- On Feb. 6, 2015, 3:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/ --- (Updated Feb. 6, 2015, 3:14 p.m.) Review request for KDE Frameworks, KDEPIM and Telepathy. Repository: libkpeople Description --- Adds a README.md and a metainfo.yaml. It also documents some classes and methods that didn't have any documentation. Diffs - src/widgets/CMakeLists.txt bd2cd7e src/widgets/mergedialog.h 305d07b src/widgets/persondetailsview.h 0769d51 CMakeLists.txt 00177f3 README.md PRE-CREATION metainfo.yaml PRE-CREATION src/CMakeLists.txt 7e01976 src/duplicatesfinder_p.h 05f0063 src/persondata.h 0fab902 src/personsmodel.h 32dc1f5 Diff: https://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122206: [kio] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/ --- (Updated Feb. 7, 2015, 12:14 a.m.) Review request for KDE Frameworks. Changes --- Do it like kwin. Repository: kio Description --- [kio] Make tests optional This is a small patch to CMakeLists.txt to only depend on Qt5Test if BUILD_TESTING. Diffs (updated) - CMakeLists.txt c1ed03f6cac648517828aec60e896baf9fbcfd9d Diff: https://git.reviewboard.kde.org/r/122206/diff/ Testing --- Thanks, Andreas Sturmlechner ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : plasma-framework_stable_qt5 » All,LINBUILDER #98
See http://build.kde.org/job/plasma-framework_stable_qt5/Variation=All,label=LINBUILDER/98/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to stable : kservice_master_qt5 #233
See http://build.kde.org/job/kservice_master_qt5/233/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122453: Improve KPeople documentation, in order to become a Framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/ --- Review request for KDE Frameworks, KDEPIM and Telepathy. Repository: libkpeople Description --- Adds a README.md and a metainfo.yaml. It also documents some classes and methods that didn't have any documentation. Diffs - src/widgets/CMakeLists.txt bd2cd7e src/widgets/mergedialog.h 305d07b src/widgets/persondetailsview.h 0769d51 CMakeLists.txt 00177f3 README.md PRE-CREATION metainfo.yaml PRE-CREATION src/CMakeLists.txt 7e01976 src/duplicatesfinder_p.h 05f0063 src/persondata.h 0fab902 src/personsmodel.h 32dc1f5 Diff: https://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121020: reverse ShowIconsOnPushButtons default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121020/ --- (Updated Feb. 6, 2015, 4:26 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. Repository: plasma-desktop Description --- sumamrized, also see https://forum.kde.org/viewtopic.php?f=285t=123587 https://git.reviewboard.kde.org/r/121019/ https://git.reviewboard.kde.org/r/121021/ Diffs - kcms/krdb/krdb.cpp 8452aa5 kcms/style/kcmstyle.cpp 9a13f45 Diff: https://git.reviewboard.kde.org/r/121020/diff/ Testing --- Thanks, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121021: reverse ShowIconsOnPushButtons default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121021/ --- (Updated Feb. 6, 2015, 4:26 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. Repository: kdelibs4support Description --- sumamrized, also see https://forum.kde.org/viewtopic.php?f=285t=123587 https://git.reviewboard.kde.org/r/121019/ https://git.reviewboard.kde.org/r/121020/ Diffs - src/kdeui/k4style.cpp a1a2ab1 src/kdeui/kglobalsettings.h d63ac69 Diff: https://git.reviewboard.kde.org/r/121021/diff/ Testing --- Thanks, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121019: reverse ShowIconsOnPushButtons default
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121019/ --- (Updated Feb. 6, 2015, 4:25 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. Repository: frameworkintegration Description --- sumamrized, also see https://forum.kde.org/viewtopic.php?f=285t=123587 https://git.reviewboard.kde.org/r/121020/ https://git.reviewboard.kde.org/r/121021/ Diffs - autotests/kdeplatformtheme_changed_kdeglobals 910e0e3 autotests/kdeplatformtheme_kdeglobals df52410 src/kstyle/kstyle.cpp b5f7363 src/platformtheme/khintssettings.cpp 8799216 Diff: https://git.reviewboard.kde.org/r/121019/diff/ Testing --- Thanks, Thomas Lübking ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/#review75535 --- metainfo.yaml https://git.reviewboard.kde.org/r/122453/#comment52234 Perhaps you want to add your name over here? - Vishesh Handa On Feb. 6, 2015, 2:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453/ --- (Updated Feb. 6, 2015, 2:14 p.m.) Review request for KDE Frameworks, KDEPIM and Telepathy. Repository: libkpeople Description --- Adds a README.md and a metainfo.yaml. It also documents some classes and methods that didn't have any documentation. Diffs - src/widgets/CMakeLists.txt bd2cd7e src/widgets/mergedialog.h 305d07b src/widgets/persondetailsview.h 0769d51 CMakeLists.txt 00177f3 README.md PRE-CREATION metainfo.yaml PRE-CREATION src/CMakeLists.txt 7e01976 src/duplicatesfinder_p.h 05f0063 src/persondata.h 0fab902 src/personsmodel.h 32dc1f5 Diff: https://git.reviewboard.kde.org/r/122453/diff/ Testing --- Unit tests still pass ;). Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/ --- Review request for KDE Frameworks. Bugs: 343735 https://bugs.kde.org/show_bug.cgi?id=343735 Repository: kio Description --- This is an attempt to fix a bug that seems quite difficult to reproduce, but definitely happens It seems there is a weird race condition linked to the sync of the two files .local/share/user-places.xbel .local/share/kfileplaces/bookmarks.xml causing the bug https://bugs.kde.org/show_bug.cgi?id=343735 all processes that are listening for changes in the bookmark manager will try to sync their bookmarks with the shared ones (user-places.xbel) and depending what process arrives first, some bookmarks may be lost if this is ok, it will have to go in kdelibs4 (since distributions will support kde4 apps for a long time still) as well as (ouch) dolphin both 4 and 5, since it forks KFilePlacesModel Diffs - src/filewidgets/kfileplacesmodel.cpp d8da868 src/filewidgets/kfileplacessharedbookmarks.cpp fbd6b53 src/filewidgets/kfileplacessharedbookmarks_p.h 4c9f6a4 Diff: https://git.reviewboard.kde.org/r/122459/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/ --- (Updated Feb. 6, 2015, 5:53 p.m.) Review request for KDE Frameworks. Bugs: 343735 https://bugs.kde.org/show_bug.cgi?id=343735 Repository: kio Description --- This is an attempt to fix a bug that seems quite difficult to reproduce, but definitely happens It seems there is a weird race condition linked to the sync of the two files .local/share/user-places.xbel .local/share/kfileplaces/bookmarks.xml causing the bug https://bugs.kde.org/show_bug.cgi?id=343735 all processes that are listening for changes in the bookmark manager will try to sync their bookmarks with the shared ones (user-places.xbel) and depending what process arrives first, some bookmarks may be lost if this is ok, it will have to go in kdelibs4 (since distributions will support kde4 apps for a long time still) as well as (ouch) dolphin both 4 and 5, since it forks KFilePlacesModel Diffs (updated) - src/filewidgets/kfileplacesmodel.cpp d8da868 src/filewidgets/kfileplacessharedbookmarks.cpp fbd6b53 src/filewidgets/kfileplacessharedbookmarks_p.h 4c9f6a4 Diff: https://git.reviewboard.kde.org/r/122459/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/#review75541 --- src/filewidgets/kfileplacesmodel.cpp https://git.reviewboard.kde.org/r/122459/#comment52246 bit enthusiastic once will suffice. +1 - David Edmundson On Feb. 6, 2015, 5:42 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/ --- (Updated Feb. 6, 2015, 5:42 p.m.) Review request for KDE Frameworks. Bugs: 343735 https://bugs.kde.org/show_bug.cgi?id=343735 Repository: kio Description --- This is an attempt to fix a bug that seems quite difficult to reproduce, but definitely happens It seems there is a weird race condition linked to the sync of the two files .local/share/user-places.xbel .local/share/kfileplaces/bookmarks.xml causing the bug https://bugs.kde.org/show_bug.cgi?id=343735 all processes that are listening for changes in the bookmark manager will try to sync their bookmarks with the shared ones (user-places.xbel) and depending what process arrives first, some bookmarks may be lost if this is ok, it will have to go in kdelibs4 (since distributions will support kde4 apps for a long time still) as well as (ouch) dolphin both 4 and 5, since it forks KFilePlacesModel Diffs - src/filewidgets/kfileplacesmodel.cpp d8da868 src/filewidgets/kfileplacessharedbookmarks.cpp fbd6b53 src/filewidgets/kfileplacessharedbookmarks_p.h 4c9f6a4 Diff: https://git.reviewboard.kde.org/r/122459/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
