Jenkins-kde-ci: krunner master kf5-qt5 » OSX,clang - Build # 4 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/4/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

BUG: 346920
REVIEW: 124032


Diffs
-

  autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
  src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 

Diff: https://git.reviewboard.kde.org/r/124032/diff/


Testing
---

added a unit test, it now passes. also kate and the manual 
kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
requester.


Thanks,

Milian Wolff

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 123861: Make KCodecs::base64Encode() RFC compliant

2015-06-06 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123861/#review81258
---


This sounds like something that should come with a unittest...

- David Faure


On May 20, 2015, 12:46 p.m., Daniel Vrátil wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123861/
 ---
 
 (Updated May 20, 2015, 12:46 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kcodecs
 
 
 Description
 ---
 
 Don't append a trailing CRLF to the coded data. This was left over from 
 KMime, where this made some sense in respect to RFC822.
 
 According to LXR it should not affect anything except for some unreleased KDE 
 PIM code and it will fix code that expects the original behaviour.
 
 
 Diffs
 -
 
   src/kcodecsbase64.cpp fc03262 
 
 Diff: https://git.reviewboard.kde.org/r/123861/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Daniel Vrátil
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 123872: Add TranslationDomain attribute to kconfig_compiler

2015-06-06 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review81259
---


A test doesn't really need ki18n, it could just define its own i18n() function.

Alternatively, you can put the test in a higher level framework, like 
frameworkintegration.

- David Faure


On May 21, 2015, 3:21 p.m., Chusslove Illich wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123872/
 ---
 
 (Updated May 21, 2015, 3:21 p.m.)
 
 
 Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.
 
 
 Repository: kconfig
 
 
 Description
 ---
 
 When using Ki18n as the translation system, library .kcfg files also need to 
 specify the translation domain. This is analogous to the TRANSLATION_DOMAIN 
 define in C++ code, and translationDomain attribute in .rc files.
 
 
 Diffs
 -
 
   src/kconfig_compiler/kconfig_compiler.cpp 7160bb5 
 
 Diff: https://git.reviewboard.kde.org/r/123872/diff/
 
 
 Testing
 ---
 
 Compiles.
 
 
 Thanks,
 
 Chusslove Illich
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


missing dep on OSX CI?

2015-06-06 Thread David Faure
KActivities fails with the error below. Is boost::optional installed?

04:17:31 
/Users/jenkins/builds/kactivities/kf5-qt5/src/utils/continue_with.h:14:10: 
fatal error: 'boost/optional.hpp' file not found
04:17:31 #include boost/optional.hpp

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


ACL support missing in Linux CI?

2015-06-06 Thread David Faure
This used to pass, but broke in the recent restructuring of the CI (it moved to 
a different VM?)

https://build.kde.org/view/Frameworks%20kf5-qt5/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/testReport/%28root%29/TestSuite/kiocore_kacltest/

Can you check that the fileystem this runs on, has ACL support?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: [kio] autotests: Add unit test for KIO::AccessManager

2015-06-06 Thread David Faure
On Wednesday 03 June 2015 02:07:09 Aleix Pol wrote:
 Is there anyone with Qt 5.4.2 around? I'm thinking the problem might
 be that it doesn't have this fix [1] yet.

I have Qt 5.4.2, and the weird thing is:
./accessmanagertest-qnam fails once for me, and then it passes repeatedly.
(reliably - ran it in a loop for 5 minutes).

It fails again only after I run ./accessmanagertest (the kio version).

Anyhow, you're right, I applied the patch you mentionned, and the test passes 
reliably now.

I'll add a Qt version ifdef.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 123972: Clarify exit value for Unique instances

2015-06-06 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123972/#review81257
---

Ship it!


Ship It!

- David Faure


On June 3, 2015, 8:19 p.m., Stefan Brüns wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123972/
 ---
 
 (Updated June 3, 2015, 8:19 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kdbusaddons
 
 
 Description
 ---
 
 The default exit value for a duplicate instance is 0, if not set
 from the already-running application.
 
 Signed-off-by: Stefan Brüns stefan.bru...@rwth-aachen.de
 
 
 Diffs
 -
 
   src/kdbusservice.h 8dd6357419c64e0b5a1eca6f3f56c760f8c398fa 
 
 Diff: https://git.reviewboard.kde.org/r/123972/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Stefan Brüns
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: KEncodingProber vs unexisting codecs

2015-06-06 Thread David Faure
On Sunday 24 May 2015 07:18:21 Albert Astals Cid wrote:
 One of the codecs that KEncodingProber can return is x-euc-tw
 
 But neither the Qt4 nor the Qt5 installed in my distribution understand that
 codec, so doing the suggested
 
   QTextCodec::codecForName(prober.encoding())-toUnicode(data);
 
 Will crash.

Qt's ICU codec indeed doesn't support euc-tw, because it's not even registered 
at IANA:
http://www.iana.org/assignments/character-sets/character-sets.xhtml
(and that's what qicucodec.cpp uses as the base list)

I would just remove it from the prober.

You are right, however, that a runtime check is needed anyway, because one can 
compile Qt without ICU support, and then the list of supported codecs might be 
different.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: krunner master stable-kf5-qt5 » Linux,gcc - Build # 4 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/krunner%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/4/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: [kio] autotests: Add unit test for KIO::AccessManager

2015-06-06 Thread Aleix Pol
On Sat, Jun 6, 2015 at 11:13 AM, David Faure fa...@kde.org wrote:
 On Wednesday 03 June 2015 02:07:09 Aleix Pol wrote:
 Is there anyone with Qt 5.4.2 around? I'm thinking the problem might
 be that it doesn't have this fix [1] yet.

 I have Qt 5.4.2, and the weird thing is:
 ./accessmanagertest-qnam fails once for me, and then it passes repeatedly.
 (reliably - ran it in a loop for 5 minutes).

 It fails again only after I run ./accessmanagertest (the kio version).

 Anyhow, you're right, I applied the patch you mentionned, and the test passes
 reliably now.

 I'll add a Qt version ifdef.

 --
 David Faure, fa...@kde.org, http://www.davidfaure.fr
 Working on KDE Frameworks 5


Thank you very much, David!

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: krunner master stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/krunner%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-06 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124014/
---

(Updated June 6, 2015, 10:23 a.m.)


Review request for KDE Frameworks.


Repository: kdeclarative


Description
---

Add QQC clone of KColorButton. 

It's being used by SystemLoadViewer Plasmoid, Kai's clock review, and a mod I'm 
doing for the notes plasmoid and it's something we'll want to have.

High DPI support works perfectly as these are device independent pixels.


Diffs (updated)
-

  src/qmlcontrols/kquickcontrols/CMakeLists.txt 
b7c08d7bcb46e53407d4b44fa593346f9d0a2137 
  src/qmlcontrols/kquickcontrols/ColorButton.qml PRE-CREATION 
  src/qmlcontrols/kquickcontrols/qmldir 
31d8b145bf50491f94a14ba317b215fd6cc0ca32 
  tests/colorButtonTest.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124014/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 10 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/10/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 10 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/10/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kauth master stable-kf5-qt5 » OSX,clang - Build # 4 - Fixed!

2015-06-06 Thread no-reply
We thank you for fixing your build!___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 15 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-06 Thread David Edmundson


 On June 5, 2015, 3:44 p.m., Marco Martin wrote:
  for qstyle based stuff we are depending on the qt devicepixelratio var, 
  right?

For all QQC stuff, yes.


 On June 5, 2015, 3:44 p.m., Marco Martin wrote:
  src/qmlcontrols/kquickcontrols/ColorButton.qml, line 40
  https://git.reviewboard.kde.org/r/124014/diff/1/?file=378857#file378857line40
 
  this may look very different with different qstyles? (like oxygen that 
  has huge margin/border area around buttons)

It looks OK on what I tested. I know it's not ideal, but nothing we have is 
(units wouldn't help)

Basically I need QStyle::sizeFromContents() but I can't use that because:
- it's not exported in any public API
- we should work with all QQC themes and not just assume it's running the 
desktop one.

You'd think one could probe the style.padding, but for the QQC desktop theme 
that's not set properly.

Hopefully at the end of the Qt Contributor Summit, I'll be able to come back 
with a solution for a future Qt, and then we'll only have to fix it in this one 
place.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124014/#review81233
---


On June 5, 2015, 10:46 a.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124014/
 ---
 
 (Updated June 5, 2015, 10:46 a.m.)
 
 
 Review request for KDE Frameworks and Plasma.
 
 
 Repository: kdeclarative
 
 
 Description
 ---
 
 Add QQC clone of KColorButton. 
 
 It's being used by SystemLoadViewer Plasmoid, Kai's clock review, and a mod 
 I'm doing for the notes plasmoid and it's something we'll want to have.
 
 High DPI support works perfectly as these are device independent pixels.
 
 
 Diffs
 -
 
   src/qmlcontrols/kquickcontrols/CMakeLists.txt 
 b7c08d7bcb46e53407d4b44fa593346f9d0a2137 
   src/qmlcontrols/kquickcontrols/ColorButton.qml PRE-CREATION 
   src/qmlcontrols/kquickcontrols/qmldir 
 31d8b145bf50491f94a14ba317b215fd6cc0ca32 
   tests/colorButtonTest.qml PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/124014/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » OSX,clang - Build # 15 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/15/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-06 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124014/#review81262
---



src/qmlcontrols/kquickcontrols/ColorButton.qml (lines 94 - 95)
https://git.reviewboard.kde.org/r/124014/#comment55674

Now you get half the opacity

opacity is set to the color's opacity but the color also has the opacity.

Either use Qt.rgba(color.r, color.g, color.b, 1) or just drop the opacity


- Kai Uwe Broulik


On Juni 6, 2015, 10:23 vorm., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124014/
 ---
 
 (Updated Juni 6, 2015, 10:23 vorm.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdeclarative
 
 
 Description
 ---
 
 Add QQC clone of KColorButton. 
 
 It's being used by SystemLoadViewer Plasmoid, Kai's clock review, and a mod 
 I'm doing for the notes plasmoid and it's something we'll want to have.
 
 High DPI support works perfectly as these are device independent pixels.
 
 
 Diffs
 -
 
   src/qmlcontrols/kquickcontrols/CMakeLists.txt 
 b7c08d7bcb46e53407d4b44fa593346f9d0a2137 
   src/qmlcontrols/kquickcontrols/ColorButton.qml PRE-CREATION 
   src/qmlcontrols/kquickcontrols/qmldir 
 31d8b145bf50491f94a14ba317b215fd6cc0ca32 
   tests/colorButtonTest.qml PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/124014/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: krunner master stable-kf5-qt5 » OSX,clang - Build # 4 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/krunner%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/4/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kconfig master stable-kf5-qt5 » OSX,clang - Build # 3 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kconfig%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/3/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: khtml master kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/khtml%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kcrash master stable-kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kcrash%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kdeclarative master kf5-qt5 » OSX,clang - Build # 5 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/5/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kcrash master kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kglobalaccel master kf5-qt5 » OSX,clang - Build # 5 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kglobalaccel%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/5/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kglobalaccel master stable-kf5-qt5 » OSX,clang - Build # 5 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kglobalaccel%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/5/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: khtml master stable-kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » OSX,clang - Build # 5 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/5/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » OSX,clang - Build # 7 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/7/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread David Faure


 On June 6, 2015, 9:07 p.m., David Faure wrote:
  The test doesn't check that user completion still works though? (in the 
  case where it's expected, ~foo).
  
  I'm curious btw, why did it crash/assert?
  
  Finally I wonder why this didn't happen in kdelibs4, but ok, the code has 
  had some changes due to the QUrl-KUrl porting, you don't *have* to answer 
  this one ;)
 
 Milian Wolff wrote:
 it still works and I also wonder why this has not happened before - I 
 blame the KUrl/QUrl differences here. Who was the expert in that area again 
 to ask? :P Is it OK if I just add a test that expects a non-empty result set 
 when ~ is inserted? Or what should we look out for ~root maybe? Or can I get 
 the shell user name (or actually - home path) via some Qt API?
 
 David Faure wrote:
 You could compare that completion with KUser::allUsersNames() :-)
 
 Or just using the current user, KUser(KUser::currentUserId()), to check 
 it's in the list, to avoid differences with allUsersNames() due to special 
 users or stuff like that.
 
 Milian Wolff wrote:
 should I run this test only on unix platforms or is this also valid on 
 windows e.g.? what about mac os x?

KUser is portable.

The completion in KIO is portable too (in fact it uses KUser::allUserNames() :-)

So you can run the test on all platforms.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/#review81277
---


On June 6, 2015, 8:58 p.m., Milian Wolff wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124032/
 ---
 
 (Updated June 6, 2015, 8:58 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 BUG: 346920
 REVIEW: 124032
 
 
 Diffs
 -
 
   autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
   src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 
 
 Diff: https://git.reviewboard.kde.org/r/124032/diff/
 
 
 Testing
 ---
 
 added a unit test, it now passes. also kate and the manual 
 kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
 requester.
 
 
 Thanks,
 
 Milian Wolff
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: ktextwidgets master stable-kf5-qt5 » OSX,clang - Build # 4 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/ktextwidgets%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/4/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/
---

(Updated June 6, 2015, 9:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 36b558dbc9d739d5367366290d034cb05e1e8061 by Milian Wolff 
to branch master.


Repository: kio


Description
---

BUG: 346920
REVIEW: 124032

Add unit test for user completion when '~' is inserted.


Diffs
-

  autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
  src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 

Diff: https://git.reviewboard.kde.org/r/124032/diff/


Testing
---

added a unit test, it now passes. also kate and the manual 
kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
requester.


Thanks,

Milian Wolff

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kwallet master stable-kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kwallet%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: What environment variable defines where krunner looks for libkdeinit5_$app.so

2015-06-06 Thread David Faure
On Saturday 06 June 2015 23:18:51 Milian Wolff wrote:
 Hey all,
 
 I try to configure my KF5 plasma environment similar to my old KDE4 plasma.
 There, I could open even applications build into my custom prefix via
 krunner. I think, the important part was to set PATH there mostly to have
 that working. In KF5 now I'm greeted with this:
 
 KDEInit could not launch 'kwrite':
 Could not open library '/usr/lib/libkdeinit5_kwrite'.
 Cannot load library /usr/lib/libkdeinit5_kwrite:
 (/usr/lib/libkdeinit5_kwrite.so: cannot open shared object file: No such
 file or directory)
 
 This file is located in my prefix: /home/milian/projects/compiled/kf5/lib64
 What environment variable do I need to set for KRunner to find it?

The error isn't about krunner but about kdeinit5, which can't find the .so to 
dlopen.

I suggest debugging a bit in kinit.cpp, function launch(), to find out more, 
but it looks like this function is already getting a full path as input?

You could try adding a lookup in LD_LIBRARY_PATH in that code, to make it more 
flexible --- or in the calling code, if indeed the problem is before that.

Problem number 2: this kdeinit5 dlopen stuff is supposed to be optional, 
kdeinit should fallback to executing the binary, otherwise. I.e. this code is 
supposed to clear libpath and keep only execpath, and find it (kwrite) in 
$PATH.

Happy debugging :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/#review81283
---

Ship it!


Ship It!

- David Faure


On June 6, 2015, 9:27 p.m., Milian Wolff wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124032/
 ---
 
 (Updated June 6, 2015, 9:27 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 BUG: 346920
 REVIEW: 124032
 
 Add unit test for user completion when '~' is inserted.
 
 
 Diffs
 -
 
   autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
   src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 
 
 Diff: https://git.reviewboard.kde.org/r/124032/diff/
 
 
 Testing
 ---
 
 added a unit test, it now passes. also kate and the manual 
 kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
 requester.
 
 
 Thanks,
 
 Milian Wolff
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kwallet master kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kwallet%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Jenkins-kde-ci: kxmlgui master kf5-qt5 » OSX, clang - Build # 3 - Still Failing!

2015-06-06 Thread David Faure
On Saturday 06 June 2015 22:01:50 no-re...@kde.org wrote:
  Check console output at
 https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=OSX,compiler=
 clang/3/ to view the results.

It fails to find a KWindowSystem 5.11.

But KWindowSystem has had version 5.11 for almost one month now, so it should 
find it.

The kwindowsystem CI page says, for OSX: NoX11=green All=gray (canceled?).

I have just triggered another build of 
https://build.kde.org/view/Frameworks%20kf5-qt5/job/kwindowsystem%20master%20kf5-qt5/
Let's see if that helps
(but man, that OSX CI slows down everything, it's becoming a real pain to make 
releases,
at least if I want to keep my checklist item ensure CI is green)

I wonder whether we couldn't completely separate the linux and OSX CI instead
of having the latter slow down the former (and unreadable merged results)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff


 On June 6, 2015, 9:07 p.m., David Faure wrote:
  The test doesn't check that user completion still works though? (in the 
  case where it's expected, ~foo).
  
  I'm curious btw, why did it crash/assert?
  
  Finally I wonder why this didn't happen in kdelibs4, but ok, the code has 
  had some changes due to the QUrl-KUrl porting, you don't *have* to answer 
  this one ;)

it still works and I also wonder why this has not happened before - I blame the 
KUrl/QUrl differences here. Who was the expert in that area again to ask? :P Is 
it OK if I just add a test that expects a non-empty result set when ~ is 
inserted? Or what should we look out for ~root maybe? Or can I get the shell 
user name (or actually - home path) via some Qt API?


- Milian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/#review81277
---


On June 6, 2015, 8:58 p.m., Milian Wolff wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124032/
 ---
 
 (Updated June 6, 2015, 8:58 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 BUG: 346920
 REVIEW: 124032
 
 
 Diffs
 -
 
   autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
   src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 
 
 Diff: https://git.reviewboard.kde.org/r/124032/diff/
 
 
 Testing
 ---
 
 added a unit test, it now passes. also kate and the manual 
 kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
 requester.
 
 
 Thanks,
 
 Milian Wolff
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kxmlgui master stable-kf5-qt5 » OSX,clang - Build # 4 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kxmlgui%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/4/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » OSX,clang - Build # 8 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/8/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: New framework: BluezQt

2015-06-06 Thread David Faure
On Thursday 28 May 2015 22:52:17 David Rosca wrote:
 It's been over 14 days now, so if there are no objections, I will ask
 sysadmins to move it to frameworks.
 
 Also, are there any other steps I should do besides moving the repository?

It looks fine, it's getting picked up for KF 5.11.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/#review81277
---


The test doesn't check that user completion still works though? (in the case 
where it's expected, ~foo).

I'm curious btw, why did it crash/assert?

Finally I wonder why this didn't happen in kdelibs4, but ok, the code has had 
some changes due to the QUrl-KUrl porting, you don't *have* to answer this one 
;)

- David Faure


On June 6, 2015, 8:58 p.m., Milian Wolff wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124032/
 ---
 
 (Updated June 6, 2015, 8:58 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 BUG: 346920
 REVIEW: 124032
 
 
 Diffs
 -
 
   autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
   src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 
 
 Diff: https://git.reviewboard.kde.org/r/124032/diff/
 
 
 Testing
 ---
 
 added a unit test, it now passes. also kate and the manual 
 kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
 requester.
 
 
 Thanks,
 
 Milian Wolff
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread David Faure


 On June 6, 2015, 9:07 p.m., David Faure wrote:
  The test doesn't check that user completion still works though? (in the 
  case where it's expected, ~foo).
  
  I'm curious btw, why did it crash/assert?
  
  Finally I wonder why this didn't happen in kdelibs4, but ok, the code has 
  had some changes due to the QUrl-KUrl porting, you don't *have* to answer 
  this one ;)
 
 Milian Wolff wrote:
 it still works and I also wonder why this has not happened before - I 
 blame the KUrl/QUrl differences here. Who was the expert in that area again 
 to ask? :P Is it OK if I just add a test that expects a non-empty result set 
 when ~ is inserted? Or what should we look out for ~root maybe? Or can I get 
 the shell user name (or actually - home path) via some Qt API?

You could compare that completion with KUser::allUsersNames() :-)

Or just using the current user, KUser(KUser::currentUserId()), to check it's in 
the list, to avoid differences with allUsersNames() due to special users or 
stuff like that.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/#review81277
---


On June 6, 2015, 8:58 p.m., Milian Wolff wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124032/
 ---
 
 (Updated June 6, 2015, 8:58 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 BUG: 346920
 REVIEW: 124032
 
 
 Diffs
 -
 
   autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
   src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 
 
 Diff: https://git.reviewboard.kde.org/r/124032/diff/
 
 
 Testing
 ---
 
 added a unit test, it now passes. also kate and the manual 
 kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
 requester.
 
 
 Thanks,
 
 Milian Wolff
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


What environment variable defines where krunner looks for libkdeinit5_$app.so

2015-06-06 Thread Milian Wolff
Hey all,

I try to configure my KF5 plasma environment similar to my old KDE4 plasma. 
There, I could open even applications build into my custom prefix via krunner. 
I think, the important part was to set PATH there mostly to have that working. 
In KF5 now I'm greeted with this:

KDEInit could not launch 'kwrite':
Could not open library '/usr/lib/libkdeinit5_kwrite'.
Cannot load library /usr/lib/libkdeinit5_kwrite: 
(/usr/lib/libkdeinit5_kwrite.so: cannot open shared object file: No such file 
or directory)

This file is located in my prefix: /home/milian/projects/compiled/kf5/lib64
What environment variable do I need to set for KRunner to find it?

Thanks
-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Alex Richardson


 On June 6, 2015, 10:07 p.m., David Faure wrote:
  The test doesn't check that user completion still works though? (in the 
  case where it's expected, ~foo).
  
  I'm curious btw, why did it crash/assert?
  
  Finally I wonder why this didn't happen in kdelibs4, but ok, the code has 
  had some changes due to the QUrl-KUrl porting, you don't *have* to answer 
  this one ;)
 
 Milian Wolff wrote:
 it still works and I also wonder why this has not happened before - I 
 blame the KUrl/QUrl differences here. Who was the expert in that area again 
 to ask? :P Is it OK if I just add a test that expects a non-empty result set 
 when ~ is inserted? Or what should we look out for ~root maybe? Or can I get 
 the shell user name (or actually - home path) via some Qt API?
 
 David Faure wrote:
 You could compare that completion with KUser::allUsersNames() :-)
 
 Or just using the current user, KUser(KUser::currentUserId()), to check 
 it's in the list, to avoid differences with allUsersNames() due to special 
 users or stuff like that.
 
 Milian Wolff wrote:
 should I run this test only on unix platforms or is this also valid on 
 windows e.g.? what about mac os x?
 
 David Faure wrote:
 KUser is portable.
 
 The completion in KIO is portable too (in fact it uses 
 KUser::allUserNames() :-)
 
 So you can run the test on all platforms.

It should work fine on Windows as well (at least it did when I tested that code 
on Windows 7, I assume Microsoft stays backwards compatible). However, I no 
longer have a Windows machine to test it.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/#review81277
---


On June 6, 2015, 9:58 p.m., Milian Wolff wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124032/
 ---
 
 (Updated June 6, 2015, 9:58 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 BUG: 346920
 REVIEW: 124032
 
 
 Diffs
 -
 
   autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
   src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 
 
 Diff: https://git.reviewboard.kde.org/r/124032/diff/
 
 
 Testing
 ---
 
 added a unit test, it now passes. also kate and the manual 
 kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
 requester.
 
 
 Thanks,
 
 Milian Wolff
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kxmlgui master kf5-qt5 » OSX,clang - Build # 3 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kxmlgui%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/3/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 11 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/11/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » OSX,clang - Build # 16 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/16/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff


 On June 6, 2015, 9:07 p.m., David Faure wrote:
  The test doesn't check that user completion still works though? (in the 
  case where it's expected, ~foo).
  
  I'm curious btw, why did it crash/assert?
  
  Finally I wonder why this didn't happen in kdelibs4, but ok, the code has 
  had some changes due to the QUrl-KUrl porting, you don't *have* to answer 
  this one ;)
 
 Milian Wolff wrote:
 it still works and I also wonder why this has not happened before - I 
 blame the KUrl/QUrl differences here. Who was the expert in that area again 
 to ask? :P Is it OK if I just add a test that expects a non-empty result set 
 when ~ is inserted? Or what should we look out for ~root maybe? Or can I get 
 the shell user name (or actually - home path) via some Qt API?
 
 David Faure wrote:
 You could compare that completion with KUser::allUsersNames() :-)
 
 Or just using the current user, KUser(KUser::currentUserId()), to check 
 it's in the list, to avoid differences with allUsersNames() due to special 
 users or stuff like that.

should I run this test only on unix platforms or is this also valid on windows 
e.g.? what about mac os x?


- Milian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/#review81277
---


On June 6, 2015, 8:58 p.m., Milian Wolff wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/124032/
 ---
 
 (Updated June 6, 2015, 8:58 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kio
 
 
 Description
 ---
 
 BUG: 346920
 REVIEW: 124032
 
 
 Diffs
 -
 
   autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
   src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 
 
 Diff: https://git.reviewboard.kde.org/r/124032/diff/
 
 
 Testing
 ---
 
 added a unit test, it now passes. also kate and the manual 
 kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
 requester.
 
 
 Thanks,
 
 Milian Wolff
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 124032: Do not try to complete users and assert when prepend is non-empty.

2015-06-06 Thread Milian Wolff

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124032/
---

(Updated June 6, 2015, 9:27 p.m.)


Review request for KDE Frameworks and David Faure.


Repository: kio


Description (updated)
---

BUG: 346920
REVIEW: 124032

Add unit test for user completion when '~' is inserted.


Diffs (updated)
-

  autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c 
  src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef 

Diff: https://git.reviewboard.kde.org/r/124032/diff/


Testing
---

added a unit test, it now passes. also kate and the manual 
kurlrequestertest_gui test don't crash anymore when I insert ~/. into a url 
requester.


Thanks,

Milian Wolff

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: plasma-framework master kf5-qt5 » OSX,NoX11,clang - Build # 9 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=OSX,Variation=NoX11,compiler=clang/9/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: What environment variable defines where krunner looks for libkdeinit5_$app.so

2015-06-06 Thread Milian Wolff
On Saturday 06 June 2015 23:31:52 David Faure wrote:
 On Saturday 06 June 2015 23:18:51 Milian Wolff wrote:
  Hey all,
  
  I try to configure my KF5 plasma environment similar to my old KDE4
  plasma.
  There, I could open even applications build into my custom prefix via
  krunner. I think, the important part was to set PATH there mostly to have
  that working. In KF5 now I'm greeted with this:
  
  KDEInit could not launch 'kwrite':
  Could not open library '/usr/lib/libkdeinit5_kwrite'.
  Cannot load library /usr/lib/libkdeinit5_kwrite:
  (/usr/lib/libkdeinit5_kwrite.so: cannot open shared object file: No such
  file or directory)
  
  This file is located in my prefix:
  /home/milian/projects/compiled/kf5/lib64
  What environment variable do I need to set for KRunner to find it?
 
 The error isn't about krunner but about kdeinit5, which can't find the .so
 to dlopen.
 
 I suggest debugging a bit in kinit.cpp, function launch(), to find out more,
 but it looks like this function is already getting a full path as input?
 
 You could try adding a lookup in LD_LIBRARY_PATH in that code, to make it
 more flexible --- or in the calling code, if indeed the problem is before
 that.
 
 Problem number 2: this kdeinit5 dlopen stuff is supposed to be optional,
 kdeinit should fallback to executing the binary, otherwise. I.e. this code
 is supposed to clear libpath and keep only execpath, and find it (kwrite)
 in $PATH.
 
 Happy debugging :-)

OK, thanks - that helped. I double-checked my environment and indeed the env 
script in ~/.config/plasma-workspace/env was wrong. I fixed it and not 
everything seems to work fine.

Bye
-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: What environment variable defines where krunner looks for libkdeinit5_$app.so

2015-06-06 Thread Elias Probst
On 06/06/2015 11:31 PM, David Faure wrote:
 Problem number 2: this kdeinit5 dlopen stuff is supposed to be optional, 
 kdeinit should fallback to executing the binary, otherwise. I.e. this code is 
 supposed to clear libpath and keep only execpath, and find it (kwrite) in 
 $PATH.

Related bug:
https://bugs.kde.org/show_bug.cgi?id=345175



signature.asc
Description: OpenPGP digital signature
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kdelibs4support master kf5-qt5 » OSX,clang - Build # 6 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/6/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master kf5-qt5 » OSX,clang - Build # 13 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/13/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: krunner master stable-kf5-qt5 » OSX,clang - Build # 5 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/krunner%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/5/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kio master stable-kf5-qt5 » OSX,clang - Build # 12 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/12/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kinit master stable-kf5-qt5 » OSX,clang - Build # 3 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/3/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kinit master kf5-qt5 » OSX,clang - Build # 3 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kinit%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/3/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: knotifications master stable-kf5-qt5 » OSX,clang - Build # 5 - Still Failing!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/5/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kinit master kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kinit%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: knotifications master kf5-qt5 » OSX,clang - Build # 4 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/knotifications%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/4/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: knotifications master stable-kf5-qt5 » OSX,clang - Build # 4 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/4/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Jenkins-kde-ci: kinit master stable-kf5-qt5 » OSX,clang - Build # 2 - Failure!

2015-06-06 Thread no-reply

 
 Check console output at 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/2/
 to view the results. 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel