Re: Review Request 124413: Enable PAM opening KWallet again
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- src/runtime/kwalletd/main.cpp (line 113) https://git.reviewboard.kde.org/r/124413/#comment57076 You should use strncmp instead of strcmp. src/runtime/kwalletd/main.cpp (line 126) https://git.reviewboard.kde.org/r/124413/#comment57078 You should use strtol() instead of atoi() for better error checking. atoi() does no error checking at all. src/runtime/kwalletd/main.cpp (line 129) https://git.reviewboard.kde.org/r/124413/#comment57077 environment src/runtime/kwalletd/main.cpp (line 144) https://git.reviewboard.kde.org/r/124413/#comment57079 You should deallocate hash here if it is not null, otherwise you have a memory leak. - Lamarque Souza On July 21, 2015, 3:52 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 3:52 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu. Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 18 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 17:00:43 + Build duration: 2.6 sec CHANGE SET No changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 18 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 17:00:43 + Build duration: 4 sec CHANGE SET No changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124413: Enable PAM opening KWallet again
On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 144 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line144 You should deallocate hash here if it is not null, otherwise you have a memory leak. Martin Klapetek wrote: I don't think so - the hash is init'ed as NULL; it is set by waitForHash() which either returns NULL (so hash stays NULL) or returns some data, at which point the code will not reach this line (can someone double check). Ah no I read it wrong, hash can be not null in here. I'll deallocate it. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- On July 21, 2015, 5:52 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 5:52 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu. Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124413: Enable PAM opening KWallet again
On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Why would you think? The whole string is being compared, what good would strncmp do in here? On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 126 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line126 You should use strtol() instead of atoi() for better error checking. atoi() does no error checking at all. ...but the code does not check for errors (and does not need to)? On July 21, 2015, 5:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 144 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line144 You should deallocate hash here if it is not null, otherwise you have a memory leak. I don't think so - the hash is init'ed as NULL; it is set by waitForHash() which either returns NULL (so hash stays NULL) or returns some data, at which point the code will not reach this line (can someone double check). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- On July 21, 2015, 5:52 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 5:52 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu. Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124413: Enable PAM opening KWallet again
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 7:27 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu. Changes --- Fix issues (as a side I'd like to point out that this patch was already reviewed once in https://git.reviewboard.kde.org/r/116555/ and I merely just cherry-pick the patch from kde-runtime) Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs (updated) - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 19 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 17:56:40 + Build duration: 1 min 52 sec CHANGE SET Revision b449460131aa342ff8405e508345957116b87baf by notmart: (add the userPaths context property) change: edit src/kpackagelauncherqml/main.cpp ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124413: Enable PAM opening KWallet again
On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string is being compared, what good would strncmp do in here? I was thinking about using something like if (strncmp(argv[x], --pam-login, sizeof(--pam-login))) It's a general rule not use use strcmp in security sensitive code since it only stops to compare characters when it finds a null character. If no such character exists in the compared string then you will have a buffer overflow. Since this is an argv string it probably contains a null byte, so the should and not have to. It is just recomendation, you can drop it if you wish. On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 126 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line126 You should use strtol() instead of atoi() for better error checking. atoi() does no error checking at all. Martin Klapetek wrote: ...but the code does not check for errors (and does not need to)? Actually, the error checking is done in line 135, so you can drop this one. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- On July 21, 2015, 5:27 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 5:27 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu. Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124413: Enable PAM opening KWallet again
On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string is being compared, what good would strncmp do in here? Lamarque Souza wrote: I was thinking about using something like if (strncmp(argv[x], --pam-login, sizeof(--pam-login))) It's a general rule not use use strcmp in security sensitive code since it only stops to compare characters when it finds a null character. If no such character exists in the compared string then you will have a buffer overflow. Since this is an argv string it probably contains a null byte, so the should and not have to. It is just recomendation, you can drop it if you wish. But --pam-login is null terminated, so you will compare at most sizeof(--pam-login) bytes anyway. - Stefan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- On July 21, 2015, 5:27 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 5:27 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu. Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 18:59:04 + Build duration: 47 sec CHANGE SET Revision 50c0a31944a40aecd05a564f23f7bd2d6a50614a by Martin Klapetek: (Fix the starting Y position for fallback popups) change: edit src/notifybypopup.cpp ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/ --- (Updated July 21, 2015, 6:39 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Changes --- Submitted with commit ba267253dbaeac32bb033e2f519d10651075c766 by Martin Klapetek to branch master. Repository: knotifications Description --- This patch reduces the dependencies of KNotifications framework and effectively makes it a tier 2 framework. KService is used only for locating additional notification plugins and to my knowledge, there are none such plugins currently existing, at least not in all around KDE plus the class for the plugins wasn't exported until about two months ago, so this should be safe without a legacy support. KIconThemes is used only to get KIconLoader::Small icon pixmap for notifications using KPassivePopup. After some playing around it turns out that it puts the icon into the KPassivePopup title and makes it as big as the text. So I've made the icon size to be the same as the text height. So this keeps things visually the same + still DPI aware, though I believe the KPassivePopup should receive a complete visual overhaul anyway. Additionally, KCodecs dependency has again one single usage for decoding html entities to QChars within QXmlStreamReader parser, so eventually could also be removed/replaced with QTextDocument::toPlainText() which seems to do the same job as QXmlStreamReader+KCodecs. Diffs - CMakeLists.txt 7b600a4 metainfo.yaml 7fc15f7 src/CMakeLists.txt 1cebece src/knotificationmanager.cpp 8d4f953 src/knotificationplugin.cpp 7315c17 src/notifybypopup.cpp bb96465 tests/kpassivepopuptest.h bc0dedc tests/kpassivepopuptest.cpp 2486fd8 Diff: https://git.reviewboard.kde.org/r/124281/diff/ Testing --- Everything still compiles + I added a test for KPassivePopup with an icon. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 16 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 21 Jul 2015 18:39:42 + Build duration: 1 min 12 sec CHANGE SET Revision ba267253dbaeac32bb033e2f519d10651075c766 by Martin Klapetek: (Remove KService and KIconThemes usage from KNotifications) change: edit CMakeLists.txt change: edit tests/kpassivepopuptest.h change: edit src/knotificationmanager.cpp change: edit src/CMakeLists.txt change: edit tests/kpassivepopuptest.cpp change: edit src/knotificationplugin.cpp change: edit metainfo.yaml change: edit src/notifybypopup.cpp ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124413: Enable PAM opening KWallet again
On July 21, 2015, 3:57 p.m., Lamarque Souza wrote: src/runtime/kwalletd/main.cpp, line 113 https://git.reviewboard.kde.org/r/124413/diff/1/?file=386596#file386596line113 You should use strncmp instead of strcmp. Martin Klapetek wrote: Why would you think? The whole string is being compared, what good would strncmp do in here? Lamarque Souza wrote: I was thinking about using something like if (strncmp(argv[x], --pam-login, sizeof(--pam-login))) It's a general rule not use use strcmp in security sensitive code since it only stops to compare characters when it finds a null character. If no such character exists in the compared string then you will have a buffer overflow. Since this is an argv string it probably contains a null byte, so the should and not have to. It is just recomendation, you can drop it if you wish. Stefan Brüns wrote: But --pam-login is null terminated, so you will compare at most sizeof(--pam-login) bytes anyway. Yeah, you're right. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/#review82770 --- On July 21, 2015, 5:27 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- (Updated July 21, 2015, 5:27 p.m.) Review request for KDE Frameworks, Àlex Fiestas and Valentin Rusu. Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124414: Fix kbuildsycoca5 --global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414/ --- Review request for KDE Frameworks. Repository: kservice Description --- Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME as first choice for GenericDataLocation and with --global it's set to - which is invalid path. kbuildsycoca5 attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in KConfig. ASSERT: QDir::isAbsolutePath(file) in file /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597 #5 0x7f6128c3c528 in raise () from /usr/lib/libc.so.6 #6 0x7f6128c3d93a in abort () from /usr/lib/libc.so.6 #7 0x7f61293c74a9 in qt_message_fatal (context=..., message=synthetic pointer) at global/qlogging.cpp:1578 #8 QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:781 #9 0x7f61293c05bc in qt_assert (assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), file=file@entry=0x7f6129cbfdf0 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line=line@entry=597) at global/qglobal.cpp:2968 #10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597 #11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609 #12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile (this=0x7ffc2f4d23e0, resourceType=QStandardPaths::GenericDataLocation, fileName=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54 #13 0x004214e1 in KBuildServiceFactory::createEntry (this=optimized out, file=...) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102 #14 0x00415358 in KBuildSycoca::createEntry (this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153 #15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273 #16 0x0041755d in KBuildSycoca::recreate (this=this@entry=0x1eb0950) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419 #17 0x00411636 in main (argc=3, argv=optimized out) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802 Diffs - src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 Diff: https://git.reviewboard.kde.org/r/124414/diff/ Testing --- Seems to be working, atleast doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124414: Fix kbuildsycoca5 --global
On jūlijs 22, 2015, 2:20 a.m., Aleix Pol Gonzalez wrote: src/kbuildsycoca/kbuildsycoca.cpp, line 686 https://git.reviewboard.kde.org/r/124414/diff/1/?file=386602#file386602line686 Would it work by using `qunsetenv`? It looks like XDG_DATA_HOME is just being invalidated here. Nope, it doesn't, if it's removed with qunsetenv or set empty then Qt will use ~/.local/share - Dāvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414/#review82795 --- On jūlijs 21, 2015, 11:51 p.m., Dāvis Mosāns wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414/ --- (Updated jūlijs 21, 2015, 11:51 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME as first choice for GenericDataLocation and with --global it's set to - which is invalid path. kbuildsycoca5 attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in KConfig. ASSERT: QDir::isAbsolutePath(file) in file /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597 #5 0x7f6128c3c528 in raise () from /usr/lib/libc.so.6 #6 0x7f6128c3d93a in abort () from /usr/lib/libc.so.6 #7 0x7f61293c74a9 in qt_message_fatal (context=..., message=synthetic pointer) at global/qlogging.cpp:1578 #8 QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:781 #9 0x7f61293c05bc in qt_assert (assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), file=file@entry=0x7f6129cbfdf0 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line=line@entry=597) at global/qglobal.cpp:2968 #10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597 #11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609 #12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile (this=0x7ffc2f4d23e0, resourceType=QStandardPaths::GenericDataLocation, fileName=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54 #13 0x004214e1 in KBuildServiceFactory::createEntry (this=optimized out, file=...) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102 #14 0x00415358 in KBuildSycoca::createEntry (this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153 #15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273 #16 0x0041755d in KBuildSycoca::recreate (this=this@entry=0x1eb0950) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419 #17 0x00411636 in main (argc=3, argv=optimized out) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802 Diffs - src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 Diff: https://git.reviewboard.kde.org/r/124414/diff/ Testing --- Seems to be working, atleast doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 124414: Fix kbuildsycoca5 --global
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414/#review82795 --- src/kbuildsycoca/kbuildsycoca.cpp (line 686) https://git.reviewboard.kde.org/r/124414/#comment57122 Would it work by using `qunsetenv`? It looks like XDG_DATA_HOME is just being invalidated here. - Aleix Pol Gonzalez On July 21, 2015, 10:51 p.m., Dāvis Mosāns wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414/ --- (Updated July 21, 2015, 10:51 p.m.) Review request for KDE Frameworks. Repository: kservice Description --- Currently kbuildsycoca5 --global does crash because Qt uses XDG_DATA_HOME as first choice for GenericDataLocation and with --global it's set to - which is invalid path. kbuildsycoca5 attempts to create -/kservices5/ksycoca5 which raises ASSERT failure in KConfig. ASSERT: QDir::isAbsolutePath(file) in file /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line 597 #5 0x7f6128c3c528 in raise () from /usr/lib/libc.so.6 #6 0x7f6128c3d93a in abort () from /usr/lib/libc.so.6 #7 0x7f61293c74a9 in qt_message_fatal (context=..., message=synthetic pointer) at global/qlogging.cpp:1578 #8 QMessageLogger::fatal (this=this@entry=0x7ffc2f4d2250, msg=msg@entry=0x7f61296345f0 ASSERT: \%s\ in file %s, line %d) at global/qlogging.cpp:781 #9 0x7f61293c05bc in qt_assert (assertion=assertion@entry=0x7f6129cbfea8 QDir::isAbsolutePath(file), file=file@entry=0x7f6129cbfdf0 /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp, line=line@entry=597) at global/qglobal.cpp:2968 #10 0x7f6129ca299f in KConfigIniBackend::setFilePath (this=0x1ecb360, file=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfigini.cpp:597 #11 0x7f6129c8bc5b in KConfigPrivate::changeFileName (this=0x1ed5af0, name=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kconfig.cpp:609 #12 0x7f6129ca9a2e in KDesktopFile::KDesktopFile (this=0x7ffc2f4d23e0, resourceType=QStandardPaths::GenericDataLocation, fileName=...) at /mnt/AUR/kconfig-git/src/kconfig/src/core/kdesktopfile.cpp:54 #13 0x004214e1 in KBuildServiceFactory::createEntry (this=optimized out, file=...) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildservicefactory.cpp:102 #14 0x00415358 in KBuildSycoca::createEntry (this=this@entry=0x1eb0950, file=..., addToFactory=addToFactory@entry=true) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:153 #15 0x00416d21 in KBuildSycoca::build (this=this@entry=0x1eb0950) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:273 #16 0x0041755d in KBuildSycoca::recreate (this=this@entry=0x1eb0950) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:419 #17 0x00411636 in main (argc=3, argv=optimized out) at /mnt/AUR/kservice-git/src/kbuildsycoca/kbuildsycoca.cpp:802 Diffs - src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 Diff: https://git.reviewboard.kde.org/r/124414/diff/ Testing --- Seems to be working, atleast doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 124413: Enable PAM opening KWallet again
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124413/ --- Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet Description --- This brings back Alex's patch in commit f2fe3e75b4ba12d0f99aa09327059a1865891b14 [1] which allows KWallet to be opened by PAM if kwallet-pam is present. http://quickgit.kde.org/?p=kde-runtime.gita=commith=f2fe3e75b4ba12d0f99aa09327059a1865891b14 Diffs - src/runtime/kwalletd/main.cpp b4e3837 Diff: https://git.reviewboard.kde.org/r/124413/diff/ Testing --- Logged in, KWallet does not ask for password anymore. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
