Review Request 124607: KService: detect ksycoca changing on disk without relying on the DBus signal.

2015-08-03 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124607/
---

Review request for KDE Frameworks and Vishesh Handa.


Repository: kservice


Description
---

This fixes threads without an event loop (e.g. in krunner) never noticing
changes in ksycoca.

Done-with: Vishesh Handa


Diffs
-

  autotests/ksycocathreadtest.cpp 0d6ed4b89581fc506ea79c32c1de314637decf3e 
  src/services/kmimetypetrader.cpp 655e5de9d272176e06af48a8417ea06e2412b9d8 
  src/services/kplugininfo.cpp 56dc0b43036a2a49804ff799360c29c2121dda54 
  src/services/kservice.cpp 3639a2875e5dbaefc6511d36d7b7f0fb7697ea74 
  src/services/kservicegroup.cpp a2905da347877ccf3466b63bd0eae518101f 
  src/services/kservicetype.cpp 5e71351e5b7a0acef96104d8d14fa5b27817595d 
  src/services/kservicetypetrader.cpp 290e44e9161c8db47278543714426fdd3b5a87af 
  src/sycoca/ksycoca.h 542029c7c21d495456065e51b485a26509152cd5 
  src/sycoca/ksycoca.cpp 32d1689ad9cd01d3a8adb5123a1848278714ca95 
  src/sycoca/ksycoca_p.h 393cfcf8f04c369ac9c03712d917c49112771838 

Diff: https://git.reviewboard.kde.org/r/124607/diff/


Testing
---

The improved unittest was failing with threadsWhoSawFakeService() always only 2 
out of 5 (the 2 threads with an event loop). Passes now.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 41 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 21:16:44 +
Build duration: 5 min 8 sec

CHANGE SET
Revision 2197c49ec2261d78962f43032970fe106d8c6b63 by Albert Astals Cid: (Kill 
unneeded QUrl wrappers)
  change: edit src/filewidgets/kfileplacesitem.cpp
  change: edit src/filewidgets/kfileplacesmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 23695/49667 
(48%)CONDITIONAL 12618/19438 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6624/7131 
(93%)CONDITIONAL 3430/6301 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7255/13961 
(52%)CONDITIONAL 3771/5267 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1841/7571 
(24%)CONDITIONAL 697/1091 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 423/836 (51%)CONDITIONAL 
309/454 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 694/1124 (62%)CONDITIONAL 
360/501 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
431/818 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 
87/110 (79%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 392/601 (65%)CONDITIONAL 
287/418 (69%)
src.kpasswdserver.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/279 (99%)CONDITIONAL 
141/246 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2583/10562 
(24%)CONDITIONAL 1235/1804 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 39 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 21:16:44 +
Build duration: 5 min 35 sec

CHANGE SET
Revision 2197c49ec2261d78962f43032970fe106d8c6b63 by Albert Astals Cid: (Kill 
unneeded QUrl wrappers)
  change: edit src/filewidgets/kfileplacesitem.cpp
  change: edit src/filewidgets/kfileplacesmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 23688/49667 
(48%)CONDITIONAL 12605/19430 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6624/7131 
(93%)CONDITIONAL 3430/6301 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7253/13961 
(52%)CONDITIONAL 3764/5265 (71%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1841/7571 
(24%)CONDITIONAL 696/1087 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 423/836 (51%)CONDITIONAL 
309/454 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 694/1124 (62%)CONDITIONAL 
360/501 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
431/818 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 
88/112 (79%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 387/601 (64%)CONDITIONAL 
283/414 (68%)
src.kpasswdserver.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/279 (99%)CONDITIONAL 
139/246 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2583/10562 
(24%)CONDITIONAL 1235/1804 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 38 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 20:31:04 +
Build duration: 13 min

CHANGE SET
Revision ee7406714eaa947df6465c076b6df0a25afa5668 by David Faure: 
(KFilePlacesModel: add unittest for externally-created file, based on the)
  change: edit autotests/kfileplacesmodeltest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 23701/49667 
(48%)CONDITIONAL 12631/19444 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6624/7131 
(93%)CONDITIONAL 3431/6301 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7256/13961 
(52%)CONDITIONAL 3777/5271 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1841/7571 
(24%)CONDITIONAL 697/1087 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 423/836 (51%)CONDITIONAL 
309/454 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 694/1124 (62%)CONDITIONAL 
360/501 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
431/818 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 
88/112 (79%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 397/601 (66%)CONDITIONAL 
292/422 (69%)
src.kpasswdserver.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/279 (99%)CONDITIONAL 
141/246 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2583/10562 
(24%)CONDITIONAL 1235/1804 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 40 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/40/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 20:31:04 +
Build duration: 12 min

CHANGE SET
Revision ee7406714eaa947df6465c076b6df0a25afa5668 by David Faure: 
(KFilePlacesModel: add unittest for externally-created file, based on the)
  change: edit autotests/kfileplacesmodeltest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 24067/49667 
(48%)CONDITIONAL 13009/20108 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6886/7131 
(97%)CONDITIONAL 3768/6919 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7290/13961 
(52%)CONDITIONAL 3787/5281 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1884/7571 
(25%)CONDITIONAL 718/ (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/836 (51%)CONDITIONAL 
313/456 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1124 (63%)CONDITIONAL 
367/507 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
432/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 
88/112 (79%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 392/601 (65%)CONDITIONAL 
287/418 (69%)
src.kpasswdserver.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/279 (99%)CONDITIONAL 
139/246 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2591/10562 
(25%)CONDITIONAL 1240/1810 (69%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124549: Fix date+releaseinfo in frameworks/kservice docbooks

2015-08-03 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124549/
---

(Updated Aug. 3, 2015, 8:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

Submitted with commit df94650b36e493603445c9d7366173c175e55ff6 by Burkhard Lück 
to branch master.


Repository: kservice


Description
---

Set date to last update/proofreading
Set releaseinfo to "Frameworks 5.x" where x is the corresponding frameworks 
version
Set productname to "KDE Frameworks"

Similar fixed are necessary for

kdelibs4support
kcontrol_kcm_ssl
kdebugdialog5
man-kf5-config.1

kio
man-kcookiejar5.8
help_documentationnotfound

kded
man-kded5.8

kinit
man-kdeinit5.8

kross
man-kf5kross.1

kdesignerplugin
man-kgendesignerplugin.1

kjs
man-kjs5.1.docbook

kjsembed
kjscmd5_man-kjscmd5.1

kpackagetool
man-kpackagetool5.1

kwallet
man-kwallet-query.1

plasma-frameworks
man-plasmapkg2.1

kconfigwidgets
man-preparetips5.1


Diffs
-

  docs/desktoptojson/man-desktoptojson.8.docbook 3751e3a 
  docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook 0f70d3c 

Diff: https://git.reviewboard.kde.org/r/124549/diff/


Testing
---

builds


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124549: Fix date+releaseinfo in frameworks/kservice docbooks

2015-08-03 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124549/#review83404
---

Ship it!


Ship It!

- David Faure


On Aug. 3, 2015, 2:20 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124549/
> ---
> 
> (Updated Aug. 3, 2015, 2:20 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> ---
> 
> Set date to last update/proofreading
> Set releaseinfo to "Frameworks 5.x" where x is the corresponding frameworks 
> version
> Set productname to "KDE Frameworks"
> 
> Similar fixed are necessary for
> 
> kdelibs4support
>   kcontrol_kcm_ssl
>   kdebugdialog5
>   man-kf5-config.1
> 
> kio
>   man-kcookiejar5.8
>   help_documentationnotfound
> 
> kded
>   man-kded5.8
> 
> kinit
>   man-kdeinit5.8
> 
> kross
>   man-kf5kross.1
> 
> kdesignerplugin
>   man-kgendesignerplugin.1
> 
> kjs
>   man-kjs5.1.docbook
> 
> kjsembed
>   kjscmd5_man-kjscmd5.1
> 
> kpackagetool
>   man-kpackagetool5.1
> 
> kwallet
>   man-kwallet-query.1
> 
> plasma-frameworks
>   man-plasmapkg2.1
> 
> kconfigwidgets
>   man-preparetips5.1
> 
> 
> Diffs
> -
> 
>   docs/desktoptojson/man-desktoptojson.8.docbook 3751e3a 
>   docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook 0f70d3c 
> 
> Diff: https://git.reviewboard.kde.org/r/124549/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [kwallet] /: Updating maintainer name

2015-08-03 Thread David Faure 
On Monday 03 August 2015 11:16:17 Lamarque Souza wrote:
> Does the maintainer field accept more than one identity?

That's the question. Go ahead and do that, Alex Merry volunteered
to fix kapidox if necessary :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 39 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 18:27:04 +
Build duration: 14 min

CHANGE SET
Revision 036d131c33e79258d8e79a2ea99790dd48909e30 by lueck: (add missing 
&language; to refentry; and change sentence about reporting)
  change: edit docs/kcookiejar5/man-kcookiejar5.8.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 24072/49656 
(48%)CONDITIONAL 12997/20088 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6880/7120 
(97%)CONDITIONAL 3746/6891 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7300/13961 
(52%)CONDITIONAL 3792/5285 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1880/7571 
(25%)CONDITIONAL 718/ (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/836 (51%)CONDITIONAL 
313/456 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1124 (63%)CONDITIONAL 
367/507 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
432/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 
88/112 (79%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 397/601 (66%)CONDITIONAL 
292/422 (69%)
src.kpasswdserver.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/279 (99%)CONDITIONAL 
139/246 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2591/10562 
(25%)CONDITIONAL 1240/1810 (69%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 37 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 18:27:04 +
Build duration: 6 min 20 sec

CHANGE SET
Revision 036d131c33e79258d8e79a2ea99790dd48909e30 by lueck: (add missing 
&language; to refentry; and change sentence about reporting)
  change: edit docs/kcookiejar5/man-kcookiejar5.8.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 
46 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 249/327 (76%)CLASSES 249/327 (76%)LINE 23662/49656 
(48%)CONDITIONAL 12585/19394 (65%)

By packages
  
autotests
FILES 59/59 (100%)CLASSES 59/59 (100%)LINE 6616/7120 
(93%)CONDITIONAL 3410/6273 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 475/476 
(100%)CONDITIONAL 166/272 (61%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 94/116 (81%)CLASSES 94/116 (81%)LINE 7255/13961 
(52%)CONDITIONAL 3769/5267 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 19/36 (53%)CLASSES 19/36 (53%)LINE 1831/7571 
(24%)CONDITIONAL 693/1087 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 423/836 (51%)CONDITIONAL 
309/454 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 750/3793 
(20%)CONDITIONAL 547/678 (81%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
600/756 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 679/1124 (60%)CONDITIONAL 
352/487 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
431/818 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 306/386 (79%)CONDITIONAL 
88/112 (79%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 392/601 (65%)CONDITIONAL 
287/418 (69%)
src.kpasswdserver.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 275/279 (99%)CONDITIONAL 
141/246 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 238/741 (32%)CONDITIONAL 
141/188 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 225/255 (88%)CONDITIONAL 
292/358 (82%)
src.widgets
FILES 28/60 (47%)CLASSES 28/60 (47%)LINE 2583/10562 
(24%)CONDITIONAL 1235/1804 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 14 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 18:18:39 +
Build duration: 1 min 41 sec

CHANGE SET
Revision 58edaf0b3c0250bc254b86364f508b617d98ccd5 by lueck: (add missing 
&language; to refentry; and change sentence about reporting)
  change: edit docs/kross/man-kf5kross.1.docbook


JUNIT RESULTS

Name: (root) Failed: 6 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.kross-guiform-pyFailed: 
TestSuite.kross-guiqt-pyFailed: TestSuite.kross-guitk-pyFailed: 
TestSuite.kross-test-pyFailed: TestSuite.kross-unittest-pyFailed: 
TestSuite.krossqtstest-test-es

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 18/22 (82%)CLASSES 18/22 (82%)LINE 660/1592 
(41%)CONDITIONAL 283/454 (62%)

By packages
  
autotests
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 165/365 (45%)CONDITIONAL 
60/86 (70%)
src.core
FILES 11/14 (79%)CLASSES 11/14 (79%)LINE 333/895 
(37%)CONDITIONAL 128/192 (67%)
src.qts
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 162/332 (49%)CONDITIONAL 
95/176 (54%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 13 - Still Unstable!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/13/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 18:18:39 +
Build duration: 2 min 11 sec

CHANGE SET
Revision 58edaf0b3c0250bc254b86364f508b617d98ccd5 by lueck: (add missing 
&language; to refentry; and change sentence about reporting)
  change: edit docs/kross/man-kf5kross.1.docbook


JUNIT RESULTS

Name: (root) Failed: 6 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.kross-guiform-pyFailed: 
TestSuite.kross-guiqt-pyFailed: TestSuite.kross-guitk-pyFailed: 
TestSuite.kross-test-pyFailed: TestSuite.kross-unittest-pyFailed: 
TestSuite.krossqtstest-test-es

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/3 (100%)FILES 18/22 (82%)CLASSES 18/22 (82%)LINE 660/1592 
(41%)CONDITIONAL 283/454 (62%)

By packages
  
autotests
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 165/365 (45%)CONDITIONAL 
60/86 (70%)
src.core
FILES 11/14 (79%)CLASSES 11/14 (79%)LINE 333/895 
(37%)CONDITIONAL 128/192 (67%)
src.qts
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 162/332 (49%)CONDITIONAL 
95/176 (54%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [kwallet] /: Updating maintainer name

2015-08-03 Thread Lamarque Souza 
Does the maintainer field accept more than one identity?

Lamarque V. Souza

http://planetkde.org/pt-br

On Mon, Aug 3, 2015 at 7:11 AM, Alex Merry  wrote:

> On Sunday 02 August 2015 19:31:36 David Faure wrote:
> > Are you sure about this? All other frameworks use the identity login name
> > there. This makes it possible (e.g. for api.kde.org) to determine full
> name
> > and email.
> >
> > I just noticed that modemmanager-qt and networkmanager-qt do it wrong
> >  -> cc'ing the maintainers.
> >
> > Compare
> >
> http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/index.html
> > where it's done right (identity login)
> >
> > and
> >
> http://api.kde.org/frameworks-api/frameworks5-apidocs/modemmanager-qt/html/i
> > ndex.html where it's not (falls back to "The KDE Community" when the
> > maintainer name is empty or unparseable).
> >
> > This being said, I don't know if kapidox supports multiple names in that
> > field, but it's worth a try.
>
> Well, if it doesn't we can easily fix that.
>
> Alex
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124549: Fix date+releaseinfo in frameworks/kservice docbooks

2015-08-03 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124549/
---

(Updated Aug. 3, 2015, 2:20 nachm.)


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

Add missing  lang="&language;" to refentry
Replace ~/.config with XDG_CONFIG_HOME
Change para about reporting bugs


Repository: kservice


Description
---

Set date to last update/proofreading
Set releaseinfo to "Frameworks 5.x" where x is the corresponding frameworks 
version
Set productname to "KDE Frameworks"

Similar fixed are necessary for

kdelibs4support
kcontrol_kcm_ssl
kdebugdialog5
man-kf5-config.1

kio
man-kcookiejar5.8
help_documentationnotfound

kded
man-kded5.8

kinit
man-kdeinit5.8

kross
man-kf5kross.1

kdesignerplugin
man-kgendesignerplugin.1

kjs
man-kjs5.1.docbook

kjsembed
kjscmd5_man-kjscmd5.1

kpackagetool
man-kpackagetool5.1

kwallet
man-kwallet-query.1

plasma-frameworks
man-plasmapkg2.1

kconfigwidgets
man-preparetips5.1


Diffs (updated)
-

  docs/desktoptojson/man-desktoptojson.8.docbook 3751e3a 
  docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook 0f70d3c 

Diff: https://git.reviewboard.kde.org/r/124549/diff/


Testing
---

builds


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124600: Update kdeinit5 docbook

2015-08-03 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124600/
---

(Updated Aug. 3, 2015, 1:39 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

Submitted with commit 07070f146ff256b9d7592cb9c6671b834fb8eba4 by Burkhard Lück 
to branch master.


Repository: kinit


Description
---

add missing lang="&language;" to refentry
fix title
fix date + releaseinfo
add productinfo

Hint:
There is no kdekillall in kf5 so far


Diffs
-

  docs/kdeinit5/man-kdeinit5.8.docbook 973207a 

Diff: https://git.reviewboard.kde.org/r/124600/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124600: Update kdeinit5 docbook

2015-08-03 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124600/#review83386
---

Ship it!


kdekillall is in kde-dev-scripts, but isn't very useful on linux, where killall 
works (there's special code in kdeinit to make it work).

- David Faure


On Aug. 3, 2015, 12:38 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124600/
> ---
> 
> (Updated Aug. 3, 2015, 12:38 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> add missing lang="&language;" to refentry
> fix title
> fix date + releaseinfo
> add productinfo
> 
> Hint:
> There is no kdekillall in kf5 so far
> 
> 
> Diffs
> -
> 
>   docs/kdeinit5/man-kdeinit5.8.docbook 973207a 
> 
> Diff: https://git.reviewboard.kde.org/r/124600/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124600: Update kdeinit5 docbook

2015-08-03 Thread David Faure 


> On Aug. 3, 2015, 9:15 a.m., David Faure wrote:
> > docs/kdeinit5/man-kdeinit5.8.docbook, line 241
> > 
> >
> > LOL, this is somewhat pessimistic ;)
> > I guess in 2008 it seemed that way indeed.
> 
> Burkhard Lück wrote:
> This para was added by jtamate with commit log "Not being so optimistic 
> about bugs..." in 2008
> to several kdelibs man page docbooks.
> This sentence is still in man-kjs5.1.docbook, 
> man-kbuildsycoca5.8.docbook, man-desktoptojson.8.docbook
> man-kcookiejar5.8.docbook, man-meinproc5.8.docbook, man-kded5.8.docbook, 
> man-kjscmd5.1.docbook 
> and man-kf5kross.1.docbook
> I'll change it for kdeinit5 to "Please use  url="http://bugs.kde.org";>KDE's bugtracker to report Bugs."
> The sentence should be changed for all other affected docbooks as well, 
> right?
> Is it ok to do that for the other docbook without review?

Yes.

(I think it should be "to report bugs", no uppercase 'B')


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124600/#review83361
---


On Aug. 3, 2015, 12:38 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124600/
> ---
> 
> (Updated Aug. 3, 2015, 12:38 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> add missing lang="&language;" to refentry
> fix title
> fix date + releaseinfo
> add productinfo
> 
> Hint:
> There is no kdekillall in kf5 so far
> 
> 
> Diffs
> -
> 
>   docs/kdeinit5/man-kdeinit5.8.docbook 973207a 
> 
> Diff: https://git.reviewboard.kde.org/r/124600/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124600: Update kdeinit5 docbook

2015-08-03 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124600/
---

(Updated Aug. 3, 2015, 12:38 nachm.)


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

Update diff with suggested changes by David, thanks for review.


Repository: kinit


Description
---

add missing lang="&language;" to refentry
fix title
fix date + releaseinfo
add productinfo

Hint:
There is no kdekillall in kf5 so far


Diffs (updated)
-

  docs/kdeinit5/man-kdeinit5.8.docbook 973207a 

Diff: https://git.reviewboard.kde.org/r/124600/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124600: Update kdeinit5 docbook

2015-08-03 Thread Burkhard Lück 


> On Aug. 3, 2015, 9:15 vorm., David Faure wrote:
> > docs/kdeinit5/man-kdeinit5.8.docbook, line 46
> > 
> >
> > This reads strangely. I suggest:
> > 
> > Launcher for applications built with kdeinit support, and for KIO 
> > slaves.
> > 
> > Or if it should stay short, then the original was OK (this is the 
> > process launcher developed by the KDE community)

"Launcher for applications built with kdeinit support, and for KIO slaves." is 
much better, will use it


> On Aug. 3, 2015, 9:15 vorm., David Faure wrote:
> > docs/kdeinit5/man-kdeinit5.8.docbook, line 241
> > 
> >
> > LOL, this is somewhat pessimistic ;)
> > I guess in 2008 it seemed that way indeed.

This para was added by jtamate with commit log "Not being so optimistic about 
bugs..." in 2008
to several kdelibs man page docbooks.
This sentence is still in man-kjs5.1.docbook, man-kbuildsycoca5.8.docbook, 
man-desktoptojson.8.docbook
man-kcookiejar5.8.docbook, man-meinproc5.8.docbook, man-kded5.8.docbook, 
man-kjscmd5.1.docbook 
and man-kf5kross.1.docbook
I'll change it for kdeinit5 to "Please use http://bugs.kde.org";>KDE's bugtracker to report Bugs."
The sentence should be changed for all other affected docbooks as well, right?
Is it ok to do that for the other docbook without review?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124600/#review83361
---


On Aug. 3, 2015, 6:29 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124600/
> ---
> 
> (Updated Aug. 3, 2015, 6:29 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> add missing lang="&language;" to refentry
> fix title
> fix date + releaseinfo
> add productinfo
> 
> Hint:
> There is no kdekillall in kf5 so far
> 
> 
> Diffs
> -
> 
>   docs/kdeinit5/man-kdeinit5.8.docbook 973207a 
> 
> Diff: https://git.reviewboard.kde.org/r/124600/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [kwallet] /: Updating maintainer name

2015-08-03 Thread Alex Merry 
On Sunday 02 August 2015 19:31:36 David Faure wrote:
> Are you sure about this? All other frameworks use the identity login name
> there. This makes it possible (e.g. for api.kde.org) to determine full name
> and email.
> 
> I just noticed that modemmanager-qt and networkmanager-qt do it wrong
>  -> cc'ing the maintainers.
> 
> Compare
> http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/index.html
> where it's done right (identity login)
> 
> and
> http://api.kde.org/frameworks-api/frameworks5-apidocs/modemmanager-qt/html/i
> ndex.html where it's not (falls back to "The KDE Community" when the
> maintainer name is empty or unparseable).
> 
> This being said, I don't know if kapidox supports multiple names in that
> field, but it's worth a try.

Well, if it doesn't we can easily fix that.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124596: KBookmarkManager: revert the port from KDirWatch to QFileSystemWatcher.

2015-08-03 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124596/
---

(Updated Aug. 3, 2015, 9:58 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Kevin Ottens.


Changes
---

Submitted with commit db935a4e2cffef6db045eabab821e24cc795808b by David Faure 
to branch master.


Repository: kbookmarks


Description
---

QFileSystemWatcher is not able to watch a file that doesn't exist yet,
it just says
QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No such 
file or directory
and that's the end of it.

We ported to QFileSystemWatcher to reduce deps, but in the end we kept
KDirWatch, in KCoreAddons.


Diffs
-

  src/kbookmarkmanager.cpp ad6af1ca0c87fe41fd4800ebf5d2924d3bd186fd 
  autotests/kbookmarktest.cpp 9a32c2a9e4e1c21ef5c6475f31ed1a67e0e627b4 
  autotests/kbookmarktest.h 2127ce89dde030beed2b680af9a0bc452962f4c8 

Diff: https://git.reviewboard.kde.org/r/124596/diff/


Testing
---

unittest added


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124596: KBookmarkManager: revert the port from KDirWatch to QFileSystemWatcher.

2015-08-03 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124596/#review83366
---

Ship it!


Ship It!

- Kevin Ottens


On Aug. 3, 2015, 9:11 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124596/
> ---
> 
> (Updated Aug. 3, 2015, 9:11 a.m.)
> 
> 
> Review request for KDE Frameworks and Kevin Ottens.
> 
> 
> Repository: kbookmarks
> 
> 
> Description
> ---
> 
> QFileSystemWatcher is not able to watch a file that doesn't exist yet,
> it just says
> QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No such 
> file or directory
> and that's the end of it.
> 
> We ported to QFileSystemWatcher to reduce deps, but in the end we kept
> KDirWatch, in KCoreAddons.
> 
> 
> Diffs
> -
> 
>   src/kbookmarkmanager.cpp ad6af1ca0c87fe41fd4800ebf5d2924d3bd186fd 
>   autotests/kbookmarktest.cpp 9a32c2a9e4e1c21ef5c6475f31ed1a67e0e627b4 
>   autotests/kbookmarktest.h 2127ce89dde030beed2b680af9a0bc452962f4c8 
> 
> Diff: https://git.reviewboard.kde.org/r/124596/diff/
> 
> 
> Testing
> ---
> 
> unittest added
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124397: Add today button to calendar

2015-08-03 Thread Martin Klapetek 


> On July 28, 2015, 10:37 p.m., Martin Klapetek wrote:
> > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 147-149
> > 
> >
> > Given this is only used here, would it make more sense to actually move 
> > the function here? Having it on the main item does not seem to bring any 
> > advantages...
> 
> Bernhard Friedreich wrote:
> resetToday in MonthView.qml is used for example by 
> org.kde.plasma.digitalclock/contents/ui/CalendarView.qml
> 
> I don't know where else it is also used..

Right, it's in MonthView.qml. So what's up with redeclaring the same function 
in DaysCalendar.qml line 59 in your patch?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review83118
---


On July 28, 2015, 10:32 p.m., Bernhard Friedreich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124397/
> ---
> 
> (Updated July 28, 2015, 10:32 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 348362
> http://bugs.kde.org/show_bug.cgi?id=348362
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Add button "Select Today" to calendar title bar
> 
> BUG: 348362
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml 
> 35a1e202ced1c050479ed04d71d8976a4e03a12c 
> 
> Diff: https://git.reviewboard.kde.org/r/124397/diff/
> 
> 
> Testing
> ---
> 
> plasmoidviewer with digitalclock plasmoid
> added digitalclock plasmoid to desktop
> 
> clicked digital clock plasmoid to view calendar
> "Select Today" button is shown
> select different day
> clicked button -> selection changes to today
> moved to another month/month selection/year/year selection -> clicked button 
> --> jumps to today
> 
> 
> File Attachments
> 
> 
> Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 27 - Fixed!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 09:17:14 +
Build duration: 3 min 55 sec

CHANGE SET
Revision 738276019e2ed30ffd03f4f3c586ba746287c244 by Marco Martin: (add the 
missing test files)
  change: edit autotests/quickviewsharedengine.cpp
  change: add autotests/data/resizemodeitem.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 692/1422 
(49%)CONDITIONAL 301/538 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 368/450 (82%)CONDITIONAL 
191/364 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 55/115 (48%)CONDITIONAL 
22/28 (79%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 86/253 (34%)CONDITIONAL 
22/36 (61%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 27 - Fixed!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 09:17:14 +
Build duration: 3 min 55 sec

CHANGE SET
Revision 738276019e2ed30ffd03f4f3c586ba746287c244 by Marco Martin: (add the 
missing test files)
  change: edit autotests/quickviewsharedengine.cpp
  change: add autotests/data/resizemodeitem.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 692/1422 
(49%)CONDITIONAL 301/538 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 368/450 (82%)CONDITIONAL 
191/364 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 55/115 (48%)CONDITIONAL 
22/28 (79%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 86/253 (34%)CONDITIONAL 
22/36 (61%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 09:17:14 +
Build duration: 3 min 1 sec

CHANGE SET
Revision 738276019e2ed30ffd03f4f3c586ba746287c244 by Marco Martin: (add the 
missing test files)
  change: edit autotests/quickviewsharedengine.cpp
  change: add autotests/data/resizemodeitem.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 692/1422 
(49%)CONDITIONAL 301/538 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 368/450 (82%)CONDITIONAL 
191/364 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 55/115 (48%)CONDITIONAL 
22/28 (79%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 86/253 (34%)CONDITIONAL 
22/36 (61%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 26 - Fixed!

2015-08-03 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/26/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 03 Aug 2015 09:17:14 +
Build duration: 3 min 1 sec

CHANGE SET
Revision 738276019e2ed30ffd03f4f3c586ba746287c244 by Marco Martin: (add the 
missing test files)
  change: edit autotests/quickviewsharedengine.cpp
  change: add autotests/data/resizemodeitem.qml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 20/25 (80%)CLASSES 20/25 (80%)LINE 692/1422 
(49%)CONDITIONAL 301/538 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 368/450 (82%)CONDITIONAL 
191/364 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/309 (50%)CONDITIONAL 
59/98 (60%)
src.kdeclarative.private
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 29/295 (10%)CONDITIONAL 
7/12 (58%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 55/115 (48%)CONDITIONAL 
22/28 (79%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 86/253 (34%)CONDITIONAL 
22/36 (61%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124600: Update kdeinit5 docbook

2015-08-03 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124600/#review83361
---



docs/kdeinit5/man-kdeinit5.8.docbook (line 46)


This reads strangely. I suggest:

Launcher for applications built with kdeinit support, and for KIO slaves.

Or if it should stay short, then the original was OK (this is the process 
launcher developed by the KDE community)



docs/kdeinit5/man-kdeinit5.8.docbook (line 241)


LOL, this is somewhat pessimistic ;)
I guess in 2008 it seemed that way indeed.


- David Faure


On Aug. 3, 2015, 6:29 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124600/
> ---
> 
> (Updated Aug. 3, 2015, 6:29 a.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> add missing lang="&language;" to refentry
> fix title
> fix date + releaseinfo
> add productinfo
> 
> Hint:
> There is no kdekillall in kf5 so far
> 
> 
> Diffs
> -
> 
>   docs/kdeinit5/man-kdeinit5.8.docbook 973207a 
> 
> Diff: https://git.reviewboard.kde.org/r/124600/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kdeclarative test still broken

2015-08-03 Thread Marco Martin 
On Saturday 01 August 2015, David Faure wrote:
> Hello, this is your friendly unit test police...
> 
> On Friday 31 July 2015 13:29:53 no-re...@kde.org wrote:
> > Build URL:
> > https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux
> > ,compiler=gcc/22/
> 
> That one is a real test failure.
> The "data" dir is missing.
> Marco: I already emailed you about that a month ago, please please give
> this the highest priority. Unittests should always pass, otherwise they're
> useless.
> 

sorry, I missed that email :/
i'm on it..

-- 
Marco Martin
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124556: Fix date+releaseinfo in frameworks/kded docbook

2015-08-03 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124556/
---

(Updated Aug. 3, 2015, 7:06 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Àlex Fiestas.


Changes
---

Submitted with commit 72c79bd50ea07d1bec1a167bb3612fc19f0b5bce by Burkhard Lück 
to branch master.


Repository: kded


Description
---

Set releaseinfo to "Frameworks 5.0"
Set productname to "KDE Frameworks"


Diffs
-

  docs/kded5/man-kded5.8.docbook 35aa1f1 

Diff: https://git.reviewboard.kde.org/r/124556/diff/


Testing
---

builds


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel