Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 54 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:09:39 + Build duration: 1 min 0 sec CHANGE SET Revision d7306b9ee88b17bacc8fb26933d48c8b51f9eca5 by David Faure: (add missing license after file splitting) change: edit src/kbuildsycoca/kbuildsycoca_main.cpp ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 53 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 3 min 22 sec CHANGE SET Revision 47572b8d86bdc8823b3fba074198b303f3031725 by David Faure: (fix build of the unittest, sorry about that) change: edit autotests/kmimeassociationstest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 73/82 (89%)CLASSES 73/82 (89%)LINE 5403/8007 (67%)CONDITIONAL 2759/4173 (66%) By packages autotests FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 1343/1437 (93%)CONDITIONAL 837/1508 (56%) src.kbuildsycoca FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 1426/1926 (74%)CONDITIONAL 781/1010 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1790/3091 (58%)CONDITIONAL 764/1129 (68%) src.sycoca FILES 13/14 (93%)CLASSES 13/14 (93%)LINE 686/1007 (68%)CONDITIONAL 307/426 (72%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 53 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 3 min 22 sec CHANGE SET Revision 47572b8d86bdc8823b3fba074198b303f3031725 by David Faure: (fix build of the unittest, sorry about that) change: edit autotests/kmimeassociationstest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 73/82 (89%)CLASSES 73/82 (89%)LINE 5403/8007 (67%)CONDITIONAL 2759/4173 (66%) By packages autotests FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 1343/1437 (93%)CONDITIONAL 837/1508 (56%) src.kbuildsycoca FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 1426/1926 (74%)CONDITIONAL 781/1010 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1790/3091 (58%)CONDITIONAL 764/1129 (68%) src.sycoca FILES 13/14 (93%)CLASSES 13/14 (93%)LINE 686/1007 (68%)CONDITIONAL 307/426 (72%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 1 min 56 sec CHANGE SET Revision 47572b8d86bdc8823b3fba074198b303f3031725 by David Faure: (fix build of the unittest, sorry about that) change: edit autotests/kmimeassociationstest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 73/82 (89%)CLASSES 73/82 (89%)LINE 5401/8007 (67%)CONDITIONAL 2755/4173 (66%) By packages autotests FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 1343/1437 (93%)CONDITIONAL 837/1508 (56%) src.kbuildsycoca FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 1425/1926 (74%)CONDITIONAL 780/1010 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1790/3091 (58%)CONDITIONAL 762/1129 (67%) src.sycoca FILES 13/14 (93%)CLASSES 13/14 (93%)LINE 685/1007 (68%)CONDITIONAL 306/426 (72%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 1 min 56 sec CHANGE SET Revision 47572b8d86bdc8823b3fba074198b303f3031725 by David Faure: (fix build of the unittest, sorry about that) change: edit autotests/kmimeassociationstest.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 73/82 (89%)CLASSES 73/82 (89%)LINE 5401/8007 (67%)CONDITIONAL 2755/4173 (66%) By packages autotests FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 1343/1437 (93%)CONDITIONAL 837/1508 (56%) src.kbuildsycoca FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 1425/1926 (74%)CONDITIONAL 780/1010 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1790/3091 (58%)CONDITIONAL 762/1129 (67%) src.sycoca FILES 13/14 (93%)CLASSES 13/14 (93%)LINE 685/1007 (68%)CONDITIONAL 306/426 (72%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 55 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:12:45 + Build duration: 2 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 73/82 (89%)CLASSES 73/82 (89%)LINE 5352/8007 (67%)CONDITIONAL 2747/4159 (66%) By packages autotests FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 1307/1437 (91%)CONDITIONAL 835/1504 (56%) src.kbuildsycoca FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 1428/1926 (74%)CONDITIONAL 781/1010 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1790/3091 (58%)CONDITIONAL 765/1129 (68%) src.sycoca FILES 13/14 (93%)CLASSES 13/14 (93%)LINE 669/1007 (66%)CONDITIONAL 296/416 (71%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 55 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:12:45 + Build duration: 2 min 7 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/7 (86%)FILES 73/82 (89%)CLASSES 73/82 (89%)LINE 5352/8007 (67%)CONDITIONAL 2747/4159 (66%) By packages autotests FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 1307/1437 (91%)CONDITIONAL 835/1504 (56%) src.kbuildsycoca FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 1428/1926 (74%)CONDITIONAL 781/1010 (77%) src.kdeinit FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/324 (0%)CONDITIONAL 0/0 (100%) src.plugin FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 48/101 (48%)CONDITIONAL 36/54 (67%) src.services FILES 28/29 (97%)CLASSES 28/29 (97%)LINE 1790/3091 (58%)CONDITIONAL 765/1129 (68%) src.sycoca FILES 13/14 (93%)CLASSES 13/14 (93%)LINE 669/1007 (66%)CONDITIONAL 296/416 (71%) tests.pluginlocator FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 110/121 (91%)CONDITIONAL 34/46 (74%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: QIcon::fromTheme(xxx, someFallback)
On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote: > > I tried to optimize it by 'caching' the isNull value in QIconPrivate. > > But then the test failed: > http://code.woboq.org/qt5/qtbase/tests/auto/gui/image/qicon/tst_qicon.cpp.html#633 > In that test, the "address-book-new" was looked before and cached, and then > we > expect that looking it up again after changing the theme name changes. > So cahcing the value of isNull would make the test fail, because it would be > cached as not null. Yes, the behaviour is that when changing the themeName, > existing QIcon will be re-looked-up next time we try to render them. One solution would be a "change counter" in the icon engine, incremented when changing themes. In QIcon, comparing a local number with that change counter, and skipping the cache if they don't match. But of course this means one more int per icon, so I don't know if it's a good idea. But yeah your isNull implementation looks fast enough; I was afraid it would be a call to availableSizes() like fromTheme was doing. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 86 - Aborted!
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 11:32:05 + Build duration: 0.75 sec CHANGE SET No changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 79 - Aborted!
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 11:32:05 + Build duration: 0.43 sec CHANGE SET No changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
folder icons where should they be set
salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file hardcoding a relevant icon now the question is where this sort of thing needs to be implemented in our tech to get all folder displaying things to display the correct icon. being my confused self I am rather clueless as to where the correct place to implement this is, so any help on this would be very welcome. thanks HS ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: QIcon::fromTheme(xxx, someFallback)
On Thu, September 10, 2015 09:16:11 David Faure wrote: > On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote: > > I tried to optimize it by 'caching' the isNull value in QIconPrivate. > > > > But then the test failed: > > http://code.woboq.org/qt5/qtbase/tests/auto/gui/image/qicon/tst_qicon.cpp. > > html#633 In that test, the "address-book-new" was looked before and > > cached, and then we expect that looking it up again after changing the > > theme name changes. So cahcing the value of isNull would make the test > > fail, because it would be cached as not null. Yes, the behaviour is that > > when changing the themeName, existing QIcon will be re-looked-up next > > time we try to render them. > One solution would be a "change counter" in the icon engine, incremented > when changing themes. In QIcon, comparing a local number with that change > counter, and skipping the cache if they don't match. But of course this > means one more int per icon, so I don't know if it's a good idea. It would only need a static int for QIcon's theme engine as a whole, no? In this case, for the "is null" cache. KSharedDataCache supports timestamping (in fact the timestamp is the only thing you're guaranteed to be able to always retrieve...), and it shouldn't be hard to track a change counter separately at a process-global perspective if needed for other aux caches. Regards, - Michael Pyne ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kservice Description --- 77a998e37 removed the call to KSycoca::disableAutoRebuild(), we can just check that we are in kbuildsycoca using qAppName like two other places in ksycoca.cpp already do. And this way get rid of more unnecessary "public" API for ksycoca. Diffs - src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 Diff: https://git.reviewboard.kde.org/r/125145/diff/ Testing --- compiles. we don't have a unittest for a corrupt ksycoca file ;) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125144: Provide enabled property for QIconItem.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125144/#review85135 --- Ship it! Looks good. How come this class is so undocumented? o.o - Aleix Pol Gonzalez On Sept. 10, 2015, 10:16 p.m., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125144/ > --- > > (Updated Sept. 10, 2015, 10:16 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: kdeclarative > > > Description > --- > > Adds the standard boolean property "enabled" to the icon component. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qiconitem.h > e030ea294f247b2e9bd57f213fe272a20afa4afc > src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp > 2a90c34318570aea52ca45ac701d73ef0083e2c2 > > Diff: https://git.reviewboard.kde.org/r/125144/diff/ > > > Testing > --- > > manual testing > > > Thanks, > > Andreas Cord-Landwehr > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125144: Provide enabled property for QIconItem.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125144/ --- Review request for KDE Frameworks and Marco Martin. Repository: kdeclarative Description --- Adds the standard boolean property "enabled" to the icon component. Diffs - src/qmlcontrols/kquickcontrolsaddons/qiconitem.h e030ea294f247b2e9bd57f213fe272a20afa4afc src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp 2a90c34318570aea52ca45ac701d73ef0083e2c2 Diff: https://git.reviewboard.kde.org/r/125144/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85136 --- What about removing s_autoRebuild and making KSycoca::disableAutoRebuild output a warning just in case someone weird out there is using it so they can get ready for KF6? - Albert Astals Cid On set. 10, 2015, 8:31 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125145/ > --- > > (Updated set. 10, 2015, 8:31 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > 77a998e37 removed the call to KSycoca::disableAutoRebuild(), > we can just check that we are in kbuildsycoca using qAppName > like two other places in ksycoca.cpp already do. > And this way get rid of more unnecessary "public" API for ksycoca. > > > Diffs > - > > src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 > src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 > > Diff: https://git.reviewboard.kde.org/r/125145/diff/ > > > Testing > --- > > compiles. > > we don't have a unittest for a corrupt ksycoca file ;) > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
> On Sept. 10, 2015, 8:39 p.m., Albert Astals Cid wrote: > > What about removing s_autoRebuild and making KSycoca::disableAutoRebuild > > output a warning just in case someone weird out there is using it so they > > can get ready for KF6? Good point, that's indeed the alternative. It's less behaviour-compatible, but for something marked as @internal and which only ever makes any difference on a corrupt database... nobody had any reason to call this indeed. Will do, thanks. And I should use the DEPRECATED macro too. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85136 --- On Sept. 10, 2015, 8:31 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125145/ > --- > > (Updated Sept. 10, 2015, 8:31 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > 77a998e37 removed the call to KSycoca::disableAutoRebuild(), > we can just check that we are in kbuildsycoca using qAppName > like two other places in ksycoca.cpp already do. > And this way get rid of more unnecessary "public" API for ksycoca. > > > Diffs > - > > src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 > src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 > > Diff: https://git.reviewboard.kde.org/r/125145/diff/ > > > Testing > --- > > compiles. > > we don't have a unittest for a corrupt ksycoca file ;) > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- (Updated Sept. 10, 2015, 8:51 p.m.) Review request for KDE Frameworks and Albert Astals Cid. Changes --- remove the static bool Repository: kservice Description (updated) --- 77a998e37 removed the call to KSycoca::disableAutoRebuild(), we can just check that we are in kbuildsycoca using qAppName like two other places in ksycoca.cpp already do. And this way get rid of more unnecessary "public" API for ksycoca. REVIEW: 125145 Diffs (updated) - src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 Diff: https://git.reviewboard.kde.org/r/125145/diff/ Testing --- compiles. we don't have a unittest for a corrupt ksycoca file ;) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85142 --- Ship it! Ship It! - Albert Astals Cid On set. 10, 2015, 8:51 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125145/ > --- > > (Updated set. 10, 2015, 8:51 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > 77a998e37 removed the call to KSycoca::disableAutoRebuild(), > we can just check that we are in kbuildsycoca using qAppName > like two other places in ksycoca.cpp already do. > And this way get rid of more unnecessary "public" API for ksycoca. > > REVIEW: 125145 > > > Diffs > - > > src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 > src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 > > Diff: https://git.reviewboard.kde.org/r/125145/diff/ > > > Testing > --- > > compiles. > > we don't have a unittest for a corrupt ksycoca file ;) > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 125148: Call parent ::event()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125148/ --- Review request for KDE Frameworks. Repository: kdelibs4support Description --- ::event() implementations need to call the parent ::event() otherwise things like deleteLater which is implemented in QObject::event won't work In this case it probably doesn't matter, but it's always good to have "good code" Diffs - src/kdecore/k3resolver.cpp 12b84df Diff: https://git.reviewboard.kde.org/r/125148/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- (Updated Sept. 10, 2015, 9:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Albert Astals Cid. Changes --- Submitted with commit 40d8500ab639a151b1655f6770493218bb2bf5ef by David Faure to branch master. Repository: kservice Description --- 77a998e37 removed the call to KSycoca::disableAutoRebuild(), we can just check that we are in kbuildsycoca using qAppName like two other places in ksycoca.cpp already do. And this way get rid of more unnecessary "public" API for ksycoca. REVIEW: 125145 Diffs - src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 Diff: https://git.reviewboard.kde.org/r/125145/diff/ Testing --- compiles. we don't have a unittest for a corrupt ksycoca file ;) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125121: Move checkGlobalHeader() within KBuildSycoca::recreate().
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125121/
---
(Updated Sept. 10, 2015, 6:39 a.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and Albert Astals Cid.
Changes
---
Submitted with commit 77a998e37bcd57908af79b96260f1577eb95d7fa by David Faure
to branch master.
Repository: kservice
Description
---
This leads to more self-contained API: recreate checks
if it can indeed reuse the existing sycoca or if it should skip it
(when language or $XDG_DATA_{HOME,DIRS} has changed)
And remove the call to clearCaches which closes KSycoca::self,
doesn't matter now that KBuildSycoca is a different instance anyway.
Diffs
-
src/kbuildsycoca/kbuildsycoca.h 65e4efb6d30ec57be1c5fd0d2a2b4dfcb7e760a7
src/kbuildsycoca/kbuildsycoca.cpp 3ce7ae425cfdfeac3264c5f4ecff440402402f7d
Diff: https://git.reviewboard.kde.org/r/125121/diff/
Testing
---
Wrote (and pushed) a new unittest (KSycocaTest::testOtherAppDir) for the case
where kbuildsycoca detects a mismatch in the global header. Works before and
after this patch.
Thanks,
David Faure
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125108: kbuildsycoca: remove code for --checkstamps and --nocheckfiles.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125108/ --- (Updated Sept. 10, 2015, 6:39 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Albert Astals Cid. Changes --- Submitted with commit b0c8fd8e64f6e02b781270e548c684a06e3e2948 by David Faure to branch master. Repository: kservice Description --- (the options are kept to avoid breaking hypothetic callers, but do nothing anymore) --checkstamps was a timestamp comparison to find out if kbuildsycoca should do nothing. Let's not just call it in that case ;) A similar timestamp check is in ksycoca.cpp since recently. --nocheckfiles was an experimental and marked dangerous option, to speed up KDE startup by only checking the global header (lang and dirs), but not checking for modified desktop files. I guess the idea was for binary packages to always ensure that ksycoca is updated. That's a very long term plan with a fdo desktop-file-index, but not really applicable until then (what if you install something from sources, on a distro set up that way...). Diffs - docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook 68e58db26262b7923adcdfc080bf18ffb7c805f6 src/kbuildsycoca/kbuildsycoca.cpp 3ce7ae425cfdfeac3264c5f4ecff440402402f7d Diff: https://git.reviewboard.kde.org/r/125108/diff/ Testing --- kservice unittests pass (but they don't really test these unused options ;) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 52 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 06:40:14 + Build duration: 1 min 53 sec CHANGE SET Revision b0c8fd8e64f6e02b781270e548c684a06e3e2948 by David Faure: (Remove code for --checkstamps and --nocheckfiles.) change: edit src/kbuildsycoca/kbuildsycoca.cpp change: edit docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook Revision 77a998e37bcd57908af79b96260f1577eb95d7fa by David Faure: (Move checkGlobalHeader() within KBuildSycoca::recreate().) change: edit src/kbuildsycoca/kbuildsycoca.h change: edit src/kbuildsycoca/kbuildsycoca.cpp Revision 584c115cfd88023b2e73d7ca93001605cdcdd878 by David Faure: (Move kbuildsycocas main to a separate file) change: edit src/kbuildsycoca/CMakeLists.txt change: edit src/kbuildsycoca/kbuildsycoca.cpp change: edit src/kbuildsycoca/kbuildsycoca.h change: add src/kbuildsycoca/kbuildsycoca_main.cpp Revision 365e891b62b510bdaa7edc270278a74b5a34e848 by David Faure: (Rename headers to _p.h in preparation for move to kservice library.) change: delete src/kbuildsycoca/vfolder_menu.h change: delete src/kbuildsycoca/kbuildmimetypefactory.h change: add src/kbuildsycoca/kbuildsycoca_p.h change: edit src/kbuildsycoca/kbuildservicefactory.cpp change: add src/kbuildsycoca/kbuildmimetypefactory_p.h change: add src/kbuildsycoca/kbuildservicetypefactory_p.h change: edit src/kbuildsycoca/kbuildsycoca_main.cpp change: edit src/kbuildsycoca/kbuildsycoca.cpp change: delete src/kbuildsycoca/ksycocaresourcelist.h change: delete src/kbuildsycoca/kmimeassociations.h change: edit src/kbuildsycoca/kbuildmimetypefactory.cpp change: add src/kbuildsycoca/vfolder_menu_p.h change: add src/kbuildsycoca/kbuildsycocainterface_p.h change: add src/kbuildsycoca/kbuildservicegroupfactory_p.h change: add src/kbuildsycoca/kbuildservicefactory_p.h change: edit src/kbuildsycoca/kbuildservicegroupfactory.cpp change: delete src/kbuildsycoca/kbuildservicefactory.h change: add src/kbuildsycoca/kctimefactory_p.h change: delete src/kbuildsycoca/kbuildservicegroupfactory.h change: edit src/kbuildsycoca/vfolder_menu.cpp change: delete src/kbuildsycoca/kctimefactory.h change: edit src/kbuildsycoca/kctimefactory.cpp change: edit src/kbuildsycoca/kbuildservicetypefactory.cpp change: add src/kbuildsycoca/ksycocaresourcelist_p.h change: delete src/kbuildsycoca/kbuildsycocainterface.h change: edit src/kbuildsycoca/kmimeassociations.cpp change: add src/kbuildsycoca/kmimeassociations_p.h change: delete src/kbuildsycoca/kbuildsycoca.h change: delete src/kbuildsycoca/kbuildservicetypefactory.h ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 52 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 06:40:14 + Build duration: 1 min 48 sec CHANGE SET Revision b0c8fd8e64f6e02b781270e548c684a06e3e2948 by David Faure: (Remove code for --checkstamps and --nocheckfiles.) change: edit src/kbuildsycoca/kbuildsycoca.cpp change: edit docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook Revision 77a998e37bcd57908af79b96260f1577eb95d7fa by David Faure: (Move checkGlobalHeader() within KBuildSycoca::recreate().) change: edit src/kbuildsycoca/kbuildsycoca.cpp change: edit src/kbuildsycoca/kbuildsycoca.h Revision 584c115cfd88023b2e73d7ca93001605cdcdd878 by David Faure: (Move kbuildsycocas main to a separate file) change: add src/kbuildsycoca/kbuildsycoca_main.cpp change: edit src/kbuildsycoca/CMakeLists.txt change: edit src/kbuildsycoca/kbuildsycoca.h change: edit src/kbuildsycoca/kbuildsycoca.cpp Revision 365e891b62b510bdaa7edc270278a74b5a34e848 by David Faure: (Rename headers to _p.h in preparation for move to kservice library.) change: add src/kbuildsycoca/ksycocaresourcelist_p.h change: add src/kbuildsycoca/kbuildservicefactory_p.h change: add src/kbuildsycoca/kbuildservicetypefactory_p.h change: add src/kbuildsycoca/kbuildsycocainterface_p.h change: edit src/kbuildsycoca/kmimeassociations.cpp change: add src/kbuildsycoca/vfolder_menu_p.h change: delete src/kbuildsycoca/kmimeassociations.h change: delete src/kbuildsycoca/kbuildservicefactory.h change: edit src/kbuildsycoca/kbuildsycoca_main.cpp change: delete src/kbuildsycoca/kbuildsycoca.h change: add src/kbuildsycoca/kmimeassociations_p.h change: delete src/kbuildsycoca/ksycocaresourcelist.h change: edit src/kbuildsycoca/kbuildservicegroupfactory.cpp change: add src/kbuildsycoca/kbuildservicegroupfactory_p.h change: edit src/kbuildsycoca/kctimefactory.cpp change: delete src/kbuildsycoca/kbuildservicetypefactory.h change: edit src/kbuildsycoca/vfolder_menu.cpp change: delete src/kbuildsycoca/vfolder_menu.h change: edit src/kbuildsycoca/kbuildsycoca.cpp change: add src/kbuildsycoca/kctimefactory_p.h change: delete src/kbuildsycoca/kbuildservicegroupfactory.h change: delete src/kbuildsycoca/kctimefactory.h change: edit src/kbuildsycoca/kbuildservicefactory.cpp change: delete src/kbuildsycoca/kbuildmimetypefactory.h change: add src/kbuildsycoca/kbuildsycoca_p.h change: edit src/kbuildsycoca/kbuildmimetypefactory.cpp change: add src/kbuildsycoca/kbuildmimetypefactory_p.h change: delete src/kbuildsycoca/kbuildsycocainterface.h change: edit src/kbuildsycoca/kbuildservicetypefactory.cpp ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
