Re: Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

2015-11-15 Thread René J . V . Bertin 


> On Nov. 15, 2015, 12:33 a.m., Aleix Pol Gonzalez wrote:
> > src/runtime/kwallet-query/src/CMakeLists.txt, line 20
> > 
> >
> > Why only for APPLE?
> 
> René J.V. Bertin wrote:
> Mostly because I didn't want to pretend to know the side-effects this 
> could have on platforms other than Linux and OS X ...
> 
> Aleix Pol Gonzalez wrote:
> That's not how it works. You don't improve kwallet on OS X, you improve 
> it everywhere. That's why it's a framework.
> 
> Also given the nature of `ecm_mark_nongui_executable` I don't see a 
> problem with having it on every platform. I can see how it can be useful on 
> other platforms, in fact. We need to minimize platfrom-specific code if we 
> want to have a viable cross-platform solution.

That reads as if I shouldn't bothering to improve the code on OS X if I don't 
also know how to improve it elsewhere, but somehow I don't think you wanted to 
say that. :)

The term `ecm_mark_nongui_executable` is not a happy choice, at least not on OS 
X where it only prevents the creation of an app bundle around the actual 
executable. That doesn't prevent the application from putting up a GUI at all, 
while the function suggests that is what could happen on other platforms. If 
you think that's not the case, then fine, I'll remove the conditional aspect.


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126069/#review88366
---


On Nov. 14, 2015, 10:29 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126069/
> ---
> 
> (Updated Nov. 14, 2015, 10:29 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Pending an overdue update to my OS X Keychain backend, this patch provides 
> better integration of the runtime:
> 
> - kwallet-query and kwalletd5 are built as regular executables, not app 
> bundles, making them easier to find via the shell and KService
> - kwalletd5 is modified to run as an agent, meaning it doesn't show up in the 
> Dock or App Switcher.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwallet-query/src/CMakeLists.txt 9ab9d9d 
>   src/runtime/kwalletd/CMakeLists.txt ba9e7ba 
>   src/runtime/kwalletd/main.cpp dd959b6 
> 
> Diff: https://git.reviewboard.kde.org/r/126069/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9 with Qt 5.5.0, in the 5.15.0 frameworks release version.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [OS X] should kauth-policy-gen be an app bundle?

2015-11-15 Thread Aleix Pol 
On Sun, Nov 15, 2015 at 12:38 PM, René J. V.  wrote:
> Aleix Pol wrote:
>
>
>> Not really, as anything installed in libexec.
>
> Is it OK to push the change to the respective CMakeLists.txt without doing a 
> RR
> first, and if so, is there any risk to changing this on all platforms instead 
> of
> only ifdef(APPLE) ?

Please make a RR, if you had done we I would have reviewed it instead
of replying to this e-mail.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

2015-11-15 Thread Aleix Pol Gonzalez 


> On Nov. 15, 2015, 12:33 a.m., Aleix Pol Gonzalez wrote:
> > src/runtime/kwallet-query/src/CMakeLists.txt, line 20
> > 
> >
> > Why only for APPLE?
> 
> René J.V. Bertin wrote:
> Mostly because I didn't want to pretend to know the side-effects this 
> could have on platforms other than Linux and OS X ...

That's not how it works. You don't improve kwallet on OS X, you improve it 
everywhere. That's why it's a framework.

Also given the nature of `ecm_mark_nongui_executable` I don't see a problem 
with having it on every platform. I can see how it can be useful on other 
platforms, in fact. We need to minimize platfrom-specific code if we want to 
have a viable cross-platform solution.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126069/#review88366
---


On Nov. 14, 2015, 10:29 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126069/
> ---
> 
> (Updated Nov. 14, 2015, 10:29 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> Pending an overdue update to my OS X Keychain backend, this patch provides 
> better integration of the runtime:
> 
> - kwallet-query and kwalletd5 are built as regular executables, not app 
> bundles, making them easier to find via the shell and KService
> - kwalletd5 is modified to run as an agent, meaning it doesn't show up in the 
> Dock or App Switcher.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwallet-query/src/CMakeLists.txt 9ab9d9d 
>   src/runtime/kwalletd/CMakeLists.txt ba9e7ba 
>   src/runtime/kwalletd/main.cpp dd959b6 
> 
> Diff: https://git.reviewboard.kde.org/r/126069/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9 with Qt 5.5.0, in the 5.15.0 frameworks release version.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-15 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/#review88390
---



src/plugins/osx/macpoller.h (line 31)


You removed Carbon from cmake, no?

I'm not sure why you're keeping both really. If IOKit is the way to go, 
then do it.


In fact, I'm quite sure that as is it already is broken without the #define

- Aleix Pol Gonzalez


On Nov. 15, 2015, 11:58 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126078/
> ---
> 
> (Updated Nov. 15, 2015, 11:58 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kidletime
> 
> 
> Description
> ---
> 
> I noticed that the KIdleTime example doesn't work properly on OS X, and that 
> the plugin for OS X still uses the deprecated Carbon-based algorithm that I 
> already patched for KDE4.
> 
> This patch is a work-in-progress (hence the qDebugs) update to use IOKit, 
> IORegistry and CoreServices to do idle-time calculation as it should be done, 
> and allow simulated user activity through a "less deprecated" function.
> 
> 
> Diffs
> -
> 
>   src/plugins/osx/macpoller.cpp ad9c10f 
>   src/plugins/osx/CMakeLists.txt e1b50b8 
>   src/plugins/osx/macpoller.h ef51ea5 
> 
> Diff: https://git.reviewboard.kde.org/r/126078/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .
> 
> The example now works: when I set a QTimer with interval==0, the expected 
> wait for user input (`resumingFromIdle` signal) works. However, I am getting 
> a `stopCatchingIdleEvents` signal which means the application waits forever, 
> without ever getting to compare idle time to the list of timeouts.
> I haven't been able to figure out where that signal comes from, nor why this 
> doesn't happen on Linux.
> 
> Surely I'm missing something, but what?
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-15 Thread René J . V . Bertin 


On Nov. 16, 2015, 12:19 a.m., René J.V. Bertin wrote:
> > In fact, I'm quite sure that as is it already is broken without the #define

Hmm? What do you think I broke that wasn't broken before (again, apart from the 
bare idle time detection, the original code doesn't work for me).

Anyway, I'm only keeping the Carbon code around as a reference until the new 
code works.


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126078/#review88390
---


On Nov. 15, 2015, 11:58 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126078/
> ---
> 
> (Updated Nov. 15, 2015, 11:58 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kidletime
> 
> 
> Description
> ---
> 
> I noticed that the KIdleTime example doesn't work properly on OS X, and that 
> the plugin for OS X still uses the deprecated Carbon-based algorithm that I 
> already patched for KDE4.
> 
> This patch is a work-in-progress (hence the qDebugs) update to use IOKit, 
> IORegistry and CoreServices to do idle-time calculation as it should be done, 
> and allow simulated user activity through a "less deprecated" function.
> 
> 
> Diffs
> -
> 
>   src/plugins/osx/macpoller.cpp ad9c10f 
>   src/plugins/osx/CMakeLists.txt e1b50b8 
>   src/plugins/osx/macpoller.h ef51ea5 
> 
> Diff: https://git.reviewboard.kde.org/r/126078/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9 with Qt 5.5.1 and frameworks 5.16.0 .
> 
> The example now works: when I set a QTimer with interval==0, the expected 
> wait for user input (`resumingFromIdle` signal) works. However, I am getting 
> a `stopCatchingIdleEvents` signal which means the application waits forever, 
> without ever getting to compare idle time to the list of timeouts.
> I haven't been able to figure out where that signal comes from, nor why this 
> doesn't happen on Linux.
> 
> Surely I'm missing something, but what?
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel